@adobe/helix-config 4.14.4 → 5.1.0

package/CHANGELOG.md

@@ -1,3 +1,22 @@
+# [5.1.0](https://github.com/adobe/helix-config/compare/v5.0.0...v5.1.0) (2025-04-04)
+
+
+### Features
+
+* support group references w/o .json ([#257](https://github.com/adobe/helix-config/issues/257)) ([013cb2a](https://github.com/adobe/helix-config/commit/013cb2a6f11cf8881966f97470c2a8eaeee81eb4)), closes [#256](https://github.com/adobe/helix-config/issues/256)
+
+# [5.0.0](https://github.com/adobe/helix-config/compare/v4.14.4...v5.0.0) (2025-04-03)
+
+
+### Bug Fixes
+
+* 404 for refs/branches that don't exist ([#254](https://github.com/adobe/helix-config/issues/254)) ([aa4a6fe](https://github.com/adobe/helix-config/commit/aa4a6fe99cb843ef61afa118a891b0d0c8c0382f))
+
+
+### BREAKING CHANGES
+
+* support for dirExists
+
 ## [4.14.4](https://github.com/adobe/helix-config/compare/v4.14.3...v4.14.4) (2025-03-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-config",
-  "version": "4.14.4",
+  "version": "5.1.0",
   "description": "Helix Config",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/S3Loader.d.ts

@@ -29,4 +29,13 @@ export declare interface S3Loader {
    * @param {string} key
    */
   headObject(bucketId, key): Promise<PipelineResponse>;
+
+  /**
+   * Check whether a directory (or prefix) exists in S3. Returns a 200
+   * status if it exists, or 404 if it doesn't.
+   * @param {string} bucketId
+   * @param {string} prefix
+   * @return {Promise<PipelineResponse>}
+   */
+  dirExists(bucketId: string, key: string): Promise<PipelineResponse>;
 }

package/src/config-legacy.js

@@ -113,7 +113,7 @@ async function resolveAdminAccess(ctx, admin) {
 
 /**
  * Loads the content from a helix 4 project.
- * @param {ConfigContext} ctx
+ * @param {import('./ConfigContext.js)'.ConfigContext} ctx
  * @param {RSO} rso
  * @param {string} scope
  * @returns {Promise<ConfigObject|null>} the config object or {@code null} if not found.

package/src/config-view.js

@@ -297,6 +297,13 @@ async function resolveConfig(ctx, rso, scope) {
   }
   const site = new ConfigObject();
   site.data = res.json();
+
+  const { code } = site.data;
+  const res2 = await ctx.loader.dirExists(HELIX_CODE_BUS, `${code.owner}/${code.repo}/${rso.ref}`);
+  if (res2.status !== 200) {
+    return null;
+  }
+
   site.updateLastModified(res.headers);
 
   // always load default profile if available
@@ -399,15 +406,21 @@ function computeSiteAdminRoles(admin, orgConfig, configGroups = {}) {
     for (const /* @type string */ entry of role) {
       if (entry.indexOf('@') > 0) {
         users.add(entry);
-      } else if (entry.startsWith('groups/') && entry.endsWith('.json')) {
+      } else if (entry.startsWith('groups/')) {
         // keep entry in list so that admin can auto-migrate updates to the groups json
         // TODO: remove after v4 EOL
         users.add(entry);
-        for (const email of resolveGroup(configGroups, entry.substring(7, entry.length - 5))) {
+        const reference = entry.endsWith('.json')
+          ? entry.substring(7, entry.length - 5)
+          : entry;
+        for (const email of resolveGroup(configGroups, reference)) {
           users.add(email);
         }
       } else if (entry.startsWith('/groups/')) {
-        for (const email of resolveGroup(orgGroups, entry.substring(8, entry.length - 5))) {
+        const reference = entry.endsWith('.json')
+          ? entry.substring(8, entry.length - 5)
+          : entry;
+        for (const email of resolveGroup(orgGroups, reference)) {
           users.add(email);
         }
       }