@adobe/helix-config 2.0.0 → 2.1.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.1.0](https://github.com/adobe/helix-config/compare/v2.0.0...v2.1.0) (2024-03-27)
+
+
+### Features
+
+* return 404 for missing branch ([#33](https://github.com/adobe/helix-config/issues/33)) ([b3ea0f4](https://github.com/adobe/helix-config/commit/b3ea0f419f34ee0a94b02b9a67c06c64eec06d2d))
+
 # [2.0.0](https://github.com/adobe/helix-config/compare/v1.3.3...v2.0.0) (2024-03-14)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-config",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "Helix Config",
   "main": "src/index.js",
   "types": "src/index.d.ts",
@@ -36,7 +36,7 @@
     "@adobe/eslint-config-helix": "2.0.6",
     "@semantic-release/changelog": "6.0.3",
     "@semantic-release/git": "10.0.1",
-    "@semantic-release/npm": "11.0.3",
+    "@semantic-release/npm": "12.0.0",
     "c8": "9.1.0",
     "eslint": "8.57.0",
     "husky": "9.0.11",

package/src/config-view.js

@@ -181,10 +181,14 @@ export async function getConfigResponse(ctx, opts) {
   } = opts;
   const rso = { ref, site, org };
   const config = await resolveConfig(ctx, rso, scope);
+  const surrogateHeaders = {
+    'x-surrogate-key': await getSurrogateKey(opts),
+  };
   if (!config) {
     return new PipelineResponse('', {
       status: 404,
       headers: {
+        ...surrogateHeaders,
         'x-error': 'config not found.',
       },
     });
@@ -203,15 +207,10 @@ export async function getConfigResponse(ctx, opts) {
     }
   }
 
-  const headers = {
-    'content-type': 'application/json',
-    'x-surrogate-key': await getSurrogateKey(opts),
-  };
-
   if (opts.scope === SCOPE_DELIVERY) {
     return new PipelineResponse('', {
       headers: {
-        'x-surrogate-key': await getSurrogateKey(opts),
+        ...surrogateHeaders,
         'x-hlx-contentbus-id': config.content.contentBusId,
         'x-hlx-owner': config.code.owner,
         'x-hlx-repo': config.code.repo,
@@ -237,11 +236,25 @@ export async function getConfigResponse(ctx, opts) {
       },
     };
     return new PipelineResponse(JSON.stringify(adminConfig, null, 2), {
-      headers,
+      headers: {
+        'content-type': 'application/json',
+        ...surrogateHeaders,
+      },
     });
   }
 
   if (opts.scope === SCOPE_PIPELINE) {
+    // validate that ref exists in code-bus
+    if (!config.head?.html) {
+      return new PipelineResponse('', {
+        status: 404,
+        headers: {
+          'x-error': 'ref does not exit (no head.html)',
+          ...surrogateHeaders,
+        },
+      });
+    }
+
     // remove all properties except `host`. pipeline doesn't need the others.
     retainProperty(config.cdn, 'host');
     const pipelineConfig = {
@@ -258,7 +271,10 @@ export async function getConfigResponse(ctx, opts) {
       folders: config.folders,
     };
     return new PipelineResponse(JSON.stringify(pipelineConfig, null, 2), {
-      headers,
+      headers: {
+        'content-type': 'application/json',
+        ...surrogateHeaders,
+      },
     });
   }
 
@@ -269,6 +285,9 @@ export async function getConfigResponse(ctx, opts) {
     public: {},
   };
   return new PipelineResponse(JSON.stringify(publicConfig, null, 2), {
-    headers,
+    headers: {
+      'content-type': 'application/json',
+      ...surrogateHeaders,
+    },
   });
 }