@adobe/helix-config-storage 2.1.6 → 2.1.7

package/.nycrc.json

@@ -1,10 +1,12 @@
 {
   "reporter": [
     "lcov",
-    "text"
+    "text",
+    "text-summary"
   ],
   "check-coverage": true,
   "lines": 100,
   "branches": 100,
-  "statements": 100
+  "statements": 100,
+  "skip-full": true
 }

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [2.1.7](https://github.com/adobe/helix-config-storage/compare/v2.1.6...v2.1.7) (2025-04-15)
+
+
+### Bug Fixes
+
+* reject duplicate users ([#114](https://github.com/adobe/helix-config-storage/issues/114)) ([5e064a0](https://github.com/adobe/helix-config-storage/commit/5e064a05fb213ebc1d86b77eea9c4680a7fb0096))
+
 ## [2.1.6](https://github.com/adobe/helix-config-storage/compare/v2.1.5...v2.1.6) (2025-04-10)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-config-storage",
-  "version": "2.1.6",
+  "version": "2.1.7",
   "description": "Helix Config Storage",
   "main": "src/index.js",
   "types": "src/index.d.ts",
@@ -46,7 +46,7 @@
     "husky": "9.1.7",
     "json-schema-to-typescript": "15.0.4",
     "junit-report-builder": "5.1.1",
-    "lint-staged": "15.5.0",
+    "lint-staged": "15.5.1",
     "mocha": "11.1.0",
     "mocha-multi-reporters": "1.5.1",
     "mocha-suppress-logs": "0.5.1",

package/src/config-store.js

@@ -246,6 +246,22 @@ function updateSecret(type, id, oldData, data) {
   return prune(oldData);
 }
 
+/**
+ * Ensures that the given email is not used by another user.
+ * @param {string} email
+ * @param {User[]} users
+ * @throws {StatusCodeError} a 400 status code error if the email is already used
+ */
+function validateUniqueEmail(email, users) {
+  if (!email) {
+    throw new StatusCodeError(400, 'missing email');
+  }
+  const existing = users.find((user) => user.email === email);
+  if (existing) {
+    throw new StatusCodeError(400, `email already in use by '${existing.id}'`);
+  }
+}
+
 /**
  * General purpose config store.
  */
@@ -593,6 +609,7 @@ export class ConfigStore {
         if (Array.isArray(data)) {
           const users = [...old.users];
           for (const userData of data) {
+            validateUniqueEmail(userData.email, users);
             users.push({
               ...createUser(),
               ...userData,
@@ -605,6 +622,7 @@ export class ConfigStore {
             ...data,
             ...user,
           };
+          validateUniqueEmail(data.email, old.users);
           frag.name = user.id;
           frag.relPath.push(user.id);
           frag.type = 'user';