@adobe/helix-config-storage 1.10.0 → 1.12.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [1.12.0](https://github.com/adobe/helix-config-storage/compare/v1.11.0...v1.12.0) (2024-12-11)
+
+
+### Features
+
+* require owner/repo for byo git ([#71](https://github.com/adobe/helix-config-storage/issues/71)) ([2d67b01](https://github.com/adobe/helix-config-storage/commit/2d67b01af1d1e16dfa569f5fb10b6e466873a47a))
+
+# [1.11.0](https://github.com/adobe/helix-config-storage/compare/v1.10.0...v1.11.0) (2024-12-10)
+
+
+### Features
+
+* lowercase hased owner ([#70](https://github.com/adobe/helix-config-storage/issues/70)) ([c40f038](https://github.com/adobe/helix-config-storage/commit/c40f03802e185d103a1b7a2771fdda672214de02))
+
 # [1.10.0](https://github.com/adobe/helix-config-storage/compare/v1.9.9...v1.10.0) (2024-12-10)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-config-storage",
-  "version": "1.10.0",
+  "version": "1.12.0",
   "description": "Helix Config Storage",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/ValidationError.js

@@ -55,7 +55,7 @@ function handleCDNProd(byPath, msg) {
 
 export class ValidationError extends Error {
   constructor(msg, errors = []) {
-    super(ValidationError.generateErrorDetail(errors));
+    super(ValidationError.generateErrorDetail(errors) || msg);
     this._errors = errors;
   }
 

package/src/schemas/code.schema.json

@@ -34,6 +34,14 @@
         "secretId": {
           "type": "string",
           "pattern":  "^[a-zA-Z0-9-_=]+$"
+        },
+        "owner": {
+          "type": "string",
+          "pattern": "^[a-zA-Z0-9_-]+$"
+        },
+        "repo": {
+          "type": "string",
+          "pattern": "^[a-zA-Z0-9_-]+$"
         }
       },
       "required": [

package/src/utils.js

@@ -14,6 +14,7 @@ import crypto from 'crypto';
 import { GitUrl } from '@adobe/helix-shared-git';
 import { decodeJwt } from 'jose';
 import { StatusCodeError } from './status-code-error.js';
+import { ValidationError } from './ValidationError.js';
 
 /**
  * Update the contentBusId field of the content object based on the source URL.
@@ -73,15 +74,21 @@ export function updateCodeSource(ctx, code) {
   if (code?.source?.url) {
     // recompute owner, repo and type
     code.source.type = 'github';
-    const url = new GitUrl(code.source.url);
-    let owner = url.owner.toLowerCase();
-    const repo = url.repo.toLowerCase();
+    const url = new URL(code.source.url);
+    let { owner, repo } = code.source;
     if (url.hostname !== 'github.com' && url.hostname !== 'www.github.com') {
+      if (!owner || !repo) {
+        throw new ValidationError('code.source.owner and code.source.repo are required for non github sources.');
+      }
       const hash = crypto
         .createHash('sha256')
         .update(url.hostname)
-        .digest('base64url');
+        .digest('base64url').toLowerCase();
       owner = `${hash}-${owner}`;
+    } else {
+      const gitUrl = new GitUrl(code.source.url);
+      owner = gitUrl.owner.toLowerCase();
+      repo = gitUrl.repo.toLowerCase();
     }
 
     if (owner !== code.owner) {