@adobe/data-lit 0.10.14 → 0.10.15

package/dist/hooks/component/hooks-controller.d.ts

@@ -1,36 +1,40 @@
 import type { Component } from "./component.js";
 /**
- * Give a hook host a real disconnect edge.
+ * Give a hook host a correct lifecycle by separating two concerns that the DOM
+ * connect/disconnect edge conflates.
  *
- * The hook model stores every effect's cleanup in `host.hooks[i].dispose`,
- * but {@link useEffect} only invokes it when dependencies change — never when
- * the element leaves the DOM. Left alone, every `useObservable` /
- * `useObservableValues` / `useEffect` subscription leaks on unmount and keeps
- * firing `requestUpdate` on a detached element. `useConnected` is likewise
- * inert because nothing dispatches the `"connected"` / `"disconnected"`
- * events it listens for.
+ * A hook host has two kinds of slot:
  *
- * This installs a single Lit {@link ReactiveController} — the one hook-friendly
- * path to a genuine `hostDisconnected` — that:
- *  - on disconnect, *schedules* (on a microtask) dispatching `"disconnected"`,
- *    disposing every hook slot, and clearing the cursor (full unmount semantics);
- *  - on connect, if a teardown is still pending it CANCELS it (the disconnect
- *    was half of a DOM move — hooks are intact, so nothing re-subscribes and no
- *    re-render is forced); otherwise it dispatches `"connected"` and, on a true
- *    reconnect, forces a re-render so the torn-down hooks re-initialize.
+ *  - **Value / subscription slots** — {@link useState}, {@link useRef},
+ *    {@link useMemo}, and effect-backed subscriptions ({@link useEffect},
+ *    {@link useObservable}, {@link useObservableValues}). These are *stateful*
+ *    and *expensive to rebuild*. They must SURVIVE a DOM move and be finalized
+ *    only when the element is genuinely gone.
+ *  - **Connectedness edges** — {@link useConnected}, the primitive for window /
+ *    document listeners, portals, drag sessions: things that track raw DOM
+ *    connectedness and must attach/detach *synchronously* on every edge.
  *
- * ## Why disposal is deferred
+ * The trap: the DOM fires `disconnectedCallback` then `connectedCallback`
+ * **synchronously, in the same task,** whenever a connected element is merely
+ * *moved* (a Lit `repeat` reorder, a list re-parenting, a drag-reorder). There
+ * is no synchronous signal that distinguishes a move from a genuine unmount, so
+ * this controller does not try to classify the edge. Instead it handles each
+ * concern with the policy that concern actually wants:
  *
- * The DOM fires `disconnectedCallback` then `connectedCallback` **synchronously,
- * in the same task,** whenever a connected element is merely *moved* — a Lit
- * `repeat` reorder, a list re-parenting, a drag-reorder. Disposing inline would
- * tear down and rebuild every subscription (re-running uncached producers) plus
- * force a re-render on every such move, with the hook state momentarily reset —
- * the studio-page lag, refresh churn, and transient empty lists on project
- * switch (FFP-111900). Deferring teardown one microtask lets a synchronous
- * reconnect distinguish a move (cancel) from a genuine unmount (let it run), so
- * a move is a no-op and only a real unmount disposes. A late reconnect (a
- * different task) is treated as unmount+remount, which is correct.
+ *  - **Edges fire synchronously, every time.** `hostConnected` /
+ *    `hostDisconnected` dispatch the `"connected"` / `"disconnected"` events
+ *    inline on every raw edge, so {@link useConnected} tears down and re-attaches
+ *    deterministically — including across a move (cheap, and exactly what a
+ *    listener/portal wants).
+ *  - **Slot finalization is deferred behind an `isConnected` re-check.** A
+ *    disconnect schedules a microtask; when it runs it disposes the slots only
+ *    if the host is STILL disconnected. A move has reconnected by then, so its
+ *    slots survive untouched — no re-subscribe, no state reset, no forced
+ *    re-render. A genuine unmount is still disconnected, so it finalizes,
+ *    preserving the unmount-leak fix.
+ *
+ * On a reconnect after a genuine finalization, the slots are empty, so the
+ * controller forces one `requestUpdate` to re-initialize them.
  *
  * It is installed lazily from inside the wrapped `render` (see {@link withHooks}),
  * which runs after `connectedCallback`, so `addController` fires `hostConnected`

package/dist/hooks/component/hooks-controller.js

@@ -9,58 +9,57 @@ function isReactiveHost(host) {
     return "addController" in host && typeof host.addController === "function";
 }
 /**
- * Dispose every effect-style hook slot and reset the hook cursor so the next
- * render re-initializes hooks from scratch. Only slots that expose a
- * `dispose` function (effects, subscriptions) are torn down; value slots
- * (state, memo, ref) are simply dropped.
+ * Finalize a host: dispose every hook slot's cleanup and clear the slots so the
+ * next render re-initializes from scratch. Only slots that expose a `dispose`
+ * function (effects, subscriptions) are torn down; value slots (state, memo,
+ * ref) are simply dropped.
  */
-function disposeHooks(host) {
+function finalizeHooks(host) {
     const { hooks } = host;
     if (hooks) {
         for (const hook of hooks) {
             hook?.dispose?.();
         }
     }
-    // Invariant: every live subscription (useEffect / useObservable / ...) exposes a
-    // `dispose` and is torn down in the loop above, so nothing should fire after this.
-    // A useState setter closure that still runs post-disconnect would write into the
-    // emptied array and requestUpdate a detached host. That signals an un-torn-down
-    // subscription (a bug at the subscription site), not something to guard here.
     host.hooks = [];
     host.hookIndex = 0;
 }
 /**
- * Give a hook host a real disconnect edge.
+ * Give a hook host a correct lifecycle by separating two concerns that the DOM
+ * connect/disconnect edge conflates.
  *
- * The hook model stores every effect's cleanup in `host.hooks[i].dispose`,
- * but {@link useEffect} only invokes it when dependencies change — never when
- * the element leaves the DOM. Left alone, every `useObservable` /
- * `useObservableValues` / `useEffect` subscription leaks on unmount and keeps
- * firing `requestUpdate` on a detached element. `useConnected` is likewise
- * inert because nothing dispatches the `"connected"` / `"disconnected"`
- * events it listens for.
+ * A hook host has two kinds of slot:
  *
- * This installs a single Lit {@link ReactiveController} — the one hook-friendly
- * path to a genuine `hostDisconnected` — that:
- *  - on disconnect, *schedules* (on a microtask) dispatching `"disconnected"`,
- *    disposing every hook slot, and clearing the cursor (full unmount semantics);
- *  - on connect, if a teardown is still pending it CANCELS it (the disconnect
- *    was half of a DOM move — hooks are intact, so nothing re-subscribes and no
- *    re-render is forced); otherwise it dispatches `"connected"` and, on a true
- *    reconnect, forces a re-render so the torn-down hooks re-initialize.
+ *  - **Value / subscription slots** — {@link useState}, {@link useRef},
+ *    {@link useMemo}, and effect-backed subscriptions ({@link useEffect},
+ *    {@link useObservable}, {@link useObservableValues}). These are *stateful*
+ *    and *expensive to rebuild*. They must SURVIVE a DOM move and be finalized
+ *    only when the element is genuinely gone.
+ *  - **Connectedness edges** — {@link useConnected}, the primitive for window /
+ *    document listeners, portals, drag sessions: things that track raw DOM
+ *    connectedness and must attach/detach *synchronously* on every edge.
  *
- * ## Why disposal is deferred
+ * The trap: the DOM fires `disconnectedCallback` then `connectedCallback`
+ * **synchronously, in the same task,** whenever a connected element is merely
+ * *moved* (a Lit `repeat` reorder, a list re-parenting, a drag-reorder). There
+ * is no synchronous signal that distinguishes a move from a genuine unmount, so
+ * this controller does not try to classify the edge. Instead it handles each
+ * concern with the policy that concern actually wants:
  *
- * The DOM fires `disconnectedCallback` then `connectedCallback` **synchronously,
- * in the same task,** whenever a connected element is merely *moved* — a Lit
- * `repeat` reorder, a list re-parenting, a drag-reorder. Disposing inline would
- * tear down and rebuild every subscription (re-running uncached producers) plus
- * force a re-render on every such move, with the hook state momentarily reset —
- * the studio-page lag, refresh churn, and transient empty lists on project
- * switch (FFP-111900). Deferring teardown one microtask lets a synchronous
- * reconnect distinguish a move (cancel) from a genuine unmount (let it run), so
- * a move is a no-op and only a real unmount disposes. A late reconnect (a
- * different task) is treated as unmount+remount, which is correct.
+ *  - **Edges fire synchronously, every time.** `hostConnected` /
+ *    `hostDisconnected` dispatch the `"connected"` / `"disconnected"` events
+ *    inline on every raw edge, so {@link useConnected} tears down and re-attaches
+ *    deterministically — including across a move (cheap, and exactly what a
+ *    listener/portal wants).
+ *  - **Slot finalization is deferred behind an `isConnected` re-check.** A
+ *    disconnect schedules a microtask; when it runs it disposes the slots only
+ *    if the host is STILL disconnected. A move has reconnected by then, so its
+ *    slots survive untouched — no re-subscribe, no state reset, no forced
+ *    re-render. A genuine unmount is still disconnected, so it finalizes,
+ *    preserving the unmount-leak fix.
+ *
+ * On a reconnect after a genuine finalization, the slots are empty, so the
+ * controller forces one `requestUpdate` to re-initialize them.
  *
  * It is installed lazily from inside the wrapped `render` (see {@link withHooks}),
  * which runs after `connectedCallback`, so `addController` fires `hostConnected`
@@ -77,42 +76,44 @@ export function installHooksController(host) {
     // addController fires hostConnected synchronously, and setting the flag first
     // guards against a re-entrant render re-installing a duplicate controller.
     host[HOOKS_CONTROLLER] = true;
-    let connectedOnce = false;
-    // True between a disconnect and its scheduled teardown. A reconnect that sees
-    // this flag set is the tail of a move and cancels the teardown.
-    let pendingDisposal = false;
+    // The slots were finalized (disposed + cleared) while the host was detached,
+    // so the next connect must re-render to re-initialize and re-subscribe them.
+    let finalized = false;
+    // A finalization microtask is already queued; don't queue a second.
+    let finalizationQueued = false;
     const controller = {
         hostConnected() {
-            if (pendingDisposal) {
-                // Tail of a MOVE: the just-fired disconnect scheduled a teardown that
-                // has not run yet. Cancel it — the hooks are untouched, so there is
-                // nothing to re-subscribe and no reason to force a re-render.
-                pendingDisposal = false;
-                return;
-            }
-            // The "connected" / "disconnected" events are for EXTERNAL listeners only.
-            // The internal useConnected does NOT depend on them: this fires before the
-            // render body attaches any listener, so useConnected is driven by its direct
-            // isConnected check plus useEffect cleanup instead.
+            // Fire the connect edge synchronously on EVERY connect (mount / move /
+            // remount) so edge hooks (useConnected) run their setup deterministically.
             host.dispatchEvent(new Event("connected"));
-            if (connectedOnce) {
-                // Reconnect: the previous disconnect disposed and cleared every
-                // hook slot, so re-render to re-run hooks and re-subscribe.
+            if (finalized) {
+                // The host was fully finalized while detached (a genuine unmount): its
+                // slots are empty, so re-render to re-initialize and re-subscribe them.
+                finalized = false;
                 host.requestUpdate();
             }
-            connectedOnce = true;
         },
         hostDisconnected() {
-            // Defer teardown one microtask so a synchronous reconnect (a DOM move)
-            // can cancel it above. Only a genuine unmount reaches the callback.
-            pendingDisposal = true;
+            // Fire the disconnect edge synchronously on EVERY disconnect (unmount /
+            // move) so edge hooks tear down synchronously.
+            host.dispatchEvent(new Event("disconnected"));
+            // Defer slot finalization behind an isConnected re-check: a DOM move has
+            // reconnected by the time the microtask runs, so its value/subscription
+            // slots survive untouched; only a genuine unmount (still detached) is
+            // finalized. This is what keeps a move from churning subscriptions while
+            // still disposing them on a real unmount.
+            if (finalizationQueued) {
+                return;
+            }
+            finalizationQueued = true;
             queueMicrotask(() => {
-                if (!pendingDisposal) {
+                finalizationQueued = false;
+                if (host.isConnected) {
+                    // Moved / reconnected within the task — keep every slot alive.
                     return;
                 }
-                pendingDisposal = false;
-                host.dispatchEvent(new Event("disconnected"));
-                disposeHooks(host);
+                finalizeHooks(host);
+                finalized = true;
             });
         },
     };

package/dist/hooks/component/hooks-controller.js.map

@@ -1 +1 @@
-{"version":3,"file":"hooks-controller.js","sourceRoot":"","sources":["../../../src/hooks/component/hooks-controller.ts"],"names":[],"mappings":"AAAA,uDAAuD;AAKvD;;;;GAIG;AACH,MAAM,gBAAgB,GAAG,MAAM,CAAC,0BAA0B,CAAC,CAAC;AAI5D,SAAS,cAAc,CAAC,IAAe;IACnC,OAAO,eAAe,IAAI,IAAI,IAAI,OAAO,IAAI,CAAC,aAAa,KAAK,UAAU,CAAC;AAC/E,CAAC;AAED;;;;;GAKG;AACH,SAAS,YAAY,CAAC,IAAe;IACjC,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC;IACvB,IAAI,KAAK,EAAE,CAAC;QACR,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACtB,IAA6C,EAAE,OAAO,EAAE,EAAE,CAAC;QAChE,CAAC;IACL,CAAC;IACD,iFAAiF;IACjF,mFAAmF;IACnF,iFAAiF;IACjF,gFAAgF;IAChF,8EAA8E;IAC9E,IAAI,CAAC,KAAK,GAAG,EAAE,CAAC;IAChB,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;AACvB,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAuCG;AACH,MAAM,UAAU,sBAAsB,CAAC,IAAe;IAClD,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,gBAAgB,CAAC,EAAE,CAAC;QAClD,OAAO;IACX,CAAC;IACD,0EAA0E;IAC1E,8EAA8E;IAC9E,2EAA2E;IAC3E,IAAI,CAAC,gBAAgB,CAAC,GAAG,IAAI,CAAC;IAE9B,IAAI,aAAa,GAAG,KAAK,CAAC;IAC1B,8EAA8E;IAC9E,gEAAgE;IAChE,IAAI,eAAe,GAAG,KAAK,CAAC;IAC5B,MAAM,UAAU,GAAuB;QACnC,aAAa;YACT,IAAI,eAAe,EAAE,CAAC;gBAClB,sEAAsE;gBACtE,oEAAoE;gBACpE,8DAA8D;gBAC9D,eAAe,GAAG,KAAK,CAAC;gBACxB,OAAO;YACX,CAAC;YACD,2EAA2E;YAC3E,2EAA2E;YAC3E,6EAA6E;YAC7E,oDAAoD;YACpD,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC;YAC3C,IAAI,aAAa,EAAE,CAAC;gBAChB,gEAAgE;gBAChE,4DAA4D;gBAC5D,IAAI,CAAC,aAAa,EAAE,CAAC;YACzB,CAAC;YACD,aAAa,GAAG,IAAI,CAAC;QACzB,CAAC;QACD,gBAAgB;YACZ,uEAAuE;YACvE,oEAAoE;YACpE,eAAe,GAAG,IAAI,CAAC;YACvB,cAAc,CAAC,GAAG,EAAE;gBAChB,IAAI,CAAC,eAAe,EAAE,CAAC;oBACnB,OAAO;gBACX,CAAC;gBACD,eAAe,GAAG,KAAK,CAAC;gBACxB,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,cAAc,CAAC,CAAC,CAAC;gBAC9C,YAAY,CAAC,IAAI,CAAC,CAAC;YACvB,CAAC,CAAC,CAAC;QACP,CAAC;KACJ,CAAC;IACF,IAAI,CAAC;QACD,IAAI,CAAC,aAAa,CAAC,UAAU,CAAC,CAAC;IACnC,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACb,4EAA4E;QAC5E,2EAA2E;QAC3E,IAAI,CAAC,gBAAgB,CAAC,GAAG,SAAS,CAAC;QACnC,MAAM,KAAK,CAAC;IAChB,CAAC;AACL,CAAC"}
+{"version":3,"file":"hooks-controller.js","sourceRoot":"","sources":["../../../src/hooks/component/hooks-controller.ts"],"names":[],"mappings":"AAAA,uDAAuD;AAKvD;;;;GAIG;AACH,MAAM,gBAAgB,GAAG,MAAM,CAAC,0BAA0B,CAAC,CAAC;AAI5D,SAAS,cAAc,CAAC,IAAe;IACnC,OAAO,eAAe,IAAI,IAAI,IAAI,OAAO,IAAI,CAAC,aAAa,KAAK,UAAU,CAAC;AAC/E,CAAC;AAED;;;;;GAKG;AACH,SAAS,aAAa,CAAC,IAAe;IAClC,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC;IACvB,IAAI,KAAK,EAAE,CAAC;QACR,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACtB,IAA6C,EAAE,OAAO,EAAE,EAAE,CAAC;QAChE,CAAC;IACL,CAAC;IACD,IAAI,CAAC,KAAK,GAAG,EAAE,CAAC;IAChB,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;AACvB,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA2CG;AACH,MAAM,UAAU,sBAAsB,CAAC,IAAe;IAClD,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,gBAAgB,CAAC,EAAE,CAAC;QAClD,OAAO;IACX,CAAC;IACD,0EAA0E;IAC1E,8EAA8E;IAC9E,2EAA2E;IAC3E,IAAI,CAAC,gBAAgB,CAAC,GAAG,IAAI,CAAC;IAE9B,6EAA6E;IAC7E,6EAA6E;IAC7E,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,oEAAoE;IACpE,IAAI,kBAAkB,GAAG,KAAK,CAAC;IAE/B,MAAM,UAAU,GAAuB;QACnC,aAAa;YACT,uEAAuE;YACvE,2EAA2E;YAC3E,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC;YAC3C,IAAI,SAAS,EAAE,CAAC;gBACZ,uEAAuE;gBACvE,wEAAwE;gBACxE,SAAS,GAAG,KAAK,CAAC;gBAClB,IAAI,CAAC,aAAa,EAAE,CAAC;YACzB,CAAC;QACL,CAAC;QACD,gBAAgB;YACZ,wEAAwE;YACxE,+CAA+C;YAC/C,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,CAAC,cAAc,CAAC,CAAC,CAAC;YAC9C,yEAAyE;YACzE,wEAAwE;YACxE,sEAAsE;YACtE,yEAAyE;YACzE,0CAA0C;YAC1C,IAAI,kBAAkB,EAAE,CAAC;gBACrB,OAAO;YACX,CAAC;YACD,kBAAkB,GAAG,IAAI,CAAC;YAC1B,cAAc,CAAC,GAAG,EAAE;gBAChB,kBAAkB,GAAG,KAAK,CAAC;gBAC3B,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;oBACnB,+DAA+D;oBAC/D,OAAO;gBACX,CAAC;gBACD,aAAa,CAAC,IAAI,CAAC,CAAC;gBACpB,SAAS,GAAG,IAAI,CAAC;YACrB,CAAC,CAAC,CAAC;QACP,CAAC;KACJ,CAAC;IACF,IAAI,CAAC;QACD,IAAI,CAAC,aAAa,CAAC,UAAU,CAAC,CAAC;IACnC,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACb,4EAA4E;QAC5E,2EAA2E;QAC3E,IAAI,CAAC,gBAAgB,CAAC,GAAG,SAAS,CAAC;QACnC,MAAM,KAAK,CAAC;IAChB,CAAC;AACL,CAAC"}

package/dist/hooks/component/hooks-controller.test.js

@@ -4,8 +4,10 @@ import { installHooksController } from "./hooks-controller.js";
 /**
  * Minimal stand-in for a Lit host: an EventTarget that captures the controller
  * installed on it so the test can drive `hostConnected` / `hostDisconnected`
- * directly (a real Lit element would need a DOM). `addController` mirrors Lit's
- * contract of firing `hostConnected` synchronously when already connected.
+ * directly (a real Lit element would need a DOM). `connect()` / `disconnect()`
+ * flip `isConnected` BEFORE dispatching, mirroring the DOM (the callback runs
+ * after connectedness has already changed) — the controller's deferred
+ * finalization reads `isConnected` to tell a move from a genuine unmount.
  */
 class FakeHost extends EventTarget {
     constructor() {
@@ -20,20 +22,21 @@ class FakeHost extends EventTarget {
     addController(controller) {
         this.controllers.push(controller);
     }
-    // Simulate Lit dispatching lifecycle to every registered controller.
     connect() {
+        this.isConnected = true;
         for (const c of this.controllers)
             c.hostConnected?.();
     }
     disconnect() {
+        this.isConnected = false;
         for (const c of this.controllers)
             c.hostDisconnected?.();
     }
 }
-/** Resolves after the current microtask checkpoint, so deferred teardown can run. */
+/** Resolves after the current microtask checkpoint, so deferred finalization can run. */
 const flushMicrotasks = () => new Promise(resolve => queueMicrotask(resolve));
 describe("installHooksController", () => {
-    it("disposes every effect hook and resets the cursor on a genuine disconnect", async () => {
+    it("finalizes every effect hook and resets the cursor on a genuine disconnect", async () => {
         const host = new FakeHost();
         const disposeA = vi.fn();
         const disposeB = vi.fn();
@@ -46,52 +49,82 @@ describe("installHooksController", () => {
         host.hookIndex = 4;
         installHooksController(host);
         host.disconnect();
-        // Teardown is deferred one microtask (so a move can cancel it); with no
-        // reconnect this is a real unmount, so it runs on the next checkpoint.
+        // Finalization is deferred one microtask (so a move can cancel it); with no
+        // reconnect the host is still disconnected, so it runs on the next checkpoint.
         await flushMicrotasks();
         expect(disposeA).toHaveBeenCalledTimes(1);
         expect(disposeB).toHaveBeenCalledTimes(1);
         expect(host.hooks).toEqual([]);
         expect(host.hookIndex).toBe(0);
     });
-    it("a synchronous disconnect→reconnect (a MOVE) cancels teardown and forces no re-render", async () => {
+    it("fires the connect / disconnect EDGE synchronously — no microtask needed", () => {
+        const host = new FakeHost();
+        const onConnected = vi.fn();
+        const onDisconnected = vi.fn();
+        host.addEventListener("connected", onConnected);
+        host.addEventListener("disconnected", onDisconnected);
+        installHooksController(host);
+        host.connect();
+        expect(onConnected).toHaveBeenCalledTimes(1);
+        host.disconnect();
+        // No flush: the edge is synchronous so connectedness hooks (useConnected)
+        // tear down inline. Under the old defer-everything controller this event
+        // only fired on a later microtask.
+        expect(onDisconnected).toHaveBeenCalledTimes(1);
+    });
+    it("fires disconnect THEN connect synchronously across a MOVE, and does NOT finalize", async () => {
         const host = new FakeHost();
         const dispose = vi.fn();
         host.hooks = [{ dispose, dependencies: [] }];
         host.hookIndex = 1;
+        const edges = [];
+        host.addEventListener("disconnected", () => edges.push("disconnect"));
+        host.addEventListener("connected", () => edges.push("connect"));
         installHooksController(host);
-        host.connect(); // first mount
         host.requestUpdate.mockClear();
-        // Disconnect immediately followed by reconnect, same task — a DOM move.
+        // Move: disconnect immediately followed by reconnect, same task.
         host.disconnect();
         host.connect();
+        expect(edges).toEqual(["disconnect", "connect"]); // both edges, synchronous, in order
         await flushMicrotasks();
-        // Nothing was torn down and no re-render was forced: the hooks survived.
+        // The slot survived: not disposed, and no re-render was forced.
         expect(dispose).not.toHaveBeenCalled();
         expect(host.hooks).toHaveLength(1);
         expect(host.requestUpdate).not.toHaveBeenCalled();
     });
-    it("dispatches connected / disconnected events across the lifecycle", async () => {
+    it("a rapid disconnect→connect→disconnect bounce finalizes exactly once (net state wins)", async () => {
         const host = new FakeHost();
-        const onConnected = vi.fn();
-        const onDisconnected = vi.fn();
-        host.addEventListener("connected", onConnected);
-        host.addEventListener("disconnected", onDisconnected);
+        const dispose = vi.fn();
+        host.hooks = [{ dispose, dependencies: [] }];
         installHooksController(host);
+        // Bounce within one task: only one finalization microtask is queued, and it
+        // reads the final isConnected (false) → finalizes once, not per disconnect.
+        host.disconnect();
         host.connect();
-        expect(onConnected).toHaveBeenCalledTimes(1);
         host.disconnect();
         await flushMicrotasks();
-        expect(onDisconnected).toHaveBeenCalledTimes(1);
+        expect(dispose).toHaveBeenCalledTimes(1);
+        expect(host.hooks).toEqual([]);
+    });
+    it("gates finalization on isConnected — a slot that reconnects before the microtask survives", async () => {
+        const host = new FakeHost();
+        const dispose = vi.fn();
+        host.hooks = [{ dispose, dependencies: [] }];
+        installHooksController(host);
+        host.disconnect(); // schedules finalization; isConnected now false
+        host.connect(); // reconnects in the same task; isConnected back to true
+        await flushMicrotasks();
+        expect(dispose).not.toHaveBeenCalled();
+        expect(host.hooks).toHaveLength(1);
     });
-    it("forces a re-render only on a genuine RE-connect, not the first connect", async () => {
+    it("forces a re-render only on a genuine RE-connect, not the first connect or a move", async () => {
         const host = new FakeHost();
         installHooksController(host);
         host.connect(); // first mount
         expect(host.requestUpdate).not.toHaveBeenCalled();
         host.disconnect();
-        await flushMicrotasks(); // genuine unmount: teardown runs
-        host.connect(); // reconnect re-initializes the torn-down hooks
+        await flushMicrotasks(); // genuine unmount: finalization runs
+        host.connect(); // reconnect must re-initialize the finalized hooks
         expect(host.requestUpdate).toHaveBeenCalledTimes(1);
     });
     it("is idempotent — repeated installs register a single controller", () => {

package/dist/hooks/component/hooks-controller.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"hooks-controller.test.js","sourceRoot":"","sources":["../../../src/hooks/component/hooks-controller.test.ts"],"names":[],"mappings":"AAAA,uDAAuD;AACvD,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAGlD,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAE/D;;;;;GAKG;AACH,MAAM,QAAS,SAAQ,WAAW;IAAlC;;QACI,gBAAW,GAAG,IAAI,CAAC;QACnB,cAAS,GAAG,CAAC,CAAC;QACd,UAAK,GAAU,EAAE,CAAC;QAClB,qBAAgB,GAAG,IAAI,GAAG,EAAc,CAAC;QACzC,kBAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,gBAAW,GAAyB,EAAE,CAAC;IAY3C,CAAC;IAVG,aAAa,CAAC,UAA8B;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACtC,CAAC;IACD,qEAAqE;IACrE,OAAO;QACH,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,WAAW;YAAE,CAAC,CAAC,aAAa,EAAE,EAAE,CAAC;IAC1D,CAAC;IACD,UAAU;QACN,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,WAAW;YAAE,CAAC,CAAC,gBAAgB,EAAE,EAAE,CAAC;IAC7D,CAAC;CACJ;AAED,qFAAqF;AACrF,MAAM,eAAe,GAAG,GAAkB,EAAE,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC,CAAC;AAE7F,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACpC,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACtF,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACzB,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACzB,IAAI,CAAC,KAAK,GAAG;YACT,EAAE,OAAO,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,EAAE;YACvC,EAAE,EAAE,uDAAuD;YAC3D,EAAE,OAAO,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,EAAE;YACvC,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,0BAA0B;SAChD,CAAC;QACF,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;QAEnB,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,wEAAwE;QACxE,uEAAuE;QACvE,MAAM,eAAe,EAAE,CAAC;QAExB,MAAM,CAAC,QAAQ,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC1C,MAAM,CAAC,QAAQ,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC1C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACnC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sFAAsF,EAAE,KAAK,IAAI,EAAE;QAClG,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,IAAI,CAAC,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC,CAAC;QAC7C,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;QAEnB,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,cAAc;QAC9B,IAAI,CAAC,aAAa,CAAC,SAAS,EAAE,CAAC;QAE/B,wEAAwE;QACxE,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,IAAI,CAAC,OAAO,EAAE,CAAC;QACf,MAAM,eAAe,EAAE,CAAC;QAExB,yEAAyE;QACzE,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;QAC7E,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5B,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC/B,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC;QAChD,IAAI,CAAC,gBAAgB,CAAC,cAAc,EAAE,cAAc,CAAC,CAAC;QAEtD,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,OAAO,EAAE,CAAC;QACf,MAAM,CAAC,WAAW,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAE7C,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,MAAM,eAAe,EAAE,CAAC;QACxB,MAAM,CAAC,cAAc,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wEAAwE,EAAE,KAAK,IAAI,EAAE;QACpF,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAE7B,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,cAAc;QAC9B,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAElD,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,MAAM,eAAe,EAAE,CAAC,CAAC,iCAAiC;QAC1D,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,+CAA+C;QAC/D,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACtE,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC1D,MAAM,IAAI,GAAG,IAAI,WAAW,EAA0B,CAAC;QACvD,MAAM,CAAC,GAAG,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC;IAC7D,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}
+{"version":3,"file":"hooks-controller.test.js","sourceRoot":"","sources":["../../../src/hooks/component/hooks-controller.test.ts"],"names":[],"mappings":"AAAA,uDAAuD;AACvD,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAGlD,OAAO,EAAE,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAE/D;;;;;;;GAOG;AACH,MAAM,QAAS,SAAQ,WAAW;IAAlC;;QACI,gBAAW,GAAG,IAAI,CAAC;QACnB,cAAS,GAAG,CAAC,CAAC;QACd,UAAK,GAAU,EAAE,CAAC;QAClB,qBAAgB,GAAG,IAAI,GAAG,EAAc,CAAC;QACzC,kBAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,gBAAW,GAAyB,EAAE,CAAC;IAa3C,CAAC;IAXG,aAAa,CAAC,UAA8B;QACxC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACtC,CAAC;IACD,OAAO;QACH,IAAI,CAAC,WAAW,GAAG,IAAI,CAAC;QACxB,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,WAAW;YAAE,CAAC,CAAC,aAAa,EAAE,EAAE,CAAC;IAC1D,CAAC;IACD,UAAU;QACN,IAAI,CAAC,WAAW,GAAG,KAAK,CAAC;QACzB,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,WAAW;YAAE,CAAC,CAAC,gBAAgB,EAAE,EAAE,CAAC;IAC7D,CAAC;CACJ;AAED,yFAAyF;AACzF,MAAM,eAAe,GAAG,GAAkB,EAAE,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC,CAAC;AAE7F,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACpC,EAAE,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;QACvF,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACzB,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACzB,IAAI,CAAC,KAAK,GAAG;YACT,EAAE,OAAO,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,EAAE;YACvC,EAAE,EAAE,uDAAuD;YAC3D,EAAE,OAAO,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,EAAE;YACvC,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,0BAA0B;SAChD,CAAC;QACF,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;QAEnB,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,4EAA4E;QAC5E,+EAA+E;QAC/E,MAAM,eAAe,EAAE,CAAC;QAExB,MAAM,CAAC,QAAQ,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC1C,MAAM,CAAC,QAAQ,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC1C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC/B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACnC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QAC/E,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5B,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC/B,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC;QAChD,IAAI,CAAC,gBAAgB,CAAC,cAAc,EAAE,cAAc,CAAC,CAAC;QAEtD,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,OAAO,EAAE,CAAC;QACf,MAAM,CAAC,WAAW,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAE7C,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,0EAA0E;QAC1E,yEAAyE;QACzE,mCAAmC;QACnC,MAAM,CAAC,cAAc,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kFAAkF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,IAAI,CAAC,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC,CAAC;QAC7C,IAAI,CAAC,SAAS,GAAG,CAAC,CAAC;QACnB,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,IAAI,CAAC,gBAAgB,CAAC,cAAc,EAAE,GAAG,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;QACtE,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,GAAG,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC;QAEhE,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,aAAa,CAAC,SAAS,EAAE,CAAC;QAE/B,iEAAiE;QACjE,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,IAAI,CAAC,OAAO,EAAE,CAAC;QACf,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,YAAY,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,oCAAoC;QAEtF,MAAM,eAAe,EAAE,CAAC;QACxB,gEAAgE;QAChE,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sFAAsF,EAAE,KAAK,IAAI,EAAE;QAClG,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,IAAI,CAAC,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC,CAAC;QAE7C,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,4EAA4E;QAC5E,4EAA4E;QAC5E,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,IAAI,CAAC,OAAO,EAAE,CAAC;QACf,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,MAAM,eAAe,EAAE,CAAC;QAExB,MAAM,CAAC,OAAO,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QACzC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACnC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0FAA0F,EAAE,KAAK,IAAI,EAAE;QACtG,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACxB,IAAI,CAAC,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,YAAY,EAAE,EAAE,EAAE,CAAC,CAAC;QAE7C,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,IAAI,CAAC,UAAU,EAAE,CAAC,CAAC,gDAAgD;QACnE,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,wDAAwD;QACxE,MAAM,eAAe,EAAE,CAAC;QAExB,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kFAAkF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAE7B,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,cAAc;QAC9B,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAElD,IAAI,CAAC,UAAU,EAAE,CAAC;QAClB,MAAM,eAAe,EAAE,CAAC,CAAC,qCAAqC;QAC9D,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,mDAAmD;QACnE,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACtE,MAAM,IAAI,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC5B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC1D,MAAM,IAAI,GAAG,IAAI,WAAW,EAA0B,CAAC;QACvD,MAAM,CAAC,GAAG,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC;IAC7D,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/dist/hooks/component/hooks-lifecycle.integration.test.d.ts

@@ -0,0 +1 @@
+export {};