@adobe/alloy 2.29.0-beta.2 → 2.29.0-beta.4

package/libEs5/components/Advertising/createComponent.js

@@ -23,9 +23,6 @@ var _default = ({
   getBrowser
 }) => {
   const componentConfig = config.advertising;
-  const sharedState = {
-    processedAdvertisingIds: false
-  };
   const sendAdConversionHandler = (0, _sendAdConversion.default)({
     eventManager,
     cookieManager,
@@ -37,7 +34,7 @@ var _default = ({
   return {
     lifecycle: {
       onComponentsRegistered() {
-        sendAdConversionHandler(sharedState);
+        return sendAdConversionHandler();
       },
       onBeforeEvent: ({
         event,
@@ -46,7 +43,6 @@ var _default = ({
         return (0, _onBeforeSendEventHandler.default)({
           cookieManager,
           logger,
-          state: sharedState,
           event,
           componentConfig,
           advertising,

package/libEs5/components/Advertising/handlers/sendAdConversion.js

@@ -34,11 +34,11 @@ var _default = ({
       skwcid,
       efid
     } = (0, _helpers.getUrlParams)();
-    const isClickThru = !!(skwcid && efid);
+    const isClickThru = !!(skwcid || efid);
     try {
-      let result = null;
       if (isClickThru) {
-        result = await (0, _clickThroughHandler.default)({
+        // wait for click through to complete
+        return (0, _clickThroughHandler.default)({
           eventManager,
           cookieManager,
           adConversionHandler,
@@ -46,19 +46,17 @@ var _default = ({
           skwcid,
           efid
         });
-        return result;
       } else if (activeAdvertiserIds) {
-        result = await (0, _viewThroughHandler.default)({
+        // fire and forget view through
+        (0, _viewThroughHandler.default)({
           eventManager,
           cookieManager,
           logger,
           componentConfig,
           adConversionHandler,
           getBrowser
-        });
-        return result;
+        }).catch(error => logger.error("Error in view through:", error));
       }
-      return null;
     } catch (error) {
       logger.error("Error in sendAdConversion:", error);
     }

package/libEs5/components/Advertising/handlers/viewThroughHandler.js

@@ -46,11 +46,11 @@ async function handleViewThrough({
   const identityPromises = Object.entries(identityPromisesMap).map(([idType, idPromise]) => idPromise.then(idValue => {
     if (idValue) {
       resolvedIds[idType] = idValue;
-      return triggerConversion(); // Return the promise directly
+      return triggerConversion();
     }
   }).catch(error => {
     logger.error(_index.LOG_ERROR_RESOLVING_ID.replace("{0}", idType), error);
     return null;
   }));
-  return Promise.allSettled(identityPromises); // Remove the separate conversionTasks handling
+  return Promise.allSettled(identityPromises);
 }

package/libEs5/constants/libraryVersion.js

@@ -14,4 +14,4 @@ governing permissions and limitations under the License.
 */
 // The __VERSION__ keyword will be replace at alloy build time with the package.json version.
 // see babel-plugin-version
-var _default = exports.default = "2.29.0-beta.2";
+var _default = exports.default = "2.29.0-beta.4";

package/libEs6/components/Advertising/createComponent.js

@@ -21,9 +21,6 @@ export default ({
   getBrowser
 }) => {
   const componentConfig = config.advertising;
-  const sharedState = {
-    processedAdvertisingIds: false
-  };
   const sendAdConversionHandler = createSendAdConversion({
     eventManager,
     cookieManager,
@@ -35,7 +32,7 @@ export default ({
   return {
     lifecycle: {
       onComponentsRegistered() {
-        sendAdConversionHandler(sharedState);
+        return sendAdConversionHandler();
       },
       onBeforeEvent: ({
         event,
@@ -44,7 +41,6 @@ export default ({
         return handleOnBeforeSendEvent({
           cookieManager,
           logger,
-          state: sharedState,
           event,
           componentConfig,
           advertising,

package/libEs6/components/Advertising/handlers/sendAdConversion.js

@@ -33,11 +33,11 @@ export default ({
       skwcid,
       efid
     } = getUrlParams();
-    const isClickThru = !!(skwcid && efid);
+    const isClickThru = !!(skwcid || efid);
     try {
-      let result = null;
       if (isClickThru) {
-        result = await handleClickThrough({
+        // wait for click through to complete
+        return handleClickThrough({
           eventManager,
           cookieManager,
           adConversionHandler,
@@ -45,19 +45,17 @@ export default ({
           skwcid,
           efid
         });
-        return result;
       } else if (activeAdvertiserIds) {
-        result = await handleViewThrough({
+        // fire and forget view through
+        handleViewThrough({
           eventManager,
           cookieManager,
           logger,
           componentConfig,
           adConversionHandler,
           getBrowser
-        });
-        return result;
+        }).catch(error => logger.error("Error in view through:", error));
       }
-      return null;
     } catch (error) {
       logger.error("Error in sendAdConversion:", error);
     }

package/libEs6/components/Advertising/handlers/viewThroughHandler.js

@@ -43,11 +43,11 @@ export default async function handleViewThrough({
   const identityPromises = Object.entries(identityPromisesMap).map(([idType, idPromise]) => idPromise.then(idValue => {
     if (idValue) {
       resolvedIds[idType] = idValue;
-      return triggerConversion(); // Return the promise directly
+      return triggerConversion();
     }
   }).catch(error => {
     logger.error(LOG_ERROR_RESOLVING_ID.replace("{0}", idType), error);
     return null;
   }));
-  return Promise.allSettled(identityPromises); // Remove the separate conversionTasks handling
+  return Promise.allSettled(identityPromises);
 }

package/libEs6/constants/libraryVersion.js

@@ -13,4 +13,4 @@ governing permissions and limitations under the License.
 // The __VERSION__ keyword will be replace at alloy build time with the package.json version.
 // see babel-plugin-version
 
-export default "2.29.0-beta.2";
+export default "2.29.0-beta.4";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/alloy",
-  "version": "2.29.0-beta.2",
+  "version": "2.29.0-beta.4",
   "description": "Adobe Experience Platform Web SDK",
   "type": "module",
   "main": "libEs5/index.js",
@@ -94,7 +94,7 @@
     "uuid": "^11.1.0"
   },
   "devDependencies": {
-    "@adobe/alloy": "^2.29.0-beta.1",
+    "@adobe/alloy": "^2.29.0-beta.3",
     "@babel/cli": "^7.27.2",
     "@babel/plugin-transform-modules-commonjs": "^7.27.1",
     "@babel/plugin-transform-runtime": "^7.27.4",

package/types/components/Advertising/createComponent.d.ts

@@ -7,7 +7,7 @@ declare function _default({ logger, config, eventManager, cookieManager, adConve
     getBrowser: any;
 }): {
     lifecycle: {
-        onComponentsRegistered(): void;
+        onComponentsRegistered(): Promise<any>;
         onBeforeEvent: ({ event, advertising }: {
             event: any;
             advertising?: {};

package/types/components/Advertising/createComponent.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"createComponent.d.ts","sourceRoot":"","sources":["../../../src/components/Advertising/createComponent.js"],"names":[],"mappings":"AAee;;;;;;;;;;;;;;;EAyCd"}
+{"version":3,"file":"createComponent.d.ts","sourceRoot":"","sources":["../../../src/components/Advertising/createComponent.js"],"names":[],"mappings":"AAee;;;;;;;;;;;;;;;EAoCd"}

package/types/components/Advertising/handlers/sendAdConversion.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"sendAdConversion.d.ts","sourceRoot":"","sources":["../../../../src/components/Advertising/handlers/sendAdConversion.js"],"names":[],"mappings":"AAqBe;;;;;;;uBA4Cd"}
+{"version":3,"file":"sendAdConversion.d.ts","sourceRoot":"","sources":["../../../../src/components/Advertising/handlers/sendAdConversion.js"],"names":[],"mappings":"AAqBe;;;;;;;uBA0Cd"}

package/types/components/Advertising/handlers/viewThroughHandler.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"viewThroughHandler.d.ts","sourceRoot":"","sources":["../../../../src/components/Advertising/handlers/viewThroughHandler.js"],"names":[],"mappings":"AAkBA;;;;;;;yCAkEC"}
+{"version":3,"file":"viewThroughHandler.d.ts","sourceRoot":"","sources":["../../../../src/components/Advertising/handlers/viewThroughHandler.js"],"names":[],"mappings":"AAkBA;;;;;;;yCAgEC"}

package/types/components/Advertising/index.d.ts

@@ -8,7 +8,7 @@ declare function createAdvertising({ logger, config, eventManager, sendEdgeNetwo
     getBrowser: any;
 }): {
     lifecycle: {
-        onComponentsRegistered(): void;
+        onComponentsRegistered(): Promise<any>;
         onBeforeEvent: ({ event, advertising }: {
             event: any;
             advertising?: {};