@adobe/aio-commerce-lib-app 0.3.0 → 0.3.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @adobe/aio-commerce-lib-app
 
+## 0.3.2
+
+### Patch Changes
+
+- [#262](https://github.com/adobe/aio-commerce-sdk/pull/262) [`7cb9252`](https://github.com/adobe/aio-commerce-sdk/commit/7cb9252736acd34f5490e2dc940b74a7ec40f17c) Thanks [@iivvaannxx](https://github.com/iivvaannxx)! - Dependencies should be installed early in the init process.
+
+## 0.3.1
+
+### Patch Changes
+
+- [#260](https://github.com/adobe/aio-commerce-sdk/pull/260) [`dbfb82f`](https://github.com/adobe/aio-commerce-sdk/commit/dbfb82fe4af72fe760df005506bec9f9927bbafc) Thanks [@iivvaannxx](https://github.com/iivvaannxx)! - Fix package json detection/creation on `init` script
+
 ## 0.3.0
 
 ### Minor Changes

package/dist/cjs/commands/index.cjs

@@ -895,8 +895,7 @@ async function ensureCommerceAppConfig(cwd = process.cwd()) {
 	}
 }
 /** Ensure package.json has the postinstall script */
-async function ensurePackageJson(execCommand, cwd = process.cwd()) {
-	const postinstallScript = `${execCommand} aio-commerce-lib-app hooks postinstall`;
+async function ensurePackageJson(cwd = process.cwd()) {
 	const packageJson = await require_config.readPackageJson(cwd);
 	if (!packageJson) {
 		consola.consola.warn("package.json not found. Creating one...");
@@ -904,16 +903,27 @@ async function ensurePackageJson(execCommand, cwd = process.cwd()) {
 			name: "my-commerce-app",
 			version: "1.0.0",
 			private: true,
-			scripts: { postinstall: postinstallScript }
+			scripts: { postinstall: "npx aio-commerce-lib-app hooks postinstall" }
 		};
 		await (0, fs_promises.writeFile)((0, path.join)((0, path.resolve)(cwd), PACKAGE_JSON_FILE), JSON.stringify(packageJsonContent, null, 2), "utf-8");
 		consola.consola.success("Wrote package.json");
-		return packageJsonContent;
+		return {
+			packageJson: packageJsonContent,
+			packageManager: "npm",
+			execCommand: "npx"
+		};
 	}
+	const packageManager = await require_config.detectPackageManager();
+	const execCommand = require_config.getExecCommand(packageManager);
+	const postinstallScript = `${execCommand} aio-commerce-lib-app hooks postinstall`;
 	packageJson.scripts ??= {};
 	if (packageJson.scripts.postinstall === postinstallScript || packageJson.scripts.postinstall?.includes(postinstallScript)) {
 		consola.consola.success(`postinstall script already configured in ${PACKAGE_JSON_FILE}`);
-		return packageJson;
+		return {
+			packageJson,
+			packageManager,
+			execCommand
+		};
 	}
 	if (packageJson.scripts.postinstall) {
 		consola.consola.warn(`${PACKAGE_JSON_FILE} already has a postinstall script. Adding a new one...`);
@@ -923,7 +933,11 @@ async function ensurePackageJson(execCommand, cwd = process.cwd()) {
 		(0, child_process.execSync)(`npm pkg set scripts.postinstall="${postinstallScript}"`);
 	}
 	consola.consola.success(`Added postinstall script to ${PACKAGE_JSON_FILE}`);
-	return packageJson;
+	return {
+		packageJson,
+		packageManager,
+		execCommand
+	};
 }
 /** Ensure app.config.yaml has the extension reference */
 async function ensureAppConfig(domains, cwd = process.cwd()) {
@@ -931,12 +945,11 @@ async function ensureAppConfig(domains, cwd = process.cwd()) {
 	if (domains.has("businessConfig.schema")) await addExtensionPointToAppConfig(CONFIGURATION_EXTENSION_POINT_ID, rootDirectory, " This extension is required for business configuration. Do not remove.");
 	await addExtensionPointToAppConfig(EXTENSIBILITY_EXTENSION_POINT_ID, rootDirectory, " This extension is required for app management. Do not remove.");
 }
-/** Install required dependencies */
-function installDependencies(packageManager, domains, cwd = process.cwd()) {
-	consola.consola.info(`Installing dependencies with ${packageManager}...`);
-	const packages = ["@adobe/aio-commerce-lib-app", "@adobe/aio-commerce-sdk"];
-	if (domains.has("businessConfig.schema")) packages.push("@adobe/aio-commerce-lib-config");
-	const packagesToInstall = packages.join(" ");
+/** Install the given dependencies */
+function runInstall(packageManager, dependencies, cwd = process.cwd()) {
+	const dependencyListString = dependencies.map((dependency) => `  - ${dependency}`).join("\n");
+	consola.consola.info(`Installing the following dependencies with ${packageManager}:\n${dependencyListString}`);
+	const packagesToInstall = dependencies.join(" ");
 	const installCommand = {
 		pnpm: `pnpm add ${packagesToInstall}`,
 		yarn: `yarn add ${packagesToInstall}`,
@@ -953,6 +966,12 @@ function installDependencies(packageManager, domains, cwd = process.cwd()) {
 		throw new Error(`Failed to install dependencies automatically. Please install manually: ${installCommand}`, { cause: error });
 	}
 }
+/** Install required dependencies */
+function installDependencies(packageManager, domains, cwd = process.cwd()) {
+	const packages = [];
+	if (domains.has("businessConfig.schema")) packages.push("@adobe/aio-commerce-lib-config");
+	runInstall(packageManager, packages, cwd);
+}
 /** Run the generation command */
 async function runGeneration(appConfig, execCommand) {
 	try {
@@ -971,21 +990,21 @@ async function ensureInstallYaml(domains, cwd = process.cwd()) {
 
 //#endregion
 //#region source/commands/init/main.ts
+const REQUIRED_DEPENDENCIES = ["@adobe/aio-commerce-lib-app", "@adobe/aio-commerce-sdk"];
 /** Initialize the project with @adobe/aio-commerce-lib-config */
 async function exec() {
 	try {
 		consola.consola.start("Initializing app...");
-		const packageManager = await require_config.detectPackageManager();
-		const execCommand = require_config.getExecCommand(packageManager);
-		await ensurePackageJson(execCommand);
+		const { execCommand, packageManager } = await ensurePackageJson();
+		runInstall(packageManager, REQUIRED_DEPENDENCIES);
 		const { config: config$1, domains } = await ensureCommerceAppConfig();
+		installDependencies(packageManager, domains);
 		(0, child_process.execSync)(`npm pkg set name="${config$1.metadata.id}"`);
 		(0, child_process.execSync)(`npm pkg set version="${config$1.metadata.version}"`);
 		(0, child_process.execSync)(`npm pkg set description="${config$1.metadata.description}"`);
 		await runGeneration(config$1, execCommand);
 		await ensureAppConfig(domains);
 		await ensureInstallYaml(domains);
-		installDependencies(packageManager, domains);
 		consola.consola.success("Initialization complete!");
 		consola.consola.box([
 			"Next steps:",

package/dist/es/commands/index.mjs

@@ -889,8 +889,7 @@ async function ensureCommerceAppConfig(cwd = process.cwd()) {
 	}
 }
 /** Ensure package.json has the postinstall script */
-async function ensurePackageJson(execCommand, cwd = process.cwd()) {
-	const postinstallScript = `${execCommand} aio-commerce-lib-app hooks postinstall`;
+async function ensurePackageJson(cwd = process.cwd()) {
 	const packageJson = await readPackageJson(cwd);
 	if (!packageJson) {
 		consola$1.warn("package.json not found. Creating one...");
@@ -898,16 +897,27 @@ async function ensurePackageJson(execCommand, cwd = process.cwd()) {
 			name: "my-commerce-app",
 			version: "1.0.0",
 			private: true,
-			scripts: { postinstall: postinstallScript }
+			scripts: { postinstall: "npx aio-commerce-lib-app hooks postinstall" }
 		};
 		await writeFile(join(resolve(cwd), PACKAGE_JSON_FILE), JSON.stringify(packageJsonContent, null, 2), "utf-8");
 		consola$1.success("Wrote package.json");
-		return packageJsonContent;
+		return {
+			packageJson: packageJsonContent,
+			packageManager: "npm",
+			execCommand: "npx"
+		};
 	}
+	const packageManager = await detectPackageManager();
+	const execCommand = getExecCommand(packageManager);
+	const postinstallScript = `${execCommand} aio-commerce-lib-app hooks postinstall`;
 	packageJson.scripts ??= {};
 	if (packageJson.scripts.postinstall === postinstallScript || packageJson.scripts.postinstall?.includes(postinstallScript)) {
 		consola$1.success(`postinstall script already configured in ${PACKAGE_JSON_FILE}`);
-		return packageJson;
+		return {
+			packageJson,
+			packageManager,
+			execCommand
+		};
 	}
 	if (packageJson.scripts.postinstall) {
 		consola$1.warn(`${PACKAGE_JSON_FILE} already has a postinstall script. Adding a new one...`);
@@ -917,7 +927,11 @@ async function ensurePackageJson(execCommand, cwd = process.cwd()) {
 		execSync(`npm pkg set scripts.postinstall="${postinstallScript}"`);
 	}
 	consola$1.success(`Added postinstall script to ${PACKAGE_JSON_FILE}`);
-	return packageJson;
+	return {
+		packageJson,
+		packageManager,
+		execCommand
+	};
 }
 /** Ensure app.config.yaml has the extension reference */
 async function ensureAppConfig(domains, cwd = process.cwd()) {
@@ -925,12 +939,11 @@ async function ensureAppConfig(domains, cwd = process.cwd()) {
 	if (domains.has("businessConfig.schema")) await addExtensionPointToAppConfig(CONFIGURATION_EXTENSION_POINT_ID, rootDirectory, " This extension is required for business configuration. Do not remove.");
 	await addExtensionPointToAppConfig(EXTENSIBILITY_EXTENSION_POINT_ID, rootDirectory, " This extension is required for app management. Do not remove.");
 }
-/** Install required dependencies */
-function installDependencies(packageManager, domains, cwd = process.cwd()) {
-	consola$1.info(`Installing dependencies with ${packageManager}...`);
-	const packages = ["@adobe/aio-commerce-lib-app", "@adobe/aio-commerce-sdk"];
-	if (domains.has("businessConfig.schema")) packages.push("@adobe/aio-commerce-lib-config");
-	const packagesToInstall = packages.join(" ");
+/** Install the given dependencies */
+function runInstall(packageManager, dependencies, cwd = process.cwd()) {
+	const dependencyListString = dependencies.map((dependency) => `  - ${dependency}`).join("\n");
+	consola$1.info(`Installing the following dependencies with ${packageManager}:\n${dependencyListString}`);
+	const packagesToInstall = dependencies.join(" ");
 	const installCommand = {
 		pnpm: `pnpm add ${packagesToInstall}`,
 		yarn: `yarn add ${packagesToInstall}`,
@@ -947,6 +960,12 @@ function installDependencies(packageManager, domains, cwd = process.cwd()) {
 		throw new Error(`Failed to install dependencies automatically. Please install manually: ${installCommand}`, { cause: error });
 	}
 }
+/** Install required dependencies */
+function installDependencies(packageManager, domains, cwd = process.cwd()) {
+	const packages = [];
+	if (domains.has("businessConfig.schema")) packages.push("@adobe/aio-commerce-lib-config");
+	runInstall(packageManager, packages, cwd);
+}
 /** Run the generation command */
 async function runGeneration(appConfig, execCommand) {
 	try {
@@ -965,21 +984,21 @@ async function ensureInstallYaml(domains, cwd = process.cwd()) {
 
 //#endregion
 //#region source/commands/init/main.ts
+const REQUIRED_DEPENDENCIES = ["@adobe/aio-commerce-lib-app", "@adobe/aio-commerce-sdk"];
 /** Initialize the project with @adobe/aio-commerce-lib-config */
 async function exec() {
 	try {
 		consola$1.start("Initializing app...");
-		const packageManager = await detectPackageManager();
-		const execCommand = getExecCommand(packageManager);
-		await ensurePackageJson(execCommand);
+		const { execCommand, packageManager } = await ensurePackageJson();
+		runInstall(packageManager, REQUIRED_DEPENDENCIES);
 		const { config: config$1, domains } = await ensureCommerceAppConfig();
+		installDependencies(packageManager, domains);
 		execSync(`npm pkg set name="${config$1.metadata.id}"`);
 		execSync(`npm pkg set version="${config$1.metadata.version}"`);
 		execSync(`npm pkg set description="${config$1.metadata.description}"`);
 		await runGeneration(config$1, execCommand);
 		await ensureAppConfig(domains);
 		await ensureInstallYaml(domains);
-		installDependencies(packageManager, domains);
 		consola$1.success("Initialization complete!");
 		consola$1.box([
 			"Next steps:",

package/package.json

@@ -2,7 +2,7 @@
   "name": "@adobe/aio-commerce-lib-app",
   "type": "module",
   "author": "Adobe Inc.",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "private": false,
   "engines": {
     "node": ">=20 <=24"
@@ -81,19 +81,19 @@
     "@adobe/aio-lib-state": "^5.3.1",
     "@standard-schema/spec": "^1.1.0",
     "yaml": "^2.8.2",
-    "@adobe/aio-commerce-lib-core": "0.6.1",
-    "@adobe/aio-commerce-lib-events": "0.6.0",
+    "@adobe/aio-commerce-lib-api": "0.6.1",
     "@adobe/aio-commerce-lib-auth": "0.8.1",
-    "@adobe/aio-commerce-lib-api": "0.6.1"
+    "@adobe/aio-commerce-lib-core": "0.6.1",
+    "@adobe/aio-commerce-lib-events": "0.6.0"
   },
   "devDependencies": {
     "@adobe/aio-lib-core-logging": "^3.0.2",
     "@aio-commerce-sdk/common-utils": "0.2.1",
+    "@aio-commerce-sdk/config-tsdown": "1.0.0",
     "@aio-commerce-sdk/config-typedoc": "1.0.0",
+    "@aio-commerce-sdk/config-typescript": "1.0.0",
     "@aio-commerce-sdk/config-vitest": "1.0.0",
-    "@aio-commerce-sdk/scripting-utils": "0.2.1",
-    "@aio-commerce-sdk/config-tsdown": "1.0.0",
-    "@aio-commerce-sdk/config-typescript": "1.0.0"
+    "@aio-commerce-sdk/scripting-utils": "0.2.1"
   },
   "sideEffects": false,
   "scripts": {