@adobe/aem-cli 16.19.0 → 16.19.2

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [16.19.2](https://github.com/adobe/helix-cli/compare/v16.19.1...v16.19.2) (2026-05-11)
+
+
+### Bug Fixes
+
+* **content:** correctness fixes for push, merge, and delete ([#2721](https://github.com/adobe/helix-cli/issues/2721)) ([efc6f11](https://github.com/adobe/helix-cli/commit/efc6f1138d55493dd546da300114df83ad006c5e))
+
+## [16.19.1](https://github.com/adobe/helix-cli/compare/v16.19.0...v16.19.1) (2026-04-28)
+
+
+### Bug Fixes
+
+* **deps:** update adobe fixes ([#2718](https://github.com/adobe/helix-cli/issues/2718)) ([487bd65](https://github.com/adobe/helix-cli/commit/487bd65e26a38707050f4605f45f515bf59bf9e3))
+
 # [16.19.0](https://github.com/adobe/helix-cli/compare/v16.18.7...v16.19.0) (2026-04-27)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/aem-cli",
-  "version": "16.19.0",
+  "version": "16.19.2",
   "description": "AEM CLI",
   "main": "index.js",
   "type": "module",
@@ -45,10 +45,10 @@
   "dependencies": {
     "@adobe/fetch": "4.3.0",
     "@adobe/helix-log": "7.0.0",
-    "@adobe/helix-shared-config": "11.1.21",
+    "@adobe/helix-shared-config": "11.1.22",
     "@adobe/helix-shared-git": "3.0.23",
     "@adobe/helix-shared-indexer": "2.2.7",
-    "@adobe/helix-shared-process-queue": "3.1.8",
+    "@adobe/helix-shared-process-queue": "3.1.9",
     "camelcase": "9.0.0",
     "chalk-template": "1.1.2",
     "chokidar": "5.0.0",
@@ -87,7 +87,7 @@
     "yargs": "18.0.0"
   },
   "devDependencies": {
-    "@adobe/eslint-config-helix": "3.0.25",
+    "@adobe/eslint-config-helix": "3.0.26",
     "@eslint/config-helpers": "0.5.5",
     "@semantic-release/changelog": "6.0.3",
     "@semantic-release/git": "10.0.1",
@@ -95,7 +95,7 @@
     "eslint": "9.4.0",
     "esmock": "2.7.3",
     "husky": "9.1.7",
-    "junit-report-builder": "5.1.1",
+    "junit-report-builder": "5.1.2",
     "lint-staged": "16.4.0",
     "mocha": "11.7.5",
     "mocha-multi-reporters": "1.5.1",

package/packages/browser-injectables/package-lock.json

@@ -22,15 +22,15 @@
       }
     },
     "node_modules/@adobe/eslint-config-helix": {
-      "version": "3.0.25",
-      "resolved": "https://registry.npmjs.org/@adobe/eslint-config-helix/-/eslint-config-helix-3.0.25.tgz",
-      "integrity": "sha512-3m8DoRPS/vq91ANyqbrgh/YnDljbHhZXpKooSWRK+OIoArkY6ju/NSFYYzbLj5ImVmfg3I4JPoiiWnNR/OTCGQ==",
+      "version": "3.0.26",
+      "resolved": "https://registry.npmjs.org/@adobe/eslint-config-helix/-/eslint-config-helix-3.0.26.tgz",
+      "integrity": "sha512-fF+yS57VSRd7ydKSgY170Q412dqwAB9euugEHDNBv3+qNvKByqiLvgfcAtodY6cwN9aUa6K8z1Yuezi3Q2+RyQ==",
       "dev": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "@eslint/config-helpers": "0.5.4",
+        "@eslint/config-helpers": "0.5.5",
         "eslint-plugin-import": "2.32.0",
-        "globals": "17.4.0"
+        "globals": "17.5.0"
       },
       "engines": {
         "node": ">= 12"
@@ -39,32 +39,6 @@
         "eslint": "^9.0.0"
       }
     },
-    "node_modules/@adobe/eslint-config-helix/node_modules/@eslint/config-helpers": {
-      "version": "0.5.4",
-      "resolved": "https://registry.npmjs.org/@eslint/config-helpers/-/config-helpers-0.5.4.tgz",
-      "integrity": "sha512-jJhqiY3wPMlWWO3370M86CPJ7pt8GmEwSLglMfQhjXal07RCvhmU0as4IuUEW5SJeunfItiEetHmSxCCe9lDBg==",
-      "dev": true,
-      "license": "Apache-2.0",
-      "dependencies": {
-        "@eslint/core": "^1.2.0"
-      },
-      "engines": {
-        "node": "^20.19.0 || ^22.13.0 || >=24"
-      }
-    },
-    "node_modules/@adobe/eslint-config-helix/node_modules/@eslint/core": {
-      "version": "1.2.1",
-      "resolved": "https://registry.npmjs.org/@eslint/core/-/core-1.2.1.tgz",
-      "integrity": "sha512-MwcE1P+AZ4C6DWlpin/OmOA54mmIZ/+xZuJiQd4SyB29oAJjN30UW9wkKNptW2ctp4cEsvhlLY/CsQ1uoHDloQ==",
-      "dev": true,
-      "license": "Apache-2.0",
-      "dependencies": {
-        "@types/json-schema": "^7.0.15"
-      },
-      "engines": {
-        "node": "^20.19.0 || ^22.13.0 || >=24"
-      }
-    },
     "node_modules/@babel/code-frame": {
       "version": "7.27.1",
       "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.27.1.tgz",
@@ -3595,9 +3569,9 @@
       }
     },
     "node_modules/globals": {
-      "version": "17.4.0",
-      "resolved": "https://registry.npmjs.org/globals/-/globals-17.4.0.tgz",
-      "integrity": "sha512-hjrNztw/VajQwOLsMNT1cbJiH2muO3OROCHnbehc8eY5JyD2gqz4AcMHPqgaOR59DjgUjYAYLeH699g/eWi2jw==",
+      "version": "17.5.0",
+      "resolved": "https://registry.npmjs.org/globals/-/globals-17.5.0.tgz",
+      "integrity": "sha512-qoV+HK2yFl/366t2/Cb3+xxPUo5BuMynomoDmiaZBIdbs+0pYbjfZU+twLhGKp4uCZ/+NbtpVepH5bGCxRyy2g==",
       "dev": true,
       "license": "MIT",
       "engines": {

package/src/content/da-api.js

@@ -162,7 +162,8 @@ export class DaClient {
   }
 
   /**
-   * Deletes a file or folder. Idempotent.
+   * Deletes a file or folder. Idempotent: 404 is treated as success.
+   * Throws on transport or server errors so callers don't silently treat them as success.
    */
   async deleteSource(org, repo, daPath) {
     const url = `${DA_ADMIN}/source/${org}/${repo}${daPath}`;
@@ -173,7 +174,10 @@ export class DaClient {
     if (res.status === 401) {
       throw new Error('Unauthorized: invalid or missing token');
     }
-    return res.ok || res.status === 204;
+    if (res.ok || res.status === 204 || res.status === 404) {
+      return true;
+    }
+    throw new Error(`DELETE failed for ${daPath}: ${res.status} ${res.statusText}`);
   }
 
   /**

package/src/content/merge.cmd.js

@@ -96,7 +96,7 @@ export default class MergeCommand {
       return;
     }
 
-    const token = await getValidToken(log, this._token, contentDir);
+    const token = await getValidToken(log, this._token, this._dir);
     const client = new DaClient(token);
 
     // Get the HEAD commit to read base blobs

package/src/content/push.cmd.js

@@ -108,16 +108,16 @@ export default class PushCommand {
    * @param {string} repo
    * @param {string} contentDir
    * @param {string[]} targets
-   * @returns {Promise<{ pushed: number, errors: number, successfullyPushed: Set<string> }>}
+   * @returns {Promise<{ pushed: number, errors: number }>}
    */
   async _uploadFiles(client, org, repo, contentDir, targets) {
     const { log } = this;
     let pushed = 0;
     let errors = 0;
-    const successfullyPushed = new Set();
 
+    // processQueue consumes its input array via shift(); copy so the caller's list survives.
     const results = await processQueue(
-      targets,
+      [...targets],
       async (daPath) => {
         const localPath = path.join(contentDir, ...daPath.split('/').filter(Boolean));
         const ext = daPath.split('.').pop();
@@ -125,7 +125,7 @@ export default class PushCommand {
           const buffer = await fse.readFile(localPath);
           await client.putSource(org, repo, daPath, buffer, getContentType(ext));
           log.info(`  ✓ ${daPath}`);
-          return { ok: true, daPath };
+          return { ok: true };
         } catch (err) {
           log.warn(`  ✗ ${daPath}: ${err.message}`);
           return { ok: false };
@@ -136,13 +136,12 @@ export default class PushCommand {
     for (const r of results) {
       if (r.ok) {
         pushed += 1;
-        successfullyPushed.add(r.daPath);
       } else {
         errors += 1;
       }
     }
 
-    return { pushed, errors, successfullyPushed };
+    return { pushed, errors };
   }
 
   /**
@@ -151,21 +150,21 @@ export default class PushCommand {
    * @param {string} org
    * @param {string} repo
    * @param {string[]} deleted
-   * @returns {Promise<{ pushed: number, errors: number, successfullyDeleted: Set<string> }>}
+   * @returns {Promise<{ pushed: number, errors: number }>}
    */
   async _deleteFiles(client, org, repo, deleted) {
     const { log } = this;
     let pushed = 0;
     let errors = 0;
-    const successfullyDeleted = new Set();
 
+    // processQueue consumes its input array via shift(); copy so the caller's list survives.
     const results = await processQueue(
-      deleted,
+      [...deleted],
       async (daPath) => {
         try {
           await client.deleteSource(org, repo, daPath);
           log.info(`  ✓ deleted ${daPath}`);
-          return { ok: true, daPath };
+          return { ok: true };
         } catch (err) {
           log.warn(`  ✗ ${daPath}: ${err.message}`);
           return { ok: false };
@@ -176,13 +175,12 @@ export default class PushCommand {
     for (const r of results) {
       if (r.ok) {
         pushed += 1;
-        successfullyDeleted.add(r.daPath);
       } else {
         errors += 1;
       }
     }
 
-    return { pushed, errors, successfullyDeleted };
+    return { pushed, errors };
   }
 
   async run() {
@@ -207,12 +205,21 @@ export default class PushCommand {
     const syncedOid = await resolveSyncedOid(fs, contentDir);
     const lastSyncTime = await getCommitCommitterTimeMs(fs, contentDir, syncedOid);
 
-    let { added, modified, deleted } = await diffCommitTrees(fs, contentDir, syncedOid, headOid);
+    const fullChanges = await diffCommitTrees(fs, contentDir, syncedOid, headOid);
+
+    const scope = this._pushPath ? this._pushPath.replace(/\/+$/, '') : null;
+    const inScope = (daPath) => scope === null
+      || daPath === scope
+      || daPath.startsWith(`${scope}/`);
+    const added = fullChanges.added.filter(inScope);
+    const modified = fullChanges.modified.filter(inScope);
+    const deleted = fullChanges.deleted.filter(inScope);
 
-    const inScope = (daPath) => !this._pushPath || daPath.startsWith(this._pushPath);
-    added = added.filter(inScope);
-    modified = modified.filter(inScope);
-    deleted = deleted.filter(inScope);
+    const fullCount = fullChanges.added.length
+      + fullChanges.modified.length
+      + fullChanges.deleted.length;
+    const scopeCount = added.length + modified.length + deleted.length;
+    const scopeIsComplete = fullCount === scopeCount;
 
     if (added.length === 0 && modified.length === 0 && deleted.length === 0) {
       log.info('Nothing to push. No commits ahead of the last da.live sync.');
@@ -261,27 +268,27 @@ export default class PushCommand {
       return;
     }
 
-    const putTargets = [...added, ...modified];
     const {
       pushed: putPushed,
       errors: putErrors,
-      successfullyPushed,
-    } = await this._uploadFiles(client, org, repo, contentDir, putTargets);
+    } = await this._uploadFiles(client, org, repo, contentDir, [...added, ...modified]);
 
     const {
       pushed: deletePushed,
       errors: deleteErrors,
-      successfullyDeleted,
     } = await this._deleteFiles(client, org, repo, deleted);
 
     const pushed = putPushed + deletePushed;
     const pushErrors = putErrors + deleteErrors;
+    const allOk = pushErrors === 0;
 
-    const allPutsOk = putTargets.every((p) => successfullyPushed.has(p));
-    const allDeletesOk = deleted.every((p) => successfullyDeleted.has(p));
-
-    if (allPutsOk && allDeletesOk) {
+    if (allOk && scopeIsComplete) {
       await writeSyncedRef(fs, contentDir, headOid);
+    } else if (allOk) {
+      log.info(
+        '\n--path filter held back other changes; sync ref not advanced. '
+        + 'Run \'aem content push\' (without --path) to fully sync.',
+      );
     } else {
       log.warn('\nSync ref not updated: fix errors and push again to finish syncing this commit.');
     }