@adobe/acc-js-sdk 1.1.61 → 1.2.0

package/test/CLAUDE.md

@@ -0,0 +1,2 @@
+<!-- Bridge file for Claude Code. Keep shared instructions in the sibling AGENTS.md unless they are Claude-specific. -->
+@AGENTS.md

package/test/cacheRefresher.test.js

@@ -311,6 +311,7 @@ describe("CacheRefresher cache", function () {
     });
 
     it('Catch error in soap call GetModifiedEntities and display a warning', async () => {
+        const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
         const client = await Mock.makeClient();
         client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
 
@@ -331,6 +332,12 @@ describe("CacheRefresher cache", function () {
             fail('exception is not expected');
         }
 
+        expect(warnSpy).toHaveBeenCalledWith(
+            expect.stringContaining('Failed to refresh cache'),
+            expect.anything()
+        );
+        warnSpy.mockRestore();
+
         cacheRefresher.stopAutoRefresh();
         client._transport.mockReturnValueOnce(Mock.LOGOFF_RESPONSE);
         await client.NLWS.xtkSession.logoff();

package/test/client.test.js

@@ -150,7 +150,7 @@ describe('ACC Client', function () {
 
         it('Should logon with dummy cookie', async () => {
             /* eslint no-global-assign: "off" */
-            document = {};
+            global.document = {};
             const client = await Mock.makeClient();
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
@@ -160,7 +160,7 @@ describe('ACC Client', function () {
             client._transport.mockReturnValueOnce(Mock.LOGOFF_RESPONSE);
             await client.NLWS.xtkSession.logoff();
             expect(client.isLogged()).toBe(false);
-            document = undefined;
+            global.document = undefined;
         });
 
         it('Should fail if Logon does not return an UserInfo struture', async () => {
@@ -2335,7 +2335,6 @@ describe('ACC Client', function () {
             const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080",
                                                     "$token$", {refreshClient: refreshClient});
             const client = await sdk.init(connectionParameters);
-            client.traceAPICalls(true);
             client._transport = jest.fn();
             client._transport.mockReturnValueOnce(Mock.BEARER_LOGON_RESPONSE);
             client._transport.mockReturnValueOnce(Promise.resolve(`XSV-350008 Session has expired or is invalid. Please reconnect.`));
@@ -2349,35 +2348,38 @@ describe('ACC Client', function () {
                     </pdomOutput></ExecuteQueryResponse>
                 </SOAP-ENV:Body>
                 </SOAP-ENV:Envelope>`));
-            await client.logon();
-            var queryDef = {
-                "schema": "nms:extAccount",
-                "operation": "select",
-                "select": {
-                    "node": [
-                        { "expr": "@id" },
-                        { "expr": "@name" }
-                    ]
-                }
-            };
-            var query = client.NLWS.xtkQueryDef.create(queryDef);
-            var extAccount = await query.executeQuery();
-            expect(extAccount).toEqual({ extAccount: [] });
-            // Same test as before traceAPICalls = false for code coverage
-            client._transport.mockReturnValueOnce(Promise.resolve(`XSV-350008 Session has expired or is invalid. Please reconnect.`));
-            client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
-                <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:queryDef' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
-                <SOAP-ENV:Body>
-                <ExecuteQueryResponse xmlns='urn:xtk:queryDef' SOAP-ENV:encodingStyle='http://schemas.xmlsoap.org/soap/encoding/'>
-                    <pdomOutput xsi:type='ns:Element' SOAP-ENV:encodingStyle='http://xml.apache.org/xml-soap/literalxml'>
-                    <extAccount-collection/>
-                    </pdomOutput></ExecuteQueryResponse>
-                </SOAP-ENV:Body>
-                </SOAP-ENV:Envelope>`));
-            client.traceAPICalls(false);
-            var query1  = client.NLWS.xtkQueryDef.create(queryDef);
-            const extAccount1 = await query1.executeQuery();
-            expect(extAccount1).toEqual({ extAccount: [] });
+            await Mock.withMockConsole(async () => {
+                client.traceAPICalls(true);
+                await client.logon();
+                var queryDef = {
+                    "schema": "nms:extAccount",
+                    "operation": "select",
+                    "select": {
+                        "node": [
+                            { "expr": "@id" },
+                            { "expr": "@name" }
+                        ]
+                    }
+                };
+                var query = client.NLWS.xtkQueryDef.create(queryDef);
+                var extAccount = await query.executeQuery();
+                expect(extAccount).toEqual({ extAccount: [] });
+                // Same test as before traceAPICalls = false for code coverage
+                client._transport.mockReturnValueOnce(Promise.resolve(`XSV-350008 Session has expired or is invalid. Please reconnect.`));
+                client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
+                    <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:queryDef' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
+                    <SOAP-ENV:Body>
+                    <ExecuteQueryResponse xmlns='urn:xtk:queryDef' SOAP-ENV:encodingStyle='http://schemas.xmlsoap.org/soap/encoding/'>
+                        <pdomOutput xsi:type='ns:Element' SOAP-ENV:encodingStyle='http://xml.apache.org/xml-soap/literalxml'>
+                        <extAccount-collection/>
+                        </pdomOutput></ExecuteQueryResponse>
+                    </SOAP-ENV:Body>
+                    </SOAP-ENV:Envelope>`));
+                client.traceAPICalls(false);
+                var query1  = client.NLWS.xtkQueryDef.create(queryDef);
+                const extAccount1 = await query1.executeQuery();
+                expect(extAccount1).toEqual({ extAccount: [] });
+            });
         });
 
         it("Expired session refresh client callback for code coverage", async () => {
@@ -2392,7 +2394,6 @@ describe('ACC Client', function () {
             const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080",
                                                     "$token$", {refreshClient: refreshClient});
             const client = await sdk.init(connectionParameters);
-            client.traceAPICalls(true);
             client._transport = jest.fn();
             client._transport.mockReturnValueOnce(Mock.BEARER_LOGON_RESPONSE);
             client._transport.mockReturnValueOnce(Promise.resolve(`XSV-350008 Session has expired or is invalid. Please reconnect.`));
@@ -2406,20 +2407,23 @@ describe('ACC Client', function () {
                     </pdomOutput></ExecuteQueryResponse>
                 </SOAP-ENV:Body>
                 </SOAP-ENV:Envelope>`));
-            await client.logon();
-            var queryDef = {
-                "schema": "nms:extAccount",
-                "operation": "select",
-                "select": {
-                    "node": [
-                        { "expr": "@id" },
-                        { "expr": "@name" }
-                    ]
-                }
-            };
-            var query = client.NLWS.xtkQueryDef.create(queryDef);
-            var extAccount = await query.executeQuery();
-            expect(extAccount).toEqual({ extAccount: [] });
+            await Mock.withMockConsole(async () => {
+                client.traceAPICalls(true);
+                await client.logon();
+                var queryDef = {
+                    "schema": "nms:extAccount",
+                    "operation": "select",
+                    "select": {
+                        "node": [
+                            { "expr": "@id" },
+                            { "expr": "@name" }
+                        ]
+                    }
+                };
+                var query = client.NLWS.xtkQueryDef.create(queryDef);
+                var extAccount = await query.executeQuery();
+                expect(extAccount).toEqual({ extAccount: [] });
+            });
         });
 
         it("Expired session refresh client callback retry failure", async () => {
@@ -2777,7 +2781,7 @@ describe('ACC Client', function () {
         it("Should support storage key type without version information", async () => {
             // Default has version & instance name
             const version = sdk.getSDKVersion().version; // "${version}" or similar
-            connectionParameters = sdk.ConnectionParameters.ofUserAndPassword("http://acc-sdk:8080", "admin", "admin");
+            let connectionParameters = sdk.ConnectionParameters.ofUserAndPassword("http://acc-sdk:8080", "admin", "admin");
             var client = await sdk.init(connectionParameters);
             expect(client._optionCache._storage._rootKey).toBe(`acc.js.sdk.${version}.acc-sdk:8080.cache.OptionCache$`);
 
@@ -2795,7 +2799,7 @@ describe('ACC Client', function () {
         it("Should support instanceKey", async () => {
             // Default has version & instance name
             const version = sdk.getSDKVersion().version; // "${version}" or similar
-            connectionParameters = sdk.ConnectionParameters.ofUserAndPassword("http://acc-sdk:8080", "admin", "admin");
+            let connectionParameters = sdk.ConnectionParameters.ofUserAndPassword("http://acc-sdk:8080", "admin", "admin");
             connectionParameters = sdk.ConnectionParameters.ofUserAndPassword("http://acc-sdk:8080", "admin", "admin", { instanceKey: "hello" });
             var client = await sdk.init(connectionParameters);
             expect(client._optionCache._storage._rootKey).toBe(`acc.js.sdk.${version}.hello.cache.OptionCache$`);
@@ -2942,7 +2946,6 @@ describe('ACC Client', function () {
             jest.advanceTimersByTime(18000);
             expect(client._entityCacheRefresher._safeCallAndRefresh.mock.calls.length).toBe(1);
             expect(client._optionCacheRefresher._safeCallAndRefresh.mock.calls.length).toBe(1);
-            client.traceAPICalls(true);
             client._transport = jest.fn();
             client._transport.mockReturnValueOnce(Mock.BEARER_LOGON_RESPONSE);
             client._transport.mockReturnValueOnce(Promise.resolve(`XSV-350008 Session has expired or is invalid. Please reconnect.`));
@@ -2956,20 +2959,23 @@ describe('ACC Client', function () {
                     </pdomOutput></ExecuteQueryResponse>
                 </SOAP-ENV:Body>
                 </SOAP-ENV:Envelope>`));
-            await client.logon();
-            var queryDef = {
-                "schema": "nms:extAccount",
-                "operation": "select",
-                "select": {
-                    "node": [
-                        { "expr": "@id" },
-                        { "expr": "@name" }
-                    ]
-                }
-            };
-            var query = client.NLWS.xtkQueryDef.create(queryDef);
-            var extAccount = await query.executeQuery();
-            expect(extAccount).toEqual({ extAccount: [] });
+            await Mock.withMockConsole(async () => {
+                client.traceAPICalls(true);
+                await client.logon();
+                var queryDef = {
+                    "schema": "nms:extAccount",
+                    "operation": "select",
+                    "select": {
+                        "node": [
+                            { "expr": "@id" },
+                            { "expr": "@name" }
+                        ]
+                    }
+                };
+                var query = client.NLWS.xtkQueryDef.create(queryDef);
+                var extAccount = await query.executeQuery();
+                expect(extAccount).toEqual({ extAccount: [] });
+            });
             jest.advanceTimersByTime(10000);
             expect(client._entityCacheRefresher._safeCallAndRefresh.mock.calls.length).toBe(2);
             expect(client._optionCacheRefresher._safeCallAndRefresh.mock.calls.length).toBe(2);
@@ -3294,7 +3300,6 @@ describe('ACC Client', function () {
                     }
                 });
                 await query.executeQuery();
-                console.log(headers);
                 expect(headers).toMatchObject({
                     "SoapAction": "xtk:queryDef#ExecuteQuery",
                     "X-Test": "world",
@@ -3447,8 +3452,8 @@ describe('ACC Client', function () {
             });
         });
 
-        it("Should add x-request-id header to every SOAP call", async () => {
-            const client = await Mock.makeClient();
+        it("Should add x-request-id header to SOAP call when enableRequestIdHeader is true", async () => {
+            const client = await Mock.makeClient({ enableRequestIdHeader: true });
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
 
@@ -3480,7 +3485,38 @@ describe('ACC Client', function () {
         });
 
         it("Should call SOAP call on request ID generation failure", async () => {
-            const client = await Mock.makeClient();
+            const client = await Mock.makeClient({enableRequestIdHeader: true});
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+            
+            const mockGetUUID = jest.spyOn(Util, 'getUUID').mockImplementation(() => { throw new Error('UUID error'); });
+            const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+            
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_QUERY_SCHEMA_RESPONSE);
+            client._transport.mockReturnValueOnce(Mock.GET_QUERY_EXECUTE_RESPONSE);
+            const queryDef = {
+                "schema": "nms:extAccount",
+                "operation": "select",
+                "select": {
+                    "node": [{ "expr": "@id" }]
+                }
+            };
+            
+            const query = client.NLWS.xtkQueryDef.create(queryDef);
+
+            const headers = await collectHeaders(client, async() => {
+                await query.executeQuery();
+            });
+
+            expect(headers["x-request-id"]).toBeUndefined();
+            
+            mockGetUUID.mockRestore();
+            consoleErrorSpy.mockRestore();
+        });
+
+
+        it("Should not add x-request-id header to SOAP call when enableRequestIdHeader is false", async () => {
+            const client = await Mock.makeClient({ enableRequestIdHeader: false });
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
             
@@ -3684,7 +3720,9 @@ describe('ACC Client', function () {
         describe('upload', () => {
             describe("File uploader - on server", () => {
             it("is not supported", async () => {
+                const warnSpy = jest.spyOn(console, 'warn').mockImplementation();
                 const client = await Mock.makeClient();
+                client.traceAPICalls(true);
                 expect(client.fileUploader).toBeDefined();
                 await expect(
                 client.fileUploader.upload({ name: "abcd.txt" })
@@ -3700,6 +3738,8 @@ describe('ACC Client', function () {
                 name: "CampaignException",
                 statusCode: 500,
                 });
+                expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining("experimental"));
+                warnSpy.mockRestore();
             });
             }); // "File uploader - on server"
 
@@ -4415,7 +4455,7 @@ describe('ACC Client', function () {
                     type: "text/html",
                     size: 12345,
                     }, undefined, 'PREFIX');
-                expect(Util.getUUID).toHaveBeenCalledTimes(8);
+                expect(Util.getUUID).toHaveBeenCalledTimes(1);
             });
             }); // "File uploader - on browser"
         }); // 'upload'
@@ -4897,15 +4937,18 @@ describe('ACC Client', function () {
             const client = await Mock.makeClient();
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
-            client.traceAPICalls(true);
+            await Mock.withMockConsole(async () => {
+                client.traceAPICalls(true);
 
-            client._transport.mockRejectedValueOnce(new HttpError(500, "Error rc=-57"));
-            await expect(client.getReportData({
-                reportName: "throughput",
-                context: "selection",
-                selection: "12133",
-                schema: "nms:delivery"
-            })).rejects.toMatchObject({ statusCode:500, message:"500 - Error 16384: SDK-000014 Failed to fetch report throughput. 500 - Error calling method '/report/throughput?_noRender=true&_schema=nms:delivery&_context=selection&_selection=12133&_selectionCount=1': Error rc=-57" });
+                client._transport.mockRejectedValueOnce(new HttpError(500, "Error rc=-57"));
+                await expect(client.getReportData({
+                    reportName: "throughput",
+                    context: "selection",
+                    selection: "12133",
+                    schema: "nms:delivery"
+                })).rejects.toMatchObject({ statusCode:500, message:"500 - Error 16384: SDK-000014 Failed to fetch report throughput. 500 - Error calling method '/report/throughput?_noRender=true&_schema=nms:delivery&_context=selection&_selection=12133&_selectionCount=1': Error rc=-57" });
+                client.traceAPICalls(false);
+            });
 
             client._transport.mockReturnValueOnce(Mock.LOGOFF_RESPONSE);
             await client.NLWS.xtkSession.logoff();
@@ -4977,8 +5020,7 @@ describe('ACC Client', function () {
             const schema = client.newSchema(xml);
             const jobs = schema.root.children["jobs"];
             expect(jobs.target).toBe("xtk:job");
-            // node 14 throws "Cannot read property 'getSchema' of null"
-            // node 16+ throws "Cannot read properties of null (reading 'getSchema')"
+            // node 20+ throws "Cannot read properties of null (reading 'getSchema')"
             await expect(jobs.linkTarget()).rejects.toThrow(/Cannot read (.*getSchema.*of null)|(.*of null.*getSchema)/);
         });
     });
@@ -5013,13 +5055,13 @@ describe('ACC Client', function () {
             
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
 
-            inputParams = [
+            const inputParams = [
                 { name: "login", type: "string", value: "admin" },
                 { name: "password", type: "string", value: "admin" },
                 { name: "parameters", type: "DOMElement", value: { rememberMe: true } },
                 
               ];
-              outputParams = [
+              const outputParams = [
                 { name: "sessionToken", type: "string" },
                 { name: "session", type: "DOMElement" },
                 { name: "securityToken", type: "string" },

package/test/jest.config.js

@@ -28,6 +28,12 @@ module.exports = {
     'jest-junit'
   ],
   testEnvironment: 'node',
+  transform: {
+    '^.+\\.m?js$': 'babel-jest'
+  },
+  transformIgnorePatterns: [
+    '/node_modules/(?!(@exodus|@asamuzakjp|@bramus|@csstools|css-tree|parse5|tough-cookie|baseline-browser-mapping)/)'
+  ],
   setupFilesAfterEnv: [/*
     '<rootDir>/test/jest/jest.setup.js',
     // remove any of the lines below if you don't want to use any of the mocks

package/test/observability.test.js

@@ -85,6 +85,7 @@ describe('ACC Client Observability', function () {
     });
 
     it('Should ignore exceptions throws from observer', async () => {
+        const infoSpy = jest.spyOn(console, 'info').mockImplementation(() => {});
         const [client, assertion] = await makeObservableClient({}, (event, parentEvent) => {
             throw new Error("Simulated failure in observer");
         });
@@ -92,6 +93,7 @@ describe('ACC Client Observability', function () {
         // logon will send an observability event, but the error will be logged and ignored
         await client.NLWS.xtkSession.logon();
         expect(assertion.hasObserved("SDK//logon")).toBe(true);
+        infoSpy.mockRestore();
     });
 
     it('Should send internal stats every 5 minutes', async () => {
@@ -188,8 +190,11 @@ describe('ACC Client Observability', function () {
         const start = assertion.getFirstObserved("CACHE_REFRESHER//start");
         expect(start.event).toMatchObject({ eventName:"CACHE_REFRESHER//start", payload:{ cacheSchemaId: "xtk:option", refreshFrequency: 10000 } });
 
-        // No mock implementation => the API call to get modified entities will fail generating a CACHE_REFRESHER//error event
+        // Simulate a failed API call to get modified entities, generating a CACHE_REFRESHER//error event
+        client._transport.mockReturnValueOnce(Promise.reject(new Error("Simulated GetModifiedEntities failure")));
+        const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
         await client._optionCacheRefresher._safeCallAndRefresh();
+        warnSpy.mockRestore();
         expect(assertion.hasObserved("CACHE_REFRESHER//tick")).toBe(true);
         const tick = assertion.getFirstObserved("CACHE_REFRESHER//tick");
         expect(tick.event).toMatchObject({ eventName:"CACHE_REFRESHER//tick", payload:{ cacheSchemaId: "xtk:option" } });

package/test/xtkJob.test.js

@@ -603,7 +603,7 @@ describe('XRK Jobs', function () {
             });
             client._transport.mockReturnValueOnce(Mock.GET_XTK_JOB_SCHEMA_RESPONSE);
             client._transport.mockReturnValueOnce(MOCK_SUBMIT_JOB_RESPONSE("4210/nms:delivery@@B/C1boHl4jx1AEnDTI4nI137QkcFiiIZf4v++eFsPdM="));
-            jobId = await job.submit();
+            const jobId = await job.submit();
 
             // First call to get status returns the status and a no logs
             client._transport.mockReturnValueOnce(MOCK_GETSTATUS1_RESPONSE(2, 0, 0, true));
@@ -728,7 +728,7 @@ describe('XRK Jobs', function () {
             });
             client._transport.mockReturnValueOnce(Mock.GET_XTK_JOB_SCHEMA_RESPONSE);
             client._transport.mockReturnValueOnce(MOCK_SUBMIT_JOB_RESPONSE("4210/nms:delivery@@B/C1boHl4jx1AEnDTI4nI137QkcFiiIZf4v++eFsPdM="));
-            jobId = await job.submit();
+            const jobId = await job.submit();
 
             // First call to get status returns the status and a no logs
             client._transport.mockReturnValueOnce(MOCK_GETSTATUS1_RESPONSE(2, 0, 0, true));