@adobe/acc-js-sdk 1.1.61 → 1.1.62

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/acc-js-sdk",
-  "version": "1.1.61",
+  "version": "1.1.62",
   "description": "ACC Javascript SDK",
   "main": "src/index.js",
   "homepage": "https://github.com/adobe/acc-js-sdk#readme",

package/src/client.js

@@ -309,6 +309,7 @@ class Credentials {
     * @property {number} timeout - Can be set to change the HTTP call timeout. Value is passed in ms.
     * @property {string} cacheRootKey - "default" or "none" - determine the prefix to use for the keys in the caches of schemas, options, etc.
     * @property {string} instanceKey - an optional value to override the instance key which is used for the caches of schemas, options, etc.
+    * @property {boolean} enableRequestIdHeader - an optional value to enable the request ID header for SOAP API calls
     * @memberOf Campaign
  */
 
@@ -1178,17 +1179,21 @@ class Client {
      * parameters should be set
      */
     _prepareSoapCall(urn, method, isStatic, internal, extraHttpHeaders, pushDownOptions) {
-        // Generate unique request ID for every SOAP call
-        let requestId;
-        try {
-          requestId = Util.getUUID();
-        } catch (error) {
-          console.error("Failed to generate request ID", error);
-        }
-        const updatedExtraHttpHeaders = requestId ? Object.assign({}, extraHttpHeaders, {
+
+        // Send request ID header if enableRequestIdHeader flag is set to true
+        const enableRequestIdHeader = this._connectionParameters._options &&
+          this._connectionParameters._options.enableRequestIdHeader;
+        let updatedExtraHttpHeaders = extraHttpHeaders;
+        if (enableRequestIdHeader) {
+          try {
+            const requestId = Util.getUUID();
+            updatedExtraHttpHeaders = Object.assign({}, extraHttpHeaders, {
               "x-request-id": requestId,
-            })
-          : extraHttpHeaders;
+            });
+          } catch (error) {
+            console.error("Failed to generate request ID", error);
+          }
+        }
         const soapCall = new SoapMethodCall(this._transport, urn, method,
                                             this._sessionToken, this._securityToken,
                                             this._getUserAgentString(),

package/test/client.test.js

@@ -3447,8 +3447,8 @@ describe('ACC Client', function () {
             });
         });
 
-        it("Should add x-request-id header to every SOAP call", async () => {
-            const client = await Mock.makeClient();
+        it("Should add x-request-id header to SOAP call when enableRequestIdHeader is true", async () => {
+            const client = await Mock.makeClient({ enableRequestIdHeader: true });
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
 
@@ -3480,7 +3480,37 @@ describe('ACC Client', function () {
         });
 
         it("Should call SOAP call on request ID generation failure", async () => {
-            const client = await Mock.makeClient();
+            const client = await Mock.makeClient({enableRequestIdHeader: true});
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+            
+            const mockGetUUID = jest.spyOn(Util, 'getUUID').mockImplementation(() => { throw new Error('UUID error'); });
+            
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_QUERY_SCHEMA_RESPONSE);
+            client._transport.mockReturnValueOnce(Mock.GET_QUERY_EXECUTE_RESPONSE);
+            const queryDef = {
+                "schema": "nms:extAccount",
+                "operation": "select",
+                "select": {
+                    "node": [{ "expr": "@id" }]
+                }
+            };
+            
+            const query = client.NLWS.xtkQueryDef.create(queryDef);
+
+            const headers = await collectHeaders(client, async() => {
+                await query.executeQuery();
+            });
+
+            expect(headers["x-request-id"]).toBeUndefined();
+            
+            // Restore the mock
+            mockGetUUID.mockRestore();
+        });
+
+
+        it("Should not add x-request-id header to SOAP call when enableRequestIdHeader is false", async () => {
+            const client = await Mock.makeClient({ enableRequestIdHeader: false });
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
             
@@ -4415,7 +4445,7 @@ describe('ACC Client', function () {
                     type: "text/html",
                     size: 12345,
                     }, undefined, 'PREFIX');
-                expect(Util.getUUID).toHaveBeenCalledTimes(8);
+                expect(Util.getUUID).toHaveBeenCalledTimes(1);
             });
             }); // "File uploader - on browser"
         }); // 'upload'