@adobe/acc-js-sdk 1.1.6 → 1.1.7

package/src/transport.js

@@ -10,7 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 (function() {
-"use strict";    
+"use strict";
 
 const { Util } = require('./util.js');
 
@@ -41,9 +41,9 @@ class HttpError {
 }
 
 /**********************************************************************************
- * 
+ *
  * Node implementation
- * 
+ *
  *********************************************************************************/
 /* istanbul ignore else */
 if (!Util.isBrowser()) {
@@ -52,13 +52,13 @@ if (!Util.isBrowser()) {
   const axios = require('axios');
 
   /**
-   * 
+   *
    * Request body (options)
    * - headers (kv)
    * - method
    * - url
    * - data
-   * 
+   *
    * Response
    * - data
    * - statusCode
@@ -96,11 +96,11 @@ if (!Util.isBrowser()) {
 }
 
 /**********************************************************************************
- * 
+ *
  * Browser-side implementation of the request-promise-native node module.
  * This simply wraps the fetch API
  * From https://www.npmjs.com/package/request-promise-native
- * 
+ *
  *********************************************************************************/
  else {
 
@@ -109,11 +109,12 @@ if (!Util.isBrowser()) {
     const headers = new Headers();
     for (var k in options.headers) {
         headers.append(k, options.headers[k]);
-    }    
+    }
     const r = new Request(options.url, {
         method: options.method,
         headers: headers,
-        body: options.data
+        body: options.data,
+        credentials: options.credentials || 'same-origin'
     });
 
     const p = fetch(r).then(async (response) => {
@@ -135,4 +136,4 @@ if (!Util.isBrowser()) {
 
 }
 
-})();
+})();

package/test/caches.test.js

@@ -30,13 +30,16 @@ describe('Caches', function() {
         it("Should cache with default TTL and default key function", () => {
             const cache = new Cache();
             cache.put("Hello", "World");
+            expect(cache._stats).toMatchObject({ reads: 0, writes: 1 });
             expect(cache.get("Hello")).toBe("World");
+            expect(cache._stats).toMatchObject({ reads: 1, writes: 1, memoryHits: 1, storageHits: 0 });
         })
 
         it("Should expires after TTL", () => {
             const cache = new Cache(undefined, undefined, -1);    // negative TTL => will immediately expire
             cache.put("Hello", "World");
             expect(cache.get("Hello")).toBeUndefined();
+            expect(cache._stats).toMatchObject({ reads: 1, writes: 1, memoryHits: 0, storageHits: 0 });
         })
 
         it("Should support custom key function", () => {
@@ -53,6 +56,7 @@ describe('Caches', function() {
             expect(cache.get("Hello")).toBe("World");
             cache.clear();
             expect(cache.get("Hello")).toBeUndefined();
+            expect(cache._stats).toMatchObject({ reads: 2, writes: 1, memoryHits: 1, storageHits: 0, clears: 1 });
         })
 
         it("Should remove key in cache", () => {
@@ -61,9 +65,11 @@ describe('Caches', function() {
             cache.put("Hi", "A");
             expect(cache.get("Hello")).toBe("World");
             expect(cache.get("Hi")).toBe("A");
+            expect(cache._stats).toMatchObject({ reads: 2, writes: 2, memoryHits: 2 });
             cache.remove("Hello");
             expect(cache.get("Hello")).toBeUndefined();
             expect(cache.get("Hi")).toBe("A");
+            expect(cache._stats).toMatchObject({ reads: 4, writes: 2, memoryHits: 3, removals: 1 });
             // should support removing a key which has already been removed
             cache.remove("Hello");
             expect(cache.get("Hello")).toBeUndefined();

package/test/client.test.js

@@ -12,9 +12,9 @@ governing permissions and limitations under the License.
 
 
 /**********************************************************************************
- * 
+ *
  * Unit tests for the ACC client
- * 
+ *
  *********************************************************************************/
 
 const sdk = require('../src/index.js');
@@ -24,6 +24,8 @@ const Mock = require('./mock.js').Mock;
 const { HttpError } = require('../src/transport.js');
 const { Cipher } = require('../src/crypto.js');
 const { EntityAccessor } = require('../src/entityAccessor.js');
+const { JSDOM } = require('jsdom');
+const dom = new JSDOM();
 
 describe('ACC Client', function () {
 
@@ -73,7 +75,7 @@ describe('ACC Client', function () {
                 var sessionInfoXml = client.getSessionInfo("xml");
                 expect(DomUtil.findElement(sessionInfoXml, "serverInfo", true).getAttribute("buildNumber")).toBe("9219");
                 await client.NLWS.xtkSession.logoff();
-                expect(client.isLogged()).toBe(false);    
+                expect(client.isLogged()).toBe(false);
             })
             expect(logs.length).toBe(4);
             expect(logs[0]).toMatch(/SOAP.*request.*Logon/is)
@@ -285,7 +287,7 @@ describe('ACC Client', function () {
                 client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
                 client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);
                 await client.NLWS.xtkSession.logon();
-    
+
                 // Setting an option for the first time will
                 // - try to read the option from the database (as it's not in cache yet): xtk:session#GetOption
                 // - use a writer to write the result to the database
@@ -308,7 +310,7 @@ describe('ACC Client', function () {
                 client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
                 client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);
                 await client.NLWS.xtkSession.logon();
-    
+
                 // Setting an option for the first time will
                 // - try to read the option from the database (as it's not in cache yet): xtk:session#GetOption
                 // - use a writer to write the result to the database
@@ -331,7 +333,7 @@ describe('ACC Client', function () {
                 client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
                 client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);
                 await client.NLWS.xtkSession.logon();
-    
+
                 // Setting an option for the first time will
                 // - try to read the option from the database (as it's not in cache yet): xtk:session#GetOption. In this case, it will return a numeric option
                 // - use a writer to write the result to the database
@@ -416,7 +418,7 @@ describe('ACC Client', function () {
             expect(schema["@name"]).toBe("extAccount");
 
             // Ask with invalid representation
-            await expect(client.getSchema("nms:extAccount", "invalid")).rejects.toMatchObject({ errorCode: 'SDK-000004' }); 
+            await expect(client.getSchema("nms:extAccount", "invalid")).rejects.toMatchObject({ errorCode: 'SDK-000004' });
 
             // Get missing schema
             client.clearAllCaches();
@@ -474,7 +476,7 @@ describe('ACC Client', function () {
             await expect(client.getSysEnum("encryptionType", startSchema)).rejects.toMatchObject({ errorCode: "SDK-000006" });
             client._representation = "xml";
 
-            // Get non-cached XML representation 
+            // Get non-cached XML representation
             client.clearAllCaches();
             client._transport.mockReturnValueOnce(Mock.GET_NMS_EXTACCOUNT_SCHEMA_RESPONSE);
             sysEnum = await client.getSysEnum("nms:extAccount:encryptionType");
@@ -690,7 +692,7 @@ describe('ACC Client', function () {
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
             const key = Mock.makeKey();
-            
+
             client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);
             client._transport.mockReturnValueOnce(Mock.GET_SECRET_KEY_OPTION_RESPONSE(key));
             var cipher = await client._getSecretKeyCipher();
@@ -1008,13 +1010,13 @@ describe('ACC Client', function () {
         });
 
         it("Should support mutable calls", async () => {
-            // Some methods can mutate the object on which they apply. This is for instance the case of the xtk:queryDef#SelectAll method. 
-            // You call it on a queryDef, and it internally returns a new query definition which contain select nodes for all the nodes of the schema. 
+            // Some methods can mutate the object on which they apply. This is for instance the case of the xtk:queryDef#SelectAll method.
+            // You call it on a queryDef, and it internally returns a new query definition which contain select nodes for all the nodes of the schema.
             // When such a method is called, the SDK will know how to "mutate" the corresponding object.
             const client = await Mock.makeClient();
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
-            
+
             var queryDef = {
                 "schema": "xtk:option",
                 "operation": "getIfExists",
@@ -1050,7 +1052,7 @@ describe('ACC Client', function () {
                     </SOAP-ENV:Body>
                     </SOAP-ENV:Envelope>`));
             await query.selectAll(false);
-            
+
             // Check that query has new nodes
             const object = query.inspect();         // JSON query object
             expect(object.select.node.length).toBe(14);
@@ -1288,7 +1290,7 @@ describe('ACC Client', function () {
 
     describe("Logon with session token", () => {
         // With session token logon, the session token is passed by the caller, and therefore the will be no "Logon" call
-      
+
         it("Should create logged client", async() => {
             const connectionParameters = sdk.ConnectionParameters.ofSessionToken("http://acc-sdk:8080", "mc/");
             const client = await sdk.init(connectionParameters);
@@ -1304,7 +1306,7 @@ describe('ACC Client', function () {
 
     describe("Anonymous login", () => {
         // With anonymous login, one is always logged
-      
+
         it("Should create anonymous client", async() => {
             const connectionParameters = sdk.ConnectionParameters.ofAnonymousUser("http://acc-sdk:8080");
             const client = await sdk.init(connectionParameters);
@@ -1553,7 +1555,7 @@ describe('ACC Client', function () {
                 "xtk:session#GetOption", true,
             ];
             const observed = [];
-            
+
             client.registerObserver({
                 onSOAPCall: (soapCall) => {
                     const request = soapCall.request;
@@ -1598,7 +1600,7 @@ describe('ACC Client', function () {
                         </SOAP-ENV:Envelope>`));
             await expect(client.getOption("XtkDatabaseId")).rejects.toMatchObject({ errorCode: "XXX-000000" });
             expect(observedException).toMatchObject({ errorCode: "XXX-000000" });
-            
+
         });
 
         it("Should ignore unregistering non-existant observers", async () => {
@@ -1613,7 +1615,7 @@ describe('ACC Client', function () {
             const client = await Mock.makeClient();
             var countCalls = 0;
             var countSuccesses = 0;
-            
+
             const observer1 = {
                 onSOAPCall: () => { countCalls = countCalls + 1; },
                 onSOAPCallSuccess: () => { countSuccesses = countSuccesses + 1; }
@@ -1643,7 +1645,7 @@ describe('ACC Client', function () {
             const client = await Mock.makeClient();
             var countCalls = 0;
             var countSuccesses = 0;
-            
+
             const observer1 = {
                 onSOAPCall: () => { countCalls = countCalls + 1; },
                 onSOAPCallSuccess: () => { countSuccesses = countSuccesses + 1; }
@@ -1668,7 +1670,7 @@ describe('ACC Client', function () {
             expect(countCalls).toBe(1);
             expect(countSuccesses).toBe(2);
         });
-      
+
         it("Should observe internal SOAP calls", async () => {
             const client = await Mock.makeClient();
             const expected = [
@@ -1678,7 +1680,7 @@ describe('ACC Client', function () {
                 "xtk:session#GetOption", false,
             ];
             const observed = [];
-            
+
             client.registerObserver({
                 onSOAPCall: (soapCall) => {
                     const request = soapCall.request;
@@ -1703,7 +1705,7 @@ describe('ACC Client', function () {
                 client.traceAPICalls(true);
                 client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
                 await client.NLWS.xtkSession.logon();
-    
+
                 client._transport.mockReturnValueOnce(Mock.PING);
                 const ping = await client.ping();
                 expect(ping.status).toBe("OK");
@@ -1727,7 +1729,7 @@ describe('ACC Client', function () {
             expect(logs[0]).toMatch(/HTTP.*request.*GET.*test.com/is)
             expect(logs[1]).toMatch(/HTTP.*response/is)
         })
-        
+
         it("Should trace HTTP call with data and no answer", async () => {
             const logs = await Mock.withMockConsole(async () => {
                 const client = await Mock.makeClient();
@@ -1782,7 +1784,7 @@ describe('ACC Client', function () {
                 url: "http://acc-sdk:8080/nl/jsp/ping.jsp"
             });
             expect(observer.onHTTPCall.mock.calls[0][1]).toBeUndefined();
-            
+
             expect(observer.onHTTPCallSuccess.mock.calls.length).toBe(1);
             expect(observer.onHTTPCallSuccess.mock.calls[0].length).toBe(2);    // 2 arguments
             expect(observer.onHTTPCallSuccess.mock.calls[0][0]).toMatchObject({
@@ -1903,7 +1905,7 @@ describe('ACC Client', function () {
             expect(client.isLogged()).toBeFalsy();
             // Ensure logoff has been called
             expect(logoff.mock.calls.length).toBe(1);
-        })   
+        })
      })
 
     describe("Bearer token authentication", () => {
@@ -1967,7 +1969,7 @@ describe('ACC Client', function () {
                 await newClient.logon();
                 return newClient;
             }
-            const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080", 
+            const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080",
                                                     "$token$", {refreshClient: refreshClient});
             const client = await sdk.init(connectionParameters);
             client.traceAPICalls(true);
@@ -2332,7 +2334,7 @@ describe('ACC Client', function () {
             expect(cached.value).toMatch("<schema");
 
             // Now simulate reusing the local storage. We need a new client to make sure we do not reuse
-            // the in-memory cache of the client. 
+            // the in-memory cache of the client.
             client = await Mock.makeClient({ storage: storage });
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
             await client.NLWS.xtkSession.logon();
@@ -2444,7 +2446,7 @@ describe('ACC Client', function () {
                 await newClient.logon();
                 return newClient;
             }
-            const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080", 
+            const connectionParameters = sdk.ConnectionParameters.ofBearerToken("http://acc-sdk:8080",
                                                     "$token$", {refreshClient: refreshClient});
             const client = await sdk.init(connectionParameters);
             jest.useFakeTimers();
@@ -2511,7 +2513,7 @@ describe('ACC Client', function () {
             const method = scope["staticP1"]; // SOAP method to call
             const paramsFn = jest.fn(); // function returning SOAP call parameters
             paramsFn.mockReturnValueOnce(["XtkDatabaseId"]);
-            
+
             client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
                 <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:session' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
                 <SOAP-ENV:Body>
@@ -2539,7 +2541,7 @@ describe('ACC Client', function () {
             const method = scope["nonStaticP1"]; // SOAP method to call
             const paramsFn = jest.fn(); // function returning SOAP call parameters
             paramsFn.mockReturnValueOnce(["XtkDatabaseId"]);
-            
+
             client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
                 <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:session' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
                 <SOAP-ENV:Body>
@@ -3098,7 +3100,7 @@ describe('ACC Client', function () {
             }
 
             client._unregisterAllCacheChangeListeners();
-            
+
             const listener = new Listener();
             listener.add("nms:recipient");
             listener.add("xtk:operator");
@@ -3111,4 +3113,243 @@ describe('ACC Client', function () {
             client._unregisterCacheChangeListener(listener);
         });
     });
+    describe('File uploader - on server', () => {
+        it('is not supported', async ()=> {
+            const client = await Mock.makeClient();
+            expect(client.fileUploader).toBeDefined()
+            await expect(client.fileUploader.upload({name: 'abcd.txt'})).rejects.toMatchObject({"cause": undefined, "detail": "File uploading is only supported in browser based calls.", "errorCode": "SDK-000013", "faultCode": 16384, "faultString": "\"Failed to upload file abcd.txt", "message": "500 - Error 16384: SDK-000013 \"Failed to upload file abcd.txt. File uploading is only supported in browser based calls.", "methodCall": undefined, "name": "CampaignException", "statusCode": 500})
+        })
+    })
+
+    describe('File uploader - on browser', () => {
+        beforeEach(() => {
+            global.document = dom.window.document
+            global.window = dom.window
+            global.FormData = function () {
+                this.append = jest.fn()
+            }
+
+            // Evaluates JavaScript code returned by the upload.jsp. Evaluation is done in the context
+            // of an iframe and will call the parent window document.controller uploadFileCallBack
+            // function
+            function evalJSReturnedByUploadJSP(js) {
+                const data = eval(`
+                (function () {
+                    var result = undefined;
+                    window = {
+                        parent: {
+                            document: {
+                                controller: {
+                                    uploadFileCallBack: (data) => {
+                                        result = data;
+                                    }
+                                }
+                            }
+                        }
+                    };
+                    ${js};
+                    return result;
+                }())
+            `);
+                // Call real callback
+                global.document.controller.uploadFileCallBack(data);
+            }
+
+            // Dynamically mock the iframe.contentWindow.document.close(); function
+            const handler = {
+                get: function (target, prop) {
+                    if (prop === 'contentWindow') {
+                        target.contentWindow.document.close = () => {
+                            var scripts = target.contentWindow.document.getElementsByTagName('script');
+                            for (let i = 0; i < scripts.length; i++) {
+                                const script = scripts[i];
+                                const js = DomUtil.elementValue(script);
+                                evalJSReturnedByUploadJSP(js);
+                            }
+                        }
+                    }
+                    return Reflect.get(...arguments);
+                }
+            };
+
+
+            // Intercept creation of iframe. returns a proxy which will intercept the iframe.contentWindow.document.close(); function
+            const _origiinalCreateElement = document.createElement;
+            global.document.createElement = (tagName) => {
+                const r = _origiinalCreateElement.call(document, tagName);
+                if (tagName === 'iframe') {
+                    const p = new Proxy(r, handler);
+                    return p;
+                }
+                return r;
+            };
+
+        });
+
+        it('works with successful post upload calls', async () => {
+            // Create a mock client and logon
+            const client = await Mock.makeClient();
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+
+            // Mock the upload protocol
+            // - the upload.jsp (which returns the content of an iframe and JS to eval)
+            // - call to xtk:counter#IncreaseValue (first, retrieve the schema xtk:counter then call the function)
+            // - call to xtk:session#Write
+            // - call to xtk:fileRes#PublishIfNeeded
+            // - call to xtk:fileRes#GetURL
+
+            client._transport.mockReturnValueOnce(Promise.resolve(`Ok 
+        <html xmlns="http://www.w3.org/1999/xhtml">
+            <head>
+              <script type="text/javascript">if(window.parent&&window.parent.document.controller&&"function"==typeof window.parent.document.controller.uploadFileCallBack){var aFilesInfo=new Array;aFilesInfo.push({paramName:"file",fileName:"test.txt",newFileName:"d8e8fca2dc0f896fd7cb4cb0031ba249.txt",md5:"d8e8fca2dc0f896fd7cb4cb0031ba249"}),window.parent.document.controller.uploadFileCallBack(aFilesInfo)}</script>
+            </head>
+        <body></body>
+        </html>`)); // upload.jsp
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_XTK_COUNTER_RESPONSE)); // GetEntityIfMoreRecentResponse - counter
+            client._transport.mockReturnValueOnce(Mock.INCREASE_VALUE_RESPONSE); // xtk:counter#IncreaseValue
+
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE); // GetEntityIfMoreRecentResponse - session
+            client._transport.mockReturnValueOnce(Mock.FILE_RES_WRITE_RESPONSE); // xtk:session#Write
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_FILERES_QUERY_SCHEMA_RESPONSE)); // GetEntityIfMoreRecentResponse - fileRes
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.PUBLISH_IF_NEEDED_RESPONSE)); // xtk:fileRes#PublishIfNeeded
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_URL_RESPONSE)); // xtk:fileRes#GetURL
+
+            // Call upload
+            const result = await client.fileUploader.upload({
+                type: 'text/html',
+                size: 12345
+            })
+            expect(result).toMatchObject({
+                md5: "d8e8fca2dc0f896fd7cb4cb0031ba249",
+                name: "test.txt",
+                size: 12345,
+                type: "text/html",
+                url: "http://hello.com"
+            });
+        })
+
+        it('throws error with dependant failures', async () => {
+            // Create a mock client and logon
+            const client = await Mock.makeClient();
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+
+            // Mock the upload protocol
+            // - the upload.jsp (which returns the content of an iframe and JS to eval)
+            // - call to xtk:counter#IncreaseValue (first, retrieve the schema xtk:counter then call the function)
+            // - call to xtk:session#Write
+            // - call to xtk:fileRes#PublishIfNeeded
+            // - call to xtk:fileRes#GetURL
+
+            client._transport.mockReturnValueOnce(Promise.reject(`Some error occurred!!!`));  // upload.jsp
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_XTK_COUNTER_RESPONSE));  // GetEntityIfMoreRecentResponse - counter
+            client._transport.mockReturnValueOnce(Mock.INCREASE_VALUE_RESPONSE);
+
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);  // GetEntityIfMoreRecentResponse - session
+            client._transport.mockReturnValueOnce(Mock.FILE_RES_WRITE_RESPONSE);  // xtk:session#Write
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_FILERES_QUERY_SCHEMA_RESPONSE));  // GetEntityIfMoreRecentResponse - fileRes
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.PUBLISH_IF_NEEDED_RESPONSE));  // xtk:fileRes#PublishIfNeeded
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_URL_RESPONSE));  // xtk:fileRes#GetURL
+            // For async handling
+            expect.assertions(1)
+            // Call upload
+            await client.fileUploader.upload({
+                type: 'text/html',
+                size: 12345,
+                name: 'abcd.txt'
+            }).catch((ex) => {
+                expect(ex.message).toMatch('500 - Error 16384: SDK-000013 "Failed to upload file abcd.txt. 500 - Error calling method \'/nl/jsp/uploadFile.jsp\': Some error occurred!!!');
+            })
+
+        })
+
+        it('throws error with not okay response', async () => {
+            // Create a mock client and logon
+            const client = await Mock.makeClient();
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+
+            // Mock the upload protocol
+            // - the upload.jsp (which returns the content of an iframe and JS to eval)
+            // - call to xtk:counter#IncreaseValue (first, retrieve the schema xtk:counter then call the function)
+            // - call to xtk:session#Write
+            // - call to xtk:fileRes#PublishIfNeeded
+            // - call to xtk:fileRes#GetURL
+
+            client._transport.mockReturnValueOnce(Promise.resolve(`Some error occurred!!!`));  // upload.jsp
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_XTK_COUNTER_RESPONSE));  // GetEntityIfMoreRecentResponse - counter
+            client._transport.mockReturnValueOnce(Mock.INCREASE_VALUE_RESPONSE);
+
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);  // GetEntityIfMoreRecentResponse - session
+            client._transport.mockReturnValueOnce(Mock.FILE_RES_WRITE_RESPONSE);  // xtk:session#Write
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_FILERES_QUERY_SCHEMA_RESPONSE));  // GetEntityIfMoreRecentResponse - fileRes
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.PUBLISH_IF_NEEDED_RESPONSE));  // xtk:fileRes#PublishIfNeeded
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_URL_RESPONSE));  // xtk:fileRes#GetURL
+            // For async handling
+            expect.assertions(1)
+            // Call upload
+            await client.fileUploader.upload({
+                type: 'text/html',
+                size: 12345,
+                name: 'abcd.txt'
+            }).catch((ex) => {
+                expect(ex.message).toMatch('500 - Error 16384: SDK-000013 "Failed to upload file abcd.txt. Some error occurred!!!');
+            })
+
+        })
+
+        it('throws error with malformed response', async () => {
+            // Create a mock client and logon
+            const client = await Mock.makeClient();
+            client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+            await client.NLWS.xtkSession.logon();
+
+            // Mock the upload protocol
+            // - the upload.jsp (which returns the content of an iframe and JS to eval)
+            // - call to xtk:counter#IncreaseValue (first, retrieve the schema xtk:counter then call the function)
+            // - call to xtk:session#Write
+            // - call to xtk:fileRes#PublishIfNeeded
+            // - call to xtk:fileRes#GetURL
+
+            client._transport.mockReturnValueOnce(Promise.resolve(`Ok 
+        <html xmlns="http://www.w3.org/1999/xhtml">
+            <head>
+              <script type="text/javascript">if(window.parent&&window.parent.document.controller&&"function"==typeof window.parent.document.controller.uploadFileCallBack){window.parent.document.controller.uploadFileCallBack([])}</script>
+            </head>
+        <body></body>
+        </html>`)); // upload.jsp
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_XTK_COUNTER_RESPONSE));  // GetEntityIfMoreRecentResponse - counter
+            client._transport.mockReturnValueOnce(Mock.INCREASE_VALUE_RESPONSE);
+
+            client._transport.mockReturnValueOnce(Mock.GET_XTK_SESSION_SCHEMA_RESPONSE);  // GetEntityIfMoreRecentResponse - session
+            client._transport.mockReturnValueOnce(Mock.FILE_RES_WRITE_RESPONSE);  // xtk:session#Write
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_FILERES_QUERY_SCHEMA_RESPONSE));  // GetEntityIfMoreRecentResponse - fileRes
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.PUBLISH_IF_NEEDED_RESPONSE));  // xtk:fileRes#PublishIfNeeded
+
+            client._transport.mockReturnValueOnce(Promise.resolve(Mock.GET_URL_RESPONSE));  // xtk:fileRes#GetURL
+            // For async handling
+            expect.assertions(1)
+            // Call upload
+            await client.fileUploader.upload({
+                type: 'text/html',
+                size: 12345,
+                name: 'abcd.txt'
+            }).catch((ex) => {
+                expect(ex.message).toMatch('500 - Error 16384: SDK-000013 "Failed to upload file abcd.txt. Malformed data:');
+            })
+
+        })
+    })
 });