@adobe/acc-js-sdk 1.1.38 → 1.1.40

package/docs/changeLog.html

@@ -3,6 +3,20 @@ layout: page
 title: Change Log
 ---
 
+<section class="changelog"><h1>Version 1.1.40</h1>
+  <h2>2023/09/27</h2>
+  <li>
+    Every upload creates a new iframe is added to the body tag which takes up some space resulting in the scrollbar. Fix this by allowing CSS attributes on the iFrame.
+  </li>
+</section>
+
+<section class="changelog"><h1>Version 1.1.39</h1>
+  <h2>2023/09/20</h2>
+  <li>
+    Fixed the name of the returned object when querying a temporary schema and when the result of the query is empty.
+  </li>
+</section>
+
 <section class="changelog"><h1>Version 1.1.38</h1>
   <h2>2023/09/06</h2>
   <li>

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@adobe/acc-js-sdk",
-  "version": "1.1.38",
+  "version": "1.1.40",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@adobe/acc-js-sdk",
-      "version": "1.1.38",
+      "version": "1.1.40",
       "license": "ISC",
       "dependencies": {
         "axios": "^1.2.1",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/acc-js-sdk",
-  "version": "1.1.38",
+  "version": "1.1.40",
   "description": "ACC Javascript SDK",
   "main": "src/index.js",
   "homepage": "https://github.com/adobe/acc-js-sdk#readme",

package/src/client.js

@@ -606,8 +606,12 @@ const fileUploader = (client) => {
                             throw okay;
                         }
                         const iframe = document.createElement('iframe');
+                        iframe.style.display = 'block';
                         iframe.style.height = 0;
                         iframe.style.width = 0;
+                        if(options && options.className) {
+                            iframe.className = options.className;
+                        }
                         document.controller = { // Written to  support https://git.corp.adobe.com/Campaign/ac/blob/v6-master/nl/datakit/nl/jsp/uploadFile.jsp
                             uploadFileCallBack: async (data) => {
                                 if (!data || data.length !== 1) {
@@ -1345,7 +1349,7 @@ class Client {
             else if (operation == "select" && emptyResult) {
                 const querySchemaId = EntityAccessor.getAttributeAsString(object, "schema");
                 const index = querySchemaId.indexOf(':');
-                const querySchemaName = querySchemaId.substr(index + 1);
+                const querySchemaName = querySchemaId.substr(index + 1).replace(':', '_');
                 outputParams[1].value[querySchemaName] = [];
             }
         }

package/test/client.test.js

@@ -1334,6 +1334,80 @@ describe('ACC Client', function () {
             expect(extAccount).toEqual({ extAccount: [] });
         });
 
+        it("select with empty result - temporary schema", async () => {
+          const client = await Mock.makeClient();
+          client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+          await client.NLWS.xtkSession.logon();
+
+          client._transport.mockReturnValueOnce(Mock.GET_XTK_QUERY_SCHEMA_RESPONSE);
+
+          client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
+          <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:queryDef' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
+            <SOAP-ENV:Body>
+              <ExecuteQueryResponse xmlns='urn:xtk:queryDef' SOAP-ENV:encodingStyle='http://schemas.xmlsoap.org/soap/encoding/'>
+                <pdomOutput xsi:type='ns:Element' SOAP-ENV:encodingStyle='http://xml.apache.org/xml-soap/literalxml'>
+                  <workflow_1047471_query2_result-collection/>
+                </pdomOutput>
+              </ExecuteQueryResponse>
+          </SOAP-ENV:Body></SOAP-ENV:Envelope>`));
+
+          var queryDef = {
+              "schema": "temp:workflow:1047471_query2_result",
+              "operation": "select",
+              "select": {
+                  "node": [
+                      { "expr": "@id" },
+                      { "expr": "@name" }
+                  ]
+              }
+          };
+
+          // Select should return empty array
+          var query = client.NLWS.xtkQueryDef.create(queryDef);
+          var temp = await query.executeQuery();
+          expect(temp).toEqual({ 'workflow_1047471_query2_result': [] });
+        });
+
+        it("select with results - temporary schema", async () => {
+          const client = await Mock.makeClient();
+          client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);
+          await client.NLWS.xtkSession.logon();
+
+          client._transport.mockReturnValueOnce(Mock.GET_XTK_QUERY_SCHEMA_RESPONSE);
+
+          client._transport.mockReturnValueOnce(Promise.resolve(`<?xml version='1.0'?>
+          <SOAP-ENV:Envelope xmlns:xsd='http://www.w3.org/2001/XMLSchema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ns='urn:xtk:queryDef' xmlns:SOAP-ENV='http://schemas.xmlsoap.org/soap/envelope/'>
+            <SOAP-ENV:Body>
+              <ExecuteQueryResponse xmlns='urn:xtk:queryDef' SOAP-ENV:encodingStyle='http://schemas.xmlsoap.org/soap/encoding/'>
+                <pdomOutput xsi:type='ns:Element' SOAP-ENV:encodingStyle='http://xml.apache.org/xml-soap/literalxml'>
+                  <workflow_1047471_query2_result-collection>
+                    <workflow_1047471_query3_result _keyfield0="1195" id="1195">
+                      <target _cs="rner20 joewar (joewarner20@fake_domain.com)"></target>
+                    </workflow_1047471_query3_result>
+                    <workflow_1047471_query3_result _keyfield0="1198" id="1198">
+                      <target _cs="aliberte23 troyla (troylaliberte23@fake_domain.com)"></target>
+                    </workflow_1047471_query3_result>
+                  </workflow_1047471_query2_result-collection>
+                </pdomOutput>
+              </ExecuteQueryResponse>
+          </SOAP-ENV:Body></SOAP-ENV:Envelope>`));
+
+          var queryDef = {
+              "schema": "temp:workflow:1047471_query2_result",
+              "operation": "select",
+              "select": {
+                  "node": [
+                      { "expr": "@id" },
+                      { "expr": "target"}
+                  ]
+              }
+          };
+
+          var query = client.NLWS.xtkQueryDef.create(queryDef);
+          var temp = await query.executeQuery();
+          expect(temp.workflow_1047471_query3_result.length).toBe(2);
+        });
+
         it("getIfExists with a result of exactly one element", async () => {
             const client = await Mock.makeClient();
             client._transport.mockReturnValueOnce(Mock.LOGON_RESPONSE);