@adobe/acc-js-sdk 1.1.11 → 1.1.12

package/docs/application.html

@@ -38,6 +38,7 @@ title: The Application Object
     <tr><td><b>login</b></td><td>the login name of the operator</td></tr>
     <tr><td><b>computeString</b></td><td>A human readable name for the operator</td></tr>
     <tr><td><b>timezone</b></td><td>The timezone of the operator</td></tr>
+    <tr><td><b>instanceLocale</b></td><td>The locale of the instance</td></tr>
     <tr><td><b>rights</b></td><td>An array of strings describing the rights of the operators</td></tr>
   </tbody>
 </table>

package/docs/changeLog.html

@@ -2,6 +2,13 @@
 layout: page
 title: Change Log
 ---
+<section class="changelog"><h1>Version 1.1.12</h1>
+  <h2>2022/11/16</h2>
+  
+  <li>Fix an issue with localization ids: do not generate localization ids for empty labels or descriptions</li>
+  <li>Add the instanceLocale attribute in the CurrentLogin object. This attribute returns the instance locale</li>
+</section>
+
 <section class="changelog"><h1>Version 1.1.11</h1>
 <h2>2022/11/09</h2>
 

package/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/acc-js-sdk",
-  "version": "1.1.11",
+  "version": "1.1.12",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/acc-js-sdk",
-  "version": "1.1.11",
+  "version": "1.1.12",
   "description": "ACC Javascript SDK",
   "main": "src/index.js",
   "homepage": "https://github.com/adobe/acc-js-sdk#readme",

package/src/application.js

@@ -669,10 +669,14 @@ class XtkSchemaNode {
             this._localizationId = this._localizationId + "__e____" + this.name;
           }
         }
-        this.labelLocalizationId = this._localizationId + "__@label";
-        this.descriptionLocalizationId = this._localizationId + "__@desc";
-        if (!this.parent) {
-            this.labelSingularLocalizationId = this._localizationId + "__@labelSingular";
+        if (this.label) {
+          this.labelLocalizationId = this._localizationId + "__@label";
+        }
+        if (this.description) {
+          this.descriptionLocalizationId = this._localizationId + "__@desc";
+        }
+        if (!this.parent && this.labelSingular) {
+          this.labelSingularLocalizationId = this._localizationId + "__@labelSingular";
         }
     }
 
@@ -1219,7 +1223,13 @@ class CurrentLogin {
          * @type {string}
          */
         this.timezone = EntityAccessor.getAttributeAsString(userInfo, "timezone");
-        
+       
+        /**
+         * The instance locale
+         * @type { string }
+         */
+        this.instanceLocale = EntityAccessor.getAttributeAsString(userInfo, "instanceLocale");
+
         /**
          * The llist of operator rights
          * @type {string[]}

package/test/application.test.js

@@ -2061,29 +2061,42 @@ describe('Application', () => {
         });
 
         describe("Translation ids", () => {
-          it("schema should have a correct label localization id", () => {
+          it("schema should not have label localization id when label does not exist", () => {
             const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='recipient' label='Recipients'/></schema>");
             const schema = newSchema(xml);
+            expect(schema.labelLocalizationId).toBeUndefined();
+            expect(schema.descriptionLocalizationId).toBeUndefined();
+          });
+
+          it("schema should have a correct label localization id", () => {
+            const xml = DomUtil.parse("<schema namespace='nms' name='recipient' label='Recipients' desc='Recipient table(profiles)'><element name='recipient' label='Recipients'/></schema>");
+            const schema = newSchema(xml);
             expect(schema.labelLocalizationId).toBe('nms__recipient__@label');
             expect(schema.descriptionLocalizationId).toBe('nms__recipient__@desc');
           });
 
           it("schema should have a correct singular label localization id", () => {
-            const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='recipient' label='Recipients'/></schema>");
+            const xml = DomUtil.parse("<schema namespace='nms' name='recipient' labelSingular='Recipient'><element name='recipient' label='Recipients'/></schema>");
             const schema = newSchema(xml);
             expect(schema.labelSingularLocalizationId).toBe('nms__recipient__@labelSingular');
           });
 
-          it("root node should have a correct label localization id", () => {
+          it("schema should not have singular label localization id when singular label does not exist", () => {
             const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='recipient' label='Recipients'/></schema>");
             const schema = newSchema(xml);
+            expect(schema.labelSingularLocalizationId).toBeUndefined();
+          });
+
+          it("root node should have a correct label localization id", () => {
+            const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='recipient' label='Recipients' desc='Recipients'/></schema>");
+            const schema = newSchema(xml);
             const root = schema.root;
             expect(root.labelLocalizationId).toBe('nms__recipient__e____recipient__@label');
             expect(root.descriptionLocalizationId).toBe('nms__recipient__e____recipient__@desc');
           });
 
           it("child node should have a correct label localization id", () => {
-            const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='lib' label='library'/><element name='recipient' label='Recipients'/></schema>");
+            const xml = DomUtil.parse("<schema namespace='nms' name='recipient'><element name='lib' label='library' desc='library'/><element name='recipient' label='Recipients'/></schema>");
             const schema = newSchema(xml);
             const lib = schema.children["lib"];
             expect(lib.labelLocalizationId).toBe('nms__recipient__e____lib__@label');
@@ -2093,7 +2106,7 @@ describe('Application', () => {
           it("attribute should have a correct label localization id", () => {
             const xml = DomUtil.parse(`<schema namespace='nms' name='recipient'>
                                             <element name='recipient' label='Recipients'>
-                                                <attribute name='email' type='string' label='email' length='3'/>
+                                                <attribute name='email' type='string' label='email'  desc='email' length='3'/>
                                             </element>
                                         </schema>`);
             const schema = newSchema(xml);
@@ -2141,13 +2154,15 @@ describe('Application', () => {
                 loginCS: "Alex",
                 timezone: "Europe/Paris",
                 "login-right": [
-                ]
+                ],
+                instanceLocale: "en"
             })
             expect(op.login).toBe("alex");
             expect(op.id).toBe(12);
             expect(op.computeString).toBe("Alex");
             expect(op.timezone).toBe("Europe/Paris");
             expect(op.rights).toEqual([]);
+            expect(op.instanceLocale).toBe("en");
         })
 
         it("Should support missing 'login-right' node", () => {