@adobe-commerce/elsie 1.3.1-alpha012 → 1.3.1-alpha014

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe-commerce/elsie",
-  "version": "1.3.1-alpha012",
+  "version": "1.3.1-alpha014",
   "license": "SEE LICENSE IN LICENSE.md",
   "description": "Domain Package SDK",
   "engines": {

package/src/components/Button/Button.css

@@ -55,8 +55,8 @@
 }
 
 /* Primary */
-button.dropin-button.dropin-button--primary,
-a.dropin-button.dropin-button--primary,
+.dropin-button--primary,
+a.dropin-button--primary,
 .dropin-iconButton--primary {
   border: none;
   background: var(--color-brand-500) 0 0% no-repeat padding-box;
@@ -72,8 +72,8 @@ a.dropin-button.dropin-button--primary,
   padding: var(--spacing-xsmall);
 }
 
-button.dropin-button.dropin-button--primary--disabled,
-a.dropin-button.dropin-button--primary--disabled,
+.dropin-button--primary--disabled,
+a.dropin-button--primary--disabled,
 .dropin-iconButton--primary--disabled {
   background: var(--color-neutral-300) 0 0% no-repeat padding-box;
   color: var(--color-neutral-500);
@@ -82,21 +82,21 @@ a.dropin-button.dropin-button--primary--disabled,
   user-select: none;
 }
 
-button.dropin-button.dropin-button--primary:hover,
-a.dropin-button.dropin-button--primary:hover,
+.dropin-button--primary:hover,
+a.dropin-button--primary:hover,
 .dropin-iconButton--primary:hover,
-button.dropin-button.dropin-button--primary:focus:hover,
+.dropin-button--primary:focus:hover,
 .dropin-iconButton--primary:focus:hover {
   background-color: var(--color-button-hover);
   text-decoration: none;
 }
 
-button.dropin-button.dropin-button--primary:focus,
+.dropin-button--primary:focus,
 .dropin-iconButton--primary:focus {
   background-color: var(--color-brand-500);
 }
 
-button.dropin-button.dropin-button--primary:hover:active,
+.dropin-button--primary:hover:active,
 .dropin-iconButton--primary:hover:active {
   background-color: var(--color-button-active);
 }

package/src/components/Icon/Icon.stories.tsx

@@ -14,8 +14,13 @@ import * as Icons from '@adobe-commerce/elsie/icons';
 
 /**
  * Use Icons as symbols or metaphors to communicate and enhance the user experience.
+ * 
+ * The Icon component supports three source types:
+ * - Direct component imports
+ * - Icon names from the built-in icon set
+ * - SVGs from URLs (supports URLs that match the host domain)
  */
-const meta: Meta<IconProps> = {
+const meta: Meta<StoryIconProps> = {
   title: 'Components/Icon',
   component: Icon,
   argTypes: {
@@ -25,6 +30,13 @@ const meta: Meta<IconProps> = {
       control: {
         type: 'select',
       },
+      description: 'Select a built-in icon',
+    },
+    url: {
+      control: {
+        type: 'text',
+      },
+      description: 'Or enter a URL to an external SVG (this takes priority over icon selection)',
     },
     size: {
       control: 'select',
@@ -33,6 +45,7 @@ const meta: Meta<IconProps> = {
     stroke: {
       control: 'select',
       options: ['1', '2', '3', '4'],
+      description: 'Stroke width. Works only for stroke-based icons.',
     },
     title: {
       control: 'text',
@@ -43,7 +56,11 @@ const meta: Meta<IconProps> = {
 
 export default meta;
 
-type Story = StoryObj<IconProps>;
+type Story = StoryObj<StoryIconProps>;
+
+interface StoryIconProps extends IconProps {
+  url?: string;
+}
 
 /**
  * ```ts
@@ -52,23 +69,26 @@ type Story = StoryObj<IconProps>;
  */
 
 export const Primary: Story = {
+  render: ({ url, source, ...args }: StoryIconProps) => {
+    const iconSource = url || source;
+    return <Icon {...args} source={iconSource as any} />;
+  },
   args: {
     source: Cart,
   },
 };
 
 export const Lazy: Story = {
-  argTypes: {
-    source: {
-      mapping: Object.keys(Icons),
-    },
+  render: ({ url, source, ...args }: StoryIconProps) => {
+    const iconSource = url || source;
+    return <Icon {...args} source={iconSource as any} />;
   },
   args: {
     source: 'Cart',
   },
 };
 
-export const AllIcons: Story = {
+export const AllBuiltInIcons: Story = {
   argTypes: {
     style: Object
   },
@@ -96,3 +116,72 @@ export const AllIcons: Story = {
     </div>
   ),
 };
+
+
+export const UrlExamples: Story = {
+  render: ({ url, ...args }: StoryIconProps) => (
+    <div style={{ 
+      display: 'grid', 
+      gridTemplateColumns: 'repeat(auto-fit, minmax(200px, 1fr))', 
+      gap: '2rem',
+      padding: '1rem'
+    }}>
+      <div style={{
+        border: '1px solid #e1e5e9',
+        borderRadius: '8px',
+        padding: '1.5rem',
+        textAlign: 'center',
+        backgroundColor: '#f8f9fa'
+      }}>
+        <h3 style={{ margin: '0 0 1rem 0', color: '#2c3e50' }}>✅ Valid URL</h3>
+        <Icon 
+          source={url || `${window.location.origin}/favicon.svg`}
+          size="12"
+          title="logo icon from common domain"
+          aria-label="Star icon loaded from external URL"
+          {...args}
+        />
+        <p style={{ 
+          fontSize: '12px', 
+          color: '#495057',
+          margin: '0.5rem 0 0 0',
+          wordBreak: 'break-all'
+        }}>
+          {url ? `Displays icon from: ${url}` : 'Displays icon from SVG'}
+        </p>
+      </div>
+      
+      <div style={{
+        border: '1px solid #f8d7da',
+        borderRadius: '8px',
+        padding: '1.5rem',
+        textAlign: 'center',
+        backgroundColor: '#f8d7da'
+      }}>
+        <h3 style={{ margin: '0 0 1rem 0', color: '#721c24' }}>❌ Invalid URL</h3>
+        <Icon 
+          source="https://invalid-url.com/icon.svg" 
+          size="32"
+          title="Failed to load icon"
+          aria-label="Icon that failed to load"
+        />
+        <p style={{ 
+          fontSize: '12px', 
+          color: '#721c24',
+          margin: '0.5rem 0 0 0',
+          wordBreak: 'break-all'
+        }}>
+          Shows empty SVG
+        </p>
+      </div>
+      
+    </div>
+  ),
+  parameters: {
+    docs: {
+      description: {
+        story: 'Examples of different URL formats supported by the Icon component.',
+      },
+    },
+  },
+};

package/src/components/Icon/Icon.tsx

@@ -10,6 +10,7 @@
 import { FunctionComponent } from 'preact';
 import { classes } from '@adobe-commerce/elsie/lib/classes';
 import { lazy, Suspense, SVGProps } from 'preact/compat';
+import { useState, useEffect } from 'preact/hooks';
 
 import '@adobe-commerce/elsie/components/Icon/Icon.css';
 
@@ -66,9 +67,10 @@ const lazyIcons = {
 };
 
 export interface IconProps extends Omit<SVGProps<SVGSVGElement>, 'size'> {
-  source:
-    | FunctionComponent<SVGProps<SVGSVGElement> & { title?: string }>
-    | IconType;
+  source?:
+  | FunctionComponent<SVGProps<SVGSVGElement> & { title?: string }>
+  | IconType
+  | string;
   size?: '12' | '16' | '24' | '32' | '64' | '80';
   stroke?: '1' | '2' | '3' | '4';
   className?: string;
@@ -79,6 +81,115 @@ export type IconNode = FunctionComponent<
   SVGProps<SVGSVGElement> & { title?: string }
 >;
 
+function isValidUrl(source: string): boolean { // check for URL from same domain
+  try {
+    if (source.startsWith('//')) {
+      const absoluteUrl = `${window.location.protocol}${source}`;
+      const url = new URL(absoluteUrl);
+      return url.hostname === window.location.hostname;
+    }
+    const url = new URL(source);
+    
+    if (url.hostname !== window.location.hostname) {
+      console.error(`[Icon] External URL rejected for security: ${source} - Only same-domain URLs are allowed`);
+      return false;
+    }
+    
+    return true;
+  } catch {
+    console.error(`[Icon] Invalid URL format: ${source}`);
+    return false;
+  }
+}
+
+function UrlSvgLoader({
+  url,
+  ...props
+}: SVGProps<SVGSVGElement> & { url: string }) {
+  const [svgContent, setSvgContent] = useState<string>('');
+  const [loading, setLoading] = useState(true);
+  const [error, setError] = useState(false);
+
+  useEffect(() => {
+    fetch(url)
+      .then(response => {
+        if (!response.ok) {
+          console.error(`[Icon] Failed to fetch SVG: ${response.status} ${response.statusText}`);
+          throw error;
+        }
+        return response.text();
+      })
+      .then(content => {
+        // Check if content is valid SVG
+        if (!content.trim().toLowerCase().startsWith('<?xml') && 
+            !content.trim().toLowerCase().startsWith('<svg')) {
+          console.error(`[Icon] Invalid SVG content from ${url} - Content must be a valid SVG file`);
+          setError(true);
+          setLoading(false);
+          return;
+        }
+
+        // Process SVG content to ensure proper sizing and accessibility
+        let processedContent = content;
+
+        if (props.width) {
+          processedContent = processedContent.replace(
+            /<svg([^>]*)\s+width\s*=\s*["'][^"']*["']/gi,
+            '<svg$1'
+          );
+          processedContent = processedContent.replace(
+            /<svg/i,
+            `<svg width="${props.width}"`
+          );
+        }
+
+        if (props.height) {
+          processedContent = processedContent.replace(
+            /<svg([^>]*)\s+height\s*=\s*["'][^"']*["']/gi,
+            '<svg$1'
+          );
+          processedContent = processedContent.replace(
+            /<svg/i,
+            `<svg height="${props.height}"`
+          );
+        }
+        
+        if (props.title) {
+          processedContent = processedContent.replace(/<title[^>]*>.*?<\/title>/gi, '');
+          processedContent = processedContent.replace(
+            /<svg([^>]*)>/i,
+            `<svg$1><title>${props.title}</title>`
+          );
+        }
+        
+        setSvgContent(processedContent);
+        setLoading(false);
+      })
+      .catch((error) => {
+        console.error(`[Icon] ${error.message}`);
+        setError(true);
+        setLoading(false);
+      });
+  }, [url, props.width, props.height, props.title]);
+
+  if (loading || error) {
+    return <svg {...props} />;
+  }
+
+  return (
+    <div
+      className={props.className}
+      style={{
+        width: String(props.width),
+        height: String(props.height),
+        display: 'inline-block',
+        lineHeight: 0,
+      }}
+      dangerouslySetInnerHTML={{ __html: svgContent }}
+    />
+  );
+}
+
 export function Icon({
   source: Source,
   size = '24',
@@ -87,7 +198,6 @@ export function Icon({
   className,
   ...props
 }: IconProps) {
-  const LazyIcon = typeof Source === 'string' ? lazyIcons[Source] : null;
 
   const defaultProps = {
     className: classes([
@@ -100,10 +210,27 @@ export function Icon({
     viewBox,
   };
 
+  if (typeof Source === 'string' && isValidUrl(Source)) {
+    return (
+      <Suspense fallback={<svg {...props} {...defaultProps} />}>
+        <UrlSvgLoader url={Source} {...props} {...defaultProps}/>
+      </Suspense>
+    );
+  }
+
+  const LazyIcon = typeof Source === 'string' && Source in lazyIcons
+    ? lazyIcons[Source as IconType]
+    : null;
+
+  const isRejectedUrl = typeof Source === 'string' && 
+    (Source.startsWith('http') || Source.startsWith('//') || Source.startsWith('/'));
+
   return (
     <Suspense fallback={<svg {...props} {...defaultProps} />}>
       {LazyIcon ? (
         <LazyIcon {...props} {...defaultProps} />
+      ) : isRejectedUrl ? (
+        <svg {...props} {...defaultProps} />
       ) : (
         // @ts-ignore
         <Source {...props} {...defaultProps} />