@admc.com/eslintplugin-sn-test 3.6.2 → 3.8.1

package/.eslintrc.json

@@ -4,7 +4,7 @@
   "env": { "es2022": true, "node": true },
   "extends": "eslint:recommended",
   "parserOptions": { "ecmaVersion": "latest" },
-  "ignorePatterns": ["goodScripts/**", "badScripts/**", "test/**"],
+  "ignorePatterns": ["*Scripts/**", "test/**"],
   "rules": {
     "camelcase": ["warn", { "properties": "never" }],
     "eqeqeq": "error",

package/bad1Scripts/all/sp_widget.client_script/gs.js

@@ -1 +1,13 @@
-if (gs.getUserName() === null) throw new Error("bad");
+function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	gs.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/namedFn.js

@@ -0,0 +1,13 @@
+function _unused($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/spaceBeforeFn.js

@@ -0,0 +1,13 @@
+ function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/statementBeforeFn.js

@@ -0,0 +1,14 @@
+console.info("helo");
+function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.link/backticks.js

@@ -0,0 +1,5 @@
+(scope) => {
+    "use strict";
+    const wid = scope.widget.id;
+	console.warn(`${wid} UPDATE02`);
+}

package/bad1Scripts/all/sys_ui_context_menu/backticks.js

@@ -0,0 +1,2 @@
+// eslint-disable-next-line max-len
+console.info(`The built-in variables are g_list ${g_list}, g_fieldName (${g_fieldName$}), g_sysId ${g_sysId}`);

package/bad1Scripts/scoped-es12/sp_widget.script/interpolateStr.js

@@ -0,0 +1,7 @@
+(function() {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info(`Set datum for client to (${input.data})`);
+    }
+})();

package/bad2Scripts/all/sp_widget.client_script/fnAssignment.js

@@ -0,0 +1,16 @@
+_unused = function($scope) {
+    /* I had to put this script under bad2Scripts instead of bad1Scripts to accommodate an
+     * ESLint bug where varsIgnorePatterns are sometimes not honored, including for "_unused". */
+    "use strict";
+    /* global _unused:writable */
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+};

package/bad2Scripts/all/sp_widget.client_script/ootbBoilerplate.js

@@ -0,0 +1,8 @@
+api.controller=function() {
+  // Have to satisfy "use strict" or would have to complicate eslintplugin-sn-test design to
+  // allow arbitrarily-specified number of failures, or at least add support for 3 failures.
+  // Doing this instead of eslint-disable notation since that notation would conflict with wrapping:
+  "use strict";
+  /* widget controller */
+  var c = this;
+};

package/goodScripts/all/sp_widget.client_script/cleanedBoilerplate.js

@@ -0,0 +1,9 @@
+api.controller=function() {
+  // Doing this instead of eslint-disable notation since that notation would conflict with wrapping:
+  "use strict";
+  // This is as close as can get to OOTB while not failing more basic rules that we don't
+  // want to test for here.
+  /* eslint-disable no-var,no-unused-vars */
+  /* widget controller */
+  var c = this;
+};

package/goodScripts/all/sp_widget.client_script/good.js

@@ -1,11 +1,13 @@
-let v = "four";
-const dblr = v=>{'use strict'; return v+v;};
-
-api.onLoad = function($scope) {
+function($scope) {
     "use strict";
-    console.info('Running api.onLoad');
-    $scope.thisRef = this;
-};
-
-v = dblr(v);
-console.info(window.name, v, jQuery("body").length, document.URL);
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/goodScripts/all/sp_widget.link/cleanedBoilerplate.js

@@ -0,0 +1,4 @@
+function link(scope, element, attrs, controller) {  // eslint-disable-line no-unused-vars
+    "use strict";
+  
+}

package/goodScripts/all/sp_widget.link/good.js

@@ -0,0 +1,9 @@
+(scope) => {
+    "use strict";
+    const fName = "splink/" + scope.widget.id + ":" + scope.$id;
+	console.warn("UPDATE02");
+    console.warn("scope", scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	scope.pneu = "new string";
+}

package/goodScripts/all/sys_ui_context_menu/good.js

@@ -0,0 +1,2 @@
+console.info("The built-in variables are g_list " + g_list + ", g_fieldName ("
+  + g_fieldName + "), g_sysId " + g_sysId);

package/goodScripts/scoped-es12/sp_widget.script/arrow.js

@@ -0,0 +1,7 @@
+(() => {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info("Set datum for client" + input.datum);
+    }
+})();

package/goodScripts/scoped-es12/sp_widget.script/good.js

@@ -0,0 +1,7 @@
+(function() {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info("Set datum for client" + input.datum);
+    }
+})();

package/goodScripts/scoped-es5/sp_widget.script/good.js

@@ -1,6 +1,6 @@
 (function() {
     if (input.datum) {
         data.datum = input.datum;
-        gs.info("Set datum for client");
+        gs.info("Set datum for client" + input.datum);
     }
 })();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.6.2",
+  "version": "3.8.1",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -27,10 +27,7 @@
     "@admc.com/sn/no-init-emptystring": "error"
   },
   "overrides": [
-    {
-      "files": ["**/sys_ui_script/*/*.js"],
-      "rules": { "@admc.com/sn/no-uiscript-curlyref": "error" }
-    }, { // ES6 overrides
+    {  // ES6 overrides
       "files": [ "**/@(noniso|iso)/*.js",
                  "**/@(sys_ui_script|sys_script_validator|sp_widget.client_script|sys_ux_data_broker_scriptlet)/all/*.js"],  // eslint-disable-line max-len
       "rules": {
@@ -56,6 +53,15 @@
         "prefer-spread": "error",
         "prefer-template": "error"
       }
+    }, {
+        // Reverting eslint-plugin-sn exceptions back, because we overrode them generally above
+        // when raising warnings to errors.
+        "files":
+          ["**/@(sys_ui_script|sp_widget.script|sp_widget.client_script|sp_widget.link)/*/*.js"],
+        "rules": {
+            "prefer-template": "off",
+            "no-template-curly-in-string": "off"
+        }
     }, {  // Overriding for ES12 IIFE scriptlets}
       "files": [
         "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script)/scoped-es12/*.js",  // eslint-disable-line max-len