@admc.com/eslintplugin-sn-test 3.6.1 → 3.8.0

package/.eslintrc.json

@@ -4,7 +4,7 @@
   "env": { "es2022": true, "node": true },
   "extends": "eslint:recommended",
   "parserOptions": { "ecmaVersion": "latest" },
-  "ignorePatterns": ["goodScripts/**", "badScripts/**", "test/**"],
+  "ignorePatterns": ["*Scripts/**", "test/**"],
   "rules": {
     "camelcase": ["warn", { "properties": "never" }],
     "eqeqeq": "error",
@@ -35,7 +35,7 @@
     "no-eval": "warn",
     "no-extra-label": "error",
     "no-extra-bind": "error",
-    "no-else-return": "error",
+    "no-else-return": ["error", {"allowElseIf": false}],
     "no-array-constructor": "warn",
     "new-cap": "error",
     "max-depth": "warn",
@@ -48,6 +48,13 @@
     "no-constructor-return": "error",
     "no-constant-binary-expression": "error",
     "array-callback-return": ["error", { "checkForEach": true }],
+    "no-unused-vars": ["error", {
+        "args": "all",
+        "argsIgnorePattern": "^_?dummy",
+        "caughtErrors": "all", 
+        "caughtErrorsIgnorePattern": "^_?dummy"
+    }],
+    "no-eq-null": "error",
 
     // Post-ES6
     "no-var": "error",
@@ -63,6 +70,8 @@
     "require-atomic-updates": "error",
     "no-unused-private-class-members": "error",
     "no-promise-executor-return": "error",
+    "prefer-rest-params": "error",
+    "prefer-spread": "error",
 
     // formatting
     "comma-spacing": "warn",

package/.gitattributes

@@ -1,18 +1,18 @@
 * text=auto
 
-*.bash eol=lf
-*.sh eol=lf
-*.ksh eol=lf
-*.csh eol=lf
-*.pem eol=lf
-*.cmd eol=crlf
-*.bat eol=crlf
-*.BAT eol=crlf
-*.CMD eol=crlf
-*.dsp eol=crlf
-*.sln eol=crlf
-*.vcproj eol=crlf
-*.reg eol=crlf
+*.bash text eol=lf
+*.sh text eol=lf
+*.ksh text eol=lf
+*.csh text eol=lf
+*.pem text eol=lf
+*.cmd text eol=crlf
+*.bat text eol=crlf
+*.BAT text eol=crlf
+*.CMD text eol=crlf
+*.dsp text eol=crlf
+*.sln text eol=crlf
+*.vcproj text eol=crlf
+*.reg text eol=crlf
 
 *.PNG -text
 *.png -text
@@ -52,8 +52,8 @@
 *.list text
 *.text text
 *.tpl text
-*.dsv lf
-*.html lf
+*.dsv text eol=lf
+*.html text eol=lf
 *.ent text
 *.xhtml text
 *.dtd text
@@ -97,8 +97,8 @@ makefile text
 *.csv text
 *.shtml text
 *.htm text
-*.js lf
-*.jsm lf
+*.js text eol=lf
+*.jsm text eol=lf
 *.sql text
 *.isq text
 *.nsq text
@@ -112,6 +112,6 @@ makefile text
 *.xsl text
 *.xslt text
 *.dtd text
-*.json lf
+*.json text eol=lf
 *.md text
 LICENSE text

package/bad1Scripts/all/sp_widget.client_script/fnAssignment.js

@@ -0,0 +1,13 @@
+dummy = function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+};

package/bad1Scripts/all/sp_widget.client_script/gs.js

@@ -1 +1,13 @@
-if (gs.getUserName() === null) throw new Error("bad");
+function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	gs.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/namedFn.js

@@ -0,0 +1,13 @@
+function dummy($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/ootbBoilerplate.js

@@ -0,0 +1,9 @@
+api.controller=function() {
+  // Doing this instead of eslint-disable notation since that notation would conflict with wrapping:
+  "use strict";
+  // This is as close as can get to OOTB while not failing more basic rules that we don't
+  // want to test for here.
+  /* eslint-disable no-var,no-unused-vars */
+  /* widget controller */
+  var c = this;
+};

package/bad1Scripts/all/sp_widget.client_script/spaceBeforeFn.js

@@ -0,0 +1,13 @@
+ function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/all/sp_widget.client_script/statementBeforeFn.js

@@ -0,0 +1,14 @@
+console.info("helo");
+function($scope) {
+    "use strict";
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/bad1Scripts/scoped-es12/sp_widget.script/interpolateStr.js

@@ -0,0 +1,7 @@
+(function() {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info(`Set datum for client to (${input.data})`);
+    }
+})();

package/bad1Scripts/scoped-es12/sys_ux_data_broker_transform/topLevelArrow.js

@@ -0,0 +1,5 @@
+(iput) => {
+    if (!iput.propertyName) return {"error" : "missing property name"};
+	gs.info(`transformTst:brokertran requested prop '${iput.propertyName}'`);
+	return `${gs.getProperty(iput.propertyName)}>`;
+}

package/goodScripts/all/sp_widget.client_script/good.js

@@ -1,11 +1,13 @@
-let v = "four";
-const dblr = v=>{'use strict'; return v+v;};
-
-api.onLoad = function($scope) {
+function($scope) {
     "use strict";
-    console.info('Running api.onLoad');
-    $scope.thisRef = this;
-};
-
-v = dblr(v);
-console.info(window.name, v, jQuery("body").length, document.URL);
+    const fName = "spclient/" + $scope.widget.id + ":" + $scope.$id;
+	console.warn("UPDATE02");
+    console.warn("$scope", $scope);
+	console.info("Executing " + fName + " with this", this);
+	this.thisVar = "I am here";  // To facilitate checking for this exact instance
+	console.info(fName + " inputs", this.inputs);
+	console.info(fName + " data", this.data);
+	console.info(fName + " options", this.options);
+	$scope.pneu = "new string";
+	console.info("this", this);
+}

package/goodScripts/all/sys_ux_client_script/arrowFnNoParen.js

@@ -0,0 +1,5 @@
+// Header comment
+a => {
+    console.info(`Something about ${a}`);
+}
+/* Tail comment */

package/goodScripts/all/sys_ux_client_script/arrowNoParam.js

@@ -0,0 +1,5 @@
+// Header comment
+() => {
+    console.info(`Something`);
+}
+/* Tail comment */

package/goodScripts/scoped-es12/sp_widget.script/good.js

@@ -0,0 +1,7 @@
+(function() {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info("Set datum for client" + input.datum);
+    }
+})();

package/goodScripts/scoped-es12/sys_ux_data_broker_transform/internalArrow.js

@@ -0,0 +1,5 @@
+function(iput) {
+    if (!iput.propertyNames) return {"error" : "missing property names"};
+    iput.propertyNames.forEach(p => { gs.info(`Next prop (${p})`); });
+    return null;
+}

package/goodScripts/scoped-es5/sp_widget.script/good.js

@@ -1,6 +1,6 @@
 (function() {
     if (input.datum) {
         data.datum = input.datum;
-        gs.info("Set datum for client");
+        gs.info("Set datum for client" + input.datum);
     }
 })();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.6.1",
+  "version": "3.8.0",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -22,14 +22,12 @@
     "eqeqeq": "error",
     "semi": "error",
     "no-extra-parens": "error",
+    "no-eq-null": "error",
     "@admc.com/sn/prefer-array-iterator": "error",
     "@admc.com/sn/no-init-emptystring": "error"
   },
   "overrides": [
-    {
-      "files": ["**/sys_ui_script/*/*.js"],
-      "rules": { "@admc.com/sn/no-uiscript-curlyref": "error" }
-    }, { // ES6 overrides
+    {  // ES6 overrides
       "files": [ "**/@(noniso|iso)/*.js",
                  "**/@(sys_ui_script|sys_script_validator|sp_widget.client_script|sys_ux_data_broker_scriptlet)/all/*.js"],  // eslint-disable-line max-len
       "rules": {
@@ -39,6 +37,8 @@
         "no-useless-rename": "error",
         "no-var": "error",
         "prefer-template": "error",
+        "prefer-rest-params": "error",
+        "prefer-spread": "error",
         "@admc.com/sn/no-client-gr": "error"
       }
     }, {  // ES 12 overrides
@@ -49,8 +49,19 @@
         "object-shorthand": "error",
         "no-useless-rename": "error",
         "no-var": "error",
+        "prefer-rest-params": "error",
+        "prefer-spread": "error",
         "prefer-template": "error"
       }
+    }, {
+        // Reverting eslint-plugin-sn exceptions back, because we overrode them generally above
+        // when raising warnings to errors.
+        "files":
+          ["**/@(sys_ui_script|sp_widget.script|sp_widget.client_script|sp_widget.link)/*/*.js"],
+        "rules": {
+            "prefer-template": "off",
+            "no-template-curly-in-string": "off"
+        }
     }, {  // Overriding for ES12 IIFE scriptlets}
       "files": [
         "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script)/scoped-es12/*.js",  // eslint-disable-line max-len