@admc.com/eslintplugin-sn-test 3.4.0 → 3.6.0

package/bad1Scripts/all/sys_ux_client_script/extraParam.js

@@ -0,0 +1,5 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "fx" }] */
+function fx({a, b}, c) {
+    console.info(`Something about ${a} and ${b} and ${c}`);
+}
+/* Tail comment */

package/bad1Scripts/all/sys_ux_client_script/spuriousRootExpr.js

@@ -0,0 +1,5 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "fx" }] */
+const c = "bonus";
+function fx({a, b}) {
+    console.info(`Something about ${a} and ${b} and ${c}`);
+}

package/bad1Scripts/all/sys_ux_data_broker_scriptlet/backticks.js

@@ -0,0 +1,5 @@
+function(iput) {
+    if (!iput.propertyName) return {"error" : "missing property name"};
+	gs.info(`getCappedProp:brokerscr  input (${iput.propertyName})`);
+	return "Z" + (iput.propertyName + iput.propertyName).toUpperCase();
+

package/bad1Scripts/scoped-es5/sys_ux_data_broker_transform/let.js

@@ -0,0 +1,5 @@
+function(iput) {
+    if (!iput.pattern) return {"error" : "missing property pattern"};
+	let x = 3;
+	return 45;
+}

package/bad2Scripts/all/sys_ux_client_script/tradWSemi.js

@@ -0,0 +1,5 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "fx" }] */
+function fx({a, b}) {
+    console.info(`Something about ${a} and ${b}`);
+};
+/* Tail comment */

package/goodScripts/all/sys_ux_client_script/arrowFn.js

@@ -0,0 +1,5 @@
+// Header comment
+({a, b}) => {
+    console.info(`Something about ${a} and ${b}`);
+}
+/* Tail comment */

package/goodScripts/all/sys_ux_client_script/arrowFnBodyShortcut1L.js

@@ -0,0 +1,4 @@
+// a comment
+({a, b}) => console.info(`About ${a}`) || console.info(`About ${b}`)
+/* multi
+ * line */

package/goodScripts/all/sys_ux_client_script/arrowFnBodyShortcutML.js

@@ -0,0 +1,5 @@
+// comment
+({a, b}) =>
+    console.info(`About ${a}`) ||
+    console.info(`About ${b}`)
+/* multi line*/

package/goodScripts/all/sys_ux_client_script/arrowFnEmptyParam1L.js

@@ -0,0 +1,4 @@
+// eslint-disable-next-line no-empty-pattern
+({}) => { console.info("No params"); }
+
+/* post comment */

package/goodScripts/all/sys_ux_client_script/arrowFnEmptyParamML.js

@@ -0,0 +1,7 @@
+// eslint-disable-next-line no-empty-pattern
+({}) => {
+    console.info("No params");
+}
+
+/* post
+ * comment */

package/goodScripts/all/sys_ux_client_script/arrowFnNoParams1L.js

@@ -0,0 +1 @@
+() => { console.info("No params"); }

package/goodScripts/all/sys_ux_client_script/arrowFnNoParamsML.js

@@ -0,0 +1,9 @@
+/* pre
+ * comment
+ */
+() => {
+    console.info("No params");
+}
+/* post
+ * comment
+ */

package/goodScripts/all/sys_ux_client_script/tradCompleteAnonyFn.js

@@ -1,5 +1,5 @@
 // Header comment
 (function({a, b}) {
     console.info(`Something about ${a} and ${b}`);
-});
+})
 /* Tail comment */

package/goodScripts/all/sys_ux_client_script_include/arrowExtraParam.js

@@ -0,0 +1,4 @@
+({a, b}, c, d) => {
+    console.info(`Something about ${a} and ${b} and ${c} and ${d}`);
+}
+/* Tail comment */

package/goodScripts/all/sys_ux_client_script_include/tradExtraParam.js

@@ -0,0 +1,5 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "fx" }] */
+function fx({a, b}, c) {
+    console.info(`Something about ${a} and ${b} and ${c}`);
+}
+/* Tail comment */

package/goodScripts/all/sys_ux_data_broker_scriptlet/good.js

@@ -0,0 +1,4 @@
+function(iput) {
+    if (!iput.propertyName) return {"error" : "missing property name"};
+	return (iput.propertyName + iput.propertyName).toUpperCase();
+}

package/goodScripts/scoped-es12/sys_ux_data_broker_transform/good.js

@@ -0,0 +1,5 @@
+function(iput) {
+    if (!iput.propertyName) return {"error" : "missing property name"};
+	gs.info(`transformTst:brokertran requested prop '${iput.propertyName}'`);
+	return `${gs.getProperty(iput.propertyName)}>`;
+}

package/goodScripts/scoped-es5/sys_ux_data_broker_transform/good.js

@@ -0,0 +1,4 @@
+function(iput) {
+    if (!iput.pattern) return {"error" : "missing property pattern"};
+	return 45;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.4.0",
+  "version": "3.6.0",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -9,7 +9,7 @@
   "extends": ["plugin:@admc.com/sn/servicenow"],
 
   // Following are overrides which escalate warns to errors.
-  // Tests only work if the leve is error because we check only snLint/eslint return value,
+  // Tests only work if the level is error because we check only snLint/eslint return value,
   // not the stdout or stderr.
   "rules": {
     "no-implied-eval": "error",
@@ -31,7 +31,7 @@
       "rules": { "@admc.com/sn/no-uiscript-curlyref": "error" }
     }, { // ES6 overrides
       "files": [ "**/@(noniso|iso)/*.js",
-                 "**/@(sys_ui_script|sys_script_validator|sp_widget.client_script)/all/*.js"],
+                 "**/@(sys_ui_script|sys_script_validator|sp_widget.client_script|sys_ux_data_broker_scriptlet)/all/*.js"],  // eslint-disable-line max-len
       "rules": {
         "strict": ["error", "function"],
         "prefer-arrow-callback": "error",
@@ -68,6 +68,9 @@
     }, { // Condition scriptlets
       "files": [ "**/*.condition/*/*.js"],
       "rules": { "strict": "off", "semi": "off" }
+    }, { // NE sys_ux scripts don't need and can't use "use strict"
+      "files": [ "**/sys_ux_*/*/*.js"],
+      "rules": { "strict": "off" }
     }
   ],
   "settings": {

package/goodScripts/all/sys_ux_client_script/ArrowFnNoParams.js

@@ -1,2 +0,0 @@
-// eslint-disable-next-line no-empty-pattern
-({}) => { console.info("No params"); };