@admc.com/eslintplugin-sn-test 3.13.1 → 3.15.0

package/bad1Scripts/global/sys_atf_step_config.description_generator/es12.js

@@ -1,4 +1,5 @@
 (function() {
     "use strict";
-    return `I am ${gs.getUserName()}`;
+    let v = gs.getUserName;
+    return `I am ${v}`;
 })();

package/bad1Scripts/global/sys_security_acl/let.js

@@ -0,0 +1,2 @@
+let x = 3;
+gs.log(x, "logSrc");

package/bad1Scripts/global/sys_security_acl/scopedLog.js

@@ -1 +1 @@
-gs.info("scoped log");
+gs.info("message");

package/{bad1Scripts → goodScripts}/all/sys_ux_data_broker_scriptlet/backticks.js

@@ -1,5 +1,5 @@
 function(iput) {
     if (!iput.propertyName) return {"error" : "missing property name"};
 	console.info(`getCappedProp:brokerscr input (${iput.propertyName})`);
-	return "Z" + (iput.propertyName + iput.propertyName).toUpperCase();
+	return (iput.propertyName + iput.propertyName).toUpperCase();
 }

package/goodScripts/global/sys_security_acl/snc.js

@@ -0,0 +1 @@
+gs.log(typeof SNC.CanonicalName, "logSrc");

package/goodScripts/global/sysauto_script/arrow-0p.js

@@ -0,0 +1,6 @@
+const combine = () => {
+    const intP1 = 1;  // eslint-disable-line no-unused-vars
+    const intP2 = "two";  // eslint-disable-line no-unused-vars
+    return `${intP1}|${intP2}`;
+};
+gs.log(combine(), "logsrc");

package/goodScripts/global/sysauto_script/arrow-0pimpl.js

@@ -0,0 +1,4 @@
+const combine = () => {
+    return `1|two`;
+};
+gs.log(combine(), "logsrc");

package/goodScripts/global/sysauto_script/arrow-1line.js

@@ -0,0 +1,2 @@
+// eslint-disable-next-line no-unused-vars
+const combine = (p1,p2) => { const q1 = p1; const q2 = p2; return `${q1}|${q2}`; }; gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/arrow-iife.js

@@ -0,0 +1,5 @@
+gs.log(((p1, p2) => {
+    const inP1 = p1;  // eslint-disable-line no-unused-vars
+    const inP2 = p2;  // eslint-disable-line no-unused-vars
+    return `${inP1}|${inP2}`;
+})(1, "two"), "logSrc");

package/goodScripts/global/sysauto_script/arrow-iifeimpl1line.js

@@ -0,0 +1 @@
+gs.log(((p1, p2) => `${p1}|${p2}`)(1, "two"), "logsrc");  // eslint-disable-line no-unused-vars

package/goodScripts/global/sysauto_script/arrow-impl.js

@@ -0,0 +1,5 @@
+// eslint-disable-next-line no-unused-vars
+const combine = (p1, p2) =>
+    `${p1}|${p2}`
+;
+gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/arrow-impl1line.js

@@ -0,0 +1,2 @@
+// eslint-disable-next-line no-unused-vars
+const combine = (p1, p2) => `${p1}|${p2}`; gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/arrow-implmline.js

@@ -0,0 +1,9 @@
+/* eslint-disable no-unused-vars */
+const combine
+  =
+  (p1, p2)   =>
+    `${p1}|
+    ${p2}`
+;
+/* eslint-enable no-unused-vars */
+gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/arrow-mline.js

@@ -0,0 +1,12 @@
+const
+  combine
+  =
+  (p1,
+  p2)   =>
+  {
+    const intP1 = p1;  // eslint-disable-line no-unused-vars
+    const intP2 = p2;  // eslint-disable-line no-unused-vars
+    return `${p1}|${p2}`;
+}
+;
+gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/arrow.js

@@ -0,0 +1,6 @@
+const combine = (p1, p2) => {
+    const inP1 = p1;  // eslint-disable-line no-unused-vars
+    const inP2 = p2;  // eslint-disable-line no-unused-vars
+    return `${inP1}|${inP2}`;
+};
+gs.log(combine(1, "two"), "logsrc");

package/goodScripts/global/sysauto_script/backtick.js

@@ -0,0 +1,3 @@
+const c = "A constant";  // eslint-disable-line no-unused-vars
+gs.log(`c =
+    (${c})`, "logSrc");

package/goodScripts/global-es12/sys_security_acl/snc.js

@@ -0,0 +1,2 @@
+"use strict";
+gs.log(typeof SNC.CanonicalName, "logSrc");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.13.1",
+  "version": "3.15.0",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -28,7 +28,15 @@
     "@admc.com/sn/no-gr-count-iterate": "error"
   },
   "overrides": [
-    {  // ES6 overrides
+    {  // JS Level checks.  Not needed for end user linting.
+      "files": [ "**/scoped-es12/*.js", "global-es12/*.js",
+                 "**/sys_variable_value/s*_scoped-es12/*.js" ],
+      "rules": { "@admc.com/sn/supports-let": "error" }
+    }, {  // JS Level checks.  Not needed for end user linting.
+      "files": ["**/@(ecc_agent_script|ecc_agent_script_include|sa_pattern)/all/*.js",
+                "**/global/*.js"],
+      "rules": { "@admc.com/sn/supports-let": ["error", "invert"] }
+    }, {  // ES6 overrides
       "files": [ "**/@(noniso|iso)/*.js",
                  "**/@(sys_ui_script|sys_script_validator|sp_widget.client_script|sys_ux_data_broker_scriptlet|sp_widget.link|sys_ui_context_menu)/all/*.js"],  // eslint-disable-line max-len
       "rules": {
@@ -43,7 +51,8 @@
         "@admc.com/sn/no-client-gr": "error"
       }
     }, {  // ES 12 overrides
-      "files": [ "**/scoped-es12/*.js", "**/sys_variable_value/s*_scoped-es12/*.js" ],
+      "files": [ "**/scoped-es12/*.js", "**/global-es12/*.js",
+                 "**/sys_variable_value/s*_scoped-es12/*.js" ],
       "rules": {
         "strict": ["error", "global"],
         "prefer-arrow-callback": "error",
@@ -58,7 +67,7 @@
       "files": [ "**/catalog_script_client/*/*.js" ],
       "rules": { "@admc.com/sn/no-backtick-curlyref": "error" }
     }, {  // Same reason as the warn-to-error overides above, but rule applies only to some scripts.
-      "files": [ "**/global/*.js", "**/sys_variable_value/s*_global/*.js" ],
+      "files": [ "**/global/*.js", "**/global-es12/*.js", "**/sys_variable_value/s*_global/*.js" ],
       "rules": { "@admc.com/sn/no-log-console": "error" }
     }, {
         // Reverting eslint-plugin-sn exceptions back, because we overrode them generally above
@@ -70,9 +79,7 @@
         "files": ["**/sys_ux_data_broker_scriptlet/all/*.js"],
         "rules": {
             "@admc.com/sn/single-fn": ["error", { "table": "sys_ux_data_broker_scriptlet" }],
-            "prefer-template": "off",
             "@admc.com/sn/no-toplvl-arrow-fn": "error",
-            "@admc.com/sn/no-backticks": "error",
             "strict": "off"
         }
     }, {