@admc.com/eslintplugin-sn-test 3.12.0 → 3.12.1

package/bad1Scripts/global/sys_script_include/nestedVar.js

@@ -0,0 +1 @@
+for (var i = 0; i < 10; i++) gs.log(i, "src");

package/bad2Scripts/global/sys_script/noVarOnTop.js

@@ -0,0 +1,13 @@
+(function() {
+// Test availability of global vars from the different component lists:
+gs.log("a message", "a source");  // coreServerObjects.txt
+gs.log(SNC.CMDBUtil.getTables0("sys_db_object"), "src");  // directly in exports.js
+gs.log(Object.keys(new sn_codesearch.CodeSearch()).length, "src");  // SIScopes
+
+var varsAreAllowed = "a val";
+gs.log(varsAreAllowed, "2nd");
+
+const con = "a val";
+con += "addition";  // Can't test for const changes
+gs.log(con, "2nd");
+})(previous, current);

package/goodScripts/global/sys_script/good.js

@@ -1,13 +1,14 @@
 (function() {
+var varsAreAllowed;
+const con = "a val";
 // Test availability of global vars from the different component lists:
 gs.log("a message", "a source");  // coreServerObjects.txt
 gs.log(SNC.CMDBUtil.getTables0("sys_db_object"), "src");  // directly in exports.js
 gs.log(Object.keys(new sn_codesearch.CodeSearch()).length, "src");  // SIScopes
 
-var varsAreAllowed = "a val";
+varsAreAllowed = "a val";
 gs.log(varsAreAllowed, "2nd");
 
-const con = "a val";
 con += "addition";  // Can't test for const changes
 gs.log(con, "2nd");
 })(previous, current);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.12.0",
+  "version": "3.12.1",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -57,6 +57,13 @@
     }, {  // Same reason as the warn-to-error overides above, but rule applies only to some scripts.
       "files": [ "**/catalog_script_client/*/*.js" ],
       "rules": { "@admc.com/sn/no-backtick-curlyref": "error" }
+    }, {  // Same reason as the warn-to-error overides above, but rule applies only to some scripts.
+      "files": [
+          "**/@(global|iso_global|noniso_global)/*.js", "**/sys_variable_value/s*_global/*.js" ],
+      "rules": { "vars-on-top": "error" }
+    }, {  // Same reason as the warn-to-error overides above, but rule applies only to some scripts.
+      "files": [ "**/global/*.js", "**/sys_variable_value/s*_global/*.js" ],
+      "rules": { "@admc.com/sn/no-log-console": "error" }
     }, {
         // Reverting eslint-plugin-sn exceptions back, because we overrode them generally above
         // when raising warnings to errors.