@admc.com/eslintplugin-sn-test 3.11.0 → 3.11.2

package/bad1Scripts/all/sys_script_validator/interpolateStr.js

@@ -0,0 +1,5 @@
+function validate() {
+    "use strict";
+    const msg = "client log";
+    console.info(`Message: ${msg}`);
+}

package/bad1Scripts/iso/catalog_script_client/interpolateStr.js

@@ -0,0 +1 @@
+console.info(`TABLE: ${g_form.getTableName()}`);

package/bad1Scripts/scoped-es12/sysevent_in_email_action/ootbBoilerplate.js

@@ -1,5 +1,5 @@
-"use strict";
 (function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    "use strict";
 
 	// Implement email action here
     logger.info(`Input params (${current}) (${event}) (${email}) (${classifier})`);

package/bad1Scripts/scoped-es5/sp_widget.script/globalLog.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     if (input.datum) {
         data.datum = input.datum;
         gs.log("Set datum for client", "src");

package/bad1Scripts/scoped-es5/sys_script/brCurrentUpdate.js

@@ -1,3 +1,4 @@
 (function() {
+"use strict";
 if (!current.update("update notation")) throw new Error("update failed");
 })(previous, current);

package/bad1Scripts/sss_scoped-es12/sys_variable_value/noIife.js

@@ -0,0 +1,2 @@
+const aStr = "thing";
+gs.info(aStr);

package/goodScripts/all/sys_script_validator/noInterp.js

@@ -0,0 +1,5 @@
+function validate() {
+    "use strict";
+    const msg = "client log";
+    console.info("Message: " + msg);
+}

package/goodScripts/iso/catalog_script_client/noInterp.js

@@ -0,0 +1 @@
+console.info("TABLE: " + g_form.getTableName());

package/goodScripts/scoped-es12/sp_widget.script/noInterp.js

@@ -0,0 +1,7 @@
+(function() {
+    "use strict";
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info("Set datum for client to (" + input.data + ')');
+    }
+})();

package/goodScripts/scoped-es12/sys_atf_step_config.step_execution_generator/nice.js

@@ -1,4 +1,4 @@
-"use strict";
-(() => {  // eslint-disable-next-line array-callback-return
+(() => {
+    "use strict";  // eslint-disable-next-line array-callback-return
     ["u_a", "u_b", "u_c"].forEach(n => outputs[n] = inputs[n]);
 })(inputs, outputs, stepResult, timeout);

package/goodScripts/scoped-es12/sysevent_in_email_action/cleanedBoilerplate.js

@@ -1,4 +1,4 @@
-"use strict";
 (function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    "use strict";
     logger.info(`Input params (${current}) (${event}) (${email}) (${classifier})`);
 })(current, event, email, logger, classifier);

package/goodScripts/scoped-es5/sp_widget.script/good.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     if (input.datum) {
         data.datum = input.datum;
         gs.info("Set datum for client" + input.datum);

package/goodScripts/scoped-es5/sys_processor/scopedLogging.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     gs.debug("Single-param");
     gs.info("Multi-{1} with {0} placeholders", 2, "param");
     var dynamicMsg = "Does not contain placeholders";

package/goodScripts/scoped-es5/sys_script/glideDateDV.js

@@ -1,4 +1,5 @@
 (function() {
+"use strict";
 // This is the supported replacement for obsoleted gs.now() function:
 gs.info("Today in UTF is " + new GlideDate().getDisplayValue());
 })(previous, current);

package/goodScripts/scoped-es5/sys_script/good.js

@@ -1,4 +1,5 @@
 (function() {
+"use strict";
 // Test availability of scoped vars from the different component lists:
 gs.info(new sn_ws_err.NotAcceptableError("fake err"));  // coreServerObjects.txt
 gs.info(Object.keys(new sn_codesearch.CodeSearch()).length);  // SIScopes

package/goodScripts/scoped-es5/sys_script_email/good.js

@@ -1,3 +1,4 @@
 (function(thing) {
+    "use strict";
     gs.info(thing);
 })(email, email_action, event, current, template);

package/goodScripts/scoped-es5/sys_transform_map/good.js

@@ -1,3 +1,4 @@
 (function() {
+    "use strict";
     gs.info("scoped log");
 })(source, target, map, log, action==="update");

package/goodScripts/sin_scoped-es12/sys_variable_value/sysid.js

@@ -0,0 +1,3 @@
+"use strict";
+const aSysId = "123456789012345678901234567890ab";
+gs.info(aSysId);

package/goodScripts/sss_scoped-es12/sys_variable_value/safeNoIife.js

@@ -0,0 +1,20 @@
+gs.info(`Provided functions:
+${jasmine}
+${describe}
+${xdescribe}
+${fdescribe}
+${it}
+${xit}
+${fit}
+${beforeEach}
+${beforeAll}
+${afterEach}
+${afterAll}
+${expect}
+${fail}
+${pending}
+${spyOn}
++ input Params:
+${steps}
+${params}
+`);

package/goodScripts/sss_scoped-es12/sys_variable_value/sysid.js

@@ -0,0 +1,24 @@
+((steps, params) => {
+    "use strict";
+    gs.info(`Provided functions:
+${jasmine}
+${describe}
+${xdescribe}
+${fdescribe}
+${it}
+${xit}
+${fit}
+${beforeEach}
+${beforeAll}
+${afterEach}
+${afterAll}
+${expect}
+${fail}
+${pending}
+${spyOn}
++ input Params:
+${steps}
+${params}
+`);
+    gs.info("123456789012345678901234567890ab");
+})(outputs, steps, params, stepResult, assertEqual);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.11.0",
+  "version": "3.11.2",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",

package/sneslintrc.json

@@ -43,7 +43,7 @@
         "@admc.com/sn/no-client-gr": "error"
       }
     }, {  // ES 12 overrides
-      "files": [ "**/scoped-es12/*.js" ],
+      "files": [ "**/scoped-es12/*.js", "**/sys_variable_value/s*_scoped-es12/*.js" ],
       "rules": {
         "strict": ["error", "global"],
         "prefer-arrow-callback": "error",
@@ -54,19 +54,24 @@
         "prefer-spread": "error",
         "prefer-template": "error"
       }
+    }, {  // Same reason as the warn-to-error overides above, but rule applies only to some scripts.
+      "files": [ "**/catalog_script_client/*/*.js" ],
+      "rules": { "@admc.com/sn/no-backtick-curlyref": "error" }
     }, {
         // Reverting eslint-plugin-sn exceptions back, because we overrode them generally above
         // when raising warnings to errors.
         "files":
-          ["**/@(sys_ui_script|sp_widget.script|sp_widget.client_script|sp_widget.link|sp_widget.link|sys_ui_context_menu)/*/*.js"],
-        "rules": {
-            "prefer-template": "off",
-            "no-template-curly-in-string": "off"
-        }
-    }, {  // Overriding for ES12 IIFE scriptlets}
+          ["**/@(sys_ui_script|sp_widget.script|sp_widget.client_script|sp_widget.link|sys_ui_context_menu)/*/*.js"],
+        "rules": { "no-template-curly-in-string": "off" }
+    }, {
+        "files":
+          ["**/@(sys_ui_script|sp_widget.script|sp_widget.client_script|sp_widget.link|sys_ui_context_menu|sys_script_validator|catalog_script_client)/*/*.js"],
+        "rules": { "prefer-template": "off" }
+    }, {  // Overriding for ES5+ IIFE scriptlets}
       "files": [
-        "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script)/scoped-es12/*.js",  // eslint-disable-line max-len
-        "**/sys_ui_action/@(iso|noniso)_scoped-es12/*.js"
+        "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script|sysevent_in_email_action|sys_atf_step_config.step_execution_generator)/scoped-es*/*.js",  // eslint-disable-line max-len
+        "**/sys_ui_action.script/@(iso|noniso)_scoped-es*/*.js",
+        "**/sys_variable_value/sss_scoped-es*/*.js"
       ],
       "rules": { "strict": ["error", "function"] }
     }, { // Custom table and scope