@admc.com/eslintplugin-sn-test 3.10.0 → 3.11.1

package/bad1Scripts/global/sys_atf_step_config.description_generator/es12.js

@@ -0,0 +1,4 @@
+(function() {
+    "use strict";
+    return `I am ${gs.getUserName()}`;
+})();

package/bad1Scripts/global/sys_atf_step_config.description_generator/nonimmedIife.js

@@ -0,0 +1,7 @@
+function generateDescription() {
+    "use strict";
+    // the global variable 'step' represents the current glide record
+    var description = "X";
+	return description;
+}
+ generateDescription();

package/bad1Scripts/global/sys_atf_step_config.description_generator/ootbBoilerplate.js

@@ -0,0 +1,7 @@
+function generateDescription() {
+    // the global variable 'step' represents the current glide record
+    var description = "X";
+	// your code here
+	return description;
+}
+ generateDescription();

package/bad1Scripts/global/sys_atf_step_config.description_generator/scopedExpr.js

@@ -0,0 +1 @@
+`I am ${gs.getUserName()}`;

package/bad1Scripts/global/sys_atf_step_config.step_execution_generator/ootbBoilerplate.js

@@ -0,0 +1,55 @@
+// The inputs are a map of the variables defined in the inputs related list below.
+// Inputs are consumed in the step configuration. Input
+// values may be hardcoded or mapped from the outputs of a previous step.
+// If a test author using your step uses mapping to pass in an output from a previous 
+// test step then when referencing the input variable the mapping will be resolved 
+// automatically
+//  Example:
+//      var myRecords = new GlideRecord(inputs.table);
+//
+// The outputs are a map of the variables defined in the outputs related list.
+// Outputs should be set (assigned) in order to pass data out of a test step that
+// can be consumed my mapping as an input to subsequent steps. 
+//  Example:
+//      outputs.table = gr.getRecordClassName()
+//
+//
+// Note that inputs and outputs are strongly typed as defined in their variable definition.
+// Their behavior is the same as a dictionary defined field of the same type in a table.
+//
+// The stepResult is a simple API for controlling the step pass/fail and logging with three
+// methods:
+//      stepResult.setFailed: Causes step to fail
+//
+//      stepResult.setSuccess: Causes step to succeed
+//
+//      stepResult.setOutputMessage: Log a message to step results after step executes.
+//            Can only be called once or will overwrite previous 
+//            message
+//
+// If neither setFailed or setSuccess is called the default is to succeed.
+//
+// Example usage of step timeout in script
+//      var counter = 0;
+//      // 'timeout' is a field on the step form
+//      while (counter <= timeout) {
+//            if (desiredOutcome) {
+//                stepResult.setOutputMessage('Success!');
+//                stepResult.setSuccess();
+//                return;
+//            }
+//            counter++;
+//
+//            // When writing scripts in ATF, use waitOneSecond() instead of gs.sleep()
+//            // since gs.sleep() may not work in non-global scopes
+//            sn_atf.AutomatedTestingFramework.waitOneSecond();
+//      }
+//
+//      // desired outcome did not occur within the timeout
+//      stepResult.setOutputMessage('Failure!');
+//      stepResult.setFailed();
+//
+(function executeStep(inputs, outputs, stepResult, timeout) {
+    gs.log("Input params: " + inputs + " / " + outputs + " / " + stepResult + " / " + timeout,
+      "src");
+}(inputs, outputs, stepResult, timeout));

package/bad1Scripts/global/sys_script_email/wrongIifeParams.js

@@ -1,3 +1,3 @@
 (function() {
     gs.log("global log", "src");
-})(current, template, email, email_action, event, gs);
+})(current, template, email, email_action, event, other);

package/bad1Scripts/global/sysevent_in_email_action/ootbBoilerplate.js

@@ -0,0 +1,4 @@
+(function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    logger.log("Input params: " + current + " / " + event + " / " + email + " / " + classifier);
+	// Implement email action here
+})(current, event, email, logger, classifier);

package/bad1Scripts/scoped-es12/sysevent_in_email_action/ootbBoilerplate.js

@@ -0,0 +1,6 @@
+(function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    "use strict";
+
+	// Implement email action here
+    logger.info(`Input params (${current}) (${event}) (${email}) (${classifier})`);
+})(current, event, email, logger, classifier);

package/bad1Scripts/scoped-es5/sp_widget.script/globalLog.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     if (input.datum) {
         data.datum = input.datum;
         gs.log("Set datum for client", "src");

package/bad1Scripts/scoped-es5/sys_script/brCurrentUpdate.js

@@ -1,3 +1,4 @@
 (function() {
+"use strict";
 if (!current.update("update notation")) throw new Error("update failed");
 })(previous, current);

package/bad1Scripts/sss_scoped-es12/sys_variable_value/noIife.js

@@ -0,0 +1,2 @@
+const aStr = "thing";
+gs.info(aStr);

package/bad2Scripts/sss_global/sys_variable_value/ootbBoilerplate.js

@@ -0,0 +1,91 @@
+// You can use this step to execute a variety of server-side javascript tests including
+// jasmine tests and custom assertions
+//
+//
+// Pass or fail a step: Override the step outcome to pass or fail. This is ignored 
+//                      by jasmine tests
+//
+//  - Return true from the main function body to pass the step
+//  - Return false from the main function body to fail the step
+//
+//
+// outputs:       Pre-defined Step config Output variables to set on this step during 
+//                execution that are available to later steps
+//
+// steps(SYS_ID): A function to retrieve Output variable data from a step that executed
+//                earlier in the test. The desired step's sys_id is required
+//
+// params:        The current test run data set's parameter data including both 
+//                exclusive and shared parameters
+//
+//  Example:
+//
+//      // Test step 1 - add data
+//      var gr = new GlideRecord('sc_task');
+//      // If parameterized testing is enabled, parameters are stored in the params object
+//      gr.setValue('short_description', params.u_my_short_description)
+//      gr.setValue('caller', params.u_my_user.manager)
+//      // this sample step's Step config has Output variables named table and record_id
+//      outputs.table = 'sc_task';
+//      outputs.record_id = gr.insert();
+//
+//      // Test step 2 - access added data and validate
+//      // check that the record exists (or that business logic changed it)
+//      var gr = new GlideRecord("sc_task");
+//      gr.get(steps(PREVIOUS_STEP_SYS_ID).record_id);
+//      assertEqual({name: "task gr exists", shouldbe: true, value: gr.isValidRecord()});
+//
+//
+// stepResult.setOutputMessage: Log a message to step results after step executes.
+//                              Can only be called once or will overwrite previous 
+//                              message
+//
+//  Example:
+//
+//      var gr = new GlideRecord('sc_task');
+//      gr.setValue('short_description', 'verify task can be inserted');
+//      var grSysId = gr.insert();
+//      var justCreatedGR = new GlideRecord('sc_task');
+//      if (justCreatedGR.get(grSysId)) {
+//            stepResult.setOutputMessage("Successfully inserted task record");
+//            return true; // pass the step
+//      } else { 
+//            stepResult.setOutputMessage("Failed to insert task record");
+//            return false; // fail the step
+//      }
+//
+//
+// Note: describe is only supported in Global scope.
+// Use 'describe' to create a suite of test scripts and 'it' to define test expectations
+//
+//  Example jasmine test:
+//
+//      describe('my suite of script tests', function() {
+//            it('should meet expectations', function() {
+//                  expect(true).not.toBe(false);
+//            });
+//      });
+//      // make sure to uncomment jasmine.getEnv().execute(); outside the function body
+//
+//
+// assertEqual: A function used to compare that assertion.shouldbe == assertion.value;
+//              in case of failure it throws an Error and logs that the assertion by
+//              name has failed
+//
+//  Example:
+//
+//      var testAssertion = {
+//            name: "my test assertion",
+//            shouldbe: "expected value"
+//            value: "actual value",
+//      };
+//      assertEqual(testAssertion); // throws Error, logs message to test step output
+//
+(function(outputs, steps, params, stepResult, assertEqual) {
+    // add test script here
+    gs.log("Input params: " + outputs + " / " + steps + " / " + params + " / " + stepResult
+      + " / " + assertEqual, "src");
+
+})(outputs, steps, params, stepResult, assertEqual);
+// uncomment the next line to execute this script as a jasmine test
+//jasmine.getEnv().execute();

package/goodScripts/all/sp_widget.client_script/cleanedBoilerplate.js

@@ -1,5 +1,4 @@
 api.controller=function() {
-  // Doing this instead of eslint-disable notation since that notation would conflict with wrapping:
   "use strict";
   // This is as close as can get to OOTB while not failing more basic rules that we don't
   // want to test for here.

package/goodScripts/global/sys_atf_step_config.description_generator/expr.js

@@ -0,0 +1 @@
+"I am " + gs.getUserName();

package/goodScripts/global/sys_atf_step_config.description_generator/nice.js

@@ -0,0 +1,3 @@
+(function() {
+    return "I am " + gs.getUserName();
+})();

package/goodScripts/global/sys_atf_step_config.step_execution_generator/cleanedBoilerplate.js

@@ -0,0 +1,4 @@
+(function executeStep(inputs, outputs, stepResult, timeout) {
+    gs.log("Input params: " + inputs + " / " + outputs + " / " + stepResult + " / " + timeout,
+      "testing");
+}(inputs, outputs, stepResult, timeout));

package/goodScripts/global/sys_atf_step_config.step_execution_generator/nice.js

@@ -0,0 +1,4 @@
+(function(inputs, outputs, stepResult, timeout) {
+    gs.log("Input params: " + inputs + " / " + outputs + " / " + stepResult + " / " + timeout,
+      "src");
+})(inputs, outputs, stepResult, timeout);

package/goodScripts/global/sysevent_in_email_action/cleanedBoilerplate.js

@@ -0,0 +1,3 @@
+(function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    logger.log("Input params: " + current + " / " + event + " / " + email + " / " + classifier);
+})(current, event, email, logger, classifier);

package/goodScripts/scoped-es12/sys_atf_step_config.step_execution_generator/nice.js

@@ -0,0 +1,4 @@
+(() => {
+    "use strict";  // eslint-disable-next-line array-callback-return
+    ["u_a", "u_b", "u_c"].forEach(n => outputs[n] = inputs[n]);
+})(inputs, outputs, stepResult, timeout);

package/goodScripts/scoped-es12/sysevent_in_email_action/cleanedBoilerplate.js

@@ -0,0 +1,4 @@
+(function runAction(/*GlideRecord*/ current, /*GlideRecord*/ event, /*EmailWrapper*/ email, /*ScopedEmailLogger*/ logger, /*EmailClassifier*/ classifier) {
+    "use strict";
+    logger.info(`Input params (${current}) (${event}) (${email}) (${classifier})`);
+})(current, event, email, logger, classifier);

package/goodScripts/scoped-es5/sp_widget.script/good.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     if (input.datum) {
         data.datum = input.datum;
         gs.info("Set datum for client" + input.datum);

package/goodScripts/scoped-es5/sys_processor/scopedLogging.js

@@ -1,4 +1,5 @@
 (function() {
+    "use strict";
     gs.debug("Single-param");
     gs.info("Multi-{1} with {0} placeholders", 2, "param");
     var dynamicMsg = "Does not contain placeholders";

package/goodScripts/scoped-es5/sys_script/glideDateDV.js

@@ -1,4 +1,5 @@
 (function() {
+"use strict";
 // This is the supported replacement for obsoleted gs.now() function:
 gs.info("Today in UTF is " + new GlideDate().getDisplayValue());
 })(previous, current);

package/goodScripts/scoped-es5/sys_script/good.js

@@ -1,4 +1,5 @@
 (function() {
+"use strict";
 // Test availability of scoped vars from the different component lists:
 gs.info(new sn_ws_err.NotAcceptableError("fake err"));  // coreServerObjects.txt
 gs.info(Object.keys(new sn_codesearch.CodeSearch()).length);  // SIScopes

package/goodScripts/scoped-es5/sys_script_email/good.js

@@ -1,3 +1,4 @@
 (function(thing) {
+    "use strict";
     gs.info(thing);
 })(email, email_action, event, current, template);

package/goodScripts/scoped-es5/sys_transform_map/good.js

@@ -1,3 +1,4 @@
 (function() {
-    gs.info("scopedl og");
-})(source, target, isUpdate, map, log);
+    "use strict";
+    gs.info("scoped log");
+})(source, target, map, log, action==="update");

package/goodScripts/sin_scoped-es12/sys_variable_value/sysid.js

@@ -0,0 +1,3 @@
+"use strict";
+const aSysId = "123456789012345678901234567890ab";
+gs.info(aSysId);

package/goodScripts/sss_global/sys_variable_value/cleanedBoilerplate.js

@@ -0,0 +1,4 @@
+(function(outputs, steps, params, stepResult, assertEqual) {
+    gs.log("Input params: " + outputs
+        + " / " + steps + " / " + params + " / " + stepResult + " / " + assertEqual, "src");
+})(outputs, steps, params, stepResult, assertEqual);

package/goodScripts/sss_scoped-es12/sys_variable_value/cleanedBoilerplate.js

@@ -0,0 +1,4 @@
+((outputs, steps, params, stepResult, assertEqual) => {
+    "use strict";
+    gs.info(`Input params (${outputs}) (${steps}) (${params}) (${stepResult}) (${assertEqual})`);
+})(outputs, steps, params, stepResult, assertEqual);

package/goodScripts/sss_scoped-es12/sys_variable_value/safeNoIife.js

@@ -0,0 +1,20 @@
+gs.info(`Provided functions:
+${jasmine}
+${describe}
+${xdescribe}
+${fdescribe}
+${it}
+${xit}
+${fit}
+${beforeEach}
+${beforeAll}
+${afterEach}
+${afterAll}
+${expect}
+${fail}
+${pending}
+${spyOn}
++ input Params:
+${steps}
+${params}
+`);

package/goodScripts/sss_scoped-es12/sys_variable_value/sysid.js

@@ -0,0 +1,24 @@
+((steps, params) => {
+    "use strict";
+    gs.info(`Provided functions:
+${jasmine}
+${describe}
+${xdescribe}
+${fdescribe}
+${it}
+${xit}
+${fit}
+${beforeEach}
+${beforeAll}
+${afterEach}
+${afterAll}
+${expect}
+${fail}
+${pending}
+${spyOn}
++ input Params:
+${steps}
+${params}
+`);
+    gs.info("123456789012345678901234567890ab");
+})(outputs, steps, params, stepResult, assertEqual);

package/goodScripts/sss_scoped-es12/sys_variable_value/useGlobals.js

@@ -0,0 +1,23 @@
+((steps, params) => {
+    "use strict";
+    gs.info(`Provided functions:
+${jasmine}
+${describe}
+${xdescribe}
+${fdescribe}
+${it}
+${xit}
+${fit}
+${beforeEach}
+${beforeAll}
+${afterEach}
+${afterAll}
+${expect}
+${fail}
+${pending}
+${spyOn}
++ input Params:
+${steps}
+${params}
+`);
+})(outputs, steps, params, stepResult, assertEqual);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "3.10.0",
+  "version": "3.11.1",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",
@@ -25,9 +25,7 @@
   },
   "homepage": "https://github.com/unsaved/eslint-plugin-sn#readme",
   "dependencies": {
+    "@admc.com/eslint-plugin-sn": "^3.13.1",
     "mocha": "^10.0.0"
-  },
-  "peerDependencies": {
-    "@admc.com/eslint-plugin-sn": "^3.9.8"
   }
 }

package/sneslintrc.json

@@ -43,7 +43,7 @@
         "@admc.com/sn/no-client-gr": "error"
       }
     }, {  // ES 12 overrides
-      "files": [ "**/scoped-es12/*.js" ],
+      "files": [ "**/scoped-es12/*.js", "**/sys_variable_value/s*_scoped-es12/*.js" ],
       "rules": {
         "strict": ["error", "global"],
         "prefer-arrow-callback": "error",
@@ -63,10 +63,11 @@
             "prefer-template": "off",
             "no-template-curly-in-string": "off"
         }
-    }, {  // Overriding for ES12 IIFE scriptlets}
+    }, {  // Overriding for ES5+ IIFE scriptlets}
       "files": [
-        "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script)/scoped-es12/*.js",  // eslint-disable-line max-len
-        "**/sys_ui_action/@(iso|noniso)_scoped-es12/*.js"
+        "**/@(sys_script|sys_ws_operation|sys_web_service|sys_processor|sys_script_email|sys_transform_map|sys_transform_script|sp_widget.script|sys_ui_page.processing_script|sysevent_in_email_action|sys_atf_step_config.step_execution_generator)/scoped-es*/*.js",  // eslint-disable-line max-len
+        "**/sys_ui_action.script/@(iso|noniso)_scoped-es*/*.js",
+        "**/sys_variable_value/sss_scoped-es*/*.js"
       ],
       "rules": { "strict": ["error", "function"] }
     }, { // Custom table and scope