@admc.com/eslintplugin-sn-test 1.1.3 → 2.0.2

package/README.md

@@ -24,3 +24,5 @@ link (non-global) link feature, but this has side-effects since the intermediate
 at a shared location on your computer.
 Less invasive is to just manually wipe the subdirectory node_modules/@admc.com/eslint-plugin-sn/
 and replace it with a symlink (or copy) of the development eslint-plugin-sn project directory.
+Be aware that "npm update" will wipe the sym link and replace it with what is found from a
+regular module resolution.

package/badScripts/all/sp_widget.client_script/gs.js

@@ -0,0 +1 @@
+if (gs.getUserName() === null) throw new Error("bad");

package/badScripts/all/sys_ui_script/backtickRef.js

@@ -0,0 +1 @@
+console.info(`Value is ${location}`);

package/badScripts/all/sys_ui_script/curlyrefComment.js

@@ -0,0 +1 @@
+//  A ${curly + 3} expression in a comment

package/badScripts/global/sp_widget.script/noIife.js

@@ -0,0 +1,4 @@
+if (input.datum) {
+    data.datum = input.datum;
+    gs.log("Set datum for client", "src");
+}

package/badScripts/global/sp_widget.script/otherGlobal.js

@@ -0,0 +1,6 @@
+(function() {
+    if (uther.datum) {
+        data.datum = 'indication';
+        gs.log("Set datum for client", "src");
+    }
+})();

package/badScripts/scoped/sp_widget.script/globalLog.js

@@ -0,0 +1,6 @@
+(function() {
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.log("Set datum for client", "src");
+    }
+})();

package/goodScripts/all/sp_widget.client_script/good.js

@@ -0,0 +1,11 @@
+let v = "four";
+const dblr = v=>{'use strict'; return v+v;};
+
+api.onLoad = function($scope) {
+    "use strict";
+    console.info('Running api.onLoad');
+    $scope.thisRef = this;
+};
+
+v = dblr(v);
+console.info(window.name, v, jQuery("body").length, document.URL);

package/goodScripts/all/sys_ui_script/good.js

@@ -0,0 +1,2 @@
+console.info(location + ` now in  multi-line
+backtick string`);

package/goodScripts/global/sp_widget.script/good.js

@@ -0,0 +1,6 @@
+(function() {
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.log("Set datum for client", "src");
+    }
+})();

package/goodScripts/scoped/sp_widget.script/good.js

@@ -0,0 +1,6 @@
+(function() {
+    if (input.datum) {
+        data.datum = input.datum;
+        gs.info("Set datum for client");
+    }
+})();

package/goodScripts/sys_script_validator/good.js

@@ -1,4 +1,5 @@
-(function() {
+function validate() {
     "use strict";
-    console.info("all is well");
-})(value);
+    const msg = "client log";
+    console.info(msg);
+}

package/masterTest.js

@@ -5,9 +5,23 @@ if (!__filename.startsWith(process.cwd() + "/"))  // eslint-disable-line prefer-
 const relTestPath = __filename.substring(process.cwd().length + 1);
 const path = require("path");
 const fs = require("fs");
-const ex = /^test[/](good|bad)[/](?:(\w+)[/])?([\w.]+[/]\w+)-test[.]js$/.exec(relTestPath);
+const ex =
+  /^test[/](good|bad|reallybad)[/](?:(\w+)[/])?([\w.]+[/]\w+)-test[.]js$/.exec(relTestPath);
 if (!ex) throw new Error(`Bad test file path: ${relTestPath}`);
-const shouldSucceed = ex[1] === "good";
+let expectExitVal;
+switch (ex[1]) {
+    case "good":
+        expectExitVal = 0;
+        break;
+    case "bad":
+        expectExitVal = 1;
+        break;
+    case "reallybad":
+        expectExitVal = 253;
+        break;
+}
+if (expectExitVal === undefined)
+    throw new Error(`eslintplugin-sn-test framework doesn't support test sub-type '${ex[1]}'`);
 const altscope = ex[2];
 const tableBase = ex[3];
 // eslint-disable-next-line no-extra-parens, prefer-template
@@ -24,7 +38,6 @@ const childProcess = require("child_process").
   spawnSync(process.execPath, params, { stdio: "inherit" });
 
 it(altscope ? `${tableBase} | ${altscope}` : tableBase, () => {
-    if (shouldSucceed && childProcess.status !== 0
-      || !shouldSucceed && childProcess.status !== 1)
+    if (expectExitVal !== childProcess.status)
         throw new Error(`Failed with code ${childProcess.status}`);
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "1.1.3",
+  "version": "2.0.2",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",
@@ -28,6 +28,6 @@
     "mocha": "^10.0.0"
   },
   "peerDependencies": {
-    "@admc.com/eslint-plugin-sn": "^1.1.8"
+    "@admc.com/eslint-plugin-sn": "^2.0.8"
   }
 }

package/populateTest.bash

@@ -51,16 +51,17 @@ TMPFILE="$TMPDIR/${PROGNAME#.*}.$$"
 trap 'rm -f "$TMPFILE"' EXIT
 [ -d goodScripts ] || Abort "Directory 'goodScripts' is missing"
 [ -d badScripts ] || Abort "Directory 'badScripts' is missing"
-find goodScripts badScripts -name '*.js' > "$TMPFILE" ||
+[ -d reallybadScripts ] || Abort "Directory 'badScripts' is missing"
+find goodScripts badScripts reallybadScripts -name '*.js' > "$TMPFILE" ||
 Abort 'find command failed'
 [ -n "$REPLACE_MODE" ] && rm -rf test/good test/bad
 while read SCRIPT_PATH; do
     GB=
     case "$SCRIPT_PATH" in
-        badScripts/*) GB=bad;;
-        goodScripts/*) GB=good;;
+        badScripts/*|goodScripts/*|reallybadScripts/*) ;;
         *) Abort "Unexpected SCRIPT_PATH prefix: $SCRIPT_PATH";;
     esac
+    GB="${SCRIPT_PATH%%Scripts*}"
     REBASED="test/$GB/${SCRIPT_PATH#*Scripts/}"
     TEST_PATH="${REBASED%.js}-test.js"
     [ -e "$TEST_PATH" ] && {

package/{badScripts/global → reallyBadScripts}/invalid_table/invalidTable.js

@@ -1 +1,2 @@
+"use strict";
 if ([].forEach === undefined) throw new Error("Should never get this");

package/{badScripts → reallybadScripts/global}/invalid_table/invalidTable.js

@@ -1 +1,2 @@
+"use strict";
 if ([].forEach === undefined) throw new Error("Should never get this");

package/{badScripts → reallybadScripts}/invalid/sys_script/invalidAltscope.js

@@ -1 +1,2 @@
+"use strict";
 if ([].forEach === undefined) throw new Error("Should never get this");

package/sneslintrc.json

@@ -27,12 +27,15 @@
   },
   "overrides": [
     {
+      "files": ["**/sys_ui_script/*/*.js"],
+      "rules": { "@admc.com/sn/no-uiscript-curlyref": "error" }
+    },{ // ES6 overrides
       "files": [
-        "**//@(global|scoped)/*.js",
+        "**/@(global|scoped)/*.js",
         "**/sys_ui_action/@(iso|noniso)_@(global|scoped)action/*.js"
       ]
     },{ // ES6 overrides
-      "files": [ "**/@(noniso|iso)/*.js" ],
+      "files": [ "**/@(noniso|iso)/*.js", "**/@(sys_ui_script|sys_script_validator)/*.js"],
       "rules": {
         "strict": ["error", "safe"],
         "prefer-arrow-callback": "error",
@@ -40,7 +43,8 @@
         "no-useless-rename": "error",
         "no-var": "error",
         "prefer-template": "error"
-      },
+      }
+    }, {
       "files": [ "**/sys_ui_script/*.js" ],
       "rules": {
         "strict": ["error", "safe"],
@@ -53,14 +57,13 @@
       "files": [ "**/custom_table/custom_alt/*.js" ],
       "env": {"@admc.com/sn/sn_server_global": true },
       "rules": {
-         "@admc.com/sn/invalid-table-altscope": "off",
+         "@admc.com/sn/invalid-table-alt": "off",
          "@admc.com/sn/log-global-2-args": "error",
          "@admc.com/sn/no-log-scoped": "error"
        }
     }
   ],
   "settings": {
-    "customTables": ["custom_table"],
-    "customAlts": ["custom_alt"]
+    "customTables": {"custom_table": ["custom_alt"]}
   }
 }

package/badScripts/sys_script_validator/wrongIifeParam.js

@@ -1,4 +0,0 @@
-(function() {
-    "use strict";
-    console.info("all is well");
-})(window);

package/goodScripts/sys_ui_script/good.js

@@ -1,2 +0,0 @@
-const msg = "a ok";
-console.info(msg + " now");