@admc.com/eslintplugin-sn-test 1.0.0 → 1.0.3

package/.eslintrc.json

@@ -6,10 +6,8 @@
   "parserOptions": { "ecmaVersion": "latest" },
   "ignorePatterns": ["goodScripts/**", "badScripts/**", "test/**"],
   "rules": {
-    "camelcase": "warn",
+    "camelcase": ["warn", { "properties": "never" }],
     "eqeqeq": "error",
-    "no-var": "error",
-    "prefer-const": "error",
     "semi": "error",
     "no-unreachable-loop": "error",
     "no-use-before-define": ["error", { "functions": false, "classes": false }],
@@ -52,6 +50,8 @@
     "array-callback-return": ["error", { "checkForEach": true }],
 
     // Post-ES6
+    "no-var": "error",
+    "prefer-const": "error",
     "strict": ["error", "safe"],
     "prefer-exponentiation-operator": "error",
     "prefer-arrow-callback": "error",

package/badScripts/global/sys_script/initToUndefined.js

@@ -1,2 +1,4 @@
+(function() {
 var unusedVar = undefined;
 if (!unusedVar) gs.log("notset", "2nd");
+})(previous, current);

package/badScripts/global/sys_script/noIifeParams.js

@@ -0,0 +1,3 @@
+(function() {
+    console.log("This will fail", "blaine");
+}();  // Invocation params here is what is constrained

package/badScripts/global/sys_script/noiife.js

@@ -0,0 +1 @@
+console.log("here without IIFE", "blaine");

package/badScripts/global/sys_script/patternId.js

@@ -0,0 +1 @@
+gs.log(patternId, "2nd");

package/badScripts/global/sys_script/request.js

@@ -0,0 +1 @@
+gs.log(request.queryParams, "2nd");

package/badScripts/global/sys_script/unusedVar.js

@@ -1 +1,3 @@
+(function() {
 var unusedVar = 3;
+})(previous, current);

package/badScripts/global/sys_script/wrongIifeParams.js

@@ -0,0 +1,3 @@
+(function() {
+    console.log("This will fail", "blaine");
+}(alpha, beta);  // Invocation params here is what is constrained

package/badScripts/global/sysauto_script/badIife.js

@@ -0,0 +1,2 @@
+function fn() { gs.log("I do nothing", "src"); }
+fn();

package/badScripts/global/sysauto_script/grNoValidate.js

@@ -0,0 +1,4 @@
+const gr = new GlideRecord("sys_script_fix");
+gr.setLimit(1);
+gr.next();
+gs.log("Got sys_script_fix " + gr.sys_id, "src");

package/badScripts/global/sysauto_script/traditionalFor.js

@@ -0,0 +1,3 @@
+const ar = ["alpha", "beta", "gamma"];
+var i = 0;
+for (i = 0; i < ar.length; i++) gs.log("#" + (i+1) + " = " + ar[i], "src");

package/badScripts/scoped/sys_script/let.js

@@ -1,2 +1,4 @@
+(function() {
 let x = 3;
 gs.log(3, 'src');
+})(previous, current);

package/functions.bash

@@ -1,7 +1,7 @@
 # Useful shell functions
 
 function rchead() {
-    local TARGET_FILE=eslintrc.json
+    local TARGET_FILE=sneslintrc.json
     local SYNTAX_MSG='SYNTAX: rchead n   # where n is a positive integer'
     [ -f "$TARGET_FILE" ] || {
         echo "rchead file '$TARGET_FILE' not present or not a file" 1>&2

package/goodScripts/ecc_agent_script/good.js

@@ -1,4 +1,4 @@
-var TstCls = Class.create();
+const TstCls = Class.create();
 TstCls.prototype.initialize = function(o) {
     this.o = o;
     this.p = String(Packages.java.lang.System.getProperty(o));

package/goodScripts/global/sys_script/good.js

@@ -1,7 +1,7 @@
+(function() {
 // Test availability of global vars from the different component lists:
 gs.log("a message", "a source");  // coreServerObjects.txt
 gs.log(SNC.CMDBUtil.getTables0("sys_db_object"), "src");  // directly in exports.js
-// eslint-disable-next-line camelcase
 gs.log(Object.keys(new sn_codesearch.CodeSearch()).length, "src");  // SIScopes
 
 var varsAreAllowed = "a val";
@@ -10,3 +10,4 @@ gs.log(varsAreAllowed, "2nd");
 const con = "a val";
 con += "addition";  // Can't test for const changes
 gs.log(con, "2nd");
+})(previous, current);

package/goodScripts/global/sys_script_include/createOtherClass.js

@@ -1,7 +1,7 @@
 // This passes test because we assign to the new class.
 // This is how SI classes are generally instantiated on SN, because this
 // is how the auto-generated code templates do it.
-var OtherAjaxProcessor = Class.create();
+const OtherAjaxProcessor = Class.create();
  
 OtherAjaxProcessor.prototype = Object.extendsObject(AbstractAjaxProcessor, {
     type: "OtherAjaxProcessor",

package/goodScripts/scoped/sa_pattern_prepost_script/good.js

@@ -0,0 +1 @@
+gs.info(patternId, "2nd");

package/goodScripts/scoped/sys_script/good.js

@@ -1,6 +1,6 @@
+(function() {
 // Test availability of scoped vars from the different component lists:
-gs.info("a message");  // coreServerObjects.txt
-// eslint-disable-next-line camelcase
+gs.info(new sn_ws_err.NotAcceptableError("fake err"));  // coreServerObjects.txt
 gs.info(Object.keys(new sn_codesearch.CodeSearch()).length);  // SIScopes
 
 var varsAreAllowed = "a val";
@@ -9,3 +9,4 @@ gs.info(varsAreAllowed);
 const con = "a val";
 con += "addition";  // Can't test for const changes
 gs.info(con);
+})(previous, current);

package/goodScripts/scoped/sys_ws_operation/good.js

@@ -0,0 +1,2 @@
+gs.info(request.http.inputParam);
+response.setStatus(200);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@admc.com/eslintplugin-sn-test",
-  "version": "1.0.0",
+  "version": "1.0.3",
   "description": "External tests for ESLint plugin @admc.com/eslint-plugin-sn",
   "scripts": {
     "test": "mocha --recursive",
@@ -25,7 +25,9 @@
   },
   "homepage": "https://github.com/unsaved/eslint-plugin-sn#readme",
   "dependencies": {
-    "@admc.com/eslint-plugin-sn": "^1.0.1",
     "mocha": "^10.0.0"
+  },
+  "peerDependencies": {
+    "@admc.com/eslint-plugin-sn": "^1.0.6"
   }
 }

package/{eslintrc.json → sneslintrc.json}

@@ -17,14 +17,20 @@
     "no-array-constructor": "error",
     "max-depth": "error",
     "dot-notation": "error",
-    "camelcase": "error",
+    "camelcase": ["error", { "properties": "never" }],
     "no-template-curly-in-string": "error",
     "eqeqeq": "error",
     "semi": "error",
-    "no-extra-parens": "error"
+    "no-extra-parens": "error",
+    "@admc.com/sn/prefer-array-iterator": "error"
   },
   "overrides": [
     {
+      "files": ["**/@(sa_pattern_prepost_script|sys_script_fix|sys_script|sys_script_include|sys_auto_script|sys_ws_operation|sys_web_service)/@(global|scoped)/*.js"],
+      "rules": {
+        "camelcase": ["error", { "properties": "never", "ignoreGlobals": true }]
+      }
+    },{ // ES6 overrides
       "files": ["**/@(sys|catalog|expert)_script_client/@(noniso|iso)/*.js"],
       "rules": {
         "strict": ["error", "safe"],