@adland/embed 0.4.0 → 0.5.0

package/CHANGELOG.md

@@ -1,5 +1,137 @@
 # @adland/embed
 
+## 0.5.0
+
+### Minor Changes
+
+- 6bf8334: The card draws the right picture, and stops naming the ad's type.
+
+  ## The wrong picture in the square well
+
+  `cardMarkup` asked `@adland/react` for `getAdImage`, which prefers an ad's Open
+  Graph cover. But the card it renders is a compact row whose media box is square
+  by construction — `--adland-media-size` sets its width and its height alike.
+
+  So a link ad for splits.org put the middle of an 840×560 banner in a 44px box
+  where their logo belonged. It reads as a bad picture rather than the wrong
+  field, which is why it survived: nothing about it looks like a bug.
+
+  `getAdIcon` prefers the square mark and falls back to the cover, so an ad
+  carrying only one still renders. The two getters exist for exactly this — which
+  is right depends on the shape of the space, not on the ad.
+
+  Unchanged for anyone composing their own card with `@adland/react`: `<AdImage>`
+  in a wide box was always correct and still is.
+
+  ## The type badge is gone
+
+  The card rendered the ad's type beside it — "Link", "Token". It told a reader
+  nothing they wanted: they can see it is a link by looking at it, and the word
+  took a chunk of a row that is already a title and a description.
+
+  Removed with it, since a styling hook for an element that never renders is worse
+  than no hook:
+
+  - the `badge` name from `AD_PARTS`
+  - `--adland-badge-radius`, `--adland-badge-border`, `--adland-badge-size`,
+    `--adland-badge-weight`, `--adland-badge-padding`
+  - `--adland-accent-bg` and `--adland-accent-fg`, which existed only to colour it
+
+  The theme surface is 24 properties. `--adland-label` and `--adland-label-size`
+  stay: "Ad" is a disclosure, not a description, and it is not going anywhere.
+
+  Card padding is unchanged at 12px — `--adland-padding` was always there for a
+  theme that wants it tighter.
+
+- f2441cc: Two ways to style a card that were not previously possible.
+
+  ## `render-mode="light"`
+
+  The two existing modes both isolate, and both isolate from the publisher as
+  much as from the advertiser. `isolated` (the default) seals the card in an
+  iframe, where the only way in is the `--adland-*` custom properties the element
+  copies across the document boundary. `inline` uses a shadow root, which those
+  properties inherit through and `::part()` can reach — better, and still not a
+  stylesheet, because Tailwind emits classes and a class in the page cannot cross
+  a shadow boundary. A publisher wanting `rounded-2xl` on the card had no way to
+  say it.
+
+  In `light` the markup is ordinary children of `<adland-slot>`, so every hook —
+  `.adland-card`, `.adland-media`, `.adland-title`, `.adland-description`,
+  `.adland-label`, `.adland-badge` — is a normal element in the page:
+
+      <adland-slot
+        slot-key="adland-1"
+        render-mode="light"
+        class="[&_.adland-card]:flex [&_.adland-card]:gap-3
+               [&_.adland-card]:rounded-xl [&_.adland-media]:size-12"
+      ></adland-slot>
+
+  Isolation runs both ways, so the trade is real: in this mode your CSS can break
+  the ad, and `BASE_STYLES` is deliberately not injected — in the light DOM those
+  rules would leak to the whole page. An unstyled card is what arrives, and
+  styling it becomes your job rather than your option. That is why it is opt-in
+  and why the default has not changed.
+
+  ## Nine more theme properties
+
+  The theme surface was 21 properties and could not express a card that is raised
+  at rest, presses when you hover it, or has a border on anything but the card
+  itself. Every gap below was found trying to build one neo-brutalist card and
+  discovering the style was unreachable:
+
+  | property                   | default          | why                                                                                           |
+  | -------------------------- | ---------------- | --------------------------------------------------------------------------------------------- |
+  | `--adland-shadow`          | `none`           | There was a hover shadow and none at rest, which ruled out every raised style.                |
+  | `--adland-transform-hover` | `none`           | Shrinking the shadow alone reads as a wobble; the card has to move into the space it vacates. |
+  | `--adland-transition`      | the existing one | So a style can snap rather than ease.                                                         |
+  | `--adland-media-border`    | `none`           | Hardcoded to borderless.                                                                      |
+  | `--adland-badge-border`    | `none`           | Same.                                                                                         |
+  | `--adland-badge-size`      | `10px`           | Was fixed.                                                                                    |
+  | `--adland-badge-weight`    | `600`            | Was fixed.                                                                                    |
+  | `--adland-badge-padding`   | `2px 6px`        | Was fixed.                                                                                    |
+  | `--adland-label-size`      | `9px`            | Was fixed.                                                                                    |
+
+  Every one defaults to what was previously hardcoded, so nothing moves for anyone
+  not setting them.
+
+      <adland-slot
+        slot-key="adland-1"
+        style="--adland-bg: #fff; --adland-fg: #000;
+               --adland-border: #000; --adland-border-width: 2px;
+               --adland-radius: 0; --adland-shadow: 4px 4px 0 #000;
+               --adland-accent-bg: #FFE500"
+      ></adland-slot>
+
+### Patch Changes
+
+- aaf1443: Fix: clicking a token, cast, tweet or profile ad did nothing.
+
+  Two bugs, and they hid each other.
+
+  `render.ts` carried its own `adWebUrl`, which resolved `link` and `miniapp` and
+  returned null for the other four types. `@adland/react`'s `WebActionAdapter` has
+  always used `adDestination` from `@adland/data`, which resolves all six — so
+  this was a second, shorter implementation of a function that already existed.
+  It now delegates to the shared one.
+
+  With no destination there was no `<a>` wrapper, and the iframe's click handler
+  told `handleClick` the URL had `alreadyOpened` — unconditionally, on the
+  assumption an anchor was always there. So the click was tracked and then
+  dropped, with no fallback to the adapter. The element now records whether an
+  anchor was actually rendered and passes that instead.
+
+  Only the default `isolated` mode was affected. `inline` and `light` route
+  through the adapter and were always correct, which is why the same ad worked in
+  one mode and not another.
+
+  A test asserted the old behaviour — "returns null for ad types with no web URL"
+  — so this shipped looking deliberate. Replaced with a table covering all six.
+
+- Updated dependencies [c826a3c]
+- Updated dependencies [2dc1cd3]
+  - @adland/react@0.25.0
+
 ## 0.4.0
 
 ### Minor Changes