@adityaaria/spark 6.0.19 → 6.0.21

package/bin/spark-install.sh

@@ -70,6 +70,7 @@ SCOPE="project"
 FORCE=false
 HELP=false
 DRY_RUN=false
+UNINSTALL=false
 
 parse_args() {
   while [ $# -gt 0 ]; do
@@ -77,6 +78,7 @@ parse_args() {
       -g|--global)  SCOPE="global" ;;
       --force)      FORCE=true ;;
       --dry-run)    DRY_RUN=true ;;
+      -u|--uninstall) UNINSTALL=true ;;
       -h|--help)    HELP=true ;;
       *)
         error "Unknown argument: $1"
@@ -97,10 +99,11 @@ print_help() {
     bash bin/spark-install.sh [options]
 
   Options:
-    -g, --global    Install to global agent config (~/.agent/skills/)
-                    Default: project scope (./.agent/skills/)
+    -g, --global    Install to global agent config (~/.agents/skills/)
+                    Default: project scope (./.agents/skills/)
     --force         Re-install even if already installed
     --dry-run       Show what would be done without making changes
+    -u, --uninstall Safely remove SPARK from agent configs
     -h, --help      Show this help message
 
   Examples:
@@ -750,6 +753,85 @@ check_existing_install() {
   fi
 }
 
+# =============================================================================
+# Uninstall
+# =============================================================================
+
+uninstall_for_agent() {
+  local agent_id="$1"
+  local target_dir
+  target_dir="$(get_target_dir "$agent_id")"
+
+  if [ ! -d "$target_dir" ]; then
+    return 0
+  fi
+
+  info "Removing SPARK from $agent_id at $target_dir"
+
+  # 1. Remove skills symlink/directory
+  if [ -e "$target_dir/skills" ]; then
+    rm -rf "$target_dir/skills"
+  fi
+
+  # 2. Remove hooks
+  local hook_files
+  hook_files="$(get_agent_hook_files "$agent_id")"
+  if [ -n "$hook_files" ]; then
+    while IFS= read -r hook_file; do
+      [ -z "$hook_file" ] && continue
+      rm -f "$target_dir/$hook_file"
+    done <<< "$hook_files"
+    # Try to remove hooks dir if empty
+    rmdir "$target_dir/hooks" 2>/dev/null || true
+  fi
+
+  # 3. Remove plugin manifests
+  local manifest_files
+  manifest_files="$(get_agent_manifest_files "$agent_id")"
+  if [ -n "$manifest_files" ]; then
+    while IFS= read -r manifest_file; do
+      [ -z "$manifest_file" ] && continue
+      rm -f "$target_dir/$manifest_file"
+      local manifest_dir
+      manifest_dir="$(dirname "$target_dir/$manifest_file")"
+      rmdir "$manifest_dir" 2>/dev/null || true
+    done <<< "$manifest_files"
+  fi
+
+  # 4. Remove agent dir if totally empty
+  rmdir "$target_dir" 2>/dev/null || true
+}
+
+perform_uninstall() {
+  header "SPARK Uninstaller"
+
+  local lock_dir
+  if [ "$SCOPE" = "global" ]; then
+    lock_dir="${HOME:-$(eval echo ~)}"
+  else
+    lock_dir="$(pwd)"
+  fi
+  local lock_path="$lock_dir/$LOCK_FILE_NAME"
+
+  # Detect agents
+  info "Detecting installed agents to clean up..."
+  detect_agents || true
+  build_selected_agents
+
+  for agent_id in "${SELECTED_AGENTS[@]}"; do
+    uninstall_for_agent "$agent_id"
+  done
+
+  if [ -f "$lock_path" ]; then
+    rm -f "$lock_path"
+    info "Removed lock file: $lock_path"
+  fi
+
+  echo ""
+  success "SPARK has been safely uninstalled."
+  exit $EXIT_SUCCESS
+}
+
 # =============================================================================
 # Summary
 # =============================================================================
@@ -800,6 +882,10 @@ main() {
     exit $EXIT_SUCCESS
   fi
 
+  if $UNINSTALL; then
+    perform_uninstall
+  fi
+
   header "SPARK Native Installer"
 
   # Step 1: Resolve repo

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adityaaria/spark",
-  "version": "6.0.19",
+  "version": "6.0.21",
   "description": "SPARK skills and runtime bootstrap for coding agents",
   "type": "module",
   "publishConfig": {

package/skills/project-scanner/SKILL.md

@@ -11,7 +11,7 @@ Use this skill to scan and document a codebase's architecture, operational rules
 
 **Announce at start:** "spark detection 💥 Using project-scanner to analyze repository DNA"
 
-**Save findings to:** The `.docs/` directory. Create it if it does not exist. For large projects, break down the documentation logically (e.g., `.docs/PROJECT_SCAN.md`, `.docs/API_CONTRACT.md`, `.docs/DOMAINS/`) instead of creating one massive monolithic file.
+**Save findings to:** The `.docs/` directory. **You must physically create this directory and save the files to disk using your tools. Do NOT just print the output to the user.** For large projects, break down the documentation logically (e.g., `.docs/PROJECT_SCAN.md`, `.docs/API_CONTRACT.md`, `.docs/DOMAINS/`) instead of creating one massive monolithic file.
 
 ## Handling Massive Codebases (Subagent Delegation)
 If the repository is extremely large and analyzing all four pillars sequentially risks exceeding context limits or taking too long:
@@ -56,4 +56,4 @@ Identify conventions, rules, and technical debt enforced or found in the codebas
 - `[ ]` **Step 2:** Scan root configuration files and prioritize searching for Swagger/OpenAPI specifications.
 - `[ ]` **Step 3:** Scan source directory structures to infer the language, framework, and architectural patterns.
 - `[ ]` **Step 4:** Analyze testing frameworks, CI/CD workflows, and actively hunt for anti-patterns and legacy traps.
-- `[ ]` **Step 5:** Write the comprehensive report(s) into the `.docs/` directory.
+- `[ ]` **Step 5 (CRITICAL):** You MUST use your file-writing tools to physically create the `.docs/` directory and save the markdown files (e.g. `PROJECT_SCAN.md`, `API_CONTRACT.md`) into it. DO NOT just print the summary into the chat! You must physically write the files to disk.

package/skills/using-spark/SKILL.md

@@ -10,7 +10,12 @@ If you were dispatched as a subagent to execute a specific task, skip this skill
 <EXTREMELY-IMPORTANT>
 If you think there is even a 1% chance a skill might apply to what you are doing, you ABSOLUTELY MUST invoke the skill.
 
-IF A SKILL APPLIES TO YOUR TASK, YOU DO NOT HAVE A CHOICE. YOU MUST USE IT.
+IF A SKILL APPLIES TO YOUR TASK, OR IF THE USER EXPLICITLY REQUESTS A SKILL, YOU DO NOT HAVE A CHOICE. YOU MUST USE IT IMMEDIATELY.
+
+**Do NOT ask clarifying questions first.**
+**Do NOT start a conversation.**
+**Do NOT explain what you are going to do.**
+**JUST EXECUTE THE SKILL DIRECTLY AS YOUR FIRST TOOL CALL.**
 
 This is not negotiable. This is not optional. You cannot rationalize your way out of this.
 </EXTREMELY-IMPORTANT>
@@ -49,6 +54,8 @@ Skills speak in actions ("dispatch a subagent", "create a todo", "read a file")
 
 **Invoke relevant or requested skills BEFORE any response or action.** Even a 1% chance a skill might apply means that you should invoke the skill to check. If an invoked skill turns out to be wrong for the situation, you don't need to use it.
 
+**CRITICAL:** If the user mentions a specific skill by name (e.g., "scan project", "project-scanner", "run deployment"), you MUST invoke that skill IMMEDIATELY as your very first tool call. Do not answer conversationally. Do not ask for confirmation. Execute the skill first.
+
 ## Announcement Format
 When you invoke a skill, you MUST announce it to the developer using exactly this format as the very first thing you say:
 `spark detection 💥 Using [skill] to [purpose]`

package/src/cli/index.js

@@ -14,6 +14,12 @@ export async function run(argv = [], env = process.env) {
     return;
   }
 
+  if (command === 'uninstall') {
+    // Forward the args and append --uninstall
+    await runInstall([...args, '--uninstall'], env);
+    return;
+  }
+
   if (command === 'dashboard' || command === 'ui') {
     const { startDashboard } = await import('../dashboard/server.js');
     startDashboard();

package/src/cli/output.js

@@ -24,7 +24,7 @@ export function printHelp() {
   printLine('');
   printMuted('Wraps the native SPARK installer (bin/spark-install.sh).');
   printLine('');
-  printLine(labelValue('Options', '-g, --global    Install to global agent config (~/.agent/skills/)'));
+  printLine(labelValue('Options', '-g, --global    Install to global agent config (~/.agents/skills/)'));
   printLine(labelValue('       ', '--force         Re-install even if already installed'));
   printLine(labelValue('       ', '--dry-run       Show what would be done without making changes'));
   printLine(labelValue('       ', '-h, --help      Show this help message'));