@adia-ai/gen-ui 0.8.39 → 0.8.41

package/retrieval/catalog.js

@@ -22,22 +22,36 @@ async function loadSchemas() {
 
   if (typeof process !== 'undefined' && process.versions?.node) {
     try {
-      const { readdir, readFile, stat } = await import(/* @vite-ignore */ 'node:fs/promises');
+      const { readdir, readFile } = await import(/* @vite-ignore */ 'node:fs/promises');
       const { fileURLToPath } = await import(/* @vite-ignore */ 'node:url');
       const { dirname, join } = await import(/* @vite-ignore */ 'node:path');
-      const compsDir = join(dirname(fileURLToPath(import.meta.url)), '../../../web-components/components');
-      const entries = await readdir(compsDir, { withFileTypes: true });
-      for (const e of entries) {
-        if (!e.isDirectory()) continue;
-        const path = join(compsDir, e.name, `${e.name}.a2ui.json`);
+      const engineDir = dirname(fileURLToPath(import.meta.url));
+      // gh#1380/ADR-0065: scan RECURSIVELY, not just <dir>/<dir-name>.a2ui.json —
+      // a directory holding a family (e.g. components/feed/feed-item.a2ui.json,
+      // components/tabs/tab.a2ui.json) carries sidecars whose filename doesn't
+      // match the directory's own name, and web-modules composites live in a
+      // sibling tree entirely. Missing either silently defaulted every such
+      // component's category to 'other' (exactly the bug this fix closes).
+      const roots = [
+        join(engineDir, '../../../web-components/components'),
+        join(engineDir, '../../../web-modules'),
+      ];
+      for (const root of roots) {
         try {
-          const raw = await readFile(path, 'utf8');
-          const schema = JSON.parse(raw);
-          const tag = tagFromSchema(schema);
-          if (tag) schemaByTag.set(tag, schema);
-        } catch { /* skip missing / malformed */ }
+          const entries = await readdir(root, { withFileTypes: true, recursive: true });
+          for (const e of entries) {
+            if (!e.isFile() || !e.name.endsWith('.a2ui.json')) continue;
+            const path = join(e.parentPath ?? e.path, e.name);
+            try {
+              const raw = await readFile(path, 'utf8');
+              const schema = JSON.parse(raw);
+              const tag = tagFromSchema(schema);
+              if (tag) schemaByTag.set(tag, schema);
+            } catch { /* skip malformed */ }
+          }
+        } catch { /* root missing */ }
       }
-    } catch { /* components dir missing */ }
+    } catch { /* fs/path modules unavailable */ }
   } else {
     // Browser. Vite rewrites the glob CALL at transform time; on the static
     // deploy that call throws (no Vite — `import.meta.glob` is a compile-time
@@ -47,7 +61,13 @@ async function loadSchemas() {
     // produced loaders. See composition-library.js for the full rationale.
     let modules = null;
     try {
-      modules = import.meta.glob('../../../web-components/components/*/*.a2ui.json', { query: '?raw', import: 'default' });
+      // gh#1380/ADR-0065: also glob web-modules — a composite's category
+      // (e.g. admin-sidebar-ui, chat-composer-ui) previously fell through
+      // to 'other' because only the web-components tree was globbed here.
+      modules = {
+        ...import.meta.glob('../../../web-components/components/*/*.a2ui.json', { query: '?raw', import: 'default' }),
+        ...import.meta.glob('../../../web-modules/**/*.a2ui.json', { query: '?raw', import: 'default' }),
+      };
     } catch { /* no Vite transform — static deploy */ }
 
     if (modules && Object.keys(modules).length > 0) {
@@ -94,32 +114,37 @@ export function registerSchema(tag, schema) {
 }
 
 // ── Category classification ──
-const categoryMap = {
-  'row-ui': 'layout', 'col-ui': 'layout', 'list-ui': 'layout', 'grid-ui': 'layout',
-  'stack-ui': 'layout', 'block-ui': 'layout', 'toolbar-ui': 'layout',
-  'text-ui': 'display', 'image-ui': 'display', 'icon-ui': 'display',
-  'divider-ui': 'display', 'badge-ui': 'display', 'avatar-ui': 'display',
-  'avatar-group-ui': 'display', 'progress-ui': 'display', 'skeleton-ui': 'display',
-  'code-ui': 'display', 'kbd-ui': 'display', 'tag-ui': 'display',
-  'stat-ui': 'display', 'empty-state-ui': 'display',
-  'input-ui': 'input', 'check-ui': 'input', 'switch-ui': 'input',
-  'slider-ui': 'input', 'select-ui': 'input', 'search-ui': 'input',
-  'upload-ui': 'input', 'textarea-ui': 'input', 'radio-ui': 'input',
-  'otp-input-ui': 'input', 'calendar-picker-ui': 'input', 'color-picker-ui': 'input',
-  'range-ui': 'input',
-  'button-ui': 'action',
-  'card-ui': 'container', 'tabs-ui': 'container', 'tab-ui': 'container',
-  'pane-ui': 'container', 'modal-ui': 'container', 'drawer-ui': 'container',
-  'toast-ui': 'container', 'popover-ui': 'container', 'accordion-ui': 'container',
-  'alert-ui': 'container', 'tooltip-ui': 'container', 'menu-ui': 'container',
-  'command-ui': 'container',
-  'section': 'card-child', 'header': 'card-child', 'footer': 'card-child',
-  'stream-ui': 'agent', 'table-ui': 'agent', 'chart-ui': 'agent',
-  'embed-ui': 'agent', 'noodles-ui': 'agent',
-  'breadcrumb-ui': 'navigation', 'nav-ui': 'navigation', 'pagination-ui': 'navigation',
-  'segmented-ui': 'navigation', 'segment-ui': 'navigation', 'router-ui': 'navigation',
-  'toggle-group-ui': 'navigation', 'toggle-option-ui': 'navigation',
-};
+//
+// Ratified by ADR-0065 (docs/ops/adr/adr-0065-category-vocabulary.md): `category`
+// is DERIVED from each component's own yaml SoT (forwarded verbatim onto its
+// sidecar's `x-adiaui.category` by scripts/build/components.mjs), never
+// hand-maintained here for anything that HAS a yaml SoT. The prior hand-typed
+// `categoryMap` (~60 tags) covered under a third of the catalog and silently
+// defaulted every unlisted tag — the whole picker family, `stepper-ui`,
+// `list-window-ui`, every primitive shipped after the map was last touched —
+// to `'other'`; it also disagreed with yaml where it did overlap (e.g.
+// `tab-ui`: map said `container`, yaml says `navigation`). Reading the
+// sidecar's own field instead means every YAML-backed component gets its
+// yaml-ratified category, and `scripts/build/components.mjs`'s
+// `CATEGORY_VALUES` gate (mirroring ADR-0057's `status` check) guarantees
+// that value is always one of the twelve ratified ones before it ever
+// reaches this file.
+//
+// A handful of `registry` (@adia-ai/a2ui) entries are schema-LESS v0.9
+// composition pseudo-types with no yaml, no sidecar, and therefore nothing
+// to derive from: `Section`/`Header`/`Footer` (registry.js tags them
+// `section`/`header`/`footer` — no `-ui` suffix, deliberately distinct from
+// the real `section-ui`/`header-ui`/`footer-ui` primitives, which DO have
+// yaml and now correctly resolve via the sidecar) represent a card's
+// structural child slots, not standalone components. This is the one place
+// still hand-maintained, and deliberately small — everything with a yaml
+// SoT is excluded from it by construction.
+const PSEUDO_TYPE_CATEGORY = { section: 'card-child', header: 'card-child', footer: 'card-child' };
+
+function categoryFor(tag, schema) {
+  if (schema?.['x-adiaui']?.category) return schema['x-adiaui'].category;
+  return PSEUDO_TYPE_CATEGORY[tag] || 'other';
+}
 
 // ── Trait registry ──
 //
@@ -145,6 +170,7 @@ async function loadTraitRegistry() {
         attributes: [...t.attributes],
         events: [...t.events],
         config: [...t.config],
+        prefixes: [...(t.prefixes || [])],
       }));
     } catch (err) {
       console.warn('[a2ui-corpus] could not load trait catalog:', err.message);
@@ -167,6 +193,7 @@ async function loadTraitRegistry() {
         attributes: [...t.attributes],
         events: [...t.events],
         config: [...t.config],
+        prefixes: [...(t.prefixes || [])],
       }));
     } catch { /* trait catalog not present in this build context */ }
   }
@@ -195,7 +222,7 @@ async function buildCatalog() {
     if (type.includes('-')) continue;
 
     const schema = schemaByTag.get(tag) || null;
-    const category = categoryMap[tag] || 'other';
+    const category = categoryFor(tag, schema);
 
     entries.set(type, {
       type,