@adia-ai/a2ui-retrieval 0.7.27 → 0.7.28

package/CHANGELOG.md

@@ -1,4 +1,22 @@
 # Changelog — @adia-ai/a2ui-retrieval
+## [0.7.28] — 2026-07-14
+
+### Fixed
+
+- **`anti-patterns.js`'s `noInventedComponents` derives its allowlist
+  live, not from a hand-frozen list.** The ~140-tag `Set` was a manual
+  snapshot ("regenerated 2026-06-10") with a documented prior staleness
+  incident (missing `field-ui`, a core primitive) — independent of the
+  live `registry` Map `validator.js` already imports for the same class
+  of check. Now built once at module load from `registry`
+  (`@adia-ai/a2ui-runtime`) + `component-catalog.js`'s per-component
+  sidecars, plus one named exception (`router-ui`, core-defined, no yaml
+  sidecar). Diffing the old list against the live union incidentally
+  surfaced a second staleness bug (the registry was itself missing
+  several shell-family tags the old list never had either) and dropped
+  6 confirmed-stale entries. New regression suite,
+  `anti-patterns.test.js` (6 cases).
+
 ## [0.7.27] — 2026-07-12
 
 ### Lockstep

package/anti-patterns.js

@@ -8,6 +8,38 @@
  *   - fix: guidance on how to correct it
  */
 
+import { registry } from '../runtime/registry.js';
+import { getAllComponentData } from './component-catalog.js';
+
+// `noInventedComponents`'s allowlist, below, used to be a hand-frozen Set —
+// it drifted stale at least once in production (missing field-ui, a core
+// primitive) before being "regenerated" as a one-time manual snapshot on
+// 2026-06-10, which is itself already stale again. Built live instead, from
+// the two sources every registered tag actually comes from:
+//   - `registry` (@adia-ai/a2ui-runtime) — the A2UI-emittable compose types
+//     (validator.js's checkAllTypesRegistered already imports this same Map).
+//   - `component-catalog.js`'s per-component `.a2ui.json` sidecars (the
+//     dual-mode Node/browser/static loader AGENTS.md names as the canonical
+//     pattern for this directory) — covers every component with a yaml SoT,
+//     including ones like agent-artifact-ui/aside-ui/preview-ui that exist
+//     but were never wired into the compose-emission registry.
+// `CORE_INFRA_TAGS` covers the residual few real elements neither source
+// carries: `router-ui` is defined directly in core/provider.js with no
+// yaml/generated sidecar and is never an A2UI-emittable type.
+const CORE_INFRA_TAGS = ['router-ui'];
+
+function buildKnownTags() {
+  const tags = new Set(registry.values());
+  for (const data of Object.values(getAllComponentData())) {
+    const tag = data?.['x-adiaui']?.tag;
+    if (tag) tags.add(tag);
+  }
+  for (const tag of CORE_INFRA_TAGS) tags.add(tag);
+  return tags;
+}
+
+const KNOWN_TAGS = buildKnownTags();
+
 const antiPatterns = [
   {
     name: 'noBareDivs',
@@ -66,41 +98,9 @@ const antiPatterns = [
     description: 'Only use components from the AdiaUI registry. Do not invent custom component tags.',
     check: (html) => {
       const tags = html.match(/<([a-z]+-(?:n|ui))\b/gi) || [];
-      const known = new Set([
-        // Regenerated 2026-06-10 from the per-component yaml `tag:` SoT
-        // (node: scan packages/web-components/components/*/*.yaml) + the
-        // runtime/infra extras below. The previous hand-rolled list was
-        // stale — it was MISSING field-ui (a core primitive), so every
-        // canonical labeled form flagged noInventedComponents.
-        'accordion-item-ui', 'accordion-ui', 'action-item-ui', 'action-list-ui', 'adia-root', 'agent-artifact-ui',
-        'agent-feedback-bar-ui', 'agent-questions-ui', 'agent-reasoning-ui', 'agent-suggestions-ui', 'agent-trace-ui', 'alert-ui',
-        'aside-ui', 'avatar-group-ui', 'avatar-ui', 'badge-ui', 'block-ui', 'blockquote-ui',
-        'breadcrumb-ui', 'button-ui', 'calendar-grid-ui', 'calendar-picker-ui', 'canvas-ui', 'card-ui',
-        'chart-legend-ui', 'chart-ui', 'chat-input-ui', 'chat-thread-ui', 'check-ui', 'code-ui',
-        'col-ui', 'color-input-ui', 'color-picker-ui', 'combobox-ui', 'command-ui', 'context-menu-ui',
-        'date-range-picker-ui', 'datetime-picker-ui', 'datetime-ui', 'demo-toggle-ui', 'description-list-ui', 'divider-ui',
-        'drawer-ui', 'embed-ui', 'empty-state-ui', 'feed-item-ui', 'feed-ui', 'field-ui',
-        'fields-ui', 'footer-ui', 'form-container-ui', 'frame-ui', 'grid-ui', 'header-ui',
-        'heatmap-ui', 'icon-provider', 'icon-ui', 'image-ui', 'inline-edit-ui', 'inline-message-ui',
-        'input-ui', 'inspector-ui', 'integration-card-ui', 'kbd-ui', 'link-ui', 'list-item-ui',
-        'list-ui', 'list-window-ui', 'listbox-ui', 'loading-overlay-ui', 'mark-ui', 'menu-divider-ui',
-        'menu-item-ui', 'menu-label-ui', 'menu-ui', 'modal-ui', 'nav-group-ui', 'nav-item-ui',
-        'nav-ui', 'noodles-ui', 'number-format-ui', 'option-card-ui', 'otp-input-ui', 'page-ui',
-        'pagination-ui', 'pane-ui', 'password-strength-ui', 'pipeline-status-ui', 'popover-ui', 'preview-ui',
-        'progress-row-ui', 'progress-ui', 'qr-code-ui', 'radio-ui', 'range-ui', 'rating-ui',
-        'relative-time-ui', 'richtext-ui', 'router-ui', 'row-ui', 'search-ui', 'section-ui',
-        'segment-ui', 'segmented-ui', 'select-ui', 'skeleton-ui', 'skip-nav-ui', 'slider-ui',
-        'spinner-ui', 'stack-ui', 'stat-ui', 'step-progress-ui', 'stepper-item-ui', 'stepper-ui',
-        'stream-ui', 'swatch-ui', 'swiper-ui', 'switch-ui', 'tab-ui', 'table-toolbar-ui',
-        'table-ui', 'tabs-ui', 'tag-ui', 'tags-input-ui', 'text-ui', 'textarea-ui',
-        'theme-provider', 'theme-ui', 'time-picker-ui', 'timeline-item-ui', 'timeline-ui', 'toast-ui',
-        'toc-ui', 'toggle-group-ui', 'toggle-option-ui', 'toggle-scheme-ui', 'toolbar-group-ui', 'toolbar-ui',
-        'tooltip-ui', 'tour-step-ui', 'tour-ui', 'tree-item-ui', 'tree-ui', 'upload-ui',
-        'visually-hidden-ui',
-      ]);
       for (const match of tags) {
         const tag = match.slice(1).toLowerCase();
-        if (!known.has(tag)) return true;
+        if (!KNOWN_TAGS.has(tag)) return true;
       }
       return false;
     },

package/anti-patterns.test.js

@@ -0,0 +1,59 @@
+/**
+ * anti-patterns.js — regression coverage for the noInventedComponents
+ * catalog-fragmentation fix.
+ *
+ * Prior bug: `known` was a hand-frozen Set (~140 tags, "regenerated"
+ * 2026-06-10) independent of the live `registry` Map validator.js already
+ * imports for the same purpose — it drifted stale at least once before
+ * (documented: missing field-ui, a core primitive). Fixed to build the
+ * allowlist live from `registry` + `component-catalog.js`'s per-component
+ * sidecars + a tiny, named core-infra exception list (`router-ui`).
+ */
+import { describe, it, expect } from 'vitest';
+import { checkAntiPattern } from './anti-patterns.js';
+import { registry } from '../runtime/registry.js';
+
+const check = (tag) => checkAntiPattern('noInventedComponents', `<${tag}></${tag}>`).violated;
+
+describe('anti-patterns — noInventedComponents (live catalog derivation)', () => {
+  it('accepts every tag the live registry maps to (validator.js checkAllTypesRegistered\'s own source)', () => {
+    const flagged = [...new Set(registry.values())].filter((tag) => check(tag));
+    expect(flagged).toEqual([]);
+  });
+
+  it('accepts a component that exists but was previously missing from the compose-emission registry (agent-artifact-ui)', () => {
+    expect(check('agent-artifact-ui')).toBe(false);
+  });
+
+  it('accepts router-ui — core infra defined in provider.js, no yaml sidecar, no registry entry', () => {
+    expect(check('router-ui')).toBe(false);
+  });
+
+  it('accepts chat-thread-ui — a real sidecar-carried tag masked in the aggregated catalog by a ChatThread name collision with web-modules/chat/chat-thread (tag "chat-thread")', () => {
+    expect(check('chat-thread-ui')).toBe(false);
+  });
+
+  it('still flags a genuinely invented single-hyphen tag', () => {
+    expect(check('madeup-ui')).toBe(true);
+  });
+
+  it('drops confirmed-stale entries the old hand list carried for tags that no longer exist anywhere in the tree', () => {
+    // datetime-ui / listbox-ui / theme-ui: zero hits for a real component
+    // dir, yaml `tag:`, or customElements.define anywhere in the repo at
+    // the time of the fix — genuinely stale, now correctly flaggable.
+    //
+    // adia-root / icon-provider / form-container-ui were ALSO in the old
+    // hand list but are excluded from this assertion on purpose: the tag-
+    // extraction regex just above (`/<([a-z]+-(?:n|ui))\b/gi`) only
+    // captures single-hyphen tags ending in "-n" or "-ui" — it never
+    // extracted "adia-root"/"icon-provider" (wrong suffix) or
+    // "form-container-ui" (two hyphens) in the first place, under the old
+    // list OR this one. Their allowlist membership was always inert; a
+    // pre-existing, separate regex-coverage gap, not something this fix
+    // changes either way (see the "genuinely invented single-hyphen tag"
+    // case above for what the regex CAN catch).
+    for (const stale of ['datetime-ui', 'listbox-ui', 'theme-ui']) {
+      expect(check(stale)).toBe(true);
+    }
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adia-ai/a2ui-retrieval",
-  "version": "0.7.27",
+  "version": "0.7.28",
   "description": "AdiaUI A2UI retrieval layer \u2014 catalog lookup, intent classification, domain routing, pattern + anti-pattern matching, clarity + context assembly. Consumed by the compose engine and any A2UI-protocol tooling that needs to reason about user intent against the catalog.",
   "type": "module",
   "main": "./index.js",