@adhdev/session-host-core 1.0.58-rc.9 → 1.0.58-rc.90

package/dist/index.d.mts

@@ -533,7 +533,27 @@ interface SessionHostEndpointOptions {
     platform?: NodeJS.Platform;
 }
 declare function getDefaultSessionHostEndpoint(appName?: string, options?: SessionHostEndpointOptions): SessionHostEndpoint;
-declare function createLineParser(onEnvelope: (envelope: SessionHostWireEnvelope) => void): (chunk: Buffer | string) => void;
+/**
+ * UTF8-CHUNK-BOUNDARY: decode the socket stream, never the individual chunk.
+ *
+ * This used to call `chunk.toString()` on every Buffer independently. A socket
+ * hands us arbitrary byte slices — a multi-byte UTF-8 sequence straddling two
+ * chunks gets decoded as two truncated sequences, and each half becomes U+FFFD.
+ * The damage is silent by construction: the replacement character is valid JSON
+ * string content, so the envelope still parses and only the *value* is wrong.
+ * A pasted 11,994-char Korean prompt lost exactly one character that way — the
+ * `도` beginning at wire offset 8190, split across the 8192-byte chunk boundary,
+ * arrived as `�착`.
+ *
+ * StringDecoder holds an incomplete trailing sequence back until the bytes that
+ * finish it arrive, which is the only correct way to turn a byte stream into
+ * text. String chunks bypass it: they are already decoded, and feeding them
+ * through `Buffer.from` would re-encode text the caller never asked us to touch.
+ */
+declare function createLineParser(onEnvelope: (envelope: SessionHostWireEnvelope) => void): {
+    (chunk: Buffer | string): void;
+    end(): string;
+};
 interface SessionHostClientOptions {
     endpoint?: SessionHostEndpoint;
     appName?: string;
@@ -551,6 +571,16 @@ interface SessionHostDisconnectInfo {
     /** In-flight requests abandoned by this disconnect (they were rejected). */
     pendingRequests: number;
     error?: Error;
+    /**
+     * Bytes discarded from a newline-unterminated frame at EOF (0 when the peer
+     * hung up on a clean frame boundary, which is the normal case).
+     *
+     * Non-zero means the peer was cut off MID-WRITE — diagnostic context that
+     * distinguishes "the host exited" from "the host died with a frame in
+     * flight". Before the parser's `end()` was reachable this was unknowable:
+     * the bytes were dropped with the decoder and no counter existed.
+     */
+    droppedTailBytes: number;
 }
 declare class SessionHostClient {
     readonly endpoint: SessionHostEndpoint;

package/dist/index.d.ts

@@ -533,7 +533,27 @@ interface SessionHostEndpointOptions {
     platform?: NodeJS.Platform;
 }
 declare function getDefaultSessionHostEndpoint(appName?: string, options?: SessionHostEndpointOptions): SessionHostEndpoint;
-declare function createLineParser(onEnvelope: (envelope: SessionHostWireEnvelope) => void): (chunk: Buffer | string) => void;
+/**
+ * UTF8-CHUNK-BOUNDARY: decode the socket stream, never the individual chunk.
+ *
+ * This used to call `chunk.toString()` on every Buffer independently. A socket
+ * hands us arbitrary byte slices — a multi-byte UTF-8 sequence straddling two
+ * chunks gets decoded as two truncated sequences, and each half becomes U+FFFD.
+ * The damage is silent by construction: the replacement character is valid JSON
+ * string content, so the envelope still parses and only the *value* is wrong.
+ * A pasted 11,994-char Korean prompt lost exactly one character that way — the
+ * `도` beginning at wire offset 8190, split across the 8192-byte chunk boundary,
+ * arrived as `�착`.
+ *
+ * StringDecoder holds an incomplete trailing sequence back until the bytes that
+ * finish it arrive, which is the only correct way to turn a byte stream into
+ * text. String chunks bypass it: they are already decoded, and feeding them
+ * through `Buffer.from` would re-encode text the caller never asked us to touch.
+ */
+declare function createLineParser(onEnvelope: (envelope: SessionHostWireEnvelope) => void): {
+    (chunk: Buffer | string): void;
+    end(): string;
+};
 interface SessionHostClientOptions {
     endpoint?: SessionHostEndpoint;
     appName?: string;
@@ -551,6 +571,16 @@ interface SessionHostDisconnectInfo {
     /** In-flight requests abandoned by this disconnect (they were rejected). */
     pendingRequests: number;
     error?: Error;
+    /**
+     * Bytes discarded from a newline-unterminated frame at EOF (0 when the peer
+     * hung up on a clean frame boundary, which is the normal case).
+     *
+     * Non-zero means the peer was cut off MID-WRITE — diagnostic context that
+     * distinguishes "the host exited" from "the host died with a frame in
+     * flight". Before the parser's `end()` was reachable this was unknowable:
+     * the bytes were dropped with the decoder and no counter existed.
+     */
+    droppedTailBytes: number;
 }
 declare class SessionHostClient {
     readonly endpoint: SessionHostEndpoint;

package/dist/index.js

@@ -580,6 +580,7 @@ var SessionHostRegistry = class {
 var os = __toESM(require("os"));
 var path2 = __toESM(require("path"));
 var net = __toESM(require("net"));
+var import_string_decoder = require("string_decoder");
 function generateUUID2() {
   if (typeof crypto !== "undefined" && crypto.randomUUID) {
     return crypto.randomUUID();
@@ -614,8 +615,9 @@ function serializeEnvelope(envelope) {
 }
 function createLineParser(onEnvelope) {
   let buffer = "";
-  return (chunk) => {
-    buffer += chunk.toString();
+  const decoder = new import_string_decoder.StringDecoder("utf8");
+  const parser = (chunk) => {
+    buffer += typeof chunk === "string" ? chunk : decoder.write(chunk);
     let newlineIndex = buffer.indexOf("\n");
     while (newlineIndex >= 0) {
       const rawLine = buffer.slice(0, newlineIndex).trim();
@@ -626,6 +628,12 @@ function createLineParser(onEnvelope) {
       newlineIndex = buffer.indexOf("\n");
     }
   };
+  parser.end = () => {
+    const remainder = buffer + decoder.end();
+    buffer = "";
+    return remainder;
+  };
+  return parser;
 }
 var establishedSockets = /* @__PURE__ */ new WeakSet();
 var SessionHostClient = class {
@@ -657,7 +665,7 @@ var SessionHostClient = class {
       this.disconnectListeners.delete(listener);
     };
   }
-  handleDisconnect(socket, reason, error) {
+  handleDisconnect(socket, reason, error, droppedTailBytes = 0) {
     if (this.disconnectedSockets.has(socket)) return;
     this.disconnectedSockets.add(socket);
     const wasEstablished = establishedSockets.has(socket);
@@ -689,7 +697,8 @@ var SessionHostClient = class {
       reason,
       endpointPath: this.endpoint.path,
       pendingRequests,
-      error
+      error,
+      droppedTailBytes
     };
     for (const listener of this.disconnectListeners) {
       try {
@@ -709,7 +718,7 @@ var SessionHostClient = class {
     }
     const socket = net.createConnection(this.endpoint.path);
     this.socket = socket;
-    socket.on("data", createLineParser((envelope) => {
+    const parser = createLineParser((envelope) => {
       if (envelope.kind === "response") {
         const waiter = this.requestWaiters.get(envelope.requestId);
         if (waiter) {
@@ -721,15 +730,24 @@ var SessionHostClient = class {
       if (envelope.kind === "event") {
         for (const listener of this.eventListeners) listener(envelope.event);
       }
-    }));
+    });
+    socket.on("data", parser);
+    const flushParser = () => {
+      try {
+        return parser.end();
+      } catch {
+        return "";
+      }
+    };
     socket.on("error", (error) => {
-      this.handleDisconnect(socket, "error", error);
+      const remainder = flushParser();
+      this.handleDisconnect(socket, "error", error, remainder.length);
     });
     socket.on("close", () => {
-      this.handleDisconnect(socket, "closed");
+      this.handleDisconnect(socket, "closed", void 0, flushParser().length);
     });
     socket.on("end", () => {
-      this.handleDisconnect(socket, "ended");
+      this.handleDisconnect(socket, "ended", void 0, flushParser().length);
     });
     await new Promise((resolve3, reject) => {
       socket.once("connect", () => {
@@ -867,6 +885,8 @@ function sanitizeSpawnEnv(baseEnv, overrides) {
   delete env.CODEX_SANDBOX_NETWORK_DISABLED;
   delete env.NO_COLOR;
   delete env.COLOR;
+  delete env.COLUMNS;
+  delete env.LINES;
   delete env.CLAUDECODE;
   delete env.CLAUDE_CODE_CHILD_SESSION;
   delete env.CLAUDE_CODE_ENTRYPOINT;