@adhdev/ghostty-vt-node 0.7.31 → 0.7.35

package/CMakeLists.txt

@@ -54,6 +54,22 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
   SUFFIX ".node"
 )
 
+if(MSVC)
+  # cmake-js injects CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded (/MT) globally.
+  # Node.js addons must use /MD (dynamic CRT) to match node.exe.
+  # Override to MultiThreadedDLL, suppress static CRT, and explicitly link the
+  # three dynamic-CRT import libs (msvcrt/vcruntime/ucrt) that the auto-link
+  # mechanism may not pick up when cmake-js has overridden the global setting.
+  set_target_properties(${PROJECT_NAME} PROPERTIES
+    MSVC_RUNTIME_LIBRARY "MultiThreadedDLL"
+  )
+  target_link_options(${PROJECT_NAME} PRIVATE
+    /NODEFAULTLIB:LIBCMT
+    /NODEFAULTLIB:LIBCMTD
+  )
+  target_link_libraries(${PROJECT_NAME} PRIVATE msvcrt vcruntime ucrt)
+endif()
+
 if(APPLE)
   set_target_properties(${PROJECT_NAME} PROPERTIES
     BUILD_RPATH "@loader_path"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adhdev/ghostty-vt-node",
-  "version": "0.7.31",
+  "version": "0.7.35",
   "description": "Native Node binding for libghostty-vt",
   "main": "index.js",
   "types": "index.d.ts",

package/scripts/build-or-use-prebuilt.mjs

@@ -40,11 +40,20 @@ if (installPrebuiltIfPresent()) {
   process.exit(0);
 }
 
-const npx = process.platform === 'win32' ? 'npx.cmd' : 'npx';
-const result = spawnSync(npx, ['cmake-js', 'compile'], {
+const isWindows = process.platform === 'win32';
+const command = isWindows ? (process.env.ComSpec || 'cmd.exe') : 'npm';
+const args = isWindows
+  ? ['/d', '/s', '/c', 'npm exec -- cmake-js compile']
+  : ['exec', '--', 'cmake-js', 'compile'];
+console.log(`[ghostty-vt-node] compiling ${triplet} via ${command} ${args.join(' ')}`);
+const result = spawnSync(command, args, {
   cwd: packageDir,
   env: process.env,
   stdio: 'inherit',
 });
 
+if (result.error) {
+  console.error(`[ghostty-vt-node] failed to launch native build for ${triplet}:`, result.error);
+}
+
 process.exit(result.status ?? 1);