@adhdev/daemon-core 1.0.18-rc.16 → 1.0.18-rc.17

package/src/providers/provider-schema.ts

@@ -1,4 +1,5 @@
 import type { ProviderControlDef, ProviderControlType, ProviderModule } from './contracts.js'
+import { deriveAutoApproveModeRisk } from './auto-approve-modes.js'
 import { providerHasOpenPanelSupport } from './open-panel-support.js'
 
 const VALID_CAPABILITY_MEDIA_TYPES = new Set(['text', 'image', 'audio', 'video', 'resource'])
@@ -66,6 +67,7 @@ const KNOWN_PROVIDER_FIELDS = new Set<string>([
   'providerVersion',
   'status',
   'details',
+  'autoApproveModes',
   'modelLaunchArgs',
   'modelOptions',
   'thinkingLaunchArgs',
@@ -144,6 +146,7 @@ export function validateProviderDefinition(raw: unknown): ProviderValidationResu
   validateCapabilities(provider as unknown as ProviderModule, controls, errors)
   validateNativeHistory(provider.nativeHistory, errors)
   validateMeshCoordinator(provider.meshCoordinator, errors)
+  validateAutoApproveModes(provider.autoApproveModes, errors)
 
   for (const control of controls) {
     validateControl(control as ProviderControlDef, errors)
@@ -160,6 +163,86 @@ export function validateProviderDefinition(raw: unknown): ProviderValidationResu
   return { errors, warnings }
 }
 
+export function validateAutoApproveModes(raw: unknown, errors: string[]): void {
+  if (raw === undefined) return
+  if (!raw || typeof raw !== 'object' || Array.isArray(raw)) {
+    errors.push('autoApproveModes must be an object')
+    return
+  }
+
+  const config = raw as Record<string, unknown>
+  const defaultModeId = typeof config.default === 'string' ? config.default.trim() : ''
+  if (!defaultModeId) {
+    errors.push('autoApproveModes.default must be a non-empty string')
+  } else {
+    config.default = defaultModeId
+  }
+  if (!Array.isArray(config.modes) || config.modes.length === 0) {
+    errors.push('autoApproveModes.modes must be a non-empty array')
+    return
+  }
+
+  const ids = new Set<string>()
+  for (const [index, rawMode] of config.modes.entries()) {
+    const prefix = `autoApproveModes.modes[${index}]`
+    if (!rawMode || typeof rawMode !== 'object' || Array.isArray(rawMode)) {
+      errors.push(`${prefix} must be an object`)
+      continue
+    }
+    const mode = rawMode as Record<string, unknown>
+    const id = typeof mode.id === 'string' ? mode.id.trim() : ''
+    if (!id) {
+      errors.push(`${prefix}.id must be a non-empty string`)
+    } else if (ids.has(id)) {
+      errors.push(`${prefix}.id must be unique (duplicate: ${id})`)
+    } else {
+      ids.add(id)
+      mode.id = id
+    }
+    if (typeof mode.label !== 'string' || !mode.label.trim()) {
+      errors.push(`${prefix}.label must be a non-empty string`)
+    }
+
+    const strategy = mode.strategy
+    if (!['pty-parse-default', 'launch-args', 'post-boot-command'].includes(String(strategy))) {
+      errors.push(`${prefix}.strategy must be one of: pty-parse-default, launch-args, post-boot-command`)
+    } else if (strategy === 'post-boot-command') {
+      errors.push(`${prefix}.strategy post-boot-command is reserved and unsupported in v1`)
+    }
+
+    const risk = mode.risk
+    if (!['safe', 'caution', 'dangerous'].includes(String(risk))) {
+      errors.push(`${prefix}.risk must be one of: safe, caution, dangerous`)
+    }
+
+    for (const field of ['launchArgs', 'removeArgs'] as const) {
+      const value = mode[field]
+      if (value !== undefined && (!Array.isArray(value) || value.some((arg) => typeof arg !== 'string' || !arg.trim()))) {
+        errors.push(`${prefix}.${field} must be an array of non-empty strings when provided`)
+      }
+    }
+    if (strategy === 'launch-args' && (!Array.isArray(mode.launchArgs) || mode.launchArgs.length === 0)) {
+      errors.push(`${prefix}.launchArgs must be a non-empty array for launch-args strategy`)
+    }
+
+    // Mutate the validated provider object so downstream runtime/UI consumers see
+    // the effective risk. The runtime resolver repeats this derivation as defense-in-depth.
+    if (['safe', 'caution', 'dangerous'].includes(String(risk))
+        && deriveAutoApproveModeRisk(mode as any) === 'dangerous') {
+      mode.risk = 'dangerous'
+    }
+    if (mode.risk === 'dangerous' && (typeof mode.warning !== 'string' || !mode.warning.trim())) {
+      errors.push(`${prefix}.warning is required for dangerous modes`)
+    } else if (mode.warning !== undefined && (typeof mode.warning !== 'string' || !mode.warning.trim())) {
+      errors.push(`${prefix}.warning must be a non-empty string when provided`)
+    }
+  }
+
+  if (defaultModeId && !ids.has(defaultModeId)) {
+    errors.push(`autoApproveModes.default must reference an existing mode id: ${defaultModeId}`)
+  }
+}
+
 function validateCapabilities(provider: ProviderModule, controls: ProviderControlDef[], errors: string[]): void {
   const capabilities = provider.capabilities
   if (provider.contractVersion === 2) {

package/src/providers/sdk/v1/schemas/cli/provider.schema.json

@@ -119,6 +119,20 @@
         }
       }
     },
+    "autoApproveModes": {
+      "type": "object",
+      "description": "Provider-specific auto-approve choices and their launch/runtime strategy.",
+      "required": ["default", "modes"],
+      "additionalProperties": false,
+      "properties": {
+        "default": { "type": "string", "minLength": 1 },
+        "modes": {
+          "type": "array",
+          "minItems": 1,
+          "items": { "$ref": "#/$defs/autoApproveMode" }
+        }
+      }
+    },
     "sendDelayMs": {
       "type": "number",
       "minimum": 0,
@@ -476,6 +490,36 @@
     }
   },
   "$defs": {
+    "autoApproveMode": {
+      "type": "object",
+      "required": ["id", "label", "strategy", "risk"],
+      "additionalProperties": false,
+      "properties": {
+        "id": { "type": "string", "minLength": 1 },
+        "label": { "type": "string", "minLength": 1 },
+        "strategy": { "enum": ["pty-parse-default", "launch-args", "post-boot-command"] },
+        "risk": { "enum": ["safe", "caution", "dangerous"] },
+        "warning": { "type": "string", "minLength": 1 },
+        "launchArgs": {
+          "type": "array",
+          "items": { "type": "string", "minLength": 1 }
+        },
+        "removeArgs": {
+          "type": "array",
+          "items": { "type": "string", "minLength": 1 }
+        }
+      },
+      "allOf": [
+        {
+          "if": { "properties": { "strategy": { "const": "launch-args" } }, "required": ["strategy"] },
+          "then": { "required": ["launchArgs"], "properties": { "launchArgs": { "minItems": 1 } } }
+        },
+        {
+          "if": { "properties": { "risk": { "const": "dangerous" } }, "required": ["risk"] },
+          "then": { "required": ["warning"] }
+        }
+      ]
+    },
     "patternList": {
       "type": "array",
       "items": {

package/src/repo-mesh-types.ts

@@ -15,6 +15,8 @@ import type { GitRepoStatus, GitCompactSummary } from './git/git-types.js';
 import type { MeshMissionSummary, MeshMissionSlimSummary } from './mesh/mesh-missions.js';
 import type { MeshMagiActivitySummary } from './mesh/mesh-magi-status.js';
 import type { MagiKindPanelMap, DifficultyBrainMap, NodeCapabilitySlot } from '@adhdev/mesh-shared';
+import type { ProviderModule } from './providers/contracts.js';
+import { deriveAutoApproveModeRisk } from './providers/auto-approve-modes.js';
 
 // ─── Core Mesh Types ────────────────────────────
 
@@ -350,6 +352,8 @@ export interface RepoMeshPolicy {
      * A node policy may override this per-node (RepoMeshNodePolicy.delegatedWorkerAutoApprove).
      */
     delegatedWorkerAutoApprove?: boolean;
+    /** Explicit opt-in required before delegated workers may use a dangerous provider mode. */
+    delegatedWorkerDangerousModeAllow?: boolean;
     /**
      * MESH-SEND-KEYS (feature 3): opt-in to allow the coordinator to inject
      * DESTRUCTIVE keys (CTRL_C / ESC) into a worker PTY via mesh_send_keys. These
@@ -505,6 +509,8 @@ export interface RepoMeshNodePolicy {
      * precedence over the mesh-level policy for worker sessions launched onto this node.
      */
     delegatedWorkerAutoApprove?: boolean;
+    /** Per-node override for dangerous delegated worker mode authorization. */
+    delegatedWorkerDangerousModeAllow?: boolean;
     /**
      * MESH-SEND-KEYS (feature 3): per-node override for
      * RepoMeshPolicy.allowSendKeysDestructive.
@@ -550,6 +556,7 @@ export const DEFAULT_MESH_POLICY: RepoMeshPolicy = {
     // any specific session manually; that override is preserved per-device.
     spawnedSessionVisibility: 'hidden',
     delegatedWorkerAutoApprove: true,
+    delegatedWorkerDangerousModeAllow: false,
     sessionCleanupOnNodeRemove: 'preserve',
     // MAGI auto-launches a worker session per pinned replica target with no idle
     // session; those stay idle-LIVE after their turn. Default ON (stop_and_delete)
@@ -776,6 +783,13 @@ export function mergeAndNormalizePolicy(
     } else {
         delete policy.autoConvergeCodeChange;
     }
+    // Dangerous delegated-worker provider modes are fail-closed and only persist
+    // when the mesh owner has explicitly opted in.
+    if (policy.delegatedWorkerDangerousModeAllow === true) {
+        policy.delegatedWorkerDangerousModeAllow = true;
+    } else {
+        delete policy.delegatedWorkerDangerousModeAllow;
+    }
     // Coordinator idle-push policy: strict opt-in. Only persist the explicit
     // 'auto_silent_on_dispatch' value; any other/invalid value normalizes to the
     // 'always' default and is dropped so existing meshes.json stays byte-for-byte
@@ -789,23 +803,62 @@ export function mergeAndNormalizePolicy(
 }
 
 /**
- * Resolve whether a delegated worker session launched onto `nodePolicy` (within a mesh
- * governed by `meshPolicy`) should auto-approve. Precedence: node override → mesh policy
- * → default true. The result is stamped into the worker launch settings envelope as
- * `autoApprove`; it wins over the global per-provider-type autoApprove config because the
- * launch path merges the envelope as a settingsOverride on top of the provider defaults.
+ * Resolve delegated worker auto-approve. Legacy providers return a boolean. Providers
+ * with modes return the default mode id, except a dangerous default is downgraded to a
+ * non-dangerous PTY mode unless mesh/node policy explicitly opts in.
  */
 export function resolveDelegatedWorkerAutoApprove(
-    meshPolicy?: Pick<RepoMeshPolicy, 'delegatedWorkerAutoApprove'> | null,
-    nodePolicy?: Pick<RepoMeshNodePolicy, 'delegatedWorkerAutoApprove'> | null,
-): boolean {
+    meshPolicy?: Pick<RepoMeshPolicy, 'delegatedWorkerAutoApprove' | 'delegatedWorkerDangerousModeAllow'> | null,
+    nodePolicy?: Pick<RepoMeshNodePolicy, 'delegatedWorkerAutoApprove' | 'delegatedWorkerDangerousModeAllow'> | null,
+    provider?: Pick<ProviderModule, 'autoApproveModes'> | null,
+): boolean | string {
+    let enabled = true;
     if (typeof nodePolicy?.delegatedWorkerAutoApprove === 'boolean') {
-        return nodePolicy.delegatedWorkerAutoApprove;
+        enabled = nodePolicy.delegatedWorkerAutoApprove;
+    } else if (typeof meshPolicy?.delegatedWorkerAutoApprove === 'boolean') {
+        enabled = meshPolicy.delegatedWorkerAutoApprove;
     }
-    if (typeof meshPolicy?.delegatedWorkerAutoApprove === 'boolean') {
-        return meshPolicy.delegatedWorkerAutoApprove;
+    if (!enabled) return false;
+
+    const modes = provider?.autoApproveModes;
+    if (!modes) return true;
+    const defaultMode = modes.modes.find((mode) => mode.id === modes.default);
+    if (!defaultMode || defaultMode.strategy === 'post-boot-command') return false;
+
+    const dangerousAllowed = resolveDelegatedWorkerDangerousModeAllow(meshPolicy, nodePolicy);
+    if (deriveAutoApproveModeRisk(defaultMode) === 'dangerous' && !dangerousAllowed) {
+        const ptyFallback = modes!.modes.find((mode) =>
+            mode.strategy === 'pty-parse-default' && deriveAutoApproveModeRisk(mode) !== 'dangerous');
+        return ptyFallback?.id || false;
     }
-    return true;
+    return defaultMode.id;
+}
+
+export function resolveDelegatedWorkerDangerousModeAllow(
+    meshPolicy?: Pick<RepoMeshPolicy, 'delegatedWorkerDangerousModeAllow'> | null,
+    nodePolicy?: Pick<RepoMeshNodePolicy, 'delegatedWorkerDangerousModeAllow'> | null,
+): boolean {
+    if (typeof nodePolicy?.delegatedWorkerDangerousModeAllow === 'boolean') {
+        return nodePolicy.delegatedWorkerDangerousModeAllow;
+    }
+    return meshPolicy?.delegatedWorkerDangerousModeAllow === true;
+}
+
+/** Shape a boolean-or-mode resolution for the settings precedence contract. */
+export function delegatedWorkerAutoApproveSettings(
+    meshPolicy?: Pick<RepoMeshPolicy, 'delegatedWorkerAutoApprove' | 'delegatedWorkerDangerousModeAllow'> | null,
+    nodePolicy?: Pick<RepoMeshNodePolicy, 'delegatedWorkerAutoApprove' | 'delegatedWorkerDangerousModeAllow'> | null,
+    provider?: Pick<ProviderModule, 'autoApproveModes'> | null,
+): {
+    autoApprove: boolean | undefined;
+    autoApproveMode: string | undefined;
+    delegatedWorkerDangerousModeAllow: boolean;
+} {
+    const resolved = resolveDelegatedWorkerAutoApprove(meshPolicy, nodePolicy, provider);
+    const delegatedWorkerDangerousModeAllow = resolveDelegatedWorkerDangerousModeAllow(meshPolicy, nodePolicy);
+    return typeof resolved === 'string'
+        ? { autoApprove: undefined, autoApproveMode: resolved, delegatedWorkerDangerousModeAllow }
+        : { autoApprove: resolved, autoApproveMode: undefined, delegatedWorkerDangerousModeAllow };
 }
 
 /**

package/src/shared-types.ts

@@ -52,7 +52,7 @@ export type { ProviderErrorReason } from './providers/provider-instance.js';
 // Local import for use in Managed*Entry types below
 import type { ActiveChatData as _ActiveChatData, ProviderErrorReason as _ProviderErrorReason } from './providers/provider-instance.js';
 import type { WorkspaceEntry } from './config/workspaces.js';
-import type { ProviderMeshCoordinatorConfig, ProviderResumeCapability } from './providers/contracts.js';
+import type { AutoApproveModesConfig, ProviderMeshCoordinatorConfig, ProviderResumeCapability } from './providers/contracts.js';
 import type {
     GitCompactSummary,
     GitDiffSummary,
@@ -563,6 +563,8 @@ export interface AvailableProviderInfo {
     lastVerification?: MachineProviderCheckResult;
     /** Provider-declared Repo Mesh coordinator/MCP behavior. */
     meshCoordinator?: ProviderMeshCoordinatorConfig;
+    /** Provider-declared auto-approve choices shown by session launch UIs. */
+    autoApproveModes?: AutoApproveModesConfig;
     /** BRAIN-ROUTING: suggested model values for the new-session model dropdown. */
     modelOptions?: string[];
     /** BRAIN-ROUTING: reasoning-effort values for the new-session thinking dropdown. */

package/src/status/snapshot.ts

@@ -145,6 +145,7 @@ export function buildAvailableProviders(
         lastDetection?: AvailableProviderInfo['lastDetection'];
         lastVerification?: AvailableProviderInfo['lastVerification'];
         meshCoordinator?: AvailableProviderInfo['meshCoordinator'];
+        autoApproveModes?: AvailableProviderInfo['autoApproveModes'];
         _sourceTrust?: AvailableProviderInfo['trust'];
         _sourceLayer?: AvailableProviderInfo['sourceLayer'];
         _sourceName?: string | null;
@@ -183,6 +184,7 @@ export function buildAvailableProviders(
             ...(provider.lastDetection !== undefined ? { lastDetection: provider.lastDetection } : {}),
             ...(provider.lastVerification !== undefined ? { lastVerification: provider.lastVerification } : {}),
             ...(provider.meshCoordinator !== undefined ? { meshCoordinator: provider.meshCoordinator } : {}),
+            ...(provider.autoApproveModes !== undefined ? { autoApproveModes: provider.autoApproveModes } : {}),
             ...(trust ? {
                 trust,
                 trustDescription: describeTrust(trust),