@adhdev/daemon-core 0.9.82-rc.48 → 0.9.82-rc.481

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (473) hide show
  1. package/dist/boot/daemon-lifecycle.d.ts +9 -0
  2. package/dist/boot/process-hardening.d.ts +50 -0
  3. package/dist/build-info.d.ts +37 -0
  4. package/dist/chat/source-machine.d.ts +166 -0
  5. package/dist/chat/source-resolver.d.ts +104 -0
  6. package/dist/chat/subscription-updates.d.ts +1 -0
  7. package/dist/cli-adapter-types.d.ts +68 -2
  8. package/dist/cli-adapters/cli-script-runner.d.ts +117 -0
  9. package/dist/cli-adapters/cli-state-engine.d.ts +220 -0
  10. package/dist/cli-adapters/provider-cli-adapter.d.ts +126 -64
  11. package/dist/cli-adapters/provider-cli-parse.d.ts +5 -0
  12. package/dist/cli-adapters/provider-cli-runtime.d.ts +34 -0
  13. package/dist/cli-adapters/provider-cli-shared.d.ts +74 -0
  14. package/dist/cli-adapters/pty-write-chunking.d.ts +34 -0
  15. package/dist/cli-adapters/raw-terminal-io.d.ts +37 -0
  16. package/dist/cli-adapters/resolve-executable.d.ts +69 -0
  17. package/dist/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +6 -3
  18. package/dist/cli-adapters/terminal-backends/types.d.ts +10 -2
  19. package/dist/cli-adapters/terminal-screen.d.ts +4 -11
  20. package/dist/commands/chat-commands-debug-bundle.d.ts +14 -0
  21. package/dist/commands/chat-commands-read.d.ts +23 -0
  22. package/dist/commands/chat-commands-scope.d.ts +39 -0
  23. package/dist/commands/chat-commands-shared.d.ts +33 -0
  24. package/dist/commands/chat-commands-write.d.ts +14 -0
  25. package/dist/commands/chat-commands.d.ts +10 -23
  26. package/dist/commands/cli-manager.d.ts +51 -1
  27. package/dist/commands/handler.d.ts +125 -0
  28. package/dist/commands/high-family/index.d.ts +3 -0
  29. package/dist/commands/high-family/mesh-coordinator-launch.d.ts +2 -0
  30. package/dist/commands/high-family/mesh-events.d.ts +2 -0
  31. package/dist/commands/high-family/mesh-status.d.ts +2 -0
  32. package/dist/commands/high-family/types.d.ts +64 -0
  33. package/dist/commands/low-family/coordinator-prompt.d.ts +9 -0
  34. package/dist/commands/low-family/daemon-lifecycle.d.ts +2 -0
  35. package/dist/commands/low-family/diagnostics.d.ts +2 -0
  36. package/dist/commands/low-family/index.d.ts +3 -0
  37. package/dist/commands/low-family/mesh-ledger.d.ts +10 -0
  38. package/dist/commands/low-family/mesh-node-logs.d.ts +2 -0
  39. package/dist/commands/low-family/notification.d.ts +2 -0
  40. package/dist/commands/low-family/refine-config.d.ts +2 -0
  41. package/dist/commands/low-family/session-host.d.ts +2 -0
  42. package/dist/commands/low-family/spec-providerdev.d.ts +11 -0
  43. package/dist/commands/low-family/status-meta.d.ts +2 -0
  44. package/dist/commands/low-family/types.d.ts +33 -0
  45. package/dist/commands/med-family/cli-agent.d.ts +2 -0
  46. package/dist/commands/med-family/fast-forward.d.ts +2 -0
  47. package/dist/commands/med-family/ide.d.ts +10 -0
  48. package/dist/commands/med-family/index.d.ts +3 -0
  49. package/dist/commands/med-family/mesh-crud.d.ts +48 -0
  50. package/dist/commands/med-family/mesh-host-pairing.d.ts +2 -0
  51. package/dist/commands/med-family/mesh-queue.d.ts +2 -0
  52. package/dist/commands/med-family/mesh-restart.d.ts +2 -0
  53. package/dist/commands/med-family/types.d.ts +152 -0
  54. package/dist/commands/mesh-coordinator.d.ts +85 -1
  55. package/dist/commands/router-aggregate-status.d.ts +24 -0
  56. package/dist/commands/router-mesh-session-owner.d.ts +59 -0
  57. package/dist/commands/router-refine.d.ts +137 -0
  58. package/dist/commands/router-worktree-cleanup.d.ts +133 -0
  59. package/dist/commands/router.d.ts +204 -15
  60. package/dist/commands/upgrade-helper.d.ts +41 -1
  61. package/dist/config/chat-history.d.ts +11 -0
  62. package/dist/config/config.d.ts +19 -0
  63. package/dist/config/mesh-config.d.ts +136 -1
  64. package/dist/config/mesh-json-config.d.ts +199 -0
  65. package/dist/config/registry-resolver.d.ts +54 -0
  66. package/dist/config/repo-settings.d.ts +77 -0
  67. package/dist/config/state-store.d.ts +30 -0
  68. package/dist/daemon/dev-server.d.ts +0 -2
  69. package/dist/detection/cli-detector.d.ts +17 -0
  70. package/dist/detection/ide-detector.d.ts +13 -0
  71. package/dist/detection/win32-ide-version.d.ts +37 -0
  72. package/dist/git/change-impact-config.d.ts +159 -0
  73. package/dist/git/git-commands.d.ts +26 -2
  74. package/dist/git/git-diff.d.ts +6 -0
  75. package/dist/git/git-executor.d.ts +11 -0
  76. package/dist/git/git-status.d.ts +57 -0
  77. package/dist/git/git-types.d.ts +2 -50
  78. package/dist/git/git-worktree.d.ts +71 -1
  79. package/dist/git/index.d.ts +3 -1
  80. package/dist/index.d.ts +73 -17
  81. package/dist/index.js +52979 -18657
  82. package/dist/index.js.map +1 -1
  83. package/dist/index.mjs +59496 -25355
  84. package/dist/index.mjs.map +1 -1
  85. package/dist/installer.d.ts +1 -4
  86. package/dist/ipc/local-ipc-server.d.ts +91 -0
  87. package/dist/launch.d.ts +1 -1
  88. package/dist/logging/async-batch-writer.d.ts +10 -0
  89. package/dist/logging/debug-config.d.ts +16 -0
  90. package/dist/logging/log-redactor.d.ts +24 -0
  91. package/dist/logging/log-tail-reader.d.ts +81 -0
  92. package/dist/logging/logger.d.ts +1 -1
  93. package/dist/mesh/contracts.d.ts +230 -0
  94. package/dist/mesh/coordinator-prompt.d.ts +76 -0
  95. package/dist/mesh/coordinator-registry.d.ts +59 -0
  96. package/dist/mesh/mesh-active-work.d.ts +203 -0
  97. package/dist/mesh/mesh-clone-grace.d.ts +8 -0
  98. package/dist/mesh/mesh-completion-synthesis.d.ts +4 -0
  99. package/dist/mesh/mesh-coordinator-config.d.ts +21 -0
  100. package/dist/mesh/mesh-delivery-policy.d.ts +104 -0
  101. package/dist/mesh/mesh-event-classify.d.ts +7 -0
  102. package/dist/mesh/mesh-event-forwarding.d.ts +49 -0
  103. package/dist/mesh/mesh-event-trace.d.ts +21 -0
  104. package/dist/mesh/mesh-events-coordinator.d.ts +4 -0
  105. package/dist/mesh/mesh-events-pending.d.ts +246 -0
  106. package/dist/mesh/mesh-events-stale.d.ts +61 -0
  107. package/dist/mesh/mesh-events-utils.d.ts +75 -0
  108. package/dist/mesh/mesh-events.d.ts +6 -49
  109. package/dist/mesh/mesh-fast-forward.d.ts +81 -0
  110. package/dist/mesh/mesh-host-ownership.d.ts +29 -0
  111. package/dist/mesh/mesh-init.d.ts +128 -0
  112. package/dist/mesh/mesh-ledger-reconciliation.d.ts +23 -4
  113. package/dist/mesh/mesh-ledger.d.ts +139 -1
  114. package/dist/mesh/mesh-magi-status.d.ts +63 -0
  115. package/dist/mesh/mesh-missions.d.ts +281 -0
  116. package/dist/mesh/mesh-node-identity.d.ts +310 -0
  117. package/dist/mesh/mesh-queue-assignment.d.ts +158 -0
  118. package/dist/mesh/mesh-reconcile-acked-hold.d.ts +17 -0
  119. package/dist/mesh/mesh-reconcile-config.d.ts +6 -0
  120. package/dist/mesh/mesh-reconcile-identity.d.ts +6 -0
  121. package/dist/mesh/mesh-reconcile-loop.d.ts +80 -0
  122. package/dist/mesh/mesh-reconcile-v2-backstop.d.ts +16 -0
  123. package/dist/mesh/mesh-refine-batch.d.ts +68 -0
  124. package/dist/mesh/mesh-refine-gates.d.ts +428 -0
  125. package/dist/mesh/mesh-refine-status.d.ts +62 -0
  126. package/dist/mesh/mesh-remote-event-pull.d.ts +15 -0
  127. package/dist/mesh/mesh-review-inbox.d.ts +90 -0
  128. package/dist/mesh/mesh-routing.d.ts +70 -0
  129. package/dist/mesh/mesh-runtime-store.d.ts +508 -0
  130. package/dist/mesh/mesh-scheduling-runtime.d.ts +78 -0
  131. package/dist/mesh/mesh-task-inflight.d.ts +46 -0
  132. package/dist/mesh/mesh-task-stats.d.ts +49 -0
  133. package/dist/mesh/mesh-unresolved-forward-outbox.d.ts +30 -0
  134. package/dist/mesh/mesh-warmup-deadline.d.ts +68 -0
  135. package/dist/mesh/mesh-work-queue.d.ts +363 -5
  136. package/dist/mesh/preview-freshness.d.ts +28 -0
  137. package/dist/mesh/refine-config.d.ts +216 -0
  138. package/dist/mesh/worktree-bootstrap-config.d.ts +219 -0
  139. package/dist/providers/acp-provider-instance.d.ts +5 -0
  140. package/dist/providers/approval-utils.d.ts +46 -0
  141. package/dist/providers/chat-message-normalization.d.ts +58 -1
  142. package/dist/providers/cli-provider-effect-format.d.ts +30 -0
  143. package/dist/providers/cli-provider-history-dedup.d.ts +17 -0
  144. package/dist/providers/cli-provider-input-prompt.d.ts +12 -0
  145. package/dist/providers/cli-provider-instance-types.d.ts +45 -0
  146. package/dist/providers/cli-provider-instance.d.ts +406 -30
  147. package/dist/providers/cli-provider-status-helpers.d.ts +46 -0
  148. package/dist/providers/cli-provider-transcript-merge.d.ts +7 -0
  149. package/dist/providers/contracts.d.ts +149 -6
  150. package/dist/providers/external-sources.d.ts +71 -0
  151. package/dist/providers/manual-attendance.d.ts +79 -0
  152. package/dist/providers/native-history/antigravity-claim-registry.d.ts +39 -0
  153. package/dist/providers/native-history/antigravity-cli-transcript.d.ts +137 -0
  154. package/dist/providers/native-history/claude-cli-transcript.d.ts +70 -0
  155. package/dist/providers/native-history/codex-cli-transcript.d.ts +73 -0
  156. package/dist/providers/native-history/constants.d.ts +12 -0
  157. package/dist/providers/native-history/dispatcher.d.ts +44 -0
  158. package/dist/providers/native-history/hermes-cli-transcript.d.ts +30 -0
  159. package/dist/providers/native-history/index.d.ts +13 -0
  160. package/dist/providers/provider-instance-manager.d.ts +29 -0
  161. package/dist/providers/provider-instance.d.ts +30 -1
  162. package/dist/providers/provider-loader.d.ts +42 -5
  163. package/dist/providers/provider-trust.d.ts +31 -0
  164. package/dist/providers/read-chat-contract.d.ts +29 -0
  165. package/dist/providers/sdk/v1/builders/acp/detect-status.d.ts +68 -0
  166. package/dist/providers/sdk/v1/builders/cli/detect-status.d.ts +86 -0
  167. package/dist/providers/sdk/v1/builders/cli/parse-approval-squash.d.ts +59 -0
  168. package/dist/providers/sdk/v1/builders/cli/parse-approval.d.ts +65 -0
  169. package/dist/providers/sdk/v1/builders/cli/parse-session.d.ts +91 -0
  170. package/dist/providers/sdk/v1/builders/cli/visible-region.d.ts +42 -0
  171. package/dist/providers/sdk/v1/fixture-tooling/format.d.ts +126 -0
  172. package/dist/providers/sdk/v1/fixture-tooling/index.d.ts +8 -0
  173. package/dist/providers/sdk/v1/fixture-tooling/replay.d.ts +38 -0
  174. package/dist/providers/sdk/v1/index.d.ts +30 -0
  175. package/dist/providers/sdk/v1/sandbox/README-design.d.ts +193 -0
  176. package/dist/providers/sdk/v1/sandbox/require-whitelist.d.ts +74 -0
  177. package/dist/providers/sdk/v1/sandbox/script-runner.d.ts +98 -0
  178. package/dist/providers/sdk/v1/types/cli/index.d.ts +277 -0
  179. package/dist/providers/sdk/v1/types/common/index.d.ts +203 -0
  180. package/dist/providers/sdk/v1/validators/index.d.ts +5 -0
  181. package/dist/providers/sdk/v1/validators/manifest.d.ts +40 -0
  182. package/dist/providers/sdk/v1/validators/taint.d.ts +52 -0
  183. package/dist/providers/spec/adapter.d.ts +98 -0
  184. package/dist/providers/spec/cli-adapter.d.ts +223 -0
  185. package/dist/providers/spec/evaluator.d.ts +45 -0
  186. package/dist/providers/spec/fsm-driver.d.ts +449 -0
  187. package/dist/providers/spec/fsm-evaluator.d.ts +93 -0
  188. package/dist/providers/spec/fsm-loader.d.ts +14 -0
  189. package/dist/providers/spec/fsm-types.d.ts +202 -0
  190. package/dist/providers/spec/native-history-executor.d.ts +41 -0
  191. package/dist/providers/spec/pre-launch-trust.d.ts +16 -0
  192. package/dist/providers/spec/route.d.ts +4 -0
  193. package/dist/providers/spec/types.d.ts +244 -0
  194. package/dist/providers/status-monitor.d.ts +7 -7
  195. package/dist/providers/transcript-v2.d.ts +176 -0
  196. package/dist/providers/types/interactive-prompt.d.ts +84 -0
  197. package/dist/providers/working-dir.d.ts +17 -0
  198. package/dist/repo-mesh-types.d.ts +629 -12
  199. package/dist/runtime-defaults.d.ts +2 -0
  200. package/dist/session-host/managed-host.d.ts +64 -0
  201. package/dist/session-host/runtime-surface.d.ts +10 -16
  202. package/dist/sessions/registry.d.ts +26 -0
  203. package/dist/shared-types-extra.d.ts +2 -4
  204. package/dist/shared-types.d.ts +98 -55
  205. package/dist/status/chat-tail-hot-sessions.d.ts +40 -0
  206. package/dist/status/normalize.d.ts +1 -1
  207. package/dist/status/normalize.js +1 -0
  208. package/dist/status/normalize.js.map +1 -1
  209. package/dist/status/normalize.mjs +1 -0
  210. package/dist/status/normalize.mjs.map +1 -1
  211. package/dist/status/reporter.d.ts +2 -0
  212. package/dist/status/snapshot.d.ts +26 -0
  213. package/dist/system/hash.d.ts +8 -0
  214. package/dist/system/load-better-sqlite3.d.ts +21 -0
  215. package/dist/types.d.ts +5 -0
  216. package/package.json +11 -4
  217. package/src/agent-stream/poller.ts +2 -3
  218. package/src/agent-stream/provider-adapter.ts +1 -1
  219. package/src/boot/daemon-lifecycle.ts +80 -14
  220. package/src/boot/process-hardening.ts +89 -0
  221. package/src/build-info.ts +73 -0
  222. package/src/chat/source-machine.ts +534 -0
  223. package/src/chat/source-resolver.ts +0 -0
  224. package/src/chat/subscription-updates.ts +20 -1
  225. package/src/cli-adapter-types.d.ts +3 -1
  226. package/src/cli-adapter-types.ts +68 -2
  227. package/src/cli-adapters/cli-script-runner.ts +421 -0
  228. package/src/cli-adapters/cli-state-engine.ts +1282 -0
  229. package/src/cli-adapters/provider-cli-adapter.d.ts +1 -1
  230. package/src/cli-adapters/provider-cli-adapter.ts +954 -1144
  231. package/src/cli-adapters/provider-cli-parse.d.ts +2 -0
  232. package/src/cli-adapters/provider-cli-parse.ts +19 -0
  233. package/src/cli-adapters/provider-cli-runtime.ts +56 -7
  234. package/src/cli-adapters/provider-cli-shared.d.ts +4 -0
  235. package/src/cli-adapters/provider-cli-shared.ts +121 -11
  236. package/src/cli-adapters/pty-transport.ts +2 -1
  237. package/src/cli-adapters/pty-write-chunking.ts +106 -0
  238. package/src/cli-adapters/raw-terminal-io.ts +252 -0
  239. package/src/cli-adapters/resolve-executable.ts +204 -0
  240. package/src/cli-adapters/session-host-transport.ts +2 -1
  241. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.ts +63 -29
  242. package/src/cli-adapters/terminal-backends/types.ts +10 -3
  243. package/src/cli-adapters/terminal-screen.ts +16 -81
  244. package/src/commands/chat-commands-debug-bundle.ts +398 -0
  245. package/src/commands/chat-commands-read.ts +2767 -0
  246. package/src/commands/chat-commands-scope.ts +54 -0
  247. package/src/commands/chat-commands-shared.ts +114 -0
  248. package/src/commands/chat-commands-write.ts +891 -0
  249. package/src/commands/chat-commands.ts +19 -1841
  250. package/src/commands/cli-manager.d.ts +2 -0
  251. package/src/commands/cli-manager.ts +659 -27
  252. package/src/commands/handler.ts +845 -2
  253. package/src/commands/high-family/index.ts +28 -0
  254. package/src/commands/high-family/mesh-coordinator-launch.ts +680 -0
  255. package/src/commands/high-family/mesh-events.ts +102 -0
  256. package/src/commands/high-family/mesh-status.ts +849 -0
  257. package/src/commands/high-family/types.ts +80 -0
  258. package/src/commands/low-family/coordinator-prompt.ts +72 -0
  259. package/src/commands/low-family/daemon-lifecycle.ts +120 -0
  260. package/src/commands/low-family/diagnostics.ts +57 -0
  261. package/src/commands/low-family/index.ts +37 -0
  262. package/src/commands/low-family/mesh-ledger.ts +62 -0
  263. package/src/commands/low-family/mesh-node-logs.ts +87 -0
  264. package/src/commands/low-family/notification.ts +116 -0
  265. package/src/commands/low-family/refine-config.ts +106 -0
  266. package/src/commands/low-family/session-host.ts +282 -0
  267. package/src/commands/low-family/spec-providerdev.ts +217 -0
  268. package/src/commands/low-family/status-meta.ts +112 -0
  269. package/src/commands/low-family/types.ts +39 -0
  270. package/src/commands/med-family/cli-agent.ts +241 -0
  271. package/src/commands/med-family/fast-forward.ts +230 -0
  272. package/src/commands/med-family/ide.ts +163 -0
  273. package/src/commands/med-family/index.ts +37 -0
  274. package/src/commands/med-family/mesh-crud.ts +1287 -0
  275. package/src/commands/med-family/mesh-host-pairing.ts +234 -0
  276. package/src/commands/med-family/mesh-queue.ts +167 -0
  277. package/src/commands/med-family/mesh-restart.ts +92 -0
  278. package/src/commands/med-family/types.ts +153 -0
  279. package/src/commands/mesh-coordinator.ts +334 -124
  280. package/src/commands/router-aggregate-status.ts +209 -0
  281. package/src/commands/router-mesh-session-owner.ts +114 -0
  282. package/src/commands/router-refine.ts +1711 -0
  283. package/src/commands/router-worktree-cleanup.ts +870 -0
  284. package/src/commands/router.ts +795 -4143
  285. package/src/commands/stream-commands.ts +8 -0
  286. package/src/commands/upgrade-helper.ts +310 -45
  287. package/src/config/chat-history.ts +517 -24
  288. package/src/config/config.ts +30 -0
  289. package/src/config/mesh-config.ts +632 -23
  290. package/src/config/mesh-json-config.ts +376 -0
  291. package/src/config/recent-activity.ts +8 -2
  292. package/src/config/registry-resolver.ts +100 -0
  293. package/src/config/repo-settings.ts +111 -0
  294. package/src/config/state-store.ts +55 -0
  295. package/src/daemon/dev-auto-implement.ts +3 -2
  296. package/src/daemon/dev-cli-debug.ts +10 -1
  297. package/src/daemon/dev-server.ts +0 -541
  298. package/src/detection/cli-detector.ts +94 -9
  299. package/src/detection/ide-detector.ts +55 -16
  300. package/src/detection/win32-ide-version.ts +106 -0
  301. package/src/git/change-impact-config.ts +354 -0
  302. package/src/git/git-commands.ts +112 -16
  303. package/src/git/git-diff.ts +81 -11
  304. package/src/git/git-executor.ts +12 -0
  305. package/src/git/git-status.ts +767 -48
  306. package/src/git/git-types.ts +14 -62
  307. package/src/git/git-worktree.ts +261 -4
  308. package/src/git/index.ts +17 -0
  309. package/src/index.ts +213 -13
  310. package/src/installer.d.ts +1 -1
  311. package/src/installer.ts +8 -6
  312. package/src/ipc/local-ipc-server.ts +278 -0
  313. package/src/launch.d.ts +1 -1
  314. package/src/launch.ts +37 -28
  315. package/src/logging/async-batch-writer.ts +55 -0
  316. package/src/logging/command-log.ts +7 -5
  317. package/src/logging/debug-config.ts +25 -0
  318. package/src/logging/debug-trace.ts +7 -2
  319. package/src/logging/log-redactor.ts +100 -0
  320. package/src/logging/log-tail-reader.ts +341 -0
  321. package/src/logging/logger.ts +14 -7
  322. package/src/mesh/contracts.ts +469 -0
  323. package/src/mesh/coordinator-prompt.ts +572 -34
  324. package/src/mesh/coordinator-registry.ts +121 -0
  325. package/src/mesh/mesh-active-work.ts +706 -0
  326. package/src/mesh/mesh-clone-grace.ts +68 -0
  327. package/src/mesh/mesh-completion-synthesis.ts +416 -0
  328. package/src/mesh/mesh-coordinator-config.ts +97 -0
  329. package/src/mesh/mesh-delivery-policy.ts +284 -0
  330. package/src/mesh/mesh-event-classify.ts +78 -0
  331. package/src/mesh/mesh-event-forwarding.ts +2002 -0
  332. package/src/mesh/mesh-event-trace.ts +67 -0
  333. package/src/mesh/mesh-events-coordinator.ts +32 -0
  334. package/src/mesh/mesh-events-pending.ts +1494 -0
  335. package/src/mesh/mesh-events-stale.ts +452 -0
  336. package/src/mesh/mesh-events-utils.ts +443 -0
  337. package/src/mesh/mesh-events.ts +43 -1035
  338. package/src/mesh/mesh-fast-forward.ts +856 -0
  339. package/src/mesh/mesh-host-ownership.ts +111 -0
  340. package/src/mesh/mesh-init.ts +350 -0
  341. package/src/mesh/mesh-ledger-reconciliation.ts +12 -7
  342. package/src/mesh/mesh-ledger.ts +898 -102
  343. package/src/mesh/mesh-magi-status.ts +223 -0
  344. package/src/mesh/mesh-missions.ts +695 -0
  345. package/src/mesh/mesh-node-identity.ts +2065 -0
  346. package/src/mesh/mesh-queue-assignment.ts +2263 -0
  347. package/src/mesh/mesh-reconcile-acked-hold.ts +230 -0
  348. package/src/mesh/mesh-reconcile-config.ts +66 -0
  349. package/src/mesh/mesh-reconcile-identity.ts +103 -0
  350. package/src/mesh/mesh-reconcile-loop.ts +1473 -0
  351. package/src/mesh/mesh-reconcile-v2-backstop.ts +62 -0
  352. package/src/mesh/mesh-refine-batch.ts +205 -0
  353. package/src/mesh/mesh-refine-gates.ts +1686 -0
  354. package/src/mesh/mesh-refine-status.ts +231 -0
  355. package/src/mesh/mesh-remote-event-pull.ts +279 -0
  356. package/src/mesh/mesh-review-inbox.ts +308 -0
  357. package/src/mesh/mesh-routing.ts +291 -0
  358. package/src/mesh/mesh-runtime-store.ts +2150 -0
  359. package/src/mesh/mesh-scheduling-runtime.ts +198 -0
  360. package/src/mesh/mesh-task-inflight.ts +70 -0
  361. package/src/mesh/mesh-task-stats.ts +161 -0
  362. package/src/mesh/mesh-unresolved-forward-outbox.ts +185 -0
  363. package/src/mesh/mesh-warmup-deadline.ts +152 -0
  364. package/src/mesh/mesh-work-queue.ts +1437 -147
  365. package/src/mesh/preview-freshness.ts +163 -0
  366. package/src/mesh/refine-config.ts +423 -0
  367. package/src/mesh/worktree-bootstrap-config.ts +599 -0
  368. package/src/providers/acp-provider-instance.ts +43 -10
  369. package/src/providers/approval-utils.d.ts +5 -0
  370. package/src/providers/approval-utils.ts +100 -6
  371. package/src/providers/chat-message-normalization.ts +126 -4
  372. package/src/providers/cli-provider-effect-format.ts +53 -0
  373. package/src/providers/cli-provider-history-dedup.ts +75 -0
  374. package/src/providers/cli-provider-input-prompt.ts +133 -0
  375. package/src/providers/cli-provider-instance-types.ts +131 -0
  376. package/src/providers/cli-provider-instance.ts +2709 -499
  377. package/src/providers/cli-provider-status-helpers.ts +123 -0
  378. package/src/providers/cli-provider-transcript-merge.ts +114 -0
  379. package/src/providers/contracts.d.ts +55 -0
  380. package/src/providers/contracts.ts +160 -6
  381. package/src/providers/extension-provider-instance.ts +12 -7
  382. package/src/providers/external-sources.ts +218 -0
  383. package/src/providers/ide-provider-instance.ts +35 -12
  384. package/src/providers/manual-attendance.ts +105 -0
  385. package/src/providers/native-history/antigravity-claim-registry.ts +138 -0
  386. package/src/providers/native-history/antigravity-cli-transcript.ts +1275 -0
  387. package/src/providers/native-history/claude-cli-transcript.ts +396 -0
  388. package/src/providers/native-history/codex-cli-transcript.ts +479 -0
  389. package/src/providers/native-history/constants.ts +19 -0
  390. package/src/providers/native-history/dispatcher.ts +617 -0
  391. package/src/providers/native-history/hermes-cli-transcript.ts +312 -0
  392. package/src/providers/native-history/index.ts +30 -0
  393. package/src/providers/provider-instance-manager.ts +71 -0
  394. package/src/providers/provider-instance.ts +24 -1
  395. package/src/providers/provider-loader.ts +700 -55
  396. package/src/providers/provider-schema.ts +87 -14
  397. package/src/providers/provider-trust.ts +114 -0
  398. package/src/providers/read-chat-contract.ts +76 -16
  399. package/src/providers/sdk/README.md +49 -0
  400. package/src/providers/sdk/v1/builders/acp/detect-status.ts +144 -0
  401. package/src/providers/sdk/v1/builders/cli/detect-status.ts +313 -0
  402. package/src/providers/sdk/v1/builders/cli/parse-approval-squash.ts +158 -0
  403. package/src/providers/sdk/v1/builders/cli/parse-approval.ts +261 -0
  404. package/src/providers/sdk/v1/builders/cli/parse-session.ts +276 -0
  405. package/src/providers/sdk/v1/builders/cli/visible-region.ts +143 -0
  406. package/src/providers/sdk/v1/fixture-tooling/format.ts +130 -0
  407. package/src/providers/sdk/v1/fixture-tooling/index.ts +22 -0
  408. package/src/providers/sdk/v1/fixture-tooling/replay.ts +352 -0
  409. package/src/providers/sdk/v1/index.ts +152 -0
  410. package/src/providers/sdk/v1/sandbox/README-design.ts +195 -0
  411. package/src/providers/sdk/v1/sandbox/require-whitelist.ts +472 -0
  412. package/src/providers/sdk/v1/sandbox/script-runner.ts +150 -0
  413. package/src/providers/sdk/v1/schemas/cli/provider.schema.json +509 -0
  414. package/src/providers/sdk/v1/schemas/primitives/acp-session-protocol-v1.json +131 -0
  415. package/src/providers/sdk/v1/schemas/primitives/native-history-codex-rollout-v1.json +66 -0
  416. package/src/providers/sdk/v1/schemas/primitives/tui-approval-squash-v1.json +91 -0
  417. package/src/providers/sdk/v1/schemas/primitives/tui-assistant-block-v1.json +91 -0
  418. package/src/providers/sdk/v1/schemas/primitives/tui-cue-ordering-v1.json +47 -0
  419. package/src/providers/sdk/v1/schemas/primitives/tui-dispatch-order-v1.json +32 -0
  420. package/src/providers/sdk/v1/schemas/primitives/tui-footer-chrome-v1.json +42 -0
  421. package/src/providers/sdk/v1/schemas/primitives/tui-index-finder-v1.json +27 -0
  422. package/src/providers/sdk/v1/schemas/primitives/tui-modal-v1.json +125 -0
  423. package/src/providers/sdk/v1/schemas/primitives/tui-prompt-marker-v1.json +45 -0
  424. package/src/providers/sdk/v1/schemas/primitives/tui-session-id-extraction-v1.json +46 -0
  425. package/src/providers/sdk/v1/schemas/primitives/tui-settled-prompt-v1.json +71 -0
  426. package/src/providers/sdk/v1/schemas/primitives/tui-spinner-v1.json +83 -0
  427. package/src/providers/sdk/v1/schemas/primitives/tui-transcript-pty-v1.json +83 -0
  428. package/src/providers/sdk/v1/schemas/primitives/tui-visible-region-v1.json +57 -0
  429. package/src/providers/sdk/v1/schemas/primitives/tui-welcome-screen-v1.json +35 -0
  430. package/src/providers/sdk/v1/types/cli/index.ts +365 -0
  431. package/src/providers/sdk/v1/types/common/index.ts +229 -0
  432. package/src/providers/sdk/v1/validators/index.ts +19 -0
  433. package/src/providers/sdk/v1/validators/manifest.ts +110 -0
  434. package/src/providers/sdk/v1/validators/taint.ts +309 -0
  435. package/src/providers/spec/adapter.ts +246 -0
  436. package/src/providers/spec/cli-adapter.ts +1064 -0
  437. package/src/providers/spec/evaluator.ts +407 -0
  438. package/src/providers/spec/fsm-driver.ts +1528 -0
  439. package/src/providers/spec/fsm-evaluator.ts +290 -0
  440. package/src/providers/spec/fsm-loader.ts +128 -0
  441. package/src/providers/spec/fsm-types.ts +301 -0
  442. package/src/providers/spec/native-history-executor.ts +1241 -0
  443. package/src/providers/spec/pre-launch-trust.ts +104 -0
  444. package/src/providers/spec/route.ts +51 -0
  445. package/src/providers/spec/types.ts +284 -0
  446. package/src/providers/status-monitor.d.ts +7 -7
  447. package/src/providers/status-monitor.ts +37 -22
  448. package/src/providers/transcript-v2.ts +567 -0
  449. package/src/providers/types/interactive-prompt.ts +536 -0
  450. package/src/providers/version-archive.ts +64 -24
  451. package/src/providers/working-dir.ts +23 -0
  452. package/src/repo-mesh-types.ts +868 -13
  453. package/src/runtime-defaults.ts +39 -0
  454. package/src/session-host/managed-host.ts +218 -0
  455. package/src/session-host/runtime-surface.ts +20 -80
  456. package/src/sessions/registry.ts +44 -0
  457. package/src/shared-types-extra.ts +2 -4
  458. package/src/shared-types.d.ts +8 -0
  459. package/src/shared-types.ts +136 -55
  460. package/src/status/builders.ts +26 -6
  461. package/src/status/chat-tail-hot-sessions.ts +117 -2
  462. package/src/status/normalize.ts +2 -0
  463. package/src/status/reporter.ts +19 -1
  464. package/src/status/snapshot.ts +95 -26
  465. package/src/system/hash.ts +23 -0
  466. package/src/system/host-memory.ts +29 -12
  467. package/src/system/load-better-sqlite3.ts +68 -0
  468. package/src/types.ts +5 -0
  469. package/dist/cli-adapters/terminal-backends/xterm-backend.d.ts +0 -17
  470. package/dist/mesh/mesh-sync.d.ts +0 -53
  471. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +0 -16
  472. package/src/cli-adapters/terminal-backends/xterm-backend.ts +0 -97
  473. package/src/mesh/mesh-sync.ts +0 -111
@@ -9,315 +9,292 @@ import * as os from 'os';
9
9
  import * as path from 'path';
10
10
  import * as crypto from 'crypto';
11
11
  import * as fs from 'fs';
12
- import { createRequire } from 'node:module';
13
- import { normalizeInputEnvelope, type ProviderModule, flattenContent, type InputEnvelope, type InputPart } from './contracts.js';
12
+ import { normalizeInputEnvelope, type ProviderModule, flattenContent, type InputEnvelope } from './contracts.js';
14
13
  import { assertProviderSupportsDeclaredInput, getEffectiveMessageInputSupport } from './provider-input-support.js';
15
14
  import type { ProviderInstance, ProviderState, ProviderEvent, InstanceContext, ProviderErrorReason, HotChatSessionState, SessionModalState } from './provider-instance.js';
15
+ import { normalizeInteractivePrompt, normalizeInteractivePromptResponse, type InteractivePrompt } from './types/interactive-prompt.js';
16
16
  import { ProviderCliAdapter } from '../cli-adapters/provider-cli-adapter.js';
17
+ import { shortHash } from '../system/hash.js';
17
18
  import type { CliProviderModule } from '../cli-adapters/provider-cli-adapter.js';
19
+ import { createCliAdapter } from './spec/route.js';
18
20
  import type { PtyRuntimeMetadata, PtyTransportFactory } from '../cli-adapters/pty-transport.js';
19
21
  import { StatusMonitor } from './status-monitor.js';
20
22
  import { ChatHistoryWriter, isNativeSourceCanonicalHistory, materializeProviderNativeHistory, readChatHistory, readProviderChatHistory } from '../config/chat-history.js';
23
+ import { loadPersistedProviderSessionPins } from '../config/state-store.js';
21
24
  import { LOG } from '../logging/logger.js';
25
+ import { recordDebugTrace } from '../logging/debug-trace.js';
26
+ import { shouldCollectTraceCategory } from '../logging/debug-config.js';
27
+ import { traceMeshEventStage, traceMeshEventDrop } from '../mesh/mesh-event-trace.js';
22
28
  import type { ChatMessage } from '../types.js';
23
29
  import { buildPersistedProviderEffectMessage, normalizeProviderEffects } from './control-effects.js';
24
- import { formatAutoApprovalMessage, pickApprovalButton } from './approval-utils.js';
30
+ import { formatAutoApprovalMessage, pickApprovalButton, hasNegativeApprovalOption, hasReliableApprovalAffirmative, looksLikeActiveApprovalPromptText, normalizeApprovalLabel } from './approval-utils.js';
25
31
  import { getCliScriptCommand, parseCliScriptResult } from './cli-script-results.js';
26
32
  import { mergeProviderPatchState, resolveProviderStateSurface } from './provider-patch-state.js';
27
33
  import { normalizeProviderSessionId } from './provider-session-id.js';
28
- import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages } from './chat-message-normalization.js';
29
-
30
- type PersistableCliHistoryMessage = {
31
- role: string;
32
- content: string;
33
- kind?: string;
34
- senderName?: string;
35
- receivedAt?: number;
36
- };
37
-
38
- type CompletedDebouncePending = {
39
- chatTitle: string;
40
- duration: number;
41
- timestamp: number;
42
- firstObservedAt: number;
43
- loggedBlockReason?: string;
44
- };
45
-
46
- const COMPLETED_FINALIZATION_RETRY_MS = 1000;
47
- const COMPLETED_FINALIZATION_MAX_WAIT_MS = 30_000;
48
-
49
- const IMAGE_MIME_EXTENSIONS: Record<string, string> = {
50
- 'image/png': '.png',
51
- 'image/jpeg': '.jpg',
52
- 'image/jpg': '.jpg',
53
- 'image/gif': '.gif',
54
- 'image/webp': '.webp',
55
- 'image/bmp': '.bmp',
56
- 'image/tiff': '.tiff',
57
- 'image/svg+xml': '.svg',
58
- };
59
-
60
- function filePathFromUri(uri: string): string | null {
61
- if (!uri) return null;
62
- if (uri.startsWith('file://')) {
63
- try {
64
- return decodeURIComponent(new URL(uri).pathname);
65
- } catch {
66
- return uri.slice('file://'.length);
67
- }
68
- }
69
- if (path.isAbsolute(uri)) return uri;
70
- return null;
71
- }
72
-
73
- function extensionForImageMime(mimeType: string): string {
74
- return IMAGE_MIME_EXTENSIONS[mimeType.toLowerCase()] || '.img';
75
- }
76
-
77
- function safeInputImageBasename(index: number, mimeType: string): string {
78
- const extension = extensionForImageMime(mimeType);
79
- const suffix = crypto.randomBytes(6).toString('hex');
80
- return `adhdev-input-image-${Date.now()}-${index}-${suffix}${extension}`;
81
- }
82
-
83
- function materializeImageDataPart(part: Extract<InputPart, { type: 'image' }>, index: number, dir: string): string | null {
84
- if (!part.data) return null;
85
- const rawData = part.data.includes(',') ? part.data.split(',').pop() || '' : part.data;
86
- if (!rawData) return null;
87
- fs.mkdirSync(dir, { recursive: true });
88
- const filePath = path.join(dir, safeInputImageBasename(index, part.mimeType));
89
- fs.writeFileSync(filePath, Buffer.from(rawData, 'base64'));
90
- cleanupStaleMaterializedImages(dir);
91
- return filePath;
92
- }
93
-
94
- const MATERIALIZED_IMAGE_MAX_AGE_MS = 60 * 60 * 1000; // 1 hour
95
- const MATERIALIZED_IMAGE_CLEANUP_INTERVAL_MS = 5 * 60 * 1000; // 5 minutes
96
- let lastMaterializedImageCleanupAt = 0;
97
-
98
- function cleanupStaleMaterializedImages(dir: string): void {
99
- const now = Date.now();
100
- if (now - lastMaterializedImageCleanupAt < MATERIALIZED_IMAGE_CLEANUP_INTERVAL_MS) return;
101
- lastMaterializedImageCleanupAt = now;
102
- try {
103
- const entries = fs.readdirSync(dir);
104
- for (const entry of entries) {
105
- if (!entry.startsWith('adhdev-input-image-')) continue;
106
- const fullPath = path.join(dir, entry);
107
- try {
108
- const stat = fs.statSync(fullPath);
109
- if (now - stat.mtimeMs > MATERIALIZED_IMAGE_MAX_AGE_MS) {
110
- fs.unlinkSync(fullPath);
111
- }
112
- } catch { /* file may have been removed concurrently */ }
113
- }
114
- } catch { /* dir may not exist or be inaccessible */ }
115
- }
116
-
117
- function hasNonEmptyCliModalButtons(activeModal: unknown): boolean {
118
- const buttons = (activeModal as any)?.buttons;
119
- return Array.isArray(buttons) && buttons.some((button) => String(button || '').trim().length > 0);
120
- }
121
-
122
- function isCliGeneratingLikeStatus(status: unknown): boolean {
123
- return status === 'generating' || status === 'streaming' || status === 'long_generating' || status === 'starting';
124
- }
125
-
126
- export function buildCliStructuredInputPrompt(
127
- input: InputEnvelope,
128
- options: { materializeDir?: string } = {},
129
- ): string {
130
- const promptParts: string[] = [];
131
- const imageRefs: string[] = [];
132
- const resourceRefs: string[] = [];
133
- const materializeDir = options.materializeDir || path.join(os.tmpdir(), 'adhdev-input-media');
134
-
135
- input.parts.forEach((part, index) => {
136
- if (part.type === 'text' && part.text.trim()) {
137
- promptParts.push(part.text.trim());
138
- return;
139
- }
140
-
141
- if (part.type === 'image') {
142
- const localPath = typeof part.uri === 'string' ? filePathFromUri(part.uri) : null;
143
- const materializedPath = !localPath && part.data ? materializeImageDataPart(part, index, materializeDir) : null;
144
- const ref = localPath || materializedPath || part.uri || '';
145
- if (ref) imageRefs.push(ref);
146
- if (part.alt?.trim()) promptParts.push(part.alt.trim());
147
- return;
148
- }
149
-
150
- if (part.type === 'resource_link') {
151
- resourceRefs.push([part.title, part.name, part.description, part.uri].filter(Boolean).join('\n'));
152
- return;
153
- }
34
+ import {
35
+ antigravityOwnerToken,
36
+ claimAntigravityConversation,
37
+ releaseAntigravityOwner,
38
+ } from './native-history/antigravity-claim-registry.js';
39
+ import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages, extractFinalSummaryFromMessagesAfter, readChatMessageTimestampMs } from './chat-message-normalization.js';
40
+ import { workingDirBasename } from './working-dir.js';
41
+ import { ManualAttendanceTracker } from './manual-attendance.js';
42
+ import { buildCliStructuredInputPrompt } from './cli-provider-input-prompt.js';
43
+ import { type PersistableCliHistoryMessage, buildIncrementalHistoryAppendMessages } from './cli-provider-history-dedup.js';
44
+ import {
45
+ isIdleStatus,
46
+ getMessageTime,
47
+ hasNonEmptyCliModalButtons,
48
+ isCliGeneratingLikeStatus,
49
+ computeTurnAnchoredDurationMs,
50
+ getDatabaseSync,
51
+ getForcedNewSessionScriptName,
52
+ waitForCliAdapterReady,
53
+ } from './cli-provider-status-helpers.js';
54
+ import {
55
+ STATUS_HYDRATION_TAIL_LIMIT,
56
+ COMPLETED_FINALIZATION_RETRY_MS,
57
+ COMPLETED_FINALIZATION_MAX_WAIT_MS,
58
+ NATIVE_HISTORY_MESH_IDLE_SETTLE_MS,
59
+ USER_INPUT_ACK_DEDUP_WINDOW_MS,
60
+ STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS,
61
+ TERMINAL_MESH_EVENTS,
62
+ } from './cli-provider-instance-types.js';
63
+ import type {
64
+ CompletedDebouncePending,
65
+ CompletedFinalizationBlock,
66
+ CompletionFinalAssistantEvidence,
67
+ ExternalTranscriptProbe,
68
+ } from './cli-provider-instance-types.js';
69
+ import { mergeConversationMessages, buildExternalTranscriptProbe } from './cli-provider-transcript-merge.js';
70
+ import { getEffectDedupKey, formatApprovalRequestMessage, formatMarkerTimestamp } from './cli-provider-effect-format.js';
71
+
72
+ // Re-export moved public symbols so existing importers (index.ts, tests) keep
73
+ // their `./cli-provider-instance.js` path. Pure move — no behavior change.
74
+ export { buildCliStructuredInputPrompt } from './cli-provider-input-prompt.js';
75
+ export { buildIncrementalHistoryAppendMessages } from './cli-provider-history-dedup.js';
76
+ export {
77
+ computeTurnAnchoredDurationMs,
78
+ getForcedNewSessionScriptName,
79
+ waitForCliAdapterReady,
80
+ } from './cli-provider-status-helpers.js';
154
81
 
155
- if (part.type === 'resource') {
156
- resourceRefs.push([part.name, part.text, part.uri].filter(Boolean).join('\n'));
157
- }
158
- });
159
-
160
- // Only use textFallback when no explicit text parts were collected — it is
161
- // the flattened version of the same parts, so appending it alongside them
162
- // would duplicate the content for multipart inputs.
163
- const hasExplicitTextParts = input.parts.some((part) => part.type === 'text' && part.text.trim());
164
- if (!hasExplicitTextParts && input.textFallback.trim()) {
165
- promptParts.push(input.textFallback.trim());
166
- }
167
-
168
- const ordered = [
169
- ...imageRefs,
170
- ...promptParts,
171
- ...resourceRefs,
172
- ].filter((value, index, values) => value.trim().length > 0 && values.indexOf(value) === index);
173
-
174
- return ordered.join('\n');
175
- }
176
-
177
- function normalizePersistableCliHistoryContent(content: unknown): string {
178
- return flattenContent(content as any).replace(/\s+/g, ' ').trim();
179
- }
180
-
181
- function buildPersistableCliHistorySignature(message: PersistableCliHistoryMessage): string {
182
- return [
183
- String(message.role || ''),
184
- String(message.kind || ''),
185
- String(message.senderName || ''),
186
- normalizePersistableCliHistoryContent(message.content),
187
- ].join('|');
188
- }
189
-
190
- function hasSamePersistableCliHistoryIdentity(a: PersistableCliHistoryMessage, b: PersistableCliHistoryMessage): boolean {
191
- return String(a?.role || '') === String(b?.role || '')
192
- && String(a?.kind || '') === String(b?.kind || '')
193
- && String(a?.senderName || '') === String(b?.senderName || '')
194
- && String(a?.content || '') === String(b?.content || '');
195
- }
196
-
197
- export function buildIncrementalHistoryAppendMessages(
198
- previousMessages: PersistableCliHistoryMessage[],
199
- currentMessages: PersistableCliHistoryMessage[],
200
- ): PersistableCliHistoryMessage[] {
201
- if (!Array.isArray(currentMessages) || currentMessages.length === 0) return [];
202
- if (!Array.isArray(previousMessages) || previousMessages.length === 0) return currentMessages;
203
-
204
- const comparableLength = Math.min(previousMessages.length, currentMessages.length);
205
- let sharedPrefixLength = 0;
206
- while (
207
- sharedPrefixLength < comparableLength
208
- && hasSamePersistableCliHistoryIdentity(previousMessages[sharedPrefixLength], currentMessages[sharedPrefixLength])
209
- ) {
210
- sharedPrefixLength += 1;
211
- }
212
-
213
- if (sharedPrefixLength === currentMessages.length) return [];
214
- if (sharedPrefixLength === previousMessages.length) return currentMessages.slice(sharedPrefixLength);
215
-
216
- // Rare fallback: preserve the older whitespace-normalized behavior only when
217
- // the cheap identity check detects a changed prefix. Recomputing normalized
218
- // signatures for the full transcript on every idle status poll was a CPU
219
- // hot path for long CLI sessions.
220
- while (
221
- sharedPrefixLength < comparableLength
222
- && buildPersistableCliHistorySignature(previousMessages[sharedPrefixLength])
223
- === buildPersistableCliHistorySignature(currentMessages[sharedPrefixLength])
224
- ) {
225
- sharedPrefixLength += 1;
226
- }
227
-
228
- if (sharedPrefixLength === currentMessages.length) return [];
229
- if (sharedPrefixLength === previousMessages.length) return currentMessages.slice(sharedPrefixLength);
230
- return currentMessages;
231
- }
232
-
233
- let CachedDatabaseSync: (new (path: string, options?: { readOnly?: boolean }) => {
234
- prepare(sql: string): { get(...params: Array<string | number>): unknown };
235
- close(): void;
236
- }) | null = null;
237
-
238
- function getDatabaseSync() {
239
- if (CachedDatabaseSync) return CachedDatabaseSync;
240
- const requireFn = typeof require === 'function'
241
- ? require
242
- : createRequire(path.join(process.cwd(), '__adhdev_sqlite_loader__.js'));
243
- const sqliteModule = requireFn(`node:${'sqlite'}`) as {
244
- DatabaseSync: typeof CachedDatabaseSync;
245
- };
246
- CachedDatabaseSync = sqliteModule.DatabaseSync;
247
- if (!CachedDatabaseSync) {
248
- throw new Error('node:sqlite DatabaseSync unavailable');
249
- }
250
- return CachedDatabaseSync;
82
+ /**
83
+ * The auto-approve settle-gate identity signature: the modal's question line plus
84
+ * the NORMALIZED affirmative label, no volatile counters or raw button set. Shared
85
+ * by the fire path (maybeAutoApproveStatus) and the mask-stall nudge so both compare
86
+ * the SAME identity the settle clock tracks (AUTOAPPROVE-SETTLE-FLAP).
87
+ */
88
+ function approvalModalSignature(message: unknown, affirmativeAnchor: string): string {
89
+ return [typeof message === 'string' ? message.trim() : '', affirmativeAnchor].join('::');
251
90
  }
252
91
 
253
- export function getForcedNewSessionScriptName(
254
- provider: ProviderModule | undefined,
255
- launchMode: 'new' | 'resume' | 'manual',
256
- ): string | null {
257
- if (!provider || launchMode !== 'new') return null;
258
- const resume = provider.resume;
259
- if (!resume?.supported) return null;
260
- if (Array.isArray(resume.newSessionArgs) && resume.newSessionArgs.length > 0) return null;
261
-
262
- const controls = Array.isArray((provider as any).controls) ? (provider as any).controls : [];
263
- for (const control of controls) {
264
- if (control?.type !== 'action') continue;
265
- if (typeof control?.confirmTitle === 'string' && control.confirmTitle.trim()) continue;
266
- if (typeof control?.confirmMessage === 'string' && control.confirmMessage.trim()) continue;
267
- if (typeof control?.confirmLabel === 'string' && control.confirmLabel.trim()) continue;
268
- const invokeScript = typeof control?.invokeScript === 'string' ? control.invokeScript.trim() : '';
269
- if (!invokeScript) continue;
270
- const controlId = typeof control?.id === 'string' ? control.id.trim() : '';
271
- if (controlId === 'new_session' || /^new.?session$/i.test(invokeScript)) {
272
- return invokeScript;
273
- }
274
- }
275
-
276
- return null;
277
- }
92
+ export class CliProviderInstance implements ProviderInstance {
93
+ readonly type: string;
94
+ readonly category = 'cli' as const;
278
95
 
279
- export async function waitForCliAdapterReady(
280
- adapter: { isReady?: () => boolean; getStatus?: () => { status?: string } },
281
- options?: { timeoutMs?: number; pollMs?: number },
282
- ): Promise<void> {
283
- const timeoutMs = Math.max(100, options?.timeoutMs ?? 15_000);
284
- const pollMs = Math.max(10, options?.pollMs ?? 50);
285
- const deadline = Date.now() + timeoutMs;
96
+ /**
97
+ * Quiet period an approval modal's signature must be stable before
98
+ * auto-approve sends the approve key. Guards against firing on a prompt
99
+ * that is still streaming into the PTY (the "resolves too fast" symptom):
100
+ * while the modal text/buttons are still changing, every frame yields a
101
+ * new signature and the settle clock restarts. Once the prompt finishes
102
+ * rendering the signature holds and the key is sent after this window.
103
+ * Bounded + small so genuine approvals stay timely. The FSM is already
104
+ * authoritative over the `waiting_approval` state; this only delays the
105
+ * keystroke until the modal *content* has settled.
106
+ */
107
+ private static readonly AUTO_APPROVE_SETTLE_MS = 600;
286
108
 
287
- while (Date.now() < deadline) {
288
- if (adapter?.isReady?.()) return;
289
- const status = adapter?.getStatus?.()?.status;
290
- if (status === 'stopped') {
291
- throw new Error('CLI runtime stopped before it became ready');
292
- }
293
- await new Promise((resolve) => setTimeout(resolve, pollMs));
294
- }
109
+ /**
110
+ * Busy-side hysteresis for the settle gate. A momentary `generating` flip
111
+ * while the SAME approval modal's button block is still on screen (its
112
+ * question line scrolled out of the captured frame, only the buttons + a
113
+ * residual `esc to interrupt` spinner remain) briefly reports
114
+ * status!=waiting_approval. Without hysteresis that flip wipes the settle
115
+ * clock, and the modal→generating→modal flap restarts the 600ms window
116
+ * every time so auto-approve never fires. We keep the in-progress settle
117
+ * gate warm across an inactive blip up to this bound; only once the modal
118
+ * has genuinely stayed gone this long (a real resolution → idle) is the
119
+ * gate cleared. Bounded so a genuinely new, later approval still re-settles
120
+ * from scratch rather than firing on a stale timestamp.
121
+ */
122
+ private static readonly AUTO_APPROVE_GATE_HYSTERESIS_MS = 1500;
295
123
 
296
- throw new Error(`CLI runtime did not become ready within ${timeoutMs}ms`);
297
- }
124
+ /**
125
+ * AUTOAPPROVE-FLAP-RECUR (Fix B): extended busy-side continuity window for a
126
+ * DELEGATED-WORKER auto-approve episode that is genuinely still cycling.
127
+ *
128
+ * The default AUTO_APPROVE_GATE_HYSTERESIS_MS (1500) absorbs a *momentary*
129
+ * `generating` blip. But a delegated worker running a Bash approval observed
130
+ * the FSM cycle the FULL state waiting_approval → busy → waiting_approval on a
131
+ * 2–5s period (the button set scrolls in/out AND the modal question repaints,
132
+ * so the adapter genuinely reports status=generating for whole seconds between
133
+ * approval frames). Each busy phase outran the 1500ms hysteresis, so the
134
+ * settle clock was WIPED (the genuine-resolution branch), the 600ms settle
135
+ * window never accumulated across the flap, resolveModal never fired
136
+ * (resolveModal count 0), and the mask-stall clock instead tripped at 4500ms →
137
+ * coordinator nudge → the flap the coordinator observed.
138
+ *
139
+ * A genuine resolution and a flap both start with a busy phase; they diverge
140
+ * only in whether waiting_approval RETURNS. So we cannot simply lengthen the
141
+ * blanket hysteresis (that would make every real resolution hold the gate
142
+ * open for seconds). Instead this longer window applies ONLY while an active
143
+ * mask episode is alive (autoApproveMaskSince > 0) AND the session is a
144
+ * delegated worker — i.e. exactly the never-resolving-flap case. A foreground
145
+ * / attended session keeps the tight 1500ms window unchanged. The mask-stall
146
+ * bound below still caps the episode, so a worker whose approval truly never
147
+ * returns is surfaced to the coordinator within AUTO_APPROVE_MASK_STALL_MS
148
+ * rather than held forever.
149
+ *
150
+ * INVARIANT (do not regress the ordering): this window must fully BRIDGE a
151
+ * single busy phase, and the mask-stall bound below must in turn exceed it —
152
+ * AUTO_APPROVE_MASK_STALL_MS > AUTO_APPROVE_FLAP_CONTINUITY_MS + max_busy_phase
153
+ * + AUTO_APPROVE_SETTLE_MS. Observed flap geometry (delegated-worker Bash
154
+ * approval): approval frames last ~1.5s, busy phases (modal=none) last
155
+ * ~4.3–4.5s. With the old 4000ms this window was SHORTER than a busy phase, so
156
+ * the settle clock was torn down every cycle and never accrued 600ms while the
157
+ * 4500ms mask-stall tripped INSIDE the first busy phase → a stalled-approval
158
+ * nudge leaked to the coordinator. 6000ms bridges the ~4.5s busy phase with
159
+ * margin so the returning approval frame survives to resume its settle clock.
160
+ */
161
+ private static readonly AUTO_APPROVE_FLAP_CONTINUITY_MS = 6000;
298
162
 
299
- export class CliProviderInstance implements ProviderInstance {
300
- readonly type: string;
301
- readonly category = 'cli' as const;
163
+ /**
164
+ * STATUS-MISMATCH: upper bound on how long the auto-approve→`generating` SURFACE
165
+ * mask may hide a worker's `waiting_approval` (status + activeModal) before we give
166
+ * up and surface the real prompt. The mask exists because auto-approve is expected
167
+ * to resolve the modal momentarily; but if it STALLS without ever calling
168
+ * resolveModal — the modal signature never settles for AUTO_APPROVE_SETTLE_MS (a
169
+ * perpetually-flapping/streaming prompt), no concrete modal is ever captured, or the
170
+ * modal is a picker/non-affirmative we never auto-pick — the mask would persist
171
+ * forever and read_chat / mesh_status / the dashboard would NEVER see the pending
172
+ * approval (the coordinator cannot mesh_approve what it cannot see). Once an episode
173
+ * exceeds this bound we stop masking. Generously larger than
174
+ * AUTO_APPROVE_SETTLE_MS (600) + AUTO_APPROVE_GATE_HYSTERESIS_MS (1500) so a
175
+ * legitimately slow-settling / blip-flapping prompt is never unmasked early; a
176
+ * genuine never-resolving stall surfaces within this window. The settle gate keeps
177
+ * running underneath, so a prompt that finally stabilises still auto-approves, and
178
+ * mesh_approve (raw FSM, unmasked) works throughout.
179
+ *
180
+ * INVARIANT (do not regress): must be STRICTLY GREATER than
181
+ * AUTO_APPROVE_FLAP_CONTINUITY_MS + max_busy_phase + AUTO_APPROVE_SETTLE_MS so
182
+ * that during a flap the settle clock (which FLAP_CONTINUITY keeps alive across
183
+ * each ~4.3–4.5s busy phase) gets to accrue its 600ms on the RETURNING approval
184
+ * frame before this stall bound can trip. Observed geometry: approval ~1.5s,
185
+ * busy ~4.3–4.5s. 9000ms ≥ CONTINUITY(6000) + busy(~4.5s) + SETTLE(600) headroom;
186
+ * the old 4500ms tripped inside the very first busy phase (while modal=none, so
187
+ * the nudge was NOT deferred) and leaked to the coordinator.
188
+ */
189
+ private static readonly AUTO_APPROVE_MASK_STALL_MS = 9000;
302
190
 
303
191
  private adapter: ProviderCliAdapter;
304
192
  private context: InstanceContext | null = null;
305
193
  private events: ProviderEvent[] = [];
306
194
  private lastStatus: string = 'starting';
195
+ // Idempotency guard for the queue-claim agent:ready event. agent:ready is the
196
+ // sole signal the mesh coordinator's tryAssignQueueTask waits on to hand a
197
+ // queued task to this worker. It is emitted in two places: the boot-time
198
+ // starting→idle one-shot, and the readySeen re-arm below. This flag makes the
199
+ // event fire AT MOST ONCE per session so a worker is never claimed twice and a
200
+ // queued task is never double-dispatched/double-injected. Whichever path fires
201
+ // first sets it; the other becomes a no-op.
202
+ private agentReadyEmitted = false;
307
203
  private generatingStartedAt: number = 0;
204
+ // FALSE-IDLE continuity epoch: monotonically bumped on EVERY entry into a busy
205
+ // phase (→generating or →waiting_approval). The completedDebouncePending snapshots
206
+ // this value at arm time (busyEpochAtArm); the flush guard requires it UNCHANGED
207
+ // — proving the session did not re-enter a busy phase (a momentary busy→idle blip
208
+ // in an inter-approval valley) between arming the debounce and flushing it. A
209
+ // single point-sample of status at flush time cannot see a generating phase that
210
+ // opened AND closed within the settle window; the epoch can. See
211
+ // flushCompletedDebounceIfFinalized.
212
+ private busyEpoch: number = 0;
213
+ // GENERATING-BOUNDARY (R4b): the per-turn taskId for which a startup-grace
214
+ // started+completed pair was already synthesized. Both fast-collapse callers
215
+ // (starting→idle transition AND the idle-stayed no-status-change poll) route
216
+ // through maybeSynthesizeStartupGraceCollapse; the idle-stayed caller re-polls
217
+ // steadily while the session sits idle, so this guard makes the synthesis fire
218
+ // AT MOST ONCE per collapsed turn.
219
+ private fastCollapseSynthesizedTaskId: string | null = null;
220
+ // GENERATING-BOUNDARY (R4c): the wall-clock moment the FSM's starting→idle
221
+ // startup-grace collapse was observed (set ONCE, on the first starting→idle
222
+ // transition this boot). The idle-stayed collapse window is anchored on THIS,
223
+ // not on instance/boot time (this.startedAt): the FSM spends the full 8s
224
+ // startup-grace sitting in 'starting' before collapsing, and a turn can be
225
+ // dispatched a few seconds AFTER the collapse — measuring the window from boot
226
+ // would have it already closed by the time that turn lands+completes (the live
227
+ // R4b miss: collapse at boot+8s, dispatch at boot+12.4s > the 12s boot window).
228
+ // Anchoring on the collapse moment makes the window cover dispatch-delay+turn.
229
+ private startupGraceCollapseAt: number | null = null;
308
230
  private settings: Record<string, any> = {};
309
231
  private monitor: StatusMonitor;
310
232
  private generatingDebounceTimer: NodeJS.Timeout | null = null;
311
233
  private generatingDebouncePending: { chatTitle: string; timestamp: number } | null = null;
312
- private lastApprovalEventAt = 0;
234
+ private lastApprovalEventFingerprint = '';
313
235
  private autoApproveBusy = false;
314
236
  private autoApproveBusyTimer: NodeJS.Timeout | null = null;
237
+ private lastAutoApprovalSignature = '';
238
+ // Settle gate: the approval modal's signature + the wall-clock when this
239
+ // exact signature was first observed. Auto-approve only fires once the
240
+ // SAME signature has been stable for AUTO_APPROVE_SETTLE_MS, so a prompt
241
+ // still streaming into the PTY (its buttons/message changing frame to
242
+ // frame) keeps resetting the timer and is never approved half-rendered.
243
+ private pendingAutoApprovalSignature = '';
244
+ private pendingAutoApprovalSince = 0;
245
+ private autoApproveSettleTimer: NodeJS.Timeout | null = null;
246
+ // Wall-clock when auto-approve first observed status!=waiting_approval while
247
+ // a settle gate was in progress. Drives AUTO_APPROVE_GATE_HYSTERESIS_MS (or,
248
+ // for a delegated-worker flap episode, AUTO_APPROVE_FLAP_CONTINUITY_MS) so a
249
+ // brief generating flip does not immediately wipe the settle clock.
250
+ private autoApproveInactiveSince = 0;
251
+ // AUTOAPPROVE-FLAP-RECUR (Fix A): wall-clock when the CURRENT waiting_approval
252
+ // episode last presented a concrete, captured modal (buttons.length > 0). The
253
+ // Claude TUI momentarily reports status=waiting_approval with activeModal=null
254
+ // / an empty button block while the button block scrolls out of the captured
255
+ // frame; the raw guard below (buttons.length===0) used to bail on that frame,
256
+ // never advancing the settle gate and leaving no re-check armed — so a modal
257
+ // that flapped modal=none ↔ N-buttons around the settle boundary never
258
+ // accumulated its 600ms. This tracks the last GOOD-modal frame so a short
259
+ // scroll-out blip is absorbed (settle keeps running against the last captured
260
+ // signature) while a genuinely closed modal — buttons empty continuously past
261
+ // the continuity window — is still recognised and resets the gate.
262
+ private autoApproveLastModalSeenAt = 0;
263
+ // STATUS-MISMATCH: wall-clock when the CURRENT auto-approve episode (waiting_approval
264
+ // + shouldAutoApprove) first began wanting to mask. Unlike pendingAutoApprovalSince it
265
+ // is NOT reset when the modal signature changes (a still-streaming/flapping prompt) and
266
+ // survives the same hysteresis blips the settle gate does, so it measures the TRUE age
267
+ // of an unresolved auto-approve. Once it exceeds AUTO_APPROVE_MASK_STALL_MS the surface
268
+ // mask is dropped so the real waiting_approval surfaces. Cleared when the episode ends
269
+ // (modal genuinely gone, manual attendance takes over, or auto-approve fires).
270
+ private autoApproveMaskSince = 0;
271
+ // NOTIF-APPROVAL-MASKED (Q1b): the autoApproveMaskSince episode value for which a
272
+ // stalled-approval coordinator nudge has already been emitted, so the nudge fires
273
+ // exactly once per stalled auto-approve episode (0 = none emitted). Reusing the
274
+ // per-episode mask-clock value as the key makes it provider-agnostic (no reliance on
275
+ // approvalEntrySeq) and self-resetting: each new episode gets a fresh
276
+ // autoApproveMaskSince timestamp, and the episode-end reset zeroes it.
277
+ private stalledApprovalNudgeEpisode = 0;
278
+ // Provider-common manual-attendance signal: while a human is actively driving
279
+ // this session from the dashboard, auto-approve holds so they can take manual
280
+ // control. Background mesh workers are never attended → delegated auto-approve
281
+ // is unaffected.
282
+ private readonly manualAttendance = new ManualAttendanceTracker();
315
283
  private controlValues: Record<string, string | number | boolean> = {};
316
284
  private summaryMetadata: unknown = undefined;
317
285
  private appliedEffectKeys = new Set<string>();
318
286
  private historyWriter: ChatHistoryWriter;
319
287
  private runtimeMessages: Array<{ key: string; message: ChatMessage }> = [];
320
288
  private lastPersistedHistoryMessages: PersistableCliHistoryMessage[] = [];
289
+ private lastAcknowledgedUserInputAt = 0;
290
+ // TASKBUBBLE-DUP: per-content last-ack timestamps so the same dispatched
291
+ // prompt acked twice in quick succession (the worker buffers the first
292
+ // send during bootstrap/busy, then a redelivery — dispatch-confirm-timeout
293
+ // requeue or a reconcile re-dispatch — fires a SECOND send_chat before the
294
+ // outbound queue drains) collapses to ONE user bubble. Keyed on the trimmed
295
+ // content; an entry older than USER_INPUT_ACK_DEDUP_WINDOW_MS is treated as
296
+ // a fresh, intentional resend and is NOT suppressed.
297
+ private recentUserInputAcks = new Map<string, number>();
321
298
  private lastNativeSourceCanonicalCheckAt = 0;
322
299
  private lastNativeSourceCanonicalCacheKey: string | undefined = undefined;
323
300
  private cachedSqliteDb: {
@@ -330,6 +307,7 @@ export class CliProviderInstance implements ProviderInstance {
330
307
  private suppressIdleHistoryReplay = false;
331
308
  private errorMessage: string | undefined = undefined;
332
309
  private errorReason: ProviderErrorReason | undefined = undefined;
310
+ private activeInteractivePrompt: InteractivePrompt | null = null;
333
311
 
334
312
  private presentationMode: 'terminal' | 'chat';
335
313
  private providerSessionId?: string;
@@ -370,7 +348,10 @@ export class CliProviderInstance implements ProviderInstance {
370
348
  this.providerSessionId = options?.providerSessionId;
371
349
  this.launchMode = options?.launchMode || 'new';
372
350
  this.onProviderSessionResolved = options?.onProviderSessionResolved;
373
- this.adapter = new ProviderCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory);
351
+ this.adapter = createCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory) as ProviderCliAdapter;
352
+ if (this.providerSessionId) {
353
+ this.adapter.updateRuntimeMeta({ providerSessionId: this.providerSessionId });
354
+ }
374
355
  this.monitor = new StatusMonitor();
375
356
  this.historyWriter = new ChatHistoryWriter();
376
357
  }
@@ -389,8 +370,8 @@ export class CliProviderInstance implements ProviderInstance {
389
370
  this.adapter.updateRuntimeSettings?.(this.settings);
390
371
  this.monitor.updateConfig({
391
372
  approvalAlert: this.settings.approvalAlert !== false,
392
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
393
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
373
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
374
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
394
375
  });
395
376
 
396
377
  // Server connection
@@ -412,14 +393,14 @@ export class CliProviderInstance implements ProviderInstance {
412
393
  await this.adapter.spawn();
413
394
  await this.enforceFreshSessionLaunchIfNeeded();
414
395
  this.maybeAppendRuntimeRecoveryMessage(this.adapter.getRuntimeMetadata());
415
- if (this.providerSessionId) {
396
+ if (this.providerSessionId && this.shouldHydrateExistingProviderHistory()) {
416
397
  this.restorePersistedHistoryFromCurrentSession();
417
398
  }
418
399
  if (this.providerSessionId && this.launchMode === 'resume') {
419
400
  const resumedAt = Date.now();
420
401
  this.historyWriter.appendSystemMarker(
421
402
  this.type,
422
- `Resumed saved session at ${this.formatMarkerTimestamp(resumedAt)}`,
403
+ `Resumed saved session at ${formatMarkerTimestamp(resumedAt)}`,
423
404
  {
424
405
  instanceId: this.instanceId,
425
406
  historySessionId: this.providerSessionId,
@@ -486,14 +467,38 @@ export class CliProviderInstance implements ProviderInstance {
486
467
  }
487
468
 
488
469
  getState(): ProviderState {
470
+ // TODO(phase5-sandbox): JS override scripts (detectStatus, parseApproval,
471
+ // parseSession) are currently invoked by CliScriptRunner.invoke() via direct
472
+ // function calls — the scripts run in the daemon process with full Node.js
473
+ // access and no resource limits.
474
+ //
475
+ // When Phase 5 lands, CliScriptRunner should route these calls through a
476
+ // SandboxedScriptRunner (see providers/sdk/v1/sandbox/script-runner.ts) so
477
+ // that each call gets a fresh isolated-vm context with a 50 ms CPU limit and
478
+ // a 32 MB memory cap. The execution path to change is:
479
+ // CliScriptRunner.invoke() → SandboxedScriptRunner.run(scriptSource, context)
480
+ //
481
+ // This getState() call-site is NOT where the change goes — the wiring belongs
482
+ // in cli-script-runner.ts (CliScriptRunner.detectStatus / parseApproval /
483
+ // parseSession), with provider-loader.ts updated to store script source strings
484
+ // alongside the loaded function references for extended-legacy providers.
489
485
  const adapterStatus = this.adapter.getStatus();
486
+ if (Object.prototype.hasOwnProperty.call(adapterStatus, 'activeInteractivePrompt')) {
487
+ this.activeInteractivePrompt = adapterStatus.activeInteractivePrompt ?? null;
488
+ }
490
489
  let parsedStatus: any = null;
491
490
  let parseErrorMessage: string | undefined;
492
491
  if (typeof this.adapter.getScriptParsedStatus === 'function') {
493
492
  try {
494
493
  parsedStatus = this.adapter.getScriptParsedStatus() || null;
495
- this.errorMessage = undefined;
496
- this.errorReason = undefined;
494
+ const parsedErrorMessage = typeof parsedStatus?.errorMessage === 'string' && parsedStatus.errorMessage.trim()
495
+ ? parsedStatus.errorMessage.trim()
496
+ : undefined;
497
+ const parsedErrorReason = typeof parsedStatus?.errorReason === 'string' && parsedStatus.errorReason.trim()
498
+ ? parsedStatus.errorReason.trim() as ProviderErrorReason
499
+ : undefined;
500
+ this.errorMessage = parsedErrorMessage;
501
+ this.errorReason = parsedErrorReason;
497
502
  } catch (error: any) {
498
503
  parseErrorMessage = error?.message || String(error);
499
504
  this.errorMessage = parseErrorMessage;
@@ -503,22 +508,59 @@ export class CliProviderInstance implements ProviderInstance {
503
508
  this.errorMessage = undefined;
504
509
  this.errorReason = undefined;
505
510
  }
506
- const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, Date.now());
507
- const visibleStatus = parseErrorMessage
508
- ? 'error'
509
- : (autoApproveActive ? 'generating' : adapterStatus.status);
510
- const parsedProviderSessionId = normalizeProviderSessionId(
511
+ const adapterProviderSessionId = normalizeProviderSessionId(
511
512
  this.provider,
512
- typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
513
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
513
514
  );
514
- if (parsedProviderSessionId) {
515
- this.promoteProviderSessionId(parsedProviderSessionId);
515
+ const nowMs = Date.now();
516
+ // STATUS-MISMATCH: maybeAutoApproveStatus still runs for its side effects (settle gate,
517
+ // resolveModal fire), but the SURFACE mask is dropped once the episode has stalled past
518
+ // AUTO_APPROVE_MASK_STALL_MS — otherwise a never-settling auto-approve hides the worker's
519
+ // waiting_approval + modal from read_chat/mesh_status/dashboard forever.
520
+ const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, nowMs)
521
+ && !this.autoApproveMaskStalled(nowMs);
522
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
523
+ let visibleStatus = parseErrorMessage || parsedStatus?.status === 'error'
524
+ ? 'error'
525
+ : (autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status);
526
+ // getState() must agree with the status the FSM-driven detectStatusTransition()
527
+ // already committed to lastStatus. The adapter's own status is authoritative; we do
528
+ // not second-guess it with native-transcript shape. Only reconcile a generating-like
529
+ // read down to idle when our own lastStatus has already flipped idle (avoids a
530
+ // perpetual dashboard spinner during the brief window before the next getStatus()).
531
+ if (isCliGeneratingLikeStatus(visibleStatus) && this.lastStatus === 'idle') {
532
+ visibleStatus = 'idle';
516
533
  }
517
534
  const runtime = this.adapter.getRuntimeMetadata();
518
535
  this.maybeAppendRuntimeRecoveryMessage(runtime);
519
536
  let parsedMessages = Array.isArray(parsedStatus?.messages)
520
537
  ? parsedStatus.messages
521
538
  : [];
539
+ const parsedProviderSessionId = normalizeProviderSessionId(
540
+ this.provider,
541
+ typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
542
+ );
543
+ const suppressFreshLaunchStartupReplay = this.shouldSuppressFreshLaunchStartupReplay(
544
+ parsedMessages,
545
+ parsedStatus,
546
+ adapterStatus,
547
+ parsedProviderSessionId,
548
+ );
549
+ if (adapterProviderSessionId && !suppressFreshLaunchStartupReplay) {
550
+ this.promoteProviderSessionId(adapterProviderSessionId);
551
+ }
552
+ if (parsedProviderSessionId && !suppressFreshLaunchStartupReplay) {
553
+ this.promoteProviderSessionId(parsedProviderSessionId);
554
+ }
555
+ if (suppressFreshLaunchStartupReplay) {
556
+ parsedMessages = [];
557
+ }
558
+ // Adapter runtime metadata is transport-owned and is not guaranteed to
559
+ // identify this conversation. Spec adapters historically exposed the
560
+ // provider spec id (for example "codex-cli") as runtimeId, which made
561
+ // concurrent sessions share one activeChat identity until their native
562
+ // provider session ids were discovered.
563
+ const activeChatId = this.providerSessionId || this.instanceId;
522
564
  const historyMessageCount = Number.isFinite(parsedStatus?.historyMessageCount)
523
565
  ? Math.max(0, Number(parsedStatus.historyMessageCount))
524
566
  : null;
@@ -527,10 +569,57 @@ export class CliProviderInstance implements ProviderInstance {
527
569
  ? parsedMessages.slice(-historyMessageCount)
528
570
  : [];
529
571
  }
530
- const mergedMessages = this.mergeConversationMessages(parsedMessages);
531
- const canonicalBackedHistory = this.syncCanonicalSavedHistoryIfNeeded();
572
+ const mergedMessages = mergeConversationMessages(this.runtimeMessages, parsedMessages);
573
+ const canonicalBackedHistory = this.shouldHydrateExistingProviderHistory()
574
+ ? this.syncCanonicalSavedHistoryIfNeeded()
575
+ : false;
576
+ const statusMessages: any[] = canonicalBackedHistory && this.lastPersistedHistoryMessages.length > 0
577
+ ? this.lastPersistedHistoryMessages.map((message) => ({
578
+ role: message.role,
579
+ content: message.content,
580
+ kind: message.kind,
581
+ senderName: message.senderName,
582
+ receivedAt: message.receivedAt,
583
+ }))
584
+ : mergedMessages;
585
+
586
+ // Dashboard-tail repair (native-source providers, e.g. antigravity): the
587
+ // assistant answer lives only in native-history, so the PTY-parsed
588
+ // statusMessages end on the user prompt / auto-approve system lines and the
589
+ // snapshot's preview / lastMessageRole / completionMarker never see the
590
+ // answer — the session looks stuck on the user turn. We already cached the
591
+ // real final assistant summary at completion time (lastCompletionSummary),
592
+ // so append it as the trailing assistant bubble when the current tail has no
593
+ // assistant message at/after it. Purely additive to the status view; no
594
+ // per-tick native read, no effect on providers whose PTY carries the
595
+ // assistant (they surface it themselves and the guard below is a no-op).
596
+ const adapterOwnsMessagesElsewhereForTail = (this.adapter as any)?.chatMessagesOwnedExternally === true;
597
+ if (adapterOwnsMessagesElsewhereForTail && this.lastCompletionSummary) {
598
+ const summary = this.lastCompletionSummary;
599
+ let hasTrailingAssistant = false;
600
+ for (let i = statusMessages.length - 1; i >= 0; i -= 1) {
601
+ const m = statusMessages[i] as { role?: string; kind?: string; receivedAt?: number };
602
+ const role = typeof m?.role === 'string' ? m.role : '';
603
+ if (role === 'system') continue;
604
+ if (typeof m?.kind === 'string' && m.kind === 'tool') continue;
605
+ // First non-system/non-tool message from the tail: if it's already an
606
+ // assistant reply not older than our cached summary, the tail is fine.
607
+ hasTrailingAssistant = role === 'assistant'
608
+ && typeof m?.receivedAt === 'number'
609
+ && m.receivedAt >= summary.receivedAt - 1000;
610
+ break;
611
+ }
612
+ if (!hasTrailingAssistant) {
613
+ statusMessages.push({
614
+ role: 'assistant',
615
+ content: summary.content,
616
+ kind: 'standard',
617
+ receivedAt: summary.receivedAt,
618
+ });
619
+ }
620
+ }
532
621
 
533
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
622
+ const dirName = workingDirBasename(this.workingDir);
534
623
  const parsedChatStatus = typeof parsedStatus?.status === 'string' && parsedStatus.status.trim()
535
624
  ? parsedStatus.status.trim()
536
625
  : undefined;
@@ -542,7 +631,7 @@ export class CliProviderInstance implements ProviderInstance {
542
631
  && adapterStatus.status === 'idle'
543
632
  && parsedStatus?.status === 'idle';
544
633
  let messagesToSave = parsedMessages;
545
- if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'long_generating')) {
634
+ if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'no_progress' || parsedChatStatus === 'long_generating')) {
546
635
  const lastIdx = messagesToSave.length - 1;
547
636
  if (lastIdx >= 0 && messagesToSave[lastIdx]?.role === 'assistant') {
548
637
  messagesToSave = messagesToSave.slice(0, lastIdx);
@@ -572,33 +661,48 @@ export class CliProviderInstance implements ProviderInstance {
572
661
  }
573
662
  }
574
663
 
575
- this.applyProviderResponse(parsedStatus, { phase: 'immediate' });
664
+ this.applyProviderResponse(
665
+ suppressFreshLaunchStartupReplay && parsedStatus && typeof parsedStatus === 'object'
666
+ ? { ...parsedStatus, providerSessionId: undefined }
667
+ : parsedStatus,
668
+ { phase: 'immediate' },
669
+ );
576
670
  const surface = resolveProviderStateSurface({
577
671
  summaryMetadata: this.summaryMetadata as any,
578
672
  controlValues: this.controlValues,
579
673
  });
580
674
  const activeChatStatus = parseErrorMessage
581
675
  ? 'error'
582
- : autoApproveActive && parsedStatus?.status === 'waiting_approval'
676
+ : (autoApproveActive && parsedStatus?.status === 'waiting_approval') || autoApproveHoldIdle
583
677
  ? 'generating'
584
678
  : (adapterStatus.status !== 'idle'
585
679
  ? visibleStatus
586
680
  : (suppressStaleParsedBusyStatus ? visibleStatus : (parsedChatStatus || visibleStatus)));
587
681
 
682
+ // If an AskUserQuestion prompt is awaiting user input, overlay status as
683
+ // waiting_choice. This is distinct from waiting_approval (tool-use consent)
684
+ // — the engine's isWaitingForResponse state is unchanged, so completion
685
+ // tracking continues normally once the user responds.
686
+ const hasInteractivePrompt = !!this.activeInteractivePrompt;
687
+ const finalStatus = hasInteractivePrompt ? 'waiting_choice' : visibleStatus;
688
+ const finalChatStatus = hasInteractivePrompt ? 'waiting_choice' : activeChatStatus;
689
+
588
690
  return {
589
691
  type: this.type,
590
692
  name: this.provider.name,
591
693
  category: 'cli',
592
- status: visibleStatus,
694
+ status: finalStatus,
593
695
  mode: this.presentationMode,
594
696
  activeChat: {
595
- id: `${this.type}_${this.workingDir}`,
697
+ id: activeChatId,
596
698
  title: parsedStatus?.title || dirName,
597
- status: activeChatStatus,
598
- messages: mergedMessages,
599
- activeModal: autoApproveActive ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
699
+ status: finalChatStatus,
700
+ messages: statusMessages,
701
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
702
+ activeInteractivePrompt: this.activeInteractivePrompt,
600
703
  inputContent: '',
601
704
  },
705
+ activeInteractivePrompt: this.activeInteractivePrompt,
602
706
  workspace: this.workingDir,
603
707
  instanceId: this.instanceId,
604
708
  providerSessionId: this.providerSessionId,
@@ -638,8 +742,12 @@ export class CliProviderInstance implements ProviderInstance {
638
742
 
639
743
  getHotChatSessionState(): HotChatSessionState {
640
744
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
641
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
642
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
745
+ const nowMs = Date.now();
746
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
747
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
748
+ && !this.autoApproveMaskStalled(nowMs);
749
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
750
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
643
751
  const runtime = this.adapter.getRuntimeMetadata();
644
752
  return {
645
753
  id: this.instanceId,
@@ -651,36 +759,274 @@ export class CliProviderInstance implements ProviderInstance {
651
759
  };
652
760
  }
653
761
 
654
- getSessionModalState(): SessionModalState {
655
- const adapterStatus = this.adapter.getStatus({ allowParse: false });
656
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
657
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
658
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
762
+ getSessionModalState(sessionId?: string): SessionModalState {
763
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
764
+ const nowMs = Date.now();
765
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
766
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
767
+ && !this.autoApproveMaskStalled(nowMs);
768
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
769
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
770
+ const dirName = workingDirBasename(this.workingDir);
659
771
  return {
660
- id: this.instanceId,
772
+ // Honor the caller-supplied sessionId — InstanceMgr rejects the
773
+ // projection when projected.id !== requested sessionId, and
774
+ // this.instanceId is the manager's internal key, not the public
775
+ // sessionId the dashboard subscribes by.
776
+ id: sessionId ?? this.instanceId,
661
777
  status: visibleStatus,
662
778
  title: dirName,
663
- activeModal: autoApproveActive ? null : adapterStatus.activeModal,
779
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : adapterStatus.activeModal,
664
780
  };
665
781
  }
666
782
 
667
783
  updateSettings(newSettings: Record<string, any>): void {
668
- this.settings = { ...newSettings };
784
+ // Merge semantics: a key omitted from newSettings preserves its existing
785
+ // value, a key present in newSettings (even as false) overrides it.
786
+ //
787
+ // This is required because updateSettings has two callers with opposite
788
+ // intent:
789
+ // 1. Full re-injection — the dashboard toggle path (handleSetProviderSetting
790
+ // → getSettings → updateInstanceSettings) sends the COMPLETE settings
791
+ // object, so an explicit autoApprove:false must win.
792
+ // 2. Partial stamp — the mesh relay-safety stamp (router.ts agent_command,
793
+ // buildMeshWorkerRelayStamp) sends ONLY {meshNodeFor, meshNodeId,
794
+ // meshCoordinatorDaemonId, launchedByCoordinator} on every coordinator
795
+ // re-dispatch. It carries no autoApprove, so a full replacement would
796
+ // wipe the launch-time autoApprove:true the worker was started with,
797
+ // silently dropping every later approval to a manual gate until the
798
+ // machine-page toggle re-injected the full settings.
799
+ //
800
+ // A plain merge satisfies both: undefined keys fall through to the existing
801
+ // value (preserving launch-stamp settings like autoApprove + the mesh routing
802
+ // keys), explicit keys override. This subsumes the previous mesh-key preserve
803
+ // list, which only protected the routing keys and not autoApprove.
804
+ this.settings = { ...this.settings, ...newSettings };
669
805
  this.adapter.updateRuntimeSettings?.(this.settings);
670
806
  this.monitor.updateConfig({
671
807
  approvalAlert: this.settings.approvalAlert !== false,
672
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
673
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
808
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
809
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
674
810
  });
675
811
  }
676
812
 
813
+ /**
814
+ * Stamp a direct-dispatch mesh assignment on this instance.
815
+ * setupMeshEventForwarding reads settings.meshNodeFor + meshActiveTaskId to
816
+ * route generating_completed back to the originating coordinator. Without
817
+ * this stamp, mesh_send_task --direct targets a plain CLI session whose
818
+ * completion events silently drop because the forwarder has nothing to
819
+ * match against.
820
+ */
821
+ attachMeshAssignment(assignment: { meshId: string; nodeId?: string; taskId?: string; coordinatorDaemonId?: string; coordinatorSessionId?: string }): void {
822
+ if (!assignment?.meshId) return;
823
+ this.settings = {
824
+ ...this.settings,
825
+ meshNodeFor: assignment.meshId,
826
+ // WTCLAIM (A): track the bound node id under BOTH the active marker
827
+ // (meshNodeId, cleared on detach) and a sticky marker (meshLastNodeId,
828
+ // preserved across detach). The sticky marker lets a detached but still
829
+ // coordinator-owned session be re-picked ONLY for the SAME node it served
830
+ // — never auto-adopted for a sibling node (e.g. a cloned worktree) that
831
+ // shares this daemon. See isMeshOwnedDelegateSession's post-detach gate.
832
+ ...(assignment.nodeId ? { meshNodeId: assignment.nodeId, meshLastNodeId: assignment.nodeId } : {}),
833
+ ...(assignment.taskId ? { meshActiveTaskId: assignment.taskId } : {}),
834
+ ...(assignment.coordinatorDaemonId ? { meshCoordinatorDaemonId: assignment.coordinatorDaemonId } : {}),
835
+ // Session-level routing anchor: the originating coordinator session, so this
836
+ // worker's completion events route back to the exact session that dispatched it.
837
+ ...(assignment.coordinatorSessionId ? { meshCoordinatorSessionId: assignment.coordinatorSessionId } : {}),
838
+ };
839
+ this.adapter.updateRuntimeSettings?.(this.settings);
840
+ }
841
+
842
+ /**
843
+ * Clear a previously-attached mesh assignment after the task reaches a
844
+ * terminal state. Leaving meshNodeFor pinned would route this session's
845
+ * subsequent unrelated turns (e.g. ad-hoc dashboard chats) to the
846
+ * coordinator as if they were task completions.
847
+ *
848
+ * MESHID-DROP-ON-DETACH (Fix C): a coordinator-LAUNCHED worker session
849
+ * (launchedByCoordinator) holds its mesh membership (meshNodeFor / meshNodeId /
850
+ * meshCoordinatorDaemonId) at the SESSION level — set once at launch
851
+ * (mesh_launch_session / queue auto-launch), independent of any single task.
852
+ * The original detach wiped meshNodeFor + meshNodeId together with the
853
+ * task-level meshActiveTaskId, so the FIRST task completion stripped the
854
+ * membership and EVERY subsequent completion forwarded with meshId absent —
855
+ * resolveWorkerDelegateRouting fell to mesh_unresolved and the coordinator
856
+ * rejected the forward "meshId required". For a launched member we therefore
857
+ * clear ONLY the task-level marker (meshActiveTaskId) and preserve the
858
+ * session-level membership so its next task's completion still resolves.
859
+ * A task-less ad-hoc turn on a preserved-membership session is NOT misrouted:
860
+ * its completion carries no taskId and the session holds no active assignment,
861
+ * so the forwarder's WARMUPGAP guard skips the dispatch-row flip (it only
862
+ * injects a benign task-less notification). A NON-launched session (a plain CLI
863
+ * session adopted by mesh_send_task --direct, launchedByCoordinator falsy)
864
+ * keeps the original full clear so an ad-hoc session is never left pinned.
865
+ */
866
+ detachMeshAssignment(): void {
867
+ if (!this.settings.meshNodeFor && !this.settings.meshActiveTaskId && !this.settings.meshNodeId) return;
868
+ // Session-level member: keep membership, drop only the task-level marker.
869
+ if (this.settings.launchedByCoordinator === true) {
870
+ if (!this.settings.meshActiveTaskId) return;
871
+ const { meshActiveTaskId, ...rest } = this.settings;
872
+ void meshActiveTaskId;
873
+ this.settings = rest;
874
+ this.adapter.updateRuntimeSettings?.(this.settings);
875
+ return;
876
+ }
877
+ const { meshNodeFor, meshNodeId, meshActiveTaskId, ...rest } = this.settings;
878
+ void meshNodeFor; void meshActiveTaskId;
879
+ // WTCLAIM (A): clear the active binding but PRESERVE the last bound node id
880
+ // (meshLastNodeId) so a later sessionless dispatch can re-adopt this idle
881
+ // session ONLY for the node it last served. Carry the id being cleared, or
882
+ // keep an already-present sticky marker if meshNodeId was absent.
883
+ const lastNodeId = (typeof meshNodeId === 'string' && meshNodeId.trim())
884
+ ? meshNodeId.trim()
885
+ : (typeof rest.meshLastNodeId === 'string' && rest.meshLastNodeId.trim() ? rest.meshLastNodeId.trim() : undefined);
886
+ this.settings = lastNodeId ? { ...rest, meshLastNodeId: lastNodeId } : rest;
887
+ this.adapter.updateRuntimeSettings?.(this.settings);
888
+ }
889
+
890
+ /**
891
+ * The resolved modal-park status of this session, or null when it is not
892
+ * parked on a modal awaiting a human answer. Mirrors the overlay logic in
893
+ * getState(): an active AskUserQuestion interactive prompt resolves to
894
+ * waiting_choice; otherwise the adapter's waiting_approval (tool consent)
895
+ * counts — UNLESS auto-approve will dismiss it, in which case the session is
896
+ * effectively generating and is NOT modal-parked. This is the single signal
897
+ * the mesh force-inject guard consults, and the same status string the
898
+ * reconcile loop reads off get_status_metadata. Lowercase literals only —
899
+ * the SessionStatus enum is forked across modules and waiting_choice is
900
+ * absent from some of them.
901
+ */
902
+ resolveModalParkStatus(): 'waiting_choice' | 'waiting_approval' | null {
903
+ if (this.activeInteractivePrompt) return 'waiting_choice';
904
+ let adapterStatus: { status?: string };
905
+ try {
906
+ adapterStatus = this.adapter.getStatus({ allowParse: false });
907
+ } catch {
908
+ return null;
909
+ }
910
+ // A session whose auto-approve is held by manual attendance IS parked on a
911
+ // modal awaiting the human — autoApproveEffectivelyActive folds that in, so
912
+ // the mesh force-inject guard correctly treats it as modal-parked. STATUS-MISMATCH:
913
+ // a STALLED auto-approve (never resolving) is likewise effectively parked — treat it
914
+ // as modal-parked so its events are held/surfaced rather than masked behind generating.
915
+ if (adapterStatus.status === 'waiting_approval'
916
+ && (!this.autoApproveEffectivelyActive(adapterStatus.status) || this.autoApproveMaskStalled())) {
917
+ // NOTIF-HELD-DRAIN (Fix 1): an autonomous mesh session (coordinator or worker)
918
+ // that is actively progressing a turn — a tool call is in flight
919
+ // (hasAdapterPendingResponse) and NO human is attending it by hand — surfaces a
920
+ // routine tool-consent `waiting_approval` on EVERY tool call when auto-approve is
921
+ // off. That transient consent is part of the turn the harness/operator drives to
922
+ // completion, NOT a session genuinely wedged awaiting a human's modal answer.
923
+ // Classifying it modal-parked makes findLiveCoordinators hold the mesh's pending
924
+ // completion events under `modal_parked` across a busy coordinator's whole work
925
+ // batch, which is the multi-minute notification stall. Treat such a transient
926
+ // consent as NOT modal-parked so it is held as ordinary "generating" (released on
927
+ // the next idle) instead. A manually-attended session, a stalled auto-approve, or a
928
+ // non-progressing session (no turn in flight) still parks — those are the genuine
929
+ // human-await cases the guard must keep holding.
930
+ if (this.isTransientToolConsent()) {
931
+ return null;
932
+ }
933
+ return 'waiting_approval';
934
+ }
935
+ return null;
936
+ }
937
+
938
+ /**
939
+ * NOTIF-HELD-DRAIN: true when this `waiting_approval` is a routine, transient tool-consent
940
+ * of an autonomously-progressing mesh session rather than a genuine human-await modal —
941
+ * i.e. it is a mesh coordinator/worker session, a turn is actively in flight
942
+ * (hasAdapterPendingResponse), and no human is attending it by hand. Such a consent is
943
+ * driven to resolution by the harness/operator as part of the in-flight turn, so holding
944
+ * the mesh's completion events behind it (modal_parked) is the false-positive that stalls
945
+ * delivery. Narrow by design: manual attendance or a non-progressing session falls through
946
+ * to the genuine-modal classification.
947
+ */
948
+ private isTransientToolConsent(now = Date.now()): boolean {
949
+ return this.isAutonomousMeshSession()
950
+ && this.hasAdapterPendingResponse()
951
+ && !this.manualAttendance.isAttended(now);
952
+ }
953
+
954
+ /** True when this session is parked on a modal awaiting a human answer. */
955
+ isModalParked(): boolean {
956
+ return this.resolveModalParkStatus() !== null;
957
+ }
958
+
959
+ /**
960
+ * PTY-OVERTRUST-DRAIN (Defect B). The deliverability/drain status the mesh
961
+ * reconcile loop must consult — the RAW adapter turn-state, with the
962
+ * auto-approve "hold-idle" visual mask STRIPPED.
963
+ *
964
+ * getState().status overlays `autoApproveHoldIdle`/`autoApproveActive` to paint a
965
+ * genuinely-idle adapter as `generating` (a UI-flicker suppression while an
966
+ * auto-approve key-press settles — see getState() ~:800). That mask is correct
967
+ * for the dashboard, but the reconcile loop trusts it as "the coordinator is
968
+ * busy" and therefore HOLDS a worker's completion under
969
+ * `generating_no_idle_coordinator` even though the coordinator's PTY is at a real
970
+ * turn end and would accept the inject as a turn — the completion is stranded.
971
+ *
972
+ * This accessor reports the drain truth instead:
973
+ * - 'modal_parked' — a GENUINE human-await modal (AskUserQuestion / a non-
974
+ * transient tool-consent). Still excluded from drain (a force-inject here
975
+ * writes raw keystrokes the modal eats → data corruption). Mirrors
976
+ * isModalParked(), evaluated first so a parked session never reads idle.
977
+ * - 'idle' — the RAW adapter is at a turn end (adapter.getStatus(allowParse:false)
978
+ * === 'idle') and the session is not modal-parked. Drain-eligible REGARDLESS
979
+ * of the auto-approve mask. This is the case the mask used to hide.
980
+ * - 'generating' — the raw adapter is genuinely mid-turn. Held (a raw PTY write
981
+ * into a generating claude-cli is not consumed as a turn → data loss). The
982
+ * intentional removal of force-inject-into-generating is preserved.
983
+ * - 'other' — any other raw status (error / starting / waiting_choice handled by
984
+ * modal-park above). Not a drain target.
985
+ *
986
+ * Uses allowParse:false (engine.activeModal only, side-effect-free) so it never
987
+ * mutates the very auto-approve mask state the diagnostics read.
988
+ */
989
+ getDrainStatus(): 'idle' | 'generating' | 'modal_parked' | 'other' {
990
+ if (this.isModalParked()) return 'modal_parked';
991
+ let rawStatus: string;
992
+ try {
993
+ const raw = this.adapter.getStatus({ allowParse: false })?.status;
994
+ rawStatus = typeof raw === 'string' ? raw.trim() : '';
995
+ } catch {
996
+ return 'other';
997
+ }
998
+ if (rawStatus === 'idle') return 'idle';
999
+ if (isCliGeneratingLikeStatus(rawStatus)) return 'generating';
1000
+ return 'other';
1001
+ }
1002
+
677
1003
  onEvent(event: string, data?: any): void {
678
1004
  if (event === 'send_message') {
679
1005
  const input = normalizeInputEnvelope(data);
680
1006
  assertProviderSupportsDeclaredInput(this.provider, input);
681
1007
  const promptText = buildCliStructuredInputPrompt(input);
682
1008
  if (promptText) {
683
- void this.adapter.sendMessage(promptText).catch((e: any) => {
1009
+ // force:true bypasses the busy/generating send guard so terminal mesh
1010
+ // events (completion/failure/bootstrap) land in a coordinator session that
1011
+ // is itself parked in `generating` while awaiting that very event.
1012
+ // Without it the message is queued and only flushed on the coordinator's
1013
+ // own idle transition — which never happens until it receives the message.
1014
+ const force = data?.force === true;
1015
+ // Modal guard: a force-inject still writes raw keystrokes into the PTY,
1016
+ // bypassing the busy send-guard. If the coordinator is parked on a
1017
+ // harness modal (claude-cli AskUserQuestion → waiting_choice, or a
1018
+ // tool-consent waiting_approval), those keystrokes are consumed by the
1019
+ // modal's key handler and silently select a choice the user never made
1020
+ // (data corruption). Hold the force-inject in that narrow window —
1021
+ // the event stays queued and the reconcile loop redelivers it on the
1022
+ // next tick once the modal is resolved. We ONLY hold for the two modal
1023
+ // states; generating is still force-injected (that is the deadlock the
1024
+ // force path exists to break — see mesh-events-coordinator).
1025
+ if (force && this.isModalParked()) {
1026
+ LOG.info('CLI', `[${this.type}] force send_message held — coordinator parked on modal (${this.resolveModalParkStatus()})`);
1027
+ return;
1028
+ }
1029
+ void this.adapter.sendMessage(promptText, force ? { force: true } : {}).catch((e: any) => {
684
1030
  LOG.warn('CLI', `[${this.type}] send_message failed: ${e?.message || e}`);
685
1031
  });
686
1032
  }
@@ -690,14 +1036,130 @@ export class CliProviderInstance implements ProviderInstance {
690
1036
  void this.adapter.resolveAction(data).catch((e: any) => {
691
1037
  LOG.warn('CLI', `[${this.type}] resolve_action failed: ${e?.message || e}`);
692
1038
  });
1039
+ } else if (event === 'interactive_prompt' && data) {
1040
+ const prompt = normalizeInteractivePrompt(data);
1041
+ if (prompt) {
1042
+ this.activeInteractivePrompt = prompt;
1043
+ this.events.push({
1044
+ event: 'interactive_prompt',
1045
+ timestamp: Date.now(),
1046
+ promptId: prompt.promptId,
1047
+ });
1048
+ }
1049
+ } else if (event === 'interactive_prompt_response' && data) {
1050
+ try {
1051
+ const response = normalizeInteractivePromptResponse(data);
1052
+ if (this.activeInteractivePrompt?.promptId === response.promptId) {
1053
+ this.activeInteractivePrompt = null;
1054
+ }
1055
+ if (typeof this.adapter.setInteractivePromptResponse !== 'function') {
1056
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response ignored: adapter does not support interactive prompts`);
1057
+ return;
1058
+ }
1059
+ void this.adapter.setInteractivePromptResponse(response).catch((e: any) => {
1060
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response failed: ${e?.message || e}`);
1061
+ });
1062
+ } catch (e: any) {
1063
+ LOG.warn('CLI', `[${this.type}] invalid interactive_prompt_response: ${e?.message || e}`);
1064
+ }
693
1065
  } else if (event === 'provider_state_patch' && data && typeof data === 'object') {
694
1066
  this.applyProviderResponse(data, { phase: 'immediate' });
695
1067
  }
696
1068
  }
697
1069
 
1070
+ recordAcknowledgedUserInput(input: InputEnvelope | string): void {
1071
+ const content = typeof input === 'string'
1072
+ ? input.trim()
1073
+ : buildCliStructuredInputPrompt(input).trim();
1074
+ if (!content) return;
1075
+
1076
+ const receivedAt = Date.now();
1077
+
1078
+ // TASKBUBBLE-DUP: collapse a redelivered dispatch to one bubble. A single
1079
+ // mesh_send_task can reach this instance as TWO send_chat calls when the
1080
+ // first injection is buffered during bootstrap/busy and a retry (dispatch-
1081
+ // confirm-timeout requeue, or a reconcile re-dispatch) fires before the
1082
+ // outbound queue drains. The previous dedupKey hashed receivedAt, so the
1083
+ // two acks produced different keys and BOTH bubbled. Suppress an identical
1084
+ // content ack seen within USER_INPUT_ACK_DEDUP_WINDOW_MS; a later resend of
1085
+ // the same text (beyond the window) is a genuine new turn and still shows.
1086
+ const ackContentKey = shortHash(`${this.instanceId}:${content}`, 24);
1087
+ const lastAckAt = this.recentUserInputAcks.get(ackContentKey);
1088
+ if (lastAckAt !== undefined && receivedAt - lastAckAt <= USER_INPUT_ACK_DEDUP_WINDOW_MS) {
1089
+ // Refresh the timestamp so a steady stream of redeliveries keeps
1090
+ // collapsing, and prune stale entries to bound the map size.
1091
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1092
+ this.pruneRecentUserInputAcks(receivedAt);
1093
+ return;
1094
+ }
1095
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1096
+ this.pruneRecentUserInputAcks(receivedAt);
1097
+
1098
+ this.lastAcknowledgedUserInputAt = receivedAt;
1099
+ // The runtimeMessages dedupKey stays per-call unique (includes receivedAt)
1100
+ // so a genuine resend of the same text after the window appends a fresh
1101
+ // bubble; redelivery within the window is already suppressed above.
1102
+ const dedupKey = `user_input_ack:${shortHash(`${this.instanceId}:${content}:${receivedAt}`, 24)}`;
1103
+ this.appendRuntimeMessage(buildChatMessage({
1104
+ role: 'user',
1105
+ senderName: 'User',
1106
+ kind: 'standard',
1107
+ content,
1108
+ receivedAt,
1109
+ timestamp: receivedAt,
1110
+ source: 'runtime_input_ack',
1111
+ meta: {
1112
+ runtimeInputAck: true,
1113
+ provider: this.type,
1114
+ workspace: this.workingDir,
1115
+ },
1116
+ } as ChatMessage), dedupKey);
1117
+ }
1118
+
1119
+ /** Drop user-input ack entries older than the dedup window so the map can't grow unbounded. */
1120
+ private pruneRecentUserInputAcks(now: number): void {
1121
+ if (this.recentUserInputAcks.size <= 1) return;
1122
+ for (const [key, at] of this.recentUserInputAcks) {
1123
+ if (now - at > USER_INPUT_ACK_DEDUP_WINDOW_MS) this.recentUserInputAcks.delete(key);
1124
+ }
1125
+ }
1126
+
1127
+ /**
1128
+ * Owner token for this session in the antigravity conversation-claim
1129
+ * registry. Keyed on the daemon instance id — the SAME value the session
1130
+ * registry stores as this session's `sessionId` (see cli-manager
1131
+ * `sessionRegistry.register({ sessionId: cliInstance.instanceId })`) and the
1132
+ * read side hands the dispatcher as `instanceId`. Both sides therefore
1133
+ * derive the identical `iid:<instanceId>` token, so the claims the
1134
+ * dispatcher records under this session are exactly the ones dispose()
1135
+ * releases.
1136
+ *
1137
+ * This must NOT be derived from a spawn timestamp: the instance's
1138
+ * `startedAt`, the adapter's `spawnedAtMs`, and the session registry's
1139
+ * `spawnedAtMs` are three INDEPENDENT `Date.now()` samples for the one
1140
+ * session, so a workspace+spawn-time token computed here would never equal
1141
+ * the read side's — the claim isolation then silently collapses and two
1142
+ * concurrent antigravity sessions cross-bind each other's conversation .db
1143
+ * (coordinator+worker chat crosswire).
1144
+ */
1145
+ private antigravityClaimOwner(): string {
1146
+ return antigravityOwnerToken(this.workingDir, this.startedAt, this.instanceId);
1147
+ }
1148
+
698
1149
  dispose(): void {
1150
+ // Release this session's antigravity conversation claims so the store
1151
+ // becomes available again (e.g. a later resume) and the registry doesn't
1152
+ // leak entries for dead sessions.
1153
+ if (this.type === 'antigravity-cli') {
1154
+ const owner = this.antigravityClaimOwner();
1155
+ if (owner) releaseAntigravityOwner(owner);
1156
+ }
699
1157
  this.adapter.shutdown();
700
1158
  this.monitor.reset();
1159
+ // Cancel any armed auto-approve timers so a pending settle re-check
1160
+ // can't fire resolveModal/detectStatusTransition against a dead adapter.
1161
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
1162
+ if (this.autoApproveBusyTimer) { clearTimeout(this.autoApproveBusyTimer); this.autoApproveBusyTimer = null; }
701
1163
  this.appliedEffectKeys.clear();
702
1164
  try { this.cachedSqliteDb?.close(); } catch { /* noop */ }
703
1165
  this.cachedSqliteDb = null;
@@ -706,6 +1168,19 @@ export class CliProviderInstance implements ProviderInstance {
706
1168
 
707
1169
  private completedDebounceTimer: NodeJS.Timeout | null = null;
708
1170
  private completedDebouncePending: CompletedDebouncePending | null = null;
1171
+ private lastExternalCompletionProbe: ExternalTranscriptProbe | null = null;
1172
+ /**
1173
+ * The final assistant summary of the last completed turn, cached at
1174
+ * completion-emit time. For a native-source provider (antigravity) whose
1175
+ * assistant answer lives only in native-history — never in the PTY parse that
1176
+ * feeds activeChat.messages — the dashboard's preview / lastMessageRole /
1177
+ * completionMarker would otherwise never see the answer and show the session
1178
+ * stuck on the user prompt. getState() appends this cached assistant bubble to
1179
+ * the status messages when the PTY tail has none, so those fields reflect the
1180
+ * real last answer with ZERO per-tick native reads (the native read already ran
1181
+ * once at completion). Reset on the next turn's start.
1182
+ */
1183
+ private lastCompletionSummary: { content: string; receivedAt: number } | null = null;
709
1184
 
710
1185
  private async enforceFreshSessionLaunchIfNeeded(): Promise<void> {
711
1186
  const scriptName = getForcedNewSessionScriptName(this.provider, this.launchMode);
@@ -734,13 +1209,314 @@ export class CliProviderInstance implements ProviderInstance {
734
1209
  this.applyProviderResponse(parsed.payload, { phase: 'immediate' });
735
1210
  }
736
1211
 
737
- private completionHasFinalAssistantMessage(messages: unknown): boolean {
1212
+ private completionHasFinalAssistantMessage(messages: unknown, turnStartedAt?: number): boolean {
738
1213
  const visibleMessages = (Array.isArray(messages) ? messages : [])
739
1214
  .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
740
1215
  const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
741
1216
  const role = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : '';
742
1217
  const content = lastVisible ? flattenContent(lastVisible.content).trim() : '';
743
- return role === 'assistant' && !!content;
1218
+ if (role !== 'assistant' || !content) return false;
1219
+ // Guard: if the last assistant message looks like an active approval/input prompt,
1220
+ // it is not a real completion — the session is still awaiting user input.
1221
+ if (looksLikeActiveApprovalPromptText(content)) return false;
1222
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): when a producing-turn start is
1223
+ // known, the final assistant bubble must POST-DATE it. A STALE mid-turn assistant
1224
+ // (predating this turn's start — e.g. the last bubble of a prior sub-turn observed
1225
+ // during an inter-approval valley) must NOT satisfy the finalization gate, or a
1226
+ // false-idle blip emits a completion carrying that stale summary. A bubble with no
1227
+ // parseable timestamp cannot be proven stale, so it is kept (fails open — behaviour
1228
+ // identical to before for providers/paths that carry no timestamps).
1229
+ if (typeof turnStartedAt === 'number' && Number.isFinite(turnStartedAt) && turnStartedAt > 0) {
1230
+ // readChatMessageTimestampMs mirrors the summary turn-scoping reader
1231
+ // (extractFinalSummaryFromMessagesAfter) — same seconds-vs-ms heuristic and
1232
+ // field precedence — so the present-check and the summary-scope agree on which
1233
+ // bubbles predate the turn.
1234
+ const ts = readChatMessageTimestampMs(lastVisible);
1235
+ if (typeof ts === 'number' && ts < turnStartedAt) return false;
1236
+ }
1237
+ return true;
1238
+ }
1239
+
1240
+ private recordPendingTranscriptProbe(pending: CompletedDebouncePending): ExternalTranscriptProbe | null {
1241
+ const probe = this.lastExternalCompletionProbe;
1242
+ if (!probe) return null;
1243
+ const history = pending.transcriptProbeHistory || [];
1244
+ const last = history[history.length - 1];
1245
+ if (!last || last.readAt !== probe.readAt || last.msgCount !== probe.msgCount || last.lastRole !== probe.lastRole || last.contentLen !== probe.contentLen) {
1246
+ history.push(probe);
1247
+ pending.transcriptProbeHistory = history.slice(-5);
1248
+ }
1249
+ return probe;
1250
+ }
1251
+
1252
+ /**
1253
+ * The spawned CLI's env overrides (e.g. the mesh coordinator points hermes
1254
+ * at a per-coordinator HERMES_HOME so its state.db lives in a tmpdir instead
1255
+ * of ~/.hermes). The native-history executor expands `${HERMES_HOME:-~/.hermes}`
1256
+ * from this map, so the completion gate MUST pass it through — otherwise the
1257
+ * gate reads ~/.hermes, finds no coordinator-session transcript, and
1258
+ * false-fires missing_final_assistant on every coordinator turn.
1259
+ */
1260
+ private spawnedEnvOverrides(): Record<string, string> | undefined {
1261
+ const meta = typeof (this.adapter as any)?.getRuntimeMetadata === 'function'
1262
+ ? (this.adapter as any).getRuntimeMetadata()
1263
+ : undefined;
1264
+ const env = meta && typeof meta === 'object' ? (meta as Record<string, unknown>).spawnedEnv : undefined;
1265
+ return env && typeof env === 'object' ? env as Record<string, string> : undefined;
1266
+ }
1267
+
1268
+ private readExternalCompletionMessages(): unknown[] | null {
1269
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1270
+ if (!adapterOwnsMessagesElsewhere) return null;
1271
+ if (!isNativeSourceCanonicalHistory(this.provider.nativeHistory)) return null;
1272
+
1273
+ // Resolve a CONCRETE native-history handle for this session's OWN
1274
+ // conversation. A provider that exposes its session id on the CLI
1275
+ // (codex/claude/hermes) sets this.providerSessionId. antigravity takes no
1276
+ // --session-id, so this.providerSessionId stays empty — recover the real
1277
+ // on-disk conversation id from the read pin persisted across restart
1278
+ // (state.json sessionProviderSessionPins, keyed by this session's
1279
+ // instanceId — the same map a binding read_chat / mesh_read_chat records
1280
+ // the resolved uuid into). The OLD `if (!this.providerSessionId) return
1281
+ // null` guard blocked antigravity's completion transcript entirely, so its
1282
+ // final-assistant evidence was permanently 'unavailable' and the turn
1283
+ // completion never emitted → the mesh reconcile loop reclaimed the
1284
+ // "delivered but no completion" task and re-dispatched the same MAGI prompt
1285
+ // (ANTIGRAVITY-FINAL-MESSAGE-TAIL-GAP, completion side).
1286
+ //
1287
+ // Prefer a concrete handle (providerSessionId, else the persisted pin). When
1288
+ // neither exists yet — a fresh antigravity turn whose conversation has not
1289
+ // been bound by any read_chat — fall through with an EMPTY handle and let the
1290
+ // dispatcher resolve this session's own conversations/<uuid>.db by the
1291
+ // spawn-floor + workspace + instanceId claim. This is safe now that the
1292
+ // claim owner token is single-form iid:<instanceId> (never collapses to '')
1293
+ // and pickUnboundConversationDb picks the oldest store born at/after THIS
1294
+ // session's floor: the probe resolves the session's OWN db under its own
1295
+ // owner token, so it can never steal a sibling's conversation (the earlier
1296
+ // theft required a floor=0 / owner='' collapse that no longer happens). It
1297
+ // means the completion summary is available on the FIRST completion — before
1298
+ // any read_chat has recorded a pin — which the dashboard tail-repair needs.
1299
+ let resolvedHandle = this.providerSessionId || '';
1300
+ if (!resolvedHandle) {
1301
+ try {
1302
+ const pinned = loadPersistedProviderSessionPins()[this.instanceId];
1303
+ if (typeof pinned === 'string' && pinned.trim()) resolvedHandle = pinned.trim();
1304
+ } catch { /* best-effort pin hydration */ }
1305
+ }
1306
+
1307
+ if (this.lastExternalCompletionProbe?.sourcePath) {
1308
+ try { fs.statSync(this.lastExternalCompletionProbe.sourcePath); } catch { /* best-effort metadata refresh */ }
1309
+ }
1310
+ const restoredHistory = readProviderChatHistory(this.type, {
1311
+ canonicalHistory: this.provider.nativeHistory,
1312
+ historySessionId: resolvedHandle || undefined,
1313
+ workspace: this.workingDir,
1314
+ offset: 0,
1315
+ limit: Number.MAX_SAFE_INTEGER,
1316
+ historyBehavior: this.provider.historyBehavior,
1317
+ scripts: this.provider.scripts as any,
1318
+ sessionStartedAtMs: this.startedAt,
1319
+ // The claim owner token must match read_chat's so the exact-bind on our
1320
+ // own conversation stays idempotent rather than looking foreign, and so
1321
+ // the floor-based resolution above claims THIS session's db under its
1322
+ // own owner (never a sibling's).
1323
+ instanceId: this.instanceId,
1324
+ envOverrides: this.spawnedEnvOverrides(),
1325
+ forceRefresh: true,
1326
+ });
1327
+ if (restoredHistory.source !== 'provider-native') {
1328
+ this.lastExternalCompletionProbe = null;
1329
+ return null;
1330
+ }
1331
+ this.lastExternalCompletionProbe = buildExternalTranscriptProbe(
1332
+ restoredHistory.messages,
1333
+ restoredHistory.sourcePath,
1334
+ restoredHistory.sourceMtimeMs,
1335
+ );
1336
+ return restoredHistory.messages;
1337
+ }
1338
+
1339
+ /**
1340
+ * The content of the LAST visible assistant bubble in a message list, or ''
1341
+ * when the tail is not an assistant reply. Skips trailing system/tool/activity
1342
+ * bubbles; stops (returns '') at the first user/human message. Used only for
1343
+ * the dashboard tail-repair cache — a display value, not a completion decision.
1344
+ */
1345
+ private lastVisibleAssistantSummary(messages: unknown): string {
1346
+ if (!Array.isArray(messages)) return '';
1347
+ for (let i = messages.length - 1; i >= 0; i -= 1) {
1348
+ const m = messages[i] as { role?: string; kind?: string; content?: unknown };
1349
+ const role = typeof m?.role === 'string' ? m.role : '';
1350
+ const kind = typeof m?.kind === 'string' ? m.kind : '';
1351
+ if (role === 'system') continue;
1352
+ if (kind === 'tool' || kind === 'activity') continue;
1353
+ if (role === 'user' || role === 'human') return '';
1354
+ if (role === 'assistant') return flattenContent(m.content as any).trim();
1355
+ return '';
1356
+ }
1357
+ return '';
1358
+ }
1359
+
1360
+ private completionFinalAssistantEvidence(parsedMessages: unknown, turnStartedAt?: number): CompletionFinalAssistantEvidence {
1361
+ // (FALSEIDLE FixB) UPPER-BOUND turn-end evidence. completionHasFinalAssistantMessage is a
1362
+ // pure message-content check ("does the last visible bubble read as a finalized assistant
1363
+ // reply, post-dating the turn start?"). That LOWER bound alone treated the FIRST assistant
1364
+ // bubble of a turn that is STILL running — a tool call in flight between two assistant
1365
+ // bubbles — as proof the turn ended (RCA cases a & b). Require in ADDITION that the turn is
1366
+ // genuinely OVER: hasAdapterPendingResponse() folds the three upper-bound discriminators
1367
+ // into one — currentTurnScope closed, no in-flight tool (isProcessing false), and no partial
1368
+ // response buffer. So a mid-turn point-sample (short-gen / fast-collapse inline paths that
1369
+ // do NOT route through getCompletedFinalizationBlock) yields present=false and is held/settled
1370
+ // rather than fired. A genuinely-finished turn (adapter idle, no pending) is unaffected — the
1371
+ // gate stays open and the completion fires exactly as before. This mirrors the established
1372
+ // `completionHasFinalAssistantMessage(...) && !hasAdapterPendingResponse()` pairing already
1373
+ // used by the no-progress monitor reconcile path.
1374
+ const turnClosed = !this.hasAdapterPendingResponse();
1375
+ if (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)) {
1376
+ return {
1377
+ present: turnClosed,
1378
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1379
+ source: 'parsed',
1380
+ };
1381
+ }
1382
+
1383
+ const externalMessages = this.readExternalCompletionMessages();
1384
+ if (externalMessages) {
1385
+ const present = turnClosed && this.completionHasFinalAssistantMessage(externalMessages, turnStartedAt);
1386
+ // Dashboard tail-repair cache: this runs on EVERY completion check
1387
+ // (mesh AND non-mesh — the non-mesh path suppresses the
1388
+ // generating_completed emit, so completionFinalSummary never runs there
1389
+ // and cannot cache). Cache whenever the external transcript's LAST
1390
+ // visible bubble is an assistant reply — this is a display value only, so
1391
+ // it is intentionally looser than the strict `present` completion gate
1392
+ // (which also requires turnClosed and turn-scoping): the dashboard should
1393
+ // show the answer as soon as native-history has it, even if the FSM has
1394
+ // not yet ratified the turn end. getState() replaces it on the next turn.
1395
+ const lastVisibleAssistant = this.lastVisibleAssistantSummary(externalMessages);
1396
+ if (lastVisibleAssistant) {
1397
+ this.lastCompletionSummary = { content: lastVisibleAssistant, receivedAt: Date.now() };
1398
+ }
1399
+ return {
1400
+ present,
1401
+ messages: externalMessages,
1402
+ source: 'external-native',
1403
+ };
1404
+ }
1405
+
1406
+ return {
1407
+ present: false,
1408
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1409
+ source: 'unavailable',
1410
+ };
1411
+ }
1412
+
1413
+ private completionFinalSummary(parsedMessages: unknown, turnStartedAt?: number): string | undefined {
1414
+ // For native-source providers (claude-cli: chatMessagesOwnedExternally), the PTY
1415
+ // screen parse is NOT the source of truth for the final summary — the terminal
1416
+ // wraps/scrolls/clips text, so a screen-parsed assistant message is often a partial
1417
+ // prefix (e.g. 76 chars of a 112-char turn). The append-only native transcript holds
1418
+ // the complete turn. Prefer it whenever it yields a longer/complete summary; fall back
1419
+ // to the parsed screen only when the transcript is unavailable. This is the real cause
1420
+ // of the truncated finalSummary — independent of cloud vs standalone (it surfaces on
1421
+ // any short, fast-completing task where screen parse wins the race).
1422
+ //
1423
+ // NOTIF Defect-B: `turnStartedAt` (the producing turn's start, snapshotted on the
1424
+ // completedDebouncePending record) turn-scopes the NATIVE transcript read. The native
1425
+ // transcript holds the WHOLE session filtered only by session start, so a debounce that
1426
+ // flushes before the producing turn's final assistant bubble has landed would otherwise
1427
+ // return the PRIOR task's last bubble (event taskId=B but summary=A). Filtering to bubbles
1428
+ // at/after turnStartedAt yields '' in that race instead of the stale tail; the weak/empty
1429
+ // summary is later upgraded by the mesh reconcile loop once the real bubble is written.
1430
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1431
+ // FALSE-IDLE Defect 1b: turn-scope the PARSED screen fallback too. Without this a stale
1432
+ // mid-turn assistant (predating turnStartedAt) that the turn-boundary gate already
1433
+ // rejected as evidence could still leak into the finalSummary via this parsed fallback
1434
+ // when the external transcript's turn-scoped read is empty — freezing the very stale text
1435
+ // the gate rejected. extractFinalSummaryFromMessagesAfter drops bubbles before the turn
1436
+ // start; with no boundary known (turnStartedAt falsy) it is identical to the unscoped read.
1437
+ const parsedSummary = extractFinalSummaryFromMessagesAfter(
1438
+ (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)
1439
+ ? (Array.isArray(parsedMessages) ? parsedMessages : [])
1440
+ : []) as any,
1441
+ turnStartedAt,
1442
+ );
1443
+ if (adapterOwnsMessagesElsewhere) {
1444
+ const externalMessages = this.readExternalCompletionMessages();
1445
+ // Turn-scope the external transcript: never return a bubble produced before this
1446
+ // turn started. With no boundary known (turnStartedAt falsy) behaviour is unchanged.
1447
+ const externalSummary = externalMessages
1448
+ ? extractFinalSummaryFromMessagesAfter(externalMessages as any, turnStartedAt)
1449
+ : '';
1450
+ // The transcript is authoritative for native-source providers. Use it unless it is
1451
+ // empty (not yet written, or no in-turn bubble) — only then fall back to the screen
1452
+ // parse, which reflects the LIVE screen (this turn's output), not the stale tail.
1453
+ if (externalSummary) {
1454
+ // Cache the resolved final assistant for the dashboard tail-repair in
1455
+ // getState(). This runs on EVERY completion attempt (including non-mesh
1456
+ // sessions whose generating_completed is suppressed, and short-gen
1457
+ // settle paths), so the dashboard sees the answer even when no
1458
+ // agent:generating_completed is ever emitted. Native read already ran.
1459
+ this.lastCompletionSummary = { content: externalSummary, receivedAt: Date.now() };
1460
+ return externalSummary;
1461
+ }
1462
+ return parsedSummary || undefined;
1463
+ }
1464
+ return parsedSummary || undefined;
1465
+ }
1466
+
1467
+ private buildCompletedFinalizationDiagnostic(args: {
1468
+ blockReason: string;
1469
+ latestStatus?: any;
1470
+ latestVisibleStatus: string;
1471
+ waitedMs: number;
1472
+ pending: CompletedDebouncePending;
1473
+ emittedAfterFinalizationTimeout: boolean;
1474
+ }): Record<string, unknown> {
1475
+ let parsed: any = null;
1476
+ let parseError: string | undefined;
1477
+ try {
1478
+ parsed = this.adapter.getScriptParsedStatus();
1479
+ } catch (error: any) {
1480
+ parseError = error?.message || String(error);
1481
+ }
1482
+
1483
+ const evidence = this.completionFinalAssistantEvidence(parsed?.messages);
1484
+ if (evidence.source === 'external-native') {
1485
+ this.recordPendingTranscriptProbe(args.pending);
1486
+ }
1487
+ const visibleMessages = (Array.isArray(evidence.messages) ? evidence.messages : [])
1488
+ .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
1489
+ const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
1490
+ const lastVisibleRole = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : null;
1491
+ const lastVisibleKind = typeof (lastVisible as any)?.kind === 'string' ? (lastVisible as any).kind : null;
1492
+ const lastVisibleContentLength = lastVisible ? flattenContent(lastVisible.content).trim().length : 0;
1493
+
1494
+ return {
1495
+ providerType: this.type,
1496
+ sessionId: this.instanceId,
1497
+ providerSessionId: this.providerSessionId || null,
1498
+ workspace: this.workingDir,
1499
+ blockReason: args.blockReason,
1500
+ emittedAfterFinalizationTimeout: args.emittedAfterFinalizationTimeout,
1501
+ waitedMs: args.waitedMs,
1502
+ maxWaitMs: COMPLETED_FINALIZATION_MAX_WAIT_MS,
1503
+ adapterStatus: typeof args.latestStatus?.status === 'string' ? args.latestStatus.status : null,
1504
+ latestVisibleStatus: args.latestVisibleStatus,
1505
+ parsedStatus: typeof parsed?.status === 'string' ? parsed.status : (parseError ? 'parse_error' : 'unknown'),
1506
+ parseError: parseError || undefined,
1507
+ finalAssistantPresent: evidence.present,
1508
+ finalAssistantEvidenceSource: evidence.source,
1509
+ visibleMessageCount: visibleMessages.length,
1510
+ lastVisibleRole,
1511
+ lastVisibleKind,
1512
+ lastVisibleContentLength,
1513
+ pendingStartedAt: this.generatingStartedAt || null,
1514
+ pendingFirstObservedAt: args.pending.firstObservedAt,
1515
+ pendingTimestamp: args.pending.timestamp,
1516
+ pendingDurationSec: args.pending.duration,
1517
+ previousBlockReason: args.pending.loggedBlockReason || null,
1518
+ transcriptProbeHistory: args.pending.transcriptProbeHistory || [],
1519
+ };
744
1520
  }
745
1521
 
746
1522
  private hasAdapterPendingResponse(): boolean {
@@ -765,41 +1541,310 @@ export class CliProviderInstance implements ProviderInstance {
765
1541
  if (!isCliGeneratingLikeStatus(parsedRawStatus)) return false;
766
1542
  if (adapterRawStatus !== 'idle') return false;
767
1543
  if (hasNonEmptyCliModalButtons(parsedStatus?.activeModal ?? parsedStatus?.modal)) return false;
768
- return !this.hasAdapterPendingResponse();
1544
+ if (this.hasAdapterPendingResponse()) return false;
1545
+ // Do not suppress when the adapter's raw response buffer is still non-empty.
1546
+ // This catches the case where isWaitingForResponse has already flipped to false
1547
+ // (so getPartialResponse() returns '') but the provider's native parser still
1548
+ // reports generating because it's parsing buffered content. Suppressing the
1549
+ // finalization block here would emit a false completion event while the provider
1550
+ // session is still actively processing its response stream.
1551
+ const adapterAny = this.adapter as any;
1552
+ if (typeof adapterAny?.responseBuffer === 'string' && adapterAny.responseBuffer.trim()) return false;
1553
+ return true;
769
1554
  }
770
1555
 
771
- private getCompletedFinalizationBlockReason(latestVisibleStatus: string): string | null {
772
- if (latestVisibleStatus !== 'idle') return `status:${latestVisibleStatus}`;
1556
+ private getCompletedFinalizationBlock(latestVisibleStatus: string, pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1557
+ if (latestVisibleStatus !== 'idle') return { reason: `status:${latestVisibleStatus}`, terminal: true };
773
1558
 
774
1559
  const adapterAny = this.adapter as any;
775
- if (adapterAny?.isWaitingForResponse === true) return 'adapter_waiting_for_response';
776
- if (adapterAny?.currentTurnScope) return 'adapter_turn_scope_active';
1560
+ const approvalResolvedIdle = pending.previousStatus === 'waiting_approval';
1561
+ // (FALSEIDLE-a FixA) The adapter pending-response checks run UNCONDITIONALLY.
1562
+ // Previously they were SKIPPED when approvalResolvedIdle, on the assumption that
1563
+ // a waiting_approval→idle transition proved the approval's turn was over. But
1564
+ // auto-approve RESOLVES the modal and the agent RESUMES the same turn — currentTurnScope
1565
+ // / isWaitingForResponse stay set, or a tool runs — so skipping the guard let the FIRST
1566
+ // assistant bubble of the still-running turn be mistaken for the last and fired an early
1567
+ // completion the coordinator could never correct (RCA case a). Keep the guard live for the
1568
+ // approval path too: when the resumed turn genuinely ends these clear and the completion
1569
+ // fires. Approval-resolved holds are NON-terminal (bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS)
1570
+ // so a provider that never closes its turn-scope still force-fires a weak completion rather
1571
+ // than wedging; the non-approval path keeps its terminal hold (a genuinely-busy adapter must
1572
+ // never force a completion out).
1573
+ if (adapterAny?.isWaitingForResponse === true) return { reason: 'adapter_waiting_for_response', terminal: !approvalResolvedIdle };
1574
+ if (adapterAny?.currentTurnScope) return { reason: 'adapter_turn_scope_active', terminal: !approvalResolvedIdle };
1575
+ if (this.hasAdapterPendingResponse()) return { reason: 'adapter_pending_response', terminal: !approvalResolvedIdle };
777
1576
 
778
1577
  const partial = typeof this.adapter.getPartialResponse === 'function'
779
1578
  ? this.adapter.getPartialResponse()
780
1579
  : '';
781
- if (typeof partial === 'string' && partial.trim()) return 'partial_response_pending';
1580
+ if (typeof partial === 'string' && partial.trim()) return { reason: 'partial_response_pending', terminal: true };
782
1581
 
783
1582
  let parsed: any;
784
1583
  try {
785
1584
  parsed = this.adapter.getScriptParsedStatus();
786
1585
  } catch (error: any) {
787
- return `parse_error:${error?.message || String(error)}`;
1586
+ return { reason: `parse_error:${error?.message || String(error)}` };
788
1587
  }
789
1588
 
790
1589
  const parsedStatus = typeof parsed?.status === 'string' ? parsed.status : 'unknown';
791
- if (parsedStatus !== 'idle') return `parsed_status:${parsedStatus}`;
792
- if (parsed?.activeModal || parsed?.modal) return 'parsed_modal_active';
793
- if (!this.completionHasFinalAssistantMessage(parsed?.messages)) return 'missing_final_assistant';
1590
+ if (parsedStatus !== 'idle') {
1591
+ const adapterStatus = this.adapter.getStatus({ allowParse: false });
1592
+ if (this.shouldSuppressStaleParsedBusyStatus(parsed, adapterStatus)) return null;
1593
+ return { reason: `parsed_status:${parsedStatus}`, terminal: isCliGeneratingLikeStatus(parsedStatus) };
1594
+ }
1595
+ if (parsed?.activeModal || parsed?.modal) return { reason: 'parsed_modal_active', terminal: true };
1596
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1597
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): turn-scope the present-check so a
1598
+ // STALE mid-turn assistant (predating pending.turnStartedAt) cannot satisfy the
1599
+ // finalization gate. Only the confirming final-assistant bubble that POST-DATES this
1600
+ // turn's start counts as evidence the turn genuinely ended.
1601
+ const finalAssistantEvidence = this.completionFinalAssistantEvidence(parsed?.messages, pending.turnStartedAt);
1602
+ const allowMissingAssistantTimeout = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1603
+ LOG.debug('CLI', `[${this.type}] finalAssistantEvidence: present=${finalAssistantEvidence.present} source=${finalAssistantEvidence.source} adapterOwnsMessagesElsewhere=${adapterOwnsMessagesElsewhere} parsedStatus=${parsedStatus}`);
1604
+ if (!finalAssistantEvidence.present) {
1605
+ if (adapterOwnsMessagesElsewhere) {
1606
+ if (finalAssistantEvidence.source === 'external-native') {
1607
+ const probe = this.recordPendingTranscriptProbe(pending);
1608
+ if (probe && !pending.loggedTranscriptProbe) {
1609
+ LOG.info('CLI', `[${this.type}] external transcript probe: msgCount=${probe.msgCount} lastRole=${probe.lastRole || 'none'} lastKind=${probe.lastKind || 'none'} contentLen=${probe.contentLen} sourceMtime=${probe.sourceMtimeMs ?? 'unknown'} mtimeAge=${probe.mtimeAgeMs ?? 'unknown'}ms`);
1610
+ pending.loggedTranscriptProbe = true;
1611
+ }
1612
+ LOG.debug('CLI', `[${this.type}] external-native probe result: lastRole=${probe?.lastRole} contentLen=${probe?.contentLen}`);
1613
+ if (probe?.lastRole === 'assistant' && (probe.contentLen ?? 0) > 0) {
1614
+ return null;
1615
+ }
1616
+ if (this.type === 'antigravity-cli') {
1617
+ return null;
1618
+ }
1619
+ // (SETTLE-VALLEY) The inter-approval idle valley: a native-history mesh worker
1620
+ // that resolved an approval and fell briefly idle (waiting_approval→idle) BEFORE
1621
+ // the next approval turn resumes. The live valley (~3s) is mostly covered by the
1622
+ // 4000ms NATIVE_HISTORY_MESH_IDLE_SETTLE_MS settle window, but a longer valley can
1623
+ // still let the flush run while the transcript's final assistant turn is not yet
1624
+ // written (source still the screen parse → finalAssistantPresent=false,
1625
+ // workerResult.source='default'). CANON-C would emit immediately here, freezing a
1626
+ // truncated preamble summary as evidenceLevel=insufficient. Instead HOLD: this
1627
+ // waiting_approval hold complements the settle window. Retry until the transcript finalizes
1628
+ // (block clears → genuine emit) or the worker resumes (resume guard cancels),
1629
+ // bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS. Scoped to the approval-resolved
1630
+ // idle so a genuinely-finished background-child turn keeps the CANON-C immediate
1631
+ // emit (its transcript trails by a write, not by a whole resume).
1632
+ if (allowMissingAssistantTimeout && pending.previousStatus === 'waiting_approval') {
1633
+ return { reason: 'missing_final_assistant', terminal: false, holdForTranscript: true };
1634
+ }
1635
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1636
+ }
1637
+ if ((this.provider as any).requiresFinalAssistantBeforeIdle === true) {
1638
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1639
+ }
1640
+ } else {
1641
+ LOG.debug('CLI', `[${this.type}] missing_final_assistant (not ownsExternal) requiresFinalAssistant=${!!(this.provider as any).requiresFinalAssistantBeforeIdle}`);
1642
+ return {
1643
+ reason: 'missing_final_assistant',
1644
+ terminal: (this.provider as any).requiresFinalAssistantBeforeIdle === true,
1645
+ allowTimeout: allowMissingAssistantTimeout,
1646
+ };
1647
+ }
1648
+ }
1649
+
1650
+ // (FALSEIDLE-a) Structural approval-resolution gate. Runs BEFORE the brittle
1651
+ // screen-text heuristic below so it also catches modals whose text does not match
1652
+ // looksLikeActiveApprovalPromptText (e.g. claude-cli's cd / "untrusted hooks" prompt).
1653
+ const approvalResolutionBlock = this.approvalResolutionFinalizationBlock(pending);
1654
+ if (approvalResolutionBlock) return approvalResolutionBlock;
1655
+
1656
+ // Guard: if the screen still shows an approval/choice prompt as the last visible text,
1657
+ // the turn is not complete even if the parsed status says idle and there is an assistant
1658
+ // message. This catches the case where waiting_approval→idle transitions occur before
1659
+ // the modal has been resolved (e.g. the PTY rendered the prompt but no button press fired).
1660
+ try {
1661
+ const screenText = typeof (this.adapter as any).getScreenText === 'function'
1662
+ ? String((this.adapter as any).getScreenText() || '')
1663
+ : '';
1664
+ if (screenText) {
1665
+ const tailLines = screenText.split(/\r?\n/).slice(-16).join('\n');
1666
+ if (looksLikeActiveApprovalPromptText(tailLines)) {
1667
+ return { reason: 'screen_shows_approval_prompt', terminal: approvalResolvedIdle };
1668
+ }
1669
+ }
1670
+ } catch { /* defensive: screen text read is best-effort */ }
794
1671
 
795
1672
  return null;
796
1673
  }
797
1674
 
1675
+ // (FALSEIDLE-a) Positive, structural proof that the latest approval entry was resolved
1676
+ // through ADHDev. resolveModal() — driven by auto-approve, dashboard/mesh_approve, and
1677
+ // dev-cli-debug alike — advances the engine's lastResolvedEntrySeq to the current
1678
+ // approvalEntrySeq. So `lastResolvedEntrySeq >= approvalEntrySeq` (with a real entry,
1679
+ // approvalEntrySeq > 0) means the modal we last saw was actually answered. Absence of this
1680
+ // evidence after a waiting_approval→idle transition means the idle is suspect: the spec's
1681
+ // text-based approval→idle rule false-tripped while the modal is still unresolved.
1682
+ // Fails OPEN (returns true) when the seq fields are unavailable, so the gate can never wedge
1683
+ // a session on a provider/adapter that does not surface the counters.
1684
+ private hasApprovalResolutionEvidence(): boolean {
1685
+ try {
1686
+ const status = this.adapter.getStatus({ allowParse: false }) as any;
1687
+ const entrySeq = typeof status?.approvalEntrySeq === 'number' ? status.approvalEntrySeq : 0;
1688
+ if (entrySeq <= 0) return true;
1689
+ const resolvedSeq = typeof status?.lastResolvedEntrySeq === 'number' ? status.lastResolvedEntrySeq : undefined;
1690
+ if (resolvedSeq === undefined) return true;
1691
+ return resolvedSeq >= entrySeq;
1692
+ } catch {
1693
+ return true;
1694
+ }
1695
+ }
1696
+
1697
+ // (FALSEIDLE-a) Hold a completion that is the anomalous DIRECT waiting_approval→idle
1698
+ // transition with no positive resolution evidence. A genuinely resolved approval routes
1699
+ // through resolveModal → setStatus('generating'), so its completion's previousStatus is
1700
+ // 'generating' (not 'waiting_approval') and this gate never fires for it. Scoped to
1701
+ // delegated mesh/coordinator sessions — whose only modal-resolution path is auto-approve /
1702
+ // mesh_approve (both advance lastResolvedEntrySeq) — so an interactive local session, where
1703
+ // a human may answer the PTY prompt directly and leave no resolveModal record, is untouched.
1704
+ // Non-terminal: the hold is bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS (30s), giving a
1705
+ // settling auto-approve time to fire and advance the seq, and guaranteeing no permanent wedge
1706
+ // if resolution ever happens via a path that does not record evidence.
1707
+ private approvalResolutionFinalizationBlock(pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1708
+ if (pending.previousStatus !== 'waiting_approval') return null;
1709
+ const meshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1710
+ if (!meshContext) return null;
1711
+ if (this.hasApprovalResolutionEvidence()) return null;
1712
+ return { reason: 'approval_resolution_unconfirmed', terminal: false };
1713
+ }
1714
+
798
1715
  private scheduleCompletedDebounceFlush(delayMs: number): void {
799
1716
  if (this.completedDebounceTimer) clearTimeout(this.completedDebounceTimer);
800
1717
  this.completedDebounceTimer = setTimeout(() => this.flushCompletedDebounceIfFinalized(), delayMs);
801
1718
  }
802
1719
 
1720
+ // EVTTRACE (observation-only): is this a mesh worker session whose completion
1721
+ // events must route to a coordinator? Used purely to gate trace logging so a
1722
+ // non-mesh CLI session's completions don't add EvtTrace noise. No decision logic.
1723
+ private isMeshWorkerSession(): boolean {
1724
+ return !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId
1725
+ || this.settings.meshNodeId || this.settings.launchedByCoordinator);
1726
+ }
1727
+
1728
+ /**
1729
+ * AUTOAPPROVE-FLAP-RECUR (Fix A+B): how long a busy blip / modal scroll-out may
1730
+ * persist before the in-progress settle gate is torn down. For a delegated
1731
+ * worker whose auto-approve episode is genuinely still cycling (mask clock
1732
+ * alive), the FSM's full waiting_approval → busy → waiting_approval flap runs
1733
+ * on a multi-second period, so the settle continuity window is extended to
1734
+ * AUTO_APPROVE_FLAP_CONTINUITY_MS to bridge it (still bounded, and still capped
1735
+ * by AUTO_APPROVE_MASK_STALL_MS). Every other case — foreground/attended
1736
+ * session, or no active mask episode — keeps the tight default hysteresis so a
1737
+ * genuine resolution frees the gate promptly.
1738
+ */
1739
+ private autoApproveContinuityWindowMs(): number {
1740
+ return this.autoApproveMaskSince > 0 && this.isMeshWorkerSession()
1741
+ ? CliProviderInstance.AUTO_APPROVE_FLAP_CONTINUITY_MS
1742
+ : CliProviderInstance.AUTO_APPROVE_GATE_HYSTERESIS_MS;
1743
+ }
1744
+
1745
+ /**
1746
+ * The settle-gate identity signature for a raw activeModal, or null when the
1747
+ * modal is NOT a concrete auto-approvable consent prompt (no captured buttons,
1748
+ * a picker/confirm kind, or no reliable affirmative+decline anchor). Mirrors the
1749
+ * gates the auto-approve fire path applies before computing modalSignature, so
1750
+ * the mask-stall nudge can ask the SAME question the settle gate is tracking —
1751
+ * "is THIS frame's modal the identity the settle clock is accruing against?" —
1752
+ * without duplicating the button-pick logic. The signature is message +
1753
+ * normalized affirmative label only (no volatile counters/button set), matching
1754
+ * the fire path exactly (AUTOAPPROVE-SETTLE-FLAP).
1755
+ */
1756
+ private approvableModalSignature(modal: any): string | null {
1757
+ const buttons = Array.isArray(modal?.buttons)
1758
+ ? modal.buttons.map((b: any) => String(b || '').trim()).filter(Boolean)
1759
+ : [];
1760
+ if (!modal || buttons.length === 0) return null;
1761
+ const modalKind = typeof modal?.kind === 'string' ? modal.kind : 'approval';
1762
+ if (modalKind !== 'approval') return null;
1763
+ const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(buttons, this.provider);
1764
+ const hasReliableConsentAnchor = hasNegativeApprovalOption(buttons)
1765
+ || hasReliableApprovalAffirmative(buttons);
1766
+ if (buttonIndex < 0 || !hasReliableConsentAnchor) return null;
1767
+ return approvalModalSignature(modal?.message, normalizeApprovalLabel(buttonLabel));
1768
+ }
1769
+
1770
+ // FALSE-IDLE (self-coordinator settle): an autonomously-progressing mesh session
1771
+ // is either a delegated worker (isMeshWorkerSession) OR the coordinator's OWN
1772
+ // claude-cli session (meshCoordinatorFor). Both run auto-approved tool turns whose
1773
+ // inter-approval valley (busy→idle blip→generating re-entry ~0.5s later) must be
1774
+ // absorbed by the completedDebounce settle window, not flushed on the first idle
1775
+ // sample. The worker branch already gets NATIVE_HISTORY_MESH_IDLE_SETTLE_MS; the
1776
+ // self-coordinator session (worker markers absent, meshCoordinatorFor present) was
1777
+ // taking flushDelay=0 — no settle window — so its busyEpoch/lastOutputAt continuity
1778
+ // guard had no window to observe the valley and fired mid-turn "next-step" previews
1779
+ // as a finalSummary. Mirrors the isAutonomousMeshSession notion in isTransientToolConsent.
1780
+ private isAutonomousMeshSession(): boolean {
1781
+ return this.isMeshWorkerSession() || !!this.settings.meshCoordinatorFor;
1782
+ }
1783
+
1784
+ /**
1785
+ * ARCH-REFACTOR R1: the taskId to attribute the CURRENTLY-completing turn to.
1786
+ * Prefers the per-turn binding (engine.currentTurnTaskId, set when the turn was
1787
+ * submitted and surviving until the next turn starts) over the last-write-wins
1788
+ * session scalar (settings.meshActiveTaskId). The scalar is retained only as a
1789
+ * backward-compat alias for the "current/last assignment" and is the source of the
1790
+ * NOTIF-MISDELIVER / TASK-MSG-MISROUTE race: a second task attaching before this
1791
+ * turn completes overwrites it. Returns undefined for a non-task ad-hoc turn.
1792
+ */
1793
+ private completingTurnTaskId(): string | undefined {
1794
+ const turnTaskId = this.adapter?.currentTurnTaskId;
1795
+ if (typeof turnTaskId === 'string' && turnTaskId.trim()) return turnTaskId;
1796
+ const scalar = this.settings.meshActiveTaskId;
1797
+ return typeof scalar === 'string' && scalar.trim() ? scalar : undefined;
1798
+ }
1799
+
1800
+ // EVTTRACE correlation context for this session's completion lifecycle. taskId is
1801
+ // the primary grep anchor; instanceId is the session fallback.
1802
+ private meshTraceCtx(event = 'agent:generating_completed'): Record<string, unknown> {
1803
+ return {
1804
+ // ARCH-REFACTOR R1: trace the per-turn taskId (falling back to the scalar) so
1805
+ // EvtTrace anchors on the same id the completion event actually carries.
1806
+ taskId: this.completingTurnTaskId(),
1807
+ sessionId: this.instanceId,
1808
+ nodeId: this.settings.meshNodeId,
1809
+ meshId: this.settings.meshNodeFor,
1810
+ event,
1811
+ };
1812
+ }
1813
+
1814
+ // COMPLETION-EARLYNOTIFY instrumentation. A session-keyed FSM-transition +
1815
+ // completion-gate snapshot recorded into the shared debug-trace ring buffer
1816
+ // (secret-safe, length/role/pattern-name only — never screen or bubble text).
1817
+ // Retrieved via getRecentDebugTrace (chat_debug_bundle). Both categories are a
1818
+ // no-op unless collectDebugTrace is on AND the category is selected, so the
1819
+ // hot-path guards below (completionTraceOn / fsmTraceOn) keep production cost
1820
+ // at a single boolean check.
1821
+ private completionTraceOn(): boolean {
1822
+ return shouldCollectTraceCategory('completion-gate');
1823
+ }
1824
+ private fsmTraceOn(): boolean {
1825
+ return shouldCollectTraceCategory('fsm-transition');
1826
+ }
1827
+ private recordCompletionGateTrace(stage: string, payload: Record<string, unknown>): void {
1828
+ recordDebugTrace({
1829
+ category: 'completion-gate',
1830
+ stage,
1831
+ level: 'debug',
1832
+ sessionId: this.instanceId,
1833
+ providerType: this.type,
1834
+ payload,
1835
+ });
1836
+ }
1837
+ private recordFsmTransitionTrace(payload: Record<string, unknown>): void {
1838
+ recordDebugTrace({
1839
+ category: 'fsm-transition',
1840
+ stage: 'transition',
1841
+ level: 'debug',
1842
+ sessionId: this.instanceId,
1843
+ providerType: this.type,
1844
+ payload,
1845
+ });
1846
+ }
1847
+
803
1848
  private flushCompletedDebounceIfFinalized(): void {
804
1849
  const pending = this.completedDebouncePending;
805
1850
  if (!pending) {
@@ -809,97 +1854,763 @@ export class CliProviderInstance implements ProviderInstance {
809
1854
 
810
1855
  const latestStatus = this.adapter.getStatus({ allowParse: false });
811
1856
  const latestAutoApproveActive = latestStatus.status === 'waiting_approval' && this.shouldAutoApprove();
812
- const latestVisibleStatus = latestAutoApproveActive ? 'generating' : latestStatus.status;
1857
+ const latestVisibleStatus = latestAutoApproveActive || this.autoApproveBusy ? 'generating' : latestStatus.status;
1858
+ LOG.debug('CLI', `[${this.type}] flush attempt: adapterStatus=${latestStatus.status} latestVisible=${latestVisibleStatus} generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse} hasPartial=${!!this.adapter.getPartialResponse?.()}`);
813
1859
  if (latestVisibleStatus !== 'idle') {
814
1860
  LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed ${latestVisibleStatus})`);
1861
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1862
+ blockReason: 'resumed_status',
1863
+ latestVisibleStatus,
1864
+ previousStatus: pending.previousStatus,
1865
+ busyEpochAtArm: pending.busyEpochAtArm,
1866
+ busyEpoch: this.busyEpoch,
1867
+ });
1868
+ this.completedDebouncePending = null;
1869
+ this.completedDebounceTimer = null;
1870
+ return;
1871
+ }
1872
+
1873
+ // FALSE-IDLE continuity guard (Defect 1a): the point-sample above only proves the
1874
+ // session is idle at THIS instant. A momentary busy→idle blip inside an inter-approval
1875
+ // valley (auto-approved tool turns) opens AND closes a generating phase entirely within
1876
+ // the settle window — so the single sample reads 'idle' even though the turn is still in
1877
+ // flight (it re-enters generating ~0.5s later). Require instead that the session stayed
1878
+ // CONTINUOUSLY idle since the debounce was armed: (1) no entry into a busy phase
1879
+ // (busyEpoch unchanged), and (2) no new raw PTY output (lastOutputAt did not advance).
1880
+ // Either signal ⇒ the idle was not continuous ⇒ cancel; the still-live turn re-arms its
1881
+ // own completion when it genuinely finishes. This only ever cancels (never emits more),
1882
+ // so shared behaviour for claude/codex/antigravity is strictly stricter, never looser.
1883
+ if (typeof pending.busyEpochAtArm === 'number' && this.busyEpoch !== pending.busyEpochAtArm) {
1884
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (busy re-entry during settle: epoch ${pending.busyEpochAtArm}→${this.busyEpoch})`);
1885
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1886
+ blockReason: 'busy_reentry',
1887
+ latestVisibleStatus,
1888
+ previousStatus: pending.previousStatus,
1889
+ busyEpochAtArm: pending.busyEpochAtArm,
1890
+ busyEpoch: this.busyEpoch,
1891
+ busyEpochDelta: this.busyEpoch - pending.busyEpochAtArm,
1892
+ });
1893
+ this.completedDebouncePending = null;
1894
+ this.completedDebounceTimer = null;
1895
+ return;
1896
+ }
1897
+ const latestOutputAt = typeof (latestStatus as any)?.lastOutputAt === 'number' ? (latestStatus as any).lastOutputAt as number : undefined;
1898
+ if (typeof pending.lastOutputAtArm === 'number'
1899
+ && typeof latestOutputAt === 'number'
1900
+ && latestOutputAt > pending.lastOutputAtArm) {
1901
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (new PTY output during settle: ${pending.lastOutputAtArm}→${latestOutputAt})`);
1902
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1903
+ blockReason: 'new_pty_output',
1904
+ latestVisibleStatus,
1905
+ previousStatus: pending.previousStatus,
1906
+ lastOutputAtArm: pending.lastOutputAtArm,
1907
+ lastOutputAt: latestOutputAt,
1908
+ lastOutputAtDelta: latestOutputAt - pending.lastOutputAtArm,
1909
+ });
815
1910
  this.completedDebouncePending = null;
816
1911
  this.completedDebounceTimer = null;
817
1912
  return;
818
1913
  }
819
1914
 
820
- const blockReason = this.getCompletedFinalizationBlockReason(latestVisibleStatus);
821
- if (blockReason) {
1915
+ const block = this.getCompletedFinalizationBlock(latestVisibleStatus, pending);
1916
+ if (block) {
1917
+ const blockReason = block.reason;
822
1918
  const waitedMs = Date.now() - pending.firstObservedAt;
823
- if (waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS) {
1919
+ // CANON-C (completion-gate decouple): a block carrying `allowTimeout` is the
1920
+ // transcript-evidence gate — the worker FSM has ALREADY reached idle and the only
1921
+ // thing missing is the append-only transcript's final assistant turn (a native-source
1922
+ // race: claude-cli owns its history externally and the file write trails the idle
1923
+ // transition). `allowTimeout` is set ONLY on the missing_final_assistant block, and
1924
+ // ONLY for mesh worker sessions (meshNodeFor / meshActiveTaskId / launchedByCoordinator).
1925
+ // The coordinator's sole path to learn this session is idle is agent:generating_completed,
1926
+ // so holding it up to COMPLETED_FINALIZATION_MAX_WAIT_MS (30s) leaves the coordinator
1927
+ // false-generating while the worker is done. Decouple the idle NOTIFICATION from the
1928
+ // transcript evidence: emit the completion immediately, marked weak
1929
+ // (completionDiagnostic.blockReason=missing_final_assistant, finalAssistantPresent=false).
1930
+ // The finalSummary is enriched on a SEPARATE path — the mesh reconcile loop reads the
1931
+ // transcript once written and re-emits a GENUINE completion (CANON-B weak→genuine
1932
+ // upgrade; buildPendingEventFingerprint keeps weak and genuine distinct so the enriched
1933
+ // one still surfaces, and isFalseIdleCompletion keeps the direct dispatch active until
1934
+ // then). All OTHER blocks (genuinely-busy adapter/partial/parsed states, transient
1935
+ // parse_error) keep the existing terminal-hold / 30s-retry behavior unchanged.
1936
+ //
1937
+ // (SETTLE-VALLEY) Exception: a `holdForTranscript` block is the inter-approval idle
1938
+ // valley of a native-history mesh worker (waiting_approval→idle that will resume into
1939
+ // the next approval). It deliberately does NOT carry allowTimeout, so it falls into the
1940
+ // hold-and-retry path below (terminal:false) rather than the CANON-C immediate emit —
1941
+ // the retry loop re-runs the resume guard each cycle, so when the worker resumes the
1942
+ // pending completion is cancelled, and when the transcript's final assistant arrives the
1943
+ // block clears for a GENUINE emit. This blocks the truncated weak (insufficient) summary
1944
+ // from ever being emitted during the valley, without depending on the valley's length.
1945
+ const isTranscriptEvidenceGate = block.allowTimeout === true;
1946
+ LOG.debug('CLI', `[${this.type}] finalization block: reason=${blockReason} terminal=${block.terminal} allowTimeout=${isTranscriptEvidenceGate} waitedMs=${waitedMs} maxWait=${COMPLETED_FINALIZATION_MAX_WAIT_MS}`);
1947
+ if (!isTranscriptEvidenceGate && (block.terminal || waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS)) {
824
1948
  if (pending.loggedBlockReason !== blockReason) {
825
1949
  LOG.info('CLI', `[${this.type}] waiting to emit completed until transcript finalizes (${blockReason})`);
1950
+ // EVTTRACE: completion held by the finalization gate (CANON-C). Observation
1951
+ // only — does not change the hold decision above.
1952
+ if (this.isMeshWorkerSession()) {
1953
+ traceMeshEventDrop('completion_gate_hold', this.meshTraceCtx(), `${blockReason} waited=${waitedMs}ms`);
1954
+ }
1955
+ // COMPLETION-EARLYNOTIFY: a hold is the CORRECT outcome when the turn is not
1956
+ // yet proven done (the FixA/FixB gates route here); trace it so an early-notify
1957
+ // investigation can see the gate holding rather than firing.
1958
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('hold', {
1959
+ blockReason,
1960
+ latestVisibleStatus,
1961
+ terminal: block.terminal === true,
1962
+ holdForTranscript: block.holdForTranscript === true,
1963
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
1964
+ waitedMs,
1965
+ });
826
1966
  pending.loggedBlockReason = blockReason;
827
1967
  }
828
1968
  this.scheduleCompletedDebounceFlush(COMPLETED_FINALIZATION_RETRY_MS);
829
1969
  return;
830
1970
  }
831
- LOG.warn('CLI', `[${this.type}] suppressed completed event after ${waitedMs}ms without finalized assistant turn (${blockReason})`);
1971
+ const emittedAfterFinalizationTimeout = waitedMs >= COMPLETED_FINALIZATION_MAX_WAIT_MS;
1972
+ const completionDiagnostic = this.buildCompletedFinalizationDiagnostic({
1973
+ blockReason,
1974
+ latestStatus,
1975
+ latestVisibleStatus,
1976
+ waitedMs,
1977
+ pending,
1978
+ emittedAfterFinalizationTimeout,
1979
+ });
1980
+ // Surface the CANON-C immediate-emit path distinctly so a delegated worker's idle
1981
+ // notification (transcript still pending) is not mistaken for a 30s-timeout fallback.
1982
+ (completionDiagnostic as Record<string, unknown>).decoupledImmediateEmit = isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout;
1983
+ LOG.warn('CLI', `[${this.type}] emitting completed event (${isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout ? 'CANON-C decoupled-immediate, transcript pending' : `after ${waitedMs}ms`}) without finalized assistant turn (${blockReason})`);
1984
+ // EVTTRACE: completion fired (forced past the finalization timeout / CANON-C decoupled-immediate).
1985
+ if (this.isMeshWorkerSession()) {
1986
+ traceMeshEventStage('fired', this.meshTraceCtx(), `forced after ${waitedMs}ms (${blockReason})`);
1987
+ }
1988
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('fire', {
1989
+ path: isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout ? 'canon_c_decoupled' : 'forced_timeout',
1990
+ blockReason,
1991
+ latestVisibleStatus,
1992
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
1993
+ finalAssistantPresent: (completionDiagnostic as any).finalAssistantPresent === true,
1994
+ evidenceSource: (completionDiagnostic as any).finalAssistantEvidenceSource ?? null,
1995
+ lastVisibleRole: (completionDiagnostic as any).lastVisibleRole ?? null,
1996
+ lastVisibleContentLen: (completionDiagnostic as any).lastVisibleContentLength ?? null,
1997
+ emittedAfterFinalizationTimeout,
1998
+ waitedMs,
1999
+ busyEpoch: this.busyEpoch,
2000
+ });
2001
+ this.emitGeneratingCompleted({
2002
+ chatTitle: pending.chatTitle,
2003
+ duration: pending.duration,
2004
+ timestamp: pending.timestamp,
2005
+ taskId: pending.taskId,
2006
+ // When finalization is forced past the timeout on a `parsed_status:` block
2007
+ // (the parser never confirmed a final assistant turn) we previously rode an
2008
+ // empty `finalSummary` unconditionally. That empty value propagates to the
2009
+ // mesh coordinator's mirror preview (meshSessionLastMessagePreview), leaving a
2010
+ // delegated session's inbox preview blank — or, for a LOCAL worktree session,
2011
+ // stuck on the dispatched user task. If the parser DID surface assistant text,
2012
+ // prefer it; only fall back to '' when no assistant summary can be derived.
2013
+ finalSummary: blockReason.startsWith('parsed_status:')
2014
+ ? (this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt) ?? '')
2015
+ : this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
2016
+ completionDiagnostic,
2017
+ });
832
2018
  this.completedDebouncePending = null;
833
2019
  this.completedDebounceTimer = null;
834
2020
  this.generatingStartedAt = 0;
2021
+ this.lastApprovalEventFingerprint = '';
835
2022
  return;
836
2023
  }
837
2024
 
838
2025
  LOG.info('CLI', `[${this.type}] completed in ${pending.duration}s`);
839
- this.pushEvent({
840
- event: 'agent:generating_completed',
2026
+ // EVTTRACE: completion fired (transcript finalized cleanly).
2027
+ if (this.isMeshWorkerSession()) {
2028
+ traceMeshEventStage('fired', this.meshTraceCtx(), `duration=${pending.duration}s`);
2029
+ }
2030
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('fire', {
2031
+ path: 'clean',
2032
+ latestVisibleStatus,
2033
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
2034
+ finalAssistantPresent: true,
2035
+ duration: pending.duration,
2036
+ busyEpoch: this.busyEpoch,
2037
+ });
2038
+ this.emitGeneratingCompleted({
841
2039
  chatTitle: pending.chatTitle,
842
2040
  duration: pending.duration,
843
2041
  timestamp: pending.timestamp,
844
- finalSummary: extractFinalSummaryFromMessages(this.adapter?.getScriptParsedStatus()?.messages),
2042
+ taskId: pending.taskId,
2043
+ finalSummary: this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
845
2044
  });
846
2045
  this.completedDebouncePending = null;
847
2046
  this.completedDebounceTimer = null;
848
2047
  this.generatingStartedAt = 0;
2048
+ this.lastApprovalEventFingerprint = '';
2049
+ }
2050
+
2051
+ /**
2052
+ * A-3 (CLI 완료판정 통합): single authoritative emit for a CLI turn's
2053
+ * `agent:generating_completed` event. The completion JUDGMENT — WHETHER and
2054
+ * WHEN a turn is done (settle windows, continuity guards, the finalization
2055
+ * gate, the short-gen / startup-grace / no-progress-monitor discriminators) —
2056
+ * stays at each call site, where it is legitimately path-specific. What used
2057
+ * to be duplicated across all five completion paths was the EVENT-SHAPE
2058
+ * assembly: the `event` name, the conditional `taskId` spread, and the
2059
+ * optional `finalSummary` / `evidenceLevel` / `completionDiagnostic` fields.
2060
+ * Folding that assembly here removes the divergence (e.g. one site spreading
2061
+ * taskId, others omitting it) without touching any judgment. Callers pass the
2062
+ * values they have already computed; omitted optionals are simply absent from
2063
+ * the emitted event, exactly as each inline builder produced before.
2064
+ */
2065
+ private emitGeneratingCompleted(opts: {
2066
+ chatTitle: string;
2067
+ duration: number | undefined;
2068
+ timestamp: number;
2069
+ taskId?: string;
2070
+ finalSummary?: string;
2071
+ evidenceLevel?: string;
2072
+ completionDiagnostic?: Record<string, unknown>;
2073
+ }): void {
2074
+ // Cache the final assistant summary so the dashboard snapshot can surface it
2075
+ // for native-source providers whose assistant answer is absent from the PTY
2076
+ // parse (antigravity). completionFinalSummary already read native-history to
2077
+ // produce this, so nothing extra is read here.
2078
+ const summary = typeof opts.finalSummary === 'string' ? opts.finalSummary.trim() : '';
2079
+ if (summary) {
2080
+ this.lastCompletionSummary = { content: summary, receivedAt: opts.timestamp };
2081
+ }
2082
+ this.pushEvent({
2083
+ event: 'agent:generating_completed',
2084
+ chatTitle: opts.chatTitle,
2085
+ duration: opts.duration,
2086
+ timestamp: opts.timestamp,
2087
+ // ARCH-REFACTOR R1: attribute to the turn captured at idle-transition.
2088
+ ...(opts.taskId ? { taskId: opts.taskId } : {}),
2089
+ // finalSummary is always carried (value may be undefined) — every prior
2090
+ // inline builder included the key, so downstream consumers see the same shape.
2091
+ finalSummary: opts.finalSummary,
2092
+ ...(opts.evidenceLevel !== undefined ? { evidenceLevel: opts.evidenceLevel } : {}),
2093
+ ...(opts.completionDiagnostic !== undefined ? { completionDiagnostic: opts.completionDiagnostic } : {}),
2094
+ });
849
2095
  }
850
2096
 
851
2097
  private maybeAutoApproveStatus(adapterStatus: any, now = Date.now()): boolean {
2098
+ // Manual-attendance suppression (provider-common): when a human is
2099
+ // Manual-attendance suppression (provider-common): when a human is
2100
+ // actively driving this session from the dashboard, hold auto-approve so
2101
+ // the modal stays visible and they can pick a button / use the controlbar
2102
+ // themselves. Return false (NOT auto-approving) so getState keeps the
2103
+ // modal surfaced. Clear any in-progress settle gate — a genuine fire
2104
+ // after the window lapses must re-settle from scratch — and arm a
2105
+ // re-check for the lapse moment, because the PTY may have gone silent and
2106
+ // would otherwise never re-drive this decision. Background mesh workers
2107
+ // are never attended, so their delegated auto-approve is untouched.
2108
+ if (adapterStatus?.status === 'waiting_approval'
2109
+ && this.shouldAutoApprove()
2110
+ && this.manualAttendance.isAttended(now)) {
2111
+ this.lastAutoApprovalSignature = '';
2112
+ this.pendingAutoApprovalSignature = '';
2113
+ this.pendingAutoApprovalSince = 0;
2114
+ this.autoApproveInactiveSince = 0;
2115
+ // Manual attendance takes over — the modal stays surfaced (maybeAutoApproveStatus
2116
+ // returns false), so end the mask episode.
2117
+ this.autoApproveMaskSince = 0;
2118
+ this.stalledApprovalNudgeEpisode = 0;
2119
+ this.autoApproveLastModalSeenAt = 0;
2120
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2121
+ this.autoApproveSettleTimer = setTimeout(() => {
2122
+ this.autoApproveSettleTimer = null;
2123
+ this.recheckAutoApproveSettled();
2124
+ }, this.manualAttendance.remainingMs(now) + 20);
2125
+ return false;
2126
+ }
852
2127
  const autoApproveActive = adapterStatus?.status === 'waiting_approval' && this.shouldAutoApprove();
853
2128
  // Guard re-entry: onStatusChange/getState can observe the same modal multiple
854
2129
  // times while the PTY absorbs the approval key. Without this flag, repeated
855
2130
  // snapshots would write stray keys into the input once the modal dismisses.
856
- if (autoApproveActive && !this.autoApproveBusy) {
857
- this.autoApproveBusy = true;
858
- if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
859
- this.autoApproveBusyTimer = setTimeout(() => {
860
- this.autoApproveBusy = false;
861
- this.autoApproveBusyTimer = null;
862
- }, 2000);
863
- const modal = adapterStatus.activeModal;
864
- const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(modal?.buttons, this.provider);
865
- this.recordAutoApproval(modal?.message, buttonLabel, now);
866
- setTimeout(() => {
867
- this.adapter.resolveModal(buttonIndex);
868
- }, 0);
2131
+ // However, Claude Code can present a second approval immediately after the
2132
+ // first. Resolve a changed modal signature even while the previous write is
2133
+ // still inside the short busy window.
2134
+ if (!autoApproveActive) {
2135
+ this.lastAutoApprovalSignature = '';
2136
+ // Hysteresis: if a settle gate is mid-progress, a momentary
2137
+ // status!=waiting_approval blip (a generating flip while the same
2138
+ // modal's button block is still on screen) must NOT wipe the settle
2139
+ // clock otherwise the modal→generating→modal flap restarts the
2140
+ // 600ms window every time and auto-approve never fires. Keep the
2141
+ // gate warm for AUTO_APPROVE_GATE_HYSTERESIS_MS; re-arm a timer so
2142
+ // that if the modal does NOT come back the gate is cleared on the
2143
+ // re-check (a genuine resolution → idle frees the gate normally).
2144
+ if (this.pendingAutoApprovalSince) {
2145
+ if (!this.autoApproveInactiveSince) this.autoApproveInactiveSince = now;
2146
+ const goneForMs = now - this.autoApproveInactiveSince;
2147
+ // AUTOAPPROVE-FLAP-RECUR (Fix B): a delegated-worker flap cycles the
2148
+ // FULL waiting_approval → busy → waiting_approval state on a
2149
+ // multi-second period, outrunning the tight default hysteresis and
2150
+ // wiping the settle clock before 600ms ever accumulates. For an
2151
+ // active worker mask episode the continuity window is widened (still
2152
+ // capped by AUTO_APPROVE_MASK_STALL_MS) so the settle clock survives
2153
+ // the busy phase and the returning approval keeps accruing settle time.
2154
+ const continuityMs = this.autoApproveContinuityWindowMs();
2155
+ if (goneForMs < continuityMs) {
2156
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2157
+ this.autoApproveSettleTimer = setTimeout(() => {
2158
+ this.autoApproveSettleTimer = null;
2159
+ this.recheckAutoApproveSettled();
2160
+ }, continuityMs - goneForMs + 20);
2161
+ return autoApproveActive;
2162
+ }
2163
+ }
2164
+ // Clear the settle gate so the next approval starts its own quiet
2165
+ // window from scratch (a stale timestamp would let it fire instantly).
2166
+ this.pendingAutoApprovalSignature = '';
2167
+ this.pendingAutoApprovalSince = 0;
2168
+ this.autoApproveInactiveSince = 0;
2169
+ // Modal has genuinely been gone past the hysteresis window → the episode ended;
2170
+ // end the mask episode too (a later approval starts a fresh stall clock).
2171
+ this.autoApproveMaskSince = 0;
2172
+ this.stalledApprovalNudgeEpisode = 0;
2173
+ this.autoApproveLastModalSeenAt = 0;
2174
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
2175
+ return autoApproveActive;
2176
+ }
2177
+ // Active approval observed — reset the inactivity tracker so a later
2178
+ // blip starts its hysteresis window fresh.
2179
+ this.autoApproveInactiveSince = 0;
2180
+ // STATUS-MISMATCH: start (or keep) the mask-stall clock for this episode. Set ONLY
2181
+ // when zero so it survives modal-signature changes and hysteresis blips — it measures
2182
+ // the true age of the unresolved auto-approve, not the per-signature settle window.
2183
+ if (!this.autoApproveMaskSince) this.autoApproveMaskSince = now;
2184
+ // NOTIF-APPROVAL-MASKED (Q1b): once this episode has stalled past the mask threshold,
2185
+ // surface the raw waiting_approval to the mesh coordinator (decoupled from the dashboard
2186
+ // mask). Placed on the active-approval path here — the single choke point that owns the
2187
+ // mask-stall clock and is re-driven throughout a silent stall (getState heartbeat,
2188
+ // detectStatusTransition, recheckAutoApproveSettled). No-op until the stall threshold trips.
2189
+ this.maybeEmitStalledApprovalNudge(adapterStatus, now);
2190
+ const modal = adapterStatus.activeModal;
2191
+ // (fix) Do not auto-approve when no concrete modal/buttons are present.
2192
+ // Claude TUI flaps between paints; without this guard adapterStatus
2193
+ // could report status=waiting_approval with activeModal=null (or with
2194
+ // an empty buttons array briefly) and we'd still call
2195
+ // resolveModal(-1) — which used to type "1" into the prompt
2196
+ // repeatedly. Skip until a real modal is captured.
2197
+ const buttons = Array.isArray(modal?.buttons)
2198
+ ? modal.buttons.map((b: any) => String(b || '').trim()).filter(Boolean)
2199
+ : [];
2200
+ if (!modal || buttons.length === 0) {
2201
+ // AUTOAPPROVE-FLAP-RECUR (Fix A): the button block momentarily scrolled
2202
+ // out of the captured frame (status is still waiting_approval — we are
2203
+ // on the active path). Do NOT tear the settle gate down on this frame:
2204
+ // if a concrete modal was captured within the continuity window and a
2205
+ // settle gate is in progress, this is a short scroll-out blip — keep the
2206
+ // gate warm against the last-captured signature and arm a re-check so a
2207
+ // silent PTY still re-drives the decision when the buttons repaint. Only
2208
+ // once the modal has stayed empty PAST the continuity window is it a
2209
+ // genuine close, and the gate is cleared here so a later approval
2210
+ // re-settles from scratch (never fires on a stale timestamp).
2211
+ const blipForMs = this.autoApproveLastModalSeenAt ? now - this.autoApproveLastModalSeenAt : Infinity;
2212
+ if (this.pendingAutoApprovalSince && blipForMs < this.autoApproveContinuityWindowMs()) {
2213
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2214
+ this.autoApproveSettleTimer = setTimeout(() => {
2215
+ this.autoApproveSettleTimer = null;
2216
+ this.recheckAutoApproveSettled();
2217
+ }, this.autoApproveContinuityWindowMs() - blipForMs + 20);
2218
+ return autoApproveActive;
2219
+ }
2220
+ if (blipForMs >= this.autoApproveContinuityWindowMs()) {
2221
+ // Buttons empty continuously past the window → the modal genuinely
2222
+ // closed (or never captured). Reset the per-signature settle gate so
2223
+ // a later approval re-settles cleanly. The mask-stall clock keeps
2224
+ // running underneath so a never-captured worker modal still surfaces
2225
+ // to the coordinator within AUTO_APPROVE_MASK_STALL_MS.
2226
+ this.pendingAutoApprovalSignature = '';
2227
+ this.pendingAutoApprovalSince = 0;
2228
+ }
2229
+ return autoApproveActive;
2230
+ }
2231
+ // Concrete modal captured this frame — mark the last-good-modal timestamp so
2232
+ // a subsequent scroll-out blip (buttons.length===0) can be told apart from a
2233
+ // genuine close by how long it persists (Fix A above).
2234
+ this.autoApproveLastModalSeenAt = now;
2235
+ // Picker/confirm exclusion (provider-common). A /model or /mode picker is
2236
+ // surfaced with status=waiting_approval so the dashboard shows it, but it
2237
+ // has no "correct" answer to auto-pick — blindly selecting the first
2238
+ // option silently switches the model (the "always Opus, before I even
2239
+ // choose" bug). Two independent gates, BOTH must pass to fire:
2240
+ //
2241
+ // (1) modal_kind — the spec/FSM tells us this is an 'approval' modal,
2242
+ // not a 'picker'/'confirm'. A modal whose kind is unknown (legacy
2243
+ // adapter, or a spec that predates modal_kind) reads as 'approval'
2244
+ // so genuine approvals keep auto-approving; only an explicit
2245
+ // 'picker'/'confirm' is excluded here.
2246
+ // (2) structural anchor — a real approval offers an affirmative AND a
2247
+ // decline option (pickApprovalButton finds a positive that isn't a
2248
+ // decline, and hasNegativeApprovalOption confirms a No/Cancel/Deny
2249
+ // is present). A model picker ("1. Default 2. Opus 3. Sonnet")
2250
+ // has no decline, so even an un-migrated picker is caught here.
2251
+ //
2252
+ // Mirrors the SDK v1 detect-status approval heuristic (detect-status.ts).
2253
+ const modalKind = typeof modal?.kind === 'string' ? modal.kind : 'approval';
2254
+ if (modalKind !== 'approval') {
2255
+ // Picker/confirm — leave it for the user; keep the modal surfaced.
2256
+ return autoApproveActive;
2257
+ }
2258
+ const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(buttons, this.provider);
2259
+ // Structural decline anchor. A real approval offers BOTH an affirmative
2260
+ // and a decline — but on a TALL Write/Edit diff the trailing "3. No"
2261
+ // scrolls off the captured frame, leaving only "1. Yes" + "2. Yes, allow
2262
+ // … this session" so hasNegativeApprovalOption reads false (#137). A
2263
+ // scoped grant-affirmative ("Yes, allow … during this session" / "…don't
2264
+ // ask again") ONLY appears in a genuine consent modal (never a picker),
2265
+ // so it stands in for the off-frame decline as a reliable second anchor.
2266
+ // Conservative by construction: a picker without a grant-scope option
2267
+ // still bails here, and the fire below still picks the plain allow-once
2268
+ // "Yes" via pickApprovalButton, not the broader grant.
2269
+ const hasReliableConsentAnchor = hasNegativeApprovalOption(buttons)
2270
+ || hasReliableApprovalAffirmative(buttons);
2271
+ if (buttonIndex < 0 || !hasReliableConsentAnchor) {
2272
+ // No affirmative matched, or no decline / reliable grant option present
2273
+ // (→ not a real consent prompt, e.g. a picker that slipped past the
2274
+ // kind gate). Surface the modal so the user decides; never pick blindly.
2275
+ return autoApproveActive;
2276
+ }
2277
+ // Modal *identity* signature — the question plus the STABLE affirmative
2278
+ // anchor only, NO volatile counters and NO raw button set. This is what
2279
+ // the settle gate tracks: the FSM bumps approvalEntrySeq on every fresh
2280
+ // waiting_approval entry, and a modal→generating→modal flap (the question
2281
+ // line scrolled out of the captured frame while the button block stays)
2282
+ // re-enters and bumps it again. Folding that seq into the settle signature
2283
+ // made the 600ms settle clock restart on every flap, so the modal never
2284
+ // stayed stable long enough to fire — the gate was never satisfied.
2285
+ // Identity excludes the seq so seq flap of the SAME modal keeps one clock.
2286
+ //
2287
+ // The raw button set is also excluded: on a TALL Write/Edit diff claude's
2288
+ // TUI repaints the button block 3↔5↔none between frames (buttons scroll in
2289
+ // and out of the captured region), which flipped both buttons.join('|') and
2290
+ // the positional buttonIndex every frame → signature flap → the settle
2291
+ // clock reset 4–9s and only mask-stalled episodes leaked to the coordinator
2292
+ // (AUTOAPPROVE-SETTLE-FLAP). The affirmative the auto-approve will actually
2293
+ // press is the invariant across those repaints, so we anchor on its
2294
+ // NORMALIZED label (numbers/bullets/punctuation stripped, so "1. Yes" and
2295
+ // "3. Yes" collapse to "yes"). Message + affirmative label uniquely
2296
+ // identifies the consent question without tracking the volatile button
2297
+ // positions.
2298
+ const affirmativeAnchor = normalizeApprovalLabel(buttonLabel);
2299
+ const modalSignature = approvalModalSignature(modal?.message, affirmativeAnchor);
2300
+ // Busy-window re-entry guard still needs the seq: two DISTINCT
2301
+ // back-to-back approvals can carry identical message/buttons (common
2302
+ // with claude-cli). Without the seq their busy signatures collide and
2303
+ // the 5s busy-window guard below would swallow the second auto-approve,
2304
+ // leaving it stuck. The seq is bumped by the FSM on every fresh
2305
+ // waiting_approval entry, so a new approval always yields a new busy
2306
+ // signature and fires through.
2307
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2308
+ ? adapterStatus.approvalEntrySeq
2309
+ : 0;
2310
+ const busySignature = `${approvalEntrySeq}::${modalSignature}`;
2311
+ // Already fired for this exact modal entry and still inside the busy
2312
+ // window — nothing to do (re-entry guard for repeated snapshots of one
2313
+ // modal).
2314
+ if (this.autoApproveBusy && busySignature === this.lastAutoApprovalSignature) {
2315
+ return autoApproveActive;
2316
+ }
2317
+
2318
+ // Settle gate: only fire once this modal identity has been stable for
2319
+ // AUTO_APPROVE_SETTLE_MS. A still-streaming prompt mutates its
2320
+ // message/buttons each frame → new identity → clock restarts, so we
2321
+ // never approve a half-rendered prompt (the "resolves too fast" bug).
2322
+ if (modalSignature !== this.pendingAutoApprovalSignature) {
2323
+ this.pendingAutoApprovalSignature = modalSignature;
2324
+ this.pendingAutoApprovalSince = now;
869
2325
  }
2326
+ const settledForMs = now - this.pendingAutoApprovalSince;
2327
+ if (settledForMs < CliProviderInstance.AUTO_APPROVE_SETTLE_MS) {
2328
+ // Not yet settled. Arm a timer to re-check after the remaining quiet
2329
+ // window — the PTY may go silent once the prompt finishes painting,
2330
+ // so there is no guaranteed status-change frame to re-drive us.
2331
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2332
+ this.autoApproveSettleTimer = setTimeout(() => {
2333
+ this.autoApproveSettleTimer = null;
2334
+ this.recheckAutoApproveSettled();
2335
+ }, CliProviderInstance.AUTO_APPROVE_SETTLE_MS - settledForMs + 20);
2336
+ return autoApproveActive;
2337
+ }
2338
+
2339
+ // Settled — fire the approve key.
2340
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
2341
+ this.autoApproveBusy = true;
2342
+ this.lastAutoApprovalSignature = busySignature;
2343
+ this.pendingAutoApprovalSignature = '';
2344
+ this.pendingAutoApprovalSince = 0;
2345
+ this.autoApproveInactiveSince = 0;
2346
+ // Fired (resolveModal in flight) — the episode resolved; end the mask-stall clock.
2347
+ this.autoApproveMaskSince = 0;
2348
+ this.stalledApprovalNudgeEpisode = 0;
2349
+ this.autoApproveLastModalSeenAt = 0;
2350
+ if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
2351
+ this.autoApproveBusyTimer = setTimeout(() => {
2352
+ this.autoApproveBusy = false;
2353
+ this.autoApproveBusyTimer = null;
2354
+ this.lastAutoApprovalSignature = '';
2355
+ }, 5000);
2356
+ this.recordAutoApproval(modal?.message, buttonLabel, now);
2357
+ setTimeout(() => {
2358
+ this.adapter.resolveModal(buttonIndex);
2359
+ }, 0);
870
2360
  return autoApproveActive;
871
2361
  }
872
2362
 
2363
+ /**
2364
+ * Re-drive the auto-approve check after the settle quiet window elapses.
2365
+ * The PTY may have gone silent once the approval prompt finished painting,
2366
+ * so no status-change frame is guaranteed to re-enter maybeAutoApproveStatus
2367
+ * — this timer-driven re-check picks up the now-settled modal and fires.
2368
+ * Deliberately lighter than detectStatusTransition(): it only re-evaluates
2369
+ * the approval decision; the next real PTY frame refreshes visible status.
2370
+ */
2371
+ private recheckAutoApproveSettled(): void {
2372
+ try {
2373
+ // APPROVAL Defect-C (auto-approve gap): re-probe with a LIVE parse, not the cached
2374
+ // engine snapshot. This timer is the ONLY re-drive when the PTY goes silent after the
2375
+ // approval prompt finishes painting (its whole reason to exist) — but with
2376
+ // allowParse:false it read only engine.activeModal, which the engine's per-frame settle
2377
+ // pass can leave null/stale when the modal arrived between writes. The re-check then saw
2378
+ // no modal and never fired, so the delegated worker's transient/quiet approval was missed
2379
+ // and the coordinator had to step in with a manual mesh_approve. allowParse:true makes
2380
+ // getStatus re-run runDetectStatus/runParseApproval on the current screen buffer (the same
2381
+ // live re-probe the coordinator's resolveAction path uses), recovering the modal so
2382
+ // auto-approve fires on its own. The half-rendered-frame guard (buttons.length===0) and
2383
+ // the settle gate in maybeAutoApproveStatus still protect against firing on a partial modal.
2384
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
2385
+ this.maybeAutoApproveStatus(adapterStatus, Date.now());
2386
+ } catch { /* adapter gone / transient — next frame retries */ }
2387
+ }
2388
+
2389
+ /**
2390
+ * Emit the queue-claim agent:ready event at most once per session. Both the
2391
+ * boot-time starting→idle one-shot and the fsmReadySeen re-arm call this; the
2392
+ * agentReadyEmitted guard ensures the second caller is a no-op so a worker is
2393
+ * never claimed twice and a queued task is never double-dispatched.
2394
+ */
2395
+ private emitAgentReadyOnce(chatTitle: string, now: number): void {
2396
+ if (this.agentReadyEmitted) return;
2397
+ this.agentReadyEmitted = true;
2398
+ this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2399
+ }
2400
+
2401
+ /**
2402
+ * GENERATING-BOUNDARY synthetic emit for a first turn that started AND finished
2403
+ * inside the startup-grace window without the FSM ever observing a 'generating'
2404
+ * frame (an unobservably-fast turn). Synthesizes the agent:generating_started +
2405
+ * agent:generating_completed pair so the mesh coordinator learns the worker went
2406
+ * idle. Returns true iff it synthesized.
2407
+ *
2408
+ * Two callers share this defense line:
2409
+ * - 'startup_grace_fast_collapse' — the starting→idle transition (the FSM whose
2410
+ * spec lacks/hadn't-synced the starting→busy edge collapses starting→idle
2411
+ * directly, with no intervening 'generating' frame).
2412
+ * - 'startup_grace_idle_turn_collapse' — the idle→idle no-status-change poll
2413
+ * (the launch settle already drained starting→idle BEFORE the first turn, so
2414
+ * the turn runs+completes while status stays 'idle' the whole time and
2415
+ * detectStatusTransition never re-enters its change block — the live rc.403
2416
+ * Probe1 miss).
2417
+ *
2418
+ * False-positive safety (must NOT fire on a benign boot): currentTurnTaskId is
2419
+ * set ONLY by onTurnStarted (a real turn STARTED this boot) and persists past
2420
+ * completion, so it excludes a true idle boot (null) and a queued-pending first
2421
+ * turn that only runs after grace (onTurnStarted not yet called → null).
2422
+ * !hasAdapterPendingResponse() excludes a turn still mid-flight. generating
2423
+ * never armed (generatingStartedAt===0 && !generatingDebouncePending) means the
2424
+ * whole idle→busy→idle never happened for this turn. The once-per-turn guard
2425
+ * (fastCollapseSynthesizedTaskId) keeps the re-polled idle-stayed caller from
2426
+ * re-emitting every poll.
2427
+ */
2428
+ private maybeSynthesizeStartupGraceCollapse(
2429
+ chatTitle: string,
2430
+ now: number,
2431
+ reason: 'startup_grace_fast_collapse' | 'startup_grace_idle_turn_collapse',
2432
+ ): boolean {
2433
+ const startedTurnTaskId = typeof (this.adapter as any)?.currentTurnTaskId === 'string'
2434
+ && (this.adapter as any).currentTurnTaskId.trim()
2435
+ ? (this.adapter as any).currentTurnTaskId as string
2436
+ : undefined;
2437
+ const fastCollapsed = !!startedTurnTaskId
2438
+ && !this.hasAdapterPendingResponse()
2439
+ && !this.generatingStartedAt
2440
+ && !this.generatingDebouncePending;
2441
+ if (!fastCollapsed) return false;
2442
+ // Once-per-turn: the idle-stayed caller re-polls steadily while the session
2443
+ // sits idle; without this guard it would re-emit the pair every poll.
2444
+ if (this.fastCollapseSynthesizedTaskId === startedTurnTaskId) return false;
2445
+
2446
+ let fcFinalSummary: string | undefined;
2447
+ let fcEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2448
+ try {
2449
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2450
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2451
+ fcEvidenceSource = evidence.source;
2452
+ fcFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2453
+ } catch { /* best-effort */ }
2454
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true || fcEvidenceSource === 'external-native') && !fcFinalSummary;
2455
+ // Mirror the short-generating idle path's suppression: a provider that
2456
+ // requires a final assistant (or external-native history) with NO confirmed
2457
+ // summary and NO mesh context emits nothing — the session is idle with no
2458
+ // confirmed turn, matching startup-blip semantics. With mesh context we still
2459
+ // emit so the coordinator can apply its own timeout/retry logic. Left UNMARKED
2460
+ // so a later poll can retry once the transcript's final assistant lands.
2461
+ const hasMeshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
2462
+ if (missingEvidence && !hasMeshContext) {
2463
+ LOG.info('CLI', `[${this.type}] ${reason} suppressed: missing final assistant evidence, no mesh context (source=${fcEvidenceSource})`);
2464
+ return false;
2465
+ }
2466
+ // Mark BEFORE emitting so a re-entrant poll cannot double-fire.
2467
+ this.fastCollapseSynthesizedTaskId = startedTurnTaskId;
2468
+ LOG.info('CLI', `[${this.type}] ${reason}: synthesizing started+completed (taskId=${startedTurnTaskId} source=${fcEvidenceSource} hadFinalSummary=${!!fcFinalSummary})`);
2469
+ // Retroactive started so the started→completed pair (and the chat bubble) is
2470
+ // well-formed; pushEvent stamps the per-turn taskId for CANON-B ack.
2471
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now });
2472
+ if (this.isMeshWorkerSession()) {
2473
+ traceMeshEventStage('fired', this.meshTraceCtx(), `${reason} (source=${fcEvidenceSource})`);
2474
+ }
2475
+ // EARLYNOTIFY-GATEBYPASS (c): a startup-grace fast-collapse never OBSERVED the turn's
2476
+ // generating phase — its evidence is a plain transcript tail, never a self-attributing
2477
+ // final_summary_json — so this synth is TENTATIVE by default. Mark it WEAK
2478
+ // (evidenceLevel:'weak') so buildPendingEventFingerprint keys it `…::weak` and any later
2479
+ // genuine agent:generating_completed for the same task can still surface (CANON-B). The
2480
+ // stronger missing_final_assistant marker is preserved when there is also no summary.
2481
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('synth-fire', {
2482
+ path: 'startup_grace_fast_collapse',
2483
+ reason,
2484
+ evidenceSource: fcEvidenceSource,
2485
+ hadFinalSummary: !!fcFinalSummary,
2486
+ missingEvidence,
2487
+ evidenceLevel: 'weak',
2488
+ });
2489
+ this.emitGeneratingCompleted({
2490
+ chatTitle,
2491
+ duration: 0,
2492
+ timestamp: now,
2493
+ finalSummary: fcFinalSummary,
2494
+ evidenceLevel: 'weak',
2495
+ completionDiagnostic: {
2496
+ reason,
2497
+ finalAssistantEvidenceSource: fcEvidenceSource,
2498
+ ...(missingEvidence ? { blockReason: 'missing_final_assistant' } : {}),
2499
+ },
2500
+ });
2501
+ return true;
2502
+ }
2503
+
873
2504
  private detectStatusTransition(): void {
874
2505
  const now = Date.now();
875
2506
  // Status-change handling is a hot path: PTY output can fire it many times
876
2507
  // during long-running CLI sessions. Keep this path on adapter-owned light
877
2508
  // state only; rich provider parsing is reserved for getState/read_chat.
878
2509
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
2510
+ const adapterProviderSessionId = normalizeProviderSessionId(
2511
+ this.provider,
2512
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
2513
+ );
2514
+ if (adapterProviderSessionId) {
2515
+ this.promoteProviderSessionId(adapterProviderSessionId);
2516
+ }
879
2517
  const parsedStatus = null;
880
2518
  const rawStatus = adapterStatus.status;
881
2519
  const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, now);
882
- const newStatus = autoApproveActive ? 'generating' : rawStatus;
883
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
2520
+ // During the autoApproveBusy window (2s after firing approval key), the PTY
2521
+ // can briefly report 'idle' before the next generating phase starts. Treat that
2522
+ // transient idle as 'generating' to suppress a spurious agent:generating_completed
2523
+ // push notification. The adapter's status is otherwise authoritative — native
2524
+ // transcript shape does NOT override the FSM's busy/idle decision.
2525
+ const autoApproveHoldIdle = this.autoApproveBusy && rawStatus === 'idle';
2526
+ const newStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : rawStatus;
2527
+ const dirName = workingDirBasename(this.workingDir);
884
2528
  const chatTitle = `${this.provider.name} · ${dirName}`;
885
2529
  const partial = this.adapter.getPartialResponse();
2530
+ // Liveness fingerprint for the no-progress watchdog. The parsed
2531
+ // assistant buffer (`partial`) alone goes static while a tool/build runs
2532
+ // — the assistant emits no tokens even though the PTY is actively
2533
+ // printing tool output — which made the watchdog false-fire a "stuck"
2534
+ // alert mid-turn. Fold in the adapter's raw-activity timestamps so any
2535
+ // visible terminal progress (lastScreenChangeAt) or raw PTY byte
2536
+ // (lastOutputAt) keeps the fingerprint moving. The watchdog then only
2537
+ // survives a genuine stall where nothing at all is happening.
886
2538
  const progressFingerprint = newStatus === 'generating'
887
- ? `${partial || ''}`.slice(-2000)
2539
+ ? `${`${partial || ''}`.slice(-2000)}::scr=${adapterStatus.lastScreenChangeAt ?? 0}::out=${adapterStatus.lastOutputAt ?? 0}`
888
2540
  : undefined;
889
2541
 
890
2542
  const previousStatus = this.lastStatus;
891
2543
  if (newStatus !== this.lastStatus) {
892
2544
  LOG.info('CLI', `[${this.type}] status: ${this.lastStatus} → ${newStatus}`);
893
- if (this.lastStatus === 'idle' && newStatus === 'generating') {
2545
+ // COMPLETION-EARLYNOTIFY: snapshot every FSM status transition (the arm/fire/cancel
2546
+ // decisions downstream all hang off these edges). Guarded so production pays only a
2547
+ // boolean check; payload carries the visibility/auto-approve flags and the continuity
2548
+ // clocks (busyEpoch / lastOutputAt / lastScreenChangeAt) that the completion gate reads.
2549
+ if (this.fsmTraceOn()) this.recordFsmTransitionTrace({
2550
+ from: this.lastStatus,
2551
+ to: newStatus,
2552
+ rawStatus,
2553
+ autoApproveActive,
2554
+ autoApproveHoldIdle,
2555
+ autoApproveBusy: this.autoApproveBusy,
2556
+ hasPending: this.hasAdapterPendingResponse(),
2557
+ busyEpoch: this.busyEpoch,
2558
+ lastOutputAt: typeof adapterStatus?.lastOutputAt === 'number' ? adapterStatus.lastOutputAt : null,
2559
+ lastScreenChangeAt: typeof adapterStatus?.lastScreenChangeAt === 'number' ? adapterStatus.lastScreenChangeAt : null,
2560
+ });
2561
+ // GENERATING-MISSING (win32 fresh-worktree first-turn): a freshly-launched session
2562
+ // is in 'starting' until its startup-grace settles to idle. When the FIRST inject
2563
+ // lands inside that grace window, the adapter can report status DIRECTLY
2564
+ // starting → generating without an intervening 'idle' frame for
2565
+ // detectStatusTransition() to observe. Previously only the idle→generating arm
2566
+ // armed the bookkeeping, so a starting→generating frame fell straight through to the
2567
+ // bare `this.lastStatus = newStatus` update: generatingStartedAt stayed 0 and no
2568
+ // generating_started was queued. The fast turn's generating→idle completion was then
2569
+ // suppressed by the startup-blip guard below (generatingStartedAt===0 &&
2570
+ // !generatingDebouncePending) — so NO generating_started AND NO generating_completed
2571
+ // ever fired and the mesh coordinator never learned the worker went idle.
2572
+ //
2573
+ // We extend the idle→generating arm to also fire on starting→generating, BUT ONLY
2574
+ // when a real turn is in flight. The adapter script can also report 'generating' from
2575
+ // pure startup PTY noise (no task dispatched) — antigravity/codex/hermes-cli all
2576
+ // exercise that benign starting→generating→idle blip, which must NOT emit a
2577
+ // completion (see "startup-phase spurious completion suppression" tests).
2578
+ // hasAdapterPendingResponse() is the discriminator: a genuine inject sets the
2579
+ // adapter's isWaitingForResponse / currentTurnScope (or leaves a partial response),
2580
+ // whereas startup repaint noise leaves all of them empty. So an armed
2581
+ // starting→generating means "the worker actually started its first turn", and a
2582
+ // bare one stays a suppressed blip via the existing fall-through.
2583
+ const startingToGeneratingWithActiveTurn = this.lastStatus === 'starting'
2584
+ && newStatus === 'generating'
2585
+ && this.hasAdapterPendingResponse();
2586
+ if (((this.lastStatus === 'idle' && newStatus === 'generating') || startingToGeneratingWithActiveTurn)) {
2587
+ // If a completion event is already pending and the turn has ended
2588
+ // (generatingStartedAt===0), the PTY is painting its prompt area
2589
+ // after completing. Ignore this blip — do not cancel the pending
2590
+ // completion and do not advance lastStatus to generating. (On a true
2591
+ // starting→generating the session is fresh: completedDebouncePending is
2592
+ // null, so this blip guard is a no-op and we arm normally below.)
2593
+ if (this.completedDebouncePending && this.generatingStartedAt === 0) {
2594
+ LOG.debug('CLI', `[${this.type}] ignoring post-completion PTY generating blip (generatingStartedAt=0)`);
2595
+ return;
2596
+ }
894
2597
  this.suppressIdleHistoryReplay = false;
895
2598
  // Cancel any pending completed event (multi-step: idle→generating resume)
896
2599
  if (this.completedDebouncePending) {
897
- LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating)`);
2600
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating) generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse}`);
898
2601
  if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
899
2602
  this.completedDebouncePending = null;
900
2603
  }
901
2604
 
902
2605
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2606
+ // A genuinely new turn is underway — drop the previous turn's cached
2607
+ // final-summary so the dashboard does not keep showing the old answer
2608
+ // as "done" while the new turn generates. Re-populated when this turn
2609
+ // completes.
2610
+ this.lastCompletionSummary = null;
2611
+ // FALSE-IDLE continuity: entering a busy phase invalidates any
2612
+ // completedDebouncePending armed earlier in this settle window.
2613
+ this.busyEpoch++;
903
2614
  // Defer the generating_started event — if idle comes back within 3s,
904
2615
  // the whole started→completed pair was a false positive from PTY noise
905
2616
  if (this.generatingDebounceTimer) clearTimeout(this.generatingDebounceTimer);
@@ -924,14 +2635,38 @@ export class CliProviderInstance implements ProviderInstance {
924
2635
  this.completedDebouncePending = null;
925
2636
 
926
2637
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2638
+ // FALSE-IDLE continuity: waiting_approval is a busy phase (the agent
2639
+ // resumes into it), so bump the epoch too — the completedDebouncePending
2640
+ // cancel above covers the currently-armed pending, and the epoch covers
2641
+ // a pending that re-arms and flushes across this same valley.
2642
+ this.busyEpoch++;
927
2643
  const modal = adapterStatus.activeModal;
928
2644
  LOG.info('CLI', `[${this.type}] approval modal: "${modal?.message?.slice(0, 80) ?? 'none'}"`);
929
- // Only push event if not already in waiting_approval (prevent flood from rapid cycles)
930
- const approvalCooldown = 5000;
931
- if (this.lastStatus !== 'waiting_approval' && (!this.lastApprovalEventAt || now - this.lastApprovalEventAt > approvalCooldown)) {
932
- this.lastApprovalEventAt = now;
2645
+ // Include the FSM's approval entry seq, mirroring the auto-approve
2646
+ // path (maybeAutoApproveStatus) and resolveModal's sameEntryReResolve
2647
+ // guard. Two distinct back-to-back approvals can carry identical
2648
+ // message/buttons (very common with claude-cli's "Allow Bash
2649
+ // command?"). Without the seq their fingerprints collide and the dedup
2650
+ // below silently drops the second waiting_approval event — it is never
2651
+ // emitted, so it cannot even land in the pending inbox for a later
2652
+ // read_chat reconcile to recover. The seq is bumped by the FSM on every
2653
+ // fresh waiting_approval entry, so a new approval always yields a new
2654
+ // fingerprint and emits.
2655
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2656
+ ? adapterStatus.approvalEntrySeq
2657
+ : 0;
2658
+ const approvalFingerprint = JSON.stringify({
2659
+ message: typeof modal?.message === 'string' ? modal.message.trim() : '',
2660
+ buttons: Array.isArray(modal?.buttons) ? modal.buttons.map((button: unknown) => String(button).trim()) : [],
2661
+ seq: approvalEntrySeq,
2662
+ });
2663
+ // PTY redraws repeat the same modal content; fingerprint dedup prevents duplicate events.
2664
+ // Do NOT also gate on lastStatus: consecutive approvals can arrive waiting_approval→waiting_approval
2665
+ // (e.g. antigravity-cli resolves one prompt and immediately shows the next) and would be silently dropped.
2666
+ if (approvalFingerprint !== this.lastApprovalEventFingerprint) {
2667
+ this.lastApprovalEventFingerprint = approvalFingerprint;
933
2668
  this.appendRuntimeSystemMessage(
934
- this.formatApprovalRequestMessage(modal?.message, modal?.buttons),
2669
+ formatApprovalRequestMessage(modal?.message, modal?.buttons),
935
2670
  `approval_request:${now}`,
936
2671
  now,
937
2672
  );
@@ -941,22 +2676,286 @@ export class CliProviderInstance implements ProviderInstance {
941
2676
  modalButtons: modal?.buttons,
942
2677
  });
943
2678
  }
2679
+ } else if (newStatus === 'generating' && this.lastStatus === 'waiting_approval') {
2680
+ // Approval resolved and the agent resumed work. Defense-in-depth:
2681
+ // clear the approval emit fingerprint here too (not only on
2682
+ // completion at scheduleCompletedDebounceFlush). A subsequent
2683
+ // waiting_approval with the same modal content as the one just
2684
+ // resolved would otherwise collide with the stale fingerprint and be
2685
+ // dropped. The seq in the fingerprint already separates entries; this
2686
+ // reset is a belt-and-suspenders guard for the re-entry case.
2687
+ this.lastApprovalEventFingerprint = '';
944
2688
  } else if (newStatus === 'idle' && (this.lastStatus === 'generating' || this.lastStatus === 'waiting_approval')) {
945
2689
  const duration = this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : 0;
946
- // If debounce still pending (generating lasted < 1s), cancel both events
2690
+ // Guard: if generatingStartedAt===0 and no debounce pending, the generating phase
2691
+ // was entered from 'starting' state (startup PTY noise), not from a real idle→generating
2692
+ // task dispatch. The idle→generating handler is the only code path that sets
2693
+ // generatingStartedAt and generatingDebouncePending, so both being absent means no
2694
+ // task was ever dispatched. Suppress the spurious completion event and fall through
2695
+ // to a simple lastStatus update.
2696
+ if (!this.generatingStartedAt && !this.generatingDebouncePending) {
2697
+ LOG.debug('CLI', `[${this.type}] suppressed startup-phase generating→idle blip (generatingStartedAt=0, no debounce pending)`);
2698
+ } else
2699
+ // If debounce still pending (generating lasted < 1s), cancel both UI events.
2700
+ // Still emit agent:generating_completed so mesh orchestration can record
2701
+ // task_completed for direct dispatches that complete faster than the debounce.
947
2702
  if (this.generatingDebouncePending) {
948
- LOG.info('CLI', `[${this.type}] suppressed short generating (${now - this.generatingStartedAt}ms)`);
2703
+ // NOTIF Defect-2a: shortDurationMs is the REPORTED turn duration, so it must be
2704
+ // measured from the IMMUTABLE turn start — not generatingStartedAt, which is
2705
+ // reset to 0 on every mid-turn waiting_approval/idle blip (see :1864/1885/2397/
2706
+ // 2503/2521) and re-armed on the next →generating, so a long turn that blipped
2707
+ // would measure only the final 1.5-2.5s sliver. engine.currentTurnStartedAt is
2708
+ // stamped once at onTurnStarted and persists past mid-turn blips until the next
2709
+ // turn starts, so it captures the true turn length. generatingStartedAt remains
2710
+ // the fallback (and the debounce itself stays a pure UI-suppression signal,
2711
+ // decoupled from the reported duration).
2712
+ const { durationMs: shortDurationMs, anchor: durationAnchor } = computeTurnAnchoredDurationMs(
2713
+ (this.adapter as any)?.currentTurnStartedAt,
2714
+ this.generatingStartedAt,
2715
+ now,
2716
+ );
2717
+ LOG.info('CLI', `[${this.type}] suppressed short generating (${shortDurationMs}ms, anchor=${durationAnchor})`);
949
2718
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2719
+ // Emit completion for mesh task association even though the UI generating
2720
+ // started/completed pair is suppressed (too short for visible UI update).
2721
+ let shortFinalSummary: string | undefined;
2722
+ let shortEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2723
+ try {
2724
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2725
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2726
+ shortEvidenceSource = evidence.source;
2727
+ shortFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2728
+ } catch { /* best-effort */ }
2729
+ // If a real response is confirmed, retroactively emit started so the chat
2730
+ // bubble appears even though the debounce suppressed the original event.
2731
+ if (shortFinalSummary) {
2732
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now - shortDurationMs });
2733
+ }
2734
+ // FALSE-IDLE short-gen settle: snapshot the producing turn's start + taskId NOW,
2735
+ // before `generatingStartedAt` is reset below — the settle-arm path (mesh sessions,
2736
+ // see the mesh branch further down) needs the same turn anchor the normal
2737
+ // completedDebounce branch captures, and generatingStartedAt is the fallback for it.
2738
+ const shortEngineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2739
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2740
+ ? (this.adapter as any).currentTurnStartedAt as number
2741
+ : 0;
2742
+ const shortTurnStartedAt = shortEngineTurnStart || this.generatingStartedAt || 0;
2743
+ const shortTaskId = this.completingTurnTaskId();
950
2744
  this.generatingDebouncePending = null;
951
2745
  this.generatingStartedAt = 0;
2746
+ // FALSE-IDLE short-gen: a short-generating completion with NO transcript
2747
+ // backing at all (shortEvidenceSource === 'unavailable': both the screen parse
2748
+ // AND the external-native transcript failed to yield a final assistant) is just
2749
+ // as unproven as an 'external-native' source that returned no final assistant.
2750
+ // Fold 'unavailable' into the missing-evidence predicate so a zero-evidence dip
2751
+ // (the mid-turn point-sample that triggered this whole false-idle bug) is treated
2752
+ // as weak/held, not fired as a genuine completion. A real shortFinalSummary being
2753
+ // present still clears the gate (the !shortFinalSummary guard is unchanged).
2754
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true
2755
+ || shortEvidenceSource === 'external-native'
2756
+ || shortEvidenceSource === 'unavailable') && !shortFinalSummary;
2757
+ if (missingEvidence) {
2758
+ LOG.warn('CLI', `[${this.type}] short completion missing final assistant evidence (source=${shortEvidenceSource})`);
2759
+ }
2760
+ if (this.isAutonomousMeshSession()) {
2761
+ // FALSE-IDLE short-gen settle (the core fix): for an autonomously-progressing
2762
+ // mesh session (delegated worker OR self-coordinator), the short-generating
2763
+ // branch was a POINT-SAMPLE — a single idle read from getStatus({allowParse:false})
2764
+ // that fires the completion INLINE with zero continuity backing. When the worker
2765
+ // is merely mid-turn (a sub-3s dip between two tool calls), this synchronously
2766
+ // emitted a false agent:generating_completed the coordinator can never correct.
2767
+ //
2768
+ // Route it through the SAME settle + continuity machinery as the normal
2769
+ // completedDebounce branch: arm completedDebouncePending capturing busyEpochAtArm
2770
+ // and lastOutputAtArm, then scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS)
2771
+ // so flushCompletedDebounceIfFinalized() re-verifies CONTINUOUS idle before emitting.
2772
+ // A busy re-entry (busyEpoch bump) or new PTY output within the settle window —
2773
+ // exactly what happens when the worker resumes its next tool call — CANCELS the
2774
+ // false completion. Genuine completions (real final assistant) still emit at the
2775
+ // end of the (short, 4s) settle window; missingEvidence flows through the
2776
+ // finalization block (missing_final_assistant → CANON-C weak/held) rather than
2777
+ // being frozen as a genuine inline fire.
2778
+ this.completedDebouncePending = {
2779
+ chatTitle,
2780
+ duration: Math.round(shortDurationMs / 1000),
2781
+ timestamp: now,
2782
+ firstObservedAt: now,
2783
+ // Short-gen enters from generating→idle (or waiting_approval→idle); the
2784
+ // completedDebounce finalization gate treats previousStatus for its
2785
+ // approval-resolution / inter-approval-valley handling. lastStatus is the
2786
+ // status we transitioned FROM here.
2787
+ previousStatus: this.lastStatus,
2788
+ ...(shortTaskId ? { taskId: shortTaskId } : {}),
2789
+ ...(shortTurnStartedAt ? { turnStartedAt: shortTurnStartedAt } : {}),
2790
+ // FALSE-IDLE continuity: same arm-time snapshots as the normal branch so the
2791
+ // flush guard can prove continuous idle across the settle window.
2792
+ busyEpochAtArm: this.busyEpoch,
2793
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2794
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2795
+ : {}),
2796
+ };
2797
+ LOG.info('CLI', `[${this.type}] short-generating routed through settle window (${shortDurationMs}ms, source=${shortEvidenceSource}, missingEvidence=${missingEvidence}) — arming completedDebouncePending instead of inline fire`);
2798
+ // EVTTRACE: now traces the settle ARM (not an inline fire) for mesh sessions,
2799
+ // so logs show the short-gen path deferring to continuity re-check.
2800
+ if (this.isMeshWorkerSession()) {
2801
+ traceMeshEventStage('arm', this.meshTraceCtx(), `short-generating settle-arm (source=${shortEvidenceSource}, missingEvidence=${missingEvidence})`);
2802
+ }
2803
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('arm', {
2804
+ branch: 'short_generating',
2805
+ previousStatus: this.lastStatus,
2806
+ turnStartedAt: shortTurnStartedAt || null,
2807
+ busyEpochAtArm: this.busyEpoch,
2808
+ lastOutputAtArm: typeof adapterStatus?.lastOutputAt === 'number' ? adapterStatus.lastOutputAt : null,
2809
+ flushDelay: NATIVE_HISTORY_MESH_IDLE_SETTLE_MS,
2810
+ evidenceSource: shortEvidenceSource,
2811
+ missingEvidence,
2812
+ hasFinalSummary: !!shortFinalSummary,
2813
+ });
2814
+ this.scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS);
2815
+ } else if (missingEvidence) {
2816
+ // NON-MESH, missing evidence: suppress the completion event entirely (the
2817
+ // original !hasMeshContext suppression). A genuinely non-mesh session has no
2818
+ // coordinator to notify, and firing a completion with no confirmed final
2819
+ // assistant would just surface an empty/unconfirmed turn. Leave
2820
+ // completedDebouncePending null — the session is now idle with no confirmed
2821
+ // turn, matching the startup-blip suppression semantics. (No EvtTrace: not a
2822
+ // mesh session, so nothing routes to a coordinator.)
2823
+ LOG.info('CLI', `[${this.type}] short completion suppressed: missing final assistant evidence, non-mesh session (source=${shortEvidenceSource})`);
2824
+ } else {
2825
+ // NON-MESH interactive fast-path with a CONFIRMED summary: keep the existing
2826
+ // inline fire. The dashboard UX reason for the short path (a fast turn should
2827
+ // surface its completion promptly without a 4s settle) still holds, and a
2828
+ // non-mesh session has no coordinator to be falsely notified — the false-idle
2829
+ // bug being fixed is specifically the mesh worker/coordinator misfire above.
2830
+ this.emitGeneratingCompleted({
2831
+ chatTitle,
2832
+ duration: 0,
2833
+ timestamp: now,
2834
+ finalSummary: shortFinalSummary,
2835
+ completionDiagnostic: {
2836
+ reason: 'short_generating_suppressed',
2837
+ shortDurationMs,
2838
+ finalAssistantEvidenceSource: shortEvidenceSource,
2839
+ },
2840
+ });
2841
+ }
952
2842
  } else {
953
2843
  // Debounce completed, then require the rich transcript path that read_chat
954
2844
  // uses to show an idle turn whose last user-facing message is assistant.
955
- this.completedDebouncePending = { chatTitle, duration, timestamp: now, firstObservedAt: now };
956
- this.scheduleCompletedDebounceFlush(3000);
2845
+ this.completedDebouncePending = {
2846
+ chatTitle,
2847
+ duration,
2848
+ timestamp: now,
2849
+ firstObservedAt: now,
2850
+ previousStatus: this.lastStatus,
2851
+ // ARCH-REFACTOR R1: snapshot the completing turn's taskId NOW (sync),
2852
+ // before any follow-up task's flush can start a new turn and move
2853
+ // engine.currentTurnTaskId.
2854
+ ...(this.completingTurnTaskId() ? { taskId: this.completingTurnTaskId() } : {}),
2855
+ // NOTIF Defect-B: snapshot the producing turn's START instant NOW, for the
2856
+ // same reason as taskId — a follow-up turn moves engine.currentTurnStartedAt.
2857
+ // Prefer the engine's per-turn start (set at onTurnStarted, earliest reliable
2858
+ // anchor) and fall back to generatingStartedAt (when generating was observed).
2859
+ ...((() => {
2860
+ const engineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2861
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2862
+ ? (this.adapter as any).currentTurnStartedAt as number
2863
+ : 0;
2864
+ const turnStartedAt = engineTurnStart || this.generatingStartedAt || 0;
2865
+ return turnStartedAt ? { turnStartedAt } : {};
2866
+ })()),
2867
+ // FALSE-IDLE continuity: snapshot the busy epoch + raw PTY output
2868
+ // clock at arm time so the flush guard can prove the session stayed
2869
+ // continuously idle (no busy re-entry, no new PTY output) through the
2870
+ // settle window rather than merely reading 'idle' once at flush.
2871
+ busyEpochAtArm: this.busyEpoch,
2872
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2873
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2874
+ : {}),
2875
+ };
2876
+ const ownsExternalHistory = !!(this.adapter as any)?.chatMessagesOwnedExternally;
2877
+ // (FALSEIDLE-BGCHILD-a) Native-history providers flush immediately (the
2878
+ // transcript is authoritative). For autonomously-progressing mesh sessions,
2879
+ // give the generating→idle transition a short settle window so a background-child
2880
+ // false idle (quiet after a backgrounded test/command while the parent turn
2881
+ // continues) or an inter-approval auto-approve valley gets caught by the resume
2882
+ // guard in flushCompletedDebounceIfFinalized instead of firing an early completion
2883
+ // the coordinator can never correct.
2884
+ //
2885
+ // (FALSE-IDLE self-coordinator settle) The settle window now covers BOTH mesh
2886
+ // worker sessions AND the coordinator's own claude-cli session (meshCoordinatorFor):
2887
+ // isAutonomousMeshSession(). Previously only isMeshWorkerSession() qualified, so a
2888
+ // self-coordinating daemon (worker + coordinator on the same daemon) ran the
2889
+ // coordinator's own turn at flushDelay=0 — no settle window at all — and the
2890
+ // busyEpoch/lastOutputAt continuity guard, being a flush-time point-check, had no
2891
+ // window in which to observe the ~0.5s auto-approve valley. Its mid-turn
2892
+ // "next-step" sentence was flushed as finalSummary. A genuinely non-mesh session
2893
+ // (neither worker nor self-coordinator) still flushes immediately (delay=0), so
2894
+ // no non-mesh behaviour changes; this only ADDS a settle window (strictly
2895
+ // stricter — the guard can only ever CANCEL a pending flush, never emit more).
2896
+ const meshSettleSession = this.isAutonomousMeshSession();
2897
+ const flushDelay = ownsExternalHistory
2898
+ ? (meshSettleSession ? NATIVE_HISTORY_MESH_IDLE_SETTLE_MS : 0)
2899
+ : 3000;
2900
+ LOG.debug('CLI', `[${this.type}] set completedDebouncePending duration=${duration}s ownsExternalHistory=${ownsExternalHistory} meshSettle=${meshSettleSession} flushDelay=${flushDelay}ms generatingStartedAt=${this.generatingStartedAt}`);
2901
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('arm', {
2902
+ branch: 'normal',
2903
+ previousStatus: this.completedDebouncePending.previousStatus,
2904
+ turnStartedAt: this.completedDebouncePending.turnStartedAt ?? null,
2905
+ busyEpochAtArm: this.completedDebouncePending.busyEpochAtArm ?? null,
2906
+ lastOutputAtArm: this.completedDebouncePending.lastOutputAtArm ?? null,
2907
+ flushDelay,
2908
+ ownsExternalHistory,
2909
+ meshSettle: meshSettleSession,
2910
+ });
2911
+ this.scheduleCompletedDebounceFlush(flushDelay);
957
2912
  }
958
2913
  } else if (newStatus === 'idle' && this.lastStatus === 'starting') {
959
- this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2914
+ this.emitAgentReadyOnce(chatTitle, now);
2915
+ // GENERATING-BOUNDARY (R4c): stamp the collapse moment ONCE so the
2916
+ // idle-stayed window below is anchored on the startup-grace collapse,
2917
+ // not on boot. Set only the first time so a later starting re-entry
2918
+ // cannot slide the window forward.
2919
+ if (this.startupGraceCollapseAt === null) this.startupGraceCollapseAt = now;
2920
+ // GENERATING-BOUNDARY fast-collapse (R4, win32 startup-grace first turn):
2921
+ // a turn dispatched into the startup-grace window can START and FINISH while
2922
+ // the FSM is still in 'starting'. On a daemon whose claude-cli spec has NOT yet
2923
+ // synced the starting→busy edge (the primary cure lives in the spec's
2924
+ // idle→busy.from), the FSM never reaches 'busy'/generating, so
2925
+ // detectStatusTransition observes starting→idle DIRECTLY with no intervening
2926
+ // 'generating' frame. The idle→generating arm — the only path that sets
2927
+ // generatingStartedAt and arms the completion — never fired, so the completing
2928
+ // turn's agent:generating_completed is never emitted and the mesh coordinator
2929
+ // never learns the worker went idle. Synthesize the started+completed pair here.
2930
+ //
2931
+ // Discriminator (false-positive safe — must NOT fire on a benign boot):
2932
+ // adapter.currentTurnTaskId is set ONLY by onTurnStarted (a real turn STARTED
2933
+ // this boot) and persists past completion, so it cleanly separates the three
2934
+ // non-firing cases — a true idle boot (no turn → null), a queued-pending
2935
+ // first turn that only runs AFTER startup-grace drains the composer (onTurnStarted
2936
+ // not yet called → null; it completes normally later via idle→busy→idle), and a
2937
+ // turn STILL running at the 8s mark (hasAdapterPendingResponse() still true →
2938
+ // excluded so we don't fire a premature mid-turn completion; idle→busy self-
2939
+ // corrects once the FSM reaches idle). We fire only when a turn started AND has
2940
+ // already finished: started-this-boot && !still-in-flight.
2941
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_fast_collapse');
2942
+ } else if (newStatus === 'error') {
2943
+ if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2944
+ this.generatingDebouncePending = null;
2945
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
2946
+ this.completedDebouncePending = null;
2947
+ this.errorMessage = adapterStatus.errorMessage || this.errorMessage;
2948
+ this.errorReason = (adapterStatus.errorReason as ProviderErrorReason) || this.errorReason;
2949
+ this.pushEvent({
2950
+ event: 'agent:stopped',
2951
+ chatTitle,
2952
+ timestamp: now,
2953
+ finalSummary: adapterStatus.errorMessage || adapterStatus.errorReason || 'Provider reported an error',
2954
+ completionDiagnostic: {
2955
+ reason: adapterStatus.errorReason || 'provider_error',
2956
+ errorMessage: adapterStatus.errorMessage || undefined,
2957
+ },
2958
+ });
960
2959
  } else if (newStatus === 'stopped') {
961
2960
  // Cancel any pending debounce
962
2961
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
@@ -968,6 +2967,79 @@ export class CliProviderInstance implements ProviderInstance {
968
2967
  this.lastStatus = newStatus;
969
2968
  }
970
2969
 
2970
+ // GENERATING-BOUNDARY idle-stayed collapse (R4b): the starting→idle
2971
+ // fast-collapse arm above only fires when the FIRST turn itself drives the
2972
+ // starting→idle transition. When the launch settle already drained
2973
+ // starting→idle BEFORE the first turn arrives, the session is already 'idle'
2974
+ // and a turn that runs+completes inside the startup-grace window — too fast
2975
+ // for any poll to observe a 'generating' frame — produces NO status change
2976
+ // at all (idle→idle). detectStatusTransition's change block above is skipped
2977
+ // entirely, so neither the idle→generating arm nor the starting→idle
2978
+ // fast-collapse arm ever runs, and the mesh coordinator never learns the
2979
+ // worker went idle (the live rc.403 Probe1 miss). Catch it here: an
2980
+ // already-idle poll (no status change), still inside the startup-grace
2981
+ // window, where a turn started this boot and has already finished without
2982
+ // ever arming generating. The same false-positive-safe discriminators apply
2983
+ // (currentTurnTaskId set && !pending && generating never armed), plus a
2984
+ // once-per-turn guard since this branch is re-polled while the session sits
2985
+ // idle. Normal turns that DO reach 'busy' set generatingStartedAt and are
2986
+ // excluded; a queued-pending first turn that only runs after grace falls
2987
+ // outside the window and completes normally via idle→busy→idle.
2988
+ //
2989
+ // R4d (the live rc.405 Probe2 miss): R4c anchored the window on the collapse
2990
+ // moment but still measured its END against `now` (the poll/completion time). The
2991
+ // helper only fires once the turn has FINISHED (!hasAdapterPendingResponse()), so
2992
+ // the first eligible poll happens at completion. When the first turn is dispatched
2993
+ // a few seconds after the collapse AND runs for a non-trivial duration, that
2994
+ // completion lands PAST the 12s now-anchored window even though the turn was a
2995
+ // genuine startup-grace first turn (live: collapse→dispatch +5.2s, turn ~11s →
2996
+ // completion at collapse+16.2s > 12s). Anchor the window on when the first turn
2997
+ // STARTED (engine.currentTurnStartedAt, set by onTurnStarted) instead: a turn that
2998
+ // STARTED within the collapse window is a startup-grace first turn no matter how
2999
+ // long it then ran. The now-anchored check is retained as a union so a fast turn
3000
+ // (dispatched+completed quickly within 12s of collapse) keeps firing too; both
3001
+ // close for a much-later turn, preserving the "don't mislabel a late fast turn"
3002
+ // honesty the window exists for.
3003
+ const firstTurnStartedAt = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
3004
+ ? (this.adapter as any).currentTurnStartedAt as number
3005
+ : 0;
3006
+ const collapsedAt = this.startupGraceCollapseAt;
3007
+ const turnStartedWithinCollapseWindow = collapsedAt !== null
3008
+ && firstTurnStartedAt > 0
3009
+ && firstTurnStartedAt >= collapsedAt
3010
+ && (firstTurnStartedAt - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
3011
+ const nowWithinCollapseWindow = collapsedAt !== null
3012
+ && (now - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
3013
+ if (
3014
+ newStatus === 'idle'
3015
+ && previousStatus === 'idle'
3016
+ && (turnStartedWithinCollapseWindow || nowWithinCollapseWindow)
3017
+ ) {
3018
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_idle_turn_collapse');
3019
+ }
3020
+
3021
+ // Re-arm the queue-claim agent:ready on the FSM's first GENUINE ready.
3022
+ //
3023
+ // The boot-time starting→idle one-shot above is the historical claim
3024
+ // trigger, but it is consumed too early for FSM-spec providers whose
3025
+ // INITIAL state already reports status 'idle' (e.g. antigravity-cli): the
3026
+ // adapter reports idle before maybeMarkReady has fired, so lastStatus
3027
+ // advances starting→idle while the prompt is not yet drawn and the worker
3028
+ // cannot yet claim. Subsequent state-driven idle frames are idle→idle (no
3029
+ // status change), so the one-shot never re-fires and the worker strands its
3030
+ // queued task — the coordinator then relaunch-loops every ~90s.
3031
+ //
3032
+ // The adapter surfaces fsmReadySeen=true exactly when the FSM reaches its
3033
+ // first non-initial idle (the prompt is genuinely up). On that signal we
3034
+ // emit agent:ready once more. emitAgentReadyOnce is idempotent (guarded by
3035
+ // agentReadyEmitted), so providers whose boot one-shot already landed on a
3036
+ // real ready (claude-cli / codex-cli / hermes-cli, which use a startup
3037
+ // grace and whose initial state is not idle) treat this as a no-op — no
3038
+ // double claim, no double task injection.
3039
+ if (newStatus === 'idle' && adapterStatus.fsmReadySeen === true && !this.agentReadyEmitted) {
3040
+ this.emitAgentReadyOnce(chatTitle, now);
3041
+ }
3042
+
971
3043
  this.applyProviderResponse(parsedStatus, {
972
3044
  phase: (newStatus === 'idle' && (previousStatus === 'generating' || previousStatus === 'waiting_approval'))
973
3045
  ? 'turn_completed'
@@ -976,8 +3048,42 @@ export class CliProviderInstance implements ProviderInstance {
976
3048
 
977
3049
  // Monitor check (cooldown based notification, IDE/CLI common)
978
3050
  const agentKey = `${this.type}:cli`;
979
- const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint);
3051
+ // Approval pending is detected from the raw adapter status, not `newStatus`:
3052
+ // auto-approve synthesizes `waiting_approval` → 'generating', which would
3053
+ // otherwise let the no-progress watchdog accumulate the approval wait.
3054
+ const approvalPending = rawStatus === 'waiting_approval';
3055
+ const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint, approvalPending);
3056
+ const monitorParsedStatus: any = parsedStatus;
980
3057
  for (const me of monitorEvents) {
3058
+ if (
3059
+ me.type === 'monitor:no_progress'
3060
+ && this.completionHasFinalAssistantMessage(monitorParsedStatus?.messages)
3061
+ && !this.hasAdapterPendingResponse()
3062
+ && !hasNonEmptyCliModalButtons(monitorParsedStatus?.activeModal ?? monitorParsedStatus?.modal)
3063
+ ) {
3064
+ // EVTTRACE: completion fired (no-progress monitor reconciled to completion).
3065
+ if (this.isMeshWorkerSession()) {
3066
+ traceMeshEventStage('fired', this.meshTraceCtx(), 'no_progress_monitor_final_summary');
3067
+ }
3068
+ this.emitGeneratingCompleted({
3069
+ chatTitle,
3070
+ duration: this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : undefined,
3071
+ timestamp: me.timestamp,
3072
+ finalSummary: extractFinalSummaryFromMessages(monitorParsedStatus?.messages),
3073
+ completionDiagnostic: {
3074
+ providerType: this.type,
3075
+ sessionId: this.instanceId,
3076
+ providerSessionId: this.providerSessionId || null,
3077
+ reconciliationReason: 'no_progress_monitor_final_summary',
3078
+ finalAssistantPresent: true,
3079
+ },
3080
+ });
3081
+ this.generatingStartedAt = 0;
3082
+ // Cancel any pending debounce flush — monitor already fired completion.
3083
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
3084
+ this.completedDebouncePending = null;
3085
+ continue;
3086
+ }
981
3087
  this.pushEvent({ event: me.type, agentKey: me.agentKey, message: me.message, elapsedSec: me.elapsedSec, timestamp: me.timestamp });
982
3088
  }
983
3089
  }
@@ -997,15 +3103,61 @@ export class CliProviderInstance implements ProviderInstance {
997
3103
  workspaceName: typeof event.workspaceName === 'string' && event.workspaceName.trim()
998
3104
  ? event.workspaceName
999
3105
  : this.workingDir,
3106
+ // Carry the workspace under BOTH `workspace` and `workspaceName` so the
3107
+ // downstream mesh forward/merge path — which reads `workspace` — can
3108
+ // propagate it to the coordinator snapshot. Without `workspace` the live
3109
+ // event path delivers an empty workspace and the dashboard falls back to
3110
+ // the generic "Terminal (Mesh Node)" title.
3111
+ workspace: typeof event.workspace === 'string' && event.workspace.trim()
3112
+ ? event.workspace
3113
+ : this.workingDir,
1000
3114
  providerSessionId: typeof event.providerSessionId === 'string' && event.providerSessionId.trim()
1001
3115
  ? event.providerSessionId
1002
3116
  : this.providerSessionId,
1003
3117
  };
3118
+ // TASKIDLESS: stamp the mesh task primary key on lifecycle events emitted by
3119
+ // a mesh worker session. The consumer (updateDirectDispatchStatus) was switched
3120
+ // to key on task_id (CANON-B), but the producer never carried it — so every
3121
+ // forwarded metadataEvent.taskId arrived undefined and the coordinator fell back
3122
+ // to a session_id match, which can flip a sibling dispatch row. Surface it here so
3123
+ // updateDirectDispatchStatus hits the exact PK row and the session_id fallback is
3124
+ // never exercised. Non-mesh sessions get no taskId (regression guard) —
3125
+ // isMeshWorkerSession() gates the injection.
3126
+ //
3127
+ // ARCH-REFACTOR R1 (per-turn identity): resolution order is
3128
+ // (1) an explicit taskId already on the event — the debounce-flush completion
3129
+ // path stamps the taskId captured at the generating→idle transition (the
3130
+ // turn that actually produced this completion);
3131
+ // (2) the per-turn binding (engine.currentTurnTaskId) for synchronously-emitted
3132
+ // events whose turn is still the current one;
3133
+ // (3) the legacy session scalar (settings.meshActiveTaskId) as a last-resort
3134
+ // backward-compat alias.
3135
+ // The scalar is last because it is last-write-wins: a second task attaching while
3136
+ // this turn was still running overwrites it, which is the exact NOTIF-MISDELIVER /
3137
+ // TASK-MSG-MISROUTE race this refactor removes.
3138
+ if (this.isMeshWorkerSession()) {
3139
+ const existingTaskId = typeof enrichedEvent.taskId === 'string' && enrichedEvent.taskId.trim()
3140
+ ? enrichedEvent.taskId
3141
+ : undefined;
3142
+ if (!existingTaskId) {
3143
+ const resolved = this.completingTurnTaskId();
3144
+ if (resolved) enrichedEvent.taskId = resolved;
3145
+ }
3146
+ }
1004
3147
  if (this.context?.emitProviderEvent) {
1005
3148
  this.context.emitProviderEvent(enrichedEvent);
1006
- return;
3149
+ } else {
3150
+ this.events.push(enrichedEvent);
3151
+ }
3152
+ // Auto-detach a direct-dispatch mesh assignment once the dispatched
3153
+ // task reaches a terminal state. Leaving meshNodeFor pinned would
3154
+ // route this session's next unrelated turn (a dashboard chat) into
3155
+ // the coordinator as if it were the completion of another task.
3156
+ // We schedule after the emit so the originating coordinator still
3157
+ // observes the completion event with its routing marker intact.
3158
+ if (TERMINAL_MESH_EVENTS.has(event.event) && this.settings.meshActiveTaskId) {
3159
+ try { this.detachMeshAssignment(); } catch { /* best-effort */ }
1007
3160
  }
1008
- this.events.push(enrichedEvent);
1009
3161
  }
1010
3162
 
1011
3163
  private flushEvents(): ProviderEvent[] {
@@ -1022,7 +3174,13 @@ export class CliProviderInstance implements ProviderInstance {
1022
3174
  typeof data.providerSessionId === 'string' ? data.providerSessionId : '',
1023
3175
  );
1024
3176
  if (patchedProviderSessionId) {
1025
- this.promoteProviderSessionId(patchedProviderSessionId);
3177
+ // A provider-response id is authoritative when it carries an
3178
+ // explicit `new_session` marker (the CLI genuinely started a new
3179
+ // conversation). Without that marker it's just an observed id and
3180
+ // must not hijack an existing binding (see promoteProviderSessionId).
3181
+ this.promoteProviderSessionId(patchedProviderSessionId, {
3182
+ authoritative: data.sessionEvent === 'new_session',
3183
+ });
1026
3184
  }
1027
3185
 
1028
3186
  if (data.sessionEvent === 'new_session') {
@@ -1047,7 +3205,7 @@ export class CliProviderInstance implements ProviderInstance {
1047
3205
  if (effectWhen === 'turn_completed' && options.phase !== 'turn_completed') continue;
1048
3206
  if (effectWhen === 'immediate' && options.phase === 'turn_completed') continue;
1049
3207
 
1050
- const effectKey = this.getEffectDedupKey(effect);
3208
+ const effectKey = getEffectDedupKey(effect);
1051
3209
  if (this.appliedEffectKeys.has(effectKey)) continue;
1052
3210
  this.appliedEffectKeys.add(effectKey);
1053
3211
 
@@ -1097,40 +3255,6 @@ export class CliProviderInstance implements ProviderInstance {
1097
3255
  this.appliedEffectKeys = new Set(Array.from(this.appliedEffectKeys).slice(-100));
1098
3256
  }
1099
3257
  }
1100
-
1101
- private getEffectDedupKey(effect: { id?: string; type: string; message?: { content?: unknown }; toast?: { message?: string }; notification?: { title?: string; body?: string } }): string {
1102
- if (effect.id) return `provider_effect:${effect.id}`;
1103
- if (effect.type === 'message') {
1104
- const content = typeof effect.message?.content === 'string'
1105
- ? effect.message.content
1106
- : JSON.stringify(effect.message?.content || '');
1107
- return `provider_effect:message:${content}`;
1108
- }
1109
- if (effect.type === 'notification') {
1110
- return `provider_effect:notification:${effect.notification?.title || ''}:${effect.notification?.body || ''}`;
1111
- }
1112
- return `provider_effect:toast:${effect.toast?.message || ''}`;
1113
- }
1114
-
1115
- private getPersistedEffectContent(effect: { type: string; message?: { content?: unknown }; toast?: { message?: string }; notification?: { title?: string; body?: string; bubbleContent?: unknown } }): string | null {
1116
- if (effect.type === 'message') {
1117
- return typeof effect.message?.content === 'string'
1118
- ? effect.message.content
1119
- : JSON.stringify(effect.message?.content || '');
1120
- }
1121
- if (effect.type === 'toast') {
1122
- return effect.toast?.message || null;
1123
- }
1124
- if (effect.type === 'notification') {
1125
- if (typeof effect.notification?.bubbleContent === 'string') return effect.notification.bubbleContent;
1126
- if (typeof effect.notification?.title === 'string' && effect.notification.title.trim()) {
1127
- return `${effect.notification.title}\n${effect.notification.body || ''}`.trim();
1128
- }
1129
- return effect.notification?.body || null;
1130
- }
1131
- return null;
1132
- }
1133
-
1134
3258
  // ─── Adapter access (backward compat) ──────────────────
1135
3259
 
1136
3260
  getAdapter(): ProviderCliAdapter {
@@ -1151,6 +3275,118 @@ export class CliProviderInstance implements ProviderInstance {
1151
3275
  return false;
1152
3276
  }
1153
3277
 
3278
+ /** @see ProviderInstance.noteManualInteraction */
3279
+ noteManualInteraction(now = Date.now(), opts?: { passive?: boolean }): void {
3280
+ // P1b (#137 secondary): a DELEGATED worker session must not treat a
3281
+ // passive dashboard view (foreground tab selection / panel open) as
3282
+ // manual attendance. A coordinator merely peeking at a worker's panel
3283
+ // would otherwise suppress that worker's delegated auto-approve for the
3284
+ // whole 60s window. Only explicit input/intervention (controlbar,
3285
+ // resolve_action, pty_input) attends a worker. Non-worker (foreground)
3286
+ // sessions keep noting on passive views so a user foregrounding their own
3287
+ // session still holds auto-approve to act on the modal themselves.
3288
+ if (opts?.passive && this.isMeshWorkerSession()) return;
3289
+ this.manualAttendance.note(now);
3290
+ }
3291
+
3292
+ /**
3293
+ * Whether auto-approve should be treated as active *right now* for display
3294
+ * and firing decisions: the configured intent AND the user is not currently
3295
+ * attending this session by hand. When a human is attending, auto-approve is
3296
+ * held so the modal stays visible and they can drive it via the controlbar.
3297
+ * Provider-agnostic — the attendance signal is the command set, never any
3298
+ * CLI-specific modal text.
3299
+ */
3300
+ private autoApproveEffectivelyActive(status: string | undefined, now = Date.now()): boolean {
3301
+ return status === 'waiting_approval'
3302
+ && this.shouldAutoApprove()
3303
+ && !this.manualAttendance.isAttended(now);
3304
+ }
3305
+
3306
+ // STATUS-MISMATCH: true once the current auto-approve episode has been masking
3307
+ // waiting_approval behind `generating` for longer than AUTO_APPROVE_MASK_STALL_MS without
3308
+ // resolving (the settle gate never fired). When stalled, the surface mask must be dropped
3309
+ // so read_chat / mesh_status / the dashboard see the real waiting_approval + modal (and a
3310
+ // coordinator can mesh_approve it). autoApproveMaskSince is maintained by
3311
+ // maybeAutoApproveStatus (driven by getState + the recheck timer during a waiting episode);
3312
+ // this read is side-effect-free so getStatusMetadata can consult it too.
3313
+ private autoApproveMaskStalled(now = Date.now()): boolean {
3314
+ return this.autoApproveMaskSince > 0
3315
+ && now - this.autoApproveMaskSince > CliProviderInstance.AUTO_APPROVE_MASK_STALL_MS;
3316
+ }
3317
+
3318
+ /**
3319
+ * NOTIF-APPROVAL-MASKED (Q1b): surface a delegated worker's STALLED auto-approve modal
3320
+ * to the mesh COORDINATOR, decoupled from the dashboard visible-status mask.
3321
+ *
3322
+ * When auto-approve is configured but the episode never settles (modal parse miss / the
3323
+ * settle gate never satisfied), getState()/detectStatusTransition() fold the raw
3324
+ * `waiting_approval` into `generating` to suppress dashboard flicker — so
3325
+ * detectStatusTransition()'s `waiting_approval` arm never runs and NO agent:waiting_approval
3326
+ * event is emitted. The coordinator's real-time approval-nudge delivery then has no input and
3327
+ * the worker's stuck modal is never surfaced (the live ~25s stall). The dashboard mask is
3328
+ * intentional and stays; this emits the coordinator nudge exactly ONCE, gated on the SAME
3329
+ * raw-waiting_approval + mask-stalled signal resolveModalParkStatus() distinguishes, the
3330
+ * instant the mask-stall threshold trips (the same moment getState un-folds the mask).
3331
+ *
3332
+ * Only delegated worker sessions qualify: a foreground session has no coordinator to notify,
3333
+ * and its own dashboard mask already reveals the modal on stall. A normally-resolving
3334
+ * auto-approve never reaches AUTO_APPROVE_MASK_STALL_MS, so it emits nothing here; and if a
3335
+ * masked approval clears just as this fires, rc.455's isApprovalNudgeResolved stale-drop
3336
+ * discards the nudge coordinator-side without noise. Dedup is per-episode (keyed on the
3337
+ * mask-clock value) so a modal that flaps between parsed/unparsed states is announced once.
3338
+ */
3339
+ private maybeEmitStalledApprovalNudge(adapterStatus: any, now: number): void {
3340
+ if (!this.isMeshWorkerSession()) return;
3341
+ if (adapterStatus?.status !== 'waiting_approval') return;
3342
+ if (!this.autoApproveMaskStalled(now)) return;
3343
+ // AUTOAPPROVE-FLAP-RECUR (Fix C, redesigned): the mask-stall bound tripped.
3344
+ // If auto-approve is genuinely about to fire on its own, defer to that fire —
3345
+ // the nudge would race a resolveModal landing milliseconds later, producing
3346
+ // the coordinator flap this fix targets.
3347
+ //
3348
+ // The ORIGINAL guard deferred on `pendingAutoApprovalSince && buttons > 0`
3349
+ // alone. That is FALSE-POSITIVE for a FLAPPING modal: a modal whose identity
3350
+ // changes every frame (message streaming) keeps pendingAutoApprovalSince
3351
+ // nonzero (it is re-stamped to `now` on every signature change) and keeps
3352
+ // buttons present, yet its settle clock is wiped back to ~0 each frame and
3353
+ // NEVER reaches SETTLE_MS — so auto-approve can never fire and this is exactly
3354
+ // the stuck episode the coordinator MUST be paged about. The old guard
3355
+ // silenced it permanently (the live rc.466 regression).
3356
+ //
3357
+ // Discriminator: a settle is genuinely PROGRESSING only if THIS frame's modal
3358
+ // carries the SAME identity the settle clock is already accruing against
3359
+ // (pendingAutoApprovalSignature). A stable modal keeps its signature across
3360
+ // frames → the clock climbs → resolveModal is imminent → defer. A flapping
3361
+ // modal presents a DIFFERENT signature this frame (or none — a non-concrete /
3362
+ // picker / never-captured modal) → the clock is about to reset (or never
3363
+ // engaged) → do NOT defer, page the coordinator. This is evaluated for the
3364
+ // CURRENT frame (not a stale prior-frame value), so a stable modal polled only
3365
+ // twice — start, then past the stall bound — is still correctly deferred.
3366
+ const currentSignature = this.approvableModalSignature(adapterStatus.activeModal);
3367
+ const settleProgressing = !!currentSignature
3368
+ && this.pendingAutoApprovalSince > 0
3369
+ && currentSignature === this.pendingAutoApprovalSignature;
3370
+ if (settleProgressing) return;
3371
+ // Exactly once per stalled episode (autoApproveMaskSince uniquely identifies it).
3372
+ if (this.stalledApprovalNudgeEpisode === this.autoApproveMaskSince) return;
3373
+ this.stalledApprovalNudgeEpisode = this.autoApproveMaskSince;
3374
+ const modal = adapterStatus.activeModal;
3375
+ const dirName = workingDirBasename(this.workingDir);
3376
+ const chatTitle = `${this.provider.name} · ${dirName}`;
3377
+ this.appendRuntimeSystemMessage(
3378
+ formatApprovalRequestMessage(modal?.message, modal?.buttons),
3379
+ `approval_request:${now}`,
3380
+ now,
3381
+ );
3382
+ this.pushEvent({
3383
+ event: 'agent:waiting_approval', chatTitle, timestamp: now,
3384
+ modalMessage: modal?.message,
3385
+ modalButtons: modal?.buttons,
3386
+ });
3387
+ LOG.info('CLI', `[${this.type}] stalled auto-approve nudge → coordinator (masked ${Math.round((now - this.autoApproveMaskSince) / 1000)}s)`);
3388
+ }
3389
+
1154
3390
  private recordAutoApproval(modalMessage?: string, buttonLabel?: string, now = Date.now()): void {
1155
3391
  this.appendRuntimeSystemMessage(
1156
3392
  formatAutoApprovalMessage(modalMessage, buttonLabel),
@@ -1170,12 +3406,6 @@ export class CliProviderInstance implements ProviderInstance {
1170
3406
  );
1171
3407
  }
1172
3408
 
1173
- private formatMarkerTimestamp(timestamp: number): string {
1174
- const date = new Date(timestamp);
1175
- const pad = (value: number) => String(value).padStart(2, '0');
1176
- return `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())} ${pad(date.getHours())}:${pad(date.getMinutes())}:${pad(date.getSeconds())}`;
1177
- }
1178
-
1179
3409
  private maybeAppendRuntimeRecoveryMessage(runtime: PtyRuntimeMetadata | null): void {
1180
3410
  if (!runtime?.restoredFromStorage || !runtime.runtimeId) return;
1181
3411
 
@@ -1238,7 +3468,7 @@ export class CliProviderInstance implements ProviderInstance {
1238
3468
  receivedAt: normalizedMessage.receivedAt || normalizedMessage.timestamp,
1239
3469
  historyDedupKey: dedupKey,
1240
3470
  }],
1241
- this.adapter.getScriptParsedStatus?.()?.title || this.workingDir.split('/').filter(Boolean).pop() || 'session',
3471
+ this.adapter.getScriptParsedStatus?.()?.title || workingDirBasename(this.workingDir),
1242
3472
  this.instanceId,
1243
3473
  this.providerSessionId,
1244
3474
  );
@@ -1246,102 +3476,46 @@ export class CliProviderInstance implements ProviderInstance {
1246
3476
  }
1247
3477
 
1248
3478
  mergeRuntimeChatMessages(parsedMessages: ChatMessage[]): ChatMessage[] {
1249
- return this.mergeConversationMessages(parsedMessages);
1250
- }
1251
-
1252
- private mergeConversationMessages(parsedMessages: any[]): ChatMessage[] {
1253
- if (this.runtimeMessages.length === 0) return normalizeChatMessages(parsedMessages);
1254
-
1255
- type MergeEntry = { message: ChatMessage; index: number; source: 'parsed' | 'runtime'; runtimeKey?: string };
1256
- const parsedEntries: MergeEntry[] = parsedMessages.map((message, index) => ({
1257
- message,
1258
- index,
1259
- source: 'parsed',
1260
- }));
1261
- const runtimeEntries: MergeEntry[] = this.runtimeMessages.map((entry, index) => ({
1262
- message: entry.message,
1263
- index: parsedMessages.length + index,
1264
- source: 'runtime',
1265
- runtimeKey: entry.key,
1266
- }));
1267
- const getTime = (message: ChatMessage): number => {
1268
- const value = typeof message.receivedAt === 'number'
1269
- ? message.receivedAt
1270
- : typeof message.timestamp === 'number'
1271
- ? message.timestamp
1272
- : 0;
1273
- return Number.isFinite(value) && value > 0 ? value : 0;
1274
- };
1275
-
1276
- const getRole = (message: ChatMessage): string => typeof message.role === 'string'
1277
- ? message.role.trim().toLowerCase()
1278
- : '';
1279
- const isRuntimeOverlay = (entry: MergeEntry): boolean => {
1280
- if (entry.source !== 'runtime') return false;
1281
- const key = typeof entry.runtimeKey === 'string' ? entry.runtimeKey.trim().toLowerCase() : '';
1282
- if (key.startsWith('auto_approval:')) return true;
1283
- return !isUserFacingChatMessage(entry.message);
1284
- };
1285
- const shouldKeepParsedBeforeUntimedRuntime = (message: ChatMessage): boolean => {
1286
- const role = getRole(message);
1287
- return role === 'user' || role === 'human';
1288
- };
1289
- const shouldKeepParsedAfterUntimedRuntime = (message: ChatMessage): boolean => {
1290
- const role = getRole(message);
1291
- if (role !== 'assistant') return false;
1292
- const kind = resolveChatMessageKind(message);
1293
- return kind === 'standard' || kind === 'terminal';
1294
- };
1295
-
1296
- return normalizeChatMessages([...parsedEntries, ...runtimeEntries]
1297
- .sort((a, b) => {
1298
- const aTime = getTime(a.message);
1299
- const bTime = getTime(b.message);
1300
- if (aTime && bTime && aTime !== bTime) return aTime - bTime;
1301
- if (a.source !== b.source && aTime !== bTime) {
1302
- const parsedEntry = a.source === 'parsed' ? a : b.source === 'parsed' ? b : null;
1303
- const runtimeEntry = a.source === 'runtime' ? a : b.source === 'runtime' ? b : null;
1304
- if (parsedEntry && runtimeEntry && isRuntimeOverlay(runtimeEntry) && getTime(parsedEntry.message) === 0 && getTime(runtimeEntry.message) > 0) {
1305
- if (shouldKeepParsedBeforeUntimedRuntime(parsedEntry.message)) {
1306
- return a.source === 'parsed' ? -1 : 1;
1307
- }
1308
- if (shouldKeepParsedAfterUntimedRuntime(parsedEntry.message)) {
1309
- return a.source === 'parsed' ? 1 : -1;
1310
- }
1311
- }
1312
- }
1313
- // Many provider-owned CLI transcripts (including Hermes CLI in debug bundles)
1314
- // do not carry timestamps on parsed messages. In that case there is no safe
1315
- // clock basis for interleaving timestamped runtime/system messages into the
1316
- // provider transcript. Keep user prompts before runtime overlays, but do not
1317
- // let timed runtime/system/tool/internal overlays become the final chat turns
1318
- // after an untimed parsed assistant transcript.
1319
- return a.index - b.index;
1320
- })
1321
- .map((entry) => entry.message));
1322
- }
1323
-
1324
- private formatApprovalRequestMessage(modalMessage?: string, buttons?: string[]): string {
1325
- const lines = ['Approval requested'];
1326
- const cleanMessage = String(modalMessage || '').trim();
1327
- if (cleanMessage) lines.push(cleanMessage);
1328
- const labels = (buttons || []).map((button) => String(button || '').trim()).filter(Boolean);
1329
- if (labels.length > 0) {
1330
- lines.push(labels.map((label) => `[${label}]`).join(' '));
1331
- }
1332
- return lines.join('\n');
3479
+ return mergeConversationMessages(this.runtimeMessages, parsedMessages);
1333
3480
  }
1334
3481
 
1335
- private promoteProviderSessionId(sessionId: string): void {
3482
+ private promoteProviderSessionId(sessionId: string, opts: { authoritative?: boolean } = {}): void {
1336
3483
  const nextSessionId = String(sessionId || '').trim();
1337
3484
  if (!nextSessionId || nextSessionId === this.providerSessionId) return;
1338
3485
 
3486
+ // Sticky binding: once this instance is bound to a provider session,
3487
+ // an *observed* id (one discovered from a status parse or the native
3488
+ // history reader) must NOT hijack the live binding. hermes ≥0.14
3489
+ // spawns a fresh `sessions` row per internal sub-session, so a
3490
+ // newest-wins native read surfaces a different id mid-turn on every
3491
+ // poll; accepting it would re-bind the instance, re-hydrate unbounded
3492
+ // history (daemon saturation) and reset completion detection so the
3493
+ // turn never finalizes. Only an *authoritative* change — the first
3494
+ // bind (no id yet) or an explicit provider `new_session`/resume — may
3495
+ // replace an existing binding. Legitimate resume/new-session paths
3496
+ // pass authoritative:true and are unaffected.
3497
+ if (this.providerSessionId && !opts.authoritative) {
3498
+ LOG.debug('CLI', `[${this.type}] ignoring non-authoritative session id ${nextSessionId} (bound to ${this.providerSessionId})`);
3499
+ return;
3500
+ }
3501
+
1339
3502
  const previousHistorySessionId = this.providerSessionId || this.instanceId;
1340
3503
  const previousProviderSessionId = this.providerSessionId;
1341
3504
  this.providerSessionId = nextSessionId;
3505
+ // Conversation-binding lock (antigravity): the moment this session is
3506
+ // authoritatively bound to a conversation uuid, claim it so a concurrent
3507
+ // sibling session's newest-on-disk discovery can never resolve to the
3508
+ // same .db (RCA: two antigravity sessions ~94ms apart shared one store
3509
+ // and cross-routed completions). Released on dispose().
3510
+ if (this.type === 'antigravity-cli') {
3511
+ const owner = this.antigravityClaimOwner();
3512
+ if (owner) claimAntigravityConversation(nextSessionId, owner);
3513
+ }
1342
3514
  this.historyWriter.promoteHistorySession(this.type, previousHistorySessionId, nextSessionId);
1343
3515
  this.historyWriter.writeSessionStart(this.type, nextSessionId, this.workingDir, this.instanceId);
1344
- this.restorePersistedHistoryFromCurrentSession();
3516
+ if (this.shouldHydrateExistingProviderHistory()) {
3517
+ this.restorePersistedHistoryFromCurrentSession();
3518
+ }
1345
3519
  this.adapter.updateRuntimeMeta({ providerSessionId: nextSessionId });
1346
3520
  this.onProviderSessionResolved?.({
1347
3521
  instanceId: this.instanceId,
@@ -1354,13 +3528,39 @@ export class CliProviderInstance implements ProviderInstance {
1354
3528
  LOG.info('CLI', `[${this.type}] discovered provider session id: ${nextSessionId}`);
1355
3529
  }
1356
3530
 
1357
- private syncCanonicalSavedHistoryIfNeeded(): boolean {
3531
+ private shouldHydrateExistingProviderHistory(): boolean {
3532
+ return this.launchMode === 'resume' || this.launchMode === 'manual';
3533
+ }
3534
+
3535
+ private shouldSuppressFreshLaunchStartupReplay(parsedMessages: unknown[], parsedStatus: any, adapterStatus: any, parsedProviderSessionId = ''): boolean {
3536
+ if (this.launchMode !== 'new') return false;
3537
+ if (this.providerSessionId) return false;
3538
+ if (!Array.isArray(parsedMessages) || parsedMessages.length === 0) return false;
3539
+ if (!isIdleStatus(adapterStatus?.status) || !isIdleStatus(parsedStatus?.status)) return false;
3540
+ if (parsedProviderSessionId) return true;
3541
+
3542
+ const newestMessageAt = parsedMessages.reduce<number>((newest, message) => Math.max(newest, getMessageTime(message)), 0);
3543
+
3544
+ // Untimestamped idle parser output during a fresh launch is usually the
3545
+ // provider's last workspace transcript before a new turn exists.
3546
+ return newestMessageAt === 0;
3547
+ }
3548
+
3549
+ private syncCanonicalSavedHistoryIfNeeded(options: { full?: boolean } = {}): boolean {
1358
3550
  if (!this.providerSessionId) return false;
1359
- const canonicalHistory = this.provider.canonicalHistory;
3551
+ const canonicalHistory = this.provider.nativeHistory;
1360
3552
  if (!canonicalHistory) return false;
1361
3553
 
3554
+ // Per-status-report hydration reads only a bounded tail (snapshot needs at
3555
+ // most the newest 60). The once-per-resume restore path passes full:true
3556
+ // because seedSessionHistory needs the COMPLETE transcript to seed dedup
3557
+ // state. The read-cache key encodes the window so the bounded and full
3558
+ // reads don't share/clobber each other's 2s cache entry.
3559
+ const limit = options.full ? Number.MAX_SAFE_INTEGER : STATUS_HYDRATION_TAIL_LIMIT;
3560
+ const windowTag = options.full ? 'full' : `tail:${STATUS_HYDRATION_TAIL_LIMIT}`;
3561
+
1362
3562
  if (isNativeSourceCanonicalHistory(canonicalHistory)) {
1363
- const cacheKey = [this.type, this.providerSessionId, this.workingDir].join('\0');
3563
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, windowTag].join('\0');
1364
3564
  const now = Date.now();
1365
3565
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1366
3566
  return true;
@@ -1373,7 +3573,7 @@ export class CliProviderInstance implements ProviderInstance {
1373
3573
  historySessionId: this.providerSessionId,
1374
3574
  workspace: this.workingDir,
1375
3575
  offset: 0,
1376
- limit: Number.MAX_SAFE_INTEGER,
3576
+ limit,
1377
3577
  historyBehavior: this.provider.historyBehavior,
1378
3578
  scripts: this.provider.scripts as any,
1379
3579
  });
@@ -1390,7 +3590,7 @@ export class CliProviderInstance implements ProviderInstance {
1390
3590
  }
1391
3591
 
1392
3592
  try {
1393
- const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror'].join('\0');
3593
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror', windowTag].join('\0');
1394
3594
  const now = Date.now();
1395
3595
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1396
3596
  return true;
@@ -1401,7 +3601,14 @@ export class CliProviderInstance implements ProviderInstance {
1401
3601
  if (!materializeProviderNativeHistory(this.type, canonicalHistory, this.providerSessionId, this.workingDir, this.provider.scripts as any)) {
1402
3602
  return false;
1403
3603
  }
1404
- const restoredHistory = readChatHistory(this.type, 0, Number.MAX_SAFE_INTEGER, this.providerSessionId, 0, this.provider.historyBehavior);
3604
+ // Bounded by default: the per-status-report path only needs the newest
3605
+ // STATUS_HYDRATION_TAIL_LIMIT messages because the snapshot caps
3606
+ // activeChat.messages to the last 60 (status/normalize.ts) and loads
3607
+ // the rest lazily via read_chat on subscribe. The once-per-resume
3608
+ // restore path passes full:true so seedSessionHistory still sees the
3609
+ // COMPLETE transcript for prefix-dedup seeding. readChatHistory serves
3610
+ // a bounded limit as an O(tail) read.
3611
+ const restoredHistory = readChatHistory(this.type, 0, limit, this.providerSessionId, 0, this.provider.historyBehavior);
1405
3612
  this.lastPersistedHistoryMessages = restoredHistory.messages.map((message) => ({
1406
3613
  role: message.role,
1407
3614
  content: message.content,
@@ -1417,10 +3624,13 @@ export class CliProviderInstance implements ProviderInstance {
1417
3624
 
1418
3625
  private restorePersistedHistoryFromCurrentSession(): void {
1419
3626
  if (!this.providerSessionId) return;
1420
- this.syncCanonicalSavedHistoryIfNeeded();
1421
- const restoredHistory = isNativeSourceCanonicalHistory(this.provider.canonicalHistory)
3627
+ // Restore is the once-per-resume seeding path: it needs the COMPLETE
3628
+ // transcript so seedSessionHistory can prime dedup state. Pass full so the
3629
+ // hydration read is unbounded here (and only here).
3630
+ this.syncCanonicalSavedHistoryIfNeeded({ full: true });
3631
+ const restoredHistory = isNativeSourceCanonicalHistory(this.provider.nativeHistory)
1422
3632
  ? readProviderChatHistory(this.type, {
1423
- canonicalHistory: this.provider.canonicalHistory,
3633
+ canonicalHistory: this.provider.nativeHistory,
1424
3634
  historySessionId: this.providerSessionId,
1425
3635
  workspace: this.workingDir,
1426
3636
  offset: 0,