@adhdev/daemon-core 0.9.82-rc.47 → 0.9.82-rc.470

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (468) hide show
  1. package/dist/boot/daemon-lifecycle.d.ts +9 -0
  2. package/dist/boot/process-hardening.d.ts +50 -0
  3. package/dist/build-info.d.ts +37 -0
  4. package/dist/chat/source-machine.d.ts +166 -0
  5. package/dist/chat/source-resolver.d.ts +104 -0
  6. package/dist/chat/subscription-updates.d.ts +1 -0
  7. package/dist/cli-adapter-types.d.ts +68 -2
  8. package/dist/cli-adapters/cli-script-runner.d.ts +117 -0
  9. package/dist/cli-adapters/cli-state-engine.d.ts +200 -0
  10. package/dist/cli-adapters/provider-cli-adapter.d.ts +126 -64
  11. package/dist/cli-adapters/provider-cli-parse.d.ts +5 -0
  12. package/dist/cli-adapters/provider-cli-runtime.d.ts +34 -0
  13. package/dist/cli-adapters/provider-cli-shared.d.ts +74 -0
  14. package/dist/cli-adapters/pty-write-chunking.d.ts +34 -0
  15. package/dist/cli-adapters/raw-terminal-io.d.ts +37 -0
  16. package/dist/cli-adapters/resolve-executable.d.ts +69 -0
  17. package/dist/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +6 -3
  18. package/dist/cli-adapters/terminal-backends/types.d.ts +10 -2
  19. package/dist/cli-adapters/terminal-screen.d.ts +4 -11
  20. package/dist/commands/chat-commands-debug-bundle.d.ts +14 -0
  21. package/dist/commands/chat-commands-read.d.ts +7 -0
  22. package/dist/commands/chat-commands-scope.d.ts +39 -0
  23. package/dist/commands/chat-commands-shared.d.ts +33 -0
  24. package/dist/commands/chat-commands-write.d.ts +14 -0
  25. package/dist/commands/chat-commands.d.ts +10 -23
  26. package/dist/commands/cli-manager.d.ts +25 -1
  27. package/dist/commands/handler.d.ts +125 -0
  28. package/dist/commands/high-family/index.d.ts +3 -0
  29. package/dist/commands/high-family/mesh-coordinator-launch.d.ts +2 -0
  30. package/dist/commands/high-family/mesh-events.d.ts +2 -0
  31. package/dist/commands/high-family/mesh-status.d.ts +2 -0
  32. package/dist/commands/high-family/types.d.ts +64 -0
  33. package/dist/commands/low-family/coordinator-prompt.d.ts +9 -0
  34. package/dist/commands/low-family/daemon-lifecycle.d.ts +2 -0
  35. package/dist/commands/low-family/diagnostics.d.ts +2 -0
  36. package/dist/commands/low-family/index.d.ts +3 -0
  37. package/dist/commands/low-family/mesh-ledger.d.ts +10 -0
  38. package/dist/commands/low-family/mesh-node-logs.d.ts +2 -0
  39. package/dist/commands/low-family/notification.d.ts +2 -0
  40. package/dist/commands/low-family/refine-config.d.ts +2 -0
  41. package/dist/commands/low-family/session-host.d.ts +2 -0
  42. package/dist/commands/low-family/spec-providerdev.d.ts +11 -0
  43. package/dist/commands/low-family/status-meta.d.ts +2 -0
  44. package/dist/commands/low-family/types.d.ts +33 -0
  45. package/dist/commands/med-family/cli-agent.d.ts +2 -0
  46. package/dist/commands/med-family/fast-forward.d.ts +2 -0
  47. package/dist/commands/med-family/ide.d.ts +10 -0
  48. package/dist/commands/med-family/index.d.ts +3 -0
  49. package/dist/commands/med-family/mesh-crud.d.ts +48 -0
  50. package/dist/commands/med-family/mesh-host-pairing.d.ts +2 -0
  51. package/dist/commands/med-family/mesh-queue.d.ts +2 -0
  52. package/dist/commands/med-family/mesh-restart.d.ts +2 -0
  53. package/dist/commands/med-family/types.d.ts +152 -0
  54. package/dist/commands/mesh-coordinator.d.ts +85 -1
  55. package/dist/commands/router-aggregate-status.d.ts +24 -0
  56. package/dist/commands/router-mesh-session-owner.d.ts +59 -0
  57. package/dist/commands/router-refine.d.ts +137 -0
  58. package/dist/commands/router-worktree-cleanup.d.ts +133 -0
  59. package/dist/commands/router.d.ts +204 -15
  60. package/dist/commands/upgrade-helper.d.ts +41 -1
  61. package/dist/config/chat-history.d.ts +9 -0
  62. package/dist/config/config.d.ts +19 -0
  63. package/dist/config/mesh-config.d.ts +136 -1
  64. package/dist/config/mesh-json-config.d.ts +199 -0
  65. package/dist/config/registry-resolver.d.ts +54 -0
  66. package/dist/config/repo-settings.d.ts +77 -0
  67. package/dist/daemon/dev-server.d.ts +0 -2
  68. package/dist/detection/cli-detector.d.ts +17 -0
  69. package/dist/detection/ide-detector.d.ts +13 -0
  70. package/dist/detection/win32-ide-version.d.ts +37 -0
  71. package/dist/git/change-impact-config.d.ts +159 -0
  72. package/dist/git/git-commands.d.ts +26 -2
  73. package/dist/git/git-diff.d.ts +6 -0
  74. package/dist/git/git-executor.d.ts +11 -0
  75. package/dist/git/git-status.d.ts +57 -0
  76. package/dist/git/git-types.d.ts +2 -50
  77. package/dist/git/git-worktree.d.ts +71 -1
  78. package/dist/git/index.d.ts +3 -1
  79. package/dist/index.d.ts +70 -16
  80. package/dist/index.js +58255 -24541
  81. package/dist/index.js.map +1 -1
  82. package/dist/index.mjs +59189 -25650
  83. package/dist/index.mjs.map +1 -1
  84. package/dist/installer.d.ts +1 -4
  85. package/dist/ipc/local-ipc-server.d.ts +91 -0
  86. package/dist/launch.d.ts +1 -1
  87. package/dist/logging/async-batch-writer.d.ts +10 -0
  88. package/dist/logging/debug-config.d.ts +16 -0
  89. package/dist/logging/log-redactor.d.ts +24 -0
  90. package/dist/logging/log-tail-reader.d.ts +81 -0
  91. package/dist/logging/logger.d.ts +1 -1
  92. package/dist/mesh/contracts.d.ts +230 -0
  93. package/dist/mesh/coordinator-prompt.d.ts +76 -0
  94. package/dist/mesh/coordinator-registry.d.ts +59 -0
  95. package/dist/mesh/mesh-active-work.d.ts +203 -0
  96. package/dist/mesh/mesh-clone-grace.d.ts +8 -0
  97. package/dist/mesh/mesh-completion-synthesis.d.ts +4 -0
  98. package/dist/mesh/mesh-coordinator-config.d.ts +21 -0
  99. package/dist/mesh/mesh-delivery-policy.d.ts +104 -0
  100. package/dist/mesh/mesh-event-classify.d.ts +7 -0
  101. package/dist/mesh/mesh-event-forwarding.d.ts +41 -0
  102. package/dist/mesh/mesh-event-trace.d.ts +21 -0
  103. package/dist/mesh/mesh-events-coordinator.d.ts +4 -0
  104. package/dist/mesh/mesh-events-pending.d.ts +246 -0
  105. package/dist/mesh/mesh-events-stale.d.ts +61 -0
  106. package/dist/mesh/mesh-events-utils.d.ts +75 -0
  107. package/dist/mesh/mesh-events.d.ts +6 -49
  108. package/dist/mesh/mesh-fast-forward.d.ts +81 -0
  109. package/dist/mesh/mesh-host-ownership.d.ts +29 -0
  110. package/dist/mesh/mesh-init.d.ts +128 -0
  111. package/dist/mesh/mesh-ledger-reconciliation.d.ts +23 -4
  112. package/dist/mesh/mesh-ledger.d.ts +139 -1
  113. package/dist/mesh/mesh-magi-status.d.ts +63 -0
  114. package/dist/mesh/mesh-missions.d.ts +226 -0
  115. package/dist/mesh/mesh-node-identity.d.ts +310 -0
  116. package/dist/mesh/mesh-queue-assignment.d.ts +158 -0
  117. package/dist/mesh/mesh-reconcile-acked-hold.d.ts +17 -0
  118. package/dist/mesh/mesh-reconcile-config.d.ts +6 -0
  119. package/dist/mesh/mesh-reconcile-identity.d.ts +6 -0
  120. package/dist/mesh/mesh-reconcile-loop.d.ts +80 -0
  121. package/dist/mesh/mesh-reconcile-v2-backstop.d.ts +16 -0
  122. package/dist/mesh/mesh-refine-batch.d.ts +68 -0
  123. package/dist/mesh/mesh-refine-gates.d.ts +428 -0
  124. package/dist/mesh/mesh-refine-status.d.ts +62 -0
  125. package/dist/mesh/mesh-remote-event-pull.d.ts +15 -0
  126. package/dist/mesh/mesh-review-inbox.d.ts +90 -0
  127. package/dist/mesh/mesh-routing.d.ts +70 -0
  128. package/dist/mesh/mesh-runtime-store.d.ts +508 -0
  129. package/dist/mesh/mesh-scheduling-runtime.d.ts +78 -0
  130. package/dist/mesh/mesh-task-inflight.d.ts +46 -0
  131. package/dist/mesh/mesh-task-stats.d.ts +49 -0
  132. package/dist/mesh/mesh-unresolved-forward-outbox.d.ts +30 -0
  133. package/dist/mesh/mesh-warmup-deadline.d.ts +68 -0
  134. package/dist/mesh/mesh-work-queue.d.ts +363 -5
  135. package/dist/mesh/preview-freshness.d.ts +28 -0
  136. package/dist/mesh/refine-config.d.ts +216 -0
  137. package/dist/mesh/worktree-bootstrap-config.d.ts +219 -0
  138. package/dist/providers/acp-provider-instance.d.ts +5 -0
  139. package/dist/providers/approval-utils.d.ts +46 -0
  140. package/dist/providers/chat-message-normalization.d.ts +58 -1
  141. package/dist/providers/cli-provider-effect-format.d.ts +30 -0
  142. package/dist/providers/cli-provider-history-dedup.d.ts +17 -0
  143. package/dist/providers/cli-provider-input-prompt.d.ts +12 -0
  144. package/dist/providers/cli-provider-instance-types.d.ts +45 -0
  145. package/dist/providers/cli-provider-instance.d.ts +340 -30
  146. package/dist/providers/cli-provider-status-helpers.d.ts +46 -0
  147. package/dist/providers/cli-provider-transcript-merge.d.ts +7 -0
  148. package/dist/providers/contracts.d.ts +149 -6
  149. package/dist/providers/external-sources.d.ts +71 -0
  150. package/dist/providers/manual-attendance.d.ts +79 -0
  151. package/dist/providers/native-history/antigravity-claim-registry.d.ts +28 -0
  152. package/dist/providers/native-history/antigravity-cli-transcript.d.ts +137 -0
  153. package/dist/providers/native-history/claude-cli-transcript.d.ts +70 -0
  154. package/dist/providers/native-history/codex-cli-transcript.d.ts +73 -0
  155. package/dist/providers/native-history/constants.d.ts +12 -0
  156. package/dist/providers/native-history/dispatcher.d.ts +31 -0
  157. package/dist/providers/native-history/hermes-cli-transcript.d.ts +30 -0
  158. package/dist/providers/native-history/index.d.ts +13 -0
  159. package/dist/providers/provider-instance-manager.d.ts +29 -0
  160. package/dist/providers/provider-instance.d.ts +30 -1
  161. package/dist/providers/provider-loader.d.ts +42 -5
  162. package/dist/providers/provider-trust.d.ts +31 -0
  163. package/dist/providers/read-chat-contract.d.ts +29 -0
  164. package/dist/providers/sdk/v1/builders/acp/detect-status.d.ts +68 -0
  165. package/dist/providers/sdk/v1/builders/cli/detect-status.d.ts +86 -0
  166. package/dist/providers/sdk/v1/builders/cli/parse-approval-squash.d.ts +59 -0
  167. package/dist/providers/sdk/v1/builders/cli/parse-approval.d.ts +65 -0
  168. package/dist/providers/sdk/v1/builders/cli/parse-session.d.ts +91 -0
  169. package/dist/providers/sdk/v1/builders/cli/visible-region.d.ts +42 -0
  170. package/dist/providers/sdk/v1/fixture-tooling/format.d.ts +126 -0
  171. package/dist/providers/sdk/v1/fixture-tooling/index.d.ts +8 -0
  172. package/dist/providers/sdk/v1/fixture-tooling/replay.d.ts +38 -0
  173. package/dist/providers/sdk/v1/index.d.ts +30 -0
  174. package/dist/providers/sdk/v1/sandbox/README-design.d.ts +193 -0
  175. package/dist/providers/sdk/v1/sandbox/require-whitelist.d.ts +74 -0
  176. package/dist/providers/sdk/v1/sandbox/script-runner.d.ts +98 -0
  177. package/dist/providers/sdk/v1/types/cli/index.d.ts +277 -0
  178. package/dist/providers/sdk/v1/types/common/index.d.ts +203 -0
  179. package/dist/providers/sdk/v1/validators/index.d.ts +5 -0
  180. package/dist/providers/sdk/v1/validators/manifest.d.ts +40 -0
  181. package/dist/providers/sdk/v1/validators/taint.d.ts +52 -0
  182. package/dist/providers/spec/adapter.d.ts +98 -0
  183. package/dist/providers/spec/cli-adapter.d.ts +223 -0
  184. package/dist/providers/spec/evaluator.d.ts +45 -0
  185. package/dist/providers/spec/fsm-driver.d.ts +449 -0
  186. package/dist/providers/spec/fsm-evaluator.d.ts +93 -0
  187. package/dist/providers/spec/fsm-loader.d.ts +14 -0
  188. package/dist/providers/spec/fsm-types.d.ts +202 -0
  189. package/dist/providers/spec/native-history-executor.d.ts +41 -0
  190. package/dist/providers/spec/pre-launch-trust.d.ts +16 -0
  191. package/dist/providers/spec/route.d.ts +4 -0
  192. package/dist/providers/spec/types.d.ts +244 -0
  193. package/dist/providers/status-monitor.d.ts +7 -7
  194. package/dist/providers/transcript-v2.d.ts +176 -0
  195. package/dist/providers/types/interactive-prompt.d.ts +84 -0
  196. package/dist/providers/working-dir.d.ts +17 -0
  197. package/dist/repo-mesh-types.d.ts +629 -12
  198. package/dist/runtime-defaults.d.ts +2 -0
  199. package/dist/session-host/managed-host.d.ts +64 -0
  200. package/dist/session-host/runtime-surface.d.ts +10 -16
  201. package/dist/sessions/registry.d.ts +6 -0
  202. package/dist/shared-types-extra.d.ts +2 -4
  203. package/dist/shared-types.d.ts +86 -55
  204. package/dist/status/normalize.d.ts +1 -1
  205. package/dist/status/normalize.js +1 -0
  206. package/dist/status/normalize.js.map +1 -1
  207. package/dist/status/normalize.mjs +1 -0
  208. package/dist/status/normalize.mjs.map +1 -1
  209. package/dist/status/reporter.d.ts +2 -0
  210. package/dist/status/snapshot.d.ts +26 -0
  211. package/dist/system/hash.d.ts +8 -0
  212. package/dist/system/load-better-sqlite3.d.ts +21 -0
  213. package/dist/types.d.ts +5 -0
  214. package/package.json +11 -4
  215. package/src/agent-stream/poller.ts +2 -3
  216. package/src/agent-stream/provider-adapter.ts +1 -1
  217. package/src/boot/daemon-lifecycle.ts +80 -14
  218. package/src/boot/process-hardening.ts +89 -0
  219. package/src/build-info.ts +73 -0
  220. package/src/chat/source-machine.ts +534 -0
  221. package/src/chat/source-resolver.ts +0 -0
  222. package/src/chat/subscription-updates.ts +20 -1
  223. package/src/cli-adapter-types.d.ts +3 -1
  224. package/src/cli-adapter-types.ts +68 -2
  225. package/src/cli-adapters/cli-script-runner.ts +421 -0
  226. package/src/cli-adapters/cli-state-engine.ts +1246 -0
  227. package/src/cli-adapters/provider-cli-adapter.d.ts +1 -1
  228. package/src/cli-adapters/provider-cli-adapter.ts +914 -1144
  229. package/src/cli-adapters/provider-cli-parse.d.ts +2 -0
  230. package/src/cli-adapters/provider-cli-parse.ts +19 -0
  231. package/src/cli-adapters/provider-cli-runtime.ts +56 -7
  232. package/src/cli-adapters/provider-cli-shared.d.ts +4 -0
  233. package/src/cli-adapters/provider-cli-shared.ts +121 -11
  234. package/src/cli-adapters/pty-transport.ts +2 -1
  235. package/src/cli-adapters/pty-write-chunking.ts +106 -0
  236. package/src/cli-adapters/raw-terminal-io.ts +252 -0
  237. package/src/cli-adapters/resolve-executable.ts +204 -0
  238. package/src/cli-adapters/session-host-transport.ts +2 -1
  239. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.ts +63 -29
  240. package/src/cli-adapters/terminal-backends/types.ts +10 -3
  241. package/src/cli-adapters/terminal-screen.ts +16 -81
  242. package/src/commands/chat-commands-debug-bundle.ts +398 -0
  243. package/src/commands/chat-commands-read.ts +2488 -0
  244. package/src/commands/chat-commands-scope.ts +54 -0
  245. package/src/commands/chat-commands-shared.ts +114 -0
  246. package/src/commands/chat-commands-write.ts +891 -0
  247. package/src/commands/chat-commands.ts +19 -1841
  248. package/src/commands/cli-manager.ts +596 -27
  249. package/src/commands/handler.ts +845 -2
  250. package/src/commands/high-family/index.ts +28 -0
  251. package/src/commands/high-family/mesh-coordinator-launch.ts +680 -0
  252. package/src/commands/high-family/mesh-events.ts +102 -0
  253. package/src/commands/high-family/mesh-status.ts +849 -0
  254. package/src/commands/high-family/types.ts +80 -0
  255. package/src/commands/low-family/coordinator-prompt.ts +72 -0
  256. package/src/commands/low-family/daemon-lifecycle.ts +120 -0
  257. package/src/commands/low-family/diagnostics.ts +57 -0
  258. package/src/commands/low-family/index.ts +37 -0
  259. package/src/commands/low-family/mesh-ledger.ts +62 -0
  260. package/src/commands/low-family/mesh-node-logs.ts +87 -0
  261. package/src/commands/low-family/notification.ts +116 -0
  262. package/src/commands/low-family/refine-config.ts +106 -0
  263. package/src/commands/low-family/session-host.ts +274 -0
  264. package/src/commands/low-family/spec-providerdev.ts +217 -0
  265. package/src/commands/low-family/status-meta.ts +112 -0
  266. package/src/commands/low-family/types.ts +39 -0
  267. package/src/commands/med-family/cli-agent.ts +241 -0
  268. package/src/commands/med-family/fast-forward.ts +230 -0
  269. package/src/commands/med-family/ide.ts +163 -0
  270. package/src/commands/med-family/index.ts +37 -0
  271. package/src/commands/med-family/mesh-crud.ts +1287 -0
  272. package/src/commands/med-family/mesh-host-pairing.ts +234 -0
  273. package/src/commands/med-family/mesh-queue.ts +167 -0
  274. package/src/commands/med-family/mesh-restart.ts +92 -0
  275. package/src/commands/med-family/types.ts +153 -0
  276. package/src/commands/mesh-coordinator.ts +334 -124
  277. package/src/commands/router-aggregate-status.ts +209 -0
  278. package/src/commands/router-mesh-session-owner.ts +114 -0
  279. package/src/commands/router-refine.ts +1711 -0
  280. package/src/commands/router-worktree-cleanup.ts +870 -0
  281. package/src/commands/router.ts +795 -4143
  282. package/src/commands/stream-commands.ts +8 -0
  283. package/src/commands/upgrade-helper.ts +310 -45
  284. package/src/config/chat-history.ts +493 -24
  285. package/src/config/config.ts +30 -0
  286. package/src/config/mesh-config.ts +632 -23
  287. package/src/config/mesh-json-config.ts +376 -0
  288. package/src/config/recent-activity.ts +8 -2
  289. package/src/config/registry-resolver.ts +100 -0
  290. package/src/config/repo-settings.ts +111 -0
  291. package/src/daemon/dev-auto-implement.ts +3 -2
  292. package/src/daemon/dev-cli-debug.ts +10 -1
  293. package/src/daemon/dev-server.ts +0 -541
  294. package/src/detection/cli-detector.ts +94 -9
  295. package/src/detection/ide-detector.ts +55 -16
  296. package/src/detection/win32-ide-version.ts +106 -0
  297. package/src/git/change-impact-config.ts +354 -0
  298. package/src/git/git-commands.ts +112 -16
  299. package/src/git/git-diff.ts +81 -11
  300. package/src/git/git-executor.ts +12 -0
  301. package/src/git/git-status.ts +767 -48
  302. package/src/git/git-types.ts +14 -62
  303. package/src/git/git-worktree.ts +261 -4
  304. package/src/git/index.ts +17 -0
  305. package/src/index.ts +207 -13
  306. package/src/installer.d.ts +1 -1
  307. package/src/installer.ts +8 -6
  308. package/src/ipc/local-ipc-server.ts +278 -0
  309. package/src/launch.d.ts +1 -1
  310. package/src/launch.ts +37 -28
  311. package/src/logging/async-batch-writer.ts +55 -0
  312. package/src/logging/command-log.ts +7 -5
  313. package/src/logging/debug-config.ts +25 -0
  314. package/src/logging/debug-trace.ts +7 -2
  315. package/src/logging/log-redactor.ts +100 -0
  316. package/src/logging/log-tail-reader.ts +341 -0
  317. package/src/logging/logger.ts +14 -7
  318. package/src/mesh/contracts.ts +469 -0
  319. package/src/mesh/coordinator-prompt.ts +572 -34
  320. package/src/mesh/coordinator-registry.ts +121 -0
  321. package/src/mesh/mesh-active-work.ts +706 -0
  322. package/src/mesh/mesh-clone-grace.ts +68 -0
  323. package/src/mesh/mesh-completion-synthesis.ts +398 -0
  324. package/src/mesh/mesh-coordinator-config.ts +97 -0
  325. package/src/mesh/mesh-delivery-policy.ts +284 -0
  326. package/src/mesh/mesh-event-classify.ts +78 -0
  327. package/src/mesh/mesh-event-forwarding.ts +1964 -0
  328. package/src/mesh/mesh-event-trace.ts +67 -0
  329. package/src/mesh/mesh-events-coordinator.ts +32 -0
  330. package/src/mesh/mesh-events-pending.ts +1494 -0
  331. package/src/mesh/mesh-events-stale.ts +440 -0
  332. package/src/mesh/mesh-events-utils.ts +443 -0
  333. package/src/mesh/mesh-events.ts +43 -1035
  334. package/src/mesh/mesh-fast-forward.ts +856 -0
  335. package/src/mesh/mesh-host-ownership.ts +111 -0
  336. package/src/mesh/mesh-init.ts +350 -0
  337. package/src/mesh/mesh-ledger-reconciliation.ts +12 -7
  338. package/src/mesh/mesh-ledger.ts +898 -102
  339. package/src/mesh/mesh-magi-status.ts +223 -0
  340. package/src/mesh/mesh-missions.ts +568 -0
  341. package/src/mesh/mesh-node-identity.ts +2065 -0
  342. package/src/mesh/mesh-queue-assignment.ts +2247 -0
  343. package/src/mesh/mesh-reconcile-acked-hold.ts +230 -0
  344. package/src/mesh/mesh-reconcile-config.ts +66 -0
  345. package/src/mesh/mesh-reconcile-identity.ts +103 -0
  346. package/src/mesh/mesh-reconcile-loop.ts +1473 -0
  347. package/src/mesh/mesh-reconcile-v2-backstop.ts +62 -0
  348. package/src/mesh/mesh-refine-batch.ts +205 -0
  349. package/src/mesh/mesh-refine-gates.ts +1686 -0
  350. package/src/mesh/mesh-refine-status.ts +231 -0
  351. package/src/mesh/mesh-remote-event-pull.ts +279 -0
  352. package/src/mesh/mesh-review-inbox.ts +308 -0
  353. package/src/mesh/mesh-routing.ts +291 -0
  354. package/src/mesh/mesh-runtime-store.ts +2150 -0
  355. package/src/mesh/mesh-scheduling-runtime.ts +198 -0
  356. package/src/mesh/mesh-task-inflight.ts +70 -0
  357. package/src/mesh/mesh-task-stats.ts +161 -0
  358. package/src/mesh/mesh-unresolved-forward-outbox.ts +185 -0
  359. package/src/mesh/mesh-warmup-deadline.ts +152 -0
  360. package/src/mesh/mesh-work-queue.ts +1437 -147
  361. package/src/mesh/preview-freshness.ts +163 -0
  362. package/src/mesh/refine-config.ts +423 -0
  363. package/src/mesh/worktree-bootstrap-config.ts +599 -0
  364. package/src/providers/acp-provider-instance.ts +43 -10
  365. package/src/providers/approval-utils.d.ts +5 -0
  366. package/src/providers/approval-utils.ts +100 -6
  367. package/src/providers/chat-message-normalization.ts +126 -4
  368. package/src/providers/cli-provider-effect-format.ts +53 -0
  369. package/src/providers/cli-provider-history-dedup.ts +75 -0
  370. package/src/providers/cli-provider-input-prompt.ts +133 -0
  371. package/src/providers/cli-provider-instance-types.ts +131 -0
  372. package/src/providers/cli-provider-instance.ts +2500 -497
  373. package/src/providers/cli-provider-status-helpers.ts +123 -0
  374. package/src/providers/cli-provider-transcript-merge.ts +114 -0
  375. package/src/providers/contracts.d.ts +55 -0
  376. package/src/providers/contracts.ts +160 -6
  377. package/src/providers/extension-provider-instance.ts +12 -7
  378. package/src/providers/external-sources.ts +218 -0
  379. package/src/providers/ide-provider-instance.ts +35 -12
  380. package/src/providers/manual-attendance.ts +105 -0
  381. package/src/providers/native-history/antigravity-claim-registry.ts +131 -0
  382. package/src/providers/native-history/antigravity-cli-transcript.ts +1193 -0
  383. package/src/providers/native-history/claude-cli-transcript.ts +396 -0
  384. package/src/providers/native-history/codex-cli-transcript.ts +479 -0
  385. package/src/providers/native-history/constants.ts +19 -0
  386. package/src/providers/native-history/dispatcher.ts +503 -0
  387. package/src/providers/native-history/hermes-cli-transcript.ts +312 -0
  388. package/src/providers/native-history/index.ts +30 -0
  389. package/src/providers/provider-instance-manager.ts +71 -0
  390. package/src/providers/provider-instance.ts +24 -1
  391. package/src/providers/provider-loader.ts +700 -55
  392. package/src/providers/provider-schema.ts +87 -14
  393. package/src/providers/provider-trust.ts +114 -0
  394. package/src/providers/read-chat-contract.ts +76 -16
  395. package/src/providers/sdk/README.md +49 -0
  396. package/src/providers/sdk/v1/builders/acp/detect-status.ts +144 -0
  397. package/src/providers/sdk/v1/builders/cli/detect-status.ts +313 -0
  398. package/src/providers/sdk/v1/builders/cli/parse-approval-squash.ts +158 -0
  399. package/src/providers/sdk/v1/builders/cli/parse-approval.ts +261 -0
  400. package/src/providers/sdk/v1/builders/cli/parse-session.ts +276 -0
  401. package/src/providers/sdk/v1/builders/cli/visible-region.ts +143 -0
  402. package/src/providers/sdk/v1/fixture-tooling/format.ts +130 -0
  403. package/src/providers/sdk/v1/fixture-tooling/index.ts +22 -0
  404. package/src/providers/sdk/v1/fixture-tooling/replay.ts +352 -0
  405. package/src/providers/sdk/v1/index.ts +152 -0
  406. package/src/providers/sdk/v1/sandbox/README-design.ts +195 -0
  407. package/src/providers/sdk/v1/sandbox/require-whitelist.ts +472 -0
  408. package/src/providers/sdk/v1/sandbox/script-runner.ts +150 -0
  409. package/src/providers/sdk/v1/schemas/cli/provider.schema.json +509 -0
  410. package/src/providers/sdk/v1/schemas/primitives/acp-session-protocol-v1.json +131 -0
  411. package/src/providers/sdk/v1/schemas/primitives/native-history-codex-rollout-v1.json +66 -0
  412. package/src/providers/sdk/v1/schemas/primitives/tui-approval-squash-v1.json +91 -0
  413. package/src/providers/sdk/v1/schemas/primitives/tui-assistant-block-v1.json +91 -0
  414. package/src/providers/sdk/v1/schemas/primitives/tui-cue-ordering-v1.json +47 -0
  415. package/src/providers/sdk/v1/schemas/primitives/tui-dispatch-order-v1.json +32 -0
  416. package/src/providers/sdk/v1/schemas/primitives/tui-footer-chrome-v1.json +42 -0
  417. package/src/providers/sdk/v1/schemas/primitives/tui-index-finder-v1.json +27 -0
  418. package/src/providers/sdk/v1/schemas/primitives/tui-modal-v1.json +125 -0
  419. package/src/providers/sdk/v1/schemas/primitives/tui-prompt-marker-v1.json +45 -0
  420. package/src/providers/sdk/v1/schemas/primitives/tui-session-id-extraction-v1.json +46 -0
  421. package/src/providers/sdk/v1/schemas/primitives/tui-settled-prompt-v1.json +71 -0
  422. package/src/providers/sdk/v1/schemas/primitives/tui-spinner-v1.json +83 -0
  423. package/src/providers/sdk/v1/schemas/primitives/tui-transcript-pty-v1.json +83 -0
  424. package/src/providers/sdk/v1/schemas/primitives/tui-visible-region-v1.json +57 -0
  425. package/src/providers/sdk/v1/schemas/primitives/tui-welcome-screen-v1.json +35 -0
  426. package/src/providers/sdk/v1/types/cli/index.ts +365 -0
  427. package/src/providers/sdk/v1/types/common/index.ts +229 -0
  428. package/src/providers/sdk/v1/validators/index.ts +19 -0
  429. package/src/providers/sdk/v1/validators/manifest.ts +110 -0
  430. package/src/providers/sdk/v1/validators/taint.ts +309 -0
  431. package/src/providers/spec/adapter.ts +246 -0
  432. package/src/providers/spec/cli-adapter.ts +1064 -0
  433. package/src/providers/spec/evaluator.ts +407 -0
  434. package/src/providers/spec/fsm-driver.ts +1528 -0
  435. package/src/providers/spec/fsm-evaluator.ts +290 -0
  436. package/src/providers/spec/fsm-loader.ts +128 -0
  437. package/src/providers/spec/fsm-types.ts +301 -0
  438. package/src/providers/spec/native-history-executor.ts +1241 -0
  439. package/src/providers/spec/pre-launch-trust.ts +104 -0
  440. package/src/providers/spec/route.ts +51 -0
  441. package/src/providers/spec/types.ts +284 -0
  442. package/src/providers/status-monitor.d.ts +7 -7
  443. package/src/providers/status-monitor.ts +37 -22
  444. package/src/providers/transcript-v2.ts +567 -0
  445. package/src/providers/types/interactive-prompt.ts +536 -0
  446. package/src/providers/version-archive.ts +64 -24
  447. package/src/providers/working-dir.ts +23 -0
  448. package/src/repo-mesh-types.ts +868 -13
  449. package/src/runtime-defaults.ts +39 -0
  450. package/src/session-host/managed-host.ts +218 -0
  451. package/src/session-host/runtime-surface.ts +20 -80
  452. package/src/sessions/registry.ts +6 -0
  453. package/src/shared-types-extra.ts +2 -4
  454. package/src/shared-types.d.ts +8 -0
  455. package/src/shared-types.ts +124 -55
  456. package/src/status/builders.ts +26 -6
  457. package/src/status/normalize.ts +2 -0
  458. package/src/status/reporter.ts +19 -1
  459. package/src/status/snapshot.ts +95 -26
  460. package/src/system/hash.ts +23 -0
  461. package/src/system/host-memory.ts +29 -12
  462. package/src/system/load-better-sqlite3.ts +68 -0
  463. package/src/types.ts +5 -0
  464. package/dist/cli-adapters/terminal-backends/xterm-backend.d.ts +0 -17
  465. package/dist/mesh/mesh-sync.d.ts +0 -53
  466. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +0 -16
  467. package/src/cli-adapters/terminal-backends/xterm-backend.ts +0 -97
  468. package/src/mesh/mesh-sync.ts +0 -111
@@ -9,315 +9,271 @@ import * as os from 'os';
9
9
  import * as path from 'path';
10
10
  import * as crypto from 'crypto';
11
11
  import * as fs from 'fs';
12
- import { createRequire } from 'node:module';
13
- import { normalizeInputEnvelope, type ProviderModule, flattenContent, type InputEnvelope, type InputPart } from './contracts.js';
12
+ import { normalizeInputEnvelope, type ProviderModule, flattenContent, type InputEnvelope } from './contracts.js';
14
13
  import { assertProviderSupportsDeclaredInput, getEffectiveMessageInputSupport } from './provider-input-support.js';
15
14
  import type { ProviderInstance, ProviderState, ProviderEvent, InstanceContext, ProviderErrorReason, HotChatSessionState, SessionModalState } from './provider-instance.js';
15
+ import { normalizeInteractivePrompt, normalizeInteractivePromptResponse, type InteractivePrompt } from './types/interactive-prompt.js';
16
16
  import { ProviderCliAdapter } from '../cli-adapters/provider-cli-adapter.js';
17
+ import { shortHash } from '../system/hash.js';
17
18
  import type { CliProviderModule } from '../cli-adapters/provider-cli-adapter.js';
19
+ import { createCliAdapter } from './spec/route.js';
18
20
  import type { PtyRuntimeMetadata, PtyTransportFactory } from '../cli-adapters/pty-transport.js';
19
21
  import { StatusMonitor } from './status-monitor.js';
20
22
  import { ChatHistoryWriter, isNativeSourceCanonicalHistory, materializeProviderNativeHistory, readChatHistory, readProviderChatHistory } from '../config/chat-history.js';
21
23
  import { LOG } from '../logging/logger.js';
24
+ import { recordDebugTrace } from '../logging/debug-trace.js';
25
+ import { shouldCollectTraceCategory } from '../logging/debug-config.js';
26
+ import { traceMeshEventStage, traceMeshEventDrop } from '../mesh/mesh-event-trace.js';
22
27
  import type { ChatMessage } from '../types.js';
23
28
  import { buildPersistedProviderEffectMessage, normalizeProviderEffects } from './control-effects.js';
24
- import { formatAutoApprovalMessage, pickApprovalButton } from './approval-utils.js';
29
+ import { formatAutoApprovalMessage, pickApprovalButton, hasNegativeApprovalOption, hasReliableApprovalAffirmative, looksLikeActiveApprovalPromptText, normalizeApprovalLabel } from './approval-utils.js';
25
30
  import { getCliScriptCommand, parseCliScriptResult } from './cli-script-results.js';
26
31
  import { mergeProviderPatchState, resolveProviderStateSurface } from './provider-patch-state.js';
27
32
  import { normalizeProviderSessionId } from './provider-session-id.js';
28
- import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages } from './chat-message-normalization.js';
29
-
30
- type PersistableCliHistoryMessage = {
31
- role: string;
32
- content: string;
33
- kind?: string;
34
- senderName?: string;
35
- receivedAt?: number;
36
- };
37
-
38
- type CompletedDebouncePending = {
39
- chatTitle: string;
40
- duration: number;
41
- timestamp: number;
42
- firstObservedAt: number;
43
- loggedBlockReason?: string;
44
- };
45
-
46
- const COMPLETED_FINALIZATION_RETRY_MS = 1000;
47
- const COMPLETED_FINALIZATION_MAX_WAIT_MS = 30_000;
48
-
49
- const IMAGE_MIME_EXTENSIONS: Record<string, string> = {
50
- 'image/png': '.png',
51
- 'image/jpeg': '.jpg',
52
- 'image/jpg': '.jpg',
53
- 'image/gif': '.gif',
54
- 'image/webp': '.webp',
55
- 'image/bmp': '.bmp',
56
- 'image/tiff': '.tiff',
57
- 'image/svg+xml': '.svg',
58
- };
59
-
60
- function filePathFromUri(uri: string): string | null {
61
- if (!uri) return null;
62
- if (uri.startsWith('file://')) {
63
- try {
64
- return decodeURIComponent(new URL(uri).pathname);
65
- } catch {
66
- return uri.slice('file://'.length);
67
- }
68
- }
69
- if (path.isAbsolute(uri)) return uri;
70
- return null;
71
- }
72
-
73
- function extensionForImageMime(mimeType: string): string {
74
- return IMAGE_MIME_EXTENSIONS[mimeType.toLowerCase()] || '.img';
75
- }
76
-
77
- function safeInputImageBasename(index: number, mimeType: string): string {
78
- const extension = extensionForImageMime(mimeType);
79
- const suffix = crypto.randomBytes(6).toString('hex');
80
- return `adhdev-input-image-${Date.now()}-${index}-${suffix}${extension}`;
81
- }
82
-
83
- function materializeImageDataPart(part: Extract<InputPart, { type: 'image' }>, index: number, dir: string): string | null {
84
- if (!part.data) return null;
85
- const rawData = part.data.includes(',') ? part.data.split(',').pop() || '' : part.data;
86
- if (!rawData) return null;
87
- fs.mkdirSync(dir, { recursive: true });
88
- const filePath = path.join(dir, safeInputImageBasename(index, part.mimeType));
89
- fs.writeFileSync(filePath, Buffer.from(rawData, 'base64'));
90
- cleanupStaleMaterializedImages(dir);
91
- return filePath;
92
- }
93
-
94
- const MATERIALIZED_IMAGE_MAX_AGE_MS = 60 * 60 * 1000; // 1 hour
95
- const MATERIALIZED_IMAGE_CLEANUP_INTERVAL_MS = 5 * 60 * 1000; // 5 minutes
96
- let lastMaterializedImageCleanupAt = 0;
97
-
98
- function cleanupStaleMaterializedImages(dir: string): void {
99
- const now = Date.now();
100
- if (now - lastMaterializedImageCleanupAt < MATERIALIZED_IMAGE_CLEANUP_INTERVAL_MS) return;
101
- lastMaterializedImageCleanupAt = now;
102
- try {
103
- const entries = fs.readdirSync(dir);
104
- for (const entry of entries) {
105
- if (!entry.startsWith('adhdev-input-image-')) continue;
106
- const fullPath = path.join(dir, entry);
107
- try {
108
- const stat = fs.statSync(fullPath);
109
- if (now - stat.mtimeMs > MATERIALIZED_IMAGE_MAX_AGE_MS) {
110
- fs.unlinkSync(fullPath);
111
- }
112
- } catch { /* file may have been removed concurrently */ }
113
- }
114
- } catch { /* dir may not exist or be inaccessible */ }
115
- }
116
-
117
- function hasNonEmptyCliModalButtons(activeModal: unknown): boolean {
118
- const buttons = (activeModal as any)?.buttons;
119
- return Array.isArray(buttons) && buttons.some((button) => String(button || '').trim().length > 0);
120
- }
121
-
122
- function isCliGeneratingLikeStatus(status: unknown): boolean {
123
- return status === 'generating' || status === 'streaming' || status === 'long_generating' || status === 'starting';
124
- }
125
-
126
- export function buildCliStructuredInputPrompt(
127
- input: InputEnvelope,
128
- options: { materializeDir?: string } = {},
129
- ): string {
130
- const promptParts: string[] = [];
131
- const imageRefs: string[] = [];
132
- const resourceRefs: string[] = [];
133
- const materializeDir = options.materializeDir || path.join(os.tmpdir(), 'adhdev-input-media');
134
-
135
- input.parts.forEach((part, index) => {
136
- if (part.type === 'text' && part.text.trim()) {
137
- promptParts.push(part.text.trim());
138
- return;
139
- }
140
-
141
- if (part.type === 'image') {
142
- const localPath = typeof part.uri === 'string' ? filePathFromUri(part.uri) : null;
143
- const materializedPath = !localPath && part.data ? materializeImageDataPart(part, index, materializeDir) : null;
144
- const ref = localPath || materializedPath || part.uri || '';
145
- if (ref) imageRefs.push(ref);
146
- if (part.alt?.trim()) promptParts.push(part.alt.trim());
147
- return;
148
- }
149
-
150
- if (part.type === 'resource_link') {
151
- resourceRefs.push([part.title, part.name, part.description, part.uri].filter(Boolean).join('\n'));
152
- return;
153
- }
154
-
155
- if (part.type === 'resource') {
156
- resourceRefs.push([part.name, part.text, part.uri].filter(Boolean).join('\n'));
157
- }
158
- });
159
-
160
- // Only use textFallback when no explicit text parts were collected — it is
161
- // the flattened version of the same parts, so appending it alongside them
162
- // would duplicate the content for multipart inputs.
163
- const hasExplicitTextParts = input.parts.some((part) => part.type === 'text' && part.text.trim());
164
- if (!hasExplicitTextParts && input.textFallback.trim()) {
165
- promptParts.push(input.textFallback.trim());
166
- }
167
-
168
- const ordered = [
169
- ...imageRefs,
170
- ...promptParts,
171
- ...resourceRefs,
172
- ].filter((value, index, values) => value.trim().length > 0 && values.indexOf(value) === index);
33
+ import {
34
+ antigravityOwnerToken,
35
+ claimAntigravityConversation,
36
+ releaseAntigravityOwner,
37
+ } from './native-history/antigravity-claim-registry.js';
38
+ import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages, extractFinalSummaryFromMessagesAfter, readChatMessageTimestampMs } from './chat-message-normalization.js';
39
+ import { workingDirBasename } from './working-dir.js';
40
+ import { ManualAttendanceTracker } from './manual-attendance.js';
41
+ import { buildCliStructuredInputPrompt } from './cli-provider-input-prompt.js';
42
+ import { type PersistableCliHistoryMessage, buildIncrementalHistoryAppendMessages } from './cli-provider-history-dedup.js';
43
+ import {
44
+ isIdleStatus,
45
+ getMessageTime,
46
+ hasNonEmptyCliModalButtons,
47
+ isCliGeneratingLikeStatus,
48
+ computeTurnAnchoredDurationMs,
49
+ getDatabaseSync,
50
+ getForcedNewSessionScriptName,
51
+ waitForCliAdapterReady,
52
+ } from './cli-provider-status-helpers.js';
53
+ import {
54
+ STATUS_HYDRATION_TAIL_LIMIT,
55
+ COMPLETED_FINALIZATION_RETRY_MS,
56
+ COMPLETED_FINALIZATION_MAX_WAIT_MS,
57
+ NATIVE_HISTORY_MESH_IDLE_SETTLE_MS,
58
+ USER_INPUT_ACK_DEDUP_WINDOW_MS,
59
+ STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS,
60
+ TERMINAL_MESH_EVENTS,
61
+ } from './cli-provider-instance-types.js';
62
+ import type {
63
+ CompletedDebouncePending,
64
+ CompletedFinalizationBlock,
65
+ CompletionFinalAssistantEvidence,
66
+ ExternalTranscriptProbe,
67
+ } from './cli-provider-instance-types.js';
68
+ import { mergeConversationMessages, buildExternalTranscriptProbe } from './cli-provider-transcript-merge.js';
69
+ import { getEffectDedupKey, formatApprovalRequestMessage, formatMarkerTimestamp } from './cli-provider-effect-format.js';
70
+
71
+ // Re-export moved public symbols so existing importers (index.ts, tests) keep
72
+ // their `./cli-provider-instance.js` path. Pure move — no behavior change.
73
+ export { buildCliStructuredInputPrompt } from './cli-provider-input-prompt.js';
74
+ export { buildIncrementalHistoryAppendMessages } from './cli-provider-history-dedup.js';
75
+ export {
76
+ computeTurnAnchoredDurationMs,
77
+ getForcedNewSessionScriptName,
78
+ waitForCliAdapterReady,
79
+ } from './cli-provider-status-helpers.js';
173
80
 
174
- return ordered.join('\n');
175
- }
176
-
177
- function normalizePersistableCliHistoryContent(content: unknown): string {
178
- return flattenContent(content as any).replace(/\s+/g, ' ').trim();
179
- }
180
-
181
- function buildPersistableCliHistorySignature(message: PersistableCliHistoryMessage): string {
182
- return [
183
- String(message.role || ''),
184
- String(message.kind || ''),
185
- String(message.senderName || ''),
186
- normalizePersistableCliHistoryContent(message.content),
187
- ].join('|');
188
- }
189
-
190
- function hasSamePersistableCliHistoryIdentity(a: PersistableCliHistoryMessage, b: PersistableCliHistoryMessage): boolean {
191
- return String(a?.role || '') === String(b?.role || '')
192
- && String(a?.kind || '') === String(b?.kind || '')
193
- && String(a?.senderName || '') === String(b?.senderName || '')
194
- && String(a?.content || '') === String(b?.content || '');
195
- }
196
-
197
- export function buildIncrementalHistoryAppendMessages(
198
- previousMessages: PersistableCliHistoryMessage[],
199
- currentMessages: PersistableCliHistoryMessage[],
200
- ): PersistableCliHistoryMessage[] {
201
- if (!Array.isArray(currentMessages) || currentMessages.length === 0) return [];
202
- if (!Array.isArray(previousMessages) || previousMessages.length === 0) return currentMessages;
203
-
204
- const comparableLength = Math.min(previousMessages.length, currentMessages.length);
205
- let sharedPrefixLength = 0;
206
- while (
207
- sharedPrefixLength < comparableLength
208
- && hasSamePersistableCliHistoryIdentity(previousMessages[sharedPrefixLength], currentMessages[sharedPrefixLength])
209
- ) {
210
- sharedPrefixLength += 1;
211
- }
212
-
213
- if (sharedPrefixLength === currentMessages.length) return [];
214
- if (sharedPrefixLength === previousMessages.length) return currentMessages.slice(sharedPrefixLength);
215
-
216
- // Rare fallback: preserve the older whitespace-normalized behavior only when
217
- // the cheap identity check detects a changed prefix. Recomputing normalized
218
- // signatures for the full transcript on every idle status poll was a CPU
219
- // hot path for long CLI sessions.
220
- while (
221
- sharedPrefixLength < comparableLength
222
- && buildPersistableCliHistorySignature(previousMessages[sharedPrefixLength])
223
- === buildPersistableCliHistorySignature(currentMessages[sharedPrefixLength])
224
- ) {
225
- sharedPrefixLength += 1;
226
- }
227
-
228
- if (sharedPrefixLength === currentMessages.length) return [];
229
- if (sharedPrefixLength === previousMessages.length) return currentMessages.slice(sharedPrefixLength);
230
- return currentMessages;
231
- }
232
-
233
- let CachedDatabaseSync: (new (path: string, options?: { readOnly?: boolean }) => {
234
- prepare(sql: string): { get(...params: Array<string | number>): unknown };
235
- close(): void;
236
- }) | null = null;
237
-
238
- function getDatabaseSync() {
239
- if (CachedDatabaseSync) return CachedDatabaseSync;
240
- const requireFn = typeof require === 'function'
241
- ? require
242
- : createRequire(path.join(process.cwd(), '__adhdev_sqlite_loader__.js'));
243
- const sqliteModule = requireFn(`node:${'sqlite'}`) as {
244
- DatabaseSync: typeof CachedDatabaseSync;
245
- };
246
- CachedDatabaseSync = sqliteModule.DatabaseSync;
247
- if (!CachedDatabaseSync) {
248
- throw new Error('node:sqlite DatabaseSync unavailable');
249
- }
250
- return CachedDatabaseSync;
81
+ /**
82
+ * The auto-approve settle-gate identity signature: the modal's question line plus
83
+ * the NORMALIZED affirmative label, no volatile counters or raw button set. Shared
84
+ * by the fire path (maybeAutoApproveStatus) and the mask-stall nudge so both compare
85
+ * the SAME identity the settle clock tracks (AUTOAPPROVE-SETTLE-FLAP).
86
+ */
87
+ function approvalModalSignature(message: unknown, affirmativeAnchor: string): string {
88
+ return [typeof message === 'string' ? message.trim() : '', affirmativeAnchor].join('::');
251
89
  }
252
90
 
253
- export function getForcedNewSessionScriptName(
254
- provider: ProviderModule | undefined,
255
- launchMode: 'new' | 'resume' | 'manual',
256
- ): string | null {
257
- if (!provider || launchMode !== 'new') return null;
258
- const resume = provider.resume;
259
- if (!resume?.supported) return null;
260
- if (Array.isArray(resume.newSessionArgs) && resume.newSessionArgs.length > 0) return null;
261
-
262
- const controls = Array.isArray((provider as any).controls) ? (provider as any).controls : [];
263
- for (const control of controls) {
264
- if (control?.type !== 'action') continue;
265
- if (typeof control?.confirmTitle === 'string' && control.confirmTitle.trim()) continue;
266
- if (typeof control?.confirmMessage === 'string' && control.confirmMessage.trim()) continue;
267
- if (typeof control?.confirmLabel === 'string' && control.confirmLabel.trim()) continue;
268
- const invokeScript = typeof control?.invokeScript === 'string' ? control.invokeScript.trim() : '';
269
- if (!invokeScript) continue;
270
- const controlId = typeof control?.id === 'string' ? control.id.trim() : '';
271
- if (controlId === 'new_session' || /^new.?session$/i.test(invokeScript)) {
272
- return invokeScript;
273
- }
274
- }
275
-
276
- return null;
277
- }
91
+ export class CliProviderInstance implements ProviderInstance {
92
+ readonly type: string;
93
+ readonly category = 'cli' as const;
278
94
 
279
- export async function waitForCliAdapterReady(
280
- adapter: { isReady?: () => boolean; getStatus?: () => { status?: string } },
281
- options?: { timeoutMs?: number; pollMs?: number },
282
- ): Promise<void> {
283
- const timeoutMs = Math.max(100, options?.timeoutMs ?? 15_000);
284
- const pollMs = Math.max(10, options?.pollMs ?? 50);
285
- const deadline = Date.now() + timeoutMs;
95
+ /**
96
+ * Quiet period an approval modal's signature must be stable before
97
+ * auto-approve sends the approve key. Guards against firing on a prompt
98
+ * that is still streaming into the PTY (the "resolves too fast" symptom):
99
+ * while the modal text/buttons are still changing, every frame yields a
100
+ * new signature and the settle clock restarts. Once the prompt finishes
101
+ * rendering the signature holds and the key is sent after this window.
102
+ * Bounded + small so genuine approvals stay timely. The FSM is already
103
+ * authoritative over the `waiting_approval` state; this only delays the
104
+ * keystroke until the modal *content* has settled.
105
+ */
106
+ private static readonly AUTO_APPROVE_SETTLE_MS = 600;
286
107
 
287
- while (Date.now() < deadline) {
288
- if (adapter?.isReady?.()) return;
289
- const status = adapter?.getStatus?.()?.status;
290
- if (status === 'stopped') {
291
- throw new Error('CLI runtime stopped before it became ready');
292
- }
293
- await new Promise((resolve) => setTimeout(resolve, pollMs));
294
- }
108
+ /**
109
+ * Busy-side hysteresis for the settle gate. A momentary `generating` flip
110
+ * while the SAME approval modal's button block is still on screen (its
111
+ * question line scrolled out of the captured frame, only the buttons + a
112
+ * residual `esc to interrupt` spinner remain) briefly reports
113
+ * status!=waiting_approval. Without hysteresis that flip wipes the settle
114
+ * clock, and the modal→generating→modal flap restarts the 600ms window
115
+ * every time so auto-approve never fires. We keep the in-progress settle
116
+ * gate warm across an inactive blip up to this bound; only once the modal
117
+ * has genuinely stayed gone this long (a real resolution → idle) is the
118
+ * gate cleared. Bounded so a genuinely new, later approval still re-settles
119
+ * from scratch rather than firing on a stale timestamp.
120
+ */
121
+ private static readonly AUTO_APPROVE_GATE_HYSTERESIS_MS = 1500;
295
122
 
296
- throw new Error(`CLI runtime did not become ready within ${timeoutMs}ms`);
297
- }
123
+ /**
124
+ * AUTOAPPROVE-FLAP-RECUR (Fix B): extended busy-side continuity window for a
125
+ * DELEGATED-WORKER auto-approve episode that is genuinely still cycling.
126
+ *
127
+ * The default AUTO_APPROVE_GATE_HYSTERESIS_MS (1500) absorbs a *momentary*
128
+ * `generating` blip. But a delegated worker running a Bash approval observed
129
+ * the FSM cycle the FULL state waiting_approval → busy → waiting_approval on a
130
+ * 2–5s period (the button set scrolls in/out AND the modal question repaints,
131
+ * so the adapter genuinely reports status=generating for whole seconds between
132
+ * approval frames). Each busy phase outran the 1500ms hysteresis, so the
133
+ * settle clock was WIPED (the genuine-resolution branch), the 600ms settle
134
+ * window never accumulated across the flap, resolveModal never fired
135
+ * (resolveModal count 0), and the mask-stall clock instead tripped at 4500ms →
136
+ * coordinator nudge → the flap the coordinator observed.
137
+ *
138
+ * A genuine resolution and a flap both start with a busy phase; they diverge
139
+ * only in whether waiting_approval RETURNS. So we cannot simply lengthen the
140
+ * blanket hysteresis (that would make every real resolution hold the gate
141
+ * open for seconds). Instead this longer window applies ONLY while an active
142
+ * mask episode is alive (autoApproveMaskSince > 0) AND the session is a
143
+ * delegated worker — i.e. exactly the never-resolving-flap case. A foreground
144
+ * / attended session keeps the tight 1500ms window unchanged. The mask-stall
145
+ * bound below still caps the episode, so a worker whose approval truly never
146
+ * returns is surfaced to the coordinator within AUTO_APPROVE_MASK_STALL_MS
147
+ * rather than held forever.
148
+ */
149
+ private static readonly AUTO_APPROVE_FLAP_CONTINUITY_MS = 4000;
298
150
 
299
- export class CliProviderInstance implements ProviderInstance {
300
- readonly type: string;
301
- readonly category = 'cli' as const;
151
+ /**
152
+ * STATUS-MISMATCH: upper bound on how long the auto-approve→`generating` SURFACE
153
+ * mask may hide a worker's `waiting_approval` (status + activeModal) before we give
154
+ * up and surface the real prompt. The mask exists because auto-approve is expected
155
+ * to resolve the modal momentarily; but if it STALLS without ever calling
156
+ * resolveModal — the modal signature never settles for AUTO_APPROVE_SETTLE_MS (a
157
+ * perpetually-flapping/streaming prompt), no concrete modal is ever captured, or the
158
+ * modal is a picker/non-affirmative we never auto-pick — the mask would persist
159
+ * forever and read_chat / mesh_status / the dashboard would NEVER see the pending
160
+ * approval (the coordinator cannot mesh_approve what it cannot see). Once an episode
161
+ * exceeds this bound we stop masking. Generously larger than
162
+ * AUTO_APPROVE_SETTLE_MS (600) + AUTO_APPROVE_GATE_HYSTERESIS_MS (1500) so a
163
+ * legitimately slow-settling / blip-flapping prompt is never unmasked early; a
164
+ * genuine never-resolving stall surfaces within this window. The settle gate keeps
165
+ * running underneath, so a prompt that finally stabilises still auto-approves, and
166
+ * mesh_approve (raw FSM, unmasked) works throughout.
167
+ */
168
+ private static readonly AUTO_APPROVE_MASK_STALL_MS = 4500;
302
169
 
303
170
  private adapter: ProviderCliAdapter;
304
171
  private context: InstanceContext | null = null;
305
172
  private events: ProviderEvent[] = [];
306
173
  private lastStatus: string = 'starting';
174
+ // Idempotency guard for the queue-claim agent:ready event. agent:ready is the
175
+ // sole signal the mesh coordinator's tryAssignQueueTask waits on to hand a
176
+ // queued task to this worker. It is emitted in two places: the boot-time
177
+ // starting→idle one-shot, and the readySeen re-arm below. This flag makes the
178
+ // event fire AT MOST ONCE per session so a worker is never claimed twice and a
179
+ // queued task is never double-dispatched/double-injected. Whichever path fires
180
+ // first sets it; the other becomes a no-op.
181
+ private agentReadyEmitted = false;
307
182
  private generatingStartedAt: number = 0;
183
+ // FALSE-IDLE continuity epoch: monotonically bumped on EVERY entry into a busy
184
+ // phase (→generating or →waiting_approval). The completedDebouncePending snapshots
185
+ // this value at arm time (busyEpochAtArm); the flush guard requires it UNCHANGED
186
+ // — proving the session did not re-enter a busy phase (a momentary busy→idle blip
187
+ // in an inter-approval valley) between arming the debounce and flushing it. A
188
+ // single point-sample of status at flush time cannot see a generating phase that
189
+ // opened AND closed within the settle window; the epoch can. See
190
+ // flushCompletedDebounceIfFinalized.
191
+ private busyEpoch: number = 0;
192
+ // GENERATING-BOUNDARY (R4b): the per-turn taskId for which a startup-grace
193
+ // started+completed pair was already synthesized. Both fast-collapse callers
194
+ // (starting→idle transition AND the idle-stayed no-status-change poll) route
195
+ // through maybeSynthesizeStartupGraceCollapse; the idle-stayed caller re-polls
196
+ // steadily while the session sits idle, so this guard makes the synthesis fire
197
+ // AT MOST ONCE per collapsed turn.
198
+ private fastCollapseSynthesizedTaskId: string | null = null;
199
+ // GENERATING-BOUNDARY (R4c): the wall-clock moment the FSM's starting→idle
200
+ // startup-grace collapse was observed (set ONCE, on the first starting→idle
201
+ // transition this boot). The idle-stayed collapse window is anchored on THIS,
202
+ // not on instance/boot time (this.startedAt): the FSM spends the full 8s
203
+ // startup-grace sitting in 'starting' before collapsing, and a turn can be
204
+ // dispatched a few seconds AFTER the collapse — measuring the window from boot
205
+ // would have it already closed by the time that turn lands+completes (the live
206
+ // R4b miss: collapse at boot+8s, dispatch at boot+12.4s > the 12s boot window).
207
+ // Anchoring on the collapse moment makes the window cover dispatch-delay+turn.
208
+ private startupGraceCollapseAt: number | null = null;
308
209
  private settings: Record<string, any> = {};
309
210
  private monitor: StatusMonitor;
310
211
  private generatingDebounceTimer: NodeJS.Timeout | null = null;
311
212
  private generatingDebouncePending: { chatTitle: string; timestamp: number } | null = null;
312
- private lastApprovalEventAt = 0;
213
+ private lastApprovalEventFingerprint = '';
313
214
  private autoApproveBusy = false;
314
215
  private autoApproveBusyTimer: NodeJS.Timeout | null = null;
216
+ private lastAutoApprovalSignature = '';
217
+ // Settle gate: the approval modal's signature + the wall-clock when this
218
+ // exact signature was first observed. Auto-approve only fires once the
219
+ // SAME signature has been stable for AUTO_APPROVE_SETTLE_MS, so a prompt
220
+ // still streaming into the PTY (its buttons/message changing frame to
221
+ // frame) keeps resetting the timer and is never approved half-rendered.
222
+ private pendingAutoApprovalSignature = '';
223
+ private pendingAutoApprovalSince = 0;
224
+ private autoApproveSettleTimer: NodeJS.Timeout | null = null;
225
+ // Wall-clock when auto-approve first observed status!=waiting_approval while
226
+ // a settle gate was in progress. Drives AUTO_APPROVE_GATE_HYSTERESIS_MS (or,
227
+ // for a delegated-worker flap episode, AUTO_APPROVE_FLAP_CONTINUITY_MS) so a
228
+ // brief generating flip does not immediately wipe the settle clock.
229
+ private autoApproveInactiveSince = 0;
230
+ // AUTOAPPROVE-FLAP-RECUR (Fix A): wall-clock when the CURRENT waiting_approval
231
+ // episode last presented a concrete, captured modal (buttons.length > 0). The
232
+ // Claude TUI momentarily reports status=waiting_approval with activeModal=null
233
+ // / an empty button block while the button block scrolls out of the captured
234
+ // frame; the raw guard below (buttons.length===0) used to bail on that frame,
235
+ // never advancing the settle gate and leaving no re-check armed — so a modal
236
+ // that flapped modal=none ↔ N-buttons around the settle boundary never
237
+ // accumulated its 600ms. This tracks the last GOOD-modal frame so a short
238
+ // scroll-out blip is absorbed (settle keeps running against the last captured
239
+ // signature) while a genuinely closed modal — buttons empty continuously past
240
+ // the continuity window — is still recognised and resets the gate.
241
+ private autoApproveLastModalSeenAt = 0;
242
+ // STATUS-MISMATCH: wall-clock when the CURRENT auto-approve episode (waiting_approval
243
+ // + shouldAutoApprove) first began wanting to mask. Unlike pendingAutoApprovalSince it
244
+ // is NOT reset when the modal signature changes (a still-streaming/flapping prompt) and
245
+ // survives the same hysteresis blips the settle gate does, so it measures the TRUE age
246
+ // of an unresolved auto-approve. Once it exceeds AUTO_APPROVE_MASK_STALL_MS the surface
247
+ // mask is dropped so the real waiting_approval surfaces. Cleared when the episode ends
248
+ // (modal genuinely gone, manual attendance takes over, or auto-approve fires).
249
+ private autoApproveMaskSince = 0;
250
+ // NOTIF-APPROVAL-MASKED (Q1b): the autoApproveMaskSince episode value for which a
251
+ // stalled-approval coordinator nudge has already been emitted, so the nudge fires
252
+ // exactly once per stalled auto-approve episode (0 = none emitted). Reusing the
253
+ // per-episode mask-clock value as the key makes it provider-agnostic (no reliance on
254
+ // approvalEntrySeq) and self-resetting: each new episode gets a fresh
255
+ // autoApproveMaskSince timestamp, and the episode-end reset zeroes it.
256
+ private stalledApprovalNudgeEpisode = 0;
257
+ // Provider-common manual-attendance signal: while a human is actively driving
258
+ // this session from the dashboard, auto-approve holds so they can take manual
259
+ // control. Background mesh workers are never attended → delegated auto-approve
260
+ // is unaffected.
261
+ private readonly manualAttendance = new ManualAttendanceTracker();
315
262
  private controlValues: Record<string, string | number | boolean> = {};
316
263
  private summaryMetadata: unknown = undefined;
317
264
  private appliedEffectKeys = new Set<string>();
318
265
  private historyWriter: ChatHistoryWriter;
319
266
  private runtimeMessages: Array<{ key: string; message: ChatMessage }> = [];
320
267
  private lastPersistedHistoryMessages: PersistableCliHistoryMessage[] = [];
268
+ private lastAcknowledgedUserInputAt = 0;
269
+ // TASKBUBBLE-DUP: per-content last-ack timestamps so the same dispatched
270
+ // prompt acked twice in quick succession (the worker buffers the first
271
+ // send during bootstrap/busy, then a redelivery — dispatch-confirm-timeout
272
+ // requeue or a reconcile re-dispatch — fires a SECOND send_chat before the
273
+ // outbound queue drains) collapses to ONE user bubble. Keyed on the trimmed
274
+ // content; an entry older than USER_INPUT_ACK_DEDUP_WINDOW_MS is treated as
275
+ // a fresh, intentional resend and is NOT suppressed.
276
+ private recentUserInputAcks = new Map<string, number>();
321
277
  private lastNativeSourceCanonicalCheckAt = 0;
322
278
  private lastNativeSourceCanonicalCacheKey: string | undefined = undefined;
323
279
  private cachedSqliteDb: {
@@ -330,6 +286,7 @@ export class CliProviderInstance implements ProviderInstance {
330
286
  private suppressIdleHistoryReplay = false;
331
287
  private errorMessage: string | undefined = undefined;
332
288
  private errorReason: ProviderErrorReason | undefined = undefined;
289
+ private activeInteractivePrompt: InteractivePrompt | null = null;
333
290
 
334
291
  private presentationMode: 'terminal' | 'chat';
335
292
  private providerSessionId?: string;
@@ -370,7 +327,10 @@ export class CliProviderInstance implements ProviderInstance {
370
327
  this.providerSessionId = options?.providerSessionId;
371
328
  this.launchMode = options?.launchMode || 'new';
372
329
  this.onProviderSessionResolved = options?.onProviderSessionResolved;
373
- this.adapter = new ProviderCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory);
330
+ this.adapter = createCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory) as ProviderCliAdapter;
331
+ if (this.providerSessionId) {
332
+ this.adapter.updateRuntimeMeta({ providerSessionId: this.providerSessionId });
333
+ }
374
334
  this.monitor = new StatusMonitor();
375
335
  this.historyWriter = new ChatHistoryWriter();
376
336
  }
@@ -389,8 +349,8 @@ export class CliProviderInstance implements ProviderInstance {
389
349
  this.adapter.updateRuntimeSettings?.(this.settings);
390
350
  this.monitor.updateConfig({
391
351
  approvalAlert: this.settings.approvalAlert !== false,
392
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
393
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
352
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
353
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
394
354
  });
395
355
 
396
356
  // Server connection
@@ -412,14 +372,14 @@ export class CliProviderInstance implements ProviderInstance {
412
372
  await this.adapter.spawn();
413
373
  await this.enforceFreshSessionLaunchIfNeeded();
414
374
  this.maybeAppendRuntimeRecoveryMessage(this.adapter.getRuntimeMetadata());
415
- if (this.providerSessionId) {
375
+ if (this.providerSessionId && this.shouldHydrateExistingProviderHistory()) {
416
376
  this.restorePersistedHistoryFromCurrentSession();
417
377
  }
418
378
  if (this.providerSessionId && this.launchMode === 'resume') {
419
379
  const resumedAt = Date.now();
420
380
  this.historyWriter.appendSystemMarker(
421
381
  this.type,
422
- `Resumed saved session at ${this.formatMarkerTimestamp(resumedAt)}`,
382
+ `Resumed saved session at ${formatMarkerTimestamp(resumedAt)}`,
423
383
  {
424
384
  instanceId: this.instanceId,
425
385
  historySessionId: this.providerSessionId,
@@ -486,14 +446,38 @@ export class CliProviderInstance implements ProviderInstance {
486
446
  }
487
447
 
488
448
  getState(): ProviderState {
449
+ // TODO(phase5-sandbox): JS override scripts (detectStatus, parseApproval,
450
+ // parseSession) are currently invoked by CliScriptRunner.invoke() via direct
451
+ // function calls — the scripts run in the daemon process with full Node.js
452
+ // access and no resource limits.
453
+ //
454
+ // When Phase 5 lands, CliScriptRunner should route these calls through a
455
+ // SandboxedScriptRunner (see providers/sdk/v1/sandbox/script-runner.ts) so
456
+ // that each call gets a fresh isolated-vm context with a 50 ms CPU limit and
457
+ // a 32 MB memory cap. The execution path to change is:
458
+ // CliScriptRunner.invoke() → SandboxedScriptRunner.run(scriptSource, context)
459
+ //
460
+ // This getState() call-site is NOT where the change goes — the wiring belongs
461
+ // in cli-script-runner.ts (CliScriptRunner.detectStatus / parseApproval /
462
+ // parseSession), with provider-loader.ts updated to store script source strings
463
+ // alongside the loaded function references for extended-legacy providers.
489
464
  const adapterStatus = this.adapter.getStatus();
465
+ if (Object.prototype.hasOwnProperty.call(adapterStatus, 'activeInteractivePrompt')) {
466
+ this.activeInteractivePrompt = adapterStatus.activeInteractivePrompt ?? null;
467
+ }
490
468
  let parsedStatus: any = null;
491
469
  let parseErrorMessage: string | undefined;
492
470
  if (typeof this.adapter.getScriptParsedStatus === 'function') {
493
471
  try {
494
472
  parsedStatus = this.adapter.getScriptParsedStatus() || null;
495
- this.errorMessage = undefined;
496
- this.errorReason = undefined;
473
+ const parsedErrorMessage = typeof parsedStatus?.errorMessage === 'string' && parsedStatus.errorMessage.trim()
474
+ ? parsedStatus.errorMessage.trim()
475
+ : undefined;
476
+ const parsedErrorReason = typeof parsedStatus?.errorReason === 'string' && parsedStatus.errorReason.trim()
477
+ ? parsedStatus.errorReason.trim() as ProviderErrorReason
478
+ : undefined;
479
+ this.errorMessage = parsedErrorMessage;
480
+ this.errorReason = parsedErrorReason;
497
481
  } catch (error: any) {
498
482
  parseErrorMessage = error?.message || String(error);
499
483
  this.errorMessage = parseErrorMessage;
@@ -503,22 +487,59 @@ export class CliProviderInstance implements ProviderInstance {
503
487
  this.errorMessage = undefined;
504
488
  this.errorReason = undefined;
505
489
  }
506
- const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, Date.now());
507
- const visibleStatus = parseErrorMessage
508
- ? 'error'
509
- : (autoApproveActive ? 'generating' : adapterStatus.status);
510
- const parsedProviderSessionId = normalizeProviderSessionId(
490
+ const adapterProviderSessionId = normalizeProviderSessionId(
511
491
  this.provider,
512
- typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
492
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
513
493
  );
514
- if (parsedProviderSessionId) {
515
- this.promoteProviderSessionId(parsedProviderSessionId);
494
+ const nowMs = Date.now();
495
+ // STATUS-MISMATCH: maybeAutoApproveStatus still runs for its side effects (settle gate,
496
+ // resolveModal fire), but the SURFACE mask is dropped once the episode has stalled past
497
+ // AUTO_APPROVE_MASK_STALL_MS — otherwise a never-settling auto-approve hides the worker's
498
+ // waiting_approval + modal from read_chat/mesh_status/dashboard forever.
499
+ const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, nowMs)
500
+ && !this.autoApproveMaskStalled(nowMs);
501
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
502
+ let visibleStatus = parseErrorMessage || parsedStatus?.status === 'error'
503
+ ? 'error'
504
+ : (autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status);
505
+ // getState() must agree with the status the FSM-driven detectStatusTransition()
506
+ // already committed to lastStatus. The adapter's own status is authoritative; we do
507
+ // not second-guess it with native-transcript shape. Only reconcile a generating-like
508
+ // read down to idle when our own lastStatus has already flipped idle (avoids a
509
+ // perpetual dashboard spinner during the brief window before the next getStatus()).
510
+ if (isCliGeneratingLikeStatus(visibleStatus) && this.lastStatus === 'idle') {
511
+ visibleStatus = 'idle';
516
512
  }
517
513
  const runtime = this.adapter.getRuntimeMetadata();
518
514
  this.maybeAppendRuntimeRecoveryMessage(runtime);
519
515
  let parsedMessages = Array.isArray(parsedStatus?.messages)
520
516
  ? parsedStatus.messages
521
517
  : [];
518
+ const parsedProviderSessionId = normalizeProviderSessionId(
519
+ this.provider,
520
+ typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
521
+ );
522
+ const suppressFreshLaunchStartupReplay = this.shouldSuppressFreshLaunchStartupReplay(
523
+ parsedMessages,
524
+ parsedStatus,
525
+ adapterStatus,
526
+ parsedProviderSessionId,
527
+ );
528
+ if (adapterProviderSessionId && !suppressFreshLaunchStartupReplay) {
529
+ this.promoteProviderSessionId(adapterProviderSessionId);
530
+ }
531
+ if (parsedProviderSessionId && !suppressFreshLaunchStartupReplay) {
532
+ this.promoteProviderSessionId(parsedProviderSessionId);
533
+ }
534
+ if (suppressFreshLaunchStartupReplay) {
535
+ parsedMessages = [];
536
+ }
537
+ // Adapter runtime metadata is transport-owned and is not guaranteed to
538
+ // identify this conversation. Spec adapters historically exposed the
539
+ // provider spec id (for example "codex-cli") as runtimeId, which made
540
+ // concurrent sessions share one activeChat identity until their native
541
+ // provider session ids were discovered.
542
+ const activeChatId = this.providerSessionId || this.instanceId;
522
543
  const historyMessageCount = Number.isFinite(parsedStatus?.historyMessageCount)
523
544
  ? Math.max(0, Number(parsedStatus.historyMessageCount))
524
545
  : null;
@@ -527,10 +548,21 @@ export class CliProviderInstance implements ProviderInstance {
527
548
  ? parsedMessages.slice(-historyMessageCount)
528
549
  : [];
529
550
  }
530
- const mergedMessages = this.mergeConversationMessages(parsedMessages);
531
- const canonicalBackedHistory = this.syncCanonicalSavedHistoryIfNeeded();
551
+ const mergedMessages = mergeConversationMessages(this.runtimeMessages, parsedMessages);
552
+ const canonicalBackedHistory = this.shouldHydrateExistingProviderHistory()
553
+ ? this.syncCanonicalSavedHistoryIfNeeded()
554
+ : false;
555
+ const statusMessages = canonicalBackedHistory && this.lastPersistedHistoryMessages.length > 0
556
+ ? this.lastPersistedHistoryMessages.map((message) => ({
557
+ role: message.role,
558
+ content: message.content,
559
+ kind: message.kind,
560
+ senderName: message.senderName,
561
+ receivedAt: message.receivedAt,
562
+ }))
563
+ : mergedMessages;
532
564
 
533
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
565
+ const dirName = workingDirBasename(this.workingDir);
534
566
  const parsedChatStatus = typeof parsedStatus?.status === 'string' && parsedStatus.status.trim()
535
567
  ? parsedStatus.status.trim()
536
568
  : undefined;
@@ -542,7 +574,7 @@ export class CliProviderInstance implements ProviderInstance {
542
574
  && adapterStatus.status === 'idle'
543
575
  && parsedStatus?.status === 'idle';
544
576
  let messagesToSave = parsedMessages;
545
- if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'long_generating')) {
577
+ if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'no_progress' || parsedChatStatus === 'long_generating')) {
546
578
  const lastIdx = messagesToSave.length - 1;
547
579
  if (lastIdx >= 0 && messagesToSave[lastIdx]?.role === 'assistant') {
548
580
  messagesToSave = messagesToSave.slice(0, lastIdx);
@@ -572,33 +604,48 @@ export class CliProviderInstance implements ProviderInstance {
572
604
  }
573
605
  }
574
606
 
575
- this.applyProviderResponse(parsedStatus, { phase: 'immediate' });
607
+ this.applyProviderResponse(
608
+ suppressFreshLaunchStartupReplay && parsedStatus && typeof parsedStatus === 'object'
609
+ ? { ...parsedStatus, providerSessionId: undefined }
610
+ : parsedStatus,
611
+ { phase: 'immediate' },
612
+ );
576
613
  const surface = resolveProviderStateSurface({
577
614
  summaryMetadata: this.summaryMetadata as any,
578
615
  controlValues: this.controlValues,
579
616
  });
580
617
  const activeChatStatus = parseErrorMessage
581
618
  ? 'error'
582
- : autoApproveActive && parsedStatus?.status === 'waiting_approval'
619
+ : (autoApproveActive && parsedStatus?.status === 'waiting_approval') || autoApproveHoldIdle
583
620
  ? 'generating'
584
621
  : (adapterStatus.status !== 'idle'
585
622
  ? visibleStatus
586
623
  : (suppressStaleParsedBusyStatus ? visibleStatus : (parsedChatStatus || visibleStatus)));
587
624
 
625
+ // If an AskUserQuestion prompt is awaiting user input, overlay status as
626
+ // waiting_choice. This is distinct from waiting_approval (tool-use consent)
627
+ // — the engine's isWaitingForResponse state is unchanged, so completion
628
+ // tracking continues normally once the user responds.
629
+ const hasInteractivePrompt = !!this.activeInteractivePrompt;
630
+ const finalStatus = hasInteractivePrompt ? 'waiting_choice' : visibleStatus;
631
+ const finalChatStatus = hasInteractivePrompt ? 'waiting_choice' : activeChatStatus;
632
+
588
633
  return {
589
634
  type: this.type,
590
635
  name: this.provider.name,
591
636
  category: 'cli',
592
- status: visibleStatus,
637
+ status: finalStatus,
593
638
  mode: this.presentationMode,
594
639
  activeChat: {
595
- id: `${this.type}_${this.workingDir}`,
640
+ id: activeChatId,
596
641
  title: parsedStatus?.title || dirName,
597
- status: activeChatStatus,
598
- messages: mergedMessages,
599
- activeModal: autoApproveActive ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
642
+ status: finalChatStatus,
643
+ messages: statusMessages,
644
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
645
+ activeInteractivePrompt: this.activeInteractivePrompt,
600
646
  inputContent: '',
601
647
  },
648
+ activeInteractivePrompt: this.activeInteractivePrompt,
602
649
  workspace: this.workingDir,
603
650
  instanceId: this.instanceId,
604
651
  providerSessionId: this.providerSessionId,
@@ -638,8 +685,12 @@ export class CliProviderInstance implements ProviderInstance {
638
685
 
639
686
  getHotChatSessionState(): HotChatSessionState {
640
687
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
641
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
642
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
688
+ const nowMs = Date.now();
689
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
690
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
691
+ && !this.autoApproveMaskStalled(nowMs);
692
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
693
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
643
694
  const runtime = this.adapter.getRuntimeMetadata();
644
695
  return {
645
696
  id: this.instanceId,
@@ -651,36 +702,274 @@ export class CliProviderInstance implements ProviderInstance {
651
702
  };
652
703
  }
653
704
 
654
- getSessionModalState(): SessionModalState {
655
- const adapterStatus = this.adapter.getStatus({ allowParse: false });
656
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
657
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
658
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
705
+ getSessionModalState(sessionId?: string): SessionModalState {
706
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
707
+ const nowMs = Date.now();
708
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
709
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
710
+ && !this.autoApproveMaskStalled(nowMs);
711
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
712
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
713
+ const dirName = workingDirBasename(this.workingDir);
659
714
  return {
660
- id: this.instanceId,
715
+ // Honor the caller-supplied sessionId — InstanceMgr rejects the
716
+ // projection when projected.id !== requested sessionId, and
717
+ // this.instanceId is the manager's internal key, not the public
718
+ // sessionId the dashboard subscribes by.
719
+ id: sessionId ?? this.instanceId,
661
720
  status: visibleStatus,
662
721
  title: dirName,
663
- activeModal: autoApproveActive ? null : adapterStatus.activeModal,
722
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : adapterStatus.activeModal,
664
723
  };
665
724
  }
666
725
 
667
726
  updateSettings(newSettings: Record<string, any>): void {
668
- this.settings = { ...newSettings };
727
+ // Merge semantics: a key omitted from newSettings preserves its existing
728
+ // value, a key present in newSettings (even as false) overrides it.
729
+ //
730
+ // This is required because updateSettings has two callers with opposite
731
+ // intent:
732
+ // 1. Full re-injection — the dashboard toggle path (handleSetProviderSetting
733
+ // → getSettings → updateInstanceSettings) sends the COMPLETE settings
734
+ // object, so an explicit autoApprove:false must win.
735
+ // 2. Partial stamp — the mesh relay-safety stamp (router.ts agent_command,
736
+ // buildMeshWorkerRelayStamp) sends ONLY {meshNodeFor, meshNodeId,
737
+ // meshCoordinatorDaemonId, launchedByCoordinator} on every coordinator
738
+ // re-dispatch. It carries no autoApprove, so a full replacement would
739
+ // wipe the launch-time autoApprove:true the worker was started with,
740
+ // silently dropping every later approval to a manual gate until the
741
+ // machine-page toggle re-injected the full settings.
742
+ //
743
+ // A plain merge satisfies both: undefined keys fall through to the existing
744
+ // value (preserving launch-stamp settings like autoApprove + the mesh routing
745
+ // keys), explicit keys override. This subsumes the previous mesh-key preserve
746
+ // list, which only protected the routing keys and not autoApprove.
747
+ this.settings = { ...this.settings, ...newSettings };
669
748
  this.adapter.updateRuntimeSettings?.(this.settings);
670
749
  this.monitor.updateConfig({
671
750
  approvalAlert: this.settings.approvalAlert !== false,
672
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
673
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
751
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
752
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
674
753
  });
675
754
  }
676
755
 
756
+ /**
757
+ * Stamp a direct-dispatch mesh assignment on this instance.
758
+ * setupMeshEventForwarding reads settings.meshNodeFor + meshActiveTaskId to
759
+ * route generating_completed back to the originating coordinator. Without
760
+ * this stamp, mesh_send_task --direct targets a plain CLI session whose
761
+ * completion events silently drop because the forwarder has nothing to
762
+ * match against.
763
+ */
764
+ attachMeshAssignment(assignment: { meshId: string; nodeId?: string; taskId?: string; coordinatorDaemonId?: string; coordinatorSessionId?: string }): void {
765
+ if (!assignment?.meshId) return;
766
+ this.settings = {
767
+ ...this.settings,
768
+ meshNodeFor: assignment.meshId,
769
+ // WTCLAIM (A): track the bound node id under BOTH the active marker
770
+ // (meshNodeId, cleared on detach) and a sticky marker (meshLastNodeId,
771
+ // preserved across detach). The sticky marker lets a detached but still
772
+ // coordinator-owned session be re-picked ONLY for the SAME node it served
773
+ // — never auto-adopted for a sibling node (e.g. a cloned worktree) that
774
+ // shares this daemon. See isMeshOwnedDelegateSession's post-detach gate.
775
+ ...(assignment.nodeId ? { meshNodeId: assignment.nodeId, meshLastNodeId: assignment.nodeId } : {}),
776
+ ...(assignment.taskId ? { meshActiveTaskId: assignment.taskId } : {}),
777
+ ...(assignment.coordinatorDaemonId ? { meshCoordinatorDaemonId: assignment.coordinatorDaemonId } : {}),
778
+ // Session-level routing anchor: the originating coordinator session, so this
779
+ // worker's completion events route back to the exact session that dispatched it.
780
+ ...(assignment.coordinatorSessionId ? { meshCoordinatorSessionId: assignment.coordinatorSessionId } : {}),
781
+ };
782
+ this.adapter.updateRuntimeSettings?.(this.settings);
783
+ }
784
+
785
+ /**
786
+ * Clear a previously-attached mesh assignment after the task reaches a
787
+ * terminal state. Leaving meshNodeFor pinned would route this session's
788
+ * subsequent unrelated turns (e.g. ad-hoc dashboard chats) to the
789
+ * coordinator as if they were task completions.
790
+ *
791
+ * MESHID-DROP-ON-DETACH (Fix C): a coordinator-LAUNCHED worker session
792
+ * (launchedByCoordinator) holds its mesh membership (meshNodeFor / meshNodeId /
793
+ * meshCoordinatorDaemonId) at the SESSION level — set once at launch
794
+ * (mesh_launch_session / queue auto-launch), independent of any single task.
795
+ * The original detach wiped meshNodeFor + meshNodeId together with the
796
+ * task-level meshActiveTaskId, so the FIRST task completion stripped the
797
+ * membership and EVERY subsequent completion forwarded with meshId absent —
798
+ * resolveWorkerDelegateRouting fell to mesh_unresolved and the coordinator
799
+ * rejected the forward "meshId required". For a launched member we therefore
800
+ * clear ONLY the task-level marker (meshActiveTaskId) and preserve the
801
+ * session-level membership so its next task's completion still resolves.
802
+ * A task-less ad-hoc turn on a preserved-membership session is NOT misrouted:
803
+ * its completion carries no taskId and the session holds no active assignment,
804
+ * so the forwarder's WARMUPGAP guard skips the dispatch-row flip (it only
805
+ * injects a benign task-less notification). A NON-launched session (a plain CLI
806
+ * session adopted by mesh_send_task --direct, launchedByCoordinator falsy)
807
+ * keeps the original full clear so an ad-hoc session is never left pinned.
808
+ */
809
+ detachMeshAssignment(): void {
810
+ if (!this.settings.meshNodeFor && !this.settings.meshActiveTaskId && !this.settings.meshNodeId) return;
811
+ // Session-level member: keep membership, drop only the task-level marker.
812
+ if (this.settings.launchedByCoordinator === true) {
813
+ if (!this.settings.meshActiveTaskId) return;
814
+ const { meshActiveTaskId, ...rest } = this.settings;
815
+ void meshActiveTaskId;
816
+ this.settings = rest;
817
+ this.adapter.updateRuntimeSettings?.(this.settings);
818
+ return;
819
+ }
820
+ const { meshNodeFor, meshNodeId, meshActiveTaskId, ...rest } = this.settings;
821
+ void meshNodeFor; void meshActiveTaskId;
822
+ // WTCLAIM (A): clear the active binding but PRESERVE the last bound node id
823
+ // (meshLastNodeId) so a later sessionless dispatch can re-adopt this idle
824
+ // session ONLY for the node it last served. Carry the id being cleared, or
825
+ // keep an already-present sticky marker if meshNodeId was absent.
826
+ const lastNodeId = (typeof meshNodeId === 'string' && meshNodeId.trim())
827
+ ? meshNodeId.trim()
828
+ : (typeof rest.meshLastNodeId === 'string' && rest.meshLastNodeId.trim() ? rest.meshLastNodeId.trim() : undefined);
829
+ this.settings = lastNodeId ? { ...rest, meshLastNodeId: lastNodeId } : rest;
830
+ this.adapter.updateRuntimeSettings?.(this.settings);
831
+ }
832
+
833
+ /**
834
+ * The resolved modal-park status of this session, or null when it is not
835
+ * parked on a modal awaiting a human answer. Mirrors the overlay logic in
836
+ * getState(): an active AskUserQuestion interactive prompt resolves to
837
+ * waiting_choice; otherwise the adapter's waiting_approval (tool consent)
838
+ * counts — UNLESS auto-approve will dismiss it, in which case the session is
839
+ * effectively generating and is NOT modal-parked. This is the single signal
840
+ * the mesh force-inject guard consults, and the same status string the
841
+ * reconcile loop reads off get_status_metadata. Lowercase literals only —
842
+ * the SessionStatus enum is forked across modules and waiting_choice is
843
+ * absent from some of them.
844
+ */
845
+ resolveModalParkStatus(): 'waiting_choice' | 'waiting_approval' | null {
846
+ if (this.activeInteractivePrompt) return 'waiting_choice';
847
+ let adapterStatus: { status?: string };
848
+ try {
849
+ adapterStatus = this.adapter.getStatus({ allowParse: false });
850
+ } catch {
851
+ return null;
852
+ }
853
+ // A session whose auto-approve is held by manual attendance IS parked on a
854
+ // modal awaiting the human — autoApproveEffectivelyActive folds that in, so
855
+ // the mesh force-inject guard correctly treats it as modal-parked. STATUS-MISMATCH:
856
+ // a STALLED auto-approve (never resolving) is likewise effectively parked — treat it
857
+ // as modal-parked so its events are held/surfaced rather than masked behind generating.
858
+ if (adapterStatus.status === 'waiting_approval'
859
+ && (!this.autoApproveEffectivelyActive(adapterStatus.status) || this.autoApproveMaskStalled())) {
860
+ // NOTIF-HELD-DRAIN (Fix 1): an autonomous mesh session (coordinator or worker)
861
+ // that is actively progressing a turn — a tool call is in flight
862
+ // (hasAdapterPendingResponse) and NO human is attending it by hand — surfaces a
863
+ // routine tool-consent `waiting_approval` on EVERY tool call when auto-approve is
864
+ // off. That transient consent is part of the turn the harness/operator drives to
865
+ // completion, NOT a session genuinely wedged awaiting a human's modal answer.
866
+ // Classifying it modal-parked makes findLiveCoordinators hold the mesh's pending
867
+ // completion events under `modal_parked` across a busy coordinator's whole work
868
+ // batch, which is the multi-minute notification stall. Treat such a transient
869
+ // consent as NOT modal-parked so it is held as ordinary "generating" (released on
870
+ // the next idle) instead. A manually-attended session, a stalled auto-approve, or a
871
+ // non-progressing session (no turn in flight) still parks — those are the genuine
872
+ // human-await cases the guard must keep holding.
873
+ if (this.isTransientToolConsent()) {
874
+ return null;
875
+ }
876
+ return 'waiting_approval';
877
+ }
878
+ return null;
879
+ }
880
+
881
+ /**
882
+ * NOTIF-HELD-DRAIN: true when this `waiting_approval` is a routine, transient tool-consent
883
+ * of an autonomously-progressing mesh session rather than a genuine human-await modal —
884
+ * i.e. it is a mesh coordinator/worker session, a turn is actively in flight
885
+ * (hasAdapterPendingResponse), and no human is attending it by hand. Such a consent is
886
+ * driven to resolution by the harness/operator as part of the in-flight turn, so holding
887
+ * the mesh's completion events behind it (modal_parked) is the false-positive that stalls
888
+ * delivery. Narrow by design: manual attendance or a non-progressing session falls through
889
+ * to the genuine-modal classification.
890
+ */
891
+ private isTransientToolConsent(now = Date.now()): boolean {
892
+ return this.isAutonomousMeshSession()
893
+ && this.hasAdapterPendingResponse()
894
+ && !this.manualAttendance.isAttended(now);
895
+ }
896
+
897
+ /** True when this session is parked on a modal awaiting a human answer. */
898
+ isModalParked(): boolean {
899
+ return this.resolveModalParkStatus() !== null;
900
+ }
901
+
902
+ /**
903
+ * PTY-OVERTRUST-DRAIN (Defect B). The deliverability/drain status the mesh
904
+ * reconcile loop must consult — the RAW adapter turn-state, with the
905
+ * auto-approve "hold-idle" visual mask STRIPPED.
906
+ *
907
+ * getState().status overlays `autoApproveHoldIdle`/`autoApproveActive` to paint a
908
+ * genuinely-idle adapter as `generating` (a UI-flicker suppression while an
909
+ * auto-approve key-press settles — see getState() ~:800). That mask is correct
910
+ * for the dashboard, but the reconcile loop trusts it as "the coordinator is
911
+ * busy" and therefore HOLDS a worker's completion under
912
+ * `generating_no_idle_coordinator` even though the coordinator's PTY is at a real
913
+ * turn end and would accept the inject as a turn — the completion is stranded.
914
+ *
915
+ * This accessor reports the drain truth instead:
916
+ * - 'modal_parked' — a GENUINE human-await modal (AskUserQuestion / a non-
917
+ * transient tool-consent). Still excluded from drain (a force-inject here
918
+ * writes raw keystrokes the modal eats → data corruption). Mirrors
919
+ * isModalParked(), evaluated first so a parked session never reads idle.
920
+ * - 'idle' — the RAW adapter is at a turn end (adapter.getStatus(allowParse:false)
921
+ * === 'idle') and the session is not modal-parked. Drain-eligible REGARDLESS
922
+ * of the auto-approve mask. This is the case the mask used to hide.
923
+ * - 'generating' — the raw adapter is genuinely mid-turn. Held (a raw PTY write
924
+ * into a generating claude-cli is not consumed as a turn → data loss). The
925
+ * intentional removal of force-inject-into-generating is preserved.
926
+ * - 'other' — any other raw status (error / starting / waiting_choice handled by
927
+ * modal-park above). Not a drain target.
928
+ *
929
+ * Uses allowParse:false (engine.activeModal only, side-effect-free) so it never
930
+ * mutates the very auto-approve mask state the diagnostics read.
931
+ */
932
+ getDrainStatus(): 'idle' | 'generating' | 'modal_parked' | 'other' {
933
+ if (this.isModalParked()) return 'modal_parked';
934
+ let rawStatus: string;
935
+ try {
936
+ const raw = this.adapter.getStatus({ allowParse: false })?.status;
937
+ rawStatus = typeof raw === 'string' ? raw.trim() : '';
938
+ } catch {
939
+ return 'other';
940
+ }
941
+ if (rawStatus === 'idle') return 'idle';
942
+ if (isCliGeneratingLikeStatus(rawStatus)) return 'generating';
943
+ return 'other';
944
+ }
945
+
677
946
  onEvent(event: string, data?: any): void {
678
947
  if (event === 'send_message') {
679
948
  const input = normalizeInputEnvelope(data);
680
949
  assertProviderSupportsDeclaredInput(this.provider, input);
681
950
  const promptText = buildCliStructuredInputPrompt(input);
682
951
  if (promptText) {
683
- void this.adapter.sendMessage(promptText).catch((e: any) => {
952
+ // force:true bypasses the busy/generating send guard so terminal mesh
953
+ // events (completion/failure/bootstrap) land in a coordinator session that
954
+ // is itself parked in `generating` while awaiting that very event.
955
+ // Without it the message is queued and only flushed on the coordinator's
956
+ // own idle transition — which never happens until it receives the message.
957
+ const force = data?.force === true;
958
+ // Modal guard: a force-inject still writes raw keystrokes into the PTY,
959
+ // bypassing the busy send-guard. If the coordinator is parked on a
960
+ // harness modal (claude-cli AskUserQuestion → waiting_choice, or a
961
+ // tool-consent waiting_approval), those keystrokes are consumed by the
962
+ // modal's key handler and silently select a choice the user never made
963
+ // (data corruption). Hold the force-inject in that narrow window —
964
+ // the event stays queued and the reconcile loop redelivers it on the
965
+ // next tick once the modal is resolved. We ONLY hold for the two modal
966
+ // states; generating is still force-injected (that is the deadlock the
967
+ // force path exists to break — see mesh-events-coordinator).
968
+ if (force && this.isModalParked()) {
969
+ LOG.info('CLI', `[${this.type}] force send_message held — coordinator parked on modal (${this.resolveModalParkStatus()})`);
970
+ return;
971
+ }
972
+ void this.adapter.sendMessage(promptText, force ? { force: true } : {}).catch((e: any) => {
684
973
  LOG.warn('CLI', `[${this.type}] send_message failed: ${e?.message || e}`);
685
974
  });
686
975
  }
@@ -690,14 +979,118 @@ export class CliProviderInstance implements ProviderInstance {
690
979
  void this.adapter.resolveAction(data).catch((e: any) => {
691
980
  LOG.warn('CLI', `[${this.type}] resolve_action failed: ${e?.message || e}`);
692
981
  });
982
+ } else if (event === 'interactive_prompt' && data) {
983
+ const prompt = normalizeInteractivePrompt(data);
984
+ if (prompt) {
985
+ this.activeInteractivePrompt = prompt;
986
+ this.events.push({
987
+ event: 'interactive_prompt',
988
+ timestamp: Date.now(),
989
+ promptId: prompt.promptId,
990
+ });
991
+ }
992
+ } else if (event === 'interactive_prompt_response' && data) {
993
+ try {
994
+ const response = normalizeInteractivePromptResponse(data);
995
+ if (this.activeInteractivePrompt?.promptId === response.promptId) {
996
+ this.activeInteractivePrompt = null;
997
+ }
998
+ if (typeof this.adapter.setInteractivePromptResponse !== 'function') {
999
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response ignored: adapter does not support interactive prompts`);
1000
+ return;
1001
+ }
1002
+ void this.adapter.setInteractivePromptResponse(response).catch((e: any) => {
1003
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response failed: ${e?.message || e}`);
1004
+ });
1005
+ } catch (e: any) {
1006
+ LOG.warn('CLI', `[${this.type}] invalid interactive_prompt_response: ${e?.message || e}`);
1007
+ }
693
1008
  } else if (event === 'provider_state_patch' && data && typeof data === 'object') {
694
1009
  this.applyProviderResponse(data, { phase: 'immediate' });
695
1010
  }
696
1011
  }
697
1012
 
1013
+ recordAcknowledgedUserInput(input: InputEnvelope | string): void {
1014
+ const content = typeof input === 'string'
1015
+ ? input.trim()
1016
+ : buildCliStructuredInputPrompt(input).trim();
1017
+ if (!content) return;
1018
+
1019
+ const receivedAt = Date.now();
1020
+
1021
+ // TASKBUBBLE-DUP: collapse a redelivered dispatch to one bubble. A single
1022
+ // mesh_send_task can reach this instance as TWO send_chat calls when the
1023
+ // first injection is buffered during bootstrap/busy and a retry (dispatch-
1024
+ // confirm-timeout requeue, or a reconcile re-dispatch) fires before the
1025
+ // outbound queue drains. The previous dedupKey hashed receivedAt, so the
1026
+ // two acks produced different keys and BOTH bubbled. Suppress an identical
1027
+ // content ack seen within USER_INPUT_ACK_DEDUP_WINDOW_MS; a later resend of
1028
+ // the same text (beyond the window) is a genuine new turn and still shows.
1029
+ const ackContentKey = shortHash(`${this.instanceId}:${content}`, 24);
1030
+ const lastAckAt = this.recentUserInputAcks.get(ackContentKey);
1031
+ if (lastAckAt !== undefined && receivedAt - lastAckAt <= USER_INPUT_ACK_DEDUP_WINDOW_MS) {
1032
+ // Refresh the timestamp so a steady stream of redeliveries keeps
1033
+ // collapsing, and prune stale entries to bound the map size.
1034
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1035
+ this.pruneRecentUserInputAcks(receivedAt);
1036
+ return;
1037
+ }
1038
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1039
+ this.pruneRecentUserInputAcks(receivedAt);
1040
+
1041
+ this.lastAcknowledgedUserInputAt = receivedAt;
1042
+ // The runtimeMessages dedupKey stays per-call unique (includes receivedAt)
1043
+ // so a genuine resend of the same text after the window appends a fresh
1044
+ // bubble; redelivery within the window is already suppressed above.
1045
+ const dedupKey = `user_input_ack:${shortHash(`${this.instanceId}:${content}:${receivedAt}`, 24)}`;
1046
+ this.appendRuntimeMessage(buildChatMessage({
1047
+ role: 'user',
1048
+ senderName: 'User',
1049
+ kind: 'standard',
1050
+ content,
1051
+ receivedAt,
1052
+ timestamp: receivedAt,
1053
+ source: 'runtime_input_ack',
1054
+ meta: {
1055
+ runtimeInputAck: true,
1056
+ provider: this.type,
1057
+ workspace: this.workingDir,
1058
+ },
1059
+ } as ChatMessage), dedupKey);
1060
+ }
1061
+
1062
+ /** Drop user-input ack entries older than the dedup window so the map can't grow unbounded. */
1063
+ private pruneRecentUserInputAcks(now: number): void {
1064
+ if (this.recentUserInputAcks.size <= 1) return;
1065
+ for (const [key, at] of this.recentUserInputAcks) {
1066
+ if (now - at > USER_INPUT_ACK_DEDUP_WINDOW_MS) this.recentUserInputAcks.delete(key);
1067
+ }
1068
+ }
1069
+
1070
+ /**
1071
+ * Owner token for this session in the antigravity conversation-claim
1072
+ * registry. Derived identically to the dispatcher's read-side token
1073
+ * (workspace + spawn time) so the claims the dispatcher records under this
1074
+ * session are the ones dispose() releases.
1075
+ */
1076
+ private antigravityClaimOwner(): string {
1077
+ return antigravityOwnerToken(this.workingDir, this.startedAt);
1078
+ }
1079
+
698
1080
  dispose(): void {
1081
+ // Release this session's antigravity conversation claims so the store
1082
+ // becomes available again (e.g. a later resume) and the registry doesn't
1083
+ // leak entries for dead sessions.
1084
+ if (this.type === 'antigravity-cli') {
1085
+ const owner = this.antigravityClaimOwner();
1086
+ if (owner) releaseAntigravityOwner(owner);
1087
+ }
699
1088
  this.adapter.shutdown();
700
1089
  this.monitor.reset();
1090
+ // Cancel any armed auto-approve timers so a pending settle re-check
1091
+ // can't fire resolveModal/detectStatusTransition against a dead adapter.
1092
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
1093
+ if (this.autoApproveBusyTimer) { clearTimeout(this.autoApproveBusyTimer); this.autoApproveBusyTimer = null; }
701
1094
  this.appliedEffectKeys.clear();
702
1095
  try { this.cachedSqliteDb?.close(); } catch { /* noop */ }
703
1096
  this.cachedSqliteDb = null;
@@ -706,6 +1099,7 @@ export class CliProviderInstance implements ProviderInstance {
706
1099
 
707
1100
  private completedDebounceTimer: NodeJS.Timeout | null = null;
708
1101
  private completedDebouncePending: CompletedDebouncePending | null = null;
1102
+ private lastExternalCompletionProbe: ExternalTranscriptProbe | null = null;
709
1103
 
710
1104
  private async enforceFreshSessionLaunchIfNeeded(): Promise<void> {
711
1105
  const scriptName = getForcedNewSessionScriptName(this.provider, this.launchMode);
@@ -734,13 +1128,233 @@ export class CliProviderInstance implements ProviderInstance {
734
1128
  this.applyProviderResponse(parsed.payload, { phase: 'immediate' });
735
1129
  }
736
1130
 
737
- private completionHasFinalAssistantMessage(messages: unknown): boolean {
1131
+ private completionHasFinalAssistantMessage(messages: unknown, turnStartedAt?: number): boolean {
738
1132
  const visibleMessages = (Array.isArray(messages) ? messages : [])
739
1133
  .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
740
1134
  const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
741
1135
  const role = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : '';
742
1136
  const content = lastVisible ? flattenContent(lastVisible.content).trim() : '';
743
- return role === 'assistant' && !!content;
1137
+ if (role !== 'assistant' || !content) return false;
1138
+ // Guard: if the last assistant message looks like an active approval/input prompt,
1139
+ // it is not a real completion — the session is still awaiting user input.
1140
+ if (looksLikeActiveApprovalPromptText(content)) return false;
1141
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): when a producing-turn start is
1142
+ // known, the final assistant bubble must POST-DATE it. A STALE mid-turn assistant
1143
+ // (predating this turn's start — e.g. the last bubble of a prior sub-turn observed
1144
+ // during an inter-approval valley) must NOT satisfy the finalization gate, or a
1145
+ // false-idle blip emits a completion carrying that stale summary. A bubble with no
1146
+ // parseable timestamp cannot be proven stale, so it is kept (fails open — behaviour
1147
+ // identical to before for providers/paths that carry no timestamps).
1148
+ if (typeof turnStartedAt === 'number' && Number.isFinite(turnStartedAt) && turnStartedAt > 0) {
1149
+ // readChatMessageTimestampMs mirrors the summary turn-scoping reader
1150
+ // (extractFinalSummaryFromMessagesAfter) — same seconds-vs-ms heuristic and
1151
+ // field precedence — so the present-check and the summary-scope agree on which
1152
+ // bubbles predate the turn.
1153
+ const ts = readChatMessageTimestampMs(lastVisible);
1154
+ if (typeof ts === 'number' && ts < turnStartedAt) return false;
1155
+ }
1156
+ return true;
1157
+ }
1158
+
1159
+ private recordPendingTranscriptProbe(pending: CompletedDebouncePending): ExternalTranscriptProbe | null {
1160
+ const probe = this.lastExternalCompletionProbe;
1161
+ if (!probe) return null;
1162
+ const history = pending.transcriptProbeHistory || [];
1163
+ const last = history[history.length - 1];
1164
+ if (!last || last.readAt !== probe.readAt || last.msgCount !== probe.msgCount || last.lastRole !== probe.lastRole || last.contentLen !== probe.contentLen) {
1165
+ history.push(probe);
1166
+ pending.transcriptProbeHistory = history.slice(-5);
1167
+ }
1168
+ return probe;
1169
+ }
1170
+
1171
+ /**
1172
+ * The spawned CLI's env overrides (e.g. the mesh coordinator points hermes
1173
+ * at a per-coordinator HERMES_HOME so its state.db lives in a tmpdir instead
1174
+ * of ~/.hermes). The native-history executor expands `${HERMES_HOME:-~/.hermes}`
1175
+ * from this map, so the completion gate MUST pass it through — otherwise the
1176
+ * gate reads ~/.hermes, finds no coordinator-session transcript, and
1177
+ * false-fires missing_final_assistant on every coordinator turn.
1178
+ */
1179
+ private spawnedEnvOverrides(): Record<string, string> | undefined {
1180
+ const meta = typeof (this.adapter as any)?.getRuntimeMetadata === 'function'
1181
+ ? (this.adapter as any).getRuntimeMetadata()
1182
+ : undefined;
1183
+ const env = meta && typeof meta === 'object' ? (meta as Record<string, unknown>).spawnedEnv : undefined;
1184
+ return env && typeof env === 'object' ? env as Record<string, string> : undefined;
1185
+ }
1186
+
1187
+ private readExternalCompletionMessages(): unknown[] | null {
1188
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1189
+ if (!adapterOwnsMessagesElsewhere) return null;
1190
+ if (!this.providerSessionId) return null;
1191
+ if (!isNativeSourceCanonicalHistory(this.provider.nativeHistory)) return null;
1192
+
1193
+ if (this.lastExternalCompletionProbe?.sourcePath) {
1194
+ try { fs.statSync(this.lastExternalCompletionProbe.sourcePath); } catch { /* best-effort metadata refresh */ }
1195
+ }
1196
+ const restoredHistory = readProviderChatHistory(this.type, {
1197
+ canonicalHistory: this.provider.nativeHistory,
1198
+ historySessionId: this.providerSessionId,
1199
+ workspace: this.workingDir,
1200
+ offset: 0,
1201
+ limit: Number.MAX_SAFE_INTEGER,
1202
+ historyBehavior: this.provider.historyBehavior,
1203
+ scripts: this.provider.scripts as any,
1204
+ sessionStartedAtMs: this.startedAt,
1205
+ envOverrides: this.spawnedEnvOverrides(),
1206
+ forceRefresh: true,
1207
+ });
1208
+ if (restoredHistory.source !== 'provider-native') {
1209
+ this.lastExternalCompletionProbe = null;
1210
+ return null;
1211
+ }
1212
+ this.lastExternalCompletionProbe = buildExternalTranscriptProbe(
1213
+ restoredHistory.messages,
1214
+ restoredHistory.sourcePath,
1215
+ restoredHistory.sourceMtimeMs,
1216
+ );
1217
+ return restoredHistory.messages;
1218
+ }
1219
+
1220
+ private completionFinalAssistantEvidence(parsedMessages: unknown, turnStartedAt?: number): CompletionFinalAssistantEvidence {
1221
+ // (FALSEIDLE FixB) UPPER-BOUND turn-end evidence. completionHasFinalAssistantMessage is a
1222
+ // pure message-content check ("does the last visible bubble read as a finalized assistant
1223
+ // reply, post-dating the turn start?"). That LOWER bound alone treated the FIRST assistant
1224
+ // bubble of a turn that is STILL running — a tool call in flight between two assistant
1225
+ // bubbles — as proof the turn ended (RCA cases a & b). Require in ADDITION that the turn is
1226
+ // genuinely OVER: hasAdapterPendingResponse() folds the three upper-bound discriminators
1227
+ // into one — currentTurnScope closed, no in-flight tool (isProcessing false), and no partial
1228
+ // response buffer. So a mid-turn point-sample (short-gen / fast-collapse inline paths that
1229
+ // do NOT route through getCompletedFinalizationBlock) yields present=false and is held/settled
1230
+ // rather than fired. A genuinely-finished turn (adapter idle, no pending) is unaffected — the
1231
+ // gate stays open and the completion fires exactly as before. This mirrors the established
1232
+ // `completionHasFinalAssistantMessage(...) && !hasAdapterPendingResponse()` pairing already
1233
+ // used by the no-progress monitor reconcile path.
1234
+ const turnClosed = !this.hasAdapterPendingResponse();
1235
+ if (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)) {
1236
+ return {
1237
+ present: turnClosed,
1238
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1239
+ source: 'parsed',
1240
+ };
1241
+ }
1242
+
1243
+ const externalMessages = this.readExternalCompletionMessages();
1244
+ if (externalMessages) {
1245
+ return {
1246
+ present: turnClosed && this.completionHasFinalAssistantMessage(externalMessages, turnStartedAt),
1247
+ messages: externalMessages,
1248
+ source: 'external-native',
1249
+ };
1250
+ }
1251
+
1252
+ return {
1253
+ present: false,
1254
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1255
+ source: 'unavailable',
1256
+ };
1257
+ }
1258
+
1259
+ private completionFinalSummary(parsedMessages: unknown, turnStartedAt?: number): string | undefined {
1260
+ // For native-source providers (claude-cli: chatMessagesOwnedExternally), the PTY
1261
+ // screen parse is NOT the source of truth for the final summary — the terminal
1262
+ // wraps/scrolls/clips text, so a screen-parsed assistant message is often a partial
1263
+ // prefix (e.g. 76 chars of a 112-char turn). The append-only native transcript holds
1264
+ // the complete turn. Prefer it whenever it yields a longer/complete summary; fall back
1265
+ // to the parsed screen only when the transcript is unavailable. This is the real cause
1266
+ // of the truncated finalSummary — independent of cloud vs standalone (it surfaces on
1267
+ // any short, fast-completing task where screen parse wins the race).
1268
+ //
1269
+ // NOTIF Defect-B: `turnStartedAt` (the producing turn's start, snapshotted on the
1270
+ // completedDebouncePending record) turn-scopes the NATIVE transcript read. The native
1271
+ // transcript holds the WHOLE session filtered only by session start, so a debounce that
1272
+ // flushes before the producing turn's final assistant bubble has landed would otherwise
1273
+ // return the PRIOR task's last bubble (event taskId=B but summary=A). Filtering to bubbles
1274
+ // at/after turnStartedAt yields '' in that race instead of the stale tail; the weak/empty
1275
+ // summary is later upgraded by the mesh reconcile loop once the real bubble is written.
1276
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1277
+ // FALSE-IDLE Defect 1b: turn-scope the PARSED screen fallback too. Without this a stale
1278
+ // mid-turn assistant (predating turnStartedAt) that the turn-boundary gate already
1279
+ // rejected as evidence could still leak into the finalSummary via this parsed fallback
1280
+ // when the external transcript's turn-scoped read is empty — freezing the very stale text
1281
+ // the gate rejected. extractFinalSummaryFromMessagesAfter drops bubbles before the turn
1282
+ // start; with no boundary known (turnStartedAt falsy) it is identical to the unscoped read.
1283
+ const parsedSummary = extractFinalSummaryFromMessagesAfter(
1284
+ (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)
1285
+ ? (Array.isArray(parsedMessages) ? parsedMessages : [])
1286
+ : []) as any,
1287
+ turnStartedAt,
1288
+ );
1289
+ if (adapterOwnsMessagesElsewhere) {
1290
+ const externalMessages = this.readExternalCompletionMessages();
1291
+ // Turn-scope the external transcript: never return a bubble produced before this
1292
+ // turn started. With no boundary known (turnStartedAt falsy) behaviour is unchanged.
1293
+ const externalSummary = externalMessages
1294
+ ? extractFinalSummaryFromMessagesAfter(externalMessages as any, turnStartedAt)
1295
+ : '';
1296
+ // The transcript is authoritative for native-source providers. Use it unless it is
1297
+ // empty (not yet written, or no in-turn bubble) — only then fall back to the screen
1298
+ // parse, which reflects the LIVE screen (this turn's output), not the stale tail.
1299
+ if (externalSummary) return externalSummary;
1300
+ return parsedSummary || undefined;
1301
+ }
1302
+ return parsedSummary || undefined;
1303
+ }
1304
+
1305
+ private buildCompletedFinalizationDiagnostic(args: {
1306
+ blockReason: string;
1307
+ latestStatus?: any;
1308
+ latestVisibleStatus: string;
1309
+ waitedMs: number;
1310
+ pending: CompletedDebouncePending;
1311
+ emittedAfterFinalizationTimeout: boolean;
1312
+ }): Record<string, unknown> {
1313
+ let parsed: any = null;
1314
+ let parseError: string | undefined;
1315
+ try {
1316
+ parsed = this.adapter.getScriptParsedStatus();
1317
+ } catch (error: any) {
1318
+ parseError = error?.message || String(error);
1319
+ }
1320
+
1321
+ const evidence = this.completionFinalAssistantEvidence(parsed?.messages);
1322
+ if (evidence.source === 'external-native') {
1323
+ this.recordPendingTranscriptProbe(args.pending);
1324
+ }
1325
+ const visibleMessages = (Array.isArray(evidence.messages) ? evidence.messages : [])
1326
+ .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
1327
+ const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
1328
+ const lastVisibleRole = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : null;
1329
+ const lastVisibleKind = typeof (lastVisible as any)?.kind === 'string' ? (lastVisible as any).kind : null;
1330
+ const lastVisibleContentLength = lastVisible ? flattenContent(lastVisible.content).trim().length : 0;
1331
+
1332
+ return {
1333
+ providerType: this.type,
1334
+ sessionId: this.instanceId,
1335
+ providerSessionId: this.providerSessionId || null,
1336
+ workspace: this.workingDir,
1337
+ blockReason: args.blockReason,
1338
+ emittedAfterFinalizationTimeout: args.emittedAfterFinalizationTimeout,
1339
+ waitedMs: args.waitedMs,
1340
+ maxWaitMs: COMPLETED_FINALIZATION_MAX_WAIT_MS,
1341
+ adapterStatus: typeof args.latestStatus?.status === 'string' ? args.latestStatus.status : null,
1342
+ latestVisibleStatus: args.latestVisibleStatus,
1343
+ parsedStatus: typeof parsed?.status === 'string' ? parsed.status : (parseError ? 'parse_error' : 'unknown'),
1344
+ parseError: parseError || undefined,
1345
+ finalAssistantPresent: evidence.present,
1346
+ finalAssistantEvidenceSource: evidence.source,
1347
+ visibleMessageCount: visibleMessages.length,
1348
+ lastVisibleRole,
1349
+ lastVisibleKind,
1350
+ lastVisibleContentLength,
1351
+ pendingStartedAt: this.generatingStartedAt || null,
1352
+ pendingFirstObservedAt: args.pending.firstObservedAt,
1353
+ pendingTimestamp: args.pending.timestamp,
1354
+ pendingDurationSec: args.pending.duration,
1355
+ previousBlockReason: args.pending.loggedBlockReason || null,
1356
+ transcriptProbeHistory: args.pending.transcriptProbeHistory || [],
1357
+ };
744
1358
  }
745
1359
 
746
1360
  private hasAdapterPendingResponse(): boolean {
@@ -765,41 +1379,310 @@ export class CliProviderInstance implements ProviderInstance {
765
1379
  if (!isCliGeneratingLikeStatus(parsedRawStatus)) return false;
766
1380
  if (adapterRawStatus !== 'idle') return false;
767
1381
  if (hasNonEmptyCliModalButtons(parsedStatus?.activeModal ?? parsedStatus?.modal)) return false;
768
- return !this.hasAdapterPendingResponse();
1382
+ if (this.hasAdapterPendingResponse()) return false;
1383
+ // Do not suppress when the adapter's raw response buffer is still non-empty.
1384
+ // This catches the case where isWaitingForResponse has already flipped to false
1385
+ // (so getPartialResponse() returns '') but the provider's native parser still
1386
+ // reports generating because it's parsing buffered content. Suppressing the
1387
+ // finalization block here would emit a false completion event while the provider
1388
+ // session is still actively processing its response stream.
1389
+ const adapterAny = this.adapter as any;
1390
+ if (typeof adapterAny?.responseBuffer === 'string' && adapterAny.responseBuffer.trim()) return false;
1391
+ return true;
769
1392
  }
770
1393
 
771
- private getCompletedFinalizationBlockReason(latestVisibleStatus: string): string | null {
772
- if (latestVisibleStatus !== 'idle') return `status:${latestVisibleStatus}`;
1394
+ private getCompletedFinalizationBlock(latestVisibleStatus: string, pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1395
+ if (latestVisibleStatus !== 'idle') return { reason: `status:${latestVisibleStatus}`, terminal: true };
773
1396
 
774
1397
  const adapterAny = this.adapter as any;
775
- if (adapterAny?.isWaitingForResponse === true) return 'adapter_waiting_for_response';
776
- if (adapterAny?.currentTurnScope) return 'adapter_turn_scope_active';
1398
+ const approvalResolvedIdle = pending.previousStatus === 'waiting_approval';
1399
+ // (FALSEIDLE-a FixA) The adapter pending-response checks run UNCONDITIONALLY.
1400
+ // Previously they were SKIPPED when approvalResolvedIdle, on the assumption that
1401
+ // a waiting_approval→idle transition proved the approval's turn was over. But
1402
+ // auto-approve RESOLVES the modal and the agent RESUMES the same turn — currentTurnScope
1403
+ // / isWaitingForResponse stay set, or a tool runs — so skipping the guard let the FIRST
1404
+ // assistant bubble of the still-running turn be mistaken for the last and fired an early
1405
+ // completion the coordinator could never correct (RCA case a). Keep the guard live for the
1406
+ // approval path too: when the resumed turn genuinely ends these clear and the completion
1407
+ // fires. Approval-resolved holds are NON-terminal (bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS)
1408
+ // so a provider that never closes its turn-scope still force-fires a weak completion rather
1409
+ // than wedging; the non-approval path keeps its terminal hold (a genuinely-busy adapter must
1410
+ // never force a completion out).
1411
+ if (adapterAny?.isWaitingForResponse === true) return { reason: 'adapter_waiting_for_response', terminal: !approvalResolvedIdle };
1412
+ if (adapterAny?.currentTurnScope) return { reason: 'adapter_turn_scope_active', terminal: !approvalResolvedIdle };
1413
+ if (this.hasAdapterPendingResponse()) return { reason: 'adapter_pending_response', terminal: !approvalResolvedIdle };
777
1414
 
778
1415
  const partial = typeof this.adapter.getPartialResponse === 'function'
779
1416
  ? this.adapter.getPartialResponse()
780
1417
  : '';
781
- if (typeof partial === 'string' && partial.trim()) return 'partial_response_pending';
1418
+ if (typeof partial === 'string' && partial.trim()) return { reason: 'partial_response_pending', terminal: true };
782
1419
 
783
1420
  let parsed: any;
784
1421
  try {
785
1422
  parsed = this.adapter.getScriptParsedStatus();
786
1423
  } catch (error: any) {
787
- return `parse_error:${error?.message || String(error)}`;
1424
+ return { reason: `parse_error:${error?.message || String(error)}` };
788
1425
  }
789
1426
 
790
1427
  const parsedStatus = typeof parsed?.status === 'string' ? parsed.status : 'unknown';
791
- if (parsedStatus !== 'idle') return `parsed_status:${parsedStatus}`;
792
- if (parsed?.activeModal || parsed?.modal) return 'parsed_modal_active';
793
- if (!this.completionHasFinalAssistantMessage(parsed?.messages)) return 'missing_final_assistant';
1428
+ if (parsedStatus !== 'idle') {
1429
+ const adapterStatus = this.adapter.getStatus({ allowParse: false });
1430
+ if (this.shouldSuppressStaleParsedBusyStatus(parsed, adapterStatus)) return null;
1431
+ return { reason: `parsed_status:${parsedStatus}`, terminal: isCliGeneratingLikeStatus(parsedStatus) };
1432
+ }
1433
+ if (parsed?.activeModal || parsed?.modal) return { reason: 'parsed_modal_active', terminal: true };
1434
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1435
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): turn-scope the present-check so a
1436
+ // STALE mid-turn assistant (predating pending.turnStartedAt) cannot satisfy the
1437
+ // finalization gate. Only the confirming final-assistant bubble that POST-DATES this
1438
+ // turn's start counts as evidence the turn genuinely ended.
1439
+ const finalAssistantEvidence = this.completionFinalAssistantEvidence(parsed?.messages, pending.turnStartedAt);
1440
+ const allowMissingAssistantTimeout = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1441
+ LOG.debug('CLI', `[${this.type}] finalAssistantEvidence: present=${finalAssistantEvidence.present} source=${finalAssistantEvidence.source} adapterOwnsMessagesElsewhere=${adapterOwnsMessagesElsewhere} parsedStatus=${parsedStatus}`);
1442
+ if (!finalAssistantEvidence.present) {
1443
+ if (adapterOwnsMessagesElsewhere) {
1444
+ if (finalAssistantEvidence.source === 'external-native') {
1445
+ const probe = this.recordPendingTranscriptProbe(pending);
1446
+ if (probe && !pending.loggedTranscriptProbe) {
1447
+ LOG.info('CLI', `[${this.type}] external transcript probe: msgCount=${probe.msgCount} lastRole=${probe.lastRole || 'none'} lastKind=${probe.lastKind || 'none'} contentLen=${probe.contentLen} sourceMtime=${probe.sourceMtimeMs ?? 'unknown'} mtimeAge=${probe.mtimeAgeMs ?? 'unknown'}ms`);
1448
+ pending.loggedTranscriptProbe = true;
1449
+ }
1450
+ LOG.debug('CLI', `[${this.type}] external-native probe result: lastRole=${probe?.lastRole} contentLen=${probe?.contentLen}`);
1451
+ if (probe?.lastRole === 'assistant' && (probe.contentLen ?? 0) > 0) {
1452
+ return null;
1453
+ }
1454
+ if (this.type === 'antigravity-cli') {
1455
+ return null;
1456
+ }
1457
+ // (SETTLE-VALLEY) The inter-approval idle valley: a native-history mesh worker
1458
+ // that resolved an approval and fell briefly idle (waiting_approval→idle) BEFORE
1459
+ // the next approval turn resumes. The live valley (~3s) is mostly covered by the
1460
+ // 4000ms NATIVE_HISTORY_MESH_IDLE_SETTLE_MS settle window, but a longer valley can
1461
+ // still let the flush run while the transcript's final assistant turn is not yet
1462
+ // written (source still the screen parse → finalAssistantPresent=false,
1463
+ // workerResult.source='default'). CANON-C would emit immediately here, freezing a
1464
+ // truncated preamble summary as evidenceLevel=insufficient. Instead HOLD: this
1465
+ // waiting_approval hold complements the settle window. Retry until the transcript finalizes
1466
+ // (block clears → genuine emit) or the worker resumes (resume guard cancels),
1467
+ // bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS. Scoped to the approval-resolved
1468
+ // idle so a genuinely-finished background-child turn keeps the CANON-C immediate
1469
+ // emit (its transcript trails by a write, not by a whole resume).
1470
+ if (allowMissingAssistantTimeout && pending.previousStatus === 'waiting_approval') {
1471
+ return { reason: 'missing_final_assistant', terminal: false, holdForTranscript: true };
1472
+ }
1473
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1474
+ }
1475
+ if ((this.provider as any).requiresFinalAssistantBeforeIdle === true) {
1476
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1477
+ }
1478
+ } else {
1479
+ LOG.debug('CLI', `[${this.type}] missing_final_assistant (not ownsExternal) requiresFinalAssistant=${!!(this.provider as any).requiresFinalAssistantBeforeIdle}`);
1480
+ return {
1481
+ reason: 'missing_final_assistant',
1482
+ terminal: (this.provider as any).requiresFinalAssistantBeforeIdle === true,
1483
+ allowTimeout: allowMissingAssistantTimeout,
1484
+ };
1485
+ }
1486
+ }
1487
+
1488
+ // (FALSEIDLE-a) Structural approval-resolution gate. Runs BEFORE the brittle
1489
+ // screen-text heuristic below so it also catches modals whose text does not match
1490
+ // looksLikeActiveApprovalPromptText (e.g. claude-cli's cd / "untrusted hooks" prompt).
1491
+ const approvalResolutionBlock = this.approvalResolutionFinalizationBlock(pending);
1492
+ if (approvalResolutionBlock) return approvalResolutionBlock;
1493
+
1494
+ // Guard: if the screen still shows an approval/choice prompt as the last visible text,
1495
+ // the turn is not complete even if the parsed status says idle and there is an assistant
1496
+ // message. This catches the case where waiting_approval→idle transitions occur before
1497
+ // the modal has been resolved (e.g. the PTY rendered the prompt but no button press fired).
1498
+ try {
1499
+ const screenText = typeof (this.adapter as any).getScreenText === 'function'
1500
+ ? String((this.adapter as any).getScreenText() || '')
1501
+ : '';
1502
+ if (screenText) {
1503
+ const tailLines = screenText.split(/\r?\n/).slice(-16).join('\n');
1504
+ if (looksLikeActiveApprovalPromptText(tailLines)) {
1505
+ return { reason: 'screen_shows_approval_prompt', terminal: approvalResolvedIdle };
1506
+ }
1507
+ }
1508
+ } catch { /* defensive: screen text read is best-effort */ }
794
1509
 
795
1510
  return null;
796
1511
  }
797
1512
 
1513
+ // (FALSEIDLE-a) Positive, structural proof that the latest approval entry was resolved
1514
+ // through ADHDev. resolveModal() — driven by auto-approve, dashboard/mesh_approve, and
1515
+ // dev-cli-debug alike — advances the engine's lastResolvedEntrySeq to the current
1516
+ // approvalEntrySeq. So `lastResolvedEntrySeq >= approvalEntrySeq` (with a real entry,
1517
+ // approvalEntrySeq > 0) means the modal we last saw was actually answered. Absence of this
1518
+ // evidence after a waiting_approval→idle transition means the idle is suspect: the spec's
1519
+ // text-based approval→idle rule false-tripped while the modal is still unresolved.
1520
+ // Fails OPEN (returns true) when the seq fields are unavailable, so the gate can never wedge
1521
+ // a session on a provider/adapter that does not surface the counters.
1522
+ private hasApprovalResolutionEvidence(): boolean {
1523
+ try {
1524
+ const status = this.adapter.getStatus({ allowParse: false }) as any;
1525
+ const entrySeq = typeof status?.approvalEntrySeq === 'number' ? status.approvalEntrySeq : 0;
1526
+ if (entrySeq <= 0) return true;
1527
+ const resolvedSeq = typeof status?.lastResolvedEntrySeq === 'number' ? status.lastResolvedEntrySeq : undefined;
1528
+ if (resolvedSeq === undefined) return true;
1529
+ return resolvedSeq >= entrySeq;
1530
+ } catch {
1531
+ return true;
1532
+ }
1533
+ }
1534
+
1535
+ // (FALSEIDLE-a) Hold a completion that is the anomalous DIRECT waiting_approval→idle
1536
+ // transition with no positive resolution evidence. A genuinely resolved approval routes
1537
+ // through resolveModal → setStatus('generating'), so its completion's previousStatus is
1538
+ // 'generating' (not 'waiting_approval') and this gate never fires for it. Scoped to
1539
+ // delegated mesh/coordinator sessions — whose only modal-resolution path is auto-approve /
1540
+ // mesh_approve (both advance lastResolvedEntrySeq) — so an interactive local session, where
1541
+ // a human may answer the PTY prompt directly and leave no resolveModal record, is untouched.
1542
+ // Non-terminal: the hold is bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS (30s), giving a
1543
+ // settling auto-approve time to fire and advance the seq, and guaranteeing no permanent wedge
1544
+ // if resolution ever happens via a path that does not record evidence.
1545
+ private approvalResolutionFinalizationBlock(pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1546
+ if (pending.previousStatus !== 'waiting_approval') return null;
1547
+ const meshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1548
+ if (!meshContext) return null;
1549
+ if (this.hasApprovalResolutionEvidence()) return null;
1550
+ return { reason: 'approval_resolution_unconfirmed', terminal: false };
1551
+ }
1552
+
798
1553
  private scheduleCompletedDebounceFlush(delayMs: number): void {
799
1554
  if (this.completedDebounceTimer) clearTimeout(this.completedDebounceTimer);
800
1555
  this.completedDebounceTimer = setTimeout(() => this.flushCompletedDebounceIfFinalized(), delayMs);
801
1556
  }
802
1557
 
1558
+ // EVTTRACE (observation-only): is this a mesh worker session whose completion
1559
+ // events must route to a coordinator? Used purely to gate trace logging so a
1560
+ // non-mesh CLI session's completions don't add EvtTrace noise. No decision logic.
1561
+ private isMeshWorkerSession(): boolean {
1562
+ return !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId
1563
+ || this.settings.meshNodeId || this.settings.launchedByCoordinator);
1564
+ }
1565
+
1566
+ /**
1567
+ * AUTOAPPROVE-FLAP-RECUR (Fix A+B): how long a busy blip / modal scroll-out may
1568
+ * persist before the in-progress settle gate is torn down. For a delegated
1569
+ * worker whose auto-approve episode is genuinely still cycling (mask clock
1570
+ * alive), the FSM's full waiting_approval → busy → waiting_approval flap runs
1571
+ * on a multi-second period, so the settle continuity window is extended to
1572
+ * AUTO_APPROVE_FLAP_CONTINUITY_MS to bridge it (still bounded, and still capped
1573
+ * by AUTO_APPROVE_MASK_STALL_MS). Every other case — foreground/attended
1574
+ * session, or no active mask episode — keeps the tight default hysteresis so a
1575
+ * genuine resolution frees the gate promptly.
1576
+ */
1577
+ private autoApproveContinuityWindowMs(): number {
1578
+ return this.autoApproveMaskSince > 0 && this.isMeshWorkerSession()
1579
+ ? CliProviderInstance.AUTO_APPROVE_FLAP_CONTINUITY_MS
1580
+ : CliProviderInstance.AUTO_APPROVE_GATE_HYSTERESIS_MS;
1581
+ }
1582
+
1583
+ /**
1584
+ * The settle-gate identity signature for a raw activeModal, or null when the
1585
+ * modal is NOT a concrete auto-approvable consent prompt (no captured buttons,
1586
+ * a picker/confirm kind, or no reliable affirmative+decline anchor). Mirrors the
1587
+ * gates the auto-approve fire path applies before computing modalSignature, so
1588
+ * the mask-stall nudge can ask the SAME question the settle gate is tracking —
1589
+ * "is THIS frame's modal the identity the settle clock is accruing against?" —
1590
+ * without duplicating the button-pick logic. The signature is message +
1591
+ * normalized affirmative label only (no volatile counters/button set), matching
1592
+ * the fire path exactly (AUTOAPPROVE-SETTLE-FLAP).
1593
+ */
1594
+ private approvableModalSignature(modal: any): string | null {
1595
+ const buttons = Array.isArray(modal?.buttons)
1596
+ ? modal.buttons.map((b: any) => String(b || '').trim()).filter(Boolean)
1597
+ : [];
1598
+ if (!modal || buttons.length === 0) return null;
1599
+ const modalKind = typeof modal?.kind === 'string' ? modal.kind : 'approval';
1600
+ if (modalKind !== 'approval') return null;
1601
+ const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(buttons, this.provider);
1602
+ const hasReliableConsentAnchor = hasNegativeApprovalOption(buttons)
1603
+ || hasReliableApprovalAffirmative(buttons);
1604
+ if (buttonIndex < 0 || !hasReliableConsentAnchor) return null;
1605
+ return approvalModalSignature(modal?.message, normalizeApprovalLabel(buttonLabel));
1606
+ }
1607
+
1608
+ // FALSE-IDLE (self-coordinator settle): an autonomously-progressing mesh session
1609
+ // is either a delegated worker (isMeshWorkerSession) OR the coordinator's OWN
1610
+ // claude-cli session (meshCoordinatorFor). Both run auto-approved tool turns whose
1611
+ // inter-approval valley (busy→idle blip→generating re-entry ~0.5s later) must be
1612
+ // absorbed by the completedDebounce settle window, not flushed on the first idle
1613
+ // sample. The worker branch already gets NATIVE_HISTORY_MESH_IDLE_SETTLE_MS; the
1614
+ // self-coordinator session (worker markers absent, meshCoordinatorFor present) was
1615
+ // taking flushDelay=0 — no settle window — so its busyEpoch/lastOutputAt continuity
1616
+ // guard had no window to observe the valley and fired mid-turn "next-step" previews
1617
+ // as a finalSummary. Mirrors the isAutonomousMeshSession notion in isTransientToolConsent.
1618
+ private isAutonomousMeshSession(): boolean {
1619
+ return this.isMeshWorkerSession() || !!this.settings.meshCoordinatorFor;
1620
+ }
1621
+
1622
+ /**
1623
+ * ARCH-REFACTOR R1: the taskId to attribute the CURRENTLY-completing turn to.
1624
+ * Prefers the per-turn binding (engine.currentTurnTaskId, set when the turn was
1625
+ * submitted and surviving until the next turn starts) over the last-write-wins
1626
+ * session scalar (settings.meshActiveTaskId). The scalar is retained only as a
1627
+ * backward-compat alias for the "current/last assignment" and is the source of the
1628
+ * NOTIF-MISDELIVER / TASK-MSG-MISROUTE race: a second task attaching before this
1629
+ * turn completes overwrites it. Returns undefined for a non-task ad-hoc turn.
1630
+ */
1631
+ private completingTurnTaskId(): string | undefined {
1632
+ const turnTaskId = this.adapter?.currentTurnTaskId;
1633
+ if (typeof turnTaskId === 'string' && turnTaskId.trim()) return turnTaskId;
1634
+ const scalar = this.settings.meshActiveTaskId;
1635
+ return typeof scalar === 'string' && scalar.trim() ? scalar : undefined;
1636
+ }
1637
+
1638
+ // EVTTRACE correlation context for this session's completion lifecycle. taskId is
1639
+ // the primary grep anchor; instanceId is the session fallback.
1640
+ private meshTraceCtx(event = 'agent:generating_completed'): Record<string, unknown> {
1641
+ return {
1642
+ // ARCH-REFACTOR R1: trace the per-turn taskId (falling back to the scalar) so
1643
+ // EvtTrace anchors on the same id the completion event actually carries.
1644
+ taskId: this.completingTurnTaskId(),
1645
+ sessionId: this.instanceId,
1646
+ nodeId: this.settings.meshNodeId,
1647
+ meshId: this.settings.meshNodeFor,
1648
+ event,
1649
+ };
1650
+ }
1651
+
1652
+ // COMPLETION-EARLYNOTIFY instrumentation. A session-keyed FSM-transition +
1653
+ // completion-gate snapshot recorded into the shared debug-trace ring buffer
1654
+ // (secret-safe, length/role/pattern-name only — never screen or bubble text).
1655
+ // Retrieved via getRecentDebugTrace (chat_debug_bundle). Both categories are a
1656
+ // no-op unless collectDebugTrace is on AND the category is selected, so the
1657
+ // hot-path guards below (completionTraceOn / fsmTraceOn) keep production cost
1658
+ // at a single boolean check.
1659
+ private completionTraceOn(): boolean {
1660
+ return shouldCollectTraceCategory('completion-gate');
1661
+ }
1662
+ private fsmTraceOn(): boolean {
1663
+ return shouldCollectTraceCategory('fsm-transition');
1664
+ }
1665
+ private recordCompletionGateTrace(stage: string, payload: Record<string, unknown>): void {
1666
+ recordDebugTrace({
1667
+ category: 'completion-gate',
1668
+ stage,
1669
+ level: 'debug',
1670
+ sessionId: this.instanceId,
1671
+ providerType: this.type,
1672
+ payload,
1673
+ });
1674
+ }
1675
+ private recordFsmTransitionTrace(payload: Record<string, unknown>): void {
1676
+ recordDebugTrace({
1677
+ category: 'fsm-transition',
1678
+ stage: 'transition',
1679
+ level: 'debug',
1680
+ sessionId: this.instanceId,
1681
+ providerType: this.type,
1682
+ payload,
1683
+ });
1684
+ }
1685
+
803
1686
  private flushCompletedDebounceIfFinalized(): void {
804
1687
  const pending = this.completedDebouncePending;
805
1688
  if (!pending) {
@@ -809,97 +1692,716 @@ export class CliProviderInstance implements ProviderInstance {
809
1692
 
810
1693
  const latestStatus = this.adapter.getStatus({ allowParse: false });
811
1694
  const latestAutoApproveActive = latestStatus.status === 'waiting_approval' && this.shouldAutoApprove();
812
- const latestVisibleStatus = latestAutoApproveActive ? 'generating' : latestStatus.status;
1695
+ const latestVisibleStatus = latestAutoApproveActive || this.autoApproveBusy ? 'generating' : latestStatus.status;
1696
+ LOG.debug('CLI', `[${this.type}] flush attempt: adapterStatus=${latestStatus.status} latestVisible=${latestVisibleStatus} generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse} hasPartial=${!!this.adapter.getPartialResponse?.()}`);
813
1697
  if (latestVisibleStatus !== 'idle') {
814
1698
  LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed ${latestVisibleStatus})`);
1699
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1700
+ blockReason: 'resumed_status',
1701
+ latestVisibleStatus,
1702
+ previousStatus: pending.previousStatus,
1703
+ busyEpochAtArm: pending.busyEpochAtArm,
1704
+ busyEpoch: this.busyEpoch,
1705
+ });
815
1706
  this.completedDebouncePending = null;
816
1707
  this.completedDebounceTimer = null;
817
1708
  return;
818
1709
  }
819
1710
 
820
- const blockReason = this.getCompletedFinalizationBlockReason(latestVisibleStatus);
821
- if (blockReason) {
1711
+ // FALSE-IDLE continuity guard (Defect 1a): the point-sample above only proves the
1712
+ // session is idle at THIS instant. A momentary busy→idle blip inside an inter-approval
1713
+ // valley (auto-approved tool turns) opens AND closes a generating phase entirely within
1714
+ // the settle window — so the single sample reads 'idle' even though the turn is still in
1715
+ // flight (it re-enters generating ~0.5s later). Require instead that the session stayed
1716
+ // CONTINUOUSLY idle since the debounce was armed: (1) no entry into a busy phase
1717
+ // (busyEpoch unchanged), and (2) no new raw PTY output (lastOutputAt did not advance).
1718
+ // Either signal ⇒ the idle was not continuous ⇒ cancel; the still-live turn re-arms its
1719
+ // own completion when it genuinely finishes. This only ever cancels (never emits more),
1720
+ // so shared behaviour for claude/codex/antigravity is strictly stricter, never looser.
1721
+ if (typeof pending.busyEpochAtArm === 'number' && this.busyEpoch !== pending.busyEpochAtArm) {
1722
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (busy re-entry during settle: epoch ${pending.busyEpochAtArm}→${this.busyEpoch})`);
1723
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1724
+ blockReason: 'busy_reentry',
1725
+ latestVisibleStatus,
1726
+ previousStatus: pending.previousStatus,
1727
+ busyEpochAtArm: pending.busyEpochAtArm,
1728
+ busyEpoch: this.busyEpoch,
1729
+ busyEpochDelta: this.busyEpoch - pending.busyEpochAtArm,
1730
+ });
1731
+ this.completedDebouncePending = null;
1732
+ this.completedDebounceTimer = null;
1733
+ return;
1734
+ }
1735
+ const latestOutputAt = typeof (latestStatus as any)?.lastOutputAt === 'number' ? (latestStatus as any).lastOutputAt as number : undefined;
1736
+ if (typeof pending.lastOutputAtArm === 'number'
1737
+ && typeof latestOutputAt === 'number'
1738
+ && latestOutputAt > pending.lastOutputAtArm) {
1739
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (new PTY output during settle: ${pending.lastOutputAtArm}→${latestOutputAt})`);
1740
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('cancel', {
1741
+ blockReason: 'new_pty_output',
1742
+ latestVisibleStatus,
1743
+ previousStatus: pending.previousStatus,
1744
+ lastOutputAtArm: pending.lastOutputAtArm,
1745
+ lastOutputAt: latestOutputAt,
1746
+ lastOutputAtDelta: latestOutputAt - pending.lastOutputAtArm,
1747
+ });
1748
+ this.completedDebouncePending = null;
1749
+ this.completedDebounceTimer = null;
1750
+ return;
1751
+ }
1752
+
1753
+ const block = this.getCompletedFinalizationBlock(latestVisibleStatus, pending);
1754
+ if (block) {
1755
+ const blockReason = block.reason;
822
1756
  const waitedMs = Date.now() - pending.firstObservedAt;
823
- if (waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS) {
1757
+ // CANON-C (completion-gate decouple): a block carrying `allowTimeout` is the
1758
+ // transcript-evidence gate — the worker FSM has ALREADY reached idle and the only
1759
+ // thing missing is the append-only transcript's final assistant turn (a native-source
1760
+ // race: claude-cli owns its history externally and the file write trails the idle
1761
+ // transition). `allowTimeout` is set ONLY on the missing_final_assistant block, and
1762
+ // ONLY for mesh worker sessions (meshNodeFor / meshActiveTaskId / launchedByCoordinator).
1763
+ // The coordinator's sole path to learn this session is idle is agent:generating_completed,
1764
+ // so holding it up to COMPLETED_FINALIZATION_MAX_WAIT_MS (30s) leaves the coordinator
1765
+ // false-generating while the worker is done. Decouple the idle NOTIFICATION from the
1766
+ // transcript evidence: emit the completion immediately, marked weak
1767
+ // (completionDiagnostic.blockReason=missing_final_assistant, finalAssistantPresent=false).
1768
+ // The finalSummary is enriched on a SEPARATE path — the mesh reconcile loop reads the
1769
+ // transcript once written and re-emits a GENUINE completion (CANON-B weak→genuine
1770
+ // upgrade; buildPendingEventFingerprint keeps weak and genuine distinct so the enriched
1771
+ // one still surfaces, and isFalseIdleCompletion keeps the direct dispatch active until
1772
+ // then). All OTHER blocks (genuinely-busy adapter/partial/parsed states, transient
1773
+ // parse_error) keep the existing terminal-hold / 30s-retry behavior unchanged.
1774
+ //
1775
+ // (SETTLE-VALLEY) Exception: a `holdForTranscript` block is the inter-approval idle
1776
+ // valley of a native-history mesh worker (waiting_approval→idle that will resume into
1777
+ // the next approval). It deliberately does NOT carry allowTimeout, so it falls into the
1778
+ // hold-and-retry path below (terminal:false) rather than the CANON-C immediate emit —
1779
+ // the retry loop re-runs the resume guard each cycle, so when the worker resumes the
1780
+ // pending completion is cancelled, and when the transcript's final assistant arrives the
1781
+ // block clears for a GENUINE emit. This blocks the truncated weak (insufficient) summary
1782
+ // from ever being emitted during the valley, without depending on the valley's length.
1783
+ const isTranscriptEvidenceGate = block.allowTimeout === true;
1784
+ LOG.debug('CLI', `[${this.type}] finalization block: reason=${blockReason} terminal=${block.terminal} allowTimeout=${isTranscriptEvidenceGate} waitedMs=${waitedMs} maxWait=${COMPLETED_FINALIZATION_MAX_WAIT_MS}`);
1785
+ if (!isTranscriptEvidenceGate && (block.terminal || waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS)) {
824
1786
  if (pending.loggedBlockReason !== blockReason) {
825
1787
  LOG.info('CLI', `[${this.type}] waiting to emit completed until transcript finalizes (${blockReason})`);
1788
+ // EVTTRACE: completion held by the finalization gate (CANON-C). Observation
1789
+ // only — does not change the hold decision above.
1790
+ if (this.isMeshWorkerSession()) {
1791
+ traceMeshEventDrop('completion_gate_hold', this.meshTraceCtx(), `${blockReason} waited=${waitedMs}ms`);
1792
+ }
1793
+ // COMPLETION-EARLYNOTIFY: a hold is the CORRECT outcome when the turn is not
1794
+ // yet proven done (the FixA/FixB gates route here); trace it so an early-notify
1795
+ // investigation can see the gate holding rather than firing.
1796
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('hold', {
1797
+ blockReason,
1798
+ latestVisibleStatus,
1799
+ terminal: block.terminal === true,
1800
+ holdForTranscript: block.holdForTranscript === true,
1801
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
1802
+ waitedMs,
1803
+ });
826
1804
  pending.loggedBlockReason = blockReason;
827
1805
  }
828
1806
  this.scheduleCompletedDebounceFlush(COMPLETED_FINALIZATION_RETRY_MS);
829
1807
  return;
830
1808
  }
831
- LOG.warn('CLI', `[${this.type}] suppressed completed event after ${waitedMs}ms without finalized assistant turn (${blockReason})`);
1809
+ const emittedAfterFinalizationTimeout = waitedMs >= COMPLETED_FINALIZATION_MAX_WAIT_MS;
1810
+ const completionDiagnostic = this.buildCompletedFinalizationDiagnostic({
1811
+ blockReason,
1812
+ latestStatus,
1813
+ latestVisibleStatus,
1814
+ waitedMs,
1815
+ pending,
1816
+ emittedAfterFinalizationTimeout,
1817
+ });
1818
+ // Surface the CANON-C immediate-emit path distinctly so a delegated worker's idle
1819
+ // notification (transcript still pending) is not mistaken for a 30s-timeout fallback.
1820
+ (completionDiagnostic as Record<string, unknown>).decoupledImmediateEmit = isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout;
1821
+ LOG.warn('CLI', `[${this.type}] emitting completed event (${isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout ? 'CANON-C decoupled-immediate, transcript pending' : `after ${waitedMs}ms`}) without finalized assistant turn (${blockReason})`);
1822
+ // EVTTRACE: completion fired (forced past the finalization timeout / CANON-C decoupled-immediate).
1823
+ if (this.isMeshWorkerSession()) {
1824
+ traceMeshEventStage('fired', this.meshTraceCtx(), `forced after ${waitedMs}ms (${blockReason})`);
1825
+ }
1826
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('fire', {
1827
+ path: isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout ? 'canon_c_decoupled' : 'forced_timeout',
1828
+ blockReason,
1829
+ latestVisibleStatus,
1830
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
1831
+ finalAssistantPresent: (completionDiagnostic as any).finalAssistantPresent === true,
1832
+ evidenceSource: (completionDiagnostic as any).finalAssistantEvidenceSource ?? null,
1833
+ lastVisibleRole: (completionDiagnostic as any).lastVisibleRole ?? null,
1834
+ lastVisibleContentLen: (completionDiagnostic as any).lastVisibleContentLength ?? null,
1835
+ emittedAfterFinalizationTimeout,
1836
+ waitedMs,
1837
+ busyEpoch: this.busyEpoch,
1838
+ });
1839
+ this.pushEvent({
1840
+ event: 'agent:generating_completed',
1841
+ chatTitle: pending.chatTitle,
1842
+ duration: pending.duration,
1843
+ timestamp: pending.timestamp,
1844
+ // ARCH-REFACTOR R1: attribute to the turn captured at idle-transition.
1845
+ ...(pending.taskId ? { taskId: pending.taskId } : {}),
1846
+ // When finalization is forced past the timeout on a `parsed_status:` block
1847
+ // (the parser never confirmed a final assistant turn) we previously rode an
1848
+ // empty `finalSummary` unconditionally. That empty value propagates to the
1849
+ // mesh coordinator's mirror preview (meshSessionLastMessagePreview), leaving a
1850
+ // delegated session's inbox preview blank — or, for a LOCAL worktree session,
1851
+ // stuck on the dispatched user task. If the parser DID surface assistant text,
1852
+ // prefer it; only fall back to '' when no assistant summary can be derived.
1853
+ finalSummary: blockReason.startsWith('parsed_status:')
1854
+ ? (this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt) ?? '')
1855
+ : this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
1856
+ completionDiagnostic,
1857
+ });
832
1858
  this.completedDebouncePending = null;
833
1859
  this.completedDebounceTimer = null;
834
1860
  this.generatingStartedAt = 0;
1861
+ this.lastApprovalEventFingerprint = '';
835
1862
  return;
836
1863
  }
837
1864
 
838
1865
  LOG.info('CLI', `[${this.type}] completed in ${pending.duration}s`);
1866
+ // EVTTRACE: completion fired (transcript finalized cleanly).
1867
+ if (this.isMeshWorkerSession()) {
1868
+ traceMeshEventStage('fired', this.meshTraceCtx(), `duration=${pending.duration}s`);
1869
+ }
1870
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('fire', {
1871
+ path: 'clean',
1872
+ latestVisibleStatus,
1873
+ approvalResolvedIdle: pending.previousStatus === 'waiting_approval',
1874
+ finalAssistantPresent: true,
1875
+ duration: pending.duration,
1876
+ busyEpoch: this.busyEpoch,
1877
+ });
839
1878
  this.pushEvent({
840
1879
  event: 'agent:generating_completed',
841
1880
  chatTitle: pending.chatTitle,
842
1881
  duration: pending.duration,
843
1882
  timestamp: pending.timestamp,
844
- finalSummary: extractFinalSummaryFromMessages(this.adapter?.getScriptParsedStatus()?.messages),
1883
+ // ARCH-REFACTOR R1: attribute to the turn captured at idle-transition.
1884
+ ...(pending.taskId ? { taskId: pending.taskId } : {}),
1885
+ finalSummary: this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
845
1886
  });
846
1887
  this.completedDebouncePending = null;
847
1888
  this.completedDebounceTimer = null;
848
1889
  this.generatingStartedAt = 0;
1890
+ this.lastApprovalEventFingerprint = '';
849
1891
  }
850
1892
 
851
1893
  private maybeAutoApproveStatus(adapterStatus: any, now = Date.now()): boolean {
1894
+ // Manual-attendance suppression (provider-common): when a human is
1895
+ // actively driving this session from the dashboard, hold auto-approve so
1896
+ // the modal stays visible and they can pick a button / use the controlbar
1897
+ // themselves. Return false (NOT auto-approving) so getState keeps the
1898
+ // modal surfaced. Clear any in-progress settle gate — a genuine fire
1899
+ // after the window lapses must re-settle from scratch — and arm a
1900
+ // re-check for the lapse moment, because the PTY may have gone silent and
1901
+ // would otherwise never re-drive this decision. Background mesh workers
1902
+ // are never attended, so their delegated auto-approve is untouched.
1903
+ if (adapterStatus?.status === 'waiting_approval'
1904
+ && this.shouldAutoApprove()
1905
+ && this.manualAttendance.isAttended(now)) {
1906
+ this.lastAutoApprovalSignature = '';
1907
+ this.pendingAutoApprovalSignature = '';
1908
+ this.pendingAutoApprovalSince = 0;
1909
+ this.autoApproveInactiveSince = 0;
1910
+ // Manual attendance takes over — the modal stays surfaced (maybeAutoApproveStatus
1911
+ // returns false), so end the mask episode.
1912
+ this.autoApproveMaskSince = 0;
1913
+ this.stalledApprovalNudgeEpisode = 0;
1914
+ this.autoApproveLastModalSeenAt = 0;
1915
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
1916
+ this.autoApproveSettleTimer = setTimeout(() => {
1917
+ this.autoApproveSettleTimer = null;
1918
+ this.recheckAutoApproveSettled();
1919
+ }, this.manualAttendance.remainingMs(now) + 20);
1920
+ return false;
1921
+ }
852
1922
  const autoApproveActive = adapterStatus?.status === 'waiting_approval' && this.shouldAutoApprove();
853
1923
  // Guard re-entry: onStatusChange/getState can observe the same modal multiple
854
1924
  // times while the PTY absorbs the approval key. Without this flag, repeated
855
1925
  // snapshots would write stray keys into the input once the modal dismisses.
856
- if (autoApproveActive && !this.autoApproveBusy) {
857
- this.autoApproveBusy = true;
858
- if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
859
- this.autoApproveBusyTimer = setTimeout(() => {
860
- this.autoApproveBusy = false;
861
- this.autoApproveBusyTimer = null;
862
- }, 2000);
863
- const modal = adapterStatus.activeModal;
864
- const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(modal?.buttons, this.provider);
865
- this.recordAutoApproval(modal?.message, buttonLabel, now);
866
- setTimeout(() => {
867
- this.adapter.resolveModal(buttonIndex);
868
- }, 0);
1926
+ // However, Claude Code can present a second approval immediately after the
1927
+ // first. Resolve a changed modal signature even while the previous write is
1928
+ // still inside the short busy window.
1929
+ if (!autoApproveActive) {
1930
+ this.lastAutoApprovalSignature = '';
1931
+ // Hysteresis: if a settle gate is mid-progress, a momentary
1932
+ // status!=waiting_approval blip (a generating flip while the same
1933
+ // modal's button block is still on screen) must NOT wipe the settle
1934
+ // clock otherwise the modal→generating→modal flap restarts the
1935
+ // 600ms window every time and auto-approve never fires. Keep the
1936
+ // gate warm for AUTO_APPROVE_GATE_HYSTERESIS_MS; re-arm a timer so
1937
+ // that if the modal does NOT come back the gate is cleared on the
1938
+ // re-check (a genuine resolution → idle frees the gate normally).
1939
+ if (this.pendingAutoApprovalSince) {
1940
+ if (!this.autoApproveInactiveSince) this.autoApproveInactiveSince = now;
1941
+ const goneForMs = now - this.autoApproveInactiveSince;
1942
+ // AUTOAPPROVE-FLAP-RECUR (Fix B): a delegated-worker flap cycles the
1943
+ // FULL waiting_approval → busy → waiting_approval state on a
1944
+ // multi-second period, outrunning the tight default hysteresis and
1945
+ // wiping the settle clock before 600ms ever accumulates. For an
1946
+ // active worker mask episode the continuity window is widened (still
1947
+ // capped by AUTO_APPROVE_MASK_STALL_MS) so the settle clock survives
1948
+ // the busy phase and the returning approval keeps accruing settle time.
1949
+ const continuityMs = this.autoApproveContinuityWindowMs();
1950
+ if (goneForMs < continuityMs) {
1951
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
1952
+ this.autoApproveSettleTimer = setTimeout(() => {
1953
+ this.autoApproveSettleTimer = null;
1954
+ this.recheckAutoApproveSettled();
1955
+ }, continuityMs - goneForMs + 20);
1956
+ return autoApproveActive;
1957
+ }
1958
+ }
1959
+ // Clear the settle gate so the next approval starts its own quiet
1960
+ // window from scratch (a stale timestamp would let it fire instantly).
1961
+ this.pendingAutoApprovalSignature = '';
1962
+ this.pendingAutoApprovalSince = 0;
1963
+ this.autoApproveInactiveSince = 0;
1964
+ // Modal has genuinely been gone past the hysteresis window → the episode ended;
1965
+ // end the mask episode too (a later approval starts a fresh stall clock).
1966
+ this.autoApproveMaskSince = 0;
1967
+ this.stalledApprovalNudgeEpisode = 0;
1968
+ this.autoApproveLastModalSeenAt = 0;
1969
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
1970
+ return autoApproveActive;
1971
+ }
1972
+ // Active approval observed — reset the inactivity tracker so a later
1973
+ // blip starts its hysteresis window fresh.
1974
+ this.autoApproveInactiveSince = 0;
1975
+ // STATUS-MISMATCH: start (or keep) the mask-stall clock for this episode. Set ONLY
1976
+ // when zero so it survives modal-signature changes and hysteresis blips — it measures
1977
+ // the true age of the unresolved auto-approve, not the per-signature settle window.
1978
+ if (!this.autoApproveMaskSince) this.autoApproveMaskSince = now;
1979
+ // NOTIF-APPROVAL-MASKED (Q1b): once this episode has stalled past the mask threshold,
1980
+ // surface the raw waiting_approval to the mesh coordinator (decoupled from the dashboard
1981
+ // mask). Placed on the active-approval path here — the single choke point that owns the
1982
+ // mask-stall clock and is re-driven throughout a silent stall (getState heartbeat,
1983
+ // detectStatusTransition, recheckAutoApproveSettled). No-op until the stall threshold trips.
1984
+ this.maybeEmitStalledApprovalNudge(adapterStatus, now);
1985
+ const modal = adapterStatus.activeModal;
1986
+ // (fix) Do not auto-approve when no concrete modal/buttons are present.
1987
+ // Claude TUI flaps between paints; without this guard adapterStatus
1988
+ // could report status=waiting_approval with activeModal=null (or with
1989
+ // an empty buttons array briefly) and we'd still call
1990
+ // resolveModal(-1) — which used to type "1" into the prompt
1991
+ // repeatedly. Skip until a real modal is captured.
1992
+ const buttons = Array.isArray(modal?.buttons)
1993
+ ? modal.buttons.map((b: any) => String(b || '').trim()).filter(Boolean)
1994
+ : [];
1995
+ if (!modal || buttons.length === 0) {
1996
+ // AUTOAPPROVE-FLAP-RECUR (Fix A): the button block momentarily scrolled
1997
+ // out of the captured frame (status is still waiting_approval — we are
1998
+ // on the active path). Do NOT tear the settle gate down on this frame:
1999
+ // if a concrete modal was captured within the continuity window and a
2000
+ // settle gate is in progress, this is a short scroll-out blip — keep the
2001
+ // gate warm against the last-captured signature and arm a re-check so a
2002
+ // silent PTY still re-drives the decision when the buttons repaint. Only
2003
+ // once the modal has stayed empty PAST the continuity window is it a
2004
+ // genuine close, and the gate is cleared here so a later approval
2005
+ // re-settles from scratch (never fires on a stale timestamp).
2006
+ const blipForMs = this.autoApproveLastModalSeenAt ? now - this.autoApproveLastModalSeenAt : Infinity;
2007
+ if (this.pendingAutoApprovalSince && blipForMs < this.autoApproveContinuityWindowMs()) {
2008
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2009
+ this.autoApproveSettleTimer = setTimeout(() => {
2010
+ this.autoApproveSettleTimer = null;
2011
+ this.recheckAutoApproveSettled();
2012
+ }, this.autoApproveContinuityWindowMs() - blipForMs + 20);
2013
+ return autoApproveActive;
2014
+ }
2015
+ if (blipForMs >= this.autoApproveContinuityWindowMs()) {
2016
+ // Buttons empty continuously past the window → the modal genuinely
2017
+ // closed (or never captured). Reset the per-signature settle gate so
2018
+ // a later approval re-settles cleanly. The mask-stall clock keeps
2019
+ // running underneath so a never-captured worker modal still surfaces
2020
+ // to the coordinator within AUTO_APPROVE_MASK_STALL_MS.
2021
+ this.pendingAutoApprovalSignature = '';
2022
+ this.pendingAutoApprovalSince = 0;
2023
+ }
2024
+ return autoApproveActive;
2025
+ }
2026
+ // Concrete modal captured this frame — mark the last-good-modal timestamp so
2027
+ // a subsequent scroll-out blip (buttons.length===0) can be told apart from a
2028
+ // genuine close by how long it persists (Fix A above).
2029
+ this.autoApproveLastModalSeenAt = now;
2030
+ // Picker/confirm exclusion (provider-common). A /model or /mode picker is
2031
+ // surfaced with status=waiting_approval so the dashboard shows it, but it
2032
+ // has no "correct" answer to auto-pick — blindly selecting the first
2033
+ // option silently switches the model (the "always Opus, before I even
2034
+ // choose" bug). Two independent gates, BOTH must pass to fire:
2035
+ //
2036
+ // (1) modal_kind — the spec/FSM tells us this is an 'approval' modal,
2037
+ // not a 'picker'/'confirm'. A modal whose kind is unknown (legacy
2038
+ // adapter, or a spec that predates modal_kind) reads as 'approval'
2039
+ // so genuine approvals keep auto-approving; only an explicit
2040
+ // 'picker'/'confirm' is excluded here.
2041
+ // (2) structural anchor — a real approval offers an affirmative AND a
2042
+ // decline option (pickApprovalButton finds a positive that isn't a
2043
+ // decline, and hasNegativeApprovalOption confirms a No/Cancel/Deny
2044
+ // is present). A model picker ("1. Default 2. Opus 3. Sonnet")
2045
+ // has no decline, so even an un-migrated picker is caught here.
2046
+ //
2047
+ // Mirrors the SDK v1 detect-status approval heuristic (detect-status.ts).
2048
+ const modalKind = typeof modal?.kind === 'string' ? modal.kind : 'approval';
2049
+ if (modalKind !== 'approval') {
2050
+ // Picker/confirm — leave it for the user; keep the modal surfaced.
2051
+ return autoApproveActive;
2052
+ }
2053
+ const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(buttons, this.provider);
2054
+ // Structural decline anchor. A real approval offers BOTH an affirmative
2055
+ // and a decline — but on a TALL Write/Edit diff the trailing "3. No"
2056
+ // scrolls off the captured frame, leaving only "1. Yes" + "2. Yes, allow
2057
+ // … this session" so hasNegativeApprovalOption reads false (#137). A
2058
+ // scoped grant-affirmative ("Yes, allow … during this session" / "…don't
2059
+ // ask again") ONLY appears in a genuine consent modal (never a picker),
2060
+ // so it stands in for the off-frame decline as a reliable second anchor.
2061
+ // Conservative by construction: a picker without a grant-scope option
2062
+ // still bails here, and the fire below still picks the plain allow-once
2063
+ // "Yes" via pickApprovalButton, not the broader grant.
2064
+ const hasReliableConsentAnchor = hasNegativeApprovalOption(buttons)
2065
+ || hasReliableApprovalAffirmative(buttons);
2066
+ if (buttonIndex < 0 || !hasReliableConsentAnchor) {
2067
+ // No affirmative matched, or no decline / reliable grant option present
2068
+ // (→ not a real consent prompt, e.g. a picker that slipped past the
2069
+ // kind gate). Surface the modal so the user decides; never pick blindly.
2070
+ return autoApproveActive;
869
2071
  }
2072
+ // Modal *identity* signature — the question plus the STABLE affirmative
2073
+ // anchor only, NO volatile counters and NO raw button set. This is what
2074
+ // the settle gate tracks: the FSM bumps approvalEntrySeq on every fresh
2075
+ // waiting_approval entry, and a modal→generating→modal flap (the question
2076
+ // line scrolled out of the captured frame while the button block stays)
2077
+ // re-enters and bumps it again. Folding that seq into the settle signature
2078
+ // made the 600ms settle clock restart on every flap, so the modal never
2079
+ // stayed stable long enough to fire — the gate was never satisfied.
2080
+ // Identity excludes the seq so seq flap of the SAME modal keeps one clock.
2081
+ //
2082
+ // The raw button set is also excluded: on a TALL Write/Edit diff claude's
2083
+ // TUI repaints the button block 3↔5↔none between frames (buttons scroll in
2084
+ // and out of the captured region), which flipped both buttons.join('|') and
2085
+ // the positional buttonIndex every frame → signature flap → the settle
2086
+ // clock reset 4–9s and only mask-stalled episodes leaked to the coordinator
2087
+ // (AUTOAPPROVE-SETTLE-FLAP). The affirmative the auto-approve will actually
2088
+ // press is the invariant across those repaints, so we anchor on its
2089
+ // NORMALIZED label (numbers/bullets/punctuation stripped, so "1. Yes" and
2090
+ // "3. Yes" collapse to "yes"). Message + affirmative label uniquely
2091
+ // identifies the consent question without tracking the volatile button
2092
+ // positions.
2093
+ const affirmativeAnchor = normalizeApprovalLabel(buttonLabel);
2094
+ const modalSignature = approvalModalSignature(modal?.message, affirmativeAnchor);
2095
+ // Busy-window re-entry guard still needs the seq: two DISTINCT
2096
+ // back-to-back approvals can carry identical message/buttons (common
2097
+ // with claude-cli). Without the seq their busy signatures collide and
2098
+ // the 5s busy-window guard below would swallow the second auto-approve,
2099
+ // leaving it stuck. The seq is bumped by the FSM on every fresh
2100
+ // waiting_approval entry, so a new approval always yields a new busy
2101
+ // signature and fires through.
2102
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2103
+ ? adapterStatus.approvalEntrySeq
2104
+ : 0;
2105
+ const busySignature = `${approvalEntrySeq}::${modalSignature}`;
2106
+ // Already fired for this exact modal entry and still inside the busy
2107
+ // window — nothing to do (re-entry guard for repeated snapshots of one
2108
+ // modal).
2109
+ if (this.autoApproveBusy && busySignature === this.lastAutoApprovalSignature) {
2110
+ return autoApproveActive;
2111
+ }
2112
+
2113
+ // Settle gate: only fire once this modal identity has been stable for
2114
+ // AUTO_APPROVE_SETTLE_MS. A still-streaming prompt mutates its
2115
+ // message/buttons each frame → new identity → clock restarts, so we
2116
+ // never approve a half-rendered prompt (the "resolves too fast" bug).
2117
+ if (modalSignature !== this.pendingAutoApprovalSignature) {
2118
+ this.pendingAutoApprovalSignature = modalSignature;
2119
+ this.pendingAutoApprovalSince = now;
2120
+ }
2121
+ const settledForMs = now - this.pendingAutoApprovalSince;
2122
+ if (settledForMs < CliProviderInstance.AUTO_APPROVE_SETTLE_MS) {
2123
+ // Not yet settled. Arm a timer to re-check after the remaining quiet
2124
+ // window — the PTY may go silent once the prompt finishes painting,
2125
+ // so there is no guaranteed status-change frame to re-drive us.
2126
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2127
+ this.autoApproveSettleTimer = setTimeout(() => {
2128
+ this.autoApproveSettleTimer = null;
2129
+ this.recheckAutoApproveSettled();
2130
+ }, CliProviderInstance.AUTO_APPROVE_SETTLE_MS - settledForMs + 20);
2131
+ return autoApproveActive;
2132
+ }
2133
+
2134
+ // Settled — fire the approve key.
2135
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
2136
+ this.autoApproveBusy = true;
2137
+ this.lastAutoApprovalSignature = busySignature;
2138
+ this.pendingAutoApprovalSignature = '';
2139
+ this.pendingAutoApprovalSince = 0;
2140
+ this.autoApproveInactiveSince = 0;
2141
+ // Fired (resolveModal in flight) — the episode resolved; end the mask-stall clock.
2142
+ this.autoApproveMaskSince = 0;
2143
+ this.stalledApprovalNudgeEpisode = 0;
2144
+ this.autoApproveLastModalSeenAt = 0;
2145
+ if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
2146
+ this.autoApproveBusyTimer = setTimeout(() => {
2147
+ this.autoApproveBusy = false;
2148
+ this.autoApproveBusyTimer = null;
2149
+ this.lastAutoApprovalSignature = '';
2150
+ }, 5000);
2151
+ this.recordAutoApproval(modal?.message, buttonLabel, now);
2152
+ setTimeout(() => {
2153
+ this.adapter.resolveModal(buttonIndex);
2154
+ }, 0);
870
2155
  return autoApproveActive;
871
2156
  }
872
2157
 
2158
+ /**
2159
+ * Re-drive the auto-approve check after the settle quiet window elapses.
2160
+ * The PTY may have gone silent once the approval prompt finished painting,
2161
+ * so no status-change frame is guaranteed to re-enter maybeAutoApproveStatus
2162
+ * — this timer-driven re-check picks up the now-settled modal and fires.
2163
+ * Deliberately lighter than detectStatusTransition(): it only re-evaluates
2164
+ * the approval decision; the next real PTY frame refreshes visible status.
2165
+ */
2166
+ private recheckAutoApproveSettled(): void {
2167
+ try {
2168
+ // APPROVAL Defect-C (auto-approve gap): re-probe with a LIVE parse, not the cached
2169
+ // engine snapshot. This timer is the ONLY re-drive when the PTY goes silent after the
2170
+ // approval prompt finishes painting (its whole reason to exist) — but with
2171
+ // allowParse:false it read only engine.activeModal, which the engine's per-frame settle
2172
+ // pass can leave null/stale when the modal arrived between writes. The re-check then saw
2173
+ // no modal and never fired, so the delegated worker's transient/quiet approval was missed
2174
+ // and the coordinator had to step in with a manual mesh_approve. allowParse:true makes
2175
+ // getStatus re-run runDetectStatus/runParseApproval on the current screen buffer (the same
2176
+ // live re-probe the coordinator's resolveAction path uses), recovering the modal so
2177
+ // auto-approve fires on its own. The half-rendered-frame guard (buttons.length===0) and
2178
+ // the settle gate in maybeAutoApproveStatus still protect against firing on a partial modal.
2179
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
2180
+ this.maybeAutoApproveStatus(adapterStatus, Date.now());
2181
+ } catch { /* adapter gone / transient — next frame retries */ }
2182
+ }
2183
+
2184
+ /**
2185
+ * Emit the queue-claim agent:ready event at most once per session. Both the
2186
+ * boot-time starting→idle one-shot and the fsmReadySeen re-arm call this; the
2187
+ * agentReadyEmitted guard ensures the second caller is a no-op so a worker is
2188
+ * never claimed twice and a queued task is never double-dispatched.
2189
+ */
2190
+ private emitAgentReadyOnce(chatTitle: string, now: number): void {
2191
+ if (this.agentReadyEmitted) return;
2192
+ this.agentReadyEmitted = true;
2193
+ this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2194
+ }
2195
+
2196
+ /**
2197
+ * GENERATING-BOUNDARY synthetic emit for a first turn that started AND finished
2198
+ * inside the startup-grace window without the FSM ever observing a 'generating'
2199
+ * frame (an unobservably-fast turn). Synthesizes the agent:generating_started +
2200
+ * agent:generating_completed pair so the mesh coordinator learns the worker went
2201
+ * idle. Returns true iff it synthesized.
2202
+ *
2203
+ * Two callers share this defense line:
2204
+ * - 'startup_grace_fast_collapse' — the starting→idle transition (the FSM whose
2205
+ * spec lacks/hadn't-synced the starting→busy edge collapses starting→idle
2206
+ * directly, with no intervening 'generating' frame).
2207
+ * - 'startup_grace_idle_turn_collapse' — the idle→idle no-status-change poll
2208
+ * (the launch settle already drained starting→idle BEFORE the first turn, so
2209
+ * the turn runs+completes while status stays 'idle' the whole time and
2210
+ * detectStatusTransition never re-enters its change block — the live rc.403
2211
+ * Probe1 miss).
2212
+ *
2213
+ * False-positive safety (must NOT fire on a benign boot): currentTurnTaskId is
2214
+ * set ONLY by onTurnStarted (a real turn STARTED this boot) and persists past
2215
+ * completion, so it excludes a true idle boot (null) and a queued-pending first
2216
+ * turn that only runs after grace (onTurnStarted not yet called → null).
2217
+ * !hasAdapterPendingResponse() excludes a turn still mid-flight. generating
2218
+ * never armed (generatingStartedAt===0 && !generatingDebouncePending) means the
2219
+ * whole idle→busy→idle never happened for this turn. The once-per-turn guard
2220
+ * (fastCollapseSynthesizedTaskId) keeps the re-polled idle-stayed caller from
2221
+ * re-emitting every poll.
2222
+ */
2223
+ private maybeSynthesizeStartupGraceCollapse(
2224
+ chatTitle: string,
2225
+ now: number,
2226
+ reason: 'startup_grace_fast_collapse' | 'startup_grace_idle_turn_collapse',
2227
+ ): boolean {
2228
+ const startedTurnTaskId = typeof (this.adapter as any)?.currentTurnTaskId === 'string'
2229
+ && (this.adapter as any).currentTurnTaskId.trim()
2230
+ ? (this.adapter as any).currentTurnTaskId as string
2231
+ : undefined;
2232
+ const fastCollapsed = !!startedTurnTaskId
2233
+ && !this.hasAdapterPendingResponse()
2234
+ && !this.generatingStartedAt
2235
+ && !this.generatingDebouncePending;
2236
+ if (!fastCollapsed) return false;
2237
+ // Once-per-turn: the idle-stayed caller re-polls steadily while the session
2238
+ // sits idle; without this guard it would re-emit the pair every poll.
2239
+ if (this.fastCollapseSynthesizedTaskId === startedTurnTaskId) return false;
2240
+
2241
+ let fcFinalSummary: string | undefined;
2242
+ let fcEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2243
+ try {
2244
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2245
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2246
+ fcEvidenceSource = evidence.source;
2247
+ fcFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2248
+ } catch { /* best-effort */ }
2249
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true || fcEvidenceSource === 'external-native') && !fcFinalSummary;
2250
+ // Mirror the short-generating idle path's suppression: a provider that
2251
+ // requires a final assistant (or external-native history) with NO confirmed
2252
+ // summary and NO mesh context emits nothing — the session is idle with no
2253
+ // confirmed turn, matching startup-blip semantics. With mesh context we still
2254
+ // emit so the coordinator can apply its own timeout/retry logic. Left UNMARKED
2255
+ // so a later poll can retry once the transcript's final assistant lands.
2256
+ const hasMeshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
2257
+ if (missingEvidence && !hasMeshContext) {
2258
+ LOG.info('CLI', `[${this.type}] ${reason} suppressed: missing final assistant evidence, no mesh context (source=${fcEvidenceSource})`);
2259
+ return false;
2260
+ }
2261
+ // Mark BEFORE emitting so a re-entrant poll cannot double-fire.
2262
+ this.fastCollapseSynthesizedTaskId = startedTurnTaskId;
2263
+ LOG.info('CLI', `[${this.type}] ${reason}: synthesizing started+completed (taskId=${startedTurnTaskId} source=${fcEvidenceSource} hadFinalSummary=${!!fcFinalSummary})`);
2264
+ // Retroactive started so the started→completed pair (and the chat bubble) is
2265
+ // well-formed; pushEvent stamps the per-turn taskId for CANON-B ack.
2266
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now });
2267
+ if (this.isMeshWorkerSession()) {
2268
+ traceMeshEventStage('fired', this.meshTraceCtx(), `${reason} (source=${fcEvidenceSource})`);
2269
+ }
2270
+ // EARLYNOTIFY-GATEBYPASS (c): a startup-grace fast-collapse never OBSERVED the turn's
2271
+ // generating phase — its evidence is a plain transcript tail, never a self-attributing
2272
+ // final_summary_json — so this synth is TENTATIVE by default. Mark it WEAK
2273
+ // (evidenceLevel:'weak') so buildPendingEventFingerprint keys it `…::weak` and any later
2274
+ // genuine agent:generating_completed for the same task can still surface (CANON-B). The
2275
+ // stronger missing_final_assistant marker is preserved when there is also no summary.
2276
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('synth-fire', {
2277
+ path: 'startup_grace_fast_collapse',
2278
+ reason,
2279
+ evidenceSource: fcEvidenceSource,
2280
+ hadFinalSummary: !!fcFinalSummary,
2281
+ missingEvidence,
2282
+ evidenceLevel: 'weak',
2283
+ });
2284
+ this.pushEvent({
2285
+ event: 'agent:generating_completed',
2286
+ chatTitle,
2287
+ duration: 0,
2288
+ timestamp: now,
2289
+ finalSummary: fcFinalSummary,
2290
+ evidenceLevel: 'weak',
2291
+ completionDiagnostic: {
2292
+ reason,
2293
+ finalAssistantEvidenceSource: fcEvidenceSource,
2294
+ ...(missingEvidence ? { blockReason: 'missing_final_assistant' } : {}),
2295
+ },
2296
+ });
2297
+ return true;
2298
+ }
2299
+
873
2300
  private detectStatusTransition(): void {
874
2301
  const now = Date.now();
875
2302
  // Status-change handling is a hot path: PTY output can fire it many times
876
2303
  // during long-running CLI sessions. Keep this path on adapter-owned light
877
2304
  // state only; rich provider parsing is reserved for getState/read_chat.
878
2305
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
2306
+ const adapterProviderSessionId = normalizeProviderSessionId(
2307
+ this.provider,
2308
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
2309
+ );
2310
+ if (adapterProviderSessionId) {
2311
+ this.promoteProviderSessionId(adapterProviderSessionId);
2312
+ }
879
2313
  const parsedStatus = null;
880
2314
  const rawStatus = adapterStatus.status;
881
2315
  const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, now);
882
- const newStatus = autoApproveActive ? 'generating' : rawStatus;
883
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
2316
+ // During the autoApproveBusy window (2s after firing approval key), the PTY
2317
+ // can briefly report 'idle' before the next generating phase starts. Treat that
2318
+ // transient idle as 'generating' to suppress a spurious agent:generating_completed
2319
+ // push notification. The adapter's status is otherwise authoritative — native
2320
+ // transcript shape does NOT override the FSM's busy/idle decision.
2321
+ const autoApproveHoldIdle = this.autoApproveBusy && rawStatus === 'idle';
2322
+ const newStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : rawStatus;
2323
+ const dirName = workingDirBasename(this.workingDir);
884
2324
  const chatTitle = `${this.provider.name} · ${dirName}`;
885
2325
  const partial = this.adapter.getPartialResponse();
2326
+ // Liveness fingerprint for the no-progress watchdog. The parsed
2327
+ // assistant buffer (`partial`) alone goes static while a tool/build runs
2328
+ // — the assistant emits no tokens even though the PTY is actively
2329
+ // printing tool output — which made the watchdog false-fire a "stuck"
2330
+ // alert mid-turn. Fold in the adapter's raw-activity timestamps so any
2331
+ // visible terminal progress (lastScreenChangeAt) or raw PTY byte
2332
+ // (lastOutputAt) keeps the fingerprint moving. The watchdog then only
2333
+ // survives a genuine stall where nothing at all is happening.
886
2334
  const progressFingerprint = newStatus === 'generating'
887
- ? `${partial || ''}`.slice(-2000)
2335
+ ? `${`${partial || ''}`.slice(-2000)}::scr=${adapterStatus.lastScreenChangeAt ?? 0}::out=${adapterStatus.lastOutputAt ?? 0}`
888
2336
  : undefined;
889
2337
 
890
2338
  const previousStatus = this.lastStatus;
891
2339
  if (newStatus !== this.lastStatus) {
892
2340
  LOG.info('CLI', `[${this.type}] status: ${this.lastStatus} → ${newStatus}`);
893
- if (this.lastStatus === 'idle' && newStatus === 'generating') {
2341
+ // COMPLETION-EARLYNOTIFY: snapshot every FSM status transition (the arm/fire/cancel
2342
+ // decisions downstream all hang off these edges). Guarded so production pays only a
2343
+ // boolean check; payload carries the visibility/auto-approve flags and the continuity
2344
+ // clocks (busyEpoch / lastOutputAt / lastScreenChangeAt) that the completion gate reads.
2345
+ if (this.fsmTraceOn()) this.recordFsmTransitionTrace({
2346
+ from: this.lastStatus,
2347
+ to: newStatus,
2348
+ rawStatus,
2349
+ autoApproveActive,
2350
+ autoApproveHoldIdle,
2351
+ autoApproveBusy: this.autoApproveBusy,
2352
+ hasPending: this.hasAdapterPendingResponse(),
2353
+ busyEpoch: this.busyEpoch,
2354
+ lastOutputAt: typeof adapterStatus?.lastOutputAt === 'number' ? adapterStatus.lastOutputAt : null,
2355
+ lastScreenChangeAt: typeof adapterStatus?.lastScreenChangeAt === 'number' ? adapterStatus.lastScreenChangeAt : null,
2356
+ });
2357
+ // GENERATING-MISSING (win32 fresh-worktree first-turn): a freshly-launched session
2358
+ // is in 'starting' until its startup-grace settles to idle. When the FIRST inject
2359
+ // lands inside that grace window, the adapter can report status DIRECTLY
2360
+ // starting → generating without an intervening 'idle' frame for
2361
+ // detectStatusTransition() to observe. Previously only the idle→generating arm
2362
+ // armed the bookkeeping, so a starting→generating frame fell straight through to the
2363
+ // bare `this.lastStatus = newStatus` update: generatingStartedAt stayed 0 and no
2364
+ // generating_started was queued. The fast turn's generating→idle completion was then
2365
+ // suppressed by the startup-blip guard below (generatingStartedAt===0 &&
2366
+ // !generatingDebouncePending) — so NO generating_started AND NO generating_completed
2367
+ // ever fired and the mesh coordinator never learned the worker went idle.
2368
+ //
2369
+ // We extend the idle→generating arm to also fire on starting→generating, BUT ONLY
2370
+ // when a real turn is in flight. The adapter script can also report 'generating' from
2371
+ // pure startup PTY noise (no task dispatched) — antigravity/codex/hermes-cli all
2372
+ // exercise that benign starting→generating→idle blip, which must NOT emit a
2373
+ // completion (see "startup-phase spurious completion suppression" tests).
2374
+ // hasAdapterPendingResponse() is the discriminator: a genuine inject sets the
2375
+ // adapter's isWaitingForResponse / currentTurnScope (or leaves a partial response),
2376
+ // whereas startup repaint noise leaves all of them empty. So an armed
2377
+ // starting→generating means "the worker actually started its first turn", and a
2378
+ // bare one stays a suppressed blip via the existing fall-through.
2379
+ const startingToGeneratingWithActiveTurn = this.lastStatus === 'starting'
2380
+ && newStatus === 'generating'
2381
+ && this.hasAdapterPendingResponse();
2382
+ if (((this.lastStatus === 'idle' && newStatus === 'generating') || startingToGeneratingWithActiveTurn)) {
2383
+ // If a completion event is already pending and the turn has ended
2384
+ // (generatingStartedAt===0), the PTY is painting its prompt area
2385
+ // after completing. Ignore this blip — do not cancel the pending
2386
+ // completion and do not advance lastStatus to generating. (On a true
2387
+ // starting→generating the session is fresh: completedDebouncePending is
2388
+ // null, so this blip guard is a no-op and we arm normally below.)
2389
+ if (this.completedDebouncePending && this.generatingStartedAt === 0) {
2390
+ LOG.debug('CLI', `[${this.type}] ignoring post-completion PTY generating blip (generatingStartedAt=0)`);
2391
+ return;
2392
+ }
894
2393
  this.suppressIdleHistoryReplay = false;
895
2394
  // Cancel any pending completed event (multi-step: idle→generating resume)
896
2395
  if (this.completedDebouncePending) {
897
- LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating)`);
2396
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating) generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse}`);
898
2397
  if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
899
2398
  this.completedDebouncePending = null;
900
2399
  }
901
2400
 
902
2401
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2402
+ // FALSE-IDLE continuity: entering a busy phase invalidates any
2403
+ // completedDebouncePending armed earlier in this settle window.
2404
+ this.busyEpoch++;
903
2405
  // Defer the generating_started event — if idle comes back within 3s,
904
2406
  // the whole started→completed pair was a false positive from PTY noise
905
2407
  if (this.generatingDebounceTimer) clearTimeout(this.generatingDebounceTimer);
@@ -924,14 +2426,38 @@ export class CliProviderInstance implements ProviderInstance {
924
2426
  this.completedDebouncePending = null;
925
2427
 
926
2428
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2429
+ // FALSE-IDLE continuity: waiting_approval is a busy phase (the agent
2430
+ // resumes into it), so bump the epoch too — the completedDebouncePending
2431
+ // cancel above covers the currently-armed pending, and the epoch covers
2432
+ // a pending that re-arms and flushes across this same valley.
2433
+ this.busyEpoch++;
927
2434
  const modal = adapterStatus.activeModal;
928
2435
  LOG.info('CLI', `[${this.type}] approval modal: "${modal?.message?.slice(0, 80) ?? 'none'}"`);
929
- // Only push event if not already in waiting_approval (prevent flood from rapid cycles)
930
- const approvalCooldown = 5000;
931
- if (this.lastStatus !== 'waiting_approval' && (!this.lastApprovalEventAt || now - this.lastApprovalEventAt > approvalCooldown)) {
932
- this.lastApprovalEventAt = now;
2436
+ // Include the FSM's approval entry seq, mirroring the auto-approve
2437
+ // path (maybeAutoApproveStatus) and resolveModal's sameEntryReResolve
2438
+ // guard. Two distinct back-to-back approvals can carry identical
2439
+ // message/buttons (very common with claude-cli's "Allow Bash
2440
+ // command?"). Without the seq their fingerprints collide and the dedup
2441
+ // below silently drops the second waiting_approval event — it is never
2442
+ // emitted, so it cannot even land in the pending inbox for a later
2443
+ // read_chat reconcile to recover. The seq is bumped by the FSM on every
2444
+ // fresh waiting_approval entry, so a new approval always yields a new
2445
+ // fingerprint and emits.
2446
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2447
+ ? adapterStatus.approvalEntrySeq
2448
+ : 0;
2449
+ const approvalFingerprint = JSON.stringify({
2450
+ message: typeof modal?.message === 'string' ? modal.message.trim() : '',
2451
+ buttons: Array.isArray(modal?.buttons) ? modal.buttons.map((button: unknown) => String(button).trim()) : [],
2452
+ seq: approvalEntrySeq,
2453
+ });
2454
+ // PTY redraws repeat the same modal content; fingerprint dedup prevents duplicate events.
2455
+ // Do NOT also gate on lastStatus: consecutive approvals can arrive waiting_approval→waiting_approval
2456
+ // (e.g. antigravity-cli resolves one prompt and immediately shows the next) and would be silently dropped.
2457
+ if (approvalFingerprint !== this.lastApprovalEventFingerprint) {
2458
+ this.lastApprovalEventFingerprint = approvalFingerprint;
933
2459
  this.appendRuntimeSystemMessage(
934
- this.formatApprovalRequestMessage(modal?.message, modal?.buttons),
2460
+ formatApprovalRequestMessage(modal?.message, modal?.buttons),
935
2461
  `approval_request:${now}`,
936
2462
  now,
937
2463
  );
@@ -941,22 +2467,287 @@ export class CliProviderInstance implements ProviderInstance {
941
2467
  modalButtons: modal?.buttons,
942
2468
  });
943
2469
  }
2470
+ } else if (newStatus === 'generating' && this.lastStatus === 'waiting_approval') {
2471
+ // Approval resolved and the agent resumed work. Defense-in-depth:
2472
+ // clear the approval emit fingerprint here too (not only on
2473
+ // completion at scheduleCompletedDebounceFlush). A subsequent
2474
+ // waiting_approval with the same modal content as the one just
2475
+ // resolved would otherwise collide with the stale fingerprint and be
2476
+ // dropped. The seq in the fingerprint already separates entries; this
2477
+ // reset is a belt-and-suspenders guard for the re-entry case.
2478
+ this.lastApprovalEventFingerprint = '';
944
2479
  } else if (newStatus === 'idle' && (this.lastStatus === 'generating' || this.lastStatus === 'waiting_approval')) {
945
2480
  const duration = this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : 0;
946
- // If debounce still pending (generating lasted < 1s), cancel both events
2481
+ // Guard: if generatingStartedAt===0 and no debounce pending, the generating phase
2482
+ // was entered from 'starting' state (startup PTY noise), not from a real idle→generating
2483
+ // task dispatch. The idle→generating handler is the only code path that sets
2484
+ // generatingStartedAt and generatingDebouncePending, so both being absent means no
2485
+ // task was ever dispatched. Suppress the spurious completion event and fall through
2486
+ // to a simple lastStatus update.
2487
+ if (!this.generatingStartedAt && !this.generatingDebouncePending) {
2488
+ LOG.debug('CLI', `[${this.type}] suppressed startup-phase generating→idle blip (generatingStartedAt=0, no debounce pending)`);
2489
+ } else
2490
+ // If debounce still pending (generating lasted < 1s), cancel both UI events.
2491
+ // Still emit agent:generating_completed so mesh orchestration can record
2492
+ // task_completed for direct dispatches that complete faster than the debounce.
947
2493
  if (this.generatingDebouncePending) {
948
- LOG.info('CLI', `[${this.type}] suppressed short generating (${now - this.generatingStartedAt}ms)`);
2494
+ // NOTIF Defect-2a: shortDurationMs is the REPORTED turn duration, so it must be
2495
+ // measured from the IMMUTABLE turn start — not generatingStartedAt, which is
2496
+ // reset to 0 on every mid-turn waiting_approval/idle blip (see :1864/1885/2397/
2497
+ // 2503/2521) and re-armed on the next →generating, so a long turn that blipped
2498
+ // would measure only the final 1.5-2.5s sliver. engine.currentTurnStartedAt is
2499
+ // stamped once at onTurnStarted and persists past mid-turn blips until the next
2500
+ // turn starts, so it captures the true turn length. generatingStartedAt remains
2501
+ // the fallback (and the debounce itself stays a pure UI-suppression signal,
2502
+ // decoupled from the reported duration).
2503
+ const { durationMs: shortDurationMs, anchor: durationAnchor } = computeTurnAnchoredDurationMs(
2504
+ (this.adapter as any)?.currentTurnStartedAt,
2505
+ this.generatingStartedAt,
2506
+ now,
2507
+ );
2508
+ LOG.info('CLI', `[${this.type}] suppressed short generating (${shortDurationMs}ms, anchor=${durationAnchor})`);
949
2509
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2510
+ // Emit completion for mesh task association even though the UI generating
2511
+ // started/completed pair is suppressed (too short for visible UI update).
2512
+ let shortFinalSummary: string | undefined;
2513
+ let shortEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2514
+ try {
2515
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2516
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2517
+ shortEvidenceSource = evidence.source;
2518
+ shortFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2519
+ } catch { /* best-effort */ }
2520
+ // If a real response is confirmed, retroactively emit started so the chat
2521
+ // bubble appears even though the debounce suppressed the original event.
2522
+ if (shortFinalSummary) {
2523
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now - shortDurationMs });
2524
+ }
2525
+ // FALSE-IDLE short-gen settle: snapshot the producing turn's start + taskId NOW,
2526
+ // before `generatingStartedAt` is reset below — the settle-arm path (mesh sessions,
2527
+ // see the mesh branch further down) needs the same turn anchor the normal
2528
+ // completedDebounce branch captures, and generatingStartedAt is the fallback for it.
2529
+ const shortEngineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2530
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2531
+ ? (this.adapter as any).currentTurnStartedAt as number
2532
+ : 0;
2533
+ const shortTurnStartedAt = shortEngineTurnStart || this.generatingStartedAt || 0;
2534
+ const shortTaskId = this.completingTurnTaskId();
950
2535
  this.generatingDebouncePending = null;
951
2536
  this.generatingStartedAt = 0;
2537
+ // FALSE-IDLE short-gen: a short-generating completion with NO transcript
2538
+ // backing at all (shortEvidenceSource === 'unavailable': both the screen parse
2539
+ // AND the external-native transcript failed to yield a final assistant) is just
2540
+ // as unproven as an 'external-native' source that returned no final assistant.
2541
+ // Fold 'unavailable' into the missing-evidence predicate so a zero-evidence dip
2542
+ // (the mid-turn point-sample that triggered this whole false-idle bug) is treated
2543
+ // as weak/held, not fired as a genuine completion. A real shortFinalSummary being
2544
+ // present still clears the gate (the !shortFinalSummary guard is unchanged).
2545
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true
2546
+ || shortEvidenceSource === 'external-native'
2547
+ || shortEvidenceSource === 'unavailable') && !shortFinalSummary;
2548
+ if (missingEvidence) {
2549
+ LOG.warn('CLI', `[${this.type}] short completion missing final assistant evidence (source=${shortEvidenceSource})`);
2550
+ }
2551
+ if (this.isAutonomousMeshSession()) {
2552
+ // FALSE-IDLE short-gen settle (the core fix): for an autonomously-progressing
2553
+ // mesh session (delegated worker OR self-coordinator), the short-generating
2554
+ // branch was a POINT-SAMPLE — a single idle read from getStatus({allowParse:false})
2555
+ // that fires the completion INLINE with zero continuity backing. When the worker
2556
+ // is merely mid-turn (a sub-3s dip between two tool calls), this synchronously
2557
+ // emitted a false agent:generating_completed the coordinator can never correct.
2558
+ //
2559
+ // Route it through the SAME settle + continuity machinery as the normal
2560
+ // completedDebounce branch: arm completedDebouncePending capturing busyEpochAtArm
2561
+ // and lastOutputAtArm, then scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS)
2562
+ // so flushCompletedDebounceIfFinalized() re-verifies CONTINUOUS idle before emitting.
2563
+ // A busy re-entry (busyEpoch bump) or new PTY output within the settle window —
2564
+ // exactly what happens when the worker resumes its next tool call — CANCELS the
2565
+ // false completion. Genuine completions (real final assistant) still emit at the
2566
+ // end of the (short, 4s) settle window; missingEvidence flows through the
2567
+ // finalization block (missing_final_assistant → CANON-C weak/held) rather than
2568
+ // being frozen as a genuine inline fire.
2569
+ this.completedDebouncePending = {
2570
+ chatTitle,
2571
+ duration: Math.round(shortDurationMs / 1000),
2572
+ timestamp: now,
2573
+ firstObservedAt: now,
2574
+ // Short-gen enters from generating→idle (or waiting_approval→idle); the
2575
+ // completedDebounce finalization gate treats previousStatus for its
2576
+ // approval-resolution / inter-approval-valley handling. lastStatus is the
2577
+ // status we transitioned FROM here.
2578
+ previousStatus: this.lastStatus,
2579
+ ...(shortTaskId ? { taskId: shortTaskId } : {}),
2580
+ ...(shortTurnStartedAt ? { turnStartedAt: shortTurnStartedAt } : {}),
2581
+ // FALSE-IDLE continuity: same arm-time snapshots as the normal branch so the
2582
+ // flush guard can prove continuous idle across the settle window.
2583
+ busyEpochAtArm: this.busyEpoch,
2584
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2585
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2586
+ : {}),
2587
+ };
2588
+ LOG.info('CLI', `[${this.type}] short-generating routed through settle window (${shortDurationMs}ms, source=${shortEvidenceSource}, missingEvidence=${missingEvidence}) — arming completedDebouncePending instead of inline fire`);
2589
+ // EVTTRACE: now traces the settle ARM (not an inline fire) for mesh sessions,
2590
+ // so logs show the short-gen path deferring to continuity re-check.
2591
+ if (this.isMeshWorkerSession()) {
2592
+ traceMeshEventStage('arm', this.meshTraceCtx(), `short-generating settle-arm (source=${shortEvidenceSource}, missingEvidence=${missingEvidence})`);
2593
+ }
2594
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('arm', {
2595
+ branch: 'short_generating',
2596
+ previousStatus: this.lastStatus,
2597
+ turnStartedAt: shortTurnStartedAt || null,
2598
+ busyEpochAtArm: this.busyEpoch,
2599
+ lastOutputAtArm: typeof adapterStatus?.lastOutputAt === 'number' ? adapterStatus.lastOutputAt : null,
2600
+ flushDelay: NATIVE_HISTORY_MESH_IDLE_SETTLE_MS,
2601
+ evidenceSource: shortEvidenceSource,
2602
+ missingEvidence,
2603
+ hasFinalSummary: !!shortFinalSummary,
2604
+ });
2605
+ this.scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS);
2606
+ } else if (missingEvidence) {
2607
+ // NON-MESH, missing evidence: suppress the completion event entirely (the
2608
+ // original !hasMeshContext suppression). A genuinely non-mesh session has no
2609
+ // coordinator to notify, and firing a completion with no confirmed final
2610
+ // assistant would just surface an empty/unconfirmed turn. Leave
2611
+ // completedDebouncePending null — the session is now idle with no confirmed
2612
+ // turn, matching the startup-blip suppression semantics. (No EvtTrace: not a
2613
+ // mesh session, so nothing routes to a coordinator.)
2614
+ LOG.info('CLI', `[${this.type}] short completion suppressed: missing final assistant evidence, non-mesh session (source=${shortEvidenceSource})`);
2615
+ } else {
2616
+ // NON-MESH interactive fast-path with a CONFIRMED summary: keep the existing
2617
+ // inline fire. The dashboard UX reason for the short path (a fast turn should
2618
+ // surface its completion promptly without a 4s settle) still holds, and a
2619
+ // non-mesh session has no coordinator to be falsely notified — the false-idle
2620
+ // bug being fixed is specifically the mesh worker/coordinator misfire above.
2621
+ this.pushEvent({
2622
+ event: 'agent:generating_completed',
2623
+ chatTitle,
2624
+ duration: 0,
2625
+ timestamp: now,
2626
+ finalSummary: shortFinalSummary,
2627
+ completionDiagnostic: {
2628
+ reason: 'short_generating_suppressed',
2629
+ shortDurationMs,
2630
+ finalAssistantEvidenceSource: shortEvidenceSource,
2631
+ },
2632
+ });
2633
+ }
952
2634
  } else {
953
2635
  // Debounce completed, then require the rich transcript path that read_chat
954
2636
  // uses to show an idle turn whose last user-facing message is assistant.
955
- this.completedDebouncePending = { chatTitle, duration, timestamp: now, firstObservedAt: now };
956
- this.scheduleCompletedDebounceFlush(3000);
2637
+ this.completedDebouncePending = {
2638
+ chatTitle,
2639
+ duration,
2640
+ timestamp: now,
2641
+ firstObservedAt: now,
2642
+ previousStatus: this.lastStatus,
2643
+ // ARCH-REFACTOR R1: snapshot the completing turn's taskId NOW (sync),
2644
+ // before any follow-up task's flush can start a new turn and move
2645
+ // engine.currentTurnTaskId.
2646
+ ...(this.completingTurnTaskId() ? { taskId: this.completingTurnTaskId() } : {}),
2647
+ // NOTIF Defect-B: snapshot the producing turn's START instant NOW, for the
2648
+ // same reason as taskId — a follow-up turn moves engine.currentTurnStartedAt.
2649
+ // Prefer the engine's per-turn start (set at onTurnStarted, earliest reliable
2650
+ // anchor) and fall back to generatingStartedAt (when generating was observed).
2651
+ ...((() => {
2652
+ const engineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2653
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2654
+ ? (this.adapter as any).currentTurnStartedAt as number
2655
+ : 0;
2656
+ const turnStartedAt = engineTurnStart || this.generatingStartedAt || 0;
2657
+ return turnStartedAt ? { turnStartedAt } : {};
2658
+ })()),
2659
+ // FALSE-IDLE continuity: snapshot the busy epoch + raw PTY output
2660
+ // clock at arm time so the flush guard can prove the session stayed
2661
+ // continuously idle (no busy re-entry, no new PTY output) through the
2662
+ // settle window rather than merely reading 'idle' once at flush.
2663
+ busyEpochAtArm: this.busyEpoch,
2664
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2665
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2666
+ : {}),
2667
+ };
2668
+ const ownsExternalHistory = !!(this.adapter as any)?.chatMessagesOwnedExternally;
2669
+ // (FALSEIDLE-BGCHILD-a) Native-history providers flush immediately (the
2670
+ // transcript is authoritative). For autonomously-progressing mesh sessions,
2671
+ // give the generating→idle transition a short settle window so a background-child
2672
+ // false idle (quiet after a backgrounded test/command while the parent turn
2673
+ // continues) or an inter-approval auto-approve valley gets caught by the resume
2674
+ // guard in flushCompletedDebounceIfFinalized instead of firing an early completion
2675
+ // the coordinator can never correct.
2676
+ //
2677
+ // (FALSE-IDLE self-coordinator settle) The settle window now covers BOTH mesh
2678
+ // worker sessions AND the coordinator's own claude-cli session (meshCoordinatorFor):
2679
+ // isAutonomousMeshSession(). Previously only isMeshWorkerSession() qualified, so a
2680
+ // self-coordinating daemon (worker + coordinator on the same daemon) ran the
2681
+ // coordinator's own turn at flushDelay=0 — no settle window at all — and the
2682
+ // busyEpoch/lastOutputAt continuity guard, being a flush-time point-check, had no
2683
+ // window in which to observe the ~0.5s auto-approve valley. Its mid-turn
2684
+ // "next-step" sentence was flushed as finalSummary. A genuinely non-mesh session
2685
+ // (neither worker nor self-coordinator) still flushes immediately (delay=0), so
2686
+ // no non-mesh behaviour changes; this only ADDS a settle window (strictly
2687
+ // stricter — the guard can only ever CANCEL a pending flush, never emit more).
2688
+ const meshSettleSession = this.isAutonomousMeshSession();
2689
+ const flushDelay = ownsExternalHistory
2690
+ ? (meshSettleSession ? NATIVE_HISTORY_MESH_IDLE_SETTLE_MS : 0)
2691
+ : 3000;
2692
+ LOG.debug('CLI', `[${this.type}] set completedDebouncePending duration=${duration}s ownsExternalHistory=${ownsExternalHistory} meshSettle=${meshSettleSession} flushDelay=${flushDelay}ms generatingStartedAt=${this.generatingStartedAt}`);
2693
+ if (this.completionTraceOn()) this.recordCompletionGateTrace('arm', {
2694
+ branch: 'normal',
2695
+ previousStatus: this.completedDebouncePending.previousStatus,
2696
+ turnStartedAt: this.completedDebouncePending.turnStartedAt ?? null,
2697
+ busyEpochAtArm: this.completedDebouncePending.busyEpochAtArm ?? null,
2698
+ lastOutputAtArm: this.completedDebouncePending.lastOutputAtArm ?? null,
2699
+ flushDelay,
2700
+ ownsExternalHistory,
2701
+ meshSettle: meshSettleSession,
2702
+ });
2703
+ this.scheduleCompletedDebounceFlush(flushDelay);
957
2704
  }
958
2705
  } else if (newStatus === 'idle' && this.lastStatus === 'starting') {
959
- this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2706
+ this.emitAgentReadyOnce(chatTitle, now);
2707
+ // GENERATING-BOUNDARY (R4c): stamp the collapse moment ONCE so the
2708
+ // idle-stayed window below is anchored on the startup-grace collapse,
2709
+ // not on boot. Set only the first time so a later starting re-entry
2710
+ // cannot slide the window forward.
2711
+ if (this.startupGraceCollapseAt === null) this.startupGraceCollapseAt = now;
2712
+ // GENERATING-BOUNDARY fast-collapse (R4, win32 startup-grace first turn):
2713
+ // a turn dispatched into the startup-grace window can START and FINISH while
2714
+ // the FSM is still in 'starting'. On a daemon whose claude-cli spec has NOT yet
2715
+ // synced the starting→busy edge (the primary cure lives in the spec's
2716
+ // idle→busy.from), the FSM never reaches 'busy'/generating, so
2717
+ // detectStatusTransition observes starting→idle DIRECTLY with no intervening
2718
+ // 'generating' frame. The idle→generating arm — the only path that sets
2719
+ // generatingStartedAt and arms the completion — never fired, so the completing
2720
+ // turn's agent:generating_completed is never emitted and the mesh coordinator
2721
+ // never learns the worker went idle. Synthesize the started+completed pair here.
2722
+ //
2723
+ // Discriminator (false-positive safe — must NOT fire on a benign boot):
2724
+ // adapter.currentTurnTaskId is set ONLY by onTurnStarted (a real turn STARTED
2725
+ // this boot) and persists past completion, so it cleanly separates the three
2726
+ // non-firing cases — a true idle boot (no turn → null), a queued-pending
2727
+ // first turn that only runs AFTER startup-grace drains the composer (onTurnStarted
2728
+ // not yet called → null; it completes normally later via idle→busy→idle), and a
2729
+ // turn STILL running at the 8s mark (hasAdapterPendingResponse() still true →
2730
+ // excluded so we don't fire a premature mid-turn completion; idle→busy self-
2731
+ // corrects once the FSM reaches idle). We fire only when a turn started AND has
2732
+ // already finished: started-this-boot && !still-in-flight.
2733
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_fast_collapse');
2734
+ } else if (newStatus === 'error') {
2735
+ if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2736
+ this.generatingDebouncePending = null;
2737
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
2738
+ this.completedDebouncePending = null;
2739
+ this.errorMessage = adapterStatus.errorMessage || this.errorMessage;
2740
+ this.errorReason = (adapterStatus.errorReason as ProviderErrorReason) || this.errorReason;
2741
+ this.pushEvent({
2742
+ event: 'agent:stopped',
2743
+ chatTitle,
2744
+ timestamp: now,
2745
+ finalSummary: adapterStatus.errorMessage || adapterStatus.errorReason || 'Provider reported an error',
2746
+ completionDiagnostic: {
2747
+ reason: adapterStatus.errorReason || 'provider_error',
2748
+ errorMessage: adapterStatus.errorMessage || undefined,
2749
+ },
2750
+ });
960
2751
  } else if (newStatus === 'stopped') {
961
2752
  // Cancel any pending debounce
962
2753
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
@@ -968,6 +2759,79 @@ export class CliProviderInstance implements ProviderInstance {
968
2759
  this.lastStatus = newStatus;
969
2760
  }
970
2761
 
2762
+ // GENERATING-BOUNDARY idle-stayed collapse (R4b): the starting→idle
2763
+ // fast-collapse arm above only fires when the FIRST turn itself drives the
2764
+ // starting→idle transition. When the launch settle already drained
2765
+ // starting→idle BEFORE the first turn arrives, the session is already 'idle'
2766
+ // and a turn that runs+completes inside the startup-grace window — too fast
2767
+ // for any poll to observe a 'generating' frame — produces NO status change
2768
+ // at all (idle→idle). detectStatusTransition's change block above is skipped
2769
+ // entirely, so neither the idle→generating arm nor the starting→idle
2770
+ // fast-collapse arm ever runs, and the mesh coordinator never learns the
2771
+ // worker went idle (the live rc.403 Probe1 miss). Catch it here: an
2772
+ // already-idle poll (no status change), still inside the startup-grace
2773
+ // window, where a turn started this boot and has already finished without
2774
+ // ever arming generating. The same false-positive-safe discriminators apply
2775
+ // (currentTurnTaskId set && !pending && generating never armed), plus a
2776
+ // once-per-turn guard since this branch is re-polled while the session sits
2777
+ // idle. Normal turns that DO reach 'busy' set generatingStartedAt and are
2778
+ // excluded; a queued-pending first turn that only runs after grace falls
2779
+ // outside the window and completes normally via idle→busy→idle.
2780
+ //
2781
+ // R4d (the live rc.405 Probe2 miss): R4c anchored the window on the collapse
2782
+ // moment but still measured its END against `now` (the poll/completion time). The
2783
+ // helper only fires once the turn has FINISHED (!hasAdapterPendingResponse()), so
2784
+ // the first eligible poll happens at completion. When the first turn is dispatched
2785
+ // a few seconds after the collapse AND runs for a non-trivial duration, that
2786
+ // completion lands PAST the 12s now-anchored window even though the turn was a
2787
+ // genuine startup-grace first turn (live: collapse→dispatch +5.2s, turn ~11s →
2788
+ // completion at collapse+16.2s > 12s). Anchor the window on when the first turn
2789
+ // STARTED (engine.currentTurnStartedAt, set by onTurnStarted) instead: a turn that
2790
+ // STARTED within the collapse window is a startup-grace first turn no matter how
2791
+ // long it then ran. The now-anchored check is retained as a union so a fast turn
2792
+ // (dispatched+completed quickly within 12s of collapse) keeps firing too; both
2793
+ // close for a much-later turn, preserving the "don't mislabel a late fast turn"
2794
+ // honesty the window exists for.
2795
+ const firstTurnStartedAt = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2796
+ ? (this.adapter as any).currentTurnStartedAt as number
2797
+ : 0;
2798
+ const collapsedAt = this.startupGraceCollapseAt;
2799
+ const turnStartedWithinCollapseWindow = collapsedAt !== null
2800
+ && firstTurnStartedAt > 0
2801
+ && firstTurnStartedAt >= collapsedAt
2802
+ && (firstTurnStartedAt - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
2803
+ const nowWithinCollapseWindow = collapsedAt !== null
2804
+ && (now - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
2805
+ if (
2806
+ newStatus === 'idle'
2807
+ && previousStatus === 'idle'
2808
+ && (turnStartedWithinCollapseWindow || nowWithinCollapseWindow)
2809
+ ) {
2810
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_idle_turn_collapse');
2811
+ }
2812
+
2813
+ // Re-arm the queue-claim agent:ready on the FSM's first GENUINE ready.
2814
+ //
2815
+ // The boot-time starting→idle one-shot above is the historical claim
2816
+ // trigger, but it is consumed too early for FSM-spec providers whose
2817
+ // INITIAL state already reports status 'idle' (e.g. antigravity-cli): the
2818
+ // adapter reports idle before maybeMarkReady has fired, so lastStatus
2819
+ // advances starting→idle while the prompt is not yet drawn and the worker
2820
+ // cannot yet claim. Subsequent state-driven idle frames are idle→idle (no
2821
+ // status change), so the one-shot never re-fires and the worker strands its
2822
+ // queued task — the coordinator then relaunch-loops every ~90s.
2823
+ //
2824
+ // The adapter surfaces fsmReadySeen=true exactly when the FSM reaches its
2825
+ // first non-initial idle (the prompt is genuinely up). On that signal we
2826
+ // emit agent:ready once more. emitAgentReadyOnce is idempotent (guarded by
2827
+ // agentReadyEmitted), so providers whose boot one-shot already landed on a
2828
+ // real ready (claude-cli / codex-cli / hermes-cli, which use a startup
2829
+ // grace and whose initial state is not idle) treat this as a no-op — no
2830
+ // double claim, no double task injection.
2831
+ if (newStatus === 'idle' && adapterStatus.fsmReadySeen === true && !this.agentReadyEmitted) {
2832
+ this.emitAgentReadyOnce(chatTitle, now);
2833
+ }
2834
+
971
2835
  this.applyProviderResponse(parsedStatus, {
972
2836
  phase: (newStatus === 'idle' && (previousStatus === 'generating' || previousStatus === 'waiting_approval'))
973
2837
  ? 'turn_completed'
@@ -976,8 +2840,43 @@ export class CliProviderInstance implements ProviderInstance {
976
2840
 
977
2841
  // Monitor check (cooldown based notification, IDE/CLI common)
978
2842
  const agentKey = `${this.type}:cli`;
979
- const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint);
2843
+ // Approval pending is detected from the raw adapter status, not `newStatus`:
2844
+ // auto-approve synthesizes `waiting_approval` → 'generating', which would
2845
+ // otherwise let the no-progress watchdog accumulate the approval wait.
2846
+ const approvalPending = rawStatus === 'waiting_approval';
2847
+ const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint, approvalPending);
2848
+ const monitorParsedStatus: any = parsedStatus;
980
2849
  for (const me of monitorEvents) {
2850
+ if (
2851
+ me.type === 'monitor:no_progress'
2852
+ && this.completionHasFinalAssistantMessage(monitorParsedStatus?.messages)
2853
+ && !this.hasAdapterPendingResponse()
2854
+ && !hasNonEmptyCliModalButtons(monitorParsedStatus?.activeModal ?? monitorParsedStatus?.modal)
2855
+ ) {
2856
+ // EVTTRACE: completion fired (no-progress monitor reconciled to completion).
2857
+ if (this.isMeshWorkerSession()) {
2858
+ traceMeshEventStage('fired', this.meshTraceCtx(), 'no_progress_monitor_final_summary');
2859
+ }
2860
+ this.pushEvent({
2861
+ event: 'agent:generating_completed',
2862
+ chatTitle,
2863
+ duration: this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : undefined,
2864
+ timestamp: me.timestamp,
2865
+ finalSummary: extractFinalSummaryFromMessages(monitorParsedStatus?.messages),
2866
+ completionDiagnostic: {
2867
+ providerType: this.type,
2868
+ sessionId: this.instanceId,
2869
+ providerSessionId: this.providerSessionId || null,
2870
+ reconciliationReason: 'no_progress_monitor_final_summary',
2871
+ finalAssistantPresent: true,
2872
+ },
2873
+ });
2874
+ this.generatingStartedAt = 0;
2875
+ // Cancel any pending debounce flush — monitor already fired completion.
2876
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
2877
+ this.completedDebouncePending = null;
2878
+ continue;
2879
+ }
981
2880
  this.pushEvent({ event: me.type, agentKey: me.agentKey, message: me.message, elapsedSec: me.elapsedSec, timestamp: me.timestamp });
982
2881
  }
983
2882
  }
@@ -997,15 +2896,61 @@ export class CliProviderInstance implements ProviderInstance {
997
2896
  workspaceName: typeof event.workspaceName === 'string' && event.workspaceName.trim()
998
2897
  ? event.workspaceName
999
2898
  : this.workingDir,
2899
+ // Carry the workspace under BOTH `workspace` and `workspaceName` so the
2900
+ // downstream mesh forward/merge path — which reads `workspace` — can
2901
+ // propagate it to the coordinator snapshot. Without `workspace` the live
2902
+ // event path delivers an empty workspace and the dashboard falls back to
2903
+ // the generic "Terminal (Mesh Node)" title.
2904
+ workspace: typeof event.workspace === 'string' && event.workspace.trim()
2905
+ ? event.workspace
2906
+ : this.workingDir,
1000
2907
  providerSessionId: typeof event.providerSessionId === 'string' && event.providerSessionId.trim()
1001
2908
  ? event.providerSessionId
1002
2909
  : this.providerSessionId,
1003
2910
  };
2911
+ // TASKIDLESS: stamp the mesh task primary key on lifecycle events emitted by
2912
+ // a mesh worker session. The consumer (updateDirectDispatchStatus) was switched
2913
+ // to key on task_id (CANON-B), but the producer never carried it — so every
2914
+ // forwarded metadataEvent.taskId arrived undefined and the coordinator fell back
2915
+ // to a session_id match, which can flip a sibling dispatch row. Surface it here so
2916
+ // updateDirectDispatchStatus hits the exact PK row and the session_id fallback is
2917
+ // never exercised. Non-mesh sessions get no taskId (regression guard) —
2918
+ // isMeshWorkerSession() gates the injection.
2919
+ //
2920
+ // ARCH-REFACTOR R1 (per-turn identity): resolution order is
2921
+ // (1) an explicit taskId already on the event — the debounce-flush completion
2922
+ // path stamps the taskId captured at the generating→idle transition (the
2923
+ // turn that actually produced this completion);
2924
+ // (2) the per-turn binding (engine.currentTurnTaskId) for synchronously-emitted
2925
+ // events whose turn is still the current one;
2926
+ // (3) the legacy session scalar (settings.meshActiveTaskId) as a last-resort
2927
+ // backward-compat alias.
2928
+ // The scalar is last because it is last-write-wins: a second task attaching while
2929
+ // this turn was still running overwrites it, which is the exact NOTIF-MISDELIVER /
2930
+ // TASK-MSG-MISROUTE race this refactor removes.
2931
+ if (this.isMeshWorkerSession()) {
2932
+ const existingTaskId = typeof enrichedEvent.taskId === 'string' && enrichedEvent.taskId.trim()
2933
+ ? enrichedEvent.taskId
2934
+ : undefined;
2935
+ if (!existingTaskId) {
2936
+ const resolved = this.completingTurnTaskId();
2937
+ if (resolved) enrichedEvent.taskId = resolved;
2938
+ }
2939
+ }
1004
2940
  if (this.context?.emitProviderEvent) {
1005
2941
  this.context.emitProviderEvent(enrichedEvent);
1006
- return;
2942
+ } else {
2943
+ this.events.push(enrichedEvent);
2944
+ }
2945
+ // Auto-detach a direct-dispatch mesh assignment once the dispatched
2946
+ // task reaches a terminal state. Leaving meshNodeFor pinned would
2947
+ // route this session's next unrelated turn (a dashboard chat) into
2948
+ // the coordinator as if it were the completion of another task.
2949
+ // We schedule after the emit so the originating coordinator still
2950
+ // observes the completion event with its routing marker intact.
2951
+ if (TERMINAL_MESH_EVENTS.has(event.event) && this.settings.meshActiveTaskId) {
2952
+ try { this.detachMeshAssignment(); } catch { /* best-effort */ }
1007
2953
  }
1008
- this.events.push(enrichedEvent);
1009
2954
  }
1010
2955
 
1011
2956
  private flushEvents(): ProviderEvent[] {
@@ -1022,7 +2967,13 @@ export class CliProviderInstance implements ProviderInstance {
1022
2967
  typeof data.providerSessionId === 'string' ? data.providerSessionId : '',
1023
2968
  );
1024
2969
  if (patchedProviderSessionId) {
1025
- this.promoteProviderSessionId(patchedProviderSessionId);
2970
+ // A provider-response id is authoritative when it carries an
2971
+ // explicit `new_session` marker (the CLI genuinely started a new
2972
+ // conversation). Without that marker it's just an observed id and
2973
+ // must not hijack an existing binding (see promoteProviderSessionId).
2974
+ this.promoteProviderSessionId(patchedProviderSessionId, {
2975
+ authoritative: data.sessionEvent === 'new_session',
2976
+ });
1026
2977
  }
1027
2978
 
1028
2979
  if (data.sessionEvent === 'new_session') {
@@ -1047,7 +2998,7 @@ export class CliProviderInstance implements ProviderInstance {
1047
2998
  if (effectWhen === 'turn_completed' && options.phase !== 'turn_completed') continue;
1048
2999
  if (effectWhen === 'immediate' && options.phase === 'turn_completed') continue;
1049
3000
 
1050
- const effectKey = this.getEffectDedupKey(effect);
3001
+ const effectKey = getEffectDedupKey(effect);
1051
3002
  if (this.appliedEffectKeys.has(effectKey)) continue;
1052
3003
  this.appliedEffectKeys.add(effectKey);
1053
3004
 
@@ -1097,40 +3048,6 @@ export class CliProviderInstance implements ProviderInstance {
1097
3048
  this.appliedEffectKeys = new Set(Array.from(this.appliedEffectKeys).slice(-100));
1098
3049
  }
1099
3050
  }
1100
-
1101
- private getEffectDedupKey(effect: { id?: string; type: string; message?: { content?: unknown }; toast?: { message?: string }; notification?: { title?: string; body?: string } }): string {
1102
- if (effect.id) return `provider_effect:${effect.id}`;
1103
- if (effect.type === 'message') {
1104
- const content = typeof effect.message?.content === 'string'
1105
- ? effect.message.content
1106
- : JSON.stringify(effect.message?.content || '');
1107
- return `provider_effect:message:${content}`;
1108
- }
1109
- if (effect.type === 'notification') {
1110
- return `provider_effect:notification:${effect.notification?.title || ''}:${effect.notification?.body || ''}`;
1111
- }
1112
- return `provider_effect:toast:${effect.toast?.message || ''}`;
1113
- }
1114
-
1115
- private getPersistedEffectContent(effect: { type: string; message?: { content?: unknown }; toast?: { message?: string }; notification?: { title?: string; body?: string; bubbleContent?: unknown } }): string | null {
1116
- if (effect.type === 'message') {
1117
- return typeof effect.message?.content === 'string'
1118
- ? effect.message.content
1119
- : JSON.stringify(effect.message?.content || '');
1120
- }
1121
- if (effect.type === 'toast') {
1122
- return effect.toast?.message || null;
1123
- }
1124
- if (effect.type === 'notification') {
1125
- if (typeof effect.notification?.bubbleContent === 'string') return effect.notification.bubbleContent;
1126
- if (typeof effect.notification?.title === 'string' && effect.notification.title.trim()) {
1127
- return `${effect.notification.title}\n${effect.notification.body || ''}`.trim();
1128
- }
1129
- return effect.notification?.body || null;
1130
- }
1131
- return null;
1132
- }
1133
-
1134
3051
  // ─── Adapter access (backward compat) ──────────────────
1135
3052
 
1136
3053
  getAdapter(): ProviderCliAdapter {
@@ -1151,6 +3068,118 @@ export class CliProviderInstance implements ProviderInstance {
1151
3068
  return false;
1152
3069
  }
1153
3070
 
3071
+ /** @see ProviderInstance.noteManualInteraction */
3072
+ noteManualInteraction(now = Date.now(), opts?: { passive?: boolean }): void {
3073
+ // P1b (#137 secondary): a DELEGATED worker session must not treat a
3074
+ // passive dashboard view (foreground tab selection / panel open) as
3075
+ // manual attendance. A coordinator merely peeking at a worker's panel
3076
+ // would otherwise suppress that worker's delegated auto-approve for the
3077
+ // whole 60s window. Only explicit input/intervention (controlbar,
3078
+ // resolve_action, pty_input) attends a worker. Non-worker (foreground)
3079
+ // sessions keep noting on passive views so a user foregrounding their own
3080
+ // session still holds auto-approve to act on the modal themselves.
3081
+ if (opts?.passive && this.isMeshWorkerSession()) return;
3082
+ this.manualAttendance.note(now);
3083
+ }
3084
+
3085
+ /**
3086
+ * Whether auto-approve should be treated as active *right now* for display
3087
+ * and firing decisions: the configured intent AND the user is not currently
3088
+ * attending this session by hand. When a human is attending, auto-approve is
3089
+ * held so the modal stays visible and they can drive it via the controlbar.
3090
+ * Provider-agnostic — the attendance signal is the command set, never any
3091
+ * CLI-specific modal text.
3092
+ */
3093
+ private autoApproveEffectivelyActive(status: string | undefined, now = Date.now()): boolean {
3094
+ return status === 'waiting_approval'
3095
+ && this.shouldAutoApprove()
3096
+ && !this.manualAttendance.isAttended(now);
3097
+ }
3098
+
3099
+ // STATUS-MISMATCH: true once the current auto-approve episode has been masking
3100
+ // waiting_approval behind `generating` for longer than AUTO_APPROVE_MASK_STALL_MS without
3101
+ // resolving (the settle gate never fired). When stalled, the surface mask must be dropped
3102
+ // so read_chat / mesh_status / the dashboard see the real waiting_approval + modal (and a
3103
+ // coordinator can mesh_approve it). autoApproveMaskSince is maintained by
3104
+ // maybeAutoApproveStatus (driven by getState + the recheck timer during a waiting episode);
3105
+ // this read is side-effect-free so getStatusMetadata can consult it too.
3106
+ private autoApproveMaskStalled(now = Date.now()): boolean {
3107
+ return this.autoApproveMaskSince > 0
3108
+ && now - this.autoApproveMaskSince > CliProviderInstance.AUTO_APPROVE_MASK_STALL_MS;
3109
+ }
3110
+
3111
+ /**
3112
+ * NOTIF-APPROVAL-MASKED (Q1b): surface a delegated worker's STALLED auto-approve modal
3113
+ * to the mesh COORDINATOR, decoupled from the dashboard visible-status mask.
3114
+ *
3115
+ * When auto-approve is configured but the episode never settles (modal parse miss / the
3116
+ * settle gate never satisfied), getState()/detectStatusTransition() fold the raw
3117
+ * `waiting_approval` into `generating` to suppress dashboard flicker — so
3118
+ * detectStatusTransition()'s `waiting_approval` arm never runs and NO agent:waiting_approval
3119
+ * event is emitted. The coordinator's real-time approval-nudge delivery then has no input and
3120
+ * the worker's stuck modal is never surfaced (the live ~25s stall). The dashboard mask is
3121
+ * intentional and stays; this emits the coordinator nudge exactly ONCE, gated on the SAME
3122
+ * raw-waiting_approval + mask-stalled signal resolveModalParkStatus() distinguishes, the
3123
+ * instant the mask-stall threshold trips (the same moment getState un-folds the mask).
3124
+ *
3125
+ * Only delegated worker sessions qualify: a foreground session has no coordinator to notify,
3126
+ * and its own dashboard mask already reveals the modal on stall. A normally-resolving
3127
+ * auto-approve never reaches AUTO_APPROVE_MASK_STALL_MS, so it emits nothing here; and if a
3128
+ * masked approval clears just as this fires, rc.455's isApprovalNudgeResolved stale-drop
3129
+ * discards the nudge coordinator-side without noise. Dedup is per-episode (keyed on the
3130
+ * mask-clock value) so a modal that flaps between parsed/unparsed states is announced once.
3131
+ */
3132
+ private maybeEmitStalledApprovalNudge(adapterStatus: any, now: number): void {
3133
+ if (!this.isMeshWorkerSession()) return;
3134
+ if (adapterStatus?.status !== 'waiting_approval') return;
3135
+ if (!this.autoApproveMaskStalled(now)) return;
3136
+ // AUTOAPPROVE-FLAP-RECUR (Fix C, redesigned): the mask-stall bound tripped.
3137
+ // If auto-approve is genuinely about to fire on its own, defer to that fire —
3138
+ // the nudge would race a resolveModal landing milliseconds later, producing
3139
+ // the coordinator flap this fix targets.
3140
+ //
3141
+ // The ORIGINAL guard deferred on `pendingAutoApprovalSince && buttons > 0`
3142
+ // alone. That is FALSE-POSITIVE for a FLAPPING modal: a modal whose identity
3143
+ // changes every frame (message streaming) keeps pendingAutoApprovalSince
3144
+ // nonzero (it is re-stamped to `now` on every signature change) and keeps
3145
+ // buttons present, yet its settle clock is wiped back to ~0 each frame and
3146
+ // NEVER reaches SETTLE_MS — so auto-approve can never fire and this is exactly
3147
+ // the stuck episode the coordinator MUST be paged about. The old guard
3148
+ // silenced it permanently (the live rc.466 regression).
3149
+ //
3150
+ // Discriminator: a settle is genuinely PROGRESSING only if THIS frame's modal
3151
+ // carries the SAME identity the settle clock is already accruing against
3152
+ // (pendingAutoApprovalSignature). A stable modal keeps its signature across
3153
+ // frames → the clock climbs → resolveModal is imminent → defer. A flapping
3154
+ // modal presents a DIFFERENT signature this frame (or none — a non-concrete /
3155
+ // picker / never-captured modal) → the clock is about to reset (or never
3156
+ // engaged) → do NOT defer, page the coordinator. This is evaluated for the
3157
+ // CURRENT frame (not a stale prior-frame value), so a stable modal polled only
3158
+ // twice — start, then past the stall bound — is still correctly deferred.
3159
+ const currentSignature = this.approvableModalSignature(adapterStatus.activeModal);
3160
+ const settleProgressing = !!currentSignature
3161
+ && this.pendingAutoApprovalSince > 0
3162
+ && currentSignature === this.pendingAutoApprovalSignature;
3163
+ if (settleProgressing) return;
3164
+ // Exactly once per stalled episode (autoApproveMaskSince uniquely identifies it).
3165
+ if (this.stalledApprovalNudgeEpisode === this.autoApproveMaskSince) return;
3166
+ this.stalledApprovalNudgeEpisode = this.autoApproveMaskSince;
3167
+ const modal = adapterStatus.activeModal;
3168
+ const dirName = workingDirBasename(this.workingDir);
3169
+ const chatTitle = `${this.provider.name} · ${dirName}`;
3170
+ this.appendRuntimeSystemMessage(
3171
+ formatApprovalRequestMessage(modal?.message, modal?.buttons),
3172
+ `approval_request:${now}`,
3173
+ now,
3174
+ );
3175
+ this.pushEvent({
3176
+ event: 'agent:waiting_approval', chatTitle, timestamp: now,
3177
+ modalMessage: modal?.message,
3178
+ modalButtons: modal?.buttons,
3179
+ });
3180
+ LOG.info('CLI', `[${this.type}] stalled auto-approve nudge → coordinator (masked ${Math.round((now - this.autoApproveMaskSince) / 1000)}s)`);
3181
+ }
3182
+
1154
3183
  private recordAutoApproval(modalMessage?: string, buttonLabel?: string, now = Date.now()): void {
1155
3184
  this.appendRuntimeSystemMessage(
1156
3185
  formatAutoApprovalMessage(modalMessage, buttonLabel),
@@ -1170,12 +3199,6 @@ export class CliProviderInstance implements ProviderInstance {
1170
3199
  );
1171
3200
  }
1172
3201
 
1173
- private formatMarkerTimestamp(timestamp: number): string {
1174
- const date = new Date(timestamp);
1175
- const pad = (value: number) => String(value).padStart(2, '0');
1176
- return `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())} ${pad(date.getHours())}:${pad(date.getMinutes())}:${pad(date.getSeconds())}`;
1177
- }
1178
-
1179
3202
  private maybeAppendRuntimeRecoveryMessage(runtime: PtyRuntimeMetadata | null): void {
1180
3203
  if (!runtime?.restoredFromStorage || !runtime.runtimeId) return;
1181
3204
 
@@ -1238,7 +3261,7 @@ export class CliProviderInstance implements ProviderInstance {
1238
3261
  receivedAt: normalizedMessage.receivedAt || normalizedMessage.timestamp,
1239
3262
  historyDedupKey: dedupKey,
1240
3263
  }],
1241
- this.adapter.getScriptParsedStatus?.()?.title || this.workingDir.split('/').filter(Boolean).pop() || 'session',
3264
+ this.adapter.getScriptParsedStatus?.()?.title || workingDirBasename(this.workingDir),
1242
3265
  this.instanceId,
1243
3266
  this.providerSessionId,
1244
3267
  );
@@ -1246,102 +3269,46 @@ export class CliProviderInstance implements ProviderInstance {
1246
3269
  }
1247
3270
 
1248
3271
  mergeRuntimeChatMessages(parsedMessages: ChatMessage[]): ChatMessage[] {
1249
- return this.mergeConversationMessages(parsedMessages);
3272
+ return mergeConversationMessages(this.runtimeMessages, parsedMessages);
1250
3273
  }
1251
3274
 
1252
- private mergeConversationMessages(parsedMessages: any[]): ChatMessage[] {
1253
- if (this.runtimeMessages.length === 0) return normalizeChatMessages(parsedMessages);
1254
-
1255
- type MergeEntry = { message: ChatMessage; index: number; source: 'parsed' | 'runtime'; runtimeKey?: string };
1256
- const parsedEntries: MergeEntry[] = parsedMessages.map((message, index) => ({
1257
- message,
1258
- index,
1259
- source: 'parsed',
1260
- }));
1261
- const runtimeEntries: MergeEntry[] = this.runtimeMessages.map((entry, index) => ({
1262
- message: entry.message,
1263
- index: parsedMessages.length + index,
1264
- source: 'runtime',
1265
- runtimeKey: entry.key,
1266
- }));
1267
- const getTime = (message: ChatMessage): number => {
1268
- const value = typeof message.receivedAt === 'number'
1269
- ? message.receivedAt
1270
- : typeof message.timestamp === 'number'
1271
- ? message.timestamp
1272
- : 0;
1273
- return Number.isFinite(value) && value > 0 ? value : 0;
1274
- };
1275
-
1276
- const getRole = (message: ChatMessage): string => typeof message.role === 'string'
1277
- ? message.role.trim().toLowerCase()
1278
- : '';
1279
- const isRuntimeOverlay = (entry: MergeEntry): boolean => {
1280
- if (entry.source !== 'runtime') return false;
1281
- const key = typeof entry.runtimeKey === 'string' ? entry.runtimeKey.trim().toLowerCase() : '';
1282
- if (key.startsWith('auto_approval:')) return true;
1283
- return !isUserFacingChatMessage(entry.message);
1284
- };
1285
- const shouldKeepParsedBeforeUntimedRuntime = (message: ChatMessage): boolean => {
1286
- const role = getRole(message);
1287
- return role === 'user' || role === 'human';
1288
- };
1289
- const shouldKeepParsedAfterUntimedRuntime = (message: ChatMessage): boolean => {
1290
- const role = getRole(message);
1291
- if (role !== 'assistant') return false;
1292
- const kind = resolveChatMessageKind(message);
1293
- return kind === 'standard' || kind === 'terminal';
1294
- };
1295
-
1296
- return normalizeChatMessages([...parsedEntries, ...runtimeEntries]
1297
- .sort((a, b) => {
1298
- const aTime = getTime(a.message);
1299
- const bTime = getTime(b.message);
1300
- if (aTime && bTime && aTime !== bTime) return aTime - bTime;
1301
- if (a.source !== b.source && aTime !== bTime) {
1302
- const parsedEntry = a.source === 'parsed' ? a : b.source === 'parsed' ? b : null;
1303
- const runtimeEntry = a.source === 'runtime' ? a : b.source === 'runtime' ? b : null;
1304
- if (parsedEntry && runtimeEntry && isRuntimeOverlay(runtimeEntry) && getTime(parsedEntry.message) === 0 && getTime(runtimeEntry.message) > 0) {
1305
- if (shouldKeepParsedBeforeUntimedRuntime(parsedEntry.message)) {
1306
- return a.source === 'parsed' ? -1 : 1;
1307
- }
1308
- if (shouldKeepParsedAfterUntimedRuntime(parsedEntry.message)) {
1309
- return a.source === 'parsed' ? 1 : -1;
1310
- }
1311
- }
1312
- }
1313
- // Many provider-owned CLI transcripts (including Hermes CLI in debug bundles)
1314
- // do not carry timestamps on parsed messages. In that case there is no safe
1315
- // clock basis for interleaving timestamped runtime/system messages into the
1316
- // provider transcript. Keep user prompts before runtime overlays, but do not
1317
- // let timed runtime/system/tool/internal overlays become the final chat turns
1318
- // after an untimed parsed assistant transcript.
1319
- return a.index - b.index;
1320
- })
1321
- .map((entry) => entry.message));
1322
- }
1323
-
1324
- private formatApprovalRequestMessage(modalMessage?: string, buttons?: string[]): string {
1325
- const lines = ['Approval requested'];
1326
- const cleanMessage = String(modalMessage || '').trim();
1327
- if (cleanMessage) lines.push(cleanMessage);
1328
- const labels = (buttons || []).map((button) => String(button || '').trim()).filter(Boolean);
1329
- if (labels.length > 0) {
1330
- lines.push(labels.map((label) => `[${label}]`).join(' '));
1331
- }
1332
- return lines.join('\n');
1333
- }
1334
-
1335
- private promoteProviderSessionId(sessionId: string): void {
3275
+ private promoteProviderSessionId(sessionId: string, opts: { authoritative?: boolean } = {}): void {
1336
3276
  const nextSessionId = String(sessionId || '').trim();
1337
3277
  if (!nextSessionId || nextSessionId === this.providerSessionId) return;
1338
3278
 
3279
+ // Sticky binding: once this instance is bound to a provider session,
3280
+ // an *observed* id (one discovered from a status parse or the native
3281
+ // history reader) must NOT hijack the live binding. hermes ≥0.14
3282
+ // spawns a fresh `sessions` row per internal sub-session, so a
3283
+ // newest-wins native read surfaces a different id mid-turn on every
3284
+ // poll; accepting it would re-bind the instance, re-hydrate unbounded
3285
+ // history (daemon saturation) and reset completion detection so the
3286
+ // turn never finalizes. Only an *authoritative* change — the first
3287
+ // bind (no id yet) or an explicit provider `new_session`/resume — may
3288
+ // replace an existing binding. Legitimate resume/new-session paths
3289
+ // pass authoritative:true and are unaffected.
3290
+ if (this.providerSessionId && !opts.authoritative) {
3291
+ LOG.debug('CLI', `[${this.type}] ignoring non-authoritative session id ${nextSessionId} (bound to ${this.providerSessionId})`);
3292
+ return;
3293
+ }
3294
+
1339
3295
  const previousHistorySessionId = this.providerSessionId || this.instanceId;
1340
3296
  const previousProviderSessionId = this.providerSessionId;
1341
3297
  this.providerSessionId = nextSessionId;
3298
+ // Conversation-binding lock (antigravity): the moment this session is
3299
+ // authoritatively bound to a conversation uuid, claim it so a concurrent
3300
+ // sibling session's newest-on-disk discovery can never resolve to the
3301
+ // same .db (RCA: two antigravity sessions ~94ms apart shared one store
3302
+ // and cross-routed completions). Released on dispose().
3303
+ if (this.type === 'antigravity-cli') {
3304
+ const owner = this.antigravityClaimOwner();
3305
+ if (owner) claimAntigravityConversation(nextSessionId, owner);
3306
+ }
1342
3307
  this.historyWriter.promoteHistorySession(this.type, previousHistorySessionId, nextSessionId);
1343
3308
  this.historyWriter.writeSessionStart(this.type, nextSessionId, this.workingDir, this.instanceId);
1344
- this.restorePersistedHistoryFromCurrentSession();
3309
+ if (this.shouldHydrateExistingProviderHistory()) {
3310
+ this.restorePersistedHistoryFromCurrentSession();
3311
+ }
1345
3312
  this.adapter.updateRuntimeMeta({ providerSessionId: nextSessionId });
1346
3313
  this.onProviderSessionResolved?.({
1347
3314
  instanceId: this.instanceId,
@@ -1354,13 +3321,39 @@ export class CliProviderInstance implements ProviderInstance {
1354
3321
  LOG.info('CLI', `[${this.type}] discovered provider session id: ${nextSessionId}`);
1355
3322
  }
1356
3323
 
1357
- private syncCanonicalSavedHistoryIfNeeded(): boolean {
3324
+ private shouldHydrateExistingProviderHistory(): boolean {
3325
+ return this.launchMode === 'resume' || this.launchMode === 'manual';
3326
+ }
3327
+
3328
+ private shouldSuppressFreshLaunchStartupReplay(parsedMessages: unknown[], parsedStatus: any, adapterStatus: any, parsedProviderSessionId = ''): boolean {
3329
+ if (this.launchMode !== 'new') return false;
3330
+ if (this.providerSessionId) return false;
3331
+ if (!Array.isArray(parsedMessages) || parsedMessages.length === 0) return false;
3332
+ if (!isIdleStatus(adapterStatus?.status) || !isIdleStatus(parsedStatus?.status)) return false;
3333
+ if (parsedProviderSessionId) return true;
3334
+
3335
+ const newestMessageAt = parsedMessages.reduce<number>((newest, message) => Math.max(newest, getMessageTime(message)), 0);
3336
+
3337
+ // Untimestamped idle parser output during a fresh launch is usually the
3338
+ // provider's last workspace transcript before a new turn exists.
3339
+ return newestMessageAt === 0;
3340
+ }
3341
+
3342
+ private syncCanonicalSavedHistoryIfNeeded(options: { full?: boolean } = {}): boolean {
1358
3343
  if (!this.providerSessionId) return false;
1359
- const canonicalHistory = this.provider.canonicalHistory;
3344
+ const canonicalHistory = this.provider.nativeHistory;
1360
3345
  if (!canonicalHistory) return false;
1361
3346
 
3347
+ // Per-status-report hydration reads only a bounded tail (snapshot needs at
3348
+ // most the newest 60). The once-per-resume restore path passes full:true
3349
+ // because seedSessionHistory needs the COMPLETE transcript to seed dedup
3350
+ // state. The read-cache key encodes the window so the bounded and full
3351
+ // reads don't share/clobber each other's 2s cache entry.
3352
+ const limit = options.full ? Number.MAX_SAFE_INTEGER : STATUS_HYDRATION_TAIL_LIMIT;
3353
+ const windowTag = options.full ? 'full' : `tail:${STATUS_HYDRATION_TAIL_LIMIT}`;
3354
+
1362
3355
  if (isNativeSourceCanonicalHistory(canonicalHistory)) {
1363
- const cacheKey = [this.type, this.providerSessionId, this.workingDir].join('\0');
3356
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, windowTag].join('\0');
1364
3357
  const now = Date.now();
1365
3358
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1366
3359
  return true;
@@ -1373,7 +3366,7 @@ export class CliProviderInstance implements ProviderInstance {
1373
3366
  historySessionId: this.providerSessionId,
1374
3367
  workspace: this.workingDir,
1375
3368
  offset: 0,
1376
- limit: Number.MAX_SAFE_INTEGER,
3369
+ limit,
1377
3370
  historyBehavior: this.provider.historyBehavior,
1378
3371
  scripts: this.provider.scripts as any,
1379
3372
  });
@@ -1390,7 +3383,7 @@ export class CliProviderInstance implements ProviderInstance {
1390
3383
  }
1391
3384
 
1392
3385
  try {
1393
- const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror'].join('\0');
3386
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror', windowTag].join('\0');
1394
3387
  const now = Date.now();
1395
3388
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1396
3389
  return true;
@@ -1401,7 +3394,14 @@ export class CliProviderInstance implements ProviderInstance {
1401
3394
  if (!materializeProviderNativeHistory(this.type, canonicalHistory, this.providerSessionId, this.workingDir, this.provider.scripts as any)) {
1402
3395
  return false;
1403
3396
  }
1404
- const restoredHistory = readChatHistory(this.type, 0, Number.MAX_SAFE_INTEGER, this.providerSessionId, 0, this.provider.historyBehavior);
3397
+ // Bounded by default: the per-status-report path only needs the newest
3398
+ // STATUS_HYDRATION_TAIL_LIMIT messages because the snapshot caps
3399
+ // activeChat.messages to the last 60 (status/normalize.ts) and loads
3400
+ // the rest lazily via read_chat on subscribe. The once-per-resume
3401
+ // restore path passes full:true so seedSessionHistory still sees the
3402
+ // COMPLETE transcript for prefix-dedup seeding. readChatHistory serves
3403
+ // a bounded limit as an O(tail) read.
3404
+ const restoredHistory = readChatHistory(this.type, 0, limit, this.providerSessionId, 0, this.provider.historyBehavior);
1405
3405
  this.lastPersistedHistoryMessages = restoredHistory.messages.map((message) => ({
1406
3406
  role: message.role,
1407
3407
  content: message.content,
@@ -1417,10 +3417,13 @@ export class CliProviderInstance implements ProviderInstance {
1417
3417
 
1418
3418
  private restorePersistedHistoryFromCurrentSession(): void {
1419
3419
  if (!this.providerSessionId) return;
1420
- this.syncCanonicalSavedHistoryIfNeeded();
1421
- const restoredHistory = isNativeSourceCanonicalHistory(this.provider.canonicalHistory)
3420
+ // Restore is the once-per-resume seeding path: it needs the COMPLETE
3421
+ // transcript so seedSessionHistory can prime dedup state. Pass full so the
3422
+ // hydration read is unbounded here (and only here).
3423
+ this.syncCanonicalSavedHistoryIfNeeded({ full: true });
3424
+ const restoredHistory = isNativeSourceCanonicalHistory(this.provider.nativeHistory)
1422
3425
  ? readProviderChatHistory(this.type, {
1423
- canonicalHistory: this.provider.canonicalHistory,
3426
+ canonicalHistory: this.provider.nativeHistory,
1424
3427
  historySessionId: this.providerSessionId,
1425
3428
  workspace: this.workingDir,
1426
3429
  offset: 0,