@adhdev/daemon-core 0.9.82-rc.453 → 0.9.82-rc.454

package/dist/mesh/mesh-work-queue.d.ts

@@ -324,10 +324,28 @@ export declare function updateSessionTaskStatus(meshId: string, sessionId: strin
  * Used by the completion event path to decide whether to wake the queue.
  */
 export declare function hasPendingDependents(meshId: string, taskId: string): boolean;
+/**
+ * M1: THE single dependency-gate predicate. A task is claimable from a
+ * dependency standpoint iff it carries no system block (`blockedReason`) AND
+ * every id in `dependsOn` has reached 'completed'.
+ *
+ * DEPENDSON-GATE-SYMMETRY: every scheduler surface that decides whether a
+ * pending task may run MUST route through this one predicate — the queue claim
+ * (claimNextQueueTask), the auto-launch candidate filter
+ * (maybeAutoLaunchOneQueueSession), and the cloud eager P2P push
+ * (enqueue-and-push). If any surface computes dependency readiness on its own,
+ * the gate goes asymmetric and a task blocked from the pull path can still be
+ * eager-pushed straight to an idle session, silently bypassing its
+ * prerequisites. The semantics here (all deps completed && !blocked) are the
+ * invariant — do not fork them.
+ */
+export declare function taskDependenciesSatisfied(entry: Pick<MeshWorkQueueEntry, 'dependsOn' | 'blockedReason'>, statusById: Map<string, MeshTaskStatus | string>): boolean;
 /**
  * M1-4: view-time dependency state for a task — unmet dependency ids and
  * whether the task is currently claimable from a dependency standpoint.
- * Not stored (truth stays in task statuses).
+ * Not stored (truth stays in task statuses). The `dependenciesSatisfied` field
+ * is derived from {@link taskDependenciesSatisfied} so the view and the
+ * scheduler gates can never disagree.
  */
 export declare function describeTaskDependencyState(entry: Pick<MeshWorkQueueEntry, 'dependsOn' | 'blockedReason'>, statusById: Map<string, MeshTaskStatus | string>): {
     waitingOn: string[];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adhdev/daemon-core",
-  "version": "0.9.82-rc.453",
+  "version": "0.9.82-rc.454",
   "description": "ADHDev daemon core — CDP, IDE detection, providers, command execution",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -46,8 +46,8 @@
   "author": "vilmire",
   "license": "AGPL-3.0-or-later",
   "dependencies": {
-    "@adhdev/mesh-shared": "0.9.82-rc.453",
-    "@adhdev/session-host-core": "0.9.82-rc.453",
+    "@adhdev/mesh-shared": "0.9.82-rc.454",
+    "@adhdev/session-host-core": "0.9.82-rc.454",
     "@agentclientprotocol/sdk": "^0.16.1",
     "ajv": "^8.20.0",
     "ajv-formats": "^3.0.1",

package/src/index.ts

@@ -270,7 +270,7 @@ export { buildMeshLedgerReconciliationEvidence, buildMeshLedgerReplicaEvidence }
 export type { AnyLedgerSlice, MeshLedgerReconciliationEvidence, MeshLedgerReplicaEvidence, MeshLedgerReplicaStatus } from './mesh/mesh-ledger-reconciliation.js';
 
 // ── Mesh Work Queue (GUPP) ──
-export { enqueueTask, recordDirectDispatchTask, getQueue, claimNextTask, updateTaskStatus, updateSessionTaskStatus, cancelTask, requeueTask, getMeshQueueStats, getMeshQueueRevision, normalizeMeshTaskMode, validateMeshTaskModeRequest, isTaskReadonly, buildMeshNodeCapabilityTags, nodeSatisfiesRequiredTags, normalizeMeshCapabilityTags, resolveConvergeRequiredTags, insertDirectDispatch, getActiveDirectDispatches, updateDirectDispatchStatus, cleanupTerminalDirectDispatches, markStaleDirectDispatches, deleteDirectDispatchesByTaskId, recordMeshToolCall, assertNoDependencyCycle, hasPendingDependents, describeTaskDependencyState } from './mesh/mesh-work-queue.js';
+export { enqueueTask, recordDirectDispatchTask, getQueue, claimNextTask, updateTaskStatus, updateSessionTaskStatus, cancelTask, requeueTask, getMeshQueueStats, getMeshQueueRevision, normalizeMeshTaskMode, validateMeshTaskModeRequest, isTaskReadonly, buildMeshNodeCapabilityTags, nodeSatisfiesRequiredTags, normalizeMeshCapabilityTags, resolveConvergeRequiredTags, insertDirectDispatch, getActiveDirectDispatches, updateDirectDispatchStatus, cleanupTerminalDirectDispatches, markStaleDirectDispatches, deleteDirectDispatchesByTaskId, recordMeshToolCall, assertNoDependencyCycle, hasPendingDependents, describeTaskDependencyState, taskDependenciesSatisfied } from './mesh/mesh-work-queue.js';
 export type { MeshWorkQueueEntry, MeshTaskStatus, MeshTaskMode, MeshWorkQueueStats, MeshQueueMutationOptions, MeshTaskModeValidationResult, DirectDispatchRecord, MeshToolCallRateResult } from './mesh/mesh-work-queue.js';
 export { buildCompactStaleDirectWorkSummary, buildMeshActiveWork, buildMeshActiveWorkSummary, classifyStaleDirectForPrune, pruneStaleDirectDispatches, PRUNABLE_ORPHAN_STALE_REASONS } from './mesh/mesh-active-work.js';
 export type { StaleDirectPruneClassification, StaleDirectPruneResult, PruneStaleDirectDispatchesOptions } from './mesh/mesh-active-work.js';

package/src/mesh/mesh-queue-assignment.ts

@@ -6,7 +6,7 @@ import { getMesh } from '../config/mesh-config.js';
 import { detectCLI } from '../detection/cli-detector.js';
 import { LOG } from '../logging/logger.js';
 import { appendLedgerEntry } from './mesh-ledger.js';
-import { buildMeshNodeCapabilityTags, nodeSatisfiesRequiredTags, claimNextTask, updateTaskStatus, getQueue, recordTaskAutoLaunch, getActiveDirectDispatches, isTaskReadonly } from './mesh-work-queue.js';
+import { buildMeshNodeCapabilityTags, nodeSatisfiesRequiredTags, claimNextTask, updateTaskStatus, getQueue, recordTaskAutoLaunch, getActiveDirectDispatches, isTaskReadonly, taskDependenciesSatisfied } from './mesh-work-queue.js';
 import type { MeshWorkQueueEntry } from './mesh-work-queue.js';
 import { fastForwardMeshNode } from './mesh-fast-forward.js';
 import { createSessionDelivery, updateSessionDeliveryStatus } from './mesh-delivery-policy.js';
@@ -1287,6 +1287,10 @@ function readMeshNodeId(node: any): string {
 
 async function maybeAutoLaunchOneQueueSession(components: DaemonComponents, meshId: string, mesh: any): Promise<boolean> {
     const queue = getQueue(meshId);
+    // DEPENDSON-GATE-SYMMETRY: status index over the FULL queue (incl. completed)
+    // so the dependency gate below sees the terminal state of every referenced
+    // dependency, not just the still-active rows.
+    const statusById = new Map(queue.map(task => [task.id, task.status] as const));
     const pending = queue.filter(task => task.status === 'pending');
     if (!pending.length) return false;
 
@@ -1300,6 +1304,16 @@ async function maybeAutoLaunchOneQueueSession(components: DaemonComponents, mesh
     // higher safety cap (default 2× the write cap).
     const maxReadonlyParallelTasks = resolveMaxReadonlyParallelTasks(maxParallelTasks);
     for (const task of pending) {
+        // DEPENDSON-GATE-SYMMETRY: never spawn a session for a task whose
+        // dependsOn set is not all-completed (or that carries a system block). The
+        // launched session would idle→claim and be refused by the SAME predicate in
+        // claimNextQueueTask, producing orphan-session / re-launch churn. Skip it so
+        // a later tick — after the dependency completes — launches it. Tasks with no
+        // dependsOn pass through unchanged (predicate is true).
+        if (!taskDependenciesSatisfied(task, statusById)) {
+            markAutoLaunch(meshId, task.id, { status: 'skipped', reason: 'dependencies_unsatisfied' });
+            continue;
+        }
         const isReadonly = isTaskReadonly(task);
         if (isReadonly) {
             if (activeReadonlyAssignedCount(meshId) >= maxReadonlyParallelTasks) {

package/src/mesh/mesh-runtime-store.ts

@@ -3,7 +3,7 @@ import { dirname, join } from 'path';
 import { LOG } from '../logging/logger.js';
 import { loadBetterSqlite3 } from '../system/load-better-sqlite3.js';
 import { getLedgerDir } from './mesh-ledger.js';
-import { nodeSatisfiesRequiredTags, isTaskReadonly } from './mesh-work-queue.js';
+import { nodeSatisfiesRequiredTags, isTaskReadonly, taskDependenciesSatisfied } from './mesh-work-queue.js';
 import { meshNodeIdMatches, daemonIdsEquivalent, expandDaemonIdForms, sessionIdsEquivalent } from '@adhdev/mesh-shared';
 import type { MeshTaskStatus, MeshWorkQueueEntry } from './mesh-work-queue.js';
 import type BetterSqlite3 from 'better-sqlite3';
@@ -756,11 +756,11 @@ export class MeshRuntimeStore {
                 ).all(meshId, ...depIds) as Array<{ id: string; status: string }>;
                 for (const r of depRows) depStatus.set(r.id, r.status);
             }
-            const dependenciesSatisfied = (candidate: MeshWorkQueueEntry): boolean => {
-                if (candidate.blockedReason) return false;
-                const deps = Array.isArray(candidate.dependsOn) ? candidate.dependsOn : [];
-                return deps.every(depId => depStatus.get(depId) === 'completed');
-            };
+            // DEPENDSON-GATE-SYMMETRY: the claim gate shares the single
+            // taskDependenciesSatisfied predicate with the auto-launch filter and
+            // the cloud eager P2P push, so a task blocked here is blocked there too.
+            const dependenciesSatisfied = (candidate: MeshWorkQueueEntry): boolean =>
+                taskDependenciesSatisfied(candidate, depStatus);
 
             // Per-candidate node-conflict gate: write tasks require an idle node; read-only
             // tasks bypass the node-busy check so N read-only diagnoses can run on one node

package/src/mesh/mesh-work-queue.ts

@@ -1276,10 +1276,36 @@ export function hasPendingDependents(meshId: string, taskId: string): boolean {
         .some(entry => Array.isArray(entry.dependsOn) && entry.dependsOn.includes(taskId));
 }
 
+/**
+ * M1: THE single dependency-gate predicate. A task is claimable from a
+ * dependency standpoint iff it carries no system block (`blockedReason`) AND
+ * every id in `dependsOn` has reached 'completed'.
+ *
+ * DEPENDSON-GATE-SYMMETRY: every scheduler surface that decides whether a
+ * pending task may run MUST route through this one predicate — the queue claim
+ * (claimNextQueueTask), the auto-launch candidate filter
+ * (maybeAutoLaunchOneQueueSession), and the cloud eager P2P push
+ * (enqueue-and-push). If any surface computes dependency readiness on its own,
+ * the gate goes asymmetric and a task blocked from the pull path can still be
+ * eager-pushed straight to an idle session, silently bypassing its
+ * prerequisites. The semantics here (all deps completed && !blocked) are the
+ * invariant — do not fork them.
+ */
+export function taskDependenciesSatisfied(
+    entry: Pick<MeshWorkQueueEntry, 'dependsOn' | 'blockedReason'>,
+    statusById: Map<string, MeshTaskStatus | string>,
+): boolean {
+    if (entry.blockedReason) return false;
+    const deps = Array.isArray(entry.dependsOn) ? entry.dependsOn : [];
+    return deps.every(depId => statusById.get(depId) === 'completed');
+}
+
 /**
  * M1-4: view-time dependency state for a task — unmet dependency ids and
  * whether the task is currently claimable from a dependency standpoint.
- * Not stored (truth stays in task statuses).
+ * Not stored (truth stays in task statuses). The `dependenciesSatisfied` field
+ * is derived from {@link taskDependenciesSatisfied} so the view and the
+ * scheduler gates can never disagree.
  */
 export function describeTaskDependencyState(
     entry: Pick<MeshWorkQueueEntry, 'dependsOn' | 'blockedReason'>,
@@ -1289,7 +1315,7 @@ export function describeTaskDependencyState(
     const waitingOn = deps.filter(depId => statusById.get(depId) !== 'completed');
     return {
         waitingOn,
-        dependenciesSatisfied: waitingOn.length === 0 && !entry.blockedReason,
+        dependenciesSatisfied: taskDependenciesSatisfied(entry, statusById),
     };
 }