@adhdev/daemon-core 0.9.82-rc.45 → 0.9.82-rc.451

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (429) hide show
  1. package/dist/boot/daemon-lifecycle.d.ts +9 -0
  2. package/dist/boot/process-hardening.d.ts +50 -0
  3. package/dist/build-info.d.ts +37 -0
  4. package/dist/chat/source-machine.d.ts +166 -0
  5. package/dist/chat/source-resolver.d.ts +104 -0
  6. package/dist/chat/subscription-updates.d.ts +1 -0
  7. package/dist/cli-adapter-types.d.ts +68 -2
  8. package/dist/cli-adapters/cli-script-runner.d.ts +117 -0
  9. package/dist/cli-adapters/cli-state-engine.d.ts +200 -0
  10. package/dist/cli-adapters/provider-cli-adapter.d.ts +126 -64
  11. package/dist/cli-adapters/provider-cli-parse.d.ts +5 -0
  12. package/dist/cli-adapters/provider-cli-runtime.d.ts +34 -0
  13. package/dist/cli-adapters/provider-cli-shared.d.ts +74 -0
  14. package/dist/cli-adapters/pty-write-chunking.d.ts +34 -0
  15. package/dist/cli-adapters/raw-terminal-io.d.ts +37 -0
  16. package/dist/cli-adapters/resolve-executable.d.ts +69 -0
  17. package/dist/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +6 -3
  18. package/dist/cli-adapters/terminal-backends/types.d.ts +10 -2
  19. package/dist/cli-adapters/terminal-screen.d.ts +4 -11
  20. package/dist/commands/chat-commands-debug-bundle.d.ts +14 -0
  21. package/dist/commands/chat-commands-read.d.ts +7 -0
  22. package/dist/commands/chat-commands-scope.d.ts +39 -0
  23. package/dist/commands/chat-commands-shared.d.ts +33 -0
  24. package/dist/commands/chat-commands-write.d.ts +14 -0
  25. package/dist/commands/chat-commands.d.ts +10 -23
  26. package/dist/commands/cli-manager.d.ts +25 -1
  27. package/dist/commands/handler.d.ts +125 -0
  28. package/dist/commands/high-family/index.d.ts +3 -0
  29. package/dist/commands/high-family/mesh-coordinator-launch.d.ts +2 -0
  30. package/dist/commands/high-family/mesh-events.d.ts +2 -0
  31. package/dist/commands/high-family/mesh-status.d.ts +2 -0
  32. package/dist/commands/high-family/types.d.ts +64 -0
  33. package/dist/commands/low-family/coordinator-prompt.d.ts +9 -0
  34. package/dist/commands/low-family/daemon-lifecycle.d.ts +2 -0
  35. package/dist/commands/low-family/diagnostics.d.ts +2 -0
  36. package/dist/commands/low-family/index.d.ts +3 -0
  37. package/dist/commands/low-family/mesh-ledger.d.ts +10 -0
  38. package/dist/commands/low-family/mesh-node-logs.d.ts +2 -0
  39. package/dist/commands/low-family/notification.d.ts +2 -0
  40. package/dist/commands/low-family/refine-config.d.ts +2 -0
  41. package/dist/commands/low-family/session-host.d.ts +2 -0
  42. package/dist/commands/low-family/spec-providerdev.d.ts +11 -0
  43. package/dist/commands/low-family/status-meta.d.ts +2 -0
  44. package/dist/commands/low-family/types.d.ts +33 -0
  45. package/dist/commands/med-family/cli-agent.d.ts +2 -0
  46. package/dist/commands/med-family/fast-forward.d.ts +2 -0
  47. package/dist/commands/med-family/ide.d.ts +10 -0
  48. package/dist/commands/med-family/index.d.ts +3 -0
  49. package/dist/commands/med-family/mesh-crud.d.ts +29 -0
  50. package/dist/commands/med-family/mesh-host-pairing.d.ts +2 -0
  51. package/dist/commands/med-family/mesh-queue.d.ts +2 -0
  52. package/dist/commands/med-family/mesh-restart.d.ts +2 -0
  53. package/dist/commands/med-family/types.d.ts +152 -0
  54. package/dist/commands/mesh-coordinator.d.ts +85 -1
  55. package/dist/commands/router.d.ts +279 -2
  56. package/dist/commands/upgrade-helper.d.ts +41 -1
  57. package/dist/config/chat-history.d.ts +9 -0
  58. package/dist/config/config.d.ts +5 -0
  59. package/dist/config/mesh-config.d.ts +129 -1
  60. package/dist/config/mesh-json-config.d.ts +199 -0
  61. package/dist/config/repo-settings.d.ts +77 -0
  62. package/dist/daemon/dev-server.d.ts +0 -2
  63. package/dist/detection/ide-detector.d.ts +13 -0
  64. package/dist/detection/win32-ide-version.d.ts +37 -0
  65. package/dist/git/change-impact-config.d.ts +159 -0
  66. package/dist/git/git-commands.d.ts +12 -1
  67. package/dist/git/git-diff.d.ts +6 -0
  68. package/dist/git/git-executor.d.ts +11 -0
  69. package/dist/git/git-status.d.ts +57 -0
  70. package/dist/git/git-types.d.ts +2 -50
  71. package/dist/git/git-worktree.d.ts +71 -1
  72. package/dist/git/index.d.ts +3 -1
  73. package/dist/index.d.ts +66 -14
  74. package/dist/index.js +49753 -18414
  75. package/dist/index.js.map +1 -1
  76. package/dist/index.mjs +49614 -18438
  77. package/dist/index.mjs.map +1 -1
  78. package/dist/installer.d.ts +1 -4
  79. package/dist/ipc/local-ipc-server.d.ts +91 -0
  80. package/dist/launch.d.ts +1 -1
  81. package/dist/logging/async-batch-writer.d.ts +10 -0
  82. package/dist/logging/log-redactor.d.ts +24 -0
  83. package/dist/logging/log-tail-reader.d.ts +81 -0
  84. package/dist/logging/logger.d.ts +1 -1
  85. package/dist/mesh/contracts.d.ts +164 -0
  86. package/dist/mesh/coordinator-prompt.d.ts +89 -0
  87. package/dist/mesh/coordinator-registry.d.ts +59 -0
  88. package/dist/mesh/mesh-active-work.d.ts +174 -0
  89. package/dist/mesh/mesh-clone-grace.d.ts +8 -0
  90. package/dist/mesh/mesh-coordinator-config.d.ts +21 -0
  91. package/dist/mesh/mesh-delivery-policy.d.ts +131 -0
  92. package/dist/mesh/mesh-event-classify.d.ts +5 -0
  93. package/dist/mesh/mesh-event-forwarding.d.ts +41 -0
  94. package/dist/mesh/mesh-event-trace.d.ts +21 -0
  95. package/dist/mesh/mesh-events-coordinator.d.ts +4 -0
  96. package/dist/mesh/mesh-events-pending.d.ts +69 -0
  97. package/dist/mesh/mesh-events-stale.d.ts +61 -0
  98. package/dist/mesh/mesh-events-utils.d.ts +75 -0
  99. package/dist/mesh/mesh-events.d.ts +6 -49
  100. package/dist/mesh/mesh-fast-forward.d.ts +81 -0
  101. package/dist/mesh/mesh-host-ownership.d.ts +29 -0
  102. package/dist/mesh/mesh-init.d.ts +128 -0
  103. package/dist/mesh/mesh-ledger-reconciliation.d.ts +23 -4
  104. package/dist/mesh/mesh-ledger.d.ts +115 -1
  105. package/dist/mesh/mesh-magi-status.d.ts +63 -0
  106. package/dist/mesh/mesh-missions.d.ts +189 -0
  107. package/dist/mesh/mesh-node-identity.d.ts +306 -0
  108. package/dist/mesh/mesh-queue-assignment.d.ts +113 -0
  109. package/dist/mesh/mesh-reconcile-loop.d.ts +79 -0
  110. package/dist/mesh/mesh-refine-batch.d.ts +68 -0
  111. package/dist/mesh/mesh-refine-gates.d.ts +428 -0
  112. package/dist/mesh/mesh-refine-status.d.ts +62 -0
  113. package/dist/mesh/mesh-review-inbox.d.ts +90 -0
  114. package/dist/mesh/mesh-routing.d.ts +70 -0
  115. package/dist/mesh/mesh-runtime-store.d.ts +450 -0
  116. package/dist/mesh/mesh-scheduling-runtime.d.ts +78 -0
  117. package/dist/mesh/mesh-task-inflight.d.ts +46 -0
  118. package/dist/mesh/mesh-task-stats.d.ts +49 -0
  119. package/dist/mesh/mesh-unresolved-forward-outbox.d.ts +30 -0
  120. package/dist/mesh/mesh-warmup-deadline.d.ts +68 -0
  121. package/dist/mesh/mesh-work-queue.d.ts +300 -5
  122. package/dist/mesh/preview-freshness.d.ts +18 -0
  123. package/dist/mesh/refine-config.d.ts +216 -0
  124. package/dist/mesh/worktree-bootstrap-config.d.ts +145 -0
  125. package/dist/providers/acp-provider-instance.d.ts +5 -0
  126. package/dist/providers/approval-utils.d.ts +20 -0
  127. package/dist/providers/chat-message-normalization.d.ts +32 -1
  128. package/dist/providers/cli-provider-instance.d.ts +254 -3
  129. package/dist/providers/contracts.d.ts +149 -6
  130. package/dist/providers/external-sources.d.ts +71 -0
  131. package/dist/providers/manual-attendance.d.ts +63 -0
  132. package/dist/providers/native-history/antigravity-cli-transcript.d.ts +126 -0
  133. package/dist/providers/native-history/claude-cli-transcript.d.ts +70 -0
  134. package/dist/providers/native-history/codex-cli-transcript.d.ts +73 -0
  135. package/dist/providers/native-history/constants.d.ts +12 -0
  136. package/dist/providers/native-history/dispatcher.d.ts +27 -0
  137. package/dist/providers/native-history/hermes-cli-transcript.d.ts +30 -0
  138. package/dist/providers/native-history/index.d.ts +13 -0
  139. package/dist/providers/provider-instance-manager.d.ts +29 -0
  140. package/dist/providers/provider-instance.d.ts +23 -1
  141. package/dist/providers/provider-loader.d.ts +26 -4
  142. package/dist/providers/provider-trust.d.ts +31 -0
  143. package/dist/providers/read-chat-contract.d.ts +29 -0
  144. package/dist/providers/sdk/v1/builders/acp/detect-status.d.ts +68 -0
  145. package/dist/providers/sdk/v1/builders/cli/detect-status.d.ts +86 -0
  146. package/dist/providers/sdk/v1/builders/cli/parse-approval-squash.d.ts +59 -0
  147. package/dist/providers/sdk/v1/builders/cli/parse-approval.d.ts +65 -0
  148. package/dist/providers/sdk/v1/builders/cli/parse-session.d.ts +91 -0
  149. package/dist/providers/sdk/v1/builders/cli/visible-region.d.ts +42 -0
  150. package/dist/providers/sdk/v1/fixture-tooling/format.d.ts +126 -0
  151. package/dist/providers/sdk/v1/fixture-tooling/index.d.ts +8 -0
  152. package/dist/providers/sdk/v1/fixture-tooling/replay.d.ts +38 -0
  153. package/dist/providers/sdk/v1/index.d.ts +30 -0
  154. package/dist/providers/sdk/v1/sandbox/README-design.d.ts +193 -0
  155. package/dist/providers/sdk/v1/sandbox/require-whitelist.d.ts +74 -0
  156. package/dist/providers/sdk/v1/sandbox/script-runner.d.ts +98 -0
  157. package/dist/providers/sdk/v1/types/cli/index.d.ts +277 -0
  158. package/dist/providers/sdk/v1/types/common/index.d.ts +203 -0
  159. package/dist/providers/sdk/v1/validators/index.d.ts +5 -0
  160. package/dist/providers/sdk/v1/validators/manifest.d.ts +40 -0
  161. package/dist/providers/sdk/v1/validators/taint.d.ts +52 -0
  162. package/dist/providers/spec/adapter.d.ts +98 -0
  163. package/dist/providers/spec/cli-adapter.d.ts +223 -0
  164. package/dist/providers/spec/evaluator.d.ts +45 -0
  165. package/dist/providers/spec/fsm-driver.d.ts +444 -0
  166. package/dist/providers/spec/fsm-evaluator.d.ts +93 -0
  167. package/dist/providers/spec/fsm-loader.d.ts +14 -0
  168. package/dist/providers/spec/fsm-types.d.ts +202 -0
  169. package/dist/providers/spec/native-history-executor.d.ts +41 -0
  170. package/dist/providers/spec/pre-launch-trust.d.ts +16 -0
  171. package/dist/providers/spec/route.d.ts +4 -0
  172. package/dist/providers/spec/types.d.ts +222 -0
  173. package/dist/providers/status-monitor.d.ts +7 -7
  174. package/dist/providers/transcript-v2.d.ts +176 -0
  175. package/dist/providers/types/interactive-prompt.d.ts +84 -0
  176. package/dist/providers/working-dir.d.ts +17 -0
  177. package/dist/repo-mesh-types.d.ts +519 -13
  178. package/dist/runtime-defaults.d.ts +2 -0
  179. package/dist/session-host/managed-host.d.ts +64 -0
  180. package/dist/session-host/runtime-surface.d.ts +10 -16
  181. package/dist/sessions/registry.d.ts +6 -0
  182. package/dist/shared-types-extra.d.ts +2 -4
  183. package/dist/shared-types.d.ts +86 -55
  184. package/dist/status/normalize.d.ts +1 -1
  185. package/dist/status/normalize.js +1 -0
  186. package/dist/status/normalize.js.map +1 -1
  187. package/dist/status/normalize.mjs +1 -0
  188. package/dist/status/normalize.mjs.map +1 -1
  189. package/dist/status/reporter.d.ts +2 -0
  190. package/dist/status/snapshot.d.ts +26 -0
  191. package/dist/system/hash.d.ts +8 -0
  192. package/dist/system/load-better-sqlite3.d.ts +21 -0
  193. package/dist/types.d.ts +5 -0
  194. package/package.json +7 -3
  195. package/src/agent-stream/poller.ts +2 -3
  196. package/src/agent-stream/provider-adapter.ts +1 -1
  197. package/src/boot/daemon-lifecycle.ts +63 -12
  198. package/src/boot/process-hardening.ts +89 -0
  199. package/src/build-info.ts +73 -0
  200. package/src/chat/source-machine.ts +534 -0
  201. package/src/chat/source-resolver.ts +0 -0
  202. package/src/chat/subscription-updates.ts +20 -1
  203. package/src/cli-adapter-types.d.ts +3 -1
  204. package/src/cli-adapter-types.ts +68 -2
  205. package/src/cli-adapters/cli-script-runner.ts +421 -0
  206. package/src/cli-adapters/cli-state-engine.ts +1246 -0
  207. package/src/cli-adapters/provider-cli-adapter.d.ts +1 -1
  208. package/src/cli-adapters/provider-cli-adapter.ts +914 -1144
  209. package/src/cli-adapters/provider-cli-parse.d.ts +2 -0
  210. package/src/cli-adapters/provider-cli-parse.ts +19 -0
  211. package/src/cli-adapters/provider-cli-runtime.ts +56 -7
  212. package/src/cli-adapters/provider-cli-shared.d.ts +4 -0
  213. package/src/cli-adapters/provider-cli-shared.ts +121 -11
  214. package/src/cli-adapters/pty-transport.ts +2 -1
  215. package/src/cli-adapters/pty-write-chunking.ts +106 -0
  216. package/src/cli-adapters/raw-terminal-io.ts +252 -0
  217. package/src/cli-adapters/resolve-executable.ts +204 -0
  218. package/src/cli-adapters/session-host-transport.ts +2 -1
  219. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.ts +63 -29
  220. package/src/cli-adapters/terminal-backends/types.ts +10 -3
  221. package/src/cli-adapters/terminal-screen.ts +16 -81
  222. package/src/commands/WINDOWS-UPGRADE-LOCK-FAILURE.md +198 -0
  223. package/src/commands/chat-commands-debug-bundle.ts +398 -0
  224. package/src/commands/chat-commands-read.ts +2488 -0
  225. package/src/commands/chat-commands-scope.ts +54 -0
  226. package/src/commands/chat-commands-shared.ts +114 -0
  227. package/src/commands/chat-commands-write.ts +891 -0
  228. package/src/commands/chat-commands.ts +19 -1841
  229. package/src/commands/cli-manager.ts +596 -27
  230. package/src/commands/handler.ts +841 -2
  231. package/src/commands/high-family/index.ts +28 -0
  232. package/src/commands/high-family/mesh-coordinator-launch.ts +680 -0
  233. package/src/commands/high-family/mesh-events.ts +89 -0
  234. package/src/commands/high-family/mesh-status.ts +822 -0
  235. package/src/commands/high-family/types.ts +80 -0
  236. package/src/commands/low-family/coordinator-prompt.ts +72 -0
  237. package/src/commands/low-family/daemon-lifecycle.ts +107 -0
  238. package/src/commands/low-family/diagnostics.ts +57 -0
  239. package/src/commands/low-family/index.ts +37 -0
  240. package/src/commands/low-family/mesh-ledger.ts +62 -0
  241. package/src/commands/low-family/mesh-node-logs.ts +87 -0
  242. package/src/commands/low-family/notification.ts +116 -0
  243. package/src/commands/low-family/refine-config.ts +106 -0
  244. package/src/commands/low-family/session-host.ts +274 -0
  245. package/src/commands/low-family/spec-providerdev.ts +217 -0
  246. package/src/commands/low-family/status-meta.ts +112 -0
  247. package/src/commands/low-family/types.ts +39 -0
  248. package/src/commands/med-family/cli-agent.ts +238 -0
  249. package/src/commands/med-family/fast-forward.ts +230 -0
  250. package/src/commands/med-family/ide.ts +163 -0
  251. package/src/commands/med-family/index.ts +37 -0
  252. package/src/commands/med-family/mesh-crud.ts +1253 -0
  253. package/src/commands/med-family/mesh-host-pairing.ts +234 -0
  254. package/src/commands/med-family/mesh-queue.ts +167 -0
  255. package/src/commands/med-family/mesh-restart.ts +92 -0
  256. package/src/commands/med-family/types.ts +153 -0
  257. package/src/commands/mesh-coordinator.ts +334 -124
  258. package/src/commands/router.ts +2893 -3536
  259. package/src/commands/stream-commands.ts +8 -0
  260. package/src/commands/upgrade-helper.ts +310 -45
  261. package/src/config/chat-history.ts +493 -24
  262. package/src/config/config.ts +12 -0
  263. package/src/config/mesh-config.ts +619 -23
  264. package/src/config/mesh-json-config.ts +376 -0
  265. package/src/config/recent-activity.ts +8 -2
  266. package/src/config/repo-settings.ts +111 -0
  267. package/src/daemon/dev-auto-implement.ts +3 -2
  268. package/src/daemon/dev-cli-debug.ts +10 -1
  269. package/src/daemon/dev-server.ts +0 -541
  270. package/src/detection/cli-detector.ts +28 -9
  271. package/src/detection/ide-detector.ts +55 -16
  272. package/src/detection/win32-ide-version.ts +106 -0
  273. package/src/git/change-impact-config.ts +354 -0
  274. package/src/git/git-commands.ts +78 -15
  275. package/src/git/git-diff.ts +81 -11
  276. package/src/git/git-executor.ts +12 -0
  277. package/src/git/git-status.ts +767 -48
  278. package/src/git/git-types.ts +14 -62
  279. package/src/git/git-worktree.ts +261 -4
  280. package/src/git/index.ts +17 -0
  281. package/src/index.ts +198 -12
  282. package/src/installer.d.ts +1 -1
  283. package/src/installer.ts +8 -6
  284. package/src/ipc/local-ipc-server.ts +278 -0
  285. package/src/launch.d.ts +1 -1
  286. package/src/launch.ts +37 -28
  287. package/src/logging/async-batch-writer.ts +55 -0
  288. package/src/logging/command-log.ts +7 -5
  289. package/src/logging/log-redactor.ts +100 -0
  290. package/src/logging/log-tail-reader.ts +341 -0
  291. package/src/logging/logger.ts +14 -7
  292. package/src/mesh/contracts.ts +338 -0
  293. package/src/mesh/coordinator-prompt.ts +416 -34
  294. package/src/mesh/coordinator-registry.ts +121 -0
  295. package/src/mesh/mesh-active-work.ts +645 -0
  296. package/src/mesh/mesh-clone-grace.ts +68 -0
  297. package/src/mesh/mesh-coordinator-config.ts +97 -0
  298. package/src/mesh/mesh-delivery-policy.ts +315 -0
  299. package/src/mesh/mesh-event-classify.ts +51 -0
  300. package/src/mesh/mesh-event-forwarding.ts +1897 -0
  301. package/src/mesh/mesh-event-trace.ts +67 -0
  302. package/src/mesh/mesh-events-coordinator.ts +32 -0
  303. package/src/mesh/mesh-events-pending.ts +656 -0
  304. package/src/mesh/mesh-events-stale.ts +389 -0
  305. package/src/mesh/mesh-events-utils.ts +443 -0
  306. package/src/mesh/mesh-events.ts +33 -1035
  307. package/src/mesh/mesh-fast-forward.ts +843 -0
  308. package/src/mesh/mesh-host-ownership.ts +111 -0
  309. package/src/mesh/mesh-init.ts +350 -0
  310. package/src/mesh/mesh-ledger-reconciliation.ts +12 -7
  311. package/src/mesh/mesh-ledger.ts +841 -102
  312. package/src/mesh/mesh-magi-status.ts +223 -0
  313. package/src/mesh/mesh-missions.ts +449 -0
  314. package/src/mesh/mesh-node-identity.ts +1985 -0
  315. package/src/mesh/mesh-queue-assignment.ts +1924 -0
  316. package/src/mesh/mesh-reconcile-loop.ts +2018 -0
  317. package/src/mesh/mesh-refine-batch.ts +205 -0
  318. package/src/mesh/mesh-refine-gates.ts +1673 -0
  319. package/src/mesh/mesh-refine-status.ts +231 -0
  320. package/src/mesh/mesh-review-inbox.ts +307 -0
  321. package/src/mesh/mesh-routing.ts +291 -0
  322. package/src/mesh/mesh-runtime-store.ts +1853 -0
  323. package/src/mesh/mesh-scheduling-runtime.ts +198 -0
  324. package/src/mesh/mesh-task-inflight.ts +70 -0
  325. package/src/mesh/mesh-task-stats.ts +161 -0
  326. package/src/mesh/mesh-unresolved-forward-outbox.ts +185 -0
  327. package/src/mesh/mesh-warmup-deadline.ts +152 -0
  328. package/src/mesh/mesh-work-queue.ts +1254 -141
  329. package/src/mesh/preview-freshness.ts +118 -0
  330. package/src/mesh/refine-config.ts +423 -0
  331. package/src/mesh/worktree-bootstrap-config.ts +450 -0
  332. package/src/providers/acp-provider-instance.ts +43 -10
  333. package/src/providers/approval-utils.d.ts +5 -0
  334. package/src/providers/approval-utils.ts +57 -5
  335. package/src/providers/chat-message-normalization.ts +92 -4
  336. package/src/providers/cli-provider-instance.ts +2177 -107
  337. package/src/providers/contracts.d.ts +55 -0
  338. package/src/providers/contracts.ts +160 -6
  339. package/src/providers/extension-provider-instance.ts +12 -7
  340. package/src/providers/external-sources.ts +218 -0
  341. package/src/providers/ide-provider-instance.ts +35 -12
  342. package/src/providers/manual-attendance.ts +85 -0
  343. package/src/providers/native-history/antigravity-cli-transcript.ts +1043 -0
  344. package/src/providers/native-history/claude-cli-transcript.ts +396 -0
  345. package/src/providers/native-history/codex-cli-transcript.ts +479 -0
  346. package/src/providers/native-history/constants.ts +19 -0
  347. package/src/providers/native-history/dispatcher.ts +373 -0
  348. package/src/providers/native-history/hermes-cli-transcript.ts +260 -0
  349. package/src/providers/native-history/index.ts +30 -0
  350. package/src/providers/provider-instance-manager.ts +71 -0
  351. package/src/providers/provider-instance.ts +19 -1
  352. package/src/providers/provider-loader.ts +668 -50
  353. package/src/providers/provider-schema.ts +87 -14
  354. package/src/providers/provider-trust.ts +114 -0
  355. package/src/providers/read-chat-contract.ts +76 -16
  356. package/src/providers/sdk/README.md +49 -0
  357. package/src/providers/sdk/v1/builders/acp/detect-status.ts +144 -0
  358. package/src/providers/sdk/v1/builders/cli/detect-status.ts +313 -0
  359. package/src/providers/sdk/v1/builders/cli/parse-approval-squash.ts +158 -0
  360. package/src/providers/sdk/v1/builders/cli/parse-approval.ts +250 -0
  361. package/src/providers/sdk/v1/builders/cli/parse-session.ts +276 -0
  362. package/src/providers/sdk/v1/builders/cli/visible-region.ts +143 -0
  363. package/src/providers/sdk/v1/fixture-tooling/format.ts +130 -0
  364. package/src/providers/sdk/v1/fixture-tooling/index.ts +22 -0
  365. package/src/providers/sdk/v1/fixture-tooling/replay.ts +352 -0
  366. package/src/providers/sdk/v1/index.ts +152 -0
  367. package/src/providers/sdk/v1/sandbox/README-design.ts +195 -0
  368. package/src/providers/sdk/v1/sandbox/require-whitelist.ts +472 -0
  369. package/src/providers/sdk/v1/sandbox/script-runner.ts +150 -0
  370. package/src/providers/sdk/v1/schemas/cli/provider.schema.json +509 -0
  371. package/src/providers/sdk/v1/schemas/primitives/acp-session-protocol-v1.json +131 -0
  372. package/src/providers/sdk/v1/schemas/primitives/native-history-codex-rollout-v1.json +66 -0
  373. package/src/providers/sdk/v1/schemas/primitives/tui-approval-squash-v1.json +91 -0
  374. package/src/providers/sdk/v1/schemas/primitives/tui-assistant-block-v1.json +91 -0
  375. package/src/providers/sdk/v1/schemas/primitives/tui-cue-ordering-v1.json +47 -0
  376. package/src/providers/sdk/v1/schemas/primitives/tui-dispatch-order-v1.json +32 -0
  377. package/src/providers/sdk/v1/schemas/primitives/tui-footer-chrome-v1.json +42 -0
  378. package/src/providers/sdk/v1/schemas/primitives/tui-index-finder-v1.json +27 -0
  379. package/src/providers/sdk/v1/schemas/primitives/tui-modal-v1.json +125 -0
  380. package/src/providers/sdk/v1/schemas/primitives/tui-prompt-marker-v1.json +45 -0
  381. package/src/providers/sdk/v1/schemas/primitives/tui-session-id-extraction-v1.json +46 -0
  382. package/src/providers/sdk/v1/schemas/primitives/tui-settled-prompt-v1.json +71 -0
  383. package/src/providers/sdk/v1/schemas/primitives/tui-spinner-v1.json +83 -0
  384. package/src/providers/sdk/v1/schemas/primitives/tui-transcript-pty-v1.json +83 -0
  385. package/src/providers/sdk/v1/schemas/primitives/tui-visible-region-v1.json +57 -0
  386. package/src/providers/sdk/v1/schemas/primitives/tui-welcome-screen-v1.json +35 -0
  387. package/src/providers/sdk/v1/types/cli/index.ts +365 -0
  388. package/src/providers/sdk/v1/types/common/index.ts +229 -0
  389. package/src/providers/sdk/v1/validators/index.ts +19 -0
  390. package/src/providers/sdk/v1/validators/manifest.ts +110 -0
  391. package/src/providers/sdk/v1/validators/taint.ts +309 -0
  392. package/src/providers/spec/adapter.ts +246 -0
  393. package/src/providers/spec/cli-adapter.ts +1064 -0
  394. package/src/providers/spec/evaluator.ts +407 -0
  395. package/src/providers/spec/fsm-driver.ts +1481 -0
  396. package/src/providers/spec/fsm-evaluator.ts +290 -0
  397. package/src/providers/spec/fsm-loader.ts +128 -0
  398. package/src/providers/spec/fsm-types.ts +301 -0
  399. package/src/providers/spec/native-history-executor.ts +1174 -0
  400. package/src/providers/spec/pre-launch-trust.ts +104 -0
  401. package/src/providers/spec/route.ts +51 -0
  402. package/src/providers/spec/types.ts +262 -0
  403. package/src/providers/status-monitor.d.ts +7 -7
  404. package/src/providers/status-monitor.ts +37 -22
  405. package/src/providers/transcript-v2.ts +567 -0
  406. package/src/providers/types/interactive-prompt.ts +536 -0
  407. package/src/providers/version-archive.ts +64 -24
  408. package/src/providers/working-dir.ts +23 -0
  409. package/src/repo-mesh-types.ts +758 -14
  410. package/src/runtime-defaults.ts +39 -0
  411. package/src/session-host/managed-host.ts +218 -0
  412. package/src/session-host/runtime-surface.ts +20 -80
  413. package/src/sessions/registry.ts +6 -0
  414. package/src/shared-types-extra.ts +2 -4
  415. package/src/shared-types.d.ts +8 -0
  416. package/src/shared-types.ts +124 -55
  417. package/src/status/builders.ts +26 -6
  418. package/src/status/normalize.ts +2 -0
  419. package/src/status/reporter.ts +19 -1
  420. package/src/status/snapshot.ts +95 -26
  421. package/src/system/hash.ts +23 -0
  422. package/src/system/host-memory.ts +29 -12
  423. package/src/system/load-better-sqlite3.ts +68 -0
  424. package/src/types.ts +5 -0
  425. package/dist/cli-adapters/terminal-backends/xterm-backend.d.ts +0 -17
  426. package/dist/mesh/mesh-sync.d.ts +0 -53
  427. package/src/cli-adapters/terminal-backends/ghostty-vt-backend.d.ts +0 -16
  428. package/src/cli-adapters/terminal-backends/xterm-backend.ts +0 -97
  429. package/src/mesh/mesh-sync.ts +0 -111
@@ -13,19 +13,25 @@ import { createRequire } from 'node:module';
13
13
  import { normalizeInputEnvelope, type ProviderModule, flattenContent, type InputEnvelope, type InputPart } from './contracts.js';
14
14
  import { assertProviderSupportsDeclaredInput, getEffectiveMessageInputSupport } from './provider-input-support.js';
15
15
  import type { ProviderInstance, ProviderState, ProviderEvent, InstanceContext, ProviderErrorReason, HotChatSessionState, SessionModalState } from './provider-instance.js';
16
+ import { normalizeInteractivePrompt, normalizeInteractivePromptResponse, type InteractivePrompt } from './types/interactive-prompt.js';
16
17
  import { ProviderCliAdapter } from '../cli-adapters/provider-cli-adapter.js';
18
+ import { shortHash } from '../system/hash.js';
17
19
  import type { CliProviderModule } from '../cli-adapters/provider-cli-adapter.js';
20
+ import { createCliAdapter } from './spec/route.js';
18
21
  import type { PtyRuntimeMetadata, PtyTransportFactory } from '../cli-adapters/pty-transport.js';
19
22
  import { StatusMonitor } from './status-monitor.js';
20
23
  import { ChatHistoryWriter, isNativeSourceCanonicalHistory, materializeProviderNativeHistory, readChatHistory, readProviderChatHistory } from '../config/chat-history.js';
21
24
  import { LOG } from '../logging/logger.js';
25
+ import { traceMeshEventStage, traceMeshEventDrop } from '../mesh/mesh-event-trace.js';
22
26
  import type { ChatMessage } from '../types.js';
23
27
  import { buildPersistedProviderEffectMessage, normalizeProviderEffects } from './control-effects.js';
24
- import { formatAutoApprovalMessage, pickApprovalButton } from './approval-utils.js';
28
+ import { formatAutoApprovalMessage, pickApprovalButton, hasNegativeApprovalOption, looksLikeActiveApprovalPromptText } from './approval-utils.js';
25
29
  import { getCliScriptCommand, parseCliScriptResult } from './cli-script-results.js';
26
30
  import { mergeProviderPatchState, resolveProviderStateSurface } from './provider-patch-state.js';
27
31
  import { normalizeProviderSessionId } from './provider-session-id.js';
28
- import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages } from './chat-message-normalization.js';
32
+ import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind, extractFinalSummaryFromMessages, extractFinalSummaryFromMessagesAfter, readChatMessageTimestampMs } from './chat-message-normalization.js';
33
+ import { workingDirBasename } from './working-dir.js';
34
+ import { ManualAttendanceTracker } from './manual-attendance.js';
29
35
 
30
36
  type PersistableCliHistoryMessage = {
31
37
  role: string;
@@ -35,16 +41,146 @@ type PersistableCliHistoryMessage = {
35
41
  receivedAt?: number;
36
42
  };
37
43
 
44
+ // Status snapshots only ever surface the newest messages: the cloud 'live'
45
+ // profile drops chat messages entirely (loaded lazily via read_chat on
46
+ // subscribe) and the 'full' profile caps activeChat.messages to the last 60
47
+ // (see status/normalize.ts). Unread/completion markers walk only the tail.
48
+ // So getState()'s saved-history hydration — which runs once per resume/manual
49
+ // CLI session on every status report — must read only a bounded tail, not the
50
+ // entire transcript. A full MAX_SAFE_INTEGER read here makes the initial
51
+ // status report O(transcript) × N(sessions), which is the real cold first-
52
+ // connection bottleneck on chat-heavy machines. The window comfortably exceeds
53
+ // the 60-message snapshot cap so dedup/collapse at the boundary stays stable.
54
+ const STATUS_HYDRATION_TAIL_LIMIT = 200;
55
+
38
56
  type CompletedDebouncePending = {
39
57
  chatTitle: string;
40
58
  duration: number;
41
59
  timestamp: number;
42
60
  firstObservedAt: number;
61
+ previousStatus: string;
43
62
  loggedBlockReason?: string;
63
+ loggedTranscriptProbe?: boolean;
64
+ transcriptProbeHistory?: ExternalTranscriptProbe[];
65
+ // ARCH-REFACTOR R1: the taskId of the turn that produced this (debounced) completion,
66
+ // captured SYNCHRONOUSLY at the generating→idle transition. The actual completion
67
+ // event is emitted later by the debounce flush, by which point a follow-up task may
68
+ // already have started its own turn and overwritten engine.currentTurnTaskId — so the
69
+ // id must be snapshotted here, not re-read at flush time.
70
+ taskId?: string;
71
+ // NOTIF Defect-B: the wall-clock start of the turn that produced this (debounced)
72
+ // completion, snapshotted SYNCHRONOUSLY at the generating→idle transition (same
73
+ // reason as taskId — a follow-up turn moves engine.currentTurnStartedAt). The
74
+ // completion's finalSummary is turn-scoped to bubbles at/after this instant so a
75
+ // debounce that flushes before the producing turn's final assistant bubble lands
76
+ // in the native transcript never echoes the PRIOR task's last bubble.
77
+ turnStartedAt?: number;
78
+ // FALSE-IDLE continuity: the busyEpoch value at the instant this pending was armed.
79
+ // The flush guard requires this.busyEpoch to still equal this — proving no busy
80
+ // phase (generating/waiting_approval) opened since arming. A momentary busy→idle
81
+ // blip in an inter-approval valley bumps busyEpoch, so a completion armed before
82
+ // the blip is cancelled at flush instead of emitting a stale mid-turn summary.
83
+ busyEpochAtArm?: number;
84
+ // FALSE-IDLE continuity: the adapter's raw PTY lastOutputAt at arm time. New PTY
85
+ // output after arming means the session was not continuously idle through the
86
+ // settle window (the agent kept printing), so the completion is cancelled.
87
+ lastOutputAtArm?: number;
88
+ };
89
+
90
+ function isIdleStatus(value: unknown): boolean {
91
+ const status = typeof value === 'string' ? value.trim().toLowerCase() : '';
92
+ return !status || status === 'idle' || status === 'ready';
93
+ }
94
+
95
+
96
+ function getMessageTime(message: unknown): number {
97
+ if (!message || typeof message !== 'object') return 0;
98
+ const record = message as { receivedAt?: unknown; timestamp?: unknown };
99
+ const value = Number(record.receivedAt ?? record.timestamp ?? 0);
100
+ return Number.isFinite(value) ? value : 0;
101
+ }
102
+
103
+ type CompletedFinalizationBlock = {
104
+ reason: string;
105
+ terminal?: boolean;
106
+ allowTimeout?: boolean;
107
+ // (SETTLE-VALLEY) When set, suppress the CANON-C decoupled-immediate emit for this
108
+ // missing_final_assistant block and HOLD (retry up to COMPLETED_FINALIZATION_MAX_WAIT_MS)
109
+ // until the native transcript's final assistant turn arrives (block clears → genuine emit)
110
+ // or the worker resumes (resume guard cancels). Set only for the inter-approval idle valley
111
+ // of a native-history mesh worker, where an immediate weak emit would freeze a truncated
112
+ // preamble summary (evidenceLevel=insufficient) into the append-only ledger before the
113
+ // worker's next approval turn resumes. Independent of valley length.
114
+ holdForTranscript?: boolean;
115
+ };
116
+
117
+ type CompletionFinalAssistantEvidence = {
118
+ present: boolean;
119
+ messages: unknown[];
120
+ source: 'parsed' | 'external-native' | 'unavailable';
121
+ };
122
+
123
+ type ExternalTranscriptProbe = {
124
+ readAt: number;
125
+ msgCount: number;
126
+ lastRole: string | null;
127
+ lastKind: string | null;
128
+ contentLen: number;
129
+ sourcePath: string | null;
130
+ sourceMtimeMs: number | null;
131
+ mtimeAgeMs: number | null;
44
132
  };
45
133
 
46
134
  const COMPLETED_FINALIZATION_RETRY_MS = 1000;
47
135
  const COMPLETED_FINALIZATION_MAX_WAIT_MS = 30_000;
136
+ // (FALSEIDLE-BGCHILD-a) Minimum generating→idle settle window for native-history mesh worker
137
+ // sessions. Native-history providers (e.g. claude-cli) normally flush the completion with
138
+ // flushDelay=0 — the transcript is authoritative, so there is no reason to wait. But a worker
139
+ // turn that spawns a BACKGROUND child (e.g. `npm test &`, a backgrounded Bash tool) can paint
140
+ // a burst of child output, fall quiet, and have the screen parser read a PRIOR/intermediate
141
+ // standard assistant as if the turn were done — firing a false idle while the agent is in fact
142
+ // still generating (e.g. mid-commit). With flushDelay=0 there is no window for the resume guard
143
+ // in flushCompletedDebounceIfFinalized (latestVisibleStatus !== 'idle' → cancel) to observe the
144
+ // agent picking the turn back up. A short non-zero settle window restores that resume guard for
145
+ // mesh workers without delaying genuinely-finished turns beyond this bound. Scoped to mesh
146
+ // worker sessions so interactive native-history sessions keep the immediate flush.
147
+ // 4000ms (was 1500): live measurement showed the completion event can fire 1.6–3s
148
+ // BEFORE the worker's final-assistant turn lands in the transcript on a natural
149
+ // generating→idle completion (no approval modal), freezing a prior intermediate
150
+ // bubble as finalSummary (evidenceLevel=insufficient). The 68a3c324 waiting_approval
151
+ // hold only covers the approval-resolved valley; widening this settle window to 4000ms
152
+ // covers that race AND the ~3s waiting_approval valley within the settle bound.
153
+ const NATIVE_HISTORY_MESH_IDLE_SETTLE_MS = 4000;
154
+ // TASKBUBBLE-DUP: window during which an identical user-input ack (same trimmed
155
+ // content on the same instance) is treated as a redelivery of one dispatch and
156
+ // suppressed from the chat transcript. Matches the coordinator-side
157
+ // DUPLICATE_DISPATCH_WINDOW_MS (mesh-tools) so the daemon's bubble-level guard
158
+ // covers the same retry horizon as the MCP-level dispatch dedup.
159
+ const USER_INPUT_ACK_DEDUP_WINDOW_MS = 60_000;
160
+ // GENERATING-BOUNDARY (R4c): window — measured from the startup-grace COLLAPSE moment
161
+ // (startupGraceCollapseAt), not boot — inside which a "first turn that ran+completed
162
+ // without the FSM ever observing a 'generating' frame" is attributed to the startup-grace
163
+ // collapse and synthesized (reason 'startup_grace_idle_turn_collapse').
164
+ // The spec's startup-grace exit is elapsed_ms=8000, so the FSM spends ~8s in 'starting'
165
+ // before collapsing to idle; a turn can be dispatched a few seconds AFTER that collapse
166
+ // (the live R4b miss: collapse at boot+8s, dispatch at boot+12.4s — already past a 12s
167
+ // boot-anchored window before the turn even started). Anchoring on the collapse moment
168
+ // covers dispatch-delay; R4d additionally anchors on the turn-START moment
169
+ // (engine.currentTurnStartedAt) so a non-trivial turn-DURATION cannot push the completion
170
+ // past a now-anchored window (the live rc.405 Probe2 miss). The strong discriminator is
171
+ // generatingStartedAt===0 (generating was never observed) AND a started-but-finished turn
172
+ // — the window only keeps the synthesized reason honest and scopes the synthesis to the
173
+ // boot collapse, so a much-later unobservably-fast turn is not mislabelled a startup collapse.
174
+ const STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS = 12_000;
175
+
176
+ /** Events that signal a dispatched mesh task has reached a terminal state.
177
+ * Detach the mesh assignment after emitting one of these so the worker's
178
+ * next unrelated turn doesn't impersonate another completion. */
179
+ const TERMINAL_MESH_EVENTS = new Set([
180
+ 'agent:generating_completed',
181
+ 'agent:stopped',
182
+ 'agent:ready',
183
+ ]);
48
184
 
49
185
  const IMAGE_MIME_EXTENSIONS: Record<string, string> = {
50
186
  'image/png': '.png',
@@ -120,7 +256,29 @@ function hasNonEmptyCliModalButtons(activeModal: unknown): boolean {
120
256
  }
121
257
 
122
258
  function isCliGeneratingLikeStatus(status: unknown): boolean {
123
- return status === 'generating' || status === 'streaming' || status === 'long_generating' || status === 'starting';
259
+ return status === 'generating' || status === 'streaming' || status === 'no_progress' || status === 'long_generating' || status === 'starting';
260
+ }
261
+
262
+ /**
263
+ * NOTIF Defect-2a: the REPORTED short-generating duration, anchored on the IMMUTABLE turn
264
+ * start. generatingStartedAt is reset to 0 on every mid-turn waiting_approval/idle blip and
265
+ * re-armed on the next →generating, so a long turn that blips would otherwise measure only the
266
+ * final 1.5-2.5s sliver. engine.currentTurnStartedAt (set once at onTurnStarted, surviving
267
+ * mid-turn blips until the next turn starts) is preferred; generatingStartedAt is the fallback
268
+ * for turns that never recorded an engine turn start. Returns 0 when neither anchor is set.
269
+ * Pure / unit-testable.
270
+ */
271
+ export function computeTurnAnchoredDurationMs(
272
+ engineTurnStartedAt: number | undefined,
273
+ generatingStartedAt: number,
274
+ now: number,
275
+ ): { durationMs: number; anchor: 'turn-start' | 'generatingStartedAt' | 'none' } {
276
+ const engineStart = typeof engineTurnStartedAt === 'number' && Number.isFinite(engineTurnStartedAt)
277
+ ? engineTurnStartedAt
278
+ : 0;
279
+ if (engineStart > 0) return { durationMs: now - engineStart, anchor: 'turn-start' };
280
+ if (generatingStartedAt > 0) return { durationMs: now - generatingStartedAt, anchor: 'generatingStartedAt' };
281
+ return { durationMs: 0, anchor: 'none' };
124
282
  }
125
283
 
126
284
  export function buildCliStructuredInputPrompt(
@@ -300,24 +458,140 @@ export class CliProviderInstance implements ProviderInstance {
300
458
  readonly type: string;
301
459
  readonly category = 'cli' as const;
302
460
 
461
+ /**
462
+ * Quiet period an approval modal's signature must be stable before
463
+ * auto-approve sends the approve key. Guards against firing on a prompt
464
+ * that is still streaming into the PTY (the "resolves too fast" symptom):
465
+ * while the modal text/buttons are still changing, every frame yields a
466
+ * new signature and the settle clock restarts. Once the prompt finishes
467
+ * rendering the signature holds and the key is sent after this window.
468
+ * Bounded + small so genuine approvals stay timely. The FSM is already
469
+ * authoritative over the `waiting_approval` state; this only delays the
470
+ * keystroke until the modal *content* has settled.
471
+ */
472
+ private static readonly AUTO_APPROVE_SETTLE_MS = 600;
473
+
474
+ /**
475
+ * Busy-side hysteresis for the settle gate. A momentary `generating` flip
476
+ * while the SAME approval modal's button block is still on screen (its
477
+ * question line scrolled out of the captured frame, only the buttons + a
478
+ * residual `esc to interrupt` spinner remain) briefly reports
479
+ * status!=waiting_approval. Without hysteresis that flip wipes the settle
480
+ * clock, and the modal→generating→modal flap restarts the 600ms window
481
+ * every time so auto-approve never fires. We keep the in-progress settle
482
+ * gate warm across an inactive blip up to this bound; only once the modal
483
+ * has genuinely stayed gone this long (a real resolution → idle) is the
484
+ * gate cleared. Bounded so a genuinely new, later approval still re-settles
485
+ * from scratch rather than firing on a stale timestamp.
486
+ */
487
+ private static readonly AUTO_APPROVE_GATE_HYSTERESIS_MS = 1500;
488
+
489
+ /**
490
+ * STATUS-MISMATCH: upper bound on how long the auto-approve→`generating` SURFACE
491
+ * mask may hide a worker's `waiting_approval` (status + activeModal) before we give
492
+ * up and surface the real prompt. The mask exists because auto-approve is expected
493
+ * to resolve the modal momentarily; but if it STALLS without ever calling
494
+ * resolveModal — the modal signature never settles for AUTO_APPROVE_SETTLE_MS (a
495
+ * perpetually-flapping/streaming prompt), no concrete modal is ever captured, or the
496
+ * modal is a picker/non-affirmative we never auto-pick — the mask would persist
497
+ * forever and read_chat / mesh_status / the dashboard would NEVER see the pending
498
+ * approval (the coordinator cannot mesh_approve what it cannot see). Once an episode
499
+ * exceeds this bound we stop masking. Generously larger than
500
+ * AUTO_APPROVE_SETTLE_MS (600) + AUTO_APPROVE_GATE_HYSTERESIS_MS (1500) so a
501
+ * legitimately slow-settling / blip-flapping prompt is never unmasked early; a
502
+ * genuine never-resolving stall surfaces within this window. The settle gate keeps
503
+ * running underneath, so a prompt that finally stabilises still auto-approves, and
504
+ * mesh_approve (raw FSM, unmasked) works throughout.
505
+ */
506
+ private static readonly AUTO_APPROVE_MASK_STALL_MS = 4500;
507
+
303
508
  private adapter: ProviderCliAdapter;
304
509
  private context: InstanceContext | null = null;
305
510
  private events: ProviderEvent[] = [];
306
511
  private lastStatus: string = 'starting';
512
+ // Idempotency guard for the queue-claim agent:ready event. agent:ready is the
513
+ // sole signal the mesh coordinator's tryAssignQueueTask waits on to hand a
514
+ // queued task to this worker. It is emitted in two places: the boot-time
515
+ // starting→idle one-shot, and the readySeen re-arm below. This flag makes the
516
+ // event fire AT MOST ONCE per session so a worker is never claimed twice and a
517
+ // queued task is never double-dispatched/double-injected. Whichever path fires
518
+ // first sets it; the other becomes a no-op.
519
+ private agentReadyEmitted = false;
307
520
  private generatingStartedAt: number = 0;
521
+ // FALSE-IDLE continuity epoch: monotonically bumped on EVERY entry into a busy
522
+ // phase (→generating or →waiting_approval). The completedDebouncePending snapshots
523
+ // this value at arm time (busyEpochAtArm); the flush guard requires it UNCHANGED
524
+ // — proving the session did not re-enter a busy phase (a momentary busy→idle blip
525
+ // in an inter-approval valley) between arming the debounce and flushing it. A
526
+ // single point-sample of status at flush time cannot see a generating phase that
527
+ // opened AND closed within the settle window; the epoch can. See
528
+ // flushCompletedDebounceIfFinalized.
529
+ private busyEpoch: number = 0;
530
+ // GENERATING-BOUNDARY (R4b): the per-turn taskId for which a startup-grace
531
+ // started+completed pair was already synthesized. Both fast-collapse callers
532
+ // (starting→idle transition AND the idle-stayed no-status-change poll) route
533
+ // through maybeSynthesizeStartupGraceCollapse; the idle-stayed caller re-polls
534
+ // steadily while the session sits idle, so this guard makes the synthesis fire
535
+ // AT MOST ONCE per collapsed turn.
536
+ private fastCollapseSynthesizedTaskId: string | null = null;
537
+ // GENERATING-BOUNDARY (R4c): the wall-clock moment the FSM's starting→idle
538
+ // startup-grace collapse was observed (set ONCE, on the first starting→idle
539
+ // transition this boot). The idle-stayed collapse window is anchored on THIS,
540
+ // not on instance/boot time (this.startedAt): the FSM spends the full 8s
541
+ // startup-grace sitting in 'starting' before collapsing, and a turn can be
542
+ // dispatched a few seconds AFTER the collapse — measuring the window from boot
543
+ // would have it already closed by the time that turn lands+completes (the live
544
+ // R4b miss: collapse at boot+8s, dispatch at boot+12.4s > the 12s boot window).
545
+ // Anchoring on the collapse moment makes the window cover dispatch-delay+turn.
546
+ private startupGraceCollapseAt: number | null = null;
308
547
  private settings: Record<string, any> = {};
309
548
  private monitor: StatusMonitor;
310
549
  private generatingDebounceTimer: NodeJS.Timeout | null = null;
311
550
  private generatingDebouncePending: { chatTitle: string; timestamp: number } | null = null;
312
- private lastApprovalEventAt = 0;
551
+ private lastApprovalEventFingerprint = '';
313
552
  private autoApproveBusy = false;
314
553
  private autoApproveBusyTimer: NodeJS.Timeout | null = null;
554
+ private lastAutoApprovalSignature = '';
555
+ // Settle gate: the approval modal's signature + the wall-clock when this
556
+ // exact signature was first observed. Auto-approve only fires once the
557
+ // SAME signature has been stable for AUTO_APPROVE_SETTLE_MS, so a prompt
558
+ // still streaming into the PTY (its buttons/message changing frame to
559
+ // frame) keeps resetting the timer and is never approved half-rendered.
560
+ private pendingAutoApprovalSignature = '';
561
+ private pendingAutoApprovalSince = 0;
562
+ private autoApproveSettleTimer: NodeJS.Timeout | null = null;
563
+ // Wall-clock when auto-approve first observed status!=waiting_approval while
564
+ // a settle gate was in progress. Drives AUTO_APPROVE_GATE_HYSTERESIS_MS so a
565
+ // brief generating flip does not immediately wipe the settle clock.
566
+ private autoApproveInactiveSince = 0;
567
+ // STATUS-MISMATCH: wall-clock when the CURRENT auto-approve episode (waiting_approval
568
+ // + shouldAutoApprove) first began wanting to mask. Unlike pendingAutoApprovalSince it
569
+ // is NOT reset when the modal signature changes (a still-streaming/flapping prompt) and
570
+ // survives the same hysteresis blips the settle gate does, so it measures the TRUE age
571
+ // of an unresolved auto-approve. Once it exceeds AUTO_APPROVE_MASK_STALL_MS the surface
572
+ // mask is dropped so the real waiting_approval surfaces. Cleared when the episode ends
573
+ // (modal genuinely gone, manual attendance takes over, or auto-approve fires).
574
+ private autoApproveMaskSince = 0;
575
+ // Provider-common manual-attendance signal: while a human is actively driving
576
+ // this session from the dashboard, auto-approve holds so they can take manual
577
+ // control. Background mesh workers are never attended → delegated auto-approve
578
+ // is unaffected.
579
+ private readonly manualAttendance = new ManualAttendanceTracker();
315
580
  private controlValues: Record<string, string | number | boolean> = {};
316
581
  private summaryMetadata: unknown = undefined;
317
582
  private appliedEffectKeys = new Set<string>();
318
583
  private historyWriter: ChatHistoryWriter;
319
584
  private runtimeMessages: Array<{ key: string; message: ChatMessage }> = [];
320
585
  private lastPersistedHistoryMessages: PersistableCliHistoryMessage[] = [];
586
+ private lastAcknowledgedUserInputAt = 0;
587
+ // TASKBUBBLE-DUP: per-content last-ack timestamps so the same dispatched
588
+ // prompt acked twice in quick succession (the worker buffers the first
589
+ // send during bootstrap/busy, then a redelivery — dispatch-confirm-timeout
590
+ // requeue or a reconcile re-dispatch — fires a SECOND send_chat before the
591
+ // outbound queue drains) collapses to ONE user bubble. Keyed on the trimmed
592
+ // content; an entry older than USER_INPUT_ACK_DEDUP_WINDOW_MS is treated as
593
+ // a fresh, intentional resend and is NOT suppressed.
594
+ private recentUserInputAcks = new Map<string, number>();
321
595
  private lastNativeSourceCanonicalCheckAt = 0;
322
596
  private lastNativeSourceCanonicalCacheKey: string | undefined = undefined;
323
597
  private cachedSqliteDb: {
@@ -330,6 +604,7 @@ export class CliProviderInstance implements ProviderInstance {
330
604
  private suppressIdleHistoryReplay = false;
331
605
  private errorMessage: string | undefined = undefined;
332
606
  private errorReason: ProviderErrorReason | undefined = undefined;
607
+ private activeInteractivePrompt: InteractivePrompt | null = null;
333
608
 
334
609
  private presentationMode: 'terminal' | 'chat';
335
610
  private providerSessionId?: string;
@@ -370,7 +645,10 @@ export class CliProviderInstance implements ProviderInstance {
370
645
  this.providerSessionId = options?.providerSessionId;
371
646
  this.launchMode = options?.launchMode || 'new';
372
647
  this.onProviderSessionResolved = options?.onProviderSessionResolved;
373
- this.adapter = new ProviderCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory);
648
+ this.adapter = createCliAdapter(provider as CliProviderModule, workingDir, cliArgs, options?.extraEnv || {}, transportFactory) as ProviderCliAdapter;
649
+ if (this.providerSessionId) {
650
+ this.adapter.updateRuntimeMeta({ providerSessionId: this.providerSessionId });
651
+ }
374
652
  this.monitor = new StatusMonitor();
375
653
  this.historyWriter = new ChatHistoryWriter();
376
654
  }
@@ -389,8 +667,8 @@ export class CliProviderInstance implements ProviderInstance {
389
667
  this.adapter.updateRuntimeSettings?.(this.settings);
390
668
  this.monitor.updateConfig({
391
669
  approvalAlert: this.settings.approvalAlert !== false,
392
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
393
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
670
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
671
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
394
672
  });
395
673
 
396
674
  // Server connection
@@ -412,7 +690,7 @@ export class CliProviderInstance implements ProviderInstance {
412
690
  await this.adapter.spawn();
413
691
  await this.enforceFreshSessionLaunchIfNeeded();
414
692
  this.maybeAppendRuntimeRecoveryMessage(this.adapter.getRuntimeMetadata());
415
- if (this.providerSessionId) {
693
+ if (this.providerSessionId && this.shouldHydrateExistingProviderHistory()) {
416
694
  this.restorePersistedHistoryFromCurrentSession();
417
695
  }
418
696
  if (this.providerSessionId && this.launchMode === 'resume') {
@@ -486,14 +764,38 @@ export class CliProviderInstance implements ProviderInstance {
486
764
  }
487
765
 
488
766
  getState(): ProviderState {
767
+ // TODO(phase5-sandbox): JS override scripts (detectStatus, parseApproval,
768
+ // parseSession) are currently invoked by CliScriptRunner.invoke() via direct
769
+ // function calls — the scripts run in the daemon process with full Node.js
770
+ // access and no resource limits.
771
+ //
772
+ // When Phase 5 lands, CliScriptRunner should route these calls through a
773
+ // SandboxedScriptRunner (see providers/sdk/v1/sandbox/script-runner.ts) so
774
+ // that each call gets a fresh isolated-vm context with a 50 ms CPU limit and
775
+ // a 32 MB memory cap. The execution path to change is:
776
+ // CliScriptRunner.invoke() → SandboxedScriptRunner.run(scriptSource, context)
777
+ //
778
+ // This getState() call-site is NOT where the change goes — the wiring belongs
779
+ // in cli-script-runner.ts (CliScriptRunner.detectStatus / parseApproval /
780
+ // parseSession), with provider-loader.ts updated to store script source strings
781
+ // alongside the loaded function references for extended-legacy providers.
489
782
  const adapterStatus = this.adapter.getStatus();
783
+ if (Object.prototype.hasOwnProperty.call(adapterStatus, 'activeInteractivePrompt')) {
784
+ this.activeInteractivePrompt = adapterStatus.activeInteractivePrompt ?? null;
785
+ }
490
786
  let parsedStatus: any = null;
491
787
  let parseErrorMessage: string | undefined;
492
788
  if (typeof this.adapter.getScriptParsedStatus === 'function') {
493
789
  try {
494
790
  parsedStatus = this.adapter.getScriptParsedStatus() || null;
495
- this.errorMessage = undefined;
496
- this.errorReason = undefined;
791
+ const parsedErrorMessage = typeof parsedStatus?.errorMessage === 'string' && parsedStatus.errorMessage.trim()
792
+ ? parsedStatus.errorMessage.trim()
793
+ : undefined;
794
+ const parsedErrorReason = typeof parsedStatus?.errorReason === 'string' && parsedStatus.errorReason.trim()
795
+ ? parsedStatus.errorReason.trim() as ProviderErrorReason
796
+ : undefined;
797
+ this.errorMessage = parsedErrorMessage;
798
+ this.errorReason = parsedErrorReason;
497
799
  } catch (error: any) {
498
800
  parseErrorMessage = error?.message || String(error);
499
801
  this.errorMessage = parseErrorMessage;
@@ -503,22 +805,59 @@ export class CliProviderInstance implements ProviderInstance {
503
805
  this.errorMessage = undefined;
504
806
  this.errorReason = undefined;
505
807
  }
506
- const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, Date.now());
507
- const visibleStatus = parseErrorMessage
508
- ? 'error'
509
- : (autoApproveActive ? 'generating' : adapterStatus.status);
510
- const parsedProviderSessionId = normalizeProviderSessionId(
808
+ const adapterProviderSessionId = normalizeProviderSessionId(
511
809
  this.provider,
512
- typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
810
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
513
811
  );
514
- if (parsedProviderSessionId) {
515
- this.promoteProviderSessionId(parsedProviderSessionId);
812
+ const nowMs = Date.now();
813
+ // STATUS-MISMATCH: maybeAutoApproveStatus still runs for its side effects (settle gate,
814
+ // resolveModal fire), but the SURFACE mask is dropped once the episode has stalled past
815
+ // AUTO_APPROVE_MASK_STALL_MS — otherwise a never-settling auto-approve hides the worker's
816
+ // waiting_approval + modal from read_chat/mesh_status/dashboard forever.
817
+ const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, nowMs)
818
+ && !this.autoApproveMaskStalled(nowMs);
819
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
820
+ let visibleStatus = parseErrorMessage || parsedStatus?.status === 'error'
821
+ ? 'error'
822
+ : (autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status);
823
+ // getState() must agree with the status the FSM-driven detectStatusTransition()
824
+ // already committed to lastStatus. The adapter's own status is authoritative; we do
825
+ // not second-guess it with native-transcript shape. Only reconcile a generating-like
826
+ // read down to idle when our own lastStatus has already flipped idle (avoids a
827
+ // perpetual dashboard spinner during the brief window before the next getStatus()).
828
+ if (isCliGeneratingLikeStatus(visibleStatus) && this.lastStatus === 'idle') {
829
+ visibleStatus = 'idle';
516
830
  }
517
831
  const runtime = this.adapter.getRuntimeMetadata();
518
832
  this.maybeAppendRuntimeRecoveryMessage(runtime);
519
833
  let parsedMessages = Array.isArray(parsedStatus?.messages)
520
834
  ? parsedStatus.messages
521
835
  : [];
836
+ const parsedProviderSessionId = normalizeProviderSessionId(
837
+ this.provider,
838
+ typeof parsedStatus?.providerSessionId === 'string' ? parsedStatus.providerSessionId : '',
839
+ );
840
+ const suppressFreshLaunchStartupReplay = this.shouldSuppressFreshLaunchStartupReplay(
841
+ parsedMessages,
842
+ parsedStatus,
843
+ adapterStatus,
844
+ parsedProviderSessionId,
845
+ );
846
+ if (adapterProviderSessionId && !suppressFreshLaunchStartupReplay) {
847
+ this.promoteProviderSessionId(adapterProviderSessionId);
848
+ }
849
+ if (parsedProviderSessionId && !suppressFreshLaunchStartupReplay) {
850
+ this.promoteProviderSessionId(parsedProviderSessionId);
851
+ }
852
+ if (suppressFreshLaunchStartupReplay) {
853
+ parsedMessages = [];
854
+ }
855
+ // Adapter runtime metadata is transport-owned and is not guaranteed to
856
+ // identify this conversation. Spec adapters historically exposed the
857
+ // provider spec id (for example "codex-cli") as runtimeId, which made
858
+ // concurrent sessions share one activeChat identity until their native
859
+ // provider session ids were discovered.
860
+ const activeChatId = this.providerSessionId || this.instanceId;
522
861
  const historyMessageCount = Number.isFinite(parsedStatus?.historyMessageCount)
523
862
  ? Math.max(0, Number(parsedStatus.historyMessageCount))
524
863
  : null;
@@ -528,9 +867,20 @@ export class CliProviderInstance implements ProviderInstance {
528
867
  : [];
529
868
  }
530
869
  const mergedMessages = this.mergeConversationMessages(parsedMessages);
531
- const canonicalBackedHistory = this.syncCanonicalSavedHistoryIfNeeded();
870
+ const canonicalBackedHistory = this.shouldHydrateExistingProviderHistory()
871
+ ? this.syncCanonicalSavedHistoryIfNeeded()
872
+ : false;
873
+ const statusMessages = canonicalBackedHistory && this.lastPersistedHistoryMessages.length > 0
874
+ ? this.lastPersistedHistoryMessages.map((message) => ({
875
+ role: message.role,
876
+ content: message.content,
877
+ kind: message.kind,
878
+ senderName: message.senderName,
879
+ receivedAt: message.receivedAt,
880
+ }))
881
+ : mergedMessages;
532
882
 
533
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
883
+ const dirName = workingDirBasename(this.workingDir);
534
884
  const parsedChatStatus = typeof parsedStatus?.status === 'string' && parsedStatus.status.trim()
535
885
  ? parsedStatus.status.trim()
536
886
  : undefined;
@@ -542,7 +892,7 @@ export class CliProviderInstance implements ProviderInstance {
542
892
  && adapterStatus.status === 'idle'
543
893
  && parsedStatus?.status === 'idle';
544
894
  let messagesToSave = parsedMessages;
545
- if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'long_generating')) {
895
+ if (!suppressStaleParsedBusyStatus && (parsedChatStatus === 'generating' || parsedChatStatus === 'no_progress' || parsedChatStatus === 'long_generating')) {
546
896
  const lastIdx = messagesToSave.length - 1;
547
897
  if (lastIdx >= 0 && messagesToSave[lastIdx]?.role === 'assistant') {
548
898
  messagesToSave = messagesToSave.slice(0, lastIdx);
@@ -572,33 +922,48 @@ export class CliProviderInstance implements ProviderInstance {
572
922
  }
573
923
  }
574
924
 
575
- this.applyProviderResponse(parsedStatus, { phase: 'immediate' });
925
+ this.applyProviderResponse(
926
+ suppressFreshLaunchStartupReplay && parsedStatus && typeof parsedStatus === 'object'
927
+ ? { ...parsedStatus, providerSessionId: undefined }
928
+ : parsedStatus,
929
+ { phase: 'immediate' },
930
+ );
576
931
  const surface = resolveProviderStateSurface({
577
932
  summaryMetadata: this.summaryMetadata as any,
578
933
  controlValues: this.controlValues,
579
934
  });
580
935
  const activeChatStatus = parseErrorMessage
581
936
  ? 'error'
582
- : autoApproveActive && parsedStatus?.status === 'waiting_approval'
937
+ : (autoApproveActive && parsedStatus?.status === 'waiting_approval') || autoApproveHoldIdle
583
938
  ? 'generating'
584
939
  : (adapterStatus.status !== 'idle'
585
940
  ? visibleStatus
586
941
  : (suppressStaleParsedBusyStatus ? visibleStatus : (parsedChatStatus || visibleStatus)));
587
942
 
943
+ // If an AskUserQuestion prompt is awaiting user input, overlay status as
944
+ // waiting_choice. This is distinct from waiting_approval (tool-use consent)
945
+ // — the engine's isWaitingForResponse state is unchanged, so completion
946
+ // tracking continues normally once the user responds.
947
+ const hasInteractivePrompt = !!this.activeInteractivePrompt;
948
+ const finalStatus = hasInteractivePrompt ? 'waiting_choice' : visibleStatus;
949
+ const finalChatStatus = hasInteractivePrompt ? 'waiting_choice' : activeChatStatus;
950
+
588
951
  return {
589
952
  type: this.type,
590
953
  name: this.provider.name,
591
954
  category: 'cli',
592
- status: visibleStatus,
955
+ status: finalStatus,
593
956
  mode: this.presentationMode,
594
957
  activeChat: {
595
- id: `${this.type}_${this.workingDir}`,
958
+ id: activeChatId,
596
959
  title: parsedStatus?.title || dirName,
597
- status: activeChatStatus,
598
- messages: mergedMessages,
599
- activeModal: autoApproveActive ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
960
+ status: finalChatStatus,
961
+ messages: statusMessages,
962
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : (parsedStatus?.activeModal ?? adapterStatus.activeModal),
963
+ activeInteractivePrompt: this.activeInteractivePrompt,
600
964
  inputContent: '',
601
965
  },
966
+ activeInteractivePrompt: this.activeInteractivePrompt,
602
967
  workspace: this.workingDir,
603
968
  instanceId: this.instanceId,
604
969
  providerSessionId: this.providerSessionId,
@@ -638,8 +1003,12 @@ export class CliProviderInstance implements ProviderInstance {
638
1003
 
639
1004
  getHotChatSessionState(): HotChatSessionState {
640
1005
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
641
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
642
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
1006
+ const nowMs = Date.now();
1007
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
1008
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
1009
+ && !this.autoApproveMaskStalled(nowMs);
1010
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
1011
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
643
1012
  const runtime = this.adapter.getRuntimeMetadata();
644
1013
  return {
645
1014
  id: this.instanceId,
@@ -651,36 +1020,274 @@ export class CliProviderInstance implements ProviderInstance {
651
1020
  };
652
1021
  }
653
1022
 
654
- getSessionModalState(): SessionModalState {
655
- const adapterStatus = this.adapter.getStatus({ allowParse: false });
656
- const autoApproveActive = adapterStatus.status === 'waiting_approval' && this.shouldAutoApprove();
657
- const visibleStatus = autoApproveActive ? 'generating' : adapterStatus.status;
658
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
1023
+ getSessionModalState(sessionId?: string): SessionModalState {
1024
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
1025
+ const nowMs = Date.now();
1026
+ // STATUS-MISMATCH: drop the mask once the auto-approve episode has stalled (see getState).
1027
+ const autoApproveActive = this.autoApproveEffectivelyActive(adapterStatus.status, nowMs)
1028
+ && !this.autoApproveMaskStalled(nowMs);
1029
+ const autoApproveHoldIdle = this.autoApproveBusy && adapterStatus.status === 'idle';
1030
+ const visibleStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : adapterStatus.status;
1031
+ const dirName = workingDirBasename(this.workingDir);
659
1032
  return {
660
- id: this.instanceId,
1033
+ // Honor the caller-supplied sessionId — InstanceMgr rejects the
1034
+ // projection when projected.id !== requested sessionId, and
1035
+ // this.instanceId is the manager's internal key, not the public
1036
+ // sessionId the dashboard subscribes by.
1037
+ id: sessionId ?? this.instanceId,
661
1038
  status: visibleStatus,
662
1039
  title: dirName,
663
- activeModal: autoApproveActive ? null : adapterStatus.activeModal,
1040
+ activeModal: (autoApproveActive || autoApproveHoldIdle) ? null : adapterStatus.activeModal,
664
1041
  };
665
1042
  }
666
1043
 
667
1044
  updateSettings(newSettings: Record<string, any>): void {
668
- this.settings = { ...newSettings };
1045
+ // Merge semantics: a key omitted from newSettings preserves its existing
1046
+ // value, a key present in newSettings (even as false) overrides it.
1047
+ //
1048
+ // This is required because updateSettings has two callers with opposite
1049
+ // intent:
1050
+ // 1. Full re-injection — the dashboard toggle path (handleSetProviderSetting
1051
+ // → getSettings → updateInstanceSettings) sends the COMPLETE settings
1052
+ // object, so an explicit autoApprove:false must win.
1053
+ // 2. Partial stamp — the mesh relay-safety stamp (router.ts agent_command,
1054
+ // buildMeshWorkerRelayStamp) sends ONLY {meshNodeFor, meshNodeId,
1055
+ // meshCoordinatorDaemonId, launchedByCoordinator} on every coordinator
1056
+ // re-dispatch. It carries no autoApprove, so a full replacement would
1057
+ // wipe the launch-time autoApprove:true the worker was started with,
1058
+ // silently dropping every later approval to a manual gate until the
1059
+ // machine-page toggle re-injected the full settings.
1060
+ //
1061
+ // A plain merge satisfies both: undefined keys fall through to the existing
1062
+ // value (preserving launch-stamp settings like autoApprove + the mesh routing
1063
+ // keys), explicit keys override. This subsumes the previous mesh-key preserve
1064
+ // list, which only protected the routing keys and not autoApprove.
1065
+ this.settings = { ...this.settings, ...newSettings };
669
1066
  this.adapter.updateRuntimeSettings?.(this.settings);
670
1067
  this.monitor.updateConfig({
671
1068
  approvalAlert: this.settings.approvalAlert !== false,
672
- longGeneratingAlert: this.settings.longGeneratingAlert !== false,
673
- longGeneratingThresholdSec: this.settings.longGeneratingThresholdSec || 180,
1069
+ noProgressAlert: (this.settings.noProgressAlert ?? this.settings.longGeneratingAlert) !== false,
1070
+ noProgressThresholdSec: this.settings.noProgressThresholdSec ?? this.settings.longGeneratingThresholdSec ?? 180,
674
1071
  });
675
1072
  }
676
1073
 
1074
+ /**
1075
+ * Stamp a direct-dispatch mesh assignment on this instance.
1076
+ * setupMeshEventForwarding reads settings.meshNodeFor + meshActiveTaskId to
1077
+ * route generating_completed back to the originating coordinator. Without
1078
+ * this stamp, mesh_send_task --direct targets a plain CLI session whose
1079
+ * completion events silently drop because the forwarder has nothing to
1080
+ * match against.
1081
+ */
1082
+ attachMeshAssignment(assignment: { meshId: string; nodeId?: string; taskId?: string; coordinatorDaemonId?: string; coordinatorSessionId?: string }): void {
1083
+ if (!assignment?.meshId) return;
1084
+ this.settings = {
1085
+ ...this.settings,
1086
+ meshNodeFor: assignment.meshId,
1087
+ // WTCLAIM (A): track the bound node id under BOTH the active marker
1088
+ // (meshNodeId, cleared on detach) and a sticky marker (meshLastNodeId,
1089
+ // preserved across detach). The sticky marker lets a detached but still
1090
+ // coordinator-owned session be re-picked ONLY for the SAME node it served
1091
+ // — never auto-adopted for a sibling node (e.g. a cloned worktree) that
1092
+ // shares this daemon. See isMeshOwnedDelegateSession's post-detach gate.
1093
+ ...(assignment.nodeId ? { meshNodeId: assignment.nodeId, meshLastNodeId: assignment.nodeId } : {}),
1094
+ ...(assignment.taskId ? { meshActiveTaskId: assignment.taskId } : {}),
1095
+ ...(assignment.coordinatorDaemonId ? { meshCoordinatorDaemonId: assignment.coordinatorDaemonId } : {}),
1096
+ // Session-level routing anchor: the originating coordinator session, so this
1097
+ // worker's completion events route back to the exact session that dispatched it.
1098
+ ...(assignment.coordinatorSessionId ? { meshCoordinatorSessionId: assignment.coordinatorSessionId } : {}),
1099
+ };
1100
+ this.adapter.updateRuntimeSettings?.(this.settings);
1101
+ }
1102
+
1103
+ /**
1104
+ * Clear a previously-attached mesh assignment after the task reaches a
1105
+ * terminal state. Leaving meshNodeFor pinned would route this session's
1106
+ * subsequent unrelated turns (e.g. ad-hoc dashboard chats) to the
1107
+ * coordinator as if they were task completions.
1108
+ *
1109
+ * MESHID-DROP-ON-DETACH (Fix C): a coordinator-LAUNCHED worker session
1110
+ * (launchedByCoordinator) holds its mesh membership (meshNodeFor / meshNodeId /
1111
+ * meshCoordinatorDaemonId) at the SESSION level — set once at launch
1112
+ * (mesh_launch_session / queue auto-launch), independent of any single task.
1113
+ * The original detach wiped meshNodeFor + meshNodeId together with the
1114
+ * task-level meshActiveTaskId, so the FIRST task completion stripped the
1115
+ * membership and EVERY subsequent completion forwarded with meshId absent —
1116
+ * resolveWorkerDelegateRouting fell to mesh_unresolved and the coordinator
1117
+ * rejected the forward "meshId required". For a launched member we therefore
1118
+ * clear ONLY the task-level marker (meshActiveTaskId) and preserve the
1119
+ * session-level membership so its next task's completion still resolves.
1120
+ * A task-less ad-hoc turn on a preserved-membership session is NOT misrouted:
1121
+ * its completion carries no taskId and the session holds no active assignment,
1122
+ * so the forwarder's WARMUPGAP guard skips the dispatch-row flip (it only
1123
+ * injects a benign task-less notification). A NON-launched session (a plain CLI
1124
+ * session adopted by mesh_send_task --direct, launchedByCoordinator falsy)
1125
+ * keeps the original full clear so an ad-hoc session is never left pinned.
1126
+ */
1127
+ detachMeshAssignment(): void {
1128
+ if (!this.settings.meshNodeFor && !this.settings.meshActiveTaskId && !this.settings.meshNodeId) return;
1129
+ // Session-level member: keep membership, drop only the task-level marker.
1130
+ if (this.settings.launchedByCoordinator === true) {
1131
+ if (!this.settings.meshActiveTaskId) return;
1132
+ const { meshActiveTaskId, ...rest } = this.settings;
1133
+ void meshActiveTaskId;
1134
+ this.settings = rest;
1135
+ this.adapter.updateRuntimeSettings?.(this.settings);
1136
+ return;
1137
+ }
1138
+ const { meshNodeFor, meshNodeId, meshActiveTaskId, ...rest } = this.settings;
1139
+ void meshNodeFor; void meshActiveTaskId;
1140
+ // WTCLAIM (A): clear the active binding but PRESERVE the last bound node id
1141
+ // (meshLastNodeId) so a later sessionless dispatch can re-adopt this idle
1142
+ // session ONLY for the node it last served. Carry the id being cleared, or
1143
+ // keep an already-present sticky marker if meshNodeId was absent.
1144
+ const lastNodeId = (typeof meshNodeId === 'string' && meshNodeId.trim())
1145
+ ? meshNodeId.trim()
1146
+ : (typeof rest.meshLastNodeId === 'string' && rest.meshLastNodeId.trim() ? rest.meshLastNodeId.trim() : undefined);
1147
+ this.settings = lastNodeId ? { ...rest, meshLastNodeId: lastNodeId } : rest;
1148
+ this.adapter.updateRuntimeSettings?.(this.settings);
1149
+ }
1150
+
1151
+ /**
1152
+ * The resolved modal-park status of this session, or null when it is not
1153
+ * parked on a modal awaiting a human answer. Mirrors the overlay logic in
1154
+ * getState(): an active AskUserQuestion interactive prompt resolves to
1155
+ * waiting_choice; otherwise the adapter's waiting_approval (tool consent)
1156
+ * counts — UNLESS auto-approve will dismiss it, in which case the session is
1157
+ * effectively generating and is NOT modal-parked. This is the single signal
1158
+ * the mesh force-inject guard consults, and the same status string the
1159
+ * reconcile loop reads off get_status_metadata. Lowercase literals only —
1160
+ * the SessionStatus enum is forked across modules and waiting_choice is
1161
+ * absent from some of them.
1162
+ */
1163
+ resolveModalParkStatus(): 'waiting_choice' | 'waiting_approval' | null {
1164
+ if (this.activeInteractivePrompt) return 'waiting_choice';
1165
+ let adapterStatus: { status?: string };
1166
+ try {
1167
+ adapterStatus = this.adapter.getStatus({ allowParse: false });
1168
+ } catch {
1169
+ return null;
1170
+ }
1171
+ // A session whose auto-approve is held by manual attendance IS parked on a
1172
+ // modal awaiting the human — autoApproveEffectivelyActive folds that in, so
1173
+ // the mesh force-inject guard correctly treats it as modal-parked. STATUS-MISMATCH:
1174
+ // a STALLED auto-approve (never resolving) is likewise effectively parked — treat it
1175
+ // as modal-parked so its events are held/surfaced rather than masked behind generating.
1176
+ if (adapterStatus.status === 'waiting_approval'
1177
+ && (!this.autoApproveEffectivelyActive(adapterStatus.status) || this.autoApproveMaskStalled())) {
1178
+ // NOTIF-HELD-DRAIN (Fix 1): an autonomous mesh session (coordinator or worker)
1179
+ // that is actively progressing a turn — a tool call is in flight
1180
+ // (hasAdapterPendingResponse) and NO human is attending it by hand — surfaces a
1181
+ // routine tool-consent `waiting_approval` on EVERY tool call when auto-approve is
1182
+ // off. That transient consent is part of the turn the harness/operator drives to
1183
+ // completion, NOT a session genuinely wedged awaiting a human's modal answer.
1184
+ // Classifying it modal-parked makes findLiveCoordinators hold the mesh's pending
1185
+ // completion events under `modal_parked` across a busy coordinator's whole work
1186
+ // batch, which is the multi-minute notification stall. Treat such a transient
1187
+ // consent as NOT modal-parked so it is held as ordinary "generating" (released on
1188
+ // the next idle) instead. A manually-attended session, a stalled auto-approve, or a
1189
+ // non-progressing session (no turn in flight) still parks — those are the genuine
1190
+ // human-await cases the guard must keep holding.
1191
+ if (this.isTransientToolConsent()) {
1192
+ return null;
1193
+ }
1194
+ return 'waiting_approval';
1195
+ }
1196
+ return null;
1197
+ }
1198
+
1199
+ /**
1200
+ * NOTIF-HELD-DRAIN: true when this `waiting_approval` is a routine, transient tool-consent
1201
+ * of an autonomously-progressing mesh session rather than a genuine human-await modal —
1202
+ * i.e. it is a mesh coordinator/worker session, a turn is actively in flight
1203
+ * (hasAdapterPendingResponse), and no human is attending it by hand. Such a consent is
1204
+ * driven to resolution by the harness/operator as part of the in-flight turn, so holding
1205
+ * the mesh's completion events behind it (modal_parked) is the false-positive that stalls
1206
+ * delivery. Narrow by design: manual attendance or a non-progressing session falls through
1207
+ * to the genuine-modal classification.
1208
+ */
1209
+ private isTransientToolConsent(now = Date.now()): boolean {
1210
+ return this.isAutonomousMeshSession()
1211
+ && this.hasAdapterPendingResponse()
1212
+ && !this.manualAttendance.isAttended(now);
1213
+ }
1214
+
1215
+ /** True when this session is parked on a modal awaiting a human answer. */
1216
+ isModalParked(): boolean {
1217
+ return this.resolveModalParkStatus() !== null;
1218
+ }
1219
+
1220
+ /**
1221
+ * PTY-OVERTRUST-DRAIN (Defect B). The deliverability/drain status the mesh
1222
+ * reconcile loop must consult — the RAW adapter turn-state, with the
1223
+ * auto-approve "hold-idle" visual mask STRIPPED.
1224
+ *
1225
+ * getState().status overlays `autoApproveHoldIdle`/`autoApproveActive` to paint a
1226
+ * genuinely-idle adapter as `generating` (a UI-flicker suppression while an
1227
+ * auto-approve key-press settles — see getState() ~:800). That mask is correct
1228
+ * for the dashboard, but the reconcile loop trusts it as "the coordinator is
1229
+ * busy" and therefore HOLDS a worker's completion under
1230
+ * `generating_no_idle_coordinator` even though the coordinator's PTY is at a real
1231
+ * turn end and would accept the inject as a turn — the completion is stranded.
1232
+ *
1233
+ * This accessor reports the drain truth instead:
1234
+ * - 'modal_parked' — a GENUINE human-await modal (AskUserQuestion / a non-
1235
+ * transient tool-consent). Still excluded from drain (a force-inject here
1236
+ * writes raw keystrokes the modal eats → data corruption). Mirrors
1237
+ * isModalParked(), evaluated first so a parked session never reads idle.
1238
+ * - 'idle' — the RAW adapter is at a turn end (adapter.getStatus(allowParse:false)
1239
+ * === 'idle') and the session is not modal-parked. Drain-eligible REGARDLESS
1240
+ * of the auto-approve mask. This is the case the mask used to hide.
1241
+ * - 'generating' — the raw adapter is genuinely mid-turn. Held (a raw PTY write
1242
+ * into a generating claude-cli is not consumed as a turn → data loss). The
1243
+ * intentional removal of force-inject-into-generating is preserved.
1244
+ * - 'other' — any other raw status (error / starting / waiting_choice handled by
1245
+ * modal-park above). Not a drain target.
1246
+ *
1247
+ * Uses allowParse:false (engine.activeModal only, side-effect-free) so it never
1248
+ * mutates the very auto-approve mask state the diagnostics read.
1249
+ */
1250
+ getDrainStatus(): 'idle' | 'generating' | 'modal_parked' | 'other' {
1251
+ if (this.isModalParked()) return 'modal_parked';
1252
+ let rawStatus: string;
1253
+ try {
1254
+ const raw = this.adapter.getStatus({ allowParse: false })?.status;
1255
+ rawStatus = typeof raw === 'string' ? raw.trim() : '';
1256
+ } catch {
1257
+ return 'other';
1258
+ }
1259
+ if (rawStatus === 'idle') return 'idle';
1260
+ if (isCliGeneratingLikeStatus(rawStatus)) return 'generating';
1261
+ return 'other';
1262
+ }
1263
+
677
1264
  onEvent(event: string, data?: any): void {
678
1265
  if (event === 'send_message') {
679
1266
  const input = normalizeInputEnvelope(data);
680
1267
  assertProviderSupportsDeclaredInput(this.provider, input);
681
1268
  const promptText = buildCliStructuredInputPrompt(input);
682
1269
  if (promptText) {
683
- void this.adapter.sendMessage(promptText).catch((e: any) => {
1270
+ // force:true bypasses the busy/generating send guard so terminal mesh
1271
+ // events (completion/failure/bootstrap) land in a coordinator session that
1272
+ // is itself parked in `generating` while awaiting that very event.
1273
+ // Without it the message is queued and only flushed on the coordinator's
1274
+ // own idle transition — which never happens until it receives the message.
1275
+ const force = data?.force === true;
1276
+ // Modal guard: a force-inject still writes raw keystrokes into the PTY,
1277
+ // bypassing the busy send-guard. If the coordinator is parked on a
1278
+ // harness modal (claude-cli AskUserQuestion → waiting_choice, or a
1279
+ // tool-consent waiting_approval), those keystrokes are consumed by the
1280
+ // modal's key handler and silently select a choice the user never made
1281
+ // (data corruption). Hold the force-inject in that narrow window —
1282
+ // the event stays queued and the reconcile loop redelivers it on the
1283
+ // next tick once the modal is resolved. We ONLY hold for the two modal
1284
+ // states; generating is still force-injected (that is the deadlock the
1285
+ // force path exists to break — see mesh-events-coordinator).
1286
+ if (force && this.isModalParked()) {
1287
+ LOG.info('CLI', `[${this.type}] force send_message held — coordinator parked on modal (${this.resolveModalParkStatus()})`);
1288
+ return;
1289
+ }
1290
+ void this.adapter.sendMessage(promptText, force ? { force: true } : {}).catch((e: any) => {
684
1291
  LOG.warn('CLI', `[${this.type}] send_message failed: ${e?.message || e}`);
685
1292
  });
686
1293
  }
@@ -690,14 +1297,101 @@ export class CliProviderInstance implements ProviderInstance {
690
1297
  void this.adapter.resolveAction(data).catch((e: any) => {
691
1298
  LOG.warn('CLI', `[${this.type}] resolve_action failed: ${e?.message || e}`);
692
1299
  });
1300
+ } else if (event === 'interactive_prompt' && data) {
1301
+ const prompt = normalizeInteractivePrompt(data);
1302
+ if (prompt) {
1303
+ this.activeInteractivePrompt = prompt;
1304
+ this.events.push({
1305
+ event: 'interactive_prompt',
1306
+ timestamp: Date.now(),
1307
+ promptId: prompt.promptId,
1308
+ });
1309
+ }
1310
+ } else if (event === 'interactive_prompt_response' && data) {
1311
+ try {
1312
+ const response = normalizeInteractivePromptResponse(data);
1313
+ if (this.activeInteractivePrompt?.promptId === response.promptId) {
1314
+ this.activeInteractivePrompt = null;
1315
+ }
1316
+ if (typeof this.adapter.setInteractivePromptResponse !== 'function') {
1317
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response ignored: adapter does not support interactive prompts`);
1318
+ return;
1319
+ }
1320
+ void this.adapter.setInteractivePromptResponse(response).catch((e: any) => {
1321
+ LOG.warn('CLI', `[${this.type}] interactive_prompt_response failed: ${e?.message || e}`);
1322
+ });
1323
+ } catch (e: any) {
1324
+ LOG.warn('CLI', `[${this.type}] invalid interactive_prompt_response: ${e?.message || e}`);
1325
+ }
693
1326
  } else if (event === 'provider_state_patch' && data && typeof data === 'object') {
694
1327
  this.applyProviderResponse(data, { phase: 'immediate' });
695
1328
  }
696
1329
  }
697
1330
 
1331
+ recordAcknowledgedUserInput(input: InputEnvelope | string): void {
1332
+ const content = typeof input === 'string'
1333
+ ? input.trim()
1334
+ : buildCliStructuredInputPrompt(input).trim();
1335
+ if (!content) return;
1336
+
1337
+ const receivedAt = Date.now();
1338
+
1339
+ // TASKBUBBLE-DUP: collapse a redelivered dispatch to one bubble. A single
1340
+ // mesh_send_task can reach this instance as TWO send_chat calls when the
1341
+ // first injection is buffered during bootstrap/busy and a retry (dispatch-
1342
+ // confirm-timeout requeue, or a reconcile re-dispatch) fires before the
1343
+ // outbound queue drains. The previous dedupKey hashed receivedAt, so the
1344
+ // two acks produced different keys and BOTH bubbled. Suppress an identical
1345
+ // content ack seen within USER_INPUT_ACK_DEDUP_WINDOW_MS; a later resend of
1346
+ // the same text (beyond the window) is a genuine new turn and still shows.
1347
+ const ackContentKey = shortHash(`${this.instanceId}:${content}`, 24);
1348
+ const lastAckAt = this.recentUserInputAcks.get(ackContentKey);
1349
+ if (lastAckAt !== undefined && receivedAt - lastAckAt <= USER_INPUT_ACK_DEDUP_WINDOW_MS) {
1350
+ // Refresh the timestamp so a steady stream of redeliveries keeps
1351
+ // collapsing, and prune stale entries to bound the map size.
1352
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1353
+ this.pruneRecentUserInputAcks(receivedAt);
1354
+ return;
1355
+ }
1356
+ this.recentUserInputAcks.set(ackContentKey, receivedAt);
1357
+ this.pruneRecentUserInputAcks(receivedAt);
1358
+
1359
+ this.lastAcknowledgedUserInputAt = receivedAt;
1360
+ // The runtimeMessages dedupKey stays per-call unique (includes receivedAt)
1361
+ // so a genuine resend of the same text after the window appends a fresh
1362
+ // bubble; redelivery within the window is already suppressed above.
1363
+ const dedupKey = `user_input_ack:${shortHash(`${this.instanceId}:${content}:${receivedAt}`, 24)}`;
1364
+ this.appendRuntimeMessage(buildChatMessage({
1365
+ role: 'user',
1366
+ senderName: 'User',
1367
+ kind: 'standard',
1368
+ content,
1369
+ receivedAt,
1370
+ timestamp: receivedAt,
1371
+ source: 'runtime_input_ack',
1372
+ meta: {
1373
+ runtimeInputAck: true,
1374
+ provider: this.type,
1375
+ workspace: this.workingDir,
1376
+ },
1377
+ } as ChatMessage), dedupKey);
1378
+ }
1379
+
1380
+ /** Drop user-input ack entries older than the dedup window so the map can't grow unbounded. */
1381
+ private pruneRecentUserInputAcks(now: number): void {
1382
+ if (this.recentUserInputAcks.size <= 1) return;
1383
+ for (const [key, at] of this.recentUserInputAcks) {
1384
+ if (now - at > USER_INPUT_ACK_DEDUP_WINDOW_MS) this.recentUserInputAcks.delete(key);
1385
+ }
1386
+ }
1387
+
698
1388
  dispose(): void {
699
1389
  this.adapter.shutdown();
700
1390
  this.monitor.reset();
1391
+ // Cancel any armed auto-approve timers so a pending settle re-check
1392
+ // can't fire resolveModal/detectStatusTransition against a dead adapter.
1393
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
1394
+ if (this.autoApproveBusyTimer) { clearTimeout(this.autoApproveBusyTimer); this.autoApproveBusyTimer = null; }
701
1395
  this.appliedEffectKeys.clear();
702
1396
  try { this.cachedSqliteDb?.close(); } catch { /* noop */ }
703
1397
  this.cachedSqliteDb = null;
@@ -706,6 +1400,7 @@ export class CliProviderInstance implements ProviderInstance {
706
1400
 
707
1401
  private completedDebounceTimer: NodeJS.Timeout | null = null;
708
1402
  private completedDebouncePending: CompletedDebouncePending | null = null;
1403
+ private lastExternalCompletionProbe: ExternalTranscriptProbe | null = null;
709
1404
 
710
1405
  private async enforceFreshSessionLaunchIfNeeded(): Promise<void> {
711
1406
  const scriptName = getForcedNewSessionScriptName(this.provider, this.launchMode);
@@ -734,13 +1429,219 @@ export class CliProviderInstance implements ProviderInstance {
734
1429
  this.applyProviderResponse(parsed.payload, { phase: 'immediate' });
735
1430
  }
736
1431
 
737
- private completionHasFinalAssistantMessage(messages: unknown): boolean {
1432
+ private completionHasFinalAssistantMessage(messages: unknown, turnStartedAt?: number): boolean {
738
1433
  const visibleMessages = (Array.isArray(messages) ? messages : [])
739
1434
  .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
740
1435
  const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
741
1436
  const role = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : '';
742
1437
  const content = lastVisible ? flattenContent(lastVisible.content).trim() : '';
743
- return role === 'assistant' && !!content;
1438
+ if (role !== 'assistant' || !content) return false;
1439
+ // Guard: if the last assistant message looks like an active approval/input prompt,
1440
+ // it is not a real completion — the session is still awaiting user input.
1441
+ if (looksLikeActiveApprovalPromptText(content)) return false;
1442
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): when a producing-turn start is
1443
+ // known, the final assistant bubble must POST-DATE it. A STALE mid-turn assistant
1444
+ // (predating this turn's start — e.g. the last bubble of a prior sub-turn observed
1445
+ // during an inter-approval valley) must NOT satisfy the finalization gate, or a
1446
+ // false-idle blip emits a completion carrying that stale summary. A bubble with no
1447
+ // parseable timestamp cannot be proven stale, so it is kept (fails open — behaviour
1448
+ // identical to before for providers/paths that carry no timestamps).
1449
+ if (typeof turnStartedAt === 'number' && Number.isFinite(turnStartedAt) && turnStartedAt > 0) {
1450
+ // readChatMessageTimestampMs mirrors the summary turn-scoping reader
1451
+ // (extractFinalSummaryFromMessagesAfter) — same seconds-vs-ms heuristic and
1452
+ // field precedence — so the present-check and the summary-scope agree on which
1453
+ // bubbles predate the turn.
1454
+ const ts = readChatMessageTimestampMs(lastVisible);
1455
+ if (typeof ts === 'number' && ts < turnStartedAt) return false;
1456
+ }
1457
+ return true;
1458
+ }
1459
+
1460
+ private buildExternalTranscriptProbe(messages: unknown[], sourcePath?: string, sourceMtimeMs?: number): ExternalTranscriptProbe {
1461
+ const visibleMessages = messages.filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
1462
+ const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
1463
+ const readAt = Date.now();
1464
+ const mtimeMs = Number(sourceMtimeMs) || 0;
1465
+ return {
1466
+ readAt,
1467
+ msgCount: messages.length,
1468
+ lastRole: typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : null,
1469
+ lastKind: typeof (lastVisible as any)?.kind === 'string' ? (lastVisible as any).kind : null,
1470
+ contentLen: lastVisible ? flattenContent(lastVisible.content).trim().length : 0,
1471
+ sourcePath: typeof sourcePath === 'string' && sourcePath ? sourcePath : null,
1472
+ sourceMtimeMs: mtimeMs || null,
1473
+ mtimeAgeMs: mtimeMs ? Math.max(0, readAt - mtimeMs) : null,
1474
+ };
1475
+ }
1476
+
1477
+ private recordPendingTranscriptProbe(pending: CompletedDebouncePending): ExternalTranscriptProbe | null {
1478
+ const probe = this.lastExternalCompletionProbe;
1479
+ if (!probe) return null;
1480
+ const history = pending.transcriptProbeHistory || [];
1481
+ const last = history[history.length - 1];
1482
+ if (!last || last.readAt !== probe.readAt || last.msgCount !== probe.msgCount || last.lastRole !== probe.lastRole || last.contentLen !== probe.contentLen) {
1483
+ history.push(probe);
1484
+ pending.transcriptProbeHistory = history.slice(-5);
1485
+ }
1486
+ return probe;
1487
+ }
1488
+
1489
+ private readExternalCompletionMessages(): unknown[] | null {
1490
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1491
+ if (!adapterOwnsMessagesElsewhere) return null;
1492
+ if (!this.providerSessionId) return null;
1493
+ if (!isNativeSourceCanonicalHistory(this.provider.nativeHistory)) return null;
1494
+
1495
+ if (this.lastExternalCompletionProbe?.sourcePath) {
1496
+ try { fs.statSync(this.lastExternalCompletionProbe.sourcePath); } catch { /* best-effort metadata refresh */ }
1497
+ }
1498
+ const restoredHistory = readProviderChatHistory(this.type, {
1499
+ canonicalHistory: this.provider.nativeHistory,
1500
+ historySessionId: this.providerSessionId,
1501
+ workspace: this.workingDir,
1502
+ offset: 0,
1503
+ limit: Number.MAX_SAFE_INTEGER,
1504
+ historyBehavior: this.provider.historyBehavior,
1505
+ scripts: this.provider.scripts as any,
1506
+ sessionStartedAtMs: this.startedAt,
1507
+ forceRefresh: true,
1508
+ });
1509
+ if (restoredHistory.source !== 'provider-native') {
1510
+ this.lastExternalCompletionProbe = null;
1511
+ return null;
1512
+ }
1513
+ this.lastExternalCompletionProbe = this.buildExternalTranscriptProbe(
1514
+ restoredHistory.messages,
1515
+ restoredHistory.sourcePath,
1516
+ restoredHistory.sourceMtimeMs,
1517
+ );
1518
+ return restoredHistory.messages;
1519
+ }
1520
+
1521
+ private completionFinalAssistantEvidence(parsedMessages: unknown, turnStartedAt?: number): CompletionFinalAssistantEvidence {
1522
+ if (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)) {
1523
+ return {
1524
+ present: true,
1525
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1526
+ source: 'parsed',
1527
+ };
1528
+ }
1529
+
1530
+ const externalMessages = this.readExternalCompletionMessages();
1531
+ if (externalMessages) {
1532
+ return {
1533
+ present: this.completionHasFinalAssistantMessage(externalMessages, turnStartedAt),
1534
+ messages: externalMessages,
1535
+ source: 'external-native',
1536
+ };
1537
+ }
1538
+
1539
+ return {
1540
+ present: false,
1541
+ messages: Array.isArray(parsedMessages) ? parsedMessages : [],
1542
+ source: 'unavailable',
1543
+ };
1544
+ }
1545
+
1546
+ private completionFinalSummary(parsedMessages: unknown, turnStartedAt?: number): string | undefined {
1547
+ // For native-source providers (claude-cli: chatMessagesOwnedExternally), the PTY
1548
+ // screen parse is NOT the source of truth for the final summary — the terminal
1549
+ // wraps/scrolls/clips text, so a screen-parsed assistant message is often a partial
1550
+ // prefix (e.g. 76 chars of a 112-char turn). The append-only native transcript holds
1551
+ // the complete turn. Prefer it whenever it yields a longer/complete summary; fall back
1552
+ // to the parsed screen only when the transcript is unavailable. This is the real cause
1553
+ // of the truncated finalSummary — independent of cloud vs standalone (it surfaces on
1554
+ // any short, fast-completing task where screen parse wins the race).
1555
+ //
1556
+ // NOTIF Defect-B: `turnStartedAt` (the producing turn's start, snapshotted on the
1557
+ // completedDebouncePending record) turn-scopes the NATIVE transcript read. The native
1558
+ // transcript holds the WHOLE session filtered only by session start, so a debounce that
1559
+ // flushes before the producing turn's final assistant bubble has landed would otherwise
1560
+ // return the PRIOR task's last bubble (event taskId=B but summary=A). Filtering to bubbles
1561
+ // at/after turnStartedAt yields '' in that race instead of the stale tail; the weak/empty
1562
+ // summary is later upgraded by the mesh reconcile loop once the real bubble is written.
1563
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1564
+ // FALSE-IDLE Defect 1b: turn-scope the PARSED screen fallback too. Without this a stale
1565
+ // mid-turn assistant (predating turnStartedAt) that the turn-boundary gate already
1566
+ // rejected as evidence could still leak into the finalSummary via this parsed fallback
1567
+ // when the external transcript's turn-scoped read is empty — freezing the very stale text
1568
+ // the gate rejected. extractFinalSummaryFromMessagesAfter drops bubbles before the turn
1569
+ // start; with no boundary known (turnStartedAt falsy) it is identical to the unscoped read.
1570
+ const parsedSummary = extractFinalSummaryFromMessagesAfter(
1571
+ (this.completionHasFinalAssistantMessage(parsedMessages, turnStartedAt)
1572
+ ? (Array.isArray(parsedMessages) ? parsedMessages : [])
1573
+ : []) as any,
1574
+ turnStartedAt,
1575
+ );
1576
+ if (adapterOwnsMessagesElsewhere) {
1577
+ const externalMessages = this.readExternalCompletionMessages();
1578
+ // Turn-scope the external transcript: never return a bubble produced before this
1579
+ // turn started. With no boundary known (turnStartedAt falsy) behaviour is unchanged.
1580
+ const externalSummary = externalMessages
1581
+ ? extractFinalSummaryFromMessagesAfter(externalMessages as any, turnStartedAt)
1582
+ : '';
1583
+ // The transcript is authoritative for native-source providers. Use it unless it is
1584
+ // empty (not yet written, or no in-turn bubble) — only then fall back to the screen
1585
+ // parse, which reflects the LIVE screen (this turn's output), not the stale tail.
1586
+ if (externalSummary) return externalSummary;
1587
+ return parsedSummary || undefined;
1588
+ }
1589
+ return parsedSummary || undefined;
1590
+ }
1591
+
1592
+ private buildCompletedFinalizationDiagnostic(args: {
1593
+ blockReason: string;
1594
+ latestStatus?: any;
1595
+ latestVisibleStatus: string;
1596
+ waitedMs: number;
1597
+ pending: CompletedDebouncePending;
1598
+ emittedAfterFinalizationTimeout: boolean;
1599
+ }): Record<string, unknown> {
1600
+ let parsed: any = null;
1601
+ let parseError: string | undefined;
1602
+ try {
1603
+ parsed = this.adapter.getScriptParsedStatus();
1604
+ } catch (error: any) {
1605
+ parseError = error?.message || String(error);
1606
+ }
1607
+
1608
+ const evidence = this.completionFinalAssistantEvidence(parsed?.messages);
1609
+ if (evidence.source === 'external-native') {
1610
+ this.recordPendingTranscriptProbe(args.pending);
1611
+ }
1612
+ const visibleMessages = (Array.isArray(evidence.messages) ? evidence.messages : [])
1613
+ .filter((message: any) => isUserFacingChatMessage(message as ChatMessage));
1614
+ const lastVisible = visibleMessages[visibleMessages.length - 1] as ChatMessage | undefined;
1615
+ const lastVisibleRole = typeof lastVisible?.role === 'string' ? lastVisible.role.trim().toLowerCase() : null;
1616
+ const lastVisibleKind = typeof (lastVisible as any)?.kind === 'string' ? (lastVisible as any).kind : null;
1617
+ const lastVisibleContentLength = lastVisible ? flattenContent(lastVisible.content).trim().length : 0;
1618
+
1619
+ return {
1620
+ providerType: this.type,
1621
+ sessionId: this.instanceId,
1622
+ providerSessionId: this.providerSessionId || null,
1623
+ workspace: this.workingDir,
1624
+ blockReason: args.blockReason,
1625
+ emittedAfterFinalizationTimeout: args.emittedAfterFinalizationTimeout,
1626
+ waitedMs: args.waitedMs,
1627
+ maxWaitMs: COMPLETED_FINALIZATION_MAX_WAIT_MS,
1628
+ adapterStatus: typeof args.latestStatus?.status === 'string' ? args.latestStatus.status : null,
1629
+ latestVisibleStatus: args.latestVisibleStatus,
1630
+ parsedStatus: typeof parsed?.status === 'string' ? parsed.status : (parseError ? 'parse_error' : 'unknown'),
1631
+ parseError: parseError || undefined,
1632
+ finalAssistantPresent: evidence.present,
1633
+ finalAssistantEvidenceSource: evidence.source,
1634
+ visibleMessageCount: visibleMessages.length,
1635
+ lastVisibleRole,
1636
+ lastVisibleKind,
1637
+ lastVisibleContentLength,
1638
+ pendingStartedAt: this.generatingStartedAt || null,
1639
+ pendingFirstObservedAt: args.pending.firstObservedAt,
1640
+ pendingTimestamp: args.pending.timestamp,
1641
+ pendingDurationSec: args.pending.duration,
1642
+ previousBlockReason: args.pending.loggedBlockReason || null,
1643
+ transcriptProbeHistory: args.pending.transcriptProbeHistory || [],
1644
+ };
744
1645
  }
745
1646
 
746
1647
  private hasAdapterPendingResponse(): boolean {
@@ -765,41 +1666,224 @@ export class CliProviderInstance implements ProviderInstance {
765
1666
  if (!isCliGeneratingLikeStatus(parsedRawStatus)) return false;
766
1667
  if (adapterRawStatus !== 'idle') return false;
767
1668
  if (hasNonEmptyCliModalButtons(parsedStatus?.activeModal ?? parsedStatus?.modal)) return false;
768
- return !this.hasAdapterPendingResponse();
1669
+ if (this.hasAdapterPendingResponse()) return false;
1670
+ // Do not suppress when the adapter's raw response buffer is still non-empty.
1671
+ // This catches the case where isWaitingForResponse has already flipped to false
1672
+ // (so getPartialResponse() returns '') but the provider's native parser still
1673
+ // reports generating because it's parsing buffered content. Suppressing the
1674
+ // finalization block here would emit a false completion event while the provider
1675
+ // session is still actively processing its response stream.
1676
+ const adapterAny = this.adapter as any;
1677
+ if (typeof adapterAny?.responseBuffer === 'string' && adapterAny.responseBuffer.trim()) return false;
1678
+ return true;
769
1679
  }
770
1680
 
771
- private getCompletedFinalizationBlockReason(latestVisibleStatus: string): string | null {
772
- if (latestVisibleStatus !== 'idle') return `status:${latestVisibleStatus}`;
1681
+ private getCompletedFinalizationBlock(latestVisibleStatus: string, pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1682
+ if (latestVisibleStatus !== 'idle') return { reason: `status:${latestVisibleStatus}`, terminal: true };
773
1683
 
774
1684
  const adapterAny = this.adapter as any;
775
- if (adapterAny?.isWaitingForResponse === true) return 'adapter_waiting_for_response';
776
- if (adapterAny?.currentTurnScope) return 'adapter_turn_scope_active';
1685
+ const approvalResolvedIdle = pending.previousStatus === 'waiting_approval';
1686
+ if (!approvalResolvedIdle) {
1687
+ if (adapterAny?.isWaitingForResponse === true) return { reason: 'adapter_waiting_for_response', terminal: true };
1688
+ if (adapterAny?.currentTurnScope) return { reason: 'adapter_turn_scope_active', terminal: true };
1689
+ if (this.hasAdapterPendingResponse()) return { reason: 'adapter_pending_response', terminal: true };
1690
+ }
777
1691
 
778
1692
  const partial = typeof this.adapter.getPartialResponse === 'function'
779
1693
  ? this.adapter.getPartialResponse()
780
1694
  : '';
781
- if (typeof partial === 'string' && partial.trim()) return 'partial_response_pending';
1695
+ if (typeof partial === 'string' && partial.trim()) return { reason: 'partial_response_pending', terminal: true };
782
1696
 
783
1697
  let parsed: any;
784
1698
  try {
785
1699
  parsed = this.adapter.getScriptParsedStatus();
786
1700
  } catch (error: any) {
787
- return `parse_error:${error?.message || String(error)}`;
1701
+ return { reason: `parse_error:${error?.message || String(error)}` };
788
1702
  }
789
1703
 
790
1704
  const parsedStatus = typeof parsed?.status === 'string' ? parsed.status : 'unknown';
791
- if (parsedStatus !== 'idle') return `parsed_status:${parsedStatus}`;
792
- if (parsed?.activeModal || parsed?.modal) return 'parsed_modal_active';
793
- if (!this.completionHasFinalAssistantMessage(parsed?.messages)) return 'missing_final_assistant';
1705
+ if (parsedStatus !== 'idle') {
1706
+ const adapterStatus = this.adapter.getStatus({ allowParse: false });
1707
+ if (this.shouldSuppressStaleParsedBusyStatus(parsed, adapterStatus)) return null;
1708
+ return { reason: `parsed_status:${parsedStatus}`, terminal: isCliGeneratingLikeStatus(parsedStatus) };
1709
+ }
1710
+ if (parsed?.activeModal || parsed?.modal) return { reason: 'parsed_modal_active', terminal: true };
1711
+ const adapterOwnsMessagesElsewhere = (this.adapter as any)?.chatMessagesOwnedExternally === true;
1712
+ // FALSE-IDLE turn-boundary evidence (Defect 1b): turn-scope the present-check so a
1713
+ // STALE mid-turn assistant (predating pending.turnStartedAt) cannot satisfy the
1714
+ // finalization gate. Only the confirming final-assistant bubble that POST-DATES this
1715
+ // turn's start counts as evidence the turn genuinely ended.
1716
+ const finalAssistantEvidence = this.completionFinalAssistantEvidence(parsed?.messages, pending.turnStartedAt);
1717
+ const allowMissingAssistantTimeout = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1718
+ LOG.debug('CLI', `[${this.type}] finalAssistantEvidence: present=${finalAssistantEvidence.present} source=${finalAssistantEvidence.source} adapterOwnsMessagesElsewhere=${adapterOwnsMessagesElsewhere} parsedStatus=${parsedStatus}`);
1719
+ if (!finalAssistantEvidence.present) {
1720
+ if (adapterOwnsMessagesElsewhere) {
1721
+ if (finalAssistantEvidence.source === 'external-native') {
1722
+ const probe = this.recordPendingTranscriptProbe(pending);
1723
+ if (probe && !pending.loggedTranscriptProbe) {
1724
+ LOG.info('CLI', `[${this.type}] external transcript probe: msgCount=${probe.msgCount} lastRole=${probe.lastRole || 'none'} lastKind=${probe.lastKind || 'none'} contentLen=${probe.contentLen} sourceMtime=${probe.sourceMtimeMs ?? 'unknown'} mtimeAge=${probe.mtimeAgeMs ?? 'unknown'}ms`);
1725
+ pending.loggedTranscriptProbe = true;
1726
+ }
1727
+ LOG.debug('CLI', `[${this.type}] external-native probe result: lastRole=${probe?.lastRole} contentLen=${probe?.contentLen}`);
1728
+ if (probe?.lastRole === 'assistant' && (probe.contentLen ?? 0) > 0) {
1729
+ return null;
1730
+ }
1731
+ if (this.type === 'antigravity-cli') {
1732
+ return null;
1733
+ }
1734
+ // (SETTLE-VALLEY) The inter-approval idle valley: a native-history mesh worker
1735
+ // that resolved an approval and fell briefly idle (waiting_approval→idle) BEFORE
1736
+ // the next approval turn resumes. The live valley (~3s) is mostly covered by the
1737
+ // 4000ms NATIVE_HISTORY_MESH_IDLE_SETTLE_MS settle window, but a longer valley can
1738
+ // still let the flush run while the transcript's final assistant turn is not yet
1739
+ // written (source still the screen parse → finalAssistantPresent=false,
1740
+ // workerResult.source='default'). CANON-C would emit immediately here, freezing a
1741
+ // truncated preamble summary as evidenceLevel=insufficient. Instead HOLD: this
1742
+ // waiting_approval hold complements the settle window. Retry until the transcript finalizes
1743
+ // (block clears → genuine emit) or the worker resumes (resume guard cancels),
1744
+ // bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS. Scoped to the approval-resolved
1745
+ // idle so a genuinely-finished background-child turn keeps the CANON-C immediate
1746
+ // emit (its transcript trails by a write, not by a whole resume).
1747
+ if (allowMissingAssistantTimeout && pending.previousStatus === 'waiting_approval') {
1748
+ return { reason: 'missing_final_assistant', terminal: false, holdForTranscript: true };
1749
+ }
1750
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1751
+ }
1752
+ if ((this.provider as any).requiresFinalAssistantBeforeIdle === true) {
1753
+ return { reason: 'missing_final_assistant', terminal: true, allowTimeout: allowMissingAssistantTimeout };
1754
+ }
1755
+ } else {
1756
+ LOG.debug('CLI', `[${this.type}] missing_final_assistant (not ownsExternal) requiresFinalAssistant=${!!(this.provider as any).requiresFinalAssistantBeforeIdle}`);
1757
+ return {
1758
+ reason: 'missing_final_assistant',
1759
+ terminal: (this.provider as any).requiresFinalAssistantBeforeIdle === true,
1760
+ allowTimeout: allowMissingAssistantTimeout,
1761
+ };
1762
+ }
1763
+ }
1764
+
1765
+ // (FALSEIDLE-a) Structural approval-resolution gate. Runs BEFORE the brittle
1766
+ // screen-text heuristic below so it also catches modals whose text does not match
1767
+ // looksLikeActiveApprovalPromptText (e.g. claude-cli's cd / "untrusted hooks" prompt).
1768
+ const approvalResolutionBlock = this.approvalResolutionFinalizationBlock(pending);
1769
+ if (approvalResolutionBlock) return approvalResolutionBlock;
1770
+
1771
+ // Guard: if the screen still shows an approval/choice prompt as the last visible text,
1772
+ // the turn is not complete even if the parsed status says idle and there is an assistant
1773
+ // message. This catches the case where waiting_approval→idle transitions occur before
1774
+ // the modal has been resolved (e.g. the PTY rendered the prompt but no button press fired).
1775
+ try {
1776
+ const screenText = typeof (this.adapter as any).getScreenText === 'function'
1777
+ ? String((this.adapter as any).getScreenText() || '')
1778
+ : '';
1779
+ if (screenText) {
1780
+ const tailLines = screenText.split(/\r?\n/).slice(-16).join('\n');
1781
+ if (looksLikeActiveApprovalPromptText(tailLines)) {
1782
+ return { reason: 'screen_shows_approval_prompt', terminal: approvalResolvedIdle };
1783
+ }
1784
+ }
1785
+ } catch { /* defensive: screen text read is best-effort */ }
794
1786
 
795
1787
  return null;
796
1788
  }
797
1789
 
1790
+ // (FALSEIDLE-a) Positive, structural proof that the latest approval entry was resolved
1791
+ // through ADHDev. resolveModal() — driven by auto-approve, dashboard/mesh_approve, and
1792
+ // dev-cli-debug alike — advances the engine's lastResolvedEntrySeq to the current
1793
+ // approvalEntrySeq. So `lastResolvedEntrySeq >= approvalEntrySeq` (with a real entry,
1794
+ // approvalEntrySeq > 0) means the modal we last saw was actually answered. Absence of this
1795
+ // evidence after a waiting_approval→idle transition means the idle is suspect: the spec's
1796
+ // text-based approval→idle rule false-tripped while the modal is still unresolved.
1797
+ // Fails OPEN (returns true) when the seq fields are unavailable, so the gate can never wedge
1798
+ // a session on a provider/adapter that does not surface the counters.
1799
+ private hasApprovalResolutionEvidence(): boolean {
1800
+ try {
1801
+ const status = this.adapter.getStatus({ allowParse: false }) as any;
1802
+ const entrySeq = typeof status?.approvalEntrySeq === 'number' ? status.approvalEntrySeq : 0;
1803
+ if (entrySeq <= 0) return true;
1804
+ const resolvedSeq = typeof status?.lastResolvedEntrySeq === 'number' ? status.lastResolvedEntrySeq : undefined;
1805
+ if (resolvedSeq === undefined) return true;
1806
+ return resolvedSeq >= entrySeq;
1807
+ } catch {
1808
+ return true;
1809
+ }
1810
+ }
1811
+
1812
+ // (FALSEIDLE-a) Hold a completion that is the anomalous DIRECT waiting_approval→idle
1813
+ // transition with no positive resolution evidence. A genuinely resolved approval routes
1814
+ // through resolveModal → setStatus('generating'), so its completion's previousStatus is
1815
+ // 'generating' (not 'waiting_approval') and this gate never fires for it. Scoped to
1816
+ // delegated mesh/coordinator sessions — whose only modal-resolution path is auto-approve /
1817
+ // mesh_approve (both advance lastResolvedEntrySeq) — so an interactive local session, where
1818
+ // a human may answer the PTY prompt directly and leave no resolveModal record, is untouched.
1819
+ // Non-terminal: the hold is bounded by COMPLETED_FINALIZATION_MAX_WAIT_MS (30s), giving a
1820
+ // settling auto-approve time to fire and advance the seq, and guaranteeing no permanent wedge
1821
+ // if resolution ever happens via a path that does not record evidence.
1822
+ private approvalResolutionFinalizationBlock(pending: CompletedDebouncePending): CompletedFinalizationBlock | null {
1823
+ if (pending.previousStatus !== 'waiting_approval') return null;
1824
+ const meshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
1825
+ if (!meshContext) return null;
1826
+ if (this.hasApprovalResolutionEvidence()) return null;
1827
+ return { reason: 'approval_resolution_unconfirmed', terminal: false };
1828
+ }
1829
+
798
1830
  private scheduleCompletedDebounceFlush(delayMs: number): void {
799
1831
  if (this.completedDebounceTimer) clearTimeout(this.completedDebounceTimer);
800
1832
  this.completedDebounceTimer = setTimeout(() => this.flushCompletedDebounceIfFinalized(), delayMs);
801
1833
  }
802
1834
 
1835
+ // EVTTRACE (observation-only): is this a mesh worker session whose completion
1836
+ // events must route to a coordinator? Used purely to gate trace logging so a
1837
+ // non-mesh CLI session's completions don't add EvtTrace noise. No decision logic.
1838
+ private isMeshWorkerSession(): boolean {
1839
+ return !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId
1840
+ || this.settings.meshNodeId || this.settings.launchedByCoordinator);
1841
+ }
1842
+
1843
+ // FALSE-IDLE (self-coordinator settle): an autonomously-progressing mesh session
1844
+ // is either a delegated worker (isMeshWorkerSession) OR the coordinator's OWN
1845
+ // claude-cli session (meshCoordinatorFor). Both run auto-approved tool turns whose
1846
+ // inter-approval valley (busy→idle blip→generating re-entry ~0.5s later) must be
1847
+ // absorbed by the completedDebounce settle window, not flushed on the first idle
1848
+ // sample. The worker branch already gets NATIVE_HISTORY_MESH_IDLE_SETTLE_MS; the
1849
+ // self-coordinator session (worker markers absent, meshCoordinatorFor present) was
1850
+ // taking flushDelay=0 — no settle window — so its busyEpoch/lastOutputAt continuity
1851
+ // guard had no window to observe the valley and fired mid-turn "next-step" previews
1852
+ // as a finalSummary. Mirrors the isAutonomousMeshSession notion in isTransientToolConsent.
1853
+ private isAutonomousMeshSession(): boolean {
1854
+ return this.isMeshWorkerSession() || !!this.settings.meshCoordinatorFor;
1855
+ }
1856
+
1857
+ /**
1858
+ * ARCH-REFACTOR R1: the taskId to attribute the CURRENTLY-completing turn to.
1859
+ * Prefers the per-turn binding (engine.currentTurnTaskId, set when the turn was
1860
+ * submitted and surviving until the next turn starts) over the last-write-wins
1861
+ * session scalar (settings.meshActiveTaskId). The scalar is retained only as a
1862
+ * backward-compat alias for the "current/last assignment" and is the source of the
1863
+ * NOTIF-MISDELIVER / TASK-MSG-MISROUTE race: a second task attaching before this
1864
+ * turn completes overwrites it. Returns undefined for a non-task ad-hoc turn.
1865
+ */
1866
+ private completingTurnTaskId(): string | undefined {
1867
+ const turnTaskId = this.adapter?.currentTurnTaskId;
1868
+ if (typeof turnTaskId === 'string' && turnTaskId.trim()) return turnTaskId;
1869
+ const scalar = this.settings.meshActiveTaskId;
1870
+ return typeof scalar === 'string' && scalar.trim() ? scalar : undefined;
1871
+ }
1872
+
1873
+ // EVTTRACE correlation context for this session's completion lifecycle. taskId is
1874
+ // the primary grep anchor; instanceId is the session fallback.
1875
+ private meshTraceCtx(event = 'agent:generating_completed'): Record<string, unknown> {
1876
+ return {
1877
+ // ARCH-REFACTOR R1: trace the per-turn taskId (falling back to the scalar) so
1878
+ // EvtTrace anchors on the same id the completion event actually carries.
1879
+ taskId: this.completingTurnTaskId(),
1880
+ sessionId: this.instanceId,
1881
+ nodeId: this.settings.meshNodeId,
1882
+ meshId: this.settings.meshNodeFor,
1883
+ event,
1884
+ };
1885
+ }
1886
+
803
1887
  private flushCompletedDebounceIfFinalized(): void {
804
1888
  const pending = this.completedDebouncePending;
805
1889
  if (!pending) {
@@ -809,7 +1893,8 @@ export class CliProviderInstance implements ProviderInstance {
809
1893
 
810
1894
  const latestStatus = this.adapter.getStatus({ allowParse: false });
811
1895
  const latestAutoApproveActive = latestStatus.status === 'waiting_approval' && this.shouldAutoApprove();
812
- const latestVisibleStatus = latestAutoApproveActive ? 'generating' : latestStatus.status;
1896
+ const latestVisibleStatus = latestAutoApproveActive || this.autoApproveBusy ? 'generating' : latestStatus.status;
1897
+ LOG.debug('CLI', `[${this.type}] flush attempt: adapterStatus=${latestStatus.status} latestVisible=${latestVisibleStatus} generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse} hasPartial=${!!this.adapter.getPartialResponse?.()}`);
813
1898
  if (latestVisibleStatus !== 'idle') {
814
1899
  LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed ${latestVisibleStatus})`);
815
1900
  this.completedDebouncePending = null;
@@ -817,89 +1902,548 @@ export class CliProviderInstance implements ProviderInstance {
817
1902
  return;
818
1903
  }
819
1904
 
820
- const blockReason = this.getCompletedFinalizationBlockReason(latestVisibleStatus);
821
- if (blockReason) {
1905
+ // FALSE-IDLE continuity guard (Defect 1a): the point-sample above only proves the
1906
+ // session is idle at THIS instant. A momentary busy→idle blip inside an inter-approval
1907
+ // valley (auto-approved tool turns) opens AND closes a generating phase entirely within
1908
+ // the settle window — so the single sample reads 'idle' even though the turn is still in
1909
+ // flight (it re-enters generating ~0.5s later). Require instead that the session stayed
1910
+ // CONTINUOUSLY idle since the debounce was armed: (1) no entry into a busy phase
1911
+ // (busyEpoch unchanged), and (2) no new raw PTY output (lastOutputAt did not advance).
1912
+ // Either signal ⇒ the idle was not continuous ⇒ cancel; the still-live turn re-arms its
1913
+ // own completion when it genuinely finishes. This only ever cancels (never emits more),
1914
+ // so shared behaviour for claude/codex/antigravity is strictly stricter, never looser.
1915
+ if (typeof pending.busyEpochAtArm === 'number' && this.busyEpoch !== pending.busyEpochAtArm) {
1916
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (busy re-entry during settle: epoch ${pending.busyEpochAtArm}→${this.busyEpoch})`);
1917
+ this.completedDebouncePending = null;
1918
+ this.completedDebounceTimer = null;
1919
+ return;
1920
+ }
1921
+ const latestOutputAt = typeof (latestStatus as any)?.lastOutputAt === 'number' ? (latestStatus as any).lastOutputAt as number : undefined;
1922
+ if (typeof pending.lastOutputAtArm === 'number'
1923
+ && typeof latestOutputAt === 'number'
1924
+ && latestOutputAt > pending.lastOutputAtArm) {
1925
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (new PTY output during settle: ${pending.lastOutputAtArm}→${latestOutputAt})`);
1926
+ this.completedDebouncePending = null;
1927
+ this.completedDebounceTimer = null;
1928
+ return;
1929
+ }
1930
+
1931
+ const block = this.getCompletedFinalizationBlock(latestVisibleStatus, pending);
1932
+ if (block) {
1933
+ const blockReason = block.reason;
822
1934
  const waitedMs = Date.now() - pending.firstObservedAt;
823
- if (waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS) {
1935
+ // CANON-C (completion-gate decouple): a block carrying `allowTimeout` is the
1936
+ // transcript-evidence gate — the worker FSM has ALREADY reached idle and the only
1937
+ // thing missing is the append-only transcript's final assistant turn (a native-source
1938
+ // race: claude-cli owns its history externally and the file write trails the idle
1939
+ // transition). `allowTimeout` is set ONLY on the missing_final_assistant block, and
1940
+ // ONLY for mesh worker sessions (meshNodeFor / meshActiveTaskId / launchedByCoordinator).
1941
+ // The coordinator's sole path to learn this session is idle is agent:generating_completed,
1942
+ // so holding it up to COMPLETED_FINALIZATION_MAX_WAIT_MS (30s) leaves the coordinator
1943
+ // false-generating while the worker is done. Decouple the idle NOTIFICATION from the
1944
+ // transcript evidence: emit the completion immediately, marked weak
1945
+ // (completionDiagnostic.blockReason=missing_final_assistant, finalAssistantPresent=false).
1946
+ // The finalSummary is enriched on a SEPARATE path — the mesh reconcile loop reads the
1947
+ // transcript once written and re-emits a GENUINE completion (CANON-B weak→genuine
1948
+ // upgrade; buildPendingEventFingerprint keeps weak and genuine distinct so the enriched
1949
+ // one still surfaces, and isFalseIdleCompletion keeps the direct dispatch active until
1950
+ // then). All OTHER blocks (genuinely-busy adapter/partial/parsed states, transient
1951
+ // parse_error) keep the existing terminal-hold / 30s-retry behavior unchanged.
1952
+ //
1953
+ // (SETTLE-VALLEY) Exception: a `holdForTranscript` block is the inter-approval idle
1954
+ // valley of a native-history mesh worker (waiting_approval→idle that will resume into
1955
+ // the next approval). It deliberately does NOT carry allowTimeout, so it falls into the
1956
+ // hold-and-retry path below (terminal:false) rather than the CANON-C immediate emit —
1957
+ // the retry loop re-runs the resume guard each cycle, so when the worker resumes the
1958
+ // pending completion is cancelled, and when the transcript's final assistant arrives the
1959
+ // block clears for a GENUINE emit. This blocks the truncated weak (insufficient) summary
1960
+ // from ever being emitted during the valley, without depending on the valley's length.
1961
+ const isTranscriptEvidenceGate = block.allowTimeout === true;
1962
+ LOG.debug('CLI', `[${this.type}] finalization block: reason=${blockReason} terminal=${block.terminal} allowTimeout=${isTranscriptEvidenceGate} waitedMs=${waitedMs} maxWait=${COMPLETED_FINALIZATION_MAX_WAIT_MS}`);
1963
+ if (!isTranscriptEvidenceGate && (block.terminal || waitedMs < COMPLETED_FINALIZATION_MAX_WAIT_MS)) {
824
1964
  if (pending.loggedBlockReason !== blockReason) {
825
1965
  LOG.info('CLI', `[${this.type}] waiting to emit completed until transcript finalizes (${blockReason})`);
1966
+ // EVTTRACE: completion held by the finalization gate (CANON-C). Observation
1967
+ // only — does not change the hold decision above.
1968
+ if (this.isMeshWorkerSession()) {
1969
+ traceMeshEventDrop('completion_gate_hold', this.meshTraceCtx(), `${blockReason} waited=${waitedMs}ms`);
1970
+ }
826
1971
  pending.loggedBlockReason = blockReason;
827
1972
  }
828
1973
  this.scheduleCompletedDebounceFlush(COMPLETED_FINALIZATION_RETRY_MS);
829
1974
  return;
830
1975
  }
831
- LOG.warn('CLI', `[${this.type}] suppressed completed event after ${waitedMs}ms without finalized assistant turn (${blockReason})`);
1976
+ const emittedAfterFinalizationTimeout = waitedMs >= COMPLETED_FINALIZATION_MAX_WAIT_MS;
1977
+ const completionDiagnostic = this.buildCompletedFinalizationDiagnostic({
1978
+ blockReason,
1979
+ latestStatus,
1980
+ latestVisibleStatus,
1981
+ waitedMs,
1982
+ pending,
1983
+ emittedAfterFinalizationTimeout,
1984
+ });
1985
+ // Surface the CANON-C immediate-emit path distinctly so a delegated worker's idle
1986
+ // notification (transcript still pending) is not mistaken for a 30s-timeout fallback.
1987
+ (completionDiagnostic as Record<string, unknown>).decoupledImmediateEmit = isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout;
1988
+ LOG.warn('CLI', `[${this.type}] emitting completed event (${isTranscriptEvidenceGate && !emittedAfterFinalizationTimeout ? 'CANON-C decoupled-immediate, transcript pending' : `after ${waitedMs}ms`}) without finalized assistant turn (${blockReason})`);
1989
+ // EVTTRACE: completion fired (forced past the finalization timeout / CANON-C decoupled-immediate).
1990
+ if (this.isMeshWorkerSession()) {
1991
+ traceMeshEventStage('fired', this.meshTraceCtx(), `forced after ${waitedMs}ms (${blockReason})`);
1992
+ }
1993
+ this.pushEvent({
1994
+ event: 'agent:generating_completed',
1995
+ chatTitle: pending.chatTitle,
1996
+ duration: pending.duration,
1997
+ timestamp: pending.timestamp,
1998
+ // ARCH-REFACTOR R1: attribute to the turn captured at idle-transition.
1999
+ ...(pending.taskId ? { taskId: pending.taskId } : {}),
2000
+ // When finalization is forced past the timeout on a `parsed_status:` block
2001
+ // (the parser never confirmed a final assistant turn) we previously rode an
2002
+ // empty `finalSummary` unconditionally. That empty value propagates to the
2003
+ // mesh coordinator's mirror preview (meshSessionLastMessagePreview), leaving a
2004
+ // delegated session's inbox preview blank — or, for a LOCAL worktree session,
2005
+ // stuck on the dispatched user task. If the parser DID surface assistant text,
2006
+ // prefer it; only fall back to '' when no assistant summary can be derived.
2007
+ finalSummary: blockReason.startsWith('parsed_status:')
2008
+ ? (this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt) ?? '')
2009
+ : this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
2010
+ completionDiagnostic,
2011
+ });
832
2012
  this.completedDebouncePending = null;
833
2013
  this.completedDebounceTimer = null;
834
2014
  this.generatingStartedAt = 0;
2015
+ this.lastApprovalEventFingerprint = '';
835
2016
  return;
836
2017
  }
837
2018
 
838
2019
  LOG.info('CLI', `[${this.type}] completed in ${pending.duration}s`);
2020
+ // EVTTRACE: completion fired (transcript finalized cleanly).
2021
+ if (this.isMeshWorkerSession()) {
2022
+ traceMeshEventStage('fired', this.meshTraceCtx(), `duration=${pending.duration}s`);
2023
+ }
839
2024
  this.pushEvent({
840
2025
  event: 'agent:generating_completed',
841
2026
  chatTitle: pending.chatTitle,
842
2027
  duration: pending.duration,
843
2028
  timestamp: pending.timestamp,
844
- finalSummary: extractFinalSummaryFromMessages(this.adapter?.getScriptParsedStatus()?.messages),
2029
+ // ARCH-REFACTOR R1: attribute to the turn captured at idle-transition.
2030
+ ...(pending.taskId ? { taskId: pending.taskId } : {}),
2031
+ finalSummary: this.completionFinalSummary(this.adapter?.getScriptParsedStatus()?.messages, pending.turnStartedAt),
845
2032
  });
846
2033
  this.completedDebouncePending = null;
847
2034
  this.completedDebounceTimer = null;
848
2035
  this.generatingStartedAt = 0;
2036
+ this.lastApprovalEventFingerprint = '';
849
2037
  }
850
2038
 
851
2039
  private maybeAutoApproveStatus(adapterStatus: any, now = Date.now()): boolean {
2040
+ // Manual-attendance suppression (provider-common): when a human is
2041
+ // actively driving this session from the dashboard, hold auto-approve so
2042
+ // the modal stays visible and they can pick a button / use the controlbar
2043
+ // themselves. Return false (NOT auto-approving) so getState keeps the
2044
+ // modal surfaced. Clear any in-progress settle gate — a genuine fire
2045
+ // after the window lapses must re-settle from scratch — and arm a
2046
+ // re-check for the lapse moment, because the PTY may have gone silent and
2047
+ // would otherwise never re-drive this decision. Background mesh workers
2048
+ // are never attended, so their delegated auto-approve is untouched.
2049
+ if (adapterStatus?.status === 'waiting_approval'
2050
+ && this.shouldAutoApprove()
2051
+ && this.manualAttendance.isAttended(now)) {
2052
+ this.lastAutoApprovalSignature = '';
2053
+ this.pendingAutoApprovalSignature = '';
2054
+ this.pendingAutoApprovalSince = 0;
2055
+ this.autoApproveInactiveSince = 0;
2056
+ // Manual attendance takes over — the modal stays surfaced (maybeAutoApproveStatus
2057
+ // returns false), so end the mask episode.
2058
+ this.autoApproveMaskSince = 0;
2059
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2060
+ this.autoApproveSettleTimer = setTimeout(() => {
2061
+ this.autoApproveSettleTimer = null;
2062
+ this.recheckAutoApproveSettled();
2063
+ }, this.manualAttendance.remainingMs(now) + 20);
2064
+ return false;
2065
+ }
852
2066
  const autoApproveActive = adapterStatus?.status === 'waiting_approval' && this.shouldAutoApprove();
853
2067
  // Guard re-entry: onStatusChange/getState can observe the same modal multiple
854
2068
  // times while the PTY absorbs the approval key. Without this flag, repeated
855
2069
  // snapshots would write stray keys into the input once the modal dismisses.
856
- if (autoApproveActive && !this.autoApproveBusy) {
857
- this.autoApproveBusy = true;
858
- if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
859
- this.autoApproveBusyTimer = setTimeout(() => {
860
- this.autoApproveBusy = false;
861
- this.autoApproveBusyTimer = null;
862
- }, 2000);
863
- const modal = adapterStatus.activeModal;
864
- const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(modal?.buttons, this.provider);
865
- this.recordAutoApproval(modal?.message, buttonLabel, now);
866
- setTimeout(() => {
867
- this.adapter.resolveModal(buttonIndex);
868
- }, 0);
2070
+ // However, Claude Code can present a second approval immediately after the
2071
+ // first. Resolve a changed modal signature even while the previous write is
2072
+ // still inside the short busy window.
2073
+ if (!autoApproveActive) {
2074
+ this.lastAutoApprovalSignature = '';
2075
+ // Hysteresis: if a settle gate is mid-progress, a momentary
2076
+ // status!=waiting_approval blip (a generating flip while the same
2077
+ // modal's button block is still on screen) must NOT wipe the settle
2078
+ // clock otherwise the modal→generating→modal flap restarts the
2079
+ // 600ms window every time and auto-approve never fires. Keep the
2080
+ // gate warm for AUTO_APPROVE_GATE_HYSTERESIS_MS; re-arm a timer so
2081
+ // that if the modal does NOT come back the gate is cleared on the
2082
+ // re-check (a genuine resolution → idle frees the gate normally).
2083
+ if (this.pendingAutoApprovalSince) {
2084
+ if (!this.autoApproveInactiveSince) this.autoApproveInactiveSince = now;
2085
+ const goneForMs = now - this.autoApproveInactiveSince;
2086
+ if (goneForMs < CliProviderInstance.AUTO_APPROVE_GATE_HYSTERESIS_MS) {
2087
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2088
+ this.autoApproveSettleTimer = setTimeout(() => {
2089
+ this.autoApproveSettleTimer = null;
2090
+ this.recheckAutoApproveSettled();
2091
+ }, CliProviderInstance.AUTO_APPROVE_GATE_HYSTERESIS_MS - goneForMs + 20);
2092
+ return autoApproveActive;
2093
+ }
2094
+ }
2095
+ // Clear the settle gate so the next approval starts its own quiet
2096
+ // window from scratch (a stale timestamp would let it fire instantly).
2097
+ this.pendingAutoApprovalSignature = '';
2098
+ this.pendingAutoApprovalSince = 0;
2099
+ this.autoApproveInactiveSince = 0;
2100
+ // Modal has genuinely been gone past the hysteresis window → the episode ended;
2101
+ // end the mask episode too (a later approval starts a fresh stall clock).
2102
+ this.autoApproveMaskSince = 0;
2103
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
2104
+ return autoApproveActive;
869
2105
  }
2106
+ // Active approval observed — reset the inactivity tracker so a later
2107
+ // blip starts its hysteresis window fresh.
2108
+ this.autoApproveInactiveSince = 0;
2109
+ // STATUS-MISMATCH: start (or keep) the mask-stall clock for this episode. Set ONLY
2110
+ // when zero so it survives modal-signature changes and hysteresis blips — it measures
2111
+ // the true age of the unresolved auto-approve, not the per-signature settle window.
2112
+ if (!this.autoApproveMaskSince) this.autoApproveMaskSince = now;
2113
+ const modal = adapterStatus.activeModal;
2114
+ // (fix) Do not auto-approve when no concrete modal/buttons are present.
2115
+ // Claude TUI flaps between paints; without this guard adapterStatus
2116
+ // could report status=waiting_approval with activeModal=null (or with
2117
+ // an empty buttons array briefly) and we'd still call
2118
+ // resolveModal(-1) — which used to type "1" into the prompt
2119
+ // repeatedly. Skip until a real modal is captured.
2120
+ const buttons = Array.isArray(modal?.buttons)
2121
+ ? modal.buttons.map((b: any) => String(b || '').trim()).filter(Boolean)
2122
+ : [];
2123
+ if (!modal || buttons.length === 0) {
2124
+ return autoApproveActive;
2125
+ }
2126
+ // Picker/confirm exclusion (provider-common). A /model or /mode picker is
2127
+ // surfaced with status=waiting_approval so the dashboard shows it, but it
2128
+ // has no "correct" answer to auto-pick — blindly selecting the first
2129
+ // option silently switches the model (the "always Opus, before I even
2130
+ // choose" bug). Two independent gates, BOTH must pass to fire:
2131
+ //
2132
+ // (1) modal_kind — the spec/FSM tells us this is an 'approval' modal,
2133
+ // not a 'picker'/'confirm'. A modal whose kind is unknown (legacy
2134
+ // adapter, or a spec that predates modal_kind) reads as 'approval'
2135
+ // so genuine approvals keep auto-approving; only an explicit
2136
+ // 'picker'/'confirm' is excluded here.
2137
+ // (2) structural anchor — a real approval offers an affirmative AND a
2138
+ // decline option (pickApprovalButton finds a positive that isn't a
2139
+ // decline, and hasNegativeApprovalOption confirms a No/Cancel/Deny
2140
+ // is present). A model picker ("1. Default 2. Opus 3. Sonnet")
2141
+ // has no decline, so even an un-migrated picker is caught here.
2142
+ //
2143
+ // Mirrors the SDK v1 detect-status approval heuristic (detect-status.ts).
2144
+ const modalKind = typeof modal?.kind === 'string' ? modal.kind : 'approval';
2145
+ if (modalKind !== 'approval') {
2146
+ // Picker/confirm — leave it for the user; keep the modal surfaced.
2147
+ return autoApproveActive;
2148
+ }
2149
+ const { index: buttonIndex, label: buttonLabel } = pickApprovalButton(buttons, this.provider);
2150
+ if (buttonIndex < 0 || !hasNegativeApprovalOption(buttons)) {
2151
+ // No affirmative matched, or no decline option present (→ not a real
2152
+ // consent prompt, e.g. a picker that slipped past the kind gate).
2153
+ // Surface the modal so the user decides; never pick blindly.
2154
+ return autoApproveActive;
2155
+ }
2156
+ // Modal *identity* signature — the question/button set only, NO volatile
2157
+ // counters. This is what the settle gate tracks: the FSM bumps
2158
+ // approvalEntrySeq on every fresh waiting_approval entry, and a
2159
+ // modal→generating→modal flap (the question line scrolled out of the
2160
+ // captured frame while the button block stays) re-enters and bumps it
2161
+ // again. Folding that seq into the settle signature made the 600ms
2162
+ // settle clock restart on every flap, so the modal never stayed stable
2163
+ // long enough to fire — the gate was never satisfied. Identity excludes
2164
+ // the seq so button/seq flap of the SAME modal keeps one settle clock.
2165
+ const modalSignature = [
2166
+ typeof modal?.message === 'string' ? modal.message.trim() : '',
2167
+ buttons.join('|'),
2168
+ buttonIndex,
2169
+ ].join('::');
2170
+ // Busy-window re-entry guard still needs the seq: two DISTINCT
2171
+ // back-to-back approvals can carry identical message/buttons (common
2172
+ // with claude-cli). Without the seq their busy signatures collide and
2173
+ // the 5s busy-window guard below would swallow the second auto-approve,
2174
+ // leaving it stuck. The seq is bumped by the FSM on every fresh
2175
+ // waiting_approval entry, so a new approval always yields a new busy
2176
+ // signature and fires through.
2177
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2178
+ ? adapterStatus.approvalEntrySeq
2179
+ : 0;
2180
+ const busySignature = `${approvalEntrySeq}::${modalSignature}`;
2181
+ // Already fired for this exact modal entry and still inside the busy
2182
+ // window — nothing to do (re-entry guard for repeated snapshots of one
2183
+ // modal).
2184
+ if (this.autoApproveBusy && busySignature === this.lastAutoApprovalSignature) {
2185
+ return autoApproveActive;
2186
+ }
2187
+
2188
+ // Settle gate: only fire once this modal identity has been stable for
2189
+ // AUTO_APPROVE_SETTLE_MS. A still-streaming prompt mutates its
2190
+ // message/buttons each frame → new identity → clock restarts, so we
2191
+ // never approve a half-rendered prompt (the "resolves too fast" bug).
2192
+ if (modalSignature !== this.pendingAutoApprovalSignature) {
2193
+ this.pendingAutoApprovalSignature = modalSignature;
2194
+ this.pendingAutoApprovalSince = now;
2195
+ }
2196
+ const settledForMs = now - this.pendingAutoApprovalSince;
2197
+ if (settledForMs < CliProviderInstance.AUTO_APPROVE_SETTLE_MS) {
2198
+ // Not yet settled. Arm a timer to re-check after the remaining quiet
2199
+ // window — the PTY may go silent once the prompt finishes painting,
2200
+ // so there is no guaranteed status-change frame to re-drive us.
2201
+ if (this.autoApproveSettleTimer) clearTimeout(this.autoApproveSettleTimer);
2202
+ this.autoApproveSettleTimer = setTimeout(() => {
2203
+ this.autoApproveSettleTimer = null;
2204
+ this.recheckAutoApproveSettled();
2205
+ }, CliProviderInstance.AUTO_APPROVE_SETTLE_MS - settledForMs + 20);
2206
+ return autoApproveActive;
2207
+ }
2208
+
2209
+ // Settled — fire the approve key.
2210
+ if (this.autoApproveSettleTimer) { clearTimeout(this.autoApproveSettleTimer); this.autoApproveSettleTimer = null; }
2211
+ this.autoApproveBusy = true;
2212
+ this.lastAutoApprovalSignature = busySignature;
2213
+ this.pendingAutoApprovalSignature = '';
2214
+ this.pendingAutoApprovalSince = 0;
2215
+ this.autoApproveInactiveSince = 0;
2216
+ // Fired (resolveModal in flight) — the episode resolved; end the mask-stall clock.
2217
+ this.autoApproveMaskSince = 0;
2218
+ if (this.autoApproveBusyTimer) clearTimeout(this.autoApproveBusyTimer);
2219
+ this.autoApproveBusyTimer = setTimeout(() => {
2220
+ this.autoApproveBusy = false;
2221
+ this.autoApproveBusyTimer = null;
2222
+ this.lastAutoApprovalSignature = '';
2223
+ }, 5000);
2224
+ this.recordAutoApproval(modal?.message, buttonLabel, now);
2225
+ setTimeout(() => {
2226
+ this.adapter.resolveModal(buttonIndex);
2227
+ }, 0);
870
2228
  return autoApproveActive;
871
2229
  }
872
2230
 
2231
+ /**
2232
+ * Re-drive the auto-approve check after the settle quiet window elapses.
2233
+ * The PTY may have gone silent once the approval prompt finished painting,
2234
+ * so no status-change frame is guaranteed to re-enter maybeAutoApproveStatus
2235
+ * — this timer-driven re-check picks up the now-settled modal and fires.
2236
+ * Deliberately lighter than detectStatusTransition(): it only re-evaluates
2237
+ * the approval decision; the next real PTY frame refreshes visible status.
2238
+ */
2239
+ private recheckAutoApproveSettled(): void {
2240
+ try {
2241
+ // APPROVAL Defect-C (auto-approve gap): re-probe with a LIVE parse, not the cached
2242
+ // engine snapshot. This timer is the ONLY re-drive when the PTY goes silent after the
2243
+ // approval prompt finishes painting (its whole reason to exist) — but with
2244
+ // allowParse:false it read only engine.activeModal, which the engine's per-frame settle
2245
+ // pass can leave null/stale when the modal arrived between writes. The re-check then saw
2246
+ // no modal and never fired, so the delegated worker's transient/quiet approval was missed
2247
+ // and the coordinator had to step in with a manual mesh_approve. allowParse:true makes
2248
+ // getStatus re-run runDetectStatus/runParseApproval on the current screen buffer (the same
2249
+ // live re-probe the coordinator's resolveAction path uses), recovering the modal so
2250
+ // auto-approve fires on its own. The half-rendered-frame guard (buttons.length===0) and
2251
+ // the settle gate in maybeAutoApproveStatus still protect against firing on a partial modal.
2252
+ const adapterStatus = this.adapter.getStatus({ allowParse: true });
2253
+ this.maybeAutoApproveStatus(adapterStatus, Date.now());
2254
+ } catch { /* adapter gone / transient — next frame retries */ }
2255
+ }
2256
+
2257
+ /**
2258
+ * Emit the queue-claim agent:ready event at most once per session. Both the
2259
+ * boot-time starting→idle one-shot and the fsmReadySeen re-arm call this; the
2260
+ * agentReadyEmitted guard ensures the second caller is a no-op so a worker is
2261
+ * never claimed twice and a queued task is never double-dispatched.
2262
+ */
2263
+ private emitAgentReadyOnce(chatTitle: string, now: number): void {
2264
+ if (this.agentReadyEmitted) return;
2265
+ this.agentReadyEmitted = true;
2266
+ this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2267
+ }
2268
+
2269
+ /**
2270
+ * GENERATING-BOUNDARY synthetic emit for a first turn that started AND finished
2271
+ * inside the startup-grace window without the FSM ever observing a 'generating'
2272
+ * frame (an unobservably-fast turn). Synthesizes the agent:generating_started +
2273
+ * agent:generating_completed pair so the mesh coordinator learns the worker went
2274
+ * idle. Returns true iff it synthesized.
2275
+ *
2276
+ * Two callers share this defense line:
2277
+ * - 'startup_grace_fast_collapse' — the starting→idle transition (the FSM whose
2278
+ * spec lacks/hadn't-synced the starting→busy edge collapses starting→idle
2279
+ * directly, with no intervening 'generating' frame).
2280
+ * - 'startup_grace_idle_turn_collapse' — the idle→idle no-status-change poll
2281
+ * (the launch settle already drained starting→idle BEFORE the first turn, so
2282
+ * the turn runs+completes while status stays 'idle' the whole time and
2283
+ * detectStatusTransition never re-enters its change block — the live rc.403
2284
+ * Probe1 miss).
2285
+ *
2286
+ * False-positive safety (must NOT fire on a benign boot): currentTurnTaskId is
2287
+ * set ONLY by onTurnStarted (a real turn STARTED this boot) and persists past
2288
+ * completion, so it excludes a true idle boot (null) and a queued-pending first
2289
+ * turn that only runs after grace (onTurnStarted not yet called → null).
2290
+ * !hasAdapterPendingResponse() excludes a turn still mid-flight. generating
2291
+ * never armed (generatingStartedAt===0 && !generatingDebouncePending) means the
2292
+ * whole idle→busy→idle never happened for this turn. The once-per-turn guard
2293
+ * (fastCollapseSynthesizedTaskId) keeps the re-polled idle-stayed caller from
2294
+ * re-emitting every poll.
2295
+ */
2296
+ private maybeSynthesizeStartupGraceCollapse(
2297
+ chatTitle: string,
2298
+ now: number,
2299
+ reason: 'startup_grace_fast_collapse' | 'startup_grace_idle_turn_collapse',
2300
+ ): boolean {
2301
+ const startedTurnTaskId = typeof (this.adapter as any)?.currentTurnTaskId === 'string'
2302
+ && (this.adapter as any).currentTurnTaskId.trim()
2303
+ ? (this.adapter as any).currentTurnTaskId as string
2304
+ : undefined;
2305
+ const fastCollapsed = !!startedTurnTaskId
2306
+ && !this.hasAdapterPendingResponse()
2307
+ && !this.generatingStartedAt
2308
+ && !this.generatingDebouncePending;
2309
+ if (!fastCollapsed) return false;
2310
+ // Once-per-turn: the idle-stayed caller re-polls steadily while the session
2311
+ // sits idle; without this guard it would re-emit the pair every poll.
2312
+ if (this.fastCollapseSynthesizedTaskId === startedTurnTaskId) return false;
2313
+
2314
+ let fcFinalSummary: string | undefined;
2315
+ let fcEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2316
+ try {
2317
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2318
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2319
+ fcEvidenceSource = evidence.source;
2320
+ fcFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2321
+ } catch { /* best-effort */ }
2322
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true || fcEvidenceSource === 'external-native') && !fcFinalSummary;
2323
+ // Mirror the short-generating idle path's suppression: a provider that
2324
+ // requires a final assistant (or external-native history) with NO confirmed
2325
+ // summary and NO mesh context emits nothing — the session is idle with no
2326
+ // confirmed turn, matching startup-blip semantics. With mesh context we still
2327
+ // emit so the coordinator can apply its own timeout/retry logic. Left UNMARKED
2328
+ // so a later poll can retry once the transcript's final assistant lands.
2329
+ const hasMeshContext = !!(this.settings.meshNodeFor || this.settings.meshActiveTaskId || this.settings.launchedByCoordinator);
2330
+ if (missingEvidence && !hasMeshContext) {
2331
+ LOG.info('CLI', `[${this.type}] ${reason} suppressed: missing final assistant evidence, no mesh context (source=${fcEvidenceSource})`);
2332
+ return false;
2333
+ }
2334
+ // Mark BEFORE emitting so a re-entrant poll cannot double-fire.
2335
+ this.fastCollapseSynthesizedTaskId = startedTurnTaskId;
2336
+ LOG.info('CLI', `[${this.type}] ${reason}: synthesizing started+completed (taskId=${startedTurnTaskId} source=${fcEvidenceSource} hadFinalSummary=${!!fcFinalSummary})`);
2337
+ // Retroactive started so the started→completed pair (and the chat bubble) is
2338
+ // well-formed; pushEvent stamps the per-turn taskId for CANON-B ack.
2339
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now });
2340
+ if (this.isMeshWorkerSession()) {
2341
+ traceMeshEventStage('fired', this.meshTraceCtx(), `${reason} (source=${fcEvidenceSource})`);
2342
+ }
2343
+ this.pushEvent({
2344
+ event: 'agent:generating_completed',
2345
+ chatTitle,
2346
+ duration: 0,
2347
+ timestamp: now,
2348
+ finalSummary: fcFinalSummary,
2349
+ completionDiagnostic: {
2350
+ reason,
2351
+ finalAssistantEvidenceSource: fcEvidenceSource,
2352
+ ...(missingEvidence ? { blockReason: 'missing_final_assistant' } : {}),
2353
+ },
2354
+ });
2355
+ return true;
2356
+ }
2357
+
873
2358
  private detectStatusTransition(): void {
874
2359
  const now = Date.now();
875
2360
  // Status-change handling is a hot path: PTY output can fire it many times
876
2361
  // during long-running CLI sessions. Keep this path on adapter-owned light
877
2362
  // state only; rich provider parsing is reserved for getState/read_chat.
878
2363
  const adapterStatus = this.adapter.getStatus({ allowParse: false });
2364
+ const adapterProviderSessionId = normalizeProviderSessionId(
2365
+ this.provider,
2366
+ typeof adapterStatus?.providerSessionId === 'string' ? adapterStatus.providerSessionId : '',
2367
+ );
2368
+ if (adapterProviderSessionId) {
2369
+ this.promoteProviderSessionId(adapterProviderSessionId);
2370
+ }
879
2371
  const parsedStatus = null;
880
2372
  const rawStatus = adapterStatus.status;
881
2373
  const autoApproveActive = this.maybeAutoApproveStatus(adapterStatus, now);
882
- const newStatus = autoApproveActive ? 'generating' : rawStatus;
883
- const dirName = this.workingDir.split('/').filter(Boolean).pop() || 'session';
2374
+ // During the autoApproveBusy window (2s after firing approval key), the PTY
2375
+ // can briefly report 'idle' before the next generating phase starts. Treat that
2376
+ // transient idle as 'generating' to suppress a spurious agent:generating_completed
2377
+ // push notification. The adapter's status is otherwise authoritative — native
2378
+ // transcript shape does NOT override the FSM's busy/idle decision.
2379
+ const autoApproveHoldIdle = this.autoApproveBusy && rawStatus === 'idle';
2380
+ const newStatus = autoApproveActive || autoApproveHoldIdle ? 'generating' : rawStatus;
2381
+ const dirName = workingDirBasename(this.workingDir);
884
2382
  const chatTitle = `${this.provider.name} · ${dirName}`;
885
2383
  const partial = this.adapter.getPartialResponse();
2384
+ // Liveness fingerprint for the no-progress watchdog. The parsed
2385
+ // assistant buffer (`partial`) alone goes static while a tool/build runs
2386
+ // — the assistant emits no tokens even though the PTY is actively
2387
+ // printing tool output — which made the watchdog false-fire a "stuck"
2388
+ // alert mid-turn. Fold in the adapter's raw-activity timestamps so any
2389
+ // visible terminal progress (lastScreenChangeAt) or raw PTY byte
2390
+ // (lastOutputAt) keeps the fingerprint moving. The watchdog then only
2391
+ // survives a genuine stall where nothing at all is happening.
886
2392
  const progressFingerprint = newStatus === 'generating'
887
- ? `${partial || ''}`.slice(-2000)
2393
+ ? `${`${partial || ''}`.slice(-2000)}::scr=${adapterStatus.lastScreenChangeAt ?? 0}::out=${adapterStatus.lastOutputAt ?? 0}`
888
2394
  : undefined;
889
2395
 
890
2396
  const previousStatus = this.lastStatus;
891
2397
  if (newStatus !== this.lastStatus) {
892
2398
  LOG.info('CLI', `[${this.type}] status: ${this.lastStatus} → ${newStatus}`);
893
- if (this.lastStatus === 'idle' && newStatus === 'generating') {
2399
+ // GENERATING-MISSING (win32 fresh-worktree first-turn): a freshly-launched session
2400
+ // is in 'starting' until its startup-grace settles to idle. When the FIRST inject
2401
+ // lands inside that grace window, the adapter can report status DIRECTLY
2402
+ // starting → generating without an intervening 'idle' frame for
2403
+ // detectStatusTransition() to observe. Previously only the idle→generating arm
2404
+ // armed the bookkeeping, so a starting→generating frame fell straight through to the
2405
+ // bare `this.lastStatus = newStatus` update: generatingStartedAt stayed 0 and no
2406
+ // generating_started was queued. The fast turn's generating→idle completion was then
2407
+ // suppressed by the startup-blip guard below (generatingStartedAt===0 &&
2408
+ // !generatingDebouncePending) — so NO generating_started AND NO generating_completed
2409
+ // ever fired and the mesh coordinator never learned the worker went idle.
2410
+ //
2411
+ // We extend the idle→generating arm to also fire on starting→generating, BUT ONLY
2412
+ // when a real turn is in flight. The adapter script can also report 'generating' from
2413
+ // pure startup PTY noise (no task dispatched) — antigravity/codex/hermes-cli all
2414
+ // exercise that benign starting→generating→idle blip, which must NOT emit a
2415
+ // completion (see "startup-phase spurious completion suppression" tests).
2416
+ // hasAdapterPendingResponse() is the discriminator: a genuine inject sets the
2417
+ // adapter's isWaitingForResponse / currentTurnScope (or leaves a partial response),
2418
+ // whereas startup repaint noise leaves all of them empty. So an armed
2419
+ // starting→generating means "the worker actually started its first turn", and a
2420
+ // bare one stays a suppressed blip via the existing fall-through.
2421
+ const startingToGeneratingWithActiveTurn = this.lastStatus === 'starting'
2422
+ && newStatus === 'generating'
2423
+ && this.hasAdapterPendingResponse();
2424
+ if (((this.lastStatus === 'idle' && newStatus === 'generating') || startingToGeneratingWithActiveTurn)) {
2425
+ // If a completion event is already pending and the turn has ended
2426
+ // (generatingStartedAt===0), the PTY is painting its prompt area
2427
+ // after completing. Ignore this blip — do not cancel the pending
2428
+ // completion and do not advance lastStatus to generating. (On a true
2429
+ // starting→generating the session is fresh: completedDebouncePending is
2430
+ // null, so this blip guard is a no-op and we arm normally below.)
2431
+ if (this.completedDebouncePending && this.generatingStartedAt === 0) {
2432
+ LOG.debug('CLI', `[${this.type}] ignoring post-completion PTY generating blip (generatingStartedAt=0)`);
2433
+ return;
2434
+ }
894
2435
  this.suppressIdleHistoryReplay = false;
895
2436
  // Cancel any pending completed event (multi-step: idle→generating resume)
896
2437
  if (this.completedDebouncePending) {
897
- LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating)`);
2438
+ LOG.info('CLI', `[${this.type}] cancelled pending completed (resumed generating) generatingStartedAt=${this.generatingStartedAt} isWaitingForResponse=${!!(this.adapter as any)?.isWaitingForResponse}`);
898
2439
  if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
899
2440
  this.completedDebouncePending = null;
900
2441
  }
901
2442
 
902
2443
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2444
+ // FALSE-IDLE continuity: entering a busy phase invalidates any
2445
+ // completedDebouncePending armed earlier in this settle window.
2446
+ this.busyEpoch++;
903
2447
  // Defer the generating_started event — if idle comes back within 3s,
904
2448
  // the whole started→completed pair was a false positive from PTY noise
905
2449
  if (this.generatingDebounceTimer) clearTimeout(this.generatingDebounceTimer);
@@ -924,12 +2468,36 @@ export class CliProviderInstance implements ProviderInstance {
924
2468
  this.completedDebouncePending = null;
925
2469
 
926
2470
  if (!this.generatingStartedAt) this.generatingStartedAt = now;
2471
+ // FALSE-IDLE continuity: waiting_approval is a busy phase (the agent
2472
+ // resumes into it), so bump the epoch too — the completedDebouncePending
2473
+ // cancel above covers the currently-armed pending, and the epoch covers
2474
+ // a pending that re-arms and flushes across this same valley.
2475
+ this.busyEpoch++;
927
2476
  const modal = adapterStatus.activeModal;
928
2477
  LOG.info('CLI', `[${this.type}] approval modal: "${modal?.message?.slice(0, 80) ?? 'none'}"`);
929
- // Only push event if not already in waiting_approval (prevent flood from rapid cycles)
930
- const approvalCooldown = 5000;
931
- if (this.lastStatus !== 'waiting_approval' && (!this.lastApprovalEventAt || now - this.lastApprovalEventAt > approvalCooldown)) {
932
- this.lastApprovalEventAt = now;
2478
+ // Include the FSM's approval entry seq, mirroring the auto-approve
2479
+ // path (maybeAutoApproveStatus) and resolveModal's sameEntryReResolve
2480
+ // guard. Two distinct back-to-back approvals can carry identical
2481
+ // message/buttons (very common with claude-cli's "Allow Bash
2482
+ // command?"). Without the seq their fingerprints collide and the dedup
2483
+ // below silently drops the second waiting_approval event — it is never
2484
+ // emitted, so it cannot even land in the pending inbox for a later
2485
+ // read_chat reconcile to recover. The seq is bumped by the FSM on every
2486
+ // fresh waiting_approval entry, so a new approval always yields a new
2487
+ // fingerprint and emits.
2488
+ const approvalEntrySeq = typeof adapterStatus?.approvalEntrySeq === 'number'
2489
+ ? adapterStatus.approvalEntrySeq
2490
+ : 0;
2491
+ const approvalFingerprint = JSON.stringify({
2492
+ message: typeof modal?.message === 'string' ? modal.message.trim() : '',
2493
+ buttons: Array.isArray(modal?.buttons) ? modal.buttons.map((button: unknown) => String(button).trim()) : [],
2494
+ seq: approvalEntrySeq,
2495
+ });
2496
+ // PTY redraws repeat the same modal content; fingerprint dedup prevents duplicate events.
2497
+ // Do NOT also gate on lastStatus: consecutive approvals can arrive waiting_approval→waiting_approval
2498
+ // (e.g. antigravity-cli resolves one prompt and immediately shows the next) and would be silently dropped.
2499
+ if (approvalFingerprint !== this.lastApprovalEventFingerprint) {
2500
+ this.lastApprovalEventFingerprint = approvalFingerprint;
933
2501
  this.appendRuntimeSystemMessage(
934
2502
  this.formatApprovalRequestMessage(modal?.message, modal?.buttons),
935
2503
  `approval_request:${now}`,
@@ -941,22 +2509,266 @@ export class CliProviderInstance implements ProviderInstance {
941
2509
  modalButtons: modal?.buttons,
942
2510
  });
943
2511
  }
2512
+ } else if (newStatus === 'generating' && this.lastStatus === 'waiting_approval') {
2513
+ // Approval resolved and the agent resumed work. Defense-in-depth:
2514
+ // clear the approval emit fingerprint here too (not only on
2515
+ // completion at scheduleCompletedDebounceFlush). A subsequent
2516
+ // waiting_approval with the same modal content as the one just
2517
+ // resolved would otherwise collide with the stale fingerprint and be
2518
+ // dropped. The seq in the fingerprint already separates entries; this
2519
+ // reset is a belt-and-suspenders guard for the re-entry case.
2520
+ this.lastApprovalEventFingerprint = '';
944
2521
  } else if (newStatus === 'idle' && (this.lastStatus === 'generating' || this.lastStatus === 'waiting_approval')) {
945
2522
  const duration = this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : 0;
946
- // If debounce still pending (generating lasted < 1s), cancel both events
2523
+ // Guard: if generatingStartedAt===0 and no debounce pending, the generating phase
2524
+ // was entered from 'starting' state (startup PTY noise), not from a real idle→generating
2525
+ // task dispatch. The idle→generating handler is the only code path that sets
2526
+ // generatingStartedAt and generatingDebouncePending, so both being absent means no
2527
+ // task was ever dispatched. Suppress the spurious completion event and fall through
2528
+ // to a simple lastStatus update.
2529
+ if (!this.generatingStartedAt && !this.generatingDebouncePending) {
2530
+ LOG.debug('CLI', `[${this.type}] suppressed startup-phase generating→idle blip (generatingStartedAt=0, no debounce pending)`);
2531
+ } else
2532
+ // If debounce still pending (generating lasted < 1s), cancel both UI events.
2533
+ // Still emit agent:generating_completed so mesh orchestration can record
2534
+ // task_completed for direct dispatches that complete faster than the debounce.
947
2535
  if (this.generatingDebouncePending) {
948
- LOG.info('CLI', `[${this.type}] suppressed short generating (${now - this.generatingStartedAt}ms)`);
2536
+ // NOTIF Defect-2a: shortDurationMs is the REPORTED turn duration, so it must be
2537
+ // measured from the IMMUTABLE turn start — not generatingStartedAt, which is
2538
+ // reset to 0 on every mid-turn waiting_approval/idle blip (see :1864/1885/2397/
2539
+ // 2503/2521) and re-armed on the next →generating, so a long turn that blipped
2540
+ // would measure only the final 1.5-2.5s sliver. engine.currentTurnStartedAt is
2541
+ // stamped once at onTurnStarted and persists past mid-turn blips until the next
2542
+ // turn starts, so it captures the true turn length. generatingStartedAt remains
2543
+ // the fallback (and the debounce itself stays a pure UI-suppression signal,
2544
+ // decoupled from the reported duration).
2545
+ const { durationMs: shortDurationMs, anchor: durationAnchor } = computeTurnAnchoredDurationMs(
2546
+ (this.adapter as any)?.currentTurnStartedAt,
2547
+ this.generatingStartedAt,
2548
+ now,
2549
+ );
2550
+ LOG.info('CLI', `[${this.type}] suppressed short generating (${shortDurationMs}ms, anchor=${durationAnchor})`);
949
2551
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2552
+ // Emit completion for mesh task association even though the UI generating
2553
+ // started/completed pair is suppressed (too short for visible UI update).
2554
+ let shortFinalSummary: string | undefined;
2555
+ let shortEvidenceSource: CompletionFinalAssistantEvidence['source'] = 'unavailable';
2556
+ try {
2557
+ const parsedMessages = this.adapter?.getScriptParsedStatus()?.messages;
2558
+ const evidence = this.completionFinalAssistantEvidence(parsedMessages);
2559
+ shortEvidenceSource = evidence.source;
2560
+ shortFinalSummary = extractFinalSummaryFromMessages(evidence.messages as any);
2561
+ } catch { /* best-effort */ }
2562
+ // If a real response is confirmed, retroactively emit started so the chat
2563
+ // bubble appears even though the debounce suppressed the original event.
2564
+ if (shortFinalSummary) {
2565
+ this.pushEvent({ event: 'agent:generating_started', chatTitle, timestamp: now - shortDurationMs });
2566
+ }
2567
+ // FALSE-IDLE short-gen settle: snapshot the producing turn's start + taskId NOW,
2568
+ // before `generatingStartedAt` is reset below — the settle-arm path (mesh sessions,
2569
+ // see the mesh branch further down) needs the same turn anchor the normal
2570
+ // completedDebounce branch captures, and generatingStartedAt is the fallback for it.
2571
+ const shortEngineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2572
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2573
+ ? (this.adapter as any).currentTurnStartedAt as number
2574
+ : 0;
2575
+ const shortTurnStartedAt = shortEngineTurnStart || this.generatingStartedAt || 0;
2576
+ const shortTaskId = this.completingTurnTaskId();
950
2577
  this.generatingDebouncePending = null;
951
2578
  this.generatingStartedAt = 0;
2579
+ // FALSE-IDLE short-gen: a short-generating completion with NO transcript
2580
+ // backing at all (shortEvidenceSource === 'unavailable': both the screen parse
2581
+ // AND the external-native transcript failed to yield a final assistant) is just
2582
+ // as unproven as an 'external-native' source that returned no final assistant.
2583
+ // Fold 'unavailable' into the missing-evidence predicate so a zero-evidence dip
2584
+ // (the mid-turn point-sample that triggered this whole false-idle bug) is treated
2585
+ // as weak/held, not fired as a genuine completion. A real shortFinalSummary being
2586
+ // present still clears the gate (the !shortFinalSummary guard is unchanged).
2587
+ const missingEvidence = ((this.provider as any).requiresFinalAssistantBeforeIdle === true
2588
+ || shortEvidenceSource === 'external-native'
2589
+ || shortEvidenceSource === 'unavailable') && !shortFinalSummary;
2590
+ if (missingEvidence) {
2591
+ LOG.warn('CLI', `[${this.type}] short completion missing final assistant evidence (source=${shortEvidenceSource})`);
2592
+ }
2593
+ if (this.isAutonomousMeshSession()) {
2594
+ // FALSE-IDLE short-gen settle (the core fix): for an autonomously-progressing
2595
+ // mesh session (delegated worker OR self-coordinator), the short-generating
2596
+ // branch was a POINT-SAMPLE — a single idle read from getStatus({allowParse:false})
2597
+ // that fires the completion INLINE with zero continuity backing. When the worker
2598
+ // is merely mid-turn (a sub-3s dip between two tool calls), this synchronously
2599
+ // emitted a false agent:generating_completed the coordinator can never correct.
2600
+ //
2601
+ // Route it through the SAME settle + continuity machinery as the normal
2602
+ // completedDebounce branch: arm completedDebouncePending capturing busyEpochAtArm
2603
+ // and lastOutputAtArm, then scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS)
2604
+ // so flushCompletedDebounceIfFinalized() re-verifies CONTINUOUS idle before emitting.
2605
+ // A busy re-entry (busyEpoch bump) or new PTY output within the settle window —
2606
+ // exactly what happens when the worker resumes its next tool call — CANCELS the
2607
+ // false completion. Genuine completions (real final assistant) still emit at the
2608
+ // end of the (short, 4s) settle window; missingEvidence flows through the
2609
+ // finalization block (missing_final_assistant → CANON-C weak/held) rather than
2610
+ // being frozen as a genuine inline fire.
2611
+ this.completedDebouncePending = {
2612
+ chatTitle,
2613
+ duration: Math.round(shortDurationMs / 1000),
2614
+ timestamp: now,
2615
+ firstObservedAt: now,
2616
+ // Short-gen enters from generating→idle (or waiting_approval→idle); the
2617
+ // completedDebounce finalization gate treats previousStatus for its
2618
+ // approval-resolution / inter-approval-valley handling. lastStatus is the
2619
+ // status we transitioned FROM here.
2620
+ previousStatus: this.lastStatus,
2621
+ ...(shortTaskId ? { taskId: shortTaskId } : {}),
2622
+ ...(shortTurnStartedAt ? { turnStartedAt: shortTurnStartedAt } : {}),
2623
+ // FALSE-IDLE continuity: same arm-time snapshots as the normal branch so the
2624
+ // flush guard can prove continuous idle across the settle window.
2625
+ busyEpochAtArm: this.busyEpoch,
2626
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2627
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2628
+ : {}),
2629
+ };
2630
+ LOG.info('CLI', `[${this.type}] short-generating routed through settle window (${shortDurationMs}ms, source=${shortEvidenceSource}, missingEvidence=${missingEvidence}) — arming completedDebouncePending instead of inline fire`);
2631
+ // EVTTRACE: now traces the settle ARM (not an inline fire) for mesh sessions,
2632
+ // so logs show the short-gen path deferring to continuity re-check.
2633
+ if (this.isMeshWorkerSession()) {
2634
+ traceMeshEventStage('arm', this.meshTraceCtx(), `short-generating settle-arm (source=${shortEvidenceSource}, missingEvidence=${missingEvidence})`);
2635
+ }
2636
+ this.scheduleCompletedDebounceFlush(NATIVE_HISTORY_MESH_IDLE_SETTLE_MS);
2637
+ } else if (missingEvidence) {
2638
+ // NON-MESH, missing evidence: suppress the completion event entirely (the
2639
+ // original !hasMeshContext suppression). A genuinely non-mesh session has no
2640
+ // coordinator to notify, and firing a completion with no confirmed final
2641
+ // assistant would just surface an empty/unconfirmed turn. Leave
2642
+ // completedDebouncePending null — the session is now idle with no confirmed
2643
+ // turn, matching the startup-blip suppression semantics. (No EvtTrace: not a
2644
+ // mesh session, so nothing routes to a coordinator.)
2645
+ LOG.info('CLI', `[${this.type}] short completion suppressed: missing final assistant evidence, non-mesh session (source=${shortEvidenceSource})`);
2646
+ } else {
2647
+ // NON-MESH interactive fast-path with a CONFIRMED summary: keep the existing
2648
+ // inline fire. The dashboard UX reason for the short path (a fast turn should
2649
+ // surface its completion promptly without a 4s settle) still holds, and a
2650
+ // non-mesh session has no coordinator to be falsely notified — the false-idle
2651
+ // bug being fixed is specifically the mesh worker/coordinator misfire above.
2652
+ this.pushEvent({
2653
+ event: 'agent:generating_completed',
2654
+ chatTitle,
2655
+ duration: 0,
2656
+ timestamp: now,
2657
+ finalSummary: shortFinalSummary,
2658
+ completionDiagnostic: {
2659
+ reason: 'short_generating_suppressed',
2660
+ shortDurationMs,
2661
+ finalAssistantEvidenceSource: shortEvidenceSource,
2662
+ },
2663
+ });
2664
+ }
952
2665
  } else {
953
2666
  // Debounce completed, then require the rich transcript path that read_chat
954
2667
  // uses to show an idle turn whose last user-facing message is assistant.
955
- this.completedDebouncePending = { chatTitle, duration, timestamp: now, firstObservedAt: now };
956
- this.scheduleCompletedDebounceFlush(3000);
2668
+ this.completedDebouncePending = {
2669
+ chatTitle,
2670
+ duration,
2671
+ timestamp: now,
2672
+ firstObservedAt: now,
2673
+ previousStatus: this.lastStatus,
2674
+ // ARCH-REFACTOR R1: snapshot the completing turn's taskId NOW (sync),
2675
+ // before any follow-up task's flush can start a new turn and move
2676
+ // engine.currentTurnTaskId.
2677
+ ...(this.completingTurnTaskId() ? { taskId: this.completingTurnTaskId() } : {}),
2678
+ // NOTIF Defect-B: snapshot the producing turn's START instant NOW, for the
2679
+ // same reason as taskId — a follow-up turn moves engine.currentTurnStartedAt.
2680
+ // Prefer the engine's per-turn start (set at onTurnStarted, earliest reliable
2681
+ // anchor) and fall back to generatingStartedAt (when generating was observed).
2682
+ ...((() => {
2683
+ const engineTurnStart = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2684
+ && Number.isFinite((this.adapter as any).currentTurnStartedAt)
2685
+ ? (this.adapter as any).currentTurnStartedAt as number
2686
+ : 0;
2687
+ const turnStartedAt = engineTurnStart || this.generatingStartedAt || 0;
2688
+ return turnStartedAt ? { turnStartedAt } : {};
2689
+ })()),
2690
+ // FALSE-IDLE continuity: snapshot the busy epoch + raw PTY output
2691
+ // clock at arm time so the flush guard can prove the session stayed
2692
+ // continuously idle (no busy re-entry, no new PTY output) through the
2693
+ // settle window rather than merely reading 'idle' once at flush.
2694
+ busyEpochAtArm: this.busyEpoch,
2695
+ ...(typeof adapterStatus?.lastOutputAt === 'number' && Number.isFinite(adapterStatus.lastOutputAt)
2696
+ ? { lastOutputAtArm: adapterStatus.lastOutputAt as number }
2697
+ : {}),
2698
+ };
2699
+ const ownsExternalHistory = !!(this.adapter as any)?.chatMessagesOwnedExternally;
2700
+ // (FALSEIDLE-BGCHILD-a) Native-history providers flush immediately (the
2701
+ // transcript is authoritative). For autonomously-progressing mesh sessions,
2702
+ // give the generating→idle transition a short settle window so a background-child
2703
+ // false idle (quiet after a backgrounded test/command while the parent turn
2704
+ // continues) or an inter-approval auto-approve valley gets caught by the resume
2705
+ // guard in flushCompletedDebounceIfFinalized instead of firing an early completion
2706
+ // the coordinator can never correct.
2707
+ //
2708
+ // (FALSE-IDLE self-coordinator settle) The settle window now covers BOTH mesh
2709
+ // worker sessions AND the coordinator's own claude-cli session (meshCoordinatorFor):
2710
+ // isAutonomousMeshSession(). Previously only isMeshWorkerSession() qualified, so a
2711
+ // self-coordinating daemon (worker + coordinator on the same daemon) ran the
2712
+ // coordinator's own turn at flushDelay=0 — no settle window at all — and the
2713
+ // busyEpoch/lastOutputAt continuity guard, being a flush-time point-check, had no
2714
+ // window in which to observe the ~0.5s auto-approve valley. Its mid-turn
2715
+ // "next-step" sentence was flushed as finalSummary. A genuinely non-mesh session
2716
+ // (neither worker nor self-coordinator) still flushes immediately (delay=0), so
2717
+ // no non-mesh behaviour changes; this only ADDS a settle window (strictly
2718
+ // stricter — the guard can only ever CANCEL a pending flush, never emit more).
2719
+ const meshSettleSession = this.isAutonomousMeshSession();
2720
+ const flushDelay = ownsExternalHistory
2721
+ ? (meshSettleSession ? NATIVE_HISTORY_MESH_IDLE_SETTLE_MS : 0)
2722
+ : 3000;
2723
+ LOG.debug('CLI', `[${this.type}] set completedDebouncePending duration=${duration}s ownsExternalHistory=${ownsExternalHistory} meshSettle=${meshSettleSession} flushDelay=${flushDelay}ms generatingStartedAt=${this.generatingStartedAt}`);
2724
+ this.scheduleCompletedDebounceFlush(flushDelay);
957
2725
  }
958
2726
  } else if (newStatus === 'idle' && this.lastStatus === 'starting') {
959
- this.pushEvent({ event: 'agent:ready', chatTitle, timestamp: now });
2727
+ this.emitAgentReadyOnce(chatTitle, now);
2728
+ // GENERATING-BOUNDARY (R4c): stamp the collapse moment ONCE so the
2729
+ // idle-stayed window below is anchored on the startup-grace collapse,
2730
+ // not on boot. Set only the first time so a later starting re-entry
2731
+ // cannot slide the window forward.
2732
+ if (this.startupGraceCollapseAt === null) this.startupGraceCollapseAt = now;
2733
+ // GENERATING-BOUNDARY fast-collapse (R4, win32 startup-grace first turn):
2734
+ // a turn dispatched into the startup-grace window can START and FINISH while
2735
+ // the FSM is still in 'starting'. On a daemon whose claude-cli spec has NOT yet
2736
+ // synced the starting→busy edge (the primary cure lives in the spec's
2737
+ // idle→busy.from), the FSM never reaches 'busy'/generating, so
2738
+ // detectStatusTransition observes starting→idle DIRECTLY with no intervening
2739
+ // 'generating' frame. The idle→generating arm — the only path that sets
2740
+ // generatingStartedAt and arms the completion — never fired, so the completing
2741
+ // turn's agent:generating_completed is never emitted and the mesh coordinator
2742
+ // never learns the worker went idle. Synthesize the started+completed pair here.
2743
+ //
2744
+ // Discriminator (false-positive safe — must NOT fire on a benign boot):
2745
+ // adapter.currentTurnTaskId is set ONLY by onTurnStarted (a real turn STARTED
2746
+ // this boot) and persists past completion, so it cleanly separates the three
2747
+ // non-firing cases — a true idle boot (no turn → null), a queued-pending
2748
+ // first turn that only runs AFTER startup-grace drains the composer (onTurnStarted
2749
+ // not yet called → null; it completes normally later via idle→busy→idle), and a
2750
+ // turn STILL running at the 8s mark (hasAdapterPendingResponse() still true →
2751
+ // excluded so we don't fire a premature mid-turn completion; idle→busy self-
2752
+ // corrects once the FSM reaches idle). We fire only when a turn started AND has
2753
+ // already finished: started-this-boot && !still-in-flight.
2754
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_fast_collapse');
2755
+ } else if (newStatus === 'error') {
2756
+ if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
2757
+ this.generatingDebouncePending = null;
2758
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
2759
+ this.completedDebouncePending = null;
2760
+ this.errorMessage = adapterStatus.errorMessage || this.errorMessage;
2761
+ this.errorReason = (adapterStatus.errorReason as ProviderErrorReason) || this.errorReason;
2762
+ this.pushEvent({
2763
+ event: 'agent:stopped',
2764
+ chatTitle,
2765
+ timestamp: now,
2766
+ finalSummary: adapterStatus.errorMessage || adapterStatus.errorReason || 'Provider reported an error',
2767
+ completionDiagnostic: {
2768
+ reason: adapterStatus.errorReason || 'provider_error',
2769
+ errorMessage: adapterStatus.errorMessage || undefined,
2770
+ },
2771
+ });
960
2772
  } else if (newStatus === 'stopped') {
961
2773
  // Cancel any pending debounce
962
2774
  if (this.generatingDebounceTimer) { clearTimeout(this.generatingDebounceTimer); this.generatingDebounceTimer = null; }
@@ -968,6 +2780,79 @@ export class CliProviderInstance implements ProviderInstance {
968
2780
  this.lastStatus = newStatus;
969
2781
  }
970
2782
 
2783
+ // GENERATING-BOUNDARY idle-stayed collapse (R4b): the starting→idle
2784
+ // fast-collapse arm above only fires when the FIRST turn itself drives the
2785
+ // starting→idle transition. When the launch settle already drained
2786
+ // starting→idle BEFORE the first turn arrives, the session is already 'idle'
2787
+ // and a turn that runs+completes inside the startup-grace window — too fast
2788
+ // for any poll to observe a 'generating' frame — produces NO status change
2789
+ // at all (idle→idle). detectStatusTransition's change block above is skipped
2790
+ // entirely, so neither the idle→generating arm nor the starting→idle
2791
+ // fast-collapse arm ever runs, and the mesh coordinator never learns the
2792
+ // worker went idle (the live rc.403 Probe1 miss). Catch it here: an
2793
+ // already-idle poll (no status change), still inside the startup-grace
2794
+ // window, where a turn started this boot and has already finished without
2795
+ // ever arming generating. The same false-positive-safe discriminators apply
2796
+ // (currentTurnTaskId set && !pending && generating never armed), plus a
2797
+ // once-per-turn guard since this branch is re-polled while the session sits
2798
+ // idle. Normal turns that DO reach 'busy' set generatingStartedAt and are
2799
+ // excluded; a queued-pending first turn that only runs after grace falls
2800
+ // outside the window and completes normally via idle→busy→idle.
2801
+ //
2802
+ // R4d (the live rc.405 Probe2 miss): R4c anchored the window on the collapse
2803
+ // moment but still measured its END against `now` (the poll/completion time). The
2804
+ // helper only fires once the turn has FINISHED (!hasAdapterPendingResponse()), so
2805
+ // the first eligible poll happens at completion. When the first turn is dispatched
2806
+ // a few seconds after the collapse AND runs for a non-trivial duration, that
2807
+ // completion lands PAST the 12s now-anchored window even though the turn was a
2808
+ // genuine startup-grace first turn (live: collapse→dispatch +5.2s, turn ~11s →
2809
+ // completion at collapse+16.2s > 12s). Anchor the window on when the first turn
2810
+ // STARTED (engine.currentTurnStartedAt, set by onTurnStarted) instead: a turn that
2811
+ // STARTED within the collapse window is a startup-grace first turn no matter how
2812
+ // long it then ran. The now-anchored check is retained as a union so a fast turn
2813
+ // (dispatched+completed quickly within 12s of collapse) keeps firing too; both
2814
+ // close for a much-later turn, preserving the "don't mislabel a late fast turn"
2815
+ // honesty the window exists for.
2816
+ const firstTurnStartedAt = typeof (this.adapter as any)?.currentTurnStartedAt === 'number'
2817
+ ? (this.adapter as any).currentTurnStartedAt as number
2818
+ : 0;
2819
+ const collapsedAt = this.startupGraceCollapseAt;
2820
+ const turnStartedWithinCollapseWindow = collapsedAt !== null
2821
+ && firstTurnStartedAt > 0
2822
+ && firstTurnStartedAt >= collapsedAt
2823
+ && (firstTurnStartedAt - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
2824
+ const nowWithinCollapseWindow = collapsedAt !== null
2825
+ && (now - collapsedAt) < STARTUP_GRACE_IDLE_COLLAPSE_WINDOW_MS;
2826
+ if (
2827
+ newStatus === 'idle'
2828
+ && previousStatus === 'idle'
2829
+ && (turnStartedWithinCollapseWindow || nowWithinCollapseWindow)
2830
+ ) {
2831
+ this.maybeSynthesizeStartupGraceCollapse(chatTitle, now, 'startup_grace_idle_turn_collapse');
2832
+ }
2833
+
2834
+ // Re-arm the queue-claim agent:ready on the FSM's first GENUINE ready.
2835
+ //
2836
+ // The boot-time starting→idle one-shot above is the historical claim
2837
+ // trigger, but it is consumed too early for FSM-spec providers whose
2838
+ // INITIAL state already reports status 'idle' (e.g. antigravity-cli): the
2839
+ // adapter reports idle before maybeMarkReady has fired, so lastStatus
2840
+ // advances starting→idle while the prompt is not yet drawn and the worker
2841
+ // cannot yet claim. Subsequent state-driven idle frames are idle→idle (no
2842
+ // status change), so the one-shot never re-fires and the worker strands its
2843
+ // queued task — the coordinator then relaunch-loops every ~90s.
2844
+ //
2845
+ // The adapter surfaces fsmReadySeen=true exactly when the FSM reaches its
2846
+ // first non-initial idle (the prompt is genuinely up). On that signal we
2847
+ // emit agent:ready once more. emitAgentReadyOnce is idempotent (guarded by
2848
+ // agentReadyEmitted), so providers whose boot one-shot already landed on a
2849
+ // real ready (claude-cli / codex-cli / hermes-cli, which use a startup
2850
+ // grace and whose initial state is not idle) treat this as a no-op — no
2851
+ // double claim, no double task injection.
2852
+ if (newStatus === 'idle' && adapterStatus.fsmReadySeen === true && !this.agentReadyEmitted) {
2853
+ this.emitAgentReadyOnce(chatTitle, now);
2854
+ }
2855
+
971
2856
  this.applyProviderResponse(parsedStatus, {
972
2857
  phase: (newStatus === 'idle' && (previousStatus === 'generating' || previousStatus === 'waiting_approval'))
973
2858
  ? 'turn_completed'
@@ -976,8 +2861,43 @@ export class CliProviderInstance implements ProviderInstance {
976
2861
 
977
2862
  // Monitor check (cooldown based notification, IDE/CLI common)
978
2863
  const agentKey = `${this.type}:cli`;
979
- const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint);
2864
+ // Approval pending is detected from the raw adapter status, not `newStatus`:
2865
+ // auto-approve synthesizes `waiting_approval` → 'generating', which would
2866
+ // otherwise let the no-progress watchdog accumulate the approval wait.
2867
+ const approvalPending = rawStatus === 'waiting_approval';
2868
+ const monitorEvents = this.monitor.check(agentKey, newStatus, now, progressFingerprint, approvalPending);
2869
+ const monitorParsedStatus: any = parsedStatus;
980
2870
  for (const me of monitorEvents) {
2871
+ if (
2872
+ me.type === 'monitor:no_progress'
2873
+ && this.completionHasFinalAssistantMessage(monitorParsedStatus?.messages)
2874
+ && !this.hasAdapterPendingResponse()
2875
+ && !hasNonEmptyCliModalButtons(monitorParsedStatus?.activeModal ?? monitorParsedStatus?.modal)
2876
+ ) {
2877
+ // EVTTRACE: completion fired (no-progress monitor reconciled to completion).
2878
+ if (this.isMeshWorkerSession()) {
2879
+ traceMeshEventStage('fired', this.meshTraceCtx(), 'no_progress_monitor_final_summary');
2880
+ }
2881
+ this.pushEvent({
2882
+ event: 'agent:generating_completed',
2883
+ chatTitle,
2884
+ duration: this.generatingStartedAt ? Math.round((now - this.generatingStartedAt) / 1000) : undefined,
2885
+ timestamp: me.timestamp,
2886
+ finalSummary: extractFinalSummaryFromMessages(monitorParsedStatus?.messages),
2887
+ completionDiagnostic: {
2888
+ providerType: this.type,
2889
+ sessionId: this.instanceId,
2890
+ providerSessionId: this.providerSessionId || null,
2891
+ reconciliationReason: 'no_progress_monitor_final_summary',
2892
+ finalAssistantPresent: true,
2893
+ },
2894
+ });
2895
+ this.generatingStartedAt = 0;
2896
+ // Cancel any pending debounce flush — monitor already fired completion.
2897
+ if (this.completedDebounceTimer) { clearTimeout(this.completedDebounceTimer); this.completedDebounceTimer = null; }
2898
+ this.completedDebouncePending = null;
2899
+ continue;
2900
+ }
981
2901
  this.pushEvent({ event: me.type, agentKey: me.agentKey, message: me.message, elapsedSec: me.elapsedSec, timestamp: me.timestamp });
982
2902
  }
983
2903
  }
@@ -997,15 +2917,61 @@ export class CliProviderInstance implements ProviderInstance {
997
2917
  workspaceName: typeof event.workspaceName === 'string' && event.workspaceName.trim()
998
2918
  ? event.workspaceName
999
2919
  : this.workingDir,
2920
+ // Carry the workspace under BOTH `workspace` and `workspaceName` so the
2921
+ // downstream mesh forward/merge path — which reads `workspace` — can
2922
+ // propagate it to the coordinator snapshot. Without `workspace` the live
2923
+ // event path delivers an empty workspace and the dashboard falls back to
2924
+ // the generic "Terminal (Mesh Node)" title.
2925
+ workspace: typeof event.workspace === 'string' && event.workspace.trim()
2926
+ ? event.workspace
2927
+ : this.workingDir,
1000
2928
  providerSessionId: typeof event.providerSessionId === 'string' && event.providerSessionId.trim()
1001
2929
  ? event.providerSessionId
1002
2930
  : this.providerSessionId,
1003
2931
  };
2932
+ // TASKIDLESS: stamp the mesh task primary key on lifecycle events emitted by
2933
+ // a mesh worker session. The consumer (updateDirectDispatchStatus) was switched
2934
+ // to key on task_id (CANON-B), but the producer never carried it — so every
2935
+ // forwarded metadataEvent.taskId arrived undefined and the coordinator fell back
2936
+ // to a session_id match, which can flip a sibling dispatch row. Surface it here so
2937
+ // updateDirectDispatchStatus hits the exact PK row and the session_id fallback is
2938
+ // never exercised. Non-mesh sessions get no taskId (regression guard) —
2939
+ // isMeshWorkerSession() gates the injection.
2940
+ //
2941
+ // ARCH-REFACTOR R1 (per-turn identity): resolution order is
2942
+ // (1) an explicit taskId already on the event — the debounce-flush completion
2943
+ // path stamps the taskId captured at the generating→idle transition (the
2944
+ // turn that actually produced this completion);
2945
+ // (2) the per-turn binding (engine.currentTurnTaskId) for synchronously-emitted
2946
+ // events whose turn is still the current one;
2947
+ // (3) the legacy session scalar (settings.meshActiveTaskId) as a last-resort
2948
+ // backward-compat alias.
2949
+ // The scalar is last because it is last-write-wins: a second task attaching while
2950
+ // this turn was still running overwrites it, which is the exact NOTIF-MISDELIVER /
2951
+ // TASK-MSG-MISROUTE race this refactor removes.
2952
+ if (this.isMeshWorkerSession()) {
2953
+ const existingTaskId = typeof enrichedEvent.taskId === 'string' && enrichedEvent.taskId.trim()
2954
+ ? enrichedEvent.taskId
2955
+ : undefined;
2956
+ if (!existingTaskId) {
2957
+ const resolved = this.completingTurnTaskId();
2958
+ if (resolved) enrichedEvent.taskId = resolved;
2959
+ }
2960
+ }
1004
2961
  if (this.context?.emitProviderEvent) {
1005
2962
  this.context.emitProviderEvent(enrichedEvent);
1006
- return;
2963
+ } else {
2964
+ this.events.push(enrichedEvent);
2965
+ }
2966
+ // Auto-detach a direct-dispatch mesh assignment once the dispatched
2967
+ // task reaches a terminal state. Leaving meshNodeFor pinned would
2968
+ // route this session's next unrelated turn (a dashboard chat) into
2969
+ // the coordinator as if it were the completion of another task.
2970
+ // We schedule after the emit so the originating coordinator still
2971
+ // observes the completion event with its routing marker intact.
2972
+ if (TERMINAL_MESH_EVENTS.has(event.event) && this.settings.meshActiveTaskId) {
2973
+ try { this.detachMeshAssignment(); } catch { /* best-effort */ }
1007
2974
  }
1008
- this.events.push(enrichedEvent);
1009
2975
  }
1010
2976
 
1011
2977
  private flushEvents(): ProviderEvent[] {
@@ -1022,7 +2988,13 @@ export class CliProviderInstance implements ProviderInstance {
1022
2988
  typeof data.providerSessionId === 'string' ? data.providerSessionId : '',
1023
2989
  );
1024
2990
  if (patchedProviderSessionId) {
1025
- this.promoteProviderSessionId(patchedProviderSessionId);
2991
+ // A provider-response id is authoritative when it carries an
2992
+ // explicit `new_session` marker (the CLI genuinely started a new
2993
+ // conversation). Without that marker it's just an observed id and
2994
+ // must not hijack an existing binding (see promoteProviderSessionId).
2995
+ this.promoteProviderSessionId(patchedProviderSessionId, {
2996
+ authoritative: data.sessionEvent === 'new_session',
2997
+ });
1026
2998
  }
1027
2999
 
1028
3000
  if (data.sessionEvent === 'new_session') {
@@ -1151,6 +3123,37 @@ export class CliProviderInstance implements ProviderInstance {
1151
3123
  return false;
1152
3124
  }
1153
3125
 
3126
+ /** @see ProviderInstance.noteManualInteraction */
3127
+ noteManualInteraction(now = Date.now()): void {
3128
+ this.manualAttendance.note(now);
3129
+ }
3130
+
3131
+ /**
3132
+ * Whether auto-approve should be treated as active *right now* for display
3133
+ * and firing decisions: the configured intent AND the user is not currently
3134
+ * attending this session by hand. When a human is attending, auto-approve is
3135
+ * held so the modal stays visible and they can drive it via the controlbar.
3136
+ * Provider-agnostic — the attendance signal is the command set, never any
3137
+ * CLI-specific modal text.
3138
+ */
3139
+ private autoApproveEffectivelyActive(status: string | undefined, now = Date.now()): boolean {
3140
+ return status === 'waiting_approval'
3141
+ && this.shouldAutoApprove()
3142
+ && !this.manualAttendance.isAttended(now);
3143
+ }
3144
+
3145
+ // STATUS-MISMATCH: true once the current auto-approve episode has been masking
3146
+ // waiting_approval behind `generating` for longer than AUTO_APPROVE_MASK_STALL_MS without
3147
+ // resolving (the settle gate never fired). When stalled, the surface mask must be dropped
3148
+ // so read_chat / mesh_status / the dashboard see the real waiting_approval + modal (and a
3149
+ // coordinator can mesh_approve it). autoApproveMaskSince is maintained by
3150
+ // maybeAutoApproveStatus (driven by getState + the recheck timer during a waiting episode);
3151
+ // this read is side-effect-free so getStatusMetadata can consult it too.
3152
+ private autoApproveMaskStalled(now = Date.now()): boolean {
3153
+ return this.autoApproveMaskSince > 0
3154
+ && now - this.autoApproveMaskSince > CliProviderInstance.AUTO_APPROVE_MASK_STALL_MS;
3155
+ }
3156
+
1154
3157
  private recordAutoApproval(modalMessage?: string, buttonLabel?: string, now = Date.now()): void {
1155
3158
  this.appendRuntimeSystemMessage(
1156
3159
  formatAutoApprovalMessage(modalMessage, buttonLabel),
@@ -1238,7 +3241,7 @@ export class CliProviderInstance implements ProviderInstance {
1238
3241
  receivedAt: normalizedMessage.receivedAt || normalizedMessage.timestamp,
1239
3242
  historyDedupKey: dedupKey,
1240
3243
  }],
1241
- this.adapter.getScriptParsedStatus?.()?.title || this.workingDir.split('/').filter(Boolean).pop() || 'session',
3244
+ this.adapter.getScriptParsedStatus?.()?.title || workingDirBasename(this.workingDir),
1242
3245
  this.instanceId,
1243
3246
  this.providerSessionId,
1244
3247
  );
@@ -1258,12 +3261,28 @@ export class CliProviderInstance implements ProviderInstance {
1258
3261
  index,
1259
3262
  source: 'parsed',
1260
3263
  }));
3264
+ const getRole = (message: ChatMessage): string => typeof message.role === 'string'
3265
+ ? message.role.trim().toLowerCase()
3266
+ : '';
1261
3267
  const runtimeEntries: MergeEntry[] = this.runtimeMessages.map((entry, index) => ({
1262
3268
  message: entry.message,
1263
3269
  index: parsedMessages.length + index,
1264
- source: 'runtime',
3270
+ source: 'runtime' as const,
1265
3271
  runtimeKey: entry.key,
1266
- }));
3272
+ })).filter((entry) => {
3273
+ const meta = entry.message.meta && typeof entry.message.meta === 'object' && !Array.isArray(entry.message.meta)
3274
+ ? entry.message.meta as Record<string, unknown>
3275
+ : {};
3276
+ if (meta.runtimeInputAck !== true) return true;
3277
+ const runtimeText = flattenContent(entry.message.content).replace(/\s+/g, ' ').trim();
3278
+ if (!runtimeText) return false;
3279
+ return !parsedEntries.some((parsedEntry) => {
3280
+ const parsedRole = getRole(parsedEntry.message);
3281
+ if (parsedRole !== 'user' && parsedRole !== 'human') return false;
3282
+ const parsedText = flattenContent(parsedEntry.message.content).replace(/\s+/g, ' ').trim();
3283
+ return parsedText === runtimeText;
3284
+ });
3285
+ });
1267
3286
  const getTime = (message: ChatMessage): number => {
1268
3287
  const value = typeof message.receivedAt === 'number'
1269
3288
  ? message.receivedAt
@@ -1273,9 +3292,6 @@ export class CliProviderInstance implements ProviderInstance {
1273
3292
  return Number.isFinite(value) && value > 0 ? value : 0;
1274
3293
  };
1275
3294
 
1276
- const getRole = (message: ChatMessage): string => typeof message.role === 'string'
1277
- ? message.role.trim().toLowerCase()
1278
- : '';
1279
3295
  const isRuntimeOverlay = (entry: MergeEntry): boolean => {
1280
3296
  if (entry.source !== 'runtime') return false;
1281
3297
  const key = typeof entry.runtimeKey === 'string' ? entry.runtimeKey.trim().toLowerCase() : '';
@@ -1332,16 +3348,34 @@ export class CliProviderInstance implements ProviderInstance {
1332
3348
  return lines.join('\n');
1333
3349
  }
1334
3350
 
1335
- private promoteProviderSessionId(sessionId: string): void {
3351
+ private promoteProviderSessionId(sessionId: string, opts: { authoritative?: boolean } = {}): void {
1336
3352
  const nextSessionId = String(sessionId || '').trim();
1337
3353
  if (!nextSessionId || nextSessionId === this.providerSessionId) return;
1338
3354
 
3355
+ // Sticky binding: once this instance is bound to a provider session,
3356
+ // an *observed* id (one discovered from a status parse or the native
3357
+ // history reader) must NOT hijack the live binding. hermes ≥0.14
3358
+ // spawns a fresh `sessions` row per internal sub-session, so a
3359
+ // newest-wins native read surfaces a different id mid-turn on every
3360
+ // poll; accepting it would re-bind the instance, re-hydrate unbounded
3361
+ // history (daemon saturation) and reset completion detection so the
3362
+ // turn never finalizes. Only an *authoritative* change — the first
3363
+ // bind (no id yet) or an explicit provider `new_session`/resume — may
3364
+ // replace an existing binding. Legitimate resume/new-session paths
3365
+ // pass authoritative:true and are unaffected.
3366
+ if (this.providerSessionId && !opts.authoritative) {
3367
+ LOG.debug('CLI', `[${this.type}] ignoring non-authoritative session id ${nextSessionId} (bound to ${this.providerSessionId})`);
3368
+ return;
3369
+ }
3370
+
1339
3371
  const previousHistorySessionId = this.providerSessionId || this.instanceId;
1340
3372
  const previousProviderSessionId = this.providerSessionId;
1341
3373
  this.providerSessionId = nextSessionId;
1342
3374
  this.historyWriter.promoteHistorySession(this.type, previousHistorySessionId, nextSessionId);
1343
3375
  this.historyWriter.writeSessionStart(this.type, nextSessionId, this.workingDir, this.instanceId);
1344
- this.restorePersistedHistoryFromCurrentSession();
3376
+ if (this.shouldHydrateExistingProviderHistory()) {
3377
+ this.restorePersistedHistoryFromCurrentSession();
3378
+ }
1345
3379
  this.adapter.updateRuntimeMeta({ providerSessionId: nextSessionId });
1346
3380
  this.onProviderSessionResolved?.({
1347
3381
  instanceId: this.instanceId,
@@ -1354,13 +3388,39 @@ export class CliProviderInstance implements ProviderInstance {
1354
3388
  LOG.info('CLI', `[${this.type}] discovered provider session id: ${nextSessionId}`);
1355
3389
  }
1356
3390
 
1357
- private syncCanonicalSavedHistoryIfNeeded(): boolean {
3391
+ private shouldHydrateExistingProviderHistory(): boolean {
3392
+ return this.launchMode === 'resume' || this.launchMode === 'manual';
3393
+ }
3394
+
3395
+ private shouldSuppressFreshLaunchStartupReplay(parsedMessages: unknown[], parsedStatus: any, adapterStatus: any, parsedProviderSessionId = ''): boolean {
3396
+ if (this.launchMode !== 'new') return false;
3397
+ if (this.providerSessionId) return false;
3398
+ if (!Array.isArray(parsedMessages) || parsedMessages.length === 0) return false;
3399
+ if (!isIdleStatus(adapterStatus?.status) || !isIdleStatus(parsedStatus?.status)) return false;
3400
+ if (parsedProviderSessionId) return true;
3401
+
3402
+ const newestMessageAt = parsedMessages.reduce<number>((newest, message) => Math.max(newest, getMessageTime(message)), 0);
3403
+
3404
+ // Untimestamped idle parser output during a fresh launch is usually the
3405
+ // provider's last workspace transcript before a new turn exists.
3406
+ return newestMessageAt === 0;
3407
+ }
3408
+
3409
+ private syncCanonicalSavedHistoryIfNeeded(options: { full?: boolean } = {}): boolean {
1358
3410
  if (!this.providerSessionId) return false;
1359
- const canonicalHistory = this.provider.canonicalHistory;
3411
+ const canonicalHistory = this.provider.nativeHistory;
1360
3412
  if (!canonicalHistory) return false;
1361
3413
 
3414
+ // Per-status-report hydration reads only a bounded tail (snapshot needs at
3415
+ // most the newest 60). The once-per-resume restore path passes full:true
3416
+ // because seedSessionHistory needs the COMPLETE transcript to seed dedup
3417
+ // state. The read-cache key encodes the window so the bounded and full
3418
+ // reads don't share/clobber each other's 2s cache entry.
3419
+ const limit = options.full ? Number.MAX_SAFE_INTEGER : STATUS_HYDRATION_TAIL_LIMIT;
3420
+ const windowTag = options.full ? 'full' : `tail:${STATUS_HYDRATION_TAIL_LIMIT}`;
3421
+
1362
3422
  if (isNativeSourceCanonicalHistory(canonicalHistory)) {
1363
- const cacheKey = [this.type, this.providerSessionId, this.workingDir].join('\0');
3423
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, windowTag].join('\0');
1364
3424
  const now = Date.now();
1365
3425
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1366
3426
  return true;
@@ -1373,7 +3433,7 @@ export class CliProviderInstance implements ProviderInstance {
1373
3433
  historySessionId: this.providerSessionId,
1374
3434
  workspace: this.workingDir,
1375
3435
  offset: 0,
1376
- limit: Number.MAX_SAFE_INTEGER,
3436
+ limit,
1377
3437
  historyBehavior: this.provider.historyBehavior,
1378
3438
  scripts: this.provider.scripts as any,
1379
3439
  });
@@ -1390,7 +3450,7 @@ export class CliProviderInstance implements ProviderInstance {
1390
3450
  }
1391
3451
 
1392
3452
  try {
1393
- const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror'].join('\0');
3453
+ const cacheKey = [this.type, this.providerSessionId, this.workingDir, canonicalHistory.mode || 'materialized-mirror', windowTag].join('\0');
1394
3454
  const now = Date.now();
1395
3455
  if (cacheKey === this.lastNativeSourceCanonicalCacheKey && now - this.lastNativeSourceCanonicalCheckAt < 2_000) {
1396
3456
  return true;
@@ -1401,7 +3461,14 @@ export class CliProviderInstance implements ProviderInstance {
1401
3461
  if (!materializeProviderNativeHistory(this.type, canonicalHistory, this.providerSessionId, this.workingDir, this.provider.scripts as any)) {
1402
3462
  return false;
1403
3463
  }
1404
- const restoredHistory = readChatHistory(this.type, 0, Number.MAX_SAFE_INTEGER, this.providerSessionId, 0, this.provider.historyBehavior);
3464
+ // Bounded by default: the per-status-report path only needs the newest
3465
+ // STATUS_HYDRATION_TAIL_LIMIT messages because the snapshot caps
3466
+ // activeChat.messages to the last 60 (status/normalize.ts) and loads
3467
+ // the rest lazily via read_chat on subscribe. The once-per-resume
3468
+ // restore path passes full:true so seedSessionHistory still sees the
3469
+ // COMPLETE transcript for prefix-dedup seeding. readChatHistory serves
3470
+ // a bounded limit as an O(tail) read.
3471
+ const restoredHistory = readChatHistory(this.type, 0, limit, this.providerSessionId, 0, this.provider.historyBehavior);
1405
3472
  this.lastPersistedHistoryMessages = restoredHistory.messages.map((message) => ({
1406
3473
  role: message.role,
1407
3474
  content: message.content,
@@ -1417,10 +3484,13 @@ export class CliProviderInstance implements ProviderInstance {
1417
3484
 
1418
3485
  private restorePersistedHistoryFromCurrentSession(): void {
1419
3486
  if (!this.providerSessionId) return;
1420
- this.syncCanonicalSavedHistoryIfNeeded();
1421
- const restoredHistory = isNativeSourceCanonicalHistory(this.provider.canonicalHistory)
3487
+ // Restore is the once-per-resume seeding path: it needs the COMPLETE
3488
+ // transcript so seedSessionHistory can prime dedup state. Pass full so the
3489
+ // hydration read is unbounded here (and only here).
3490
+ this.syncCanonicalSavedHistoryIfNeeded({ full: true });
3491
+ const restoredHistory = isNativeSourceCanonicalHistory(this.provider.nativeHistory)
1422
3492
  ? readProviderChatHistory(this.type, {
1423
- canonicalHistory: this.provider.canonicalHistory,
3493
+ canonicalHistory: this.provider.nativeHistory,
1424
3494
  historySessionId: this.providerSessionId,
1425
3495
  workspace: this.workingDir,
1426
3496
  offset: 0,