@adhdev/daemon-core 0.9.82-rc.373 → 0.9.82-rc.375

package/src/providers/cli-provider-instance.ts

@@ -102,6 +102,24 @@ type ExternalTranscriptProbe = {
 
 const COMPLETED_FINALIZATION_RETRY_MS = 1000;
 const COMPLETED_FINALIZATION_MAX_WAIT_MS = 30_000;
+// (FALSEIDLE-BGCHILD-a) Minimum generating→idle settle window for native-history mesh worker
+// sessions. Native-history providers (e.g. claude-cli) normally flush the completion with
+// flushDelay=0 — the transcript is authoritative, so there is no reason to wait. But a worker
+// turn that spawns a BACKGROUND child (e.g. `npm test &`, a backgrounded Bash tool) can paint
+// a burst of child output, fall quiet, and have the screen parser read a PRIOR/intermediate
+// standard assistant as if the turn were done — firing a false idle while the agent is in fact
+// still generating (e.g. mid-commit). With flushDelay=0 there is no window for the resume guard
+// in flushCompletedDebounceIfFinalized (latestVisibleStatus !== 'idle' → cancel) to observe the
+// agent picking the turn back up. A short non-zero settle window restores that resume guard for
+// mesh workers without delaying genuinely-finished turns beyond this bound. Scoped to mesh
+// worker sessions so interactive native-history sessions keep the immediate flush.
+const NATIVE_HISTORY_MESH_IDLE_SETTLE_MS = 1500;
+// TASKBUBBLE-DUP: window during which an identical user-input ack (same trimmed
+// content on the same instance) is treated as a redelivery of one dispatch and
+// suppressed from the chat transcript. Matches the coordinator-side
+// DUPLICATE_DISPATCH_WINDOW_MS (mesh-tools) so the daemon's bubble-level guard
+// covers the same retry horizon as the MCP-level dispatch dedup.
+const USER_INPUT_ACK_DEDUP_WINDOW_MS = 60_000;
 
 /** Events that signal a dispatched mesh task has reached a terminal state.
  *  Detach the mesh assignment after emitting one of these so the worker's
@@ -431,6 +449,14 @@ export class CliProviderInstance implements ProviderInstance {
     private runtimeMessages: Array<{ key: string; message: ChatMessage }> = [];
     private lastPersistedHistoryMessages: PersistableCliHistoryMessage[] = [];
     private lastAcknowledgedUserInputAt = 0;
+    // TASKBUBBLE-DUP: per-content last-ack timestamps so the same dispatched
+    // prompt acked twice in quick succession (the worker buffers the first
+    // send during bootstrap/busy, then a redelivery — dispatch-confirm-timeout
+    // requeue or a reconcile re-dispatch — fires a SECOND send_chat before the
+    // outbound queue drains) collapses to ONE user bubble. Keyed on the trimmed
+    // content; an entry older than USER_INPUT_ACK_DEDUP_WINDOW_MS is treated as
+    // a fresh, intentional resend and is NOT suppressed.
+    private recentUserInputAcks = new Map<string, number>();
     private lastNativeSourceCanonicalCheckAt = 0;
     private lastNativeSourceCanonicalCacheKey: string | undefined = undefined;
     private cachedSqliteDb: {
@@ -1056,7 +1082,31 @@ export class CliProviderInstance implements ProviderInstance {
         if (!content) return;
 
         const receivedAt = Date.now();
+
+        // TASKBUBBLE-DUP: collapse a redelivered dispatch to one bubble. A single
+        // mesh_send_task can reach this instance as TWO send_chat calls when the
+        // first injection is buffered during bootstrap/busy and a retry (dispatch-
+        // confirm-timeout requeue, or a reconcile re-dispatch) fires before the
+        // outbound queue drains. The previous dedupKey hashed receivedAt, so the
+        // two acks produced different keys and BOTH bubbled. Suppress an identical
+        // content ack seen within USER_INPUT_ACK_DEDUP_WINDOW_MS; a later resend of
+        // the same text (beyond the window) is a genuine new turn and still shows.
+        const ackContentKey = shortHash(`${this.instanceId}:${content}`, 24);
+        const lastAckAt = this.recentUserInputAcks.get(ackContentKey);
+        if (lastAckAt !== undefined && receivedAt - lastAckAt <= USER_INPUT_ACK_DEDUP_WINDOW_MS) {
+            // Refresh the timestamp so a steady stream of redeliveries keeps
+            // collapsing, and prune stale entries to bound the map size.
+            this.recentUserInputAcks.set(ackContentKey, receivedAt);
+            this.pruneRecentUserInputAcks(receivedAt);
+            return;
+        }
+        this.recentUserInputAcks.set(ackContentKey, receivedAt);
+        this.pruneRecentUserInputAcks(receivedAt);
+
         this.lastAcknowledgedUserInputAt = receivedAt;
+        // The runtimeMessages dedupKey stays per-call unique (includes receivedAt)
+        // so a genuine resend of the same text after the window appends a fresh
+        // bubble; redelivery within the window is already suppressed above.
         const dedupKey = `user_input_ack:${shortHash(`${this.instanceId}:${content}:${receivedAt}`, 24)}`;
         this.appendRuntimeMessage(buildChatMessage({
             role: 'user',
@@ -1074,6 +1124,14 @@ export class CliProviderInstance implements ProviderInstance {
         } as ChatMessage), dedupKey);
     }
 
+    /** Drop user-input ack entries older than the dedup window so the map can't grow unbounded. */
+    private pruneRecentUserInputAcks(now: number): void {
+        if (this.recentUserInputAcks.size <= 1) return;
+        for (const [key, at] of this.recentUserInputAcks) {
+            if (now - at > USER_INPUT_ACK_DEDUP_WINDOW_MS) this.recentUserInputAcks.delete(key);
+        }
+    }
+
     dispose(): void {
         this.adapter.shutdown();
         this.monitor.reset();
@@ -2004,8 +2062,17 @@ export class CliProviderInstance implements ProviderInstance {
                         previousStatus: this.lastStatus,
                     };
                     const ownsExternalHistory = !!(this.adapter as any)?.chatMessagesOwnedExternally;
-                    const flushDelay = ownsExternalHistory ? 0 : 3000;
-                    LOG.debug('CLI', `[${this.type}] set completedDebouncePending duration=${duration}s ownsExternalHistory=${ownsExternalHistory} flushDelay=${flushDelay}ms generatingStartedAt=${this.generatingStartedAt}`);
+                    // (FALSEIDLE-BGCHILD-a) Native-history providers flush immediately (the
+                    // transcript is authoritative). For mesh worker sessions, give the
+                    // generating→idle transition a short settle window so a background-child
+                    // false idle (quiet after a backgrounded test/command while the parent turn
+                    // continues) gets caught by the resume guard in flushCompletedDebounceIfFinalized
+                    // instead of firing an early completion the coordinator can never correct.
+                    const meshWorkerSession = this.isMeshWorkerSession();
+                    const flushDelay = ownsExternalHistory
+                        ? (meshWorkerSession ? NATIVE_HISTORY_MESH_IDLE_SETTLE_MS : 0)
+                        : 3000;
+                    LOG.debug('CLI', `[${this.type}] set completedDebouncePending duration=${duration}s ownsExternalHistory=${ownsExternalHistory} meshWorker=${meshWorkerSession} flushDelay=${flushDelay}ms generatingStartedAt=${this.generatingStartedAt}`);
                     this.scheduleCompletedDebounceFlush(flushDelay);
                 }
             } else if (newStatus === 'idle' && this.lastStatus === 'starting') {