@adhdev/daemon-core 0.9.76-rc.55 → 0.9.76-rc.57

package/dist/types.d.ts

@@ -42,6 +42,15 @@ export interface ChatMessage {
     /** Optional: fiber metadata */
     _type?: string;
     _sub?: string;
+    /** Transcript visibility/audience contract for separating chat-visible content from internal/debug runtime rows. */
+    visibility?: 'visible' | 'user' | 'chat' | 'hidden' | 'debug' | 'internal' | (string & {});
+    transcriptVisibility?: 'visible' | 'user' | 'chat' | 'hidden' | 'debug' | 'internal' | (string & {});
+    audience?: 'chat' | 'debug' | 'trace' | 'internal' | (string & {});
+    source?: 'assistant_text' | 'tool_call' | 'terminal_command' | 'runtime_activity' | 'runtime_status' | 'provider_chrome' | 'control' | (string & {});
+    userFacing?: boolean;
+    internal?: boolean;
+    isInternal?: boolean;
+    debug?: boolean;
     /** Meta information for thought/terminal logs etc */
     meta?: {
         label?: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adhdev/daemon-core",
-  "version": "0.9.76-rc.55",
+  "version": "0.9.76-rc.57",
   "description": "ADHDev daemon core — CDP, IDE detection, providers, command execution",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/commands/chat-commands.ts

@@ -320,19 +320,23 @@ function buildReadChatCommandResult(payload: Record<string, any>, args: any): Co
     const visibleMessages = filterUserFacingChatMessages(messages);
     const sync = buildFullTail(visibleMessages, normalizeReadChatTailLimit(args));
     const hiddenMsgCount = Math.max(0, messages.length - visibleMessages.length);
-    const nextDebugReadChat = {
-        ...(debugReadChat || {}),
-        fullMsgCount: messages.length,
-        visibleMsgCount: visibleMessages.length,
-        hiddenMsgCount,
-        returnedMsgCount: sync.messages.length,
-    };
+    const returnedDebugReadChat = debugReadChat
+        ? {
+            ...debugReadChat,
+            fullMsgCount: typeof debugReadChat.fullMsgCount === 'number'
+                ? debugReadChat.fullMsgCount
+                : messages.length,
+            visibleMsgCount: visibleMessages.length,
+            hiddenMsgCount,
+            returnedMsgCount: sync.messages.length,
+        }
+        : undefined;
     return {
         success: true,
         ...validatedPayload,
         messages: sync.messages,
         totalMessages: sync.totalMessages,
-        debugReadChat: nextDebugReadChat,
+        ...(returnedDebugReadChat ? { debugReadChat: returnedDebugReadChat } : {}),
     };
 }
 

package/src/mesh/coordinator-prompt.ts

@@ -145,8 +145,8 @@ const WORKFLOW_SECTION = `## Orchestration Workflow
    b. If you need branch isolation for parallel work, call \`mesh_clone_node\` to create a worktree node first.
    c. If no session exists, call \`mesh_launch_session\` to start one.
    d. Call \`mesh_send_task\` with a **complete, self-contained** instruction that includes all context the agent needs (file paths, line numbers, what to change, why). Do not send partial instructions expecting future follow-up.
-4. **Monitor** — Periodically call \`mesh_read_chat\` to check progress. Handle approvals via \`mesh_approve\`.
-5. **Verify** — When a task reports completion, call \`mesh_git_status\` to verify changes were made.
+4. **Monitor** — Prefer event-driven completion/status notifications. Do **not** poll \`mesh_read_chat\` repeatedly just because the delegated session has not produced a final assistant message yet; tool/terminal activity means work may still be in progress. Use at most one compact \`mesh_read_chat\` check after a completion/approval signal, an explicit user status request, or a real timeout/stall. Handle approvals via \`mesh_approve\`.
+5. **Verify** — When a task reports completion or git work is visible, call \`mesh_git_status\` to verify changes were made.
 6. **Checkpoint** — Call \`mesh_checkpoint\` to save the work.
 7. **Clean up** — Remove worktree nodes via \`mesh_remove_node\` after their work is merged or no longer needed.
 8. **Report** — Summarize what was done, what changed, and any issues.`;
@@ -163,7 +163,7 @@ function buildRulesSection(coordinatorCliType?: string): string {
 - **Respect explicit provider requests.** If the user names an agent/provider, pass the matching provider type to \`mesh_launch_session\`: Hermes → \`hermes-cli\`, Claude Code/Claude → \`claude-cli\`, Codex → \`codex-cli\`, Gemini → \`gemini-cli\`. Never substitute \`claude-cli\` just because the coordinator itself is Claude Code.
 - **Front-load the task message.** When calling \`mesh_send_task\`, include everything the agent needs: what files to touch, what the problem is, what the fix should look like. The agent won't ask follow-up questions.
 - **Don't inspect code.** Trust the agent's output. Verify via \`mesh_git_status\`, not by reading source files.
-- **Don't over-parallelize.** Start with 1-2 concurrent tasks. Scale up if they succeed.
+- **Don't over-parallelize.** Start with 1-2 concurrent tasks. Scale up if they succeed. Never launch a duplicate session or second worker solely because \`mesh_read_chat\` has no final assistant message while the delegated session is still showing tool/terminal activity.
 - **Handle failures gracefully.** If a task fails, read the chat to understand why, then retry or reassign.
 - **Keep the user informed.** Report progress after each delegation round — one or two sentences, not a narration.
 - **Respect node capabilities.** Don't send build tasks to read-only nodes. Don't push from nodes that aren't allowed to.

package/src/providers/chat-message-normalization.ts

@@ -179,25 +179,51 @@ function readMessageMeta(message: ChatMessage): Record<string, unknown> | null {
     : null;
 }
 
-function isExplicitlyHiddenFromTranscript(meta: Record<string, unknown> | null): boolean {
-  if (!meta) return false;
-  const visibility = typeof meta.transcriptVisibility === 'string'
-    ? meta.transcriptVisibility.trim().toLowerCase()
-    : '';
-  return visibility === 'hidden'
-    || visibility === 'debug'
-    || meta.internal === true
-    || meta.debug === true
-    || meta.statusOnly === true
-    || meta.controlOnly === true;
+function readStringField(value: unknown): string {
+  return typeof value === 'string' ? value.trim().toLowerCase() : '';
+}
+
+function readVisibilityField(message: ChatMessage, meta: Record<string, unknown> | null): string {
+  const record = message as ChatMessage & Record<string, unknown>;
+  return readStringField(record.visibility ?? record.transcriptVisibility ?? meta?.visibility ?? meta?.transcriptVisibility);
 }
 
-function isExplicitlyVisibleInTranscript(meta: Record<string, unknown> | null): boolean {
-  if (!meta) return false;
-  const visibility = typeof meta.transcriptVisibility === 'string'
-    ? meta.transcriptVisibility.trim().toLowerCase()
-    : '';
-  return visibility === 'visible' || meta.userFacing === true;
+function isExplicitlyHiddenFromTranscript(message: ChatMessage, meta: Record<string, unknown> | null): boolean {
+  const record = message as ChatMessage & Record<string, unknown>;
+  const visibility = readVisibilityField(message, meta);
+  const audience = readStringField(record.audience ?? meta?.audience);
+  const source = readStringField(record.source ?? meta?.source);
+
+  return visibility === 'hidden'
+    || visibility === 'debug'
+    || visibility === 'internal'
+    || audience === 'debug'
+    || audience === 'trace'
+    || audience === 'internal'
+    || source === 'runtime_status'
+    || source === 'runtime_activity'
+    || source === 'provider_chrome'
+    || source === 'control'
+    || record.internal === true
+    || record.isInternal === true
+    || record.debug === true
+    || meta?.internal === true
+    || meta?.isInternal === true
+    || meta?.debug === true
+    || meta?.statusOnly === true
+    || meta?.controlOnly === true;
+}
+
+function isExplicitlyVisibleInTranscript(message: ChatMessage, meta: Record<string, unknown> | null): boolean {
+  const record = message as ChatMessage & Record<string, unknown>;
+  const visibility = readVisibilityField(message, meta);
+  const audience = readStringField(record.audience ?? meta?.audience);
+  return visibility === 'visible'
+    || visibility === 'user'
+    || visibility === 'chat'
+    || audience === 'chat'
+    || record.userFacing === true
+    || meta?.userFacing === true;
 }
 
 /**
@@ -212,8 +238,8 @@ function isExplicitlyVisibleInTranscript(meta: Record<string, unknown> | null):
 export function isUserFacingChatMessage(message: ChatMessage | null | undefined): boolean {
   if (!message) return false;
   const meta = readMessageMeta(message);
-  if (isExplicitlyHiddenFromTranscript(meta)) return false;
-  if (isExplicitlyVisibleInTranscript(meta)) return true;
+  if (isExplicitlyHiddenFromTranscript(message, meta)) return false;
+  if (isExplicitlyVisibleInTranscript(message, meta)) return true;
 
   const role = typeof message.role === 'string' ? message.role.trim().toLowerCase() : '';
   const kind = resolveChatMessageKind(message);

package/src/providers/cli-provider-instance.ts

@@ -25,7 +25,7 @@ import { formatAutoApprovalMessage, pickApprovalButton } from './approval-utils.
 import { getCliScriptCommand, parseCliScriptResult } from './cli-script-results.js';
 import { mergeProviderPatchState, resolveProviderStateSurface } from './provider-patch-state.js';
 import { normalizeProviderSessionId } from './provider-session-id.js';
-import { buildChatMessage, buildRuntimeSystemChatMessage, normalizeChatMessages, resolveChatMessageKind } from './chat-message-normalization.js';
+import { buildChatMessage, buildRuntimeSystemChatMessage, isUserFacingChatMessage, normalizeChatMessages, resolveChatMessageKind } from './chat-message-normalization.js';
 
 type PersistableCliHistoryMessage = {
     role: string;
@@ -1031,14 +1031,11 @@ export class CliProviderInstance implements ProviderInstance {
         const getRole = (message: ChatMessage): string => typeof message.role === 'string'
             ? message.role.trim().toLowerCase()
             : '';
-        const isAutoApprovalRuntimeOverlay = (entry: MergeEntry): boolean => {
+        const isRuntimeOverlay = (entry: MergeEntry): boolean => {
             if (entry.source !== 'runtime') return false;
             const key = typeof entry.runtimeKey === 'string' ? entry.runtimeKey.trim().toLowerCase() : '';
             if (key.startsWith('auto_approval:')) return true;
-            const content = typeof entry.message.content === 'string'
-                ? entry.message.content.trim().toLowerCase()
-                : flattenContent(entry.message.content).trim().toLowerCase();
-            return content.startsWith('auto-approved:');
+            return !isUserFacingChatMessage(entry.message);
         };
         const shouldKeepParsedBeforeUntimedRuntime = (message: ChatMessage): boolean => {
             const role = getRole(message);
@@ -1059,7 +1056,7 @@ export class CliProviderInstance implements ProviderInstance {
                 if (a.source !== b.source && aTime !== bTime) {
                     const parsedEntry = a.source === 'parsed' ? a : b.source === 'parsed' ? b : null;
                     const runtimeEntry = a.source === 'runtime' ? a : b.source === 'runtime' ? b : null;
-                    if (parsedEntry && runtimeEntry && isAutoApprovalRuntimeOverlay(runtimeEntry) && getTime(parsedEntry.message) === 0 && getTime(runtimeEntry.message) > 0) {
+                    if (parsedEntry && runtimeEntry && isRuntimeOverlay(runtimeEntry) && getTime(parsedEntry.message) === 0 && getTime(runtimeEntry.message) > 0) {
                         if (shouldKeepParsedBeforeUntimedRuntime(parsedEntry.message)) {
                             return a.source === 'parsed' ? -1 : 1;
                         }
@@ -1072,8 +1069,8 @@ export class CliProviderInstance implements ProviderInstance {
                 // do not carry timestamps on parsed messages. In that case there is no safe
                 // clock basis for interleaving timestamped runtime/system messages into the
                 // provider transcript. Keep user prompts before runtime overlays, but do not
-                // let timed runtime/system overlays become the final chat turns after an
-                // untimed parsed assistant transcript.
+                // let timed runtime/system/tool/internal overlays become the final chat turns
+                // after an untimed parsed assistant transcript.
                 return a.index - b.index;
             })
             .map((entry) => entry.message));

package/src/providers/read-chat-contract.ts

@@ -77,6 +77,14 @@ function validateMessage(message: unknown, source: string, index: number): ChatM
   if (typeof message.senderName === 'string') normalized.senderName = message.senderName
   if (typeof (message as any)._type === 'string') normalized._type = (message as any)._type
   if (typeof (message as any)._sub === 'string') normalized._sub = (message as any)._sub
+  if (typeof (message as any).visibility === 'string') normalized.visibility = (message as any).visibility
+  if (typeof (message as any).transcriptVisibility === 'string') normalized.transcriptVisibility = (message as any).transcriptVisibility
+  if (typeof (message as any).audience === 'string') normalized.audience = (message as any).audience
+  if (typeof (message as any).source === 'string') normalized.source = (message as any).source
+  if (typeof (message as any).userFacing === 'boolean') normalized.userFacing = (message as any).userFacing
+  if (typeof (message as any).internal === 'boolean') normalized.internal = (message as any).internal
+  if (typeof (message as any).isInternal === 'boolean') normalized.isInternal = (message as any).isInternal
+  if (typeof (message as any).debug === 'boolean') normalized.debug = (message as any).debug
 
   return normalized
 }

package/src/types.ts

@@ -49,6 +49,15 @@ export interface ChatMessage {
   /** Optional: fiber metadata */
   _type?: string;
   _sub?: string;
+  /** Transcript visibility/audience contract for separating chat-visible content from internal/debug runtime rows. */
+  visibility?: 'visible' | 'user' | 'chat' | 'hidden' | 'debug' | 'internal' | (string & {});
+  transcriptVisibility?: 'visible' | 'user' | 'chat' | 'hidden' | 'debug' | 'internal' | (string & {});
+  audience?: 'chat' | 'debug' | 'trace' | 'internal' | (string & {});
+  source?: 'assistant_text' | 'tool_call' | 'terminal_command' | 'runtime_activity' | 'runtime_status' | 'provider_chrome' | 'control' | (string & {});
+  userFacing?: boolean;
+  internal?: boolean;
+  isInternal?: boolean;
+  debug?: boolean;
   /** Meta information for thought/terminal logs etc */
   meta?: { label?: string; isRunning?: boolean } | Record<string, any>;
   /** Sender name for shared sessions */