@adhdev/daemon-core 0.5.41 → 0.5.42

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adhdev/daemon-core",
-  "version": "0.5.41",
+  "version": "0.5.42",
   "description": "ADHDev daemon core — CDP, IDE detection, providers, command execution",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/config/config.ts

@@ -30,6 +30,12 @@ export interface ADHDevConfig {
 
  // User preferences
     autoConnect: boolean;
+    /**
+     * @deprecated Not read at runtime. Notification preferences are now managed by:
+     * - Web UI layer: useNotificationPrefs (localStorage)
+     * - Daemon layer: per-provider settings (approvalAlert, longGeneratingAlert)
+     * Kept for backward config compat — will be removed in v0.7+.
+     */
     notifications: boolean;
 
  // Auth

package/src/providers/ide-provider-instance.ts

@@ -36,6 +36,7 @@ export class IdeProviderInstance implements ProviderInstance {
     private tickBusy = false;
     private monitor: StatusMonitor;
     private historyWriter: ChatHistoryWriter;
+    private autoApproveBusy = false;
 
  // IDE meta
     private ideVersion: string = '';
@@ -361,6 +362,11 @@ export class IdeProviderInstance implements ProviderInstance {
             this.lastAgentStatuses.set(agentKey, agentStatus);
         }
 
+ // Auto-approve: when waiting_approval + settings.autoApprove → auto-click approve via CDP
+        if (agentStatus === 'waiting_approval' && this.settings.autoApprove && !this.autoApproveBusy) {
+            this.autoApproveViaScript(chatData);
+        }
+
  // Monitor check (cooldown based notification)
         const monitorEvents = this.monitor.check(agentKey, agentStatus, now);
         for (const me of monitorEvents) {
@@ -384,4 +390,40 @@ export class IdeProviderInstance implements ProviderInstance {
     updateCdp(cdp: InstanceContext['cdp']): void {
         if (this.context) this.context.cdp = cdp;
     }
+
+ // ─── Auto-approve via CDP script ────────────────────
+
+    private async autoApproveViaScript(_chatData: any): Promise<void> {
+        const cdp = this.context?.cdp;
+        if (!cdp?.isConnected) return;
+
+        // Check if provider has resolveAction script
+        const scriptFn = this.provider.scripts?.resolveAction;
+        if (typeof scriptFn !== 'function') {
+            LOG.debug('IdeInstance', `[IdeInstance:${this.type}] autoApprove: no resolveAction script available`);
+            return;
+        }
+
+        this.autoApproveBusy = true;
+        try {
+            const script = scriptFn({ action: 'approve', button: '', buttonText: '' });
+            if (!script) return;
+
+            LOG.info('IdeInstance', `[IdeInstance:${this.type}] autoApprove: executing resolveAction`);
+            const result = await cdp.evaluate(script, 10000);
+            LOG.info('IdeInstance', `[IdeInstance:${this.type}] autoApprove result: ${JSON.stringify(result)?.slice(0, 200)}`);
+
+            this.pushEvent({
+                event: 'agent:auto_approved',
+                chatTitle: _chatData?.title || this.provider.name,
+                timestamp: Date.now(),
+                ideType: this.type,
+            });
+        } catch (e: any) {
+            LOG.warn('IdeInstance', `[IdeInstance:${this.type}] autoApprove error: ${e?.message}`);
+        } finally {
+            // Debounce: prevent rapid re-approval for at least 500ms
+            setTimeout(() => { this.autoApproveBusy = false; }, 500);
+        }
+    }
 }

package/src/providers/status-monitor.ts

@@ -1,28 +1,28 @@
 /**
- * StatusMonitor — status monitoring notification system
+ * StatusMonitor — Status monitoring notification system
  *
- * Common across all Provider categories (IDE/Extension/CLI).
- * - approval wait(waiting_approval) occur when notification
+ * Common across all Provider categories (IDE/Extension/CLI/ACP).
+ * - Approval waiting (waiting_approval) notification
  * - Notification when generating persists for extended duration
- * - all config Provider Settingstoggle possible
+ * - All config toggleable via Provider Settings
  */
 
 export interface MonitorConfig {
  /** Enable awaiting-approval notification */
     approvalAlert: boolean;
- /** prolonged generating notification enabled */
+ /** Prolonged generating notification enabled */
     longGeneratingAlert: boolean;
  /** Prolonged threshold (seconds) */
     longGeneratingThresholdSec: number;
- /** repeat notification cooldown (seconds) */
+ /** Repeat notification cooldown (seconds) */
     alertCooldownSec: number;
 }
 
 export const DEFAULT_MONITOR_CONFIG: MonitorConfig = {
     approvalAlert: true,
     longGeneratingAlert: true,
-    longGeneratingThresholdSec: 180,   // 3minutes
-    alertCooldownSec: 60,              // 1minutes cooldown
+    longGeneratingThresholdSec: 180,   // 3 minutes
+    alertCooldownSec: 60,              // 1 minute cooldown
 };
 
 export interface MonitorEvent {
@@ -42,24 +42,24 @@ export class StatusMonitor {
         this.config = { ...DEFAULT_MONITOR_CONFIG, ...config };
     }
 
- /** Config update (called from Provider Settings) */
+ /** Update config (called from Provider Settings) */
     updateConfig(partial: Partial<MonitorConfig>): void {
         Object.assign(this.config, partial);
     }
 
- /** current config return */
+ /** Return current config */
     getConfig(): MonitorConfig {
         return { ...this.config };
     }
 
  /**
- * Check status transition → return notification event array
- * each onTick()from call.
- */
+  * Check status transition → return notification event array.
+  * Called from each onTick() or detectStatusTransition().
+  */
     check(agentKey: string, status: string, now: number): MonitorEvent[] {
         const events: MonitorEvent[] = [];
 
- // 1. approval wait notification
+ // 1. Approval waiting notification
         if (this.config.approvalAlert && status === 'waiting_approval') {
             if (this.shouldAlert(agentKey + ':approval', now)) {
                 events.push({
@@ -71,7 +71,7 @@ export class StatusMonitor {
             }
         }
 
- // 2. Detect prolonged generating (identical for IDE/Extension/CLI)
+ // 2. Detect prolonged generating (identical for IDE/Extension/CLI/ACP)
         if (status === 'generating' || status === 'streaming') {
             if (!this.generatingStartTimes.has(agentKey)) {
                 this.generatingStartTimes.set(agentKey, now);