@adeu/core 1.18.0 → 1.18.2

package/dist/index.d.cts

@@ -185,6 +185,16 @@ declare class RedlineEngine {
     original_mapper: DocumentMapper | null;
     skipped_details: string[];
     constructor(doc: DocumentObject, author?: string);
+    /**
+     * Return a hint when a short, single-token anchor contains punctuation that
+     * can split awkwardly, else null.
+     *
+     * Surface this ONLY for edits that actually failed to match/apply. On a
+     * successful edit the batch report already carries the redline preview, so
+     * emitting this would be a false positive: the punctuation (dates,
+     * `[_name_]` placeholders, `____` blanks) is frequently the literal target
+     * and the edit succeeds despite it. Mirrors the Python engine.
+     */
     private _check_punctuation_warning;
     /**
      * Best-effort "did you mean" hint for a failed target. The common loop trap
@@ -305,6 +315,15 @@ declare class RedlineEngine {
      */
     private _set_paragraph_style;
     private _anchor_reply_comment;
+    /**
+     * Read a comment's author directly from the comments part. Used by
+     * _clean_wrapping_comments to decide whether a wrapping comment belongs to
+     * another author (and must be preserved when its anchored change is
+     * accepted/rejected) or to us (safe to delete). Reads the part rather than
+     * the mapper because the mapper's comments_map is not rebuilt between review
+     * actions, so it can be stale mid-batch. Returns null if not found.
+     */
+    private _get_comment_author;
     private _clean_wrapping_comments;
     private _delete_comments_in_element;
     validate_edits(edits: any[], index_offset?: number): string[];

package/dist/index.d.ts

@@ -185,6 +185,16 @@ declare class RedlineEngine {
     original_mapper: DocumentMapper | null;
     skipped_details: string[];
     constructor(doc: DocumentObject, author?: string);
+    /**
+     * Return a hint when a short, single-token anchor contains punctuation that
+     * can split awkwardly, else null.
+     *
+     * Surface this ONLY for edits that actually failed to match/apply. On a
+     * successful edit the batch report already carries the redline preview, so
+     * emitting this would be a false positive: the punctuation (dates,
+     * `[_name_]` placeholders, `____` blanks) is frequently the literal target
+     * and the edit succeeds despite it. Mirrors the Python engine.
+     */
     private _check_punctuation_warning;
     /**
      * Best-effort "did you mean" hint for a failed target. The common loop trap
@@ -305,6 +315,15 @@ declare class RedlineEngine {
      */
     private _set_paragraph_style;
     private _anchor_reply_comment;
+    /**
+     * Read a comment's author directly from the comments part. Used by
+     * _clean_wrapping_comments to decide whether a wrapping comment belongs to
+     * another author (and must be preserved when its anchored change is
+     * accepted/rejected) or to us (safe to delete). Reads the part rather than
+     * the mapper because the mapper's comments_map is not rebuilt between review
+     * actions, so it can be stale mid-batch. Returns null if not found.
+     */
+    private _get_comment_author;
     private _clean_wrapping_comments;
     private _delete_comments_in_element;
     validate_edits(edits: any[], index_offset?: number): string[];

package/dist/index.js

@@ -3012,8 +3012,19 @@ var RedlineEngine = class {
     this.mapper = new DocumentMapper(this.doc);
     this.comments_manager = new CommentsManager(this.doc);
   }
+  /**
+   * Return a hint when a short, single-token anchor contains punctuation that
+   * can split awkwardly, else null.
+   *
+   * Surface this ONLY for edits that actually failed to match/apply. On a
+   * successful edit the batch report already carries the redline preview, so
+   * emitting this would be a false positive: the punctuation (dates,
+   * `[_name_]` placeholders, `____` blanks) is frequently the literal target
+   * and the edit succeeds despite it. Mirrors the Python engine.
+   */
   _check_punctuation_warning(target_text) {
     if (!target_text) return null;
+    if (target_text.length > 20 || target_text.includes(" ")) return null;
     if (target_text.includes("_") || target_text.includes("-")) {
       return `Warning: target_text '${target_text}' contains tokenization-splitting punctuation ('_' or '-'). This can trigger mid-word splits in the diff engine. Consider using a longer plain-prose anchor.`;
     }
@@ -3811,6 +3822,27 @@ var RedlineEngine = class {
     ref_run.appendChild(ref);
     insertAfter(ref_run, new_end);
   }
+  /**
+   * Read a comment's author directly from the comments part. Used by
+   * _clean_wrapping_comments to decide whether a wrapping comment belongs to
+   * another author (and must be preserved when its anchored change is
+   * accepted/rejected) or to us (safe to delete). Reads the part rather than
+   * the mapper because the mapper's comments_map is not rebuilt between review
+   * actions, so it can be stale mid-batch. Returns null if not found.
+   */
+  _get_comment_author(c_id) {
+    const part = this.doc.pkg.parts.find(
+      (p) => p.contentType === "application/vnd.openxmlformats-officedocument.wordprocessingml.comments+xml"
+    );
+    if (!part) return null;
+    const comments = findAllDescendants(part._element, "w:comment");
+    for (const c of comments) {
+      if (c.getAttribute("w:id") === c_id) {
+        return c.getAttribute("w:author");
+      }
+    }
+    return null;
+  }
   _clean_wrapping_comments(element) {
     let first_node = element;
     while (true) {
@@ -3875,7 +3907,11 @@ var RedlineEngine = class {
     for (const s of starts_to_remove) {
       const c_id = s.getAttribute("w:id");
       if (c_id && end_ids.has(c_id)) {
-        this.comments_manager.deleteComment(c_id);
+        const author = this._get_comment_author(c_id);
+        const is_own = author !== null && author === this.author;
+        if (is_own) {
+          this.comments_manager.deleteComment(c_id);
+        }
         if (s.parentNode) s.parentNode.removeChild(s);
         for (const e of ends_to_remove) {
           let e_id = null;
@@ -4004,10 +4040,9 @@ var RedlineEngine = class {
         if (edit.target_text.includes("|")) {
           matches = matches.slice(0, 1);
         } else {
-          const positions = matches.map(([start, length]) => [
-            start,
-            start + length
-          ]);
+          const positions = matches.map(
+            ([start, length]) => [start, start + length]
+          );
           errors.push(
             format_ambiguity_error(
               i + 1 + index_offset,
@@ -4174,7 +4209,10 @@ var RedlineEngine = class {
   _process_batch_internal(changes, dry_run_mode = false) {
     for (const c of changes) {
       if (c && typeof c === "object" && c.type === "modify" && c.target_text && c.new_text) {
-        const [strippedTarget, strippedNew] = stripMatchingHeadingHashes(c.target_text, c.new_text);
+        const [strippedTarget, strippedNew] = stripMatchingHeadingHashes(
+          c.target_text,
+          c.new_text
+        );
         c.target_text = strippedTarget;
         c.new_text = strippedNew;
       }
@@ -4190,10 +4228,7 @@ var RedlineEngine = class {
       const action_errors = actions.length > 0 ? this.validate_review_actions(actions) : [];
       const validate_edits_now = edits.length > 0 && action_errors.length > 0;
       const edit_errors = validate_edits_now ? this.validate_edits(edits) : [];
-      const all_errors = [
-        ...action_errors,
-        ...edit_errors
-      ];
+      const all_errors = [...action_errors, ...edit_errors];
       if (all_errors.length > 0) {
         throw new BatchValidationError(all_errors);
       }
@@ -4230,11 +4265,11 @@ var RedlineEngine = class {
         for (let i = 0; i < edits.length; i++) {
           const edit = edits[i];
           const single_errors = this.validate_edits([edit], i);
-          const warning = this._check_punctuation_warning(
-            edit.target_text || ""
-          );
           if (single_errors.length > 0) {
             skipped_edits++;
+            const warning = this._check_punctuation_warning(
+              edit.target_text || ""
+            );
             edits_reports.push({
               status: "failed",
               target_text: edit.target_text || "",
@@ -4254,7 +4289,7 @@ var RedlineEngine = class {
               status: "applied",
               target_text: edit.target_text || "",
               new_text: edit.new_text || "",
-              warning,
+              warning: null,
               error: null,
               critic_markup: previews[0],
               clean_text: previews[1],
@@ -4268,6 +4303,9 @@ var RedlineEngine = class {
           } else {
             skipped_edits++;
             const error_msg = this.skipped_details.length > 0 ? this.skipped_details[this.skipped_details.length - 1] : "Failed to apply edit";
+            const warning = this._check_punctuation_warning(
+              edit.target_text || ""
+            );
             edits_reports.push({
               status: "failed",
               target_text: edit.target_text || "",
@@ -4306,22 +4344,22 @@ var RedlineEngine = class {
           this.clean_mapper = null;
           throw err;
         }
-        applied_edits = edits.filter(
-          (e) => e._applied_status
-        ).length;
+        applied_edits = edits.filter((e) => e._applied_status).length;
         skipped_edits = edits.length - applied_edits;
         for (const edit of edits) {
           const success = edit._applied_status || false;
           const error_msg = edit._error_msg || null;
-          const warning = this._check_punctuation_warning(
-            edit.target_text || ""
-          );
           let critic_markup = null;
           let clean_text = null;
+          let warning = null;
           if (success) {
             const previews = this._build_edit_context_previews(edit);
             critic_markup = previews[0];
             clean_text = previews[1];
+          } else {
+            warning = this._check_punctuation_warning(
+              edit.target_text || ""
+            );
           }
           edits_reports.push({
             status: success ? "applied" : "failed",
@@ -4347,7 +4385,7 @@ var RedlineEngine = class {
       skipped_details: this.skipped_details,
       edits: edits_reports,
       engine: "node",
-      version: "1.10.0"
+      version: "1.18.2"
     };
   }
   apply_edits(edits, page_offsets = []) {
@@ -4791,7 +4829,10 @@ var RedlineEngine = class {
             const t_seg = target_segs[k];
             const n_seg = new_segs[k];
             if (t_seg !== n_seg) {
-              const [seg_prefix, seg_suffix] = trim_common_context(t_seg, n_seg);
+              const [seg_prefix, seg_suffix] = trim_common_context(
+                t_seg,
+                n_seg
+              );
               const seg_target = t_seg.substring(
                 seg_prefix,
                 t_seg.length - seg_suffix
@@ -5202,7 +5243,11 @@ var RedlineEngine = class {
         if (is_inline_first) {
           const del_parent = last_del.parentNode;
           if (del_parent && del_parent.tagName === "w:ins") {
-            this._insert_and_split_ins(del_parent, last_del, result.first_node);
+            this._insert_and_split_ins(
+              del_parent,
+              last_del,
+              result.first_node
+            );
           } else {
             insertAfter(result.first_node, last_del);
           }