@adeu/core 1.17.1 → 1.18.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adeu/core",
-  "version": "1.17.1",
+  "version": "1.18.0",
   "description": "",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/src/engine.bugs.test.ts

@@ -418,7 +418,7 @@ describe("Resolved Bugs Core Engine Verification", () => {
     expect(pTarget.parentNode).toBeNull();
   });
 
-  it("BUG-EXPLORE-2: Nested redline validation error includes actionable hint", async () => {
+  it("BUG-EXPLORE-2: a strict edit inside a foreign author's insertion applies (nested change)", async () => {
     const doc = await createTestDocument();
     addParagraph(doc, "Original baseline.");
 
@@ -432,20 +432,18 @@ describe("Resolved Bugs Core Engine Verification", () => {
       },
     ]);
 
-    // Author B tries to modify Author A's pending insertion
+    // Author B modifies Author A's pending insertion — this now applies: the
+    // enclosing <w:ins> is split and Author B's change nested inside it.
     const engineB = new RedlineEngine(doc, "Author B");
-
-    expect(() => {
-      engineB.process_batch([
-        {
-          type: "modify",
-          target_text: "Inserted by A.",
-          new_text: "Modified by B.",
-        },
-      ]);
-    }).toThrowError(
-      /Accept that change first or scope your edit outside of it/,
-    );
+    const result = engineB.process_batch([
+      {
+        type: "modify",
+        target_text: "Inserted by A.",
+        new_text: "Modified by B.",
+      },
+    ]);
+    expect(result.edits_applied).toBe(1);
+    expect(result.edits_skipped).toBe(0);
   });
 
   it("BUG-CROSS-PARA-1: Cross-paragraph modify coalesces paragraphs and tracks para-mark deletion", async () => {

package/src/engine.issue23.test.ts

@@ -422,31 +422,36 @@ describe("BUG-23-4: multi-paragraph target_text must produce actionable feedback
     }
   });
 
-  it("BUG-23-4-NN: rejects plain-paragraph N->N modifications spanning a paragraph boundary to prevent silent corruption", async () => {
+  it("BUG-23-4-NN: applies balanced plain-paragraph N->N modifications per paragraph, preserving the boundary", async () => {
     const doc = await createTestDocument();
     addParagraph(doc, "Clause 1 ends here.");
     addParagraph(doc, "Clause 2 begins here.");
 
     const engine = new RedlineEngine(doc, "Test Author");
 
-    let raised: any = null;
-    try {
-      engine.process_batch([
-        {
-          type: "modify",
-          target_text: "ends here.\n\nClause 2 begins",
-          new_text: "ends here. MERGED\n\nClause 2 begins CHANGED",
-        },
-      ]);
-    } catch (e: any) {
-      raised = e;
-    }
+    // Both target and replacement carry the same number of \n\n breaks, so the
+    // paragraph structure is preserved. The engine splits this into one sub-edit
+    // per paragraph and applies it as a single logical edit. (Unbalanced
+    // merges/splits are still rejected — see the regex case in engine.qa.test.)
+    const result = engine.process_batch([
+      {
+        type: "modify",
+        target_text: "ends here.\n\nClause 2 begins",
+        new_text: "ends here. MERGED\n\nClause 2 begins CHANGED",
+      },
+    ]);
 
-    expect(raised).not.toBeNull();
-    if (raised) {
-      expect(raised.name).toBe("BatchValidationError");
-      expect(raised.message.toLowerCase()).toContain("paragraph boundary");
-    }
+    expect(result.edits_applied).toBe(1);
+    expect(result.edits_skipped).toBe(0);
+
+    const buf = await doc.save();
+    const text = await extractTextFromBuffer(buf);
+    // The paragraph boundary must survive — the two clauses are NOT merged.
+    expect(text).not.toContain("ends here.Clause 2 begins");
+    expect(text).not.toContain("ends here. Clause 2 begins");
+    // Both per-paragraph insertions land.
+    expect(text).toContain("MERGED");
+    expect(text).toContain("CHANGED");
   });
 });
 

package/src/engine.qa.test.ts

@@ -83,7 +83,7 @@ describe("QA Report V2: Engine Logic", () => {
       target_text: "Occurrence",
       new_text: "Match",
       match_mode: "all"
-    };
+    } as any;
     const stats = engine.process_batch([edit], false);
     
     const report = stats.edits[0];
@@ -116,7 +116,7 @@ describe("QA Report V2: Engine Logic", () => {
       target_text: "Target word",
       new_text: "Replaced",
       match_mode: "all"
-    };
+    } as any;
 
     expect(() => engine.process_batch([edit], false)).toThrow(/targets an active insertion from another author/);
   });
@@ -132,7 +132,7 @@ describe("QA Report V2: Engine Logic", () => {
       target_text: "part.\\n\\nSecond",
       new_text: "merged",
       regex: true
-    };
+    } as any;
 
     expect(() => engine.process_batch([edit], false)).toThrow(/spans a paragraph boundary with body text on both sides/);
   });
@@ -155,7 +155,7 @@ describe("QA Report V2: Engine Logic", () => {
       target_text: "the Board of Directors",
       new_text: "the Supervisory Board",
       match_mode: "all"
-    };
+    } as any;
 
     expect(() => engineBob.process_batch([editBob], false)).toThrow(/another author/i);
   });

package/src/engine.tables.test.ts

@@ -1,12 +1,24 @@
-import { describe, it, expect } from 'vitest';
-import { createTestDocument, addParagraph, addTable, setCellText, mergeCells, addNestedTable } from './test-utils.js';
-import { DocumentObject } from './docx/bridge.js';
-import { extractTextFromBuffer } from './ingest.js';
-import { RedlineEngine } from './engine.js';
-import { ModifyText, InsertTableRow, DeleteTableRow, RejectChange } from './models.js';
-
-describe('Table Interop & Engine (Node.js Port)', () => {
-  it('interleaved tables and text remain ordered', async () => {
+import { describe, it, expect } from "vitest";
+import {
+  createTestDocument,
+  addParagraph,
+  addTable,
+  setCellText,
+  mergeCells,
+  addNestedTable,
+} from "./test-utils.js";
+import { DocumentObject } from "./docx/bridge.js";
+import { extractTextFromBuffer } from "./ingest.js";
+import { RedlineEngine } from "./engine.js";
+import {
+  ModifyText,
+  InsertTableRow,
+  DeleteTableRow,
+  RejectChange,
+} from "./models.js";
+
+describe("Table Interop & Engine (Node.js Port)", () => {
+  it("interleaved tables and text remain ordered", async () => {
     const doc = await createTestDocument();
     addParagraph(doc, "Section 1");
     const tbl = addTable(doc, 1, 1);
@@ -28,13 +40,17 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(tIdx).toBeLessThan(p2);
   });
 
-  it('extracts and edits nested tables correctly', async () => {
+  it("extracts and edits nested tables correctly", async () => {
     const doc = await createTestDocument();
     const outerTbl = addTable(doc, 1, 1);
-    
-    const rows = Array.from(outerTbl.childNodes).filter(n => (n as Element).tagName === 'w:tr') as Element[];
-    const cells = Array.from(rows[0].childNodes).filter(n => (n as Element).tagName === 'w:tc') as Element[];
-    
+
+    const rows = Array.from(outerTbl.childNodes).filter(
+      (n) => (n as Element).tagName === "w:tr",
+    ) as Element[];
+    const cells = Array.from(rows[0].childNodes).filter(
+      (n) => (n as Element).tagName === "w:tc",
+    ) as Element[];
+
     const nestedTbl = addNestedTable(cells[0], 1, 1);
     setCellText(nestedTbl, 0, 0, "InnerSecret");
 
@@ -44,7 +60,13 @@ describe('Table Interop & Engine (Node.js Port)', () => {
 
     const midDoc = await DocumentObject.load(buf);
     const engine = new RedlineEngine(midDoc);
-    const [applied] = engine.apply_edits([{ type: 'modify', target_text: "InnerSecret", new_text: "OuterSecret" } as ModifyText]);
+    const [applied] = engine.apply_edits([
+      {
+        type: "modify",
+        target_text: "InnerSecret",
+        new_text: "OuterSecret",
+      } as ModifyText,
+    ]);
     expect(applied).toBe(1);
 
     const finalBuf = await midDoc.save();
@@ -52,11 +74,11 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(final_text).toContain("{--InnerSecret--}{++OuterSecret++}");
   });
 
-  it('merged cells do not duplicate content extraction', async () => {
+  it("merged cells do not duplicate content extraction", async () => {
     const doc = await createTestDocument();
     const tbl = addTable(doc, 1, 2);
     setCellText(tbl, 0, 0, "MergedUnique");
-    
+
     // Simulate python-docx's cell.merge(cell)
     mergeCells(tbl, 0, 0, 1);
 
@@ -68,11 +90,17 @@ describe('Table Interop & Engine (Node.js Port)', () => {
 
     const midDoc = await DocumentObject.load(buf);
     const engine = new RedlineEngine(midDoc);
-    const [applied] = engine.apply_edits([{ type: 'modify', target_text: "MergedUnique", new_text: "ChangedUnique" } as ModifyText]);
+    const [applied] = engine.apply_edits([
+      {
+        type: "modify",
+        target_text: "MergedUnique",
+        new_text: "ChangedUnique",
+      } as ModifyText,
+    ]);
     expect(applied).toBe(1);
   });
 
-  it('empty row mapping alignment stays synchronized', async () => {
+  it("empty row mapping alignment stays synchronized", async () => {
     const doc = await createTestDocument();
     const tbl = addTable(doc, 3, 1);
     setCellText(tbl, 0, 0, "RowA");
@@ -81,10 +109,12 @@ describe('Table Interop & Engine (Node.js Port)', () => {
 
     const buf = await doc.save();
     const midDoc = await DocumentObject.load(buf);
-    
+
     const engine = new RedlineEngine(midDoc);
-    const [applied] = engine.apply_edits([{ type: 'modify', target_text: "RowB", new_text: "RowC" } as ModifyText]);
-    
+    const [applied] = engine.apply_edits([
+      { type: "modify", target_text: "RowB", new_text: "RowC" } as ModifyText,
+    ]);
+
     expect(applied).toBe(1);
 
     const resBuf = await midDoc.save();
@@ -94,18 +124,25 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(resText).toContain("{--RowB--}{++RowC++}");
   });
 
-  it('inserts table row below', async () => {
+  it("inserts table row below", async () => {
     const doc = await createTestDocument();
     const tbl = addTable(doc, 2, 2);
-    setCellText(tbl, 0, 0, "A1"); setCellText(tbl, 0, 1, "A2");
-    setCellText(tbl, 1, 0, "B1"); setCellText(tbl, 1, 1, "B2");
+    setCellText(tbl, 0, 0, "A1");
+    setCellText(tbl, 0, 1, "A2");
+    setCellText(tbl, 1, 0, "B1");
+    setCellText(tbl, 1, 1, "B2");
 
     const buf = await doc.save();
     const midDoc = await DocumentObject.load(buf);
 
     const engine = new RedlineEngine(midDoc);
     const stats = engine.process_batch([
-      { type: 'insert_row', target_text: "A1 | A2", position: "below", cells: ["New B1", "New B2"] } as InsertTableRow
+      {
+        type: "insert_row",
+        target_text: "A1 | A2",
+        position: "below",
+        cells: ["New B1", "New B2"],
+      } as InsertTableRow,
     ]);
 
     expect(stats.edits_applied).toBe(1);
@@ -120,18 +157,23 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(clean_text).toContain("B1 | B2");
   });
 
-  it('deletes table row', async () => {
+  it("deletes table row", async () => {
     const doc = await createTestDocument();
     const tbl = addTable(doc, 3, 2);
-    setCellText(tbl, 0, 0, "A1"); setCellText(tbl, 0, 1, "A2");
-    setCellText(tbl, 1, 0, "B1"); setCellText(tbl, 1, 1, "B2");
-    setCellText(tbl, 2, 0, "C1"); setCellText(tbl, 2, 1, "C2");
+    setCellText(tbl, 0, 0, "A1");
+    setCellText(tbl, 0, 1, "A2");
+    setCellText(tbl, 1, 0, "B1");
+    setCellText(tbl, 1, 1, "B2");
+    setCellText(tbl, 2, 0, "C1");
+    setCellText(tbl, 2, 1, "C2");
 
     const buf = await doc.save();
     const midDoc = await DocumentObject.load(buf);
 
     const engine = new RedlineEngine(midDoc);
-    const stats = engine.process_batch([{ type: 'delete_row', target_text: "B1" } as DeleteTableRow]);
+    const stats = engine.process_batch([
+      { type: "delete_row", target_text: "B1" } as DeleteTableRow,
+    ]);
 
     expect(stats.edits_applied).toBe(1);
 
@@ -144,17 +186,21 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(clean_text).toContain("C1 | C2");
   });
 
-  it('clean view naturally omits deleted row', async () => {
+  it("clean view naturally omits deleted row", async () => {
     const doc = await createTestDocument();
     const tbl = addTable(doc, 2, 2);
-    setCellText(tbl, 0, 0, "A1"); setCellText(tbl, 0, 1, "A2");
-    setCellText(tbl, 1, 0, "B1"); setCellText(tbl, 1, 1, "B2");
+    setCellText(tbl, 0, 0, "A1");
+    setCellText(tbl, 0, 1, "A2");
+    setCellText(tbl, 1, 0, "B1");
+    setCellText(tbl, 1, 1, "B2");
 
     const buf = await doc.save();
     const midDoc = await DocumentObject.load(buf);
 
     const engine = new RedlineEngine(midDoc);
-    engine.process_batch([{ type: 'delete_row', target_text: "B1" } as DeleteTableRow]);
+    engine.process_batch([
+      { type: "delete_row", target_text: "B1" } as DeleteTableRow,
+    ]);
 
     // Do NOT accept revisions, extract as Clean View directly
     const finalBuf = await midDoc.save();
@@ -163,4 +209,60 @@ describe('Table Interop & Engine (Node.js Port)', () => {
     expect(clean_text).toContain("A1 | A2");
     expect(clean_text).not.toContain("B1 | B2");
   });
-});
+  it("P0 Case 1: writes into an empty value cell via its {#cell:paraId} anchor", async () => {
+    const doc = await createTestDocument();
+    const tbl = addTable(doc, 1, 2);
+    setCellText(tbl, 0, 0, "Date");
+    // Leave cell (0,1) empty — mirrors the cloud-service-agreement form row.
+
+    // The empty cell's paragraph needs a w14:paraId for the anchor scheme.
+    const rows = Array.from(tbl.childNodes).filter(
+      (n) => (n as Element).tagName === "w:tr",
+    ) as Element[];
+    const cells = Array.from(rows[0].childNodes).filter(
+      (n) => (n as Element).tagName === "w:tc",
+    ) as Element[];
+    const emptyP = cells[1].getElementsByTagName("w:p")[0];
+    emptyP.setAttribute("w14:paraId", "DEADBEEF");
+
+    const buf = await doc.save();
+    const projected = await extractTextFromBuffer(buf, false);
+    // The anchor must be present and addressable.
+    expect(projected).toContain("{#cell:DEADBEEF}");
+
+    const midDoc = await DocumentObject.load(buf);
+    const engine = new RedlineEngine(midDoc);
+    // Target the anchor, insert text before it.
+    const stats = engine.process_batch([
+      {
+        type: "modify",
+        target_text: "{#cell:DEADBEEF}",
+        new_text: "June 22, 2026",
+      } as any,
+    ]);
+    expect(stats.edits_applied).toBe(1);
+
+    (engine as any).accept_all_revisions();
+    const cleanText = await extractTextFromBuffer(await midDoc.save(), true);
+    expect(cleanText).toContain("June 22, 2026");
+  });
+
+  it('P0 Case 2: anchored-regex miss on "( x )" yields a literal nearest-match hint', async () => {
+    const doc = await createTestDocument();
+    addParagraph(doc, "Some intro text. ( x ) Date of last signature.");
+    const engine = new RedlineEngine(doc);
+
+    const errors = engine.validate_edits([
+      {
+        type: "modify",
+        regex: true,
+        target_text: "^\\( x \\)$",
+        new_text: "",
+      } as any,
+    ]);
+    expect(errors.length).toBe(1);
+    expect(errors[0]).toContain("Target text not found");
+    expect(errors[0]).toContain('Did you mean the literal "( x )"');
+    expect(errors[0]).toContain("drop the ^/$ anchors");
+  });
+});