@adeu/core 1.14.0 → 1.15.0

package/src/models.ts

@@ -3,6 +3,8 @@ export interface ModifyText {
   target_text: string;
   new_text: string;
   comment?: string | null;
+  match_mode?: 'strict' | 'first' | 'all';
+  regex?: boolean;
   _match_start_index?: number | null;
   _internal_op?: string | null;
   _active_mapper_ref?: any | null; // Typed as DocumentMapper later

package/src/repro_heading_bug.test.ts

@@ -0,0 +1,174 @@
+import { describe, it, expect } from "vitest";
+import { createTestDocument, addParagraph } from "./test-utils.js";
+import { extractTextFromBuffer } from "./ingest.js";
+import { RedlineEngine } from "./engine.js";
+
+describe("QA Heading Bug Repro Verification", () => {
+  it("TC-1: # prefixed target, no duplicate — Node fails", async () => {
+    const doc = await createTestDocument();
+    
+    // Add Heading 1 paragraph
+    const p1 = doc.element.ownerDocument!.createElement('w:p');
+    const p1Pr = doc.element.ownerDocument!.createElement('w:pPr');
+    const p1Style = doc.element.ownerDocument!.createElement('w:pStyle');
+    p1Style.setAttribute('w:val', 'Heading1');
+    p1Pr.appendChild(p1Style);
+    p1.appendChild(p1Pr);
+    const r1 = doc.element.ownerDocument!.createElement('w:r');
+    const t1 = doc.element.ownerDocument!.createElement('w:t');
+    t1.textContent = '2. Confidentiality';
+    r1.appendChild(t1);
+    p1.appendChild(r1);
+    doc.element.appendChild(p1);
+
+    addParagraph(doc, "As defined in Section 1, the Recipient shall...");
+
+    const engine = new RedlineEngine(doc);
+    
+    const res = engine.process_batch([
+      {
+        type: "modify",
+        target_text: "# 2. Confidentiality",
+        new_text: "## 2. Confidentiality"
+      }
+    ]);
+
+    // Assert that the edit was successfully applied
+    expect(res.edits_applied).toBe(1);
+    expect(res.edits_skipped).toBe(0);
+
+    // Verify style of the paragraph changed to Heading2
+    const pStyle = p1.getElementsByTagName('w:pStyle')[0];
+    expect(pStyle).toBeDefined();
+    expect(pStyle.getAttribute('w:val')).toBe('Heading2');
+  });
+
+  it("TC-2: Bare target, duplicate in body — ambiguity error expected", async () => {
+    const doc = await createTestDocument();
+    
+    // Add Heading 1 paragraph
+    const p1 = doc.element.ownerDocument!.createElement('w:p');
+    const p1Pr = doc.element.ownerDocument!.createElement('w:pPr');
+    const p1Style = doc.element.ownerDocument!.createElement('w:pStyle');
+    p1Style.setAttribute('w:val', 'Heading1');
+    p1Pr.appendChild(p1Style);
+    p1.appendChild(p1Pr);
+    const r1 = doc.element.ownerDocument!.createElement('w:r');
+    const t1 = doc.element.ownerDocument!.createElement('w:t');
+    t1.textContent = '2. Confidentiality';
+    r1.appendChild(t1);
+    p1.appendChild(r1);
+    doc.element.appendChild(p1);
+
+    addParagraph(doc, "As defined in Section 1, the Recipient shall...");
+    addParagraph(doc, "Page footer notice: subject to NDA dated 2026-01-15.");
+    addParagraph(doc, "For further detail see section 2. Confidentiality above.");
+
+    const engine = new RedlineEngine(doc);
+
+    // Should throw BatchValidationError due to ambiguity
+    let caught: any = null;
+    try {
+      engine.process_batch([
+        {
+          type: "modify",
+          target_text: "2. Confidentiality",
+          new_text: "2. CONFIDENTIALITY"
+        }
+      ]);
+    } catch (e) {
+      caught = e;
+    }
+
+    expect(caught).toBeDefined();
+    expect(caught.name).toBe("BatchValidationError");
+    expect(caught.message).toContain("Ambiguous match");
+  });
+
+  it("TC-3: # prefixed target, duplicate in body — Node fails", async () => {
+    const doc = await createTestDocument();
+    
+    // Add Heading 1 paragraph
+    const p1 = doc.element.ownerDocument!.createElement('w:p');
+    const p1Pr = doc.element.ownerDocument!.createElement('w:pPr');
+    const p1Style = doc.element.ownerDocument!.createElement('w:pStyle');
+    p1Style.setAttribute('w:val', 'Heading1');
+    p1Pr.appendChild(p1Style);
+    p1.appendChild(p1Pr);
+    const r1 = doc.element.ownerDocument!.createElement('w:r');
+    const t1 = doc.element.ownerDocument!.createElement('w:t');
+    t1.textContent = '2. Confidentiality';
+    r1.appendChild(t1);
+    p1.appendChild(r1);
+    doc.element.appendChild(p1);
+
+    addParagraph(doc, "As defined in Section 1, the Recipient shall...");
+    addParagraph(doc, "Page footer notice: subject to NDA dated 2026-01-15.");
+    addParagraph(doc, "For further detail see section 2. Confidentiality above.");
+
+    const engine = new RedlineEngine(doc);
+    
+    const res = engine.process_batch([
+      {
+        type: "modify",
+        target_text: "# 2. Confidentiality",
+        new_text: "## 2. Confidentiality"
+      }
+    ]);
+
+    // Assert that the edit was successfully applied (resolving ambiguity)
+    expect(res.edits_applied).toBe(1);
+    expect(res.edits_skipped).toBe(0);
+
+    // Verify style of the paragraph changed to Heading2
+    const pStyle = p1.getElementsByTagName('w:pStyle')[0];
+    expect(pStyle).toBeDefined();
+    expect(pStyle.getAttribute('w:val')).toBe('Heading2');
+  });
+
+  it("TC-4: Bare target, no duplicate — Node matches heading but mishandles new_text", async () => {
+    const doc = await createTestDocument();
+    
+    // Add Heading 1 paragraph
+    const p1 = doc.element.ownerDocument!.createElement('w:p');
+    const p1Pr = doc.element.ownerDocument!.createElement('w:pPr');
+    const p1Style = doc.element.ownerDocument!.createElement('w:pStyle');
+    p1Style.setAttribute('w:val', 'Heading1');
+    p1Pr.appendChild(p1Style);
+    p1.appendChild(p1Pr);
+    const r1 = doc.element.ownerDocument!.createElement('w:r');
+    const t1 = doc.element.ownerDocument!.createElement('w:t');
+    t1.textContent = '2. Confidentiality';
+    r1.appendChild(t1);
+    p1.appendChild(r1);
+    doc.element.appendChild(p1);
+
+    addParagraph(doc, "As defined in Section 1, the Recipient shall...");
+
+    const engine = new RedlineEngine(doc);
+    
+    const res = engine.process_batch([
+      {
+        type: "modify",
+        target_text: "2. Confidentiality",
+        new_text: "## 2. Confidentiality"
+      }
+    ]);
+
+    expect(res.edits_applied).toBe(1);
+    expect(res.edits_skipped).toBe(0);
+
+    // Paragraph style should change to Heading2 (style id Heading2)
+    const pStyle = p1.getElementsByTagName('w:pStyle')[0];
+    expect(pStyle).toBeDefined();
+    expect(pStyle.getAttribute('w:val')).toBe('Heading2');
+
+    // Verify that the run text itself does not contain literal "##"
+    const textElements = p1.getElementsByTagName('w:t');
+    let rawText = "";
+    for (let j = 0; j < textElements.length; j++) {
+      rawText += textElements[j].textContent || "";
+    }
+    expect(rawText).not.toContain("##");
+  });
+});

package/src/search_write_engine.test.ts

@@ -0,0 +1,112 @@
+import { describe, it, expect } from 'vitest';
+import { createTestDocument, addParagraph } from './test-utils.js';
+import { RedlineEngine, BatchValidationError } from './engine.js';
+import { ModifyText } from './models.js';
+import { extractTextFromBuffer } from './ingest.js';
+
+describe('Search and Targeted Write Engine', () => {
+  
+  it('match_mode="strict" fails on duplicate targets', async () => {
+    const doc = await createTestDocument();
+    addParagraph(doc, "This is a repetitive clause.");
+    addParagraph(doc, "Some other text.");
+    addParagraph(doc, "This is a repetitive clause.");
+    
+    const engine = new RedlineEngine(doc);
+    
+    // We cast to any to bypass type checking since ModifyText doesn't have match_mode yet
+    const edits: any[] = [{
+      type: 'modify',
+      target_text: "This is a repetitive clause.",
+      new_text: "This is changed.",
+      match_mode: 'strict'
+    }];
+
+    expect(() => engine.process_batch(edits)).toThrowError(BatchValidationError);
+  });
+
+  it('match_mode="first" modifies only the first occurrence', async () => {
+    const doc = await createTestDocument();
+    addParagraph(doc, "This is a repetitive clause.");
+    addParagraph(doc, "This is a repetitive clause.");
+    
+    const engine = new RedlineEngine(doc);
+    const edits: any[] = [{
+      type: 'modify',
+      target_text: "This is a repetitive clause.",
+      new_text: "This is changed.",
+      match_mode: 'first'
+    }];
+
+    const stats = engine.process_batch(edits);
+    
+    // Should be applied successfully
+    expect(stats.edits_applied).toBe(1);
+
+    const buf = await doc.save();
+    const text = await extractTextFromBuffer(buf, true);
+    
+    // Only one occurrence should be modified in the accepted state
+    const newMatches = text.match(/This is changed/g);
+    expect(newMatches?.length).toBe(1);
+    
+    const oldMatches = text.match(/This is a repetitive clause/g);
+    expect(oldMatches?.length).toBe(1);
+  });
+
+  it('match_mode="all" modifies all occurrences', async () => {
+    const doc = await createTestDocument();
+    addParagraph(doc, "This is a repetitive clause.");
+    addParagraph(doc, "This is a repetitive clause.");
+    
+    const engine = new RedlineEngine(doc);
+    const edits: any[] = [{
+      type: 'modify',
+      target_text: "This is a repetitive clause.",
+      new_text: "This is changed.",
+      match_mode: 'all'
+    }];
+
+    const stats = engine.process_batch(edits);
+    
+    // It's still 1 edit instruction applied
+    expect(stats.edits_applied).toBe(1); 
+    
+    // The enriched report should show 2 occurrences modified
+    expect(stats.edits[0].occurrences_modified).toBe(2);
+
+    const buf = await doc.save();
+    const text = await extractTextFromBuffer(buf, true);
+    
+    // Both occurrences should be modified
+    const newMatches = text.match(/This is changed/g);
+    expect(newMatches?.length).toBe(2);
+  });
+
+  it('supports regex replacements with RegExp engine', async () => {
+    const doc = await createTestDocument();
+    addParagraph(doc, "Item cost: $500.");
+    addParagraph(doc, "Item cost: $1200.");
+    
+    const engine = new RedlineEngine(doc);
+    
+    // Using ES2022 RegExp capture group $1
+    const edits: any[] = [{
+      type: 'modify',
+      target_text: "Item cost: \\$(\\d+)\\.",
+      new_text: "Item cost: EUR $1.",
+      match_mode: 'all',
+      regex: true
+    }];
+
+    const stats = engine.process_batch(edits);
+    expect(stats.edits_applied).toBe(1);
+
+    const buf = await doc.save();
+    const text = await extractTextFromBuffer(buf, true);
+    
+    // Both should be correctly substituted
+    expect(text).toContain("EUR 500");
+    expect(text).toContain("EUR 1200");
+  });
+});