@adeildo/pi-ask-permission 4.1.0 → 5.0.0

package/src/ui/settings/judge.ts

@@ -1,299 +0,0 @@
-import type { Theme } from "@earendil-works/pi-coding-agent";
-import type { SettingItem } from "@earendil-works/pi-tui";
-
-import type { JudgeBackendId, JudgeConfig, JudgeFallback } from "#core/judge/config.ts";
-import {
-	detectPolicyPreset,
-	getPolicyPreset,
-	POLICY_PRESETS,
-	policyWarning,
-} from "#core/judge/policy.ts";
-import { PickerList } from "#ui/picker.ts";
-
-const PROVIDER_LABEL: Record<JudgeBackendId, string> = {
-	jev: "Jev",
-	pi: "A pi model",
-};
-
-const FALLBACK_LABEL: Record<JudgeFallback, string> = {
-	ask: "Ask me",
-	allow: "Allow",
-	deny: "Deny",
-};
-
-export const JEV_MODELS = ["jev-latest", "jev-preview", "jev-1.13.0"];
-
-interface ToolPreset {
-	label: string;
-	tools: string[];
-}
-
-const TOOL_PRESETS: ToolPreset[] = [
-	{ label: "Bash only", tools: ["bash"] },
-	{ label: "Bash and file writes", tools: ["bash", "write", "edit"] },
-	{ label: "Every tool", tools: ["*"] },
-];
-
-export interface JudgeSettingsHooks {
-	config: JudgeConfig;
-	theme: Theme;
-
-	piModels: string[];
-	save: () => void;
-	editPolicy: () => void;
-	editModel: () => void;
-}
-
-export interface JudgeSettings {
-	items: SettingItem[];
-	onChange: (id: string, value: string) => void;
-}
-
-type SubmenuDone = (selectedValue?: string, options?: { navigateTo?: string }) => void;
-
-export function buildJudgeSettings(hooks: JudgeSettingsHooks): JudgeSettings {
-	const values = judgeValues(hooks.config);
-	const item = (id: JudgeSettingId, label: string, description: string): SettingItem => ({
-		id,
-		label,
-		currentValue: values[id],
-		description,
-	});
-	const choice = (id: JudgeSettingId, label: string, choices: string[], description: string) => ({
-		...item(id, label, description),
-		values: choices,
-	});
-	const onOff = (id: JudgeSettingId, label: string, description: string) =>
-		choice(id, label, ["off", "on"], description);
-	const fallbacks = Object.values(FALLBACK_LABEL);
-
-	return {
-		items: [
-			choice(
-				"judge.provider",
-				"Provider",
-				Object.values(PROVIDER_LABEL),
-				"Jev answers fast, with a confidence. A pi model uses one you already set up.",
-			),
-			{
-				...item(
-					"judge.model",
-					"Model",
-					hooks.config.provider === "jev"
-						? "A Jev alias, or a pinned version."
-						: "The judge asks it for strict JSON.",
-				),
-				submenu: (_current, done) => modelPicker(hooks, done),
-			},
-			onOff("judge.canDeny", "Can deny", "A confident no blocks the call. Off, it comes to you."),
-			choice("judge.whenUnsure", "When unsure", fallbacks, "When the judge is not confident."),
-			choice(
-				"judge.whenItFails",
-				"When it fails",
-				fallbacks,
-				"On a timeout, an error, or a missing key.",
-			),
-			choice(
-				"judge.tools",
-				"Tools",
-				TOOL_PRESETS.map((preset) => preset.label),
-				"The judge decides these. The rest come to you.",
-			),
-			{
-				...item("judge.policy", "Policy", policyDescription(hooks.config.policy)),
-				submenu: (_current, done) => policyPicker(hooks, done),
-			},
-			onOff("judge.dryRun", "Dry run", "Show the verdict, and still ask you."),
-			onOff("judge.noUI", "Judge with no UI", "Also judge print, JSON, and subagent runs."),
-			onOff(
-				"judge.rememberApprovals",
-				"Remember approvals",
-				"A judge approval becomes always yes for this session.",
-			),
-		],
-		onChange: (id, value) => {
-			apply(hooks, id, value);
-			hooks.save();
-		},
-	};
-}
-
-export type JudgeSettingId =
-	| "judge.provider"
-	| "judge.model"
-	| "judge.canDeny"
-	| "judge.whenUnsure"
-	| "judge.whenItFails"
-	| "judge.tools"
-	| "judge.policy"
-	| "judge.dryRun"
-	| "judge.noUI"
-	| "judge.rememberApprovals";
-
-export function judgeValues(config: JudgeConfig): Record<JudgeSettingId, string> {
-	return {
-		"judge.provider": PROVIDER_LABEL[config.provider],
-		"judge.model": config.model || "(none)",
-		"judge.canDeny": toggle(config.canDeny),
-		"judge.whenUnsure": FALLBACK_LABEL[config.whenUnsure],
-		"judge.whenItFails": FALLBACK_LABEL[config.whenItFails],
-		"judge.tools": toolsLabel(config.tools),
-		"judge.policy": policyLabel(config.policy),
-		"judge.dryRun": toggle(config.dryRun),
-		"judge.noUI": toggle(config.noUI),
-		"judge.rememberApprovals": toggle(config.rememberApprovals),
-	};
-}
-
-function apply(hooks: JudgeSettingsHooks, id: string, value: string): void {
-	const judge = hooks.config;
-
-	switch (id) {
-		case "judge.provider":
-			judge.provider = value === PROVIDER_LABEL.pi ? "pi" : "jev";
-			judge.model = defaultModelFor(judge.provider, hooks.piModels, judge.model);
-			return;
-		case "judge.model":
-			judge.model = value;
-			return;
-		case "judge.canDeny":
-			judge.canDeny = value === "on";
-			return;
-		case "judge.whenUnsure":
-			judge.whenUnsure = fallbackFromLabel(value);
-			return;
-		case "judge.whenItFails":
-			judge.whenItFails = fallbackFromLabel(value);
-			return;
-		case "judge.tools":
-			judge.tools = toolsFromLabel(value) ?? judge.tools;
-			return;
-		case "judge.policy": {
-			const preset = POLICY_PRESETS.find((entry) => entry.label === value);
-			if (preset) judge.policy = preset.policy;
-			return;
-		}
-		case "judge.dryRun":
-			judge.dryRun = value === "on";
-			return;
-		case "judge.noUI":
-			judge.noUI = value === "on";
-			return;
-		case "judge.rememberApprovals":
-			judge.rememberApprovals = value === "on";
-			return;
-	}
-}
-
-function defaultModelFor(provider: JudgeBackendId, piModels: string[], current: string): string {
-	if (provider === "jev") return JEV_MODELS.includes(current) ? current : "jev-latest";
-	if (piModels.includes(current)) return current;
-	return piModels[0] ?? "";
-}
-
-function modelPicker(hooks: JudgeSettingsHooks, done: SubmenuDone): PickerList {
-	const items =
-		hooks.config.provider === "jev"
-			? [
-					...JEV_MODELS.map((model) => ({
-						id: model,
-						label: model,
-						description:
-							model === "jev-latest" ? "The current stable release (recommended)" : undefined,
-					})),
-					{ id: "__other", label: "Other\u2026", description: "Type a model id or pinned version" },
-				]
-			: hooks.piModels.length > 0
-				? hooks.piModels.map((model) => ({ id: model, label: model }))
-				: [
-						{
-							id: "__none",
-							label: "No models available",
-							description: "Configure a model in pi first",
-						},
-					];
-
-	return new PickerList(
-		hooks.config.provider === "jev" ? "Jev model" : "pi model",
-		items,
-		hooks.theme,
-		(id) => {
-			if (id === "__other") {
-				hooks.editModel();
-				return;
-			}
-			if (id !== "__none") done(id);
-		},
-		() => done(),
-		undefined,
-		hooks.config.model,
-	);
-}
-
-function policyPicker(hooks: JudgeSettingsHooks, done: SubmenuDone): PickerList {
-	const items = [
-		...POLICY_PRESETS.filter((preset) => preset.id !== "custom").map((preset) => ({
-			id: preset.id,
-			label: preset.label,
-			description: preset.description,
-		})),
-		{
-			id: "__edit",
-			label: "Edit policy\u2026",
-			description: "Write your own rules in a full editor",
-		},
-	];
-
-	return new PickerList(
-		"Policy",
-		items,
-		hooks.theme,
-		(id) => {
-			if (id === "__edit") {
-				hooks.editPolicy();
-				return;
-			}
-			const preset = getPolicyPreset(id);
-			if (preset) done(preset.label);
-		},
-		() => done(),
-		undefined,
-		detectPolicyPreset(hooks.config.policy),
-	);
-}
-
-function toggle(value: boolean): string {
-	return value ? "on" : "off";
-}
-
-function fallbackFromLabel(label: string): JudgeFallback {
-	if (label === "Allow") return "allow";
-	if (label === "Deny") return "deny";
-	return "ask";
-}
-
-function toolsLabel(tools: string[]): string {
-	const match = TOOL_PRESETS.find((preset) => sameList(preset.tools, tools));
-	return match?.label ?? "Custom";
-}
-
-function toolsFromLabel(label: string): string[] | undefined {
-	return TOOL_PRESETS.find((preset) => preset.label === label)?.tools;
-}
-
-function sameList(left: string[], right: string[]): boolean {
-	return left.length === right.length && left.every((value, index) => value === right[index]);
-}
-
-function policyLabel(policy: string): string {
-	if (policy.trim() === "") return "(none yet)";
-	return getPolicyPreset(detectPolicyPreset(policy))?.label ?? "Custom";
-}
-
-function policyDescription(policy: string): string {
-	const warning = policyWarning(policy);
-	if (warning) return warning;
-
-	const preset = getPolicyPreset(detectPolicyPreset(policy));
-	return preset?.description ?? "The judge reads this as the rulebook for what may run.";
-}

package/src/ui/settings/screen.ts

@@ -1,268 +0,0 @@
-import { type ExtensionContext, getSettingsListTheme } from "@earendil-works/pi-coding-agent";
-import { Container, type SettingItem, SettingsList, Text } from "@earendil-works/pi-tui";
-
-import type { AlwaysYes } from "#core/always-yes.ts";
-import {
-	isNoteDelivery,
-	isNoUIMode,
-	isOutsideScope,
-	type OutsideScope,
-	type PermissionConfig,
-} from "#core/config/schema.ts";
-import { POLICY_TEMPLATE, policyWarning } from "#core/judge/policy.ts";
-import { MODE_LABEL, modeFromLabel, PERMISSION_MODES, type PermissionMode } from "#core/mode.ts";
-import { NAME } from "#identity";
-import { buildJudgeSettings, type JudgeSettings, judgeValues } from "#ui/settings/judge.ts";
-import { notifyJudgePolicyWarning } from "#ui/settings/status.ts";
-
-export interface SettingsState {
-	config: PermissionConfig;
-	alwaysYes: AlwaysYes;
-	mode: () => PermissionMode;
-	setMode: (mode: PermissionMode) => void;
-	save: () => void;
-	onJudgeChange: () => void;
-}
-
-type SettingsRequest = { kind: "policy" } | { kind: "model" } | undefined;
-
-export async function openSettings(ctx: ExtensionContext, state: SettingsState): Promise<void> {
-	for (;;) {
-		// oxlint-disable-next-line no-await-in-loop -- the menu loop is sequential by design.
-		const request = await showSettings(ctx, state);
-		if (!request) return;
-
-		if (request.kind === "policy") {
-			// oxlint-disable-next-line no-await-in-loop -- one editor at a time.
-			await editPolicy(ctx, state);
-			continue;
-		}
-
-		// oxlint-disable-next-line no-await-in-loop -- one prompt at a time.
-		await editModel(ctx, state);
-	}
-}
-
-async function editPolicy(ctx: ExtensionContext, state: SettingsState): Promise<void> {
-	const judge = state.config.judge;
-	const text = await ctx.ui.editor("Judge policy", judge.policy || POLICY_TEMPLATE);
-	if (text === undefined) return;
-
-	judge.policy = text;
-	state.save();
-	state.onJudgeChange();
-
-	const warning = policyWarning(text);
-	if (warning) ctx.ui.notify(`${NAME}: ${warning}`, "warning");
-}
-
-async function editModel(ctx: ExtensionContext, state: SettingsState): Promise<void> {
-	const text = await ctx.ui.input("Jev model", "jev-latest");
-	const model = text?.trim();
-	if (!model) return;
-
-	state.config.judge.model = model;
-	state.save();
-	state.onJudgeChange();
-}
-
-const SETTINGS_VISIBLE = 18;
-
-async function showSettings(ctx: ExtensionContext, state: SettingsState): Promise<SettingsRequest> {
-	let request: SettingsRequest;
-
-	await ctx.ui.custom<void>((_tui, theme, _keybindings, done) => {
-		const close = () => done(undefined);
-		const container = new Container();
-		let settings: SettingsList | undefined;
-		let judgeSettings: JudgeSettings | undefined;
-
-		const hooks = {
-			config: state.config.judge,
-			theme,
-			piModels: piModelIds(ctx),
-			save: () => {
-				state.save();
-				state.onJudgeChange();
-			},
-			editPolicy: () => {
-				request = { kind: "policy" };
-				close();
-			},
-			editModel: () => {
-				request = { kind: "model" };
-				close();
-			},
-		};
-
-		const buildItems = (): SettingItem[] => {
-			judgeSettings = buildJudgeSettings(hooks);
-			const children = state.config.judge.enabled
-				? judgeSettings.items.map((item) => ({ ...item, label: `  ${item.label}` }))
-				: [];
-
-			return topLevelItems(state.config, state.mode(), children);
-		};
-
-		const install = (focusId: string): void => {
-			if (settings) container.removeChild(settings);
-			settings = new SettingsList(
-				buildItems(),
-				SETTINGS_VISIBLE,
-				getSettingsListTheme(),
-				onChange,
-				close,
-			);
-			container.addChild(settings);
-			settings.selectItem(focusId);
-		};
-
-		const refreshModelRow = (): void => {
-			settings?.updateValue("judge.model", judgeValues(state.config.judge)["judge.model"]);
-		};
-
-		const onChange = (id: string, value: string): void => {
-			if (id === "judge.enabled") {
-				state.config.judge.enabled = value === "on";
-				state.save();
-				state.onJudgeChange();
-				install("judge.enabled");
-				notifyJudgePolicyWarning(state.config, ctx);
-				return;
-			}
-
-			if (id.startsWith("judge.")) {
-				judgeSettings?.onChange(id, value);
-				refreshModelRow();
-				return;
-			}
-
-			if (id === "mode") {
-				const mode = modeFromLabel(value);
-				if (mode) state.setMode(mode);
-				install("mode");
-				return;
-			}
-
-			if (id === "workspace.outside" && isOutsideScope(value)) {
-				state.config.workspace.outside = value;
-				state.save();
-				state.setMode(state.mode());
-				return;
-			}
-
-			if (id === "notes" && isNoteDelivery(value)) state.config.notes = value;
-			else if (id === "noUI" && isNoUIMode(value)) state.config.noUI = value;
-			else if (id === "readOnlyBash") state.config.readOnlyBash = value === "on";
-			state.save();
-		};
-
-		container.addChild(
-			new Text(
-				theme.fg("accent", theme.bold(NAME)) +
-					theme.fg("dim", `  \u00b7  ${alwaysYesCount(state.alwaysYes.total())}`),
-				1,
-				1,
-			),
-		);
-		install("mode");
-
-		return {
-			render: (width: number) => container.render(width),
-			invalidate: () => container.invalidate(),
-			handleInput: (data: string) => settings?.handleInput?.(data),
-		};
-	});
-
-	return request;
-}
-
-export function topLevelItems(
-	config: PermissionConfig,
-	mode: PermissionMode,
-	judgeChildren: SettingItem[],
-): SettingItem[] {
-	const items = [modeItem(mode), outsideItem(config), notesItem(config)];
-	if (mode !== "auto") items.push(readOnlyBashItem(config));
-
-	return [...items, judgeToggleItem(config), ...judgeChildren, noUIItem(config)];
-}
-
-function notesItem(config: PermissionConfig): SettingItem {
-	return {
-		id: "notes",
-		label: "Notes",
-		currentValue: config.notes,
-		values: ["result", "message"],
-		description: "result adds your note to the tool result. message sends it on its own.",
-	};
-}
-
-export function outsideItem(config: PermissionConfig): SettingItem {
-	const outside = config.workspace.outside;
-	return {
-		id: "workspace.outside",
-		label: "Outside the workspace",
-		currentValue: outside,
-		values: ["ask", "deny", "allow"],
-		description: OUTSIDE_DESCRIPTION[outside],
-	};
-}
-
-const OUTSIDE_DESCRIPTION: Record<OutsideScope, string> = {
-	ask: "A call outside workspace.roots asks you. The judge never sees it.",
-	deny: "A call outside workspace.roots is blocked.",
-	allow: "No boundary. auto runs everything, anywhere.",
-};
-
-export function readOnlyBashItem(config: PermissionConfig): SettingItem {
-	return {
-		id: "readOnlyBash",
-		label: "Read-only bash",
-		currentValue: config.readOnlyBash ? "on" : "off",
-		values: ["off", "on"],
-		description: "Commands that only read run without asking.",
-	};
-}
-
-export function judgeToggleItem(config: PermissionConfig): SettingItem {
-	return {
-		id: "judge.enabled",
-		label: "Judge",
-		currentValue: config.judge.enabled ? "on" : "off",
-		values: ["off", "on"],
-		description: "A model answers first. Only the calls it is unsure about reach you.",
-	};
-}
-
-function noUIItem(config: PermissionConfig): SettingItem {
-	return {
-		id: "noUI",
-		label: "With no UI",
-		currentValue: typeof config.noUI === "string" ? config.noUI : "per tool",
-		values: ["deny", "allow"],
-		description: "When nobody can answer, as in print mode or a subagent.",
-	};
-}
-
-export function modeItem(mode: PermissionMode): SettingItem {
-	return {
-		id: "mode",
-		label: "Mode (this session)",
-		currentValue: MODE_LABEL[mode],
-		values: PERMISSION_MODES.map((entry) => MODE_LABEL[entry]),
-		description:
-			"manual asks. accept edits runs file edits. auto runs everything in the workspace.",
-	};
-}
-
-function piModelIds(ctx: ExtensionContext): string[] {
-	return ctx.modelRegistry
-		.getAvailable()
-		.map((model) => `${model.provider}/${model.id}`)
-		.toSorted((left, right) => left.localeCompare(right));
-}
-
-export function alwaysYesCount(count: number): string {
-	return `${count} always yes`;
-}

package/src/ui/settings/status.ts

@@ -1,53 +0,0 @@
-import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-
-import { type AlwaysYes, SCOPE_LABEL, SCOPES } from "#core/always-yes.ts";
-import type { PermissionConfig } from "#core/config/schema.ts";
-import { configPath, globalAlwaysYesPath, projectAlwaysYesPath } from "#core/config/store.ts";
-import { policyWarning } from "#core/judge/policy.ts";
-import { MODE_LABEL, type PermissionMode } from "#core/mode.ts";
-import { NAME } from "#identity";
-
-export function notifyJudgePolicyWarning(config: PermissionConfig, ctx: ExtensionContext): void {
-	if (!config.judge.enabled) return;
-
-	const warning = policyWarning(config.judge.policy);
-	if (warning) ctx.ui.notify(`${NAME}: ${warning}`, "warning");
-}
-
-export function statusText(
-	config: PermissionConfig,
-	alwaysYes: AlwaysYes,
-	cwd: string,
-	mode: PermissionMode,
-): string {
-	const noUI = typeof config.noUI === "string" ? config.noUI : JSON.stringify(config.noUI);
-
-	return [
-		`${NAME} \u00b7 ${configPath()}`,
-		`allow: ${config.allow.join(", ") || "(none)"}`,
-		`mode: ${MODE_LABEL[mode]} (this session)`,
-		`notes: ${config.notes} \u00b7 noUI: ${noUI}`,
-		`typing: pause ${config.typing.pause}ms \u00b7 maxWait ${config.typing.maxWait ?? "none"}`,
-		`readOnlyBash: ${config.readOnlyBash ? "on" : "off"}`,
-		`workspace: ${config.workspace.roots.join(", ")} \u00b7 outside: ${config.workspace.outside}`,
-		judgeLine(config),
-		`always yes: ${SCOPES.map((scope) => `${alwaysYes.size(scope)} ${SCOPE_LABEL[scope]}`).join(" \u00b7 ")}`,
-		`always yes for this project: ${projectAlwaysYesPath(cwd)}`,
-		`always yes everywhere: ${globalAlwaysYesPath()}`,
-	].join("\n");
-}
-
-function judgeLine(config: PermissionConfig): string {
-	const judge = config.judge;
-	if (!judge.enabled) return `judge: off \u00b7 ${judge.provider}/${judge.model}`;
-
-	const policy = judge.policy.trim() === "" ? "no policy" : "policy set";
-	const tags = [
-		judge.dryRun ? "dry run" : undefined,
-		judge.canDeny ? undefined : "cannot deny",
-		judge.noUI ? "no UI" : undefined,
-		policy,
-	].filter((tag): tag is string => tag !== undefined);
-
-	return `judge: on \u00b7 ${judge.provider}/${judge.model} \u00b7 tools ${judge.tools.join(",") || "(none)"} \u00b7 ${tags.join(" \u00b7 ")}`;
-}