@adea-ai/plugins 4.0.1 → 4.0.7

package/src/index.test.ts

@@ -108,6 +108,9 @@ const policy: CatalogPolicy = {
   ],
 }
 
+/** Upstream failures retry immediately, so retry tests do not wait out real backoff. */
+const RETRY_NOW = { 'retry-after': '0' }
+
 function stubFetch(handler: (url: string) => Response | Promise<Response>) {
   const original = globalThis.fetch
   const calls: string[] = []
@@ -233,6 +236,23 @@ describe('source adapters', () => {
     expect(gitSource.kind === 'git' ? gitSource.subdirectory : undefined).toBe('plugins/demo')
   })
 
+  test('leaves out entries with an unsupported source kind and keeps the rest', () => {
+    const parsed = parseMarketplaceManifest(
+      {
+        plugins: [
+          { name: 'xcode', source: { source: 'command', command: 'install-xcode-plugin' } },
+          { name: 'demo', source: './plugins/demo' },
+        ],
+      },
+      sources[0]!
+    )
+    expect(parsed.entries.map((entry) => entry.name)).toEqual(['demo'])
+    expect(parsed.unsupportedEntries).toEqual(['xcode: command'])
+    expect(() => parseSourceSpec({ source: 'command' }, sources[0]!, 'xcode')).toThrow(
+      'PLUGIN_SOURCE_KIND_UNSUPPORTED'
+    )
+  })
+
   test('rejects duplicate keys, traversal, and unsupported URL schemes', () => {
     expect(() => parseJsonDocument('{"plugins":[],"plugins":[]}')).toThrow('JSON_DUPLICATE_KEY')
     expect(() => parseSourceSpec({ source: 'local', path: '../outside' }, sources[0]!)).toThrow(
@@ -723,37 +743,6 @@ describe('deterministic catalog synchronization', () => {
       await rm(parent, { recursive: true, force: true })
     }
   })
-
-  test('keeps a failed build from producing a new artifact set', async () => {
-    const first = await synchronize({
-      sources,
-      categoryMap,
-      productAliases,
-      policy,
-      mode: 'offline',
-      fixtureRoot: join(process.cwd(), 'fixtures'),
-    })
-    const outputDirectory = join(await mkdtemp(join(tmpdir(), 'plugin-lkg-')), 'generated')
-    await writeArtifacts(outputDirectory, first.artifacts!)
-    const previousCatalog = await readFile(join(outputDirectory, 'catalog.v1.json'), 'utf8')
-    await expect(
-      synchronize({
-        sources,
-        categoryMap,
-        productAliases,
-        policy,
-        mode: 'offline',
-        fixtureRoot: join(process.cwd(), 'fixtures'),
-        snapshotLoader: {
-          load: async () => {
-            throw new Error('UPSTREAM_FETCH_FAILED')
-          },
-        },
-      })
-    ).rejects.toThrow('UPSTREAM_FETCH_FAILED')
-    expect(first.artifacts?.['catalog.v1.json']).toContain(first.catalog?.catalogId)
-    expect(await readFile(join(outputDirectory, 'catalog.v1.json'), 'utf8')).toBe(previousCatalog)
-  })
 })
 
 describe('identity, classification, and harness contracts', () => {
@@ -762,11 +751,16 @@ describe('identity, classification, and harness contracts', () => {
       stablePluginId('cursor-official', 'gmail')
     )
     expect(stablePluginId('--OpenAI--', '---Gmail---')).toBe('plugin:openai:gmail')
-    expect(
-      stableReleaseId('https://github.com/acme/a', 'plugins/x', 'a'.repeat(40), digest('same'))
-    ).toBe(
-      stableReleaseId('https://github.com/acme/a', 'plugins/x', 'a'.repeat(40), digest('same'))
+    const releaseId = stableReleaseId(
+      'https://github.com/acme/a',
+      'plugins/x',
+      'a'.repeat(40),
+      digest('same')
     )
+    expect(releaseId).toMatch(/^release:[a-f0-9]{64}$/)
+    expect(
+      stableReleaseId('https://github.com/acme/a', 'plugins/x', 'a'.repeat(40), digest('other'))
+    ).not.toBe(releaseId)
     expect(
       bytesDigest(
         new Map([
@@ -796,15 +790,25 @@ describe('filesystem safety', () => {
     expect(snapshot.symlinks).toEqual(['plugin'])
   })
 
-  test('enforces file and archive-like size limits', async () => {
-    const root = await mkdtemp(join(tmpdir(), 'plugins-size-'))
-    await mkdir(join(root, 'plugin'), { recursive: true })
-    await writeFile(join(root, 'plugin', 'large.txt'), '1234567890')
-    const snapshot = await snapshotFromDirectory(root, 'plugin')
-    expect(snapshot.files.size).toBe(1)
-    expect(() => {
-      if ([...snapshot.files.values()][0]!.byteLength > 5) throw new Error('PLUGIN_FILE_TOO_LARGE')
-    }).toThrow('PLUGIN_FILE_TOO_LARGE')
+  test('skips a plugin with a file over the size limit', async () => {
+    const result = await synchronize({
+      sources,
+      categoryMap,
+      productAliases,
+      policy: { ...policy, maxFileBytes: 5 },
+      mode: 'offline',
+      fixtureRoot: join(process.cwd(), 'fixtures'),
+      snapshotLoader: {
+        load: async () => ({
+          files: new Map([['large.txt', new TextEncoder().encode('1234567890')]]),
+          symlinks: [],
+        }),
+      },
+    })
+    const reasons = result.changeReport.skippedPlugins.map((skipped) => skipped.reasonCode)
+    expect(reasons.length).toBeGreaterThan(0)
+    expect(new Set(reasons)).toEqual(new Set(['PLUGIN_FILE_TOO_LARGE']))
+    expect(result.catalog?.plugins).toEqual([])
   })
 })
 
@@ -858,7 +862,7 @@ describe('upstream fetch quarantine', () => {
     const stub = stubFetch(async (url) => {
       if (url === treeUrl) {
         treeCalls += 1
-        if (treeCalls < 3) return new Response('busy', { status: 500 })
+        if (treeCalls < 3) return new Response('busy', { status: 500, headers: RETRY_NOW })
         return jsonResponse(treePayload(['plugins/demo/plugin.json']))
       }
       if (isArchive(url))
@@ -877,7 +881,7 @@ describe('upstream fetch quarantine', () => {
 
   test('quarantines a plugin when the repository tree stays unavailable', async () => {
     const stub = stubFetch((url) => {
-      if (url === treeUrl) return new Response('down', { status: 500 })
+      if (url === treeUrl) return new Response('down', { status: 500, headers: RETRY_NOW })
       return new Response('unexpected', { status: 500 })
     })
     try {
@@ -921,7 +925,7 @@ describe('upstream fetch quarantine', () => {
       if (isArchive(url))
         return recovered
           ? tarballResponse([{ path: 'plugins/demo/plugin.json', body: manifestBytes }])
-          : new Response('broken', { status: 500 })
+          : new Response('broken', { status: 500, headers: RETRY_NOW })
       return new Response('unexpected', { status: 200 })
     })
     try {
@@ -1153,7 +1157,7 @@ describe('upstream fetch quarantine', () => {
   })
 
   test('fails closed when every plugin in a source is unreachable', async () => {
-    const stub = stubFetch(() => new Response('down', { status: 500 }))
+    const stub = stubFetch(() => new Response('down', { status: 500, headers: RETRY_NOW }))
     try {
       await expect(
         buildCatalog({