@addai/node 0.30.0 → 0.30.1

package/dist/desktop/learn/browser.d.ts

@@ -4,6 +4,28 @@ export declare const DEBUG_PORT = 9222;
  *  it would point the wrapper at itself and exec forever. */
 export declare const REAL_BROWSERS: string[];
 export declare const WRAPPER_PATH = "/usr/local/bin/browser";
+/**
+ * A line of the wrapper distinctive enough to recognise it by.
+ *
+ * ⚠️ This exists because the wrapper used to destroy the browser it wraps.
+ *
+ * In the image WRAPPER_PATH is a SYMLINK — `ln -sf /usr/bin/chromium
+ * /usr/local/bin/browser`. `cp` follows a symlink destination and writes
+ * THROUGH it, so `cp wrapper /usr/local/bin/browser` overwrote /usr/bin/
+ * chromium — the real browser — with a script whose last line is
+ *
+ *     exec /usr/bin/chromium --remote-debugging-port=9222 ... "$@"
+ *
+ * which is now itself. Each hop re-appended the flags and passed the lot on
+ * as "$@", so a single launch exec'd itself until the argument list blew up.
+ * From the outside: the browser simply never opened, and the flags appeared
+ * hundreds of times over in ps.
+ *
+ * The write is fixed below. This marker is the second line of defence: a
+ * candidate that is really this wrapper is never treated as a real browser,
+ * so the loop cannot be rebuilt even if something else recreates the shape.
+ */
+export declare const WRAPPER_MARKER = "Written by @addai/node";
 /** The in-container script that signs the browser in. Beside the extension,
  *  under the same bind mount, so it arrives by the same route. */
 export declare const SEED_SCRIPT = "/conf/vault/vault-seed.mjs";

package/dist/desktop/learn/browser.js

@@ -33,7 +33,7 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.SEED_SCRIPT = exports.WRAPPER_PATH = exports.REAL_BROWSERS = exports.DEBUG_PORT = void 0;
+exports.SEED_SCRIPT = exports.WRAPPER_MARKER = exports.WRAPPER_PATH = exports.REAL_BROWSERS = exports.DEBUG_PORT = void 0;
 exports.wrapperScript = wrapperScript;
 exports.wrapperIsCurrent = wrapperIsCurrent;
 exports.ensureBrowserWrapper = ensureBrowserWrapper;
@@ -65,6 +65,28 @@ exports.REAL_BROWSERS = [
     '/usr/bin/chromium-browser',
 ];
 exports.WRAPPER_PATH = '/usr/local/bin/browser';
+/**
+ * A line of the wrapper distinctive enough to recognise it by.
+ *
+ * ⚠️ This exists because the wrapper used to destroy the browser it wraps.
+ *
+ * In the image WRAPPER_PATH is a SYMLINK — `ln -sf /usr/bin/chromium
+ * /usr/local/bin/browser`. `cp` follows a symlink destination and writes
+ * THROUGH it, so `cp wrapper /usr/local/bin/browser` overwrote /usr/bin/
+ * chromium — the real browser — with a script whose last line is
+ *
+ *     exec /usr/bin/chromium --remote-debugging-port=9222 ... "$@"
+ *
+ * which is now itself. Each hop re-appended the flags and passed the lot on
+ * as "$@", so a single launch exec'd itself until the argument list blew up.
+ * From the outside: the browser simply never opened, and the flags appeared
+ * hundreds of times over in ps.
+ *
+ * The write is fixed below. This marker is the second line of defence: a
+ * candidate that is really this wrapper is never treated as a real browser,
+ * so the loop cannot be rebuilt even if something else recreates the shape.
+ */
+exports.WRAPPER_MARKER = 'Written by @addai/node';
 /** The in-container script that signs the browser in. Beside the extension,
  *  under the same bind mount, so it arrives by the same route. */
 exports.SEED_SCRIPT = '/conf/vault/vault-seed.mjs';
@@ -112,10 +134,28 @@ function wrapperIsCurrent(content, realBrowser, extensionDir) {
  * cheap execs and no change.
  */
 async function ensureBrowserWrapper(run, confDir, extensionDir) {
+    // Each candidate is classified, not just found: one that is really this
+    // wrapper (see WRAPPER_MARKER) is a browser an older build overwrote, and
+    // pointing a new wrapper at it would rebuild the exec loop.
     const found = await run(['sh', '-c',
-        exports.REAL_BROWSERS.map(b => `[ -x ${b} ] && echo ${b}`).join(' || ') + ' || true']);
-    const real = found.out.trim().split('\n')[0]?.trim();
+        `for b in ${exports.REAL_BROWSERS.join(' ')}; do [ -x "$b" ] || continue; ` +
+            `if head -c 512 "$b" 2>/dev/null | grep -qF '${exports.WRAPPER_MARKER}'; ` +
+            `then echo "wrapped $b"; else echo "real $b"; fi; done`]);
+    const lines = found.out.trim().split('\n').map(l => l.trim()).filter(Boolean);
+    const real = lines.find(l => l.startsWith('real '))?.slice(5);
     if (!real) {
+        const wrapped = lines.find(l => l.startsWith('wrapped '))?.slice(8);
+        if (wrapped) {
+            // Deliberately not repaired from here. Putting the browser back means
+            // reinstalling its package — a network install, on every start, on a
+            // machine that is somebody's desktop — and this path is meant to be two
+            // cheap execs. Rebuilding the desktop restores it from the image.
+            return {
+                changed: false, browser: null,
+                note: `${wrapped} was overwritten by an older version of this wrapper `
+                    + 'and no longer starts a browser. Rebuild this desktop to restore it.',
+            };
+        }
         return { changed: false, browser: null, note: 'this desktop has no browser installed' };
     }
     const current = await run(['sh', '-c', `cat ${exports.WRAPPER_PATH} 2>/dev/null || true`]);
@@ -127,8 +167,15 @@ async function ensureBrowserWrapper(run, confDir, extensionDir) {
     // sudo, not `docker exec -u root`: the image gives the entity passwordless
     // sudo inside its own container, and going through the same exec path as
     // everything else keeps one way of talking to a desktop rather than two.
+    // ⚠️ rm FIRST, and it is the whole fix. In the image WRAPPER_PATH is a
+    // symlink to the real browser, and `cp` follows a symlink destination —
+    // writing through it, over the browser, rather than replacing the link.
+    // Unlinking first makes the wrapper a file of its own and leaves whatever
+    // it pointed at alone. (`cp --remove-destination` does the same in one
+    // call; this shape says why out loud and needs no GNU-only flag.)
     const put = await run(['sh', '-c',
-        `sudo cp /conf/learn/browser ${exports.WRAPPER_PATH} && sudo chmod +x ${exports.WRAPPER_PATH}`]);
+        `sudo rm -f ${exports.WRAPPER_PATH} && sudo cp /conf/learn/browser ${exports.WRAPPER_PATH} `
+            + `&& sudo chmod +x ${exports.WRAPPER_PATH}`]);
     if (!put.ok) {
         return { changed: false, browser: real, note: `could not install the browser wrapper: ${put.out.trim().slice(0, 200)}` };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@addai/node",
-  "version": "0.30.0",
+  "version": "0.30.1",
   "description": "Daemon that pairs a machine with your +Ai account and runs Claude / Codex / Kimi / Gemini agents on its behalf. Reachable via Supabase from Vault, Entity Studio, or any other +Ai surface.",
   "license": "MIT",
   "keywords": [