@adcp/sdk 14.0.0-beta.11 → 14.0.0-beta.13

package/dist/lib/server/decisioning/runtime/from-platform.mjs

@@ -44,7 +44,10 @@ import { _extractResponseSummaryEntry } from "../response-summary.mjs";
 import { productsResponse } from "../../responses.mjs";
 import { TOOL_ENTITY_FIELDS } from "./entity-hydration.generated.mjs";
 import { z } from "zod";
-import { createInMemoryTaskRegistry } from "./task-registry.mjs";
+import {
+  createInMemoryTaskRegistry,
+  taskRecordMatchesScope
+} from "./task-registry.mjs";
 import { protocolForTool, SPEC_WEBHOOK_TASK_TYPES } from "./protocol-for-tool.mjs";
 const DEFAULT_FRAMEWORK_LOGGER = {
   debug: () => {
@@ -1338,10 +1341,20 @@ function createAdcpServerFromPlatform(platform, opts) {
   }
   const pooledIdempotency = opts.pool && opts.idempotency === void 0 ? createIdempotencyStore({ backend: pgBackend(opts.pool) }) : void 0;
   const pooledCtxMetadata = opts.pool && opts.ctxMetadata === void 0 ? createCtxMetadataStore({ backend: pgCtxMetadataStore(opts.pool) }) : void 0;
-  const pooledTaskRegistry = opts.pool && opts.taskRegistry === void 0 ? createPostgresTaskRegistry({ pool: opts.pool }) : void 0;
+  if (opts.pool && opts.taskRegistry === void 0 && opts.taskRegistryNamespace === void 0) {
+    throw new PlatformConfigError(
+      "taskRegistryNamespace is required when opts.pool supplies the task registry. Use the same trusted namespace with getAllAdcpMigrations({ taskRegistryNamespace }) or getDecisioningTaskRegistryMigration({ namespace })."
+    );
+  }
+  const pooledTaskRegistry = opts.pool && opts.taskRegistry === void 0 ? createPostgresTaskRegistry({ pool: opts.pool, namespace: opts.taskRegistryNamespace }) : void 0;
   const effectiveIdempotency = opts.idempotency ?? pooledIdempotency;
   const effectiveCtxMetadata = opts.ctxMetadata ?? pooledCtxMetadata;
   const taskRegistry = opts.taskRegistry ?? pooledTaskRegistry ?? buildDefaultTaskRegistry();
+  if (taskRegistry.scopeVersion !== 1) {
+    throw new PlatformConfigError(
+      "taskRegistry.scopeVersion must be 1. Migrate custom registries to the account/principal-scoped TaskRegistry signatures before use."
+    );
+  }
   const baseBus = opts.statusChangeBus ?? createInMemoryStatusChangeBus();
   const taskWebhookEmit = opts.taskWebhookEmitter?.emit;
   const observability = opts.observability;
@@ -2008,15 +2021,13 @@ function createAdcpServerFromPlatform(platform, opts) {
     }
   }
   return Object.assign(server, {
-    getTaskState: async (taskId, expectedAccountId) => {
-      const record = await taskRegistry.getTask(taskId);
-      if (record == null) return null;
-      if (expectedAccountId !== void 0 && record.accountId !== expectedAccountId) {
-        return null;
-      }
-      return record;
+    getTaskState: async (taskId, scope) => {
+      const record = await taskRegistry.getTask(taskId, scope);
+      return record && taskRecordMatchesScope(record, scope) ? record : null;
     },
-    awaitTask: (taskId) => taskRegistry.awaitTask(taskId),
+    getTaskStateUnsafe: (taskId) => taskRegistry._getTaskUnsafe(taskId),
+    awaitTask: (taskId, scope) => taskRegistry.awaitTask(taskId, scope),
+    awaitTaskUnsafe: (taskId) => taskRegistry._awaitTaskUnsafe(taskId),
     statusChange: statusChangeBus
   });
 }
@@ -2189,9 +2200,26 @@ function buildTasksGetTool(platform, taskRegistry, agentRegistry, logger, resolv
           });
         }
       }
+      if (resolvedAccountId === void 0) {
+        return adcpError("REFERENCE_NOT_FOUND", {
+          message: `Task ${args.task_id} not found`,
+          field: "task_id"
+        });
+      }
+      const ownerCtx = {
+        store: {},
+        ...extra?.authInfo !== void 0 && { authInfo: extra.authInfo },
+        ...agent !== void 0 && { agent },
+        ...sessionKey !== void 0 && { sessionKey },
+        account: resolvedAccount ?? { id: resolvedAccountId }
+      };
+      const expectedOwnerScope = taskOwnerScopeFor(ownerCtx, resolvedAccountId);
       let record;
       try {
-        record = await taskRegistry.getTask(args.task_id);
+        record = await taskRegistry.getTask(args.task_id, {
+          accountId: resolvedAccountId,
+          ownerScope: expectedOwnerScope
+        });
       } catch (err) {
         logger.error?.("Task registry read failed during tasks_get poll", {
           error: err instanceof Error ? err.message : String(err)
@@ -2204,34 +2232,15 @@ function buildTasksGetTool(platform, taskRegistry, agentRegistry, logger, resolv
           field: "task_id"
         });
       }
-      if (resolvedAccountId === void 0 && record.accountId) {
+      if (!taskRecordMatchesScope(record, {
+        accountId: resolvedAccountId,
+        ownerScope: expectedOwnerScope
+      })) {
         return adcpError("REFERENCE_NOT_FOUND", {
           message: `Task ${args.task_id} not found`,
           field: "task_id"
         });
       }
-      if (resolvedAccountId !== void 0 && record.accountId !== resolvedAccountId) {
-        return adcpError("REFERENCE_NOT_FOUND", {
-          message: `Task ${args.task_id} not found`,
-          field: "task_id"
-        });
-      }
-      if (resolvedAccountId !== void 0) {
-        const ownerCtx = {
-          store: {},
-          ...extra?.authInfo !== void 0 && { authInfo: extra.authInfo },
-          ...agent !== void 0 && { agent },
-          ...sessionKey !== void 0 && { sessionKey },
-          account: resolvedAccount ?? { id: resolvedAccountId }
-        };
-        const expectedOwnerScope = taskOwnerScopeFor(ownerCtx, resolvedAccountId);
-        if (record.ownerScope === void 0 ? expectedOwnerScope !== `account:${resolvedAccountId}` : record.ownerScope !== expectedOwnerScope) {
-          return adcpError("REFERENCE_NOT_FOUND", {
-            message: `Task ${args.task_id} not found`,
-            field: "task_id"
-          });
-        }
-      }
       const payload = {
         task_id: record.taskId,
         task_type: record.tool,
@@ -2375,8 +2384,17 @@ function wrapBusWithObservability(bus, observability) {
     recent: bus.recent.bind(bus)
   };
 }
-function getAllAdcpMigrations() {
-  return [getIdempotencyMigration(), getCtxMetadataMigration(), getDecisioningTaskRegistryMigration()].join("\n\n");
+function getAllAdcpMigrations(options) {
+  if (!options) {
+    throw new PlatformConfigError(
+      "getAllAdcpMigrations requires { taskRegistryNamespace }; use a stable, trusted deployment or tenant namespace."
+    );
+  }
+  return [
+    getIdempotencyMigration(),
+    getCtxMetadataMigration(),
+    getDecisioningTaskRegistryMigration({ namespace: options.taskRegistryNamespace })
+  ].join("\n\n");
 }
 function buildDefaultTaskRegistry() {
   const env = process.env.NODE_ENV;
@@ -2384,7 +2402,7 @@ function buildDefaultTaskRegistry() {
   const ack = process.env.ADCP_DECISIONING_ALLOW_INMEMORY_TASKS === "1";
   if (!safe && !ack) {
     throw new Error(
-      'createAdcpServerFromPlatform: in-memory task registry refused outside {NODE_ENV=test, NODE_ENV=development}. Production deployments need a durable task registry \u2014 pick one of:\n  1. (Recommended) Pass `taskRegistry: createPostgresTaskRegistry({ pool })` to keep HITL tasks across restarts. See `@adcp/sdk/server/decisioning` for `getDecisioningTaskRegistryMigration()` \u2014 run it once against your DB.\n  2. Pass `taskRegistry: createInMemoryTaskRegistry()` explicitly if you accept that in-flight tasks are lost on process restart. The explicit pass-in is the contract \u2014 saying "yes I want in-memory in production" in code is the right shape.\n  3. ADCP_DECISIONING_ALLOW_INMEMORY_TASKS=1 env flag is the ops escape hatch (same effect as #2 but config-only); prefer #2 in adopter code.'
+      'createAdcpServerFromPlatform: in-memory task registry refused outside {NODE_ENV=test, NODE_ENV=development}. Production deployments need a durable task registry \u2014 pick one of:\n  1. (Recommended) Pass `taskRegistry: createPostgresTaskRegistry({ pool, namespace: tenantId })` to keep HITL tasks across restarts. See `@adcp/sdk/server/decisioning` for `getDecisioningTaskRegistryMigration({ namespace })` \u2014 run it once against your DB.\n  2. Pass `taskRegistry: createInMemoryTaskRegistry()` explicitly if you accept that in-flight tasks are lost on process restart. The explicit pass-in is the contract \u2014 saying "yes I want in-memory in production" in code is the right shape.\n  3. ADCP_DECISIONING_ALLOW_INMEMORY_TASKS=1 env flag is the ops escape hatch (same effect as #2 but config-only); prefer #2 in adopter code.'
     );
   }
   return createInMemoryTaskRegistry();
@@ -2519,7 +2537,12 @@ async function routeIfHandoff(taskRegistry, opts, result, project) {
       taskRegistry,
       opts,
       async (taskId) => {
-        const inner = await taskFn(buildHandoffContext(taskRegistry, taskId));
+        const inner = await taskFn(
+          buildHandoffContext(taskRegistry, taskId, {
+            accountId: opts.accountId,
+            ownerScope: opts.ownerScope ?? `account:${opts.accountId}`
+          })
+        );
         rejectResponseSummary(inner);
         return await project(inner);
       },
@@ -2567,6 +2590,10 @@ async function dispatchHitl(taskRegistry, opts, taskFn, overrideTaskId) {
     );
   };
   const completion = (async () => {
+    const registryScope = {
+      accountId: opts.accountId,
+      ownerScope: opts.ownerScope ?? `account:${opts.accountId}`
+    };
     let result;
     let taskFnError;
     try {
@@ -2580,10 +2607,10 @@ async function dispatchHitl(taskRegistry, opts, taskFn, overrideTaskId) {
         stripImplementationConfig(result);
       }
       try {
-        await taskRegistry.complete(taskId, result);
+        await taskRegistry.complete(taskId, registryScope, result);
       } catch (registryErr) {
         opts.logger.error(
-          `[adcp/decisioning] task ${taskId} (${opts.tool}) completed but registry write failed \u2014 manual reconciliation required. Webhook not emitted; buyer state will diverge until resolved. Error: ${registryErr instanceof Error ? registryErr.message : String(registryErr)}`
+          `[adcp/decisioning] task ${taskId} (${opts.tool}) completed but registry write failed \u2014 manual reconciliation required. Webhook not emitted; buyer state will diverge until resolved. Error type: ${registryErr instanceof Error ? "Error" : typeof registryErr}`
         );
         fireTransition("failed", "REGISTRY_WRITE_FAILED");
         return;
@@ -2603,10 +2630,10 @@ async function dispatchHitl(taskRegistry, opts, taskFn, overrideTaskId) {
     );
     const failureArtifact = { errors: [structured] };
     try {
-      await taskRegistry.fail(taskId, structured, failureArtifact);
+      await taskRegistry.fail(taskId, registryScope, structured, failureArtifact);
     } catch (registryErr) {
       opts.logger.error(
-        `[adcp/decisioning] task ${taskId} (${opts.tool}) failed AND registry fail-write also failed \u2014 manual reconciliation required. Webhook not emitted. taskFn error: ${structured.message}; registry error: ${registryErr instanceof Error ? registryErr.message : String(registryErr)}`
+        `[adcp/decisioning] task ${taskId} (${opts.tool}) failed AND registry fail-write also failed \u2014 manual reconciliation required. Webhook not emitted. Task error code: ${structured.code}; registry error type: ${registryErr instanceof Error ? "Error" : typeof registryErr}`
       );
       fireTransition("failed", "REGISTRY_WRITE_FAILED");
       return;
@@ -2616,7 +2643,11 @@ async function dispatchHitl(taskRegistry, opts, taskFn, overrideTaskId) {
       task: { task_id: taskId, status: "failed", result: failureArtifact, error: structured }
     });
   })();
-  taskRegistry._registerBackground(taskId, completion);
+  taskRegistry._registerBackground(
+    taskId,
+    { accountId: opts.accountId, ownerScope: opts.ownerScope ?? `account:${opts.accountId}` },
+    completion
+  );
   return { status: "submitted", task_id: taskId };
 }
 function buildTaskWebhookPayload(opts, taskId, status, artifact) {
@@ -3835,6 +3866,7 @@ function buildMediaBuyHandlers(platform, taskRegistry, taskWebhookEmit, observab
 }
 function projectBuildCreativeReturn(ret) {
   if (ret != null && typeof ret === "object" && !Array.isArray(ret)) {
+    if ("creatives" in ret) return ret;
     if ("creative_manifest" in ret) return ret;
     if ("creative_manifests" in ret) return ret;
   }