@adcp/sdk 13.0.0 → 13.0.1

package/dist/lib/testing/storyboard/runner.mjs

@@ -64,8 +64,9 @@ import {
   generateRandomInvalidJwt
 } from "./probes.mjs";
 import { readBrandJsonUrl } from "../../signing/agent-resolver/capabilities-types.mjs";
-import { validateTestKit } from "./test-kit.mjs";
+import { resolveDeclaredTestKit, validateTestKit } from "./test-kit.mjs";
 import { validateStoryboardShape } from "./loader.mjs";
+import { trustedStoryboardComplianceRoot } from "./provenance.mjs";
 import { probeRequestSigningVector } from "./request-signing/probe-dispatch.mjs";
 import { createWebhookReceiver } from "./webhook-receiver.mjs";
 import { WEBHOOK_ASSERTION_TASKS, armWebhookAssertions, executeWebhookAssertionStep } from "./webhook-assertions.mjs";
@@ -119,7 +120,10 @@ const CONTROLLER_SEEDING_FAILED_DETAIL = "Skipped: pre-flight comply_test_contro
 const FIXTURE_SEED_UNSUPPORTED_DETAIL = "Skipped: pre-flight comply_test_controller seeding requires a seed_* scenario this agent does not implement (`fixture_seed_unsupported`).";
 const OAUTH_NOT_ADVERTISED_DETAIL = "Skipped: agent does not advertise OAuth \u2014 /.well-known/oauth-protected-resource returned 404 (RFC 9728 \xA73). API-key path must carry auth_mechanism_verified for this storyboard to pass.";
 function applyStoryboardVersionOptions(storyboard, options) {
-  return applyAdcpVersionRunOptions(storyboard.adcp_version, options);
+  const versioned = applyAdcpVersionRunOptions(storyboard.adcp_version, options);
+  const mayInheritStoryboardDir = options.adcpVersion === void 0 || options.adcpVersion === storyboard.adcp_version;
+  const complianceDir = versioned.complianceDir ?? (mayInheritStoryboardDir ? trustedStoryboardComplianceRoot(storyboard) : void 0);
+  return complianceDir && versioned.complianceDir !== complianceDir ? { ...versioned, complianceDir } : versioned;
 }
 function applyAdcpVersionRunOptions(defaultAdcpVersion, options) {
   const adcpVersion = options.adcpVersion ?? defaultAdcpVersion;
@@ -608,6 +612,7 @@ async function runStoryboard(agentUrlOrUrls, storyboard, options = {}) {
   return withMCPConnectionScope(
     async () => {
       options = applyStoryboardVersionOptions(storyboard, options);
+      options = resolveDeclaredTestKit(storyboard, options);
       options = { ...options, transport: normalizeTransportOptions(options.transport) };
       const schemaRoot = getRunSchemaRoot(options);
       if (schemaRoot) {
@@ -2427,6 +2432,7 @@ async function runStoryboardStep(agentUrl, storyboard, stepId, options = {}) {
     async () => {
       validateStoryboardShape(storyboard);
       options = applyStoryboardVersionOptions(storyboard, options);
+      options = resolveDeclaredTestKit(storyboard, options);
       const schemaRoot = getRunSchemaRoot(options);
       if (schemaRoot) {
         return await withExternalSchemaRoot(
@@ -2787,7 +2793,23 @@ async function executeStep(client, step, storyboardId, phaseId, context, allStep
   }
   const testsMissingIdempotencyKey = step.omit_idempotency_key === true && isMutatingTask(effectiveStep.task);
   const testsMissingAccount = step.omit_account === true && effectiveStep.task === "create_media_buy";
-  const rawProbeHeaders = step.auth !== void 0 ? authHeadersForStep(step.auth, options) : void 0;
+  let rawProbeHeaders;
+  try {
+    rawProbeHeaders = step.auth !== void 0 ? authHeadersForStep(step.auth, options) : void 0;
+  } catch (err) {
+    return {
+      step_id: step.id,
+      phase_id: phaseId,
+      title: step.title,
+      task: step.task,
+      passed: false,
+      duration_ms: 0,
+      validations: [],
+      context,
+      error: `Step auth configuration error: ${err instanceof Error ? err.message : String(err)}`,
+      extraction: { path: "none" }
+    };
+  }
   const useRawProbe = rawProbeHeaders !== void 0;
   let taskResult;
   let stepResult;
@@ -3095,7 +3117,9 @@ async function executeStep(client, step, storyboardId, phaseId, context, allStep
   }
   let passed;
   if (step.expect_error) {
-    passed = !taskResult?.success || !!stepResult.error;
+    const responsePayload = taskResult?.data;
+    const payloadReportsFailure = responsePayload?.success === false;
+    passed = !taskResult?.success || !!stepResult.error || payloadReportsFailure;
   } else if (crossResponses) {
     passed = stepResult.passed;
   } else {
@@ -4522,6 +4546,11 @@ function authHeadersForStep(directive, options) {
     value = directive.value;
   } else if ("from_test_kit" in directive && directive.from_test_kit) {
     value = options.test_kit?.auth?.api_key;
+    if (!value) {
+      throw new Error(
+        "step declares auth.from_test_kit but no test kit with auth.api_key is configured \u2014 declare prerequisites.test_kit and authorize its cache with options.complianceDir (CLI: --compliance-dir), or pass options.test_kit (CLI: --test-kit)."
+      );
+    }
   } else if ("value_strategy" in directive && directive.value_strategy) {
     if (directive.value_strategy === "random_invalid") value = generateRandomInvalidApiKey();
     else if (directive.value_strategy === "random_invalid_jwt") value = generateRandomInvalidJwt();
@@ -4545,8 +4574,16 @@ function basicAuthHeadersForStep(directive, options) {
       )
     };
   }
-  const source = directive.from_test_kit !== void 0 ? resolveStepBasicFromTestKit(directive.from_test_kit, options) : directive.basic !== void 0 ? directive.basic : directive;
-  if (source === void 0) return {};
+  const usesTestKit = directive.from_test_kit === true || typeof directive.from_test_kit === "string" && directive.from_test_kit.length > 0;
+  const source = usesTestKit ? resolveStepBasicFromTestKit(directive.from_test_kit, options) : directive.basic !== void 0 ? directive.basic : directive;
+  if (source === void 0) {
+    if (usesTestKit) {
+      throw new Error(
+        "step declares auth.from_test_kit (basic) but no test kit with matching credentials is configured \u2014 declare prerequisites.test_kit and authorize its cache with options.complianceDir (CLI: --compliance-dir), or pass options.test_kit (CLI: --test-kit)."
+      );
+    }
+    return {};
+  }
   return { authorization: encodeBasicAuthHeader(source, "step.auth.basic") };
 }
 function resolveStepBasicFromTestKit(fromTestKit, options) {