@adcp/sdk 13.0.0-rc.13 → 13.0.0-rc.14

package/dist/lib/testing/storyboard/runner.mjs

@@ -24,7 +24,11 @@ import {
 } from "./validations.mjs";
 import { PARALLEL_DISPATCH_CONTRACT, runParallelDispatches, validateParallelDispatchSpec } from "./parallel-dispatch.mjs";
 import { resolvePath, resolvePortableIdentifierPathAll, toJsonPointer, validatePortableIdentifierPath } from "./path.mjs";
-import { RateLimitTripObserver, validateRateLimitTripSpec } from "./rate-limit-trip.mjs";
+import {
+  RATE_LIMIT_TRIP_CONTRACT,
+  RateLimitTripObserver,
+  validateRateLimitTripSpec
+} from "./rate-limit-trip.mjs";
 import { redactSecrets } from "../../utils/redact-secrets.mjs";
 import { ResponseSchemaValidationError } from "../../utils/response-unwrapper.mjs";
 import { injectLegacyEnvelopeStatus, normalizeLegacyMediaBuyStatusForReturn } from "../../utils/envelope-status-compat.mjs";
@@ -676,7 +680,7 @@ function buildCapabilityUnsupportedResult(agentUrls, storyboard, detail) {
     passed: true,
     skipped: true,
     skip_reason: "capability_unsupported",
-    skip: { reason: "unsatisfied_contract", detail },
+    skip: { reason: DETAILED_SKIP_TO_CANONICAL.capability_unsupported, detail },
     duration_ms: 0,
     validations: [],
     context: {},
@@ -989,7 +993,8 @@ function detectImplicitRequires(storyboard, options = {}) {
   for (const phase of storyboard.phases) {
     for (const step of phase.steps) {
       const stepContractInScope = !step.requires_contract || contractsInScope.has(step.requires_contract);
-      if (!needsWebhook && (step.sample_request && valueContainsWebhookToken(step.sample_request) || step.rate_limit_trip?.trip_target_sample_request && stepContractInScope && valueContainsWebhookToken(step.rate_limit_trip.trip_target_sample_request))) {
+      const rateLimitProbeInScope = step.task !== "expect_rate_limit_not_replayed" || stepContractInScope && contractsInScope.has(RATE_LIMIT_TRIP_CONTRACT) && options.allowLiveSideEffects === true;
+      if (!needsWebhook && (step.sample_request && rateLimitProbeInScope && valueContainsWebhookToken(step.sample_request) || step.rate_limit_trip?.trip_target_sample_request && stepContractInScope && rateLimitProbeInScope && valueContainsWebhookToken(step.rate_limit_trip.trip_target_sample_request))) {
         needsWebhook = true;
       }
       if (!needsSigner && step.task === "request_signing_probe") {
@@ -3189,9 +3194,9 @@ async function executeProbeStep(client, step, phaseId, context, allSteps, option
     fetchFn: options.transport?.fetchFn
   };
   let requestRecordOverride;
+  const contractsInScope = new Set(options.contracts ?? []);
   if (step.requires_contract) {
-    const contracts = new Set(options.contracts ?? []);
-    if (!contracts.has(step.requires_contract)) {
+    if (!contractsInScope.has(step.requires_contract)) {
       httpResult = {
         url: runState.agentUrl,
         status: 0,
@@ -3203,6 +3208,17 @@ async function executeProbeStep(client, step, phaseId, context, allSteps, option
       };
     }
   }
+  if (!httpResult && step.task === "expect_rate_limit_not_replayed" && !contractsInScope.has(RATE_LIMIT_TRIP_CONTRACT)) {
+    httpResult = {
+      url: runState.agentUrl,
+      status: 0,
+      headers: {},
+      body: null,
+      skipped: true,
+      skip_reason: "missing_test_kit_contract",
+      error: `Test-kit contract "${RATE_LIMIT_TRIP_CONTRACT}" is not configured on this runner.`
+    };
+  }
   if (httpResult) {
   } else if (step.task === "protected_resource_metadata") {
     if (step.validations?.some((validation) => validation.check === "oauth_metadata_graph")) {
@@ -3243,6 +3259,16 @@ async function executeProbeStep(client, step, phaseId, context, allSteps, option
         body: { attempts: 0, error: "rate_limit_trip_misconfigured" },
         error: specError
       };
+    } else if (options.allowLiveSideEffects !== true) {
+      httpResult = {
+        url: runState.agentUrl,
+        status: 0,
+        headers: {},
+        body: null,
+        skipped: true,
+        skip_reason: "live_side_effect_opt_in_required",
+        error: "The rate-limit trip probe can send hundreds of mutating requests. Pass allowLiveSideEffects: true to authorize it explicitly."
+      };
     } else {
       const rateLimitTrip = step.rate_limit_trip;
       const targetStep = {
@@ -3549,6 +3575,7 @@ function buildEffectiveStepRequest(step, context, options, runState) {
   };
 }
 function preflightRemainingCreativeAssetDirectives(allSteps, afterGlobalIndex, context, options, runState, excludedPhaseIds = /* @__PURE__ */ new Set()) {
+  const contractsInScope = new Set(options.contracts ?? []);
   for (const target of allSteps) {
     if (target.globalIndex <= afterGlobalIndex) continue;
     if (excludedPhaseIds.has(target.phaseId)) continue;
@@ -3557,7 +3584,10 @@ function preflightRemainingCreativeAssetDirectives(allSteps, afterGlobalIndex, c
     if (target.step.requires_tool && options.agentTools && !options.agentTools.includes(target.step.requires_tool)) {
       continue;
     }
-    if (target.step.requires_contract && !new Set(options.contracts ?? []).has(target.step.requires_contract)) {
+    if (target.step.requires_contract && !contractsInScope.has(target.step.requires_contract)) {
+      continue;
+    }
+    if (target.step.task === "expect_rate_limit_not_replayed" && (!contractsInScope.has(RATE_LIMIT_TRIP_CONTRACT) || options.allowLiveSideEffects !== true)) {
       continue;
     }
     if (!PROBE_TASKS.has(target.step.task) && options.agentTools && !options.agentTools.includes(resolvedTask)) {