@adcops/autocore-react 3.3.124 → 3.5.5

package/src/hooks/useAutoCoreTag.ts

@@ -14,7 +14,7 @@
  */
 
 import { useCallback, useContext, useMemo } from "react";
-import type { BaseContextValue, TagConfig, TagValueMap } from "../core/AutoCoreTagTypes";
+import type { BaseContextValue, ScaleConfig, TagConfig, TagValueMap } from "../core/AutoCoreTagTypes";
 
 export function makeAutoCoreTagHooks<Spec extends readonly TagConfig[]>(
     Context: React.Context<BaseContextValue<TagValueMap<Spec>>>,
@@ -96,12 +96,60 @@ export function makeAutoCoreTagHooks<Spec extends readonly TagConfig[]>(
 
     /**
      * Access scale configurations and update functions.
+     *
+     * `getScale` NEVER returns undefined. Callers destructure it directly
+     * (`const { label } = getScale("load")`), so handing back undefined for an
+     * unknown group throws inside render and white-screens the whole HMI — on a
+     * machine, that is the operator losing the screen over a missing unit label.
+     * An unknown group yields an identity scale instead: no conversion, empty
+     * label, which is the same thing the provider did before units.json existed.
      */
     const useScales = () => {
         const { scales, updateScale } = useContext(Context);
-        const getScale = useCallback((scaleName: string) => scales[scaleName], [scales]);
+        const getScale = useCallback(
+            (scaleName: string): ScaleConfig =>
+                scales[scaleName] ?? { name: scaleName, scale: 1, label: "" },
+            [scales],
+        );
         return { scales, updateScale, getScale } as const;
     };
 
-    return { useAutoCoreTag, useAutoCoreTags, useAutoCoreSelect, useScales } as const;
+    /**
+     * Access the machine's units table, the active display system, the live
+     * switch, and the shared formatter.
+     *
+     * `format(quantity, backendValue)` is the one place display precision is
+     * applied — use it rather than `toFixed` so a readout, a table cell and a
+     * chart tick can never disagree. It takes a BACKEND value; conversion to the
+     * active system happens inside.
+     */
+    const useUnits = () => {
+        const { units, activeSystem, setUnitSystem, formatQuantity, scales } =
+            useContext(Context);
+        const label = useCallback(
+            (quantity: string) => scales[quantity]?.label ?? "",
+            [scales],
+        );
+        const format = useCallback(
+            (quantity: string, backendValue: number) =>
+                formatQuantity ? formatQuantity(quantity, backendValue) : String(backendValue),
+            [formatQuantity],
+        );
+        return {
+            units: units ?? null,
+            activeSystem: activeSystem ?? null,
+            systems: units?.systems ?? [],
+            setUnitSystem,
+            label,
+            format,
+        } as const;
+    };
+
+    return {
+        useAutoCoreTag,
+        useAutoCoreTags,
+        useAutoCoreSelect,
+        useScales,
+        useUnits,
+    } as const;
 }

package/todo.md

@@ -1,5 +1,11 @@
 # TODO
 
+## 3.5.0 — Units & scales
+<!-- NOT 4.0: that is a separate in-progress branch. -->
+- [ ] Replace `ScaleConfig` / `acScales` with quantity-based derivation from the
+      project `units` block + GNV `active_unit_system`. Design plan:
+      **`autocore-server/UNITS_PLAN.md`** (§5.3 is the autocore-react section).
+
 ## Integration
 - [x] Hub class to route to and from the back end
 - -[x] The Hub should also be the dispatcher. I can't think of a reason they should be separate.