@adbayb/stack 0.0.0-next-730a06d → 0.0.0-next-1dfe647

package/config/eslint/constants.js

@@ -2,4 +2,9 @@ import { cwd } from "node:process";
 
 export const CWD = cwd();
 
-export const JAVASCRIPT_LIKE_FILES = ["**/*.{js,ts,jsx,tsx,cjs,cts,mjs,mts}"];
+export const JAVASCRIPT_EXTENSIONS = ["**/*.{js,jsx,cjs,mjs}"];
+
+export const JAVASCRIPT_LIKE_EXTENSIONS = [
+	...JAVASCRIPT_EXTENSIONS,
+	"**/*.{ts,tsx,cts,mts}",
+];

package/config/eslint/index.js

@@ -11,12 +11,6 @@ import { config as eslintConfig } from "./presets/eslint.js";
 import { config as baseConfig } from "./presets/base.js";
 import { createConfig } from "./helpers.js";
 
-/**
- * TODO:
- * - Review TS rules: attempt to include all rules from https://typescript-eslint.io/users/configs/#strict-type-checked and https://typescript-eslint.io/users/configs/#stylistic-type-checked ?
- * - Review JSDoc rules.
- */
-
 export default createConfig(
 	// The insertion order is important (last same config items overrides previous ones):
 	...baseConfig,

package/config/eslint/presets/eslint.js

@@ -1,28 +1,50 @@
-import { JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import {
+	JAVASCRIPT_EXTENSIONS,
+	JAVASCRIPT_LIKE_EXTENSIONS,
+} from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		// Specific ESLint rules for javascript-only files (as they're already handled for TypeScript files by the transpiler):
+		// This rule list is taken from https://typescript-eslint.io/users/configs/#recommended
+		files: JAVASCRIPT_EXTENSIONS,
+		rules: {
+			"constructor-super": "error", // ts(2335) & ts(2377)
+			"getter-return": "error", // ts(2378)
+			"no-const-assign": "error", // ts(2588)
+			"no-dupe-args": "error", // ts(2300)
+			"no-dupe-class-members": "error", // ts(2393) & ts(2300)
+			"no-dupe-keys": "error", // ts(1117)
+			"no-func-assign": "error", // ts(2630)
+			"no-import-assign": "error", // ts(2632) & ts(2540)
+			"no-new-native-nonconstructor": "error", // ts(7009)
+			"no-obj-calls": "error", // ts(2349)
+			"no-redeclare": "error", // ts(2451)
+			"no-setter-return": "error", // ts(2408)
+			"no-this-before-super": "error", // ts(2376) & ts(17009)
+			"no-undef": "error", // ts(2304) & ts(2552)
+			"no-unreachable": "error", // ts(7027)
+			"no-unsafe-negation": "error", // ts(2365) & ts(2322) & ts(2358)
+		},
+	},
+	{
+		// ESLint rules for JavaScript + TypeScript files:
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		rules: {
-			"constructor-super": "error",
 			"eqeqeq": "error",
 			"for-direction": "error",
-			"getter-return": "error",
 			"no-alert": "error",
 			"no-async-promise-executor": "error",
 			"no-case-declarations": "error",
 			"no-class-assign": "error",
 			"no-compare-neg-zero": "error",
 			"no-cond-assign": "error",
-			"no-const-assign": "error",
 			"no-constant-binary-expression": "error",
 			"no-constant-condition": "error",
 			"no-control-regex": "error",
 			"no-debugger": "error",
 			"no-delete-var": "error",
-			"no-dupe-args": "error",
 			"no-dupe-else-if": "error",
-			"no-dupe-keys": "error",
 			"no-duplicate-case": "error",
 			"no-empty": "error",
 			"no-empty-character-class": "error",
@@ -31,19 +53,14 @@ export const config = [
 			"no-ex-assign": "error",
 			"no-extra-boolean-cast": "error",
 			"no-fallthrough": "error",
-			"no-func-assign": "error",
 			"no-global-assign": "error",
-			"no-import-assign": "error",
 			"no-invalid-regexp": "error",
 			"no-irregular-whitespace": "error",
 			"no-loss-of-precision": "error",
 			"no-misleading-character-class": "error",
-			"no-new-native-nonconstructor": "error",
 			"no-nonoctal-decimal-escape": "error",
-			"no-obj-calls": "error",
 			"no-octal": "error",
 			"no-prototype-builtins": "error",
-			"no-redeclare": "error",
 			"no-regex-spaces": "error",
 			"no-restricted-syntax": [
 				"error",
@@ -54,15 +71,10 @@ export const config = [
 				},
 			],
 			"no-self-assign": "error",
-			"no-setter-return": "error",
 			"no-shadow-restricted-names": "error",
 			"no-sparse-arrays": "error",
-			"no-this-before-super": "error",
-			"no-undef": "error",
 			"no-unexpected-multiline": "error",
-			"no-unreachable": "error",
 			"no-unsafe-finally": "error",
-			"no-unsafe-negation": "error",
 			"no-unsafe-optional-chaining": "error",
 			"no-unused-labels": "error",
 			"no-unused-private-class-members": "error",

package/config/eslint/presets/import.js

@@ -1,11 +1,11 @@
 import importPlugin from "eslint-plugin-import-x";
 
-import { JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	importPlugin.flatConfigs.typescript,
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		plugins: {
 			"import-x": importPlugin,
 		},

package/config/eslint/presets/jsdoc.js

@@ -1,10 +1,10 @@
 import jsdocPlugin from "eslint-plugin-jsdoc";
 
-import { JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		plugins: {
 			jsdoc: jsdocPlugin,
 		},
@@ -25,6 +25,7 @@ export const config = [
 			"jsdoc/multiline-blocks": "error",
 			"jsdoc/no-bad-blocks": "error",
 			"jsdoc/no-blank-block-descriptions": "error",
+			"jsdoc/no-blank-blocks": "error",
 			"jsdoc/no-defaults": "error",
 			"jsdoc/no-multi-asterisks": "error",
 			"jsdoc/no-types": "error",

package/config/eslint/presets/node.js

@@ -3,11 +3,11 @@ import { join } from "node:path";
 import nodePlugin from "eslint-plugin-n";
 
 import { require } from "../helpers.js";
-import { CWD, JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { CWD, JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		plugins: {
 			n: nodePlugin,
 		},

package/config/eslint/presets/sonar.js

@@ -1,10 +1,10 @@
 import sonarjsPlugin from "eslint-plugin-sonarjs";
 
-import { JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		plugins: {
 			sonarjs: sonarjsPlugin,
 		},
@@ -175,8 +175,6 @@ export const config = [
 			"sonarjs/prefer-object-spread": "error",
 			"sonarjs/prefer-promise-shorthand": "error",
 			"sonarjs/prefer-single-boolean-return": "error",
-			"sonarjs/prefer-spread": "error",
-			"sonarjs/prefer-string-starts-ends-with": "error",
 			"sonarjs/prefer-type-guard": "error",
 			"sonarjs/prefer-while": "error",
 			"sonarjs/production-debug": "error",

package/config/eslint/presets/typescript.js

@@ -1,10 +1,10 @@
 import tseslint from "typescript-eslint";
 
-import { CWD, JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { CWD, JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		languageOptions: {
 			parser: tseslint.parser,
 			parserOptions: {
@@ -33,6 +33,7 @@ export const config = [
 					"ts-nocheck": "allow-with-description",
 				},
 			],
+			"@typescript-eslint/ban-tslint-comment": "error",
 			"@typescript-eslint/class-literal-property-style": ["error", "fields"],
 			"@typescript-eslint/class-methods-use-this": "error",
 			"@typescript-eslint/consistent-generic-constructors": [
@@ -69,6 +70,7 @@ export const config = [
 			],
 			"@typescript-eslint/method-signature-style": ["error", "property"],
 			"@typescript-eslint/no-array-constructor": "error",
+			"@typescript-eslint/no-array-delete": "error",
 			"@typescript-eslint/no-base-to-string": "error",
 			"@typescript-eslint/no-confusing-non-null-assertion": "error",
 			"@typescript-eslint/no-confusing-void-expression": "error",
@@ -94,7 +96,6 @@ export const config = [
 			"@typescript-eslint/no-invalid-this": "error",
 			"@typescript-eslint/no-invalid-void-type": "error",
 			"@typescript-eslint/no-loop-func": "error",
-			"@typescript-eslint/no-loss-of-precision": "error",
 			"@typescript-eslint/no-meaningless-void-operator": "error",
 			"@typescript-eslint/no-misused-new": "error",
 			"@typescript-eslint/no-misused-promises": "error",
@@ -103,12 +104,14 @@ export const config = [
 			"@typescript-eslint/no-non-null-asserted-nullish-coalescing": "error",
 			"@typescript-eslint/no-non-null-asserted-optional-chain": "error",
 			"@typescript-eslint/no-non-null-assertion": "error",
+			"@typescript-eslint/no-redundant-type-constituents": "error",
 			"@typescript-eslint/no-require-imports": "error",
 			"@typescript-eslint/no-shadow": "error",
 			"@typescript-eslint/no-this-alias": "error",
 			"@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
 			"@typescript-eslint/no-unnecessary-condition": "error",
 			"@typescript-eslint/no-unnecessary-qualifier": "error",
+			"@typescript-eslint/no-unnecessary-template-expression": "error",
 			"@typescript-eslint/no-unnecessary-type-arguments": "error",
 			"@typescript-eslint/no-unnecessary-type-assertion": "error",
 			"@typescript-eslint/no-unnecessary-type-constraint": "error",
@@ -137,21 +140,43 @@ export const config = [
 			"@typescript-eslint/prefer-namespace-keyword": "error",
 			"@typescript-eslint/prefer-nullish-coalescing": "error",
 			"@typescript-eslint/prefer-optional-chain": "error",
+			"@typescript-eslint/prefer-promise-reject-errors": "error",
 			"@typescript-eslint/prefer-readonly": "error",
+			"@typescript-eslint/prefer-reduce-type-parameter": "error",
 			"@typescript-eslint/prefer-regexp-exec": "error",
 			"@typescript-eslint/prefer-return-this-type": "error",
 			"@typescript-eslint/prefer-string-starts-ends-with": "error",
 			"@typescript-eslint/prefer-ts-expect-error": "error",
 			"@typescript-eslint/promise-function-async": "error",
 			"@typescript-eslint/require-await": "error",
-			"@typescript-eslint/restrict-plus-operands": "error",
-			"@typescript-eslint/restrict-template-expressions": "error",
+			"@typescript-eslint/restrict-plus-operands": [
+				"error",
+				{
+					allowAny: false,
+					allowBoolean: false,
+					allowNullish: false,
+					allowNumberAndString: false,
+					allowRegExp: false,
+				},
+			],
+			"@typescript-eslint/restrict-template-expressions": [
+				"error",
+				{
+					allowAny: false,
+					allowBoolean: false,
+					allowNever: false,
+					allowNullish: false,
+					allowNumber: false,
+					allowRegExp: false,
+				},
+			],
 			"@typescript-eslint/return-await": "error",
 			"@typescript-eslint/sort-type-constituents": "error",
 			"@typescript-eslint/switch-exhaustiveness-check": "error",
 			"@typescript-eslint/triple-slash-reference": "error",
 			"@typescript-eslint/unbound-method": "error",
 			"@typescript-eslint/unified-signatures": "error",
+			"@typescript-eslint/use-unknown-in-catch-callback-variable": "error",
 		},
 	},
 ];

package/config/eslint/presets/uncategorized.js

@@ -1,11 +1,11 @@
 import sortKeysCustomOrderPlugin from "eslint-plugin-sort-keys-custom-order";
 import { FlatCompat } from "@eslint/eslintrc";
 
-import { JAVASCRIPT_LIKE_FILES } from "../constants.js";
+import { JAVASCRIPT_LIKE_EXTENSIONS } from "../constants.js";
 
 export const config = [
 	{
-		files: JAVASCRIPT_LIKE_FILES,
+		files: JAVASCRIPT_LIKE_EXTENSIONS,
 		plugins: {
 			"sort-keys-custom-order": sortKeysCustomOrderPlugin,
 		},

package/dist/index.js

@@ -6,7 +6,7 @@ import { existsSync, cpSync, readFileSync, renameSync, writeFileSync, readdirSyn
 import { writeFile, chmod, mkdir, symlink } from 'node:fs/promises';
 import { fdir } from 'fdir';
 
-var version = "0.0.0-next-730a06d";
+var version = "0.0.0-next-1dfe647";
 
 const VERSION = version;
 
@@ -299,7 +299,7 @@ const createInstallCommand = (program)=>{
     }).task({
         label: label$4("Installing `git.commit-msg` hook"),
         async handler () {
-            await installGitHook("commit-msg", `${getStackCommand("check --only commit", false)}`);
+            await installGitHook("commit-msg", getStackCommand("check --only commit", false));
         }
     });
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adbayb/stack",
-  "version": "0.0.0-next-730a06d",
+  "version": "0.0.0-next-1dfe647",
   "description": "My opinionated JavaScript-based toolchain",
   "publishConfig": {
     "access": "public"