@adaptic/maestro 1.8.0 → 1.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptic/maestro",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "Maestro — Autonomous AI agent operating system. Deploy AI employees on dedicated Mac minis.",
   "type": "module",
   "bin": {

package/scripts/local-triggers/generate-plists.sh

@@ -36,14 +36,38 @@ MAESTRO_PLIST_ARCH_VERSION="1"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 AGENT_DIR="$(cd "$SCRIPT_DIR/../.." && pwd)"
 PLIST_DIR="$SCRIPT_DIR/plists"
-AGENT_CONFIG="$AGENT_DIR/config/agent.ts"
 
-# Extract agent first name from config/agent.ts
-if [ -f "$AGENT_CONFIG" ]; then
-    AGENT_FIRST=$(grep "firstName:" "$AGENT_CONFIG" | head -1 | sed "s/.*firstName:[[:space:]]*['\"]//; s/['\"].*//" | tr '[:upper:]' '[:lower:]')
+# Resolve the agent's first name. Order of preference:
+#   1. config/agent.json  — single source of truth (SOT) introduced when
+#      maestro split identity out of TypeScript into JSON. Use jq if
+#      available, otherwise a small awk fallback.
+#   2. config/agent.ts    — legacy path; only works if firstName is
+#      defined inline (string literal), not as a type-only declaration
+#      like `firstName: string;`.
+#   3. Directory name     — last-resort fallback (e.g. ~/ravi-ai → ravi).
+AGENT_JSON="$AGENT_DIR/config/agent.json"
+AGENT_TS="$AGENT_DIR/config/agent.ts"
+AGENT_FIRST=""
+
+if [ -z "$AGENT_FIRST" ] && [ -f "$AGENT_JSON" ]; then
+    if command -v jq >/dev/null 2>&1; then
+        AGENT_FIRST=$(jq -r '.firstName // empty' "$AGENT_JSON" 2>/dev/null | tr '[:upper:]' '[:lower:]')
+    else
+        # Awk fallback — handle "firstName": "value" with optional whitespace
+        AGENT_FIRST=$(awk -F'"' '/"firstName"[[:space:]]*:/ { print tolower($4); exit }' "$AGENT_JSON")
+    fi
+fi
+
+if [ -z "$AGENT_FIRST" ] && [ -f "$AGENT_TS" ]; then
+    # Only accept a quoted inline value — `firstName: string;` (type
+    # declaration) must not match. The grep requires a quote on the line.
+    AGENT_FIRST=$(grep "firstName:[[:space:]]*['\"]" "$AGENT_TS" \
+        | head -1 \
+        | sed "s/.*firstName:[[:space:]]*['\"]//; s/['\"].*//" \
+        | tr '[:upper:]' '[:lower:]')
 fi
 
-# Fall back to directory name if config not set or UNCONFIGURED
+# Fall back to directory name if config not set or UNCONFIGURED.
 if [ -z "$AGENT_FIRST" ] || [ "$AGENT_FIRST" = "unconfigured" ]; then
     AGENT_FIRST=$(basename "$AGENT_DIR" | sed 's/-ai$//')
 fi

package/scripts/local-triggers/generate-plists.test.mjs

@@ -167,6 +167,75 @@ test("daemon plist remains a KeepAlive job (not a cadence enqueue)", async () =>
   } finally { await rmRoot(root); }
 });
 
+test("generator reads firstName from agent.json when agent.ts is type-only (SOT layout)", async () => {
+  // Reproduce the SOT layout where agent.ts only declares interfaces
+  // (containing `firstName: string;` as a type, not a value) and the
+  // actual identity lives in agent.json. The legacy resolver matched the
+  // interface line and produced labels like
+  // `ai.adaptic.  firstname:   string;-…` — guard against regression.
+  const root = join(
+    tmpdir(),
+    `plist-sot-test-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`
+  );
+  await fsp.mkdir(root, { recursive: true });
+  // Manually wire the same fixture-builder used by other tests, except
+  // overwrite agent.ts to look like a type-only TypeScript file and add
+  // a real agent.json.
+  await fsp.mkdir(join(root, "config"), { recursive: true });
+  writeFileSync(
+    join(root, "config/agent.ts"),
+    `// Type declarations only — value lives in agent.json
+export interface PrincipalConfig { firstName: string; }
+export interface AgentConfig { firstName: string; }
+`,
+  );
+  writeFileSync(
+    join(root, "config/agent.json"),
+    JSON.stringify({ firstName: "Sigrid", lastName: "Test" }) + "\n",
+  );
+  writeFileSync(join(root, "package.json"), '{"name":"t"}');
+
+  await fsp.mkdir(join(root, "scripts/local-triggers"), { recursive: true });
+  await fsp.mkdir(join(root, "scripts/daemon"), { recursive: true });
+  await fsp.mkdir(join(root, "scripts/cadence"), { recursive: true });
+  // Same set of helper scripts as makeAgent().
+  const { copyFileSync } = await import("node:fs");
+  copyFileSync(GENERATOR, join(root, "scripts/local-triggers/generate-plists.sh"));
+  copyFileSync(
+    join(MAESTRO_ROOT, "scripts/local-triggers/run-trigger.sh"),
+    join(root, "scripts/local-triggers/run-trigger.sh"),
+  );
+  copyFileSync(
+    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper.sh"),
+    join(root, "scripts/daemon/launchd-wrapper.sh"),
+  );
+  copyFileSync(
+    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper-generic.sh"),
+    join(root, "scripts/daemon/launchd-wrapper-generic.sh"),
+  );
+  copyFileSync(
+    join(MAESTRO_ROOT, "scripts/cadence/launchd-cadence-wrapper.sh"),
+    join(root, "scripts/cadence/launchd-cadence-wrapper.sh"),
+  );
+  copyFileSync(
+    join(MAESTRO_ROOT, "scripts/cadence/enqueue-cadence-tick.mjs"),
+    join(root, "scripts/cadence/enqueue-cadence-tick.mjs"),
+  );
+  await fsp.chmod(join(root, "scripts/local-triggers/generate-plists.sh"), 0o755);
+
+  try {
+    const r = runGenerator(root);
+    assert.equal(r.status, 0, r.stderr);
+    const plists = listPlists(root);
+    assert.ok(plists.length >= 1);
+    for (const p of plists) {
+      assert.match(p, /^ai\.adaptic\.sigrid-/, `expected "sigrid" label, got: ${p}`);
+      assert.ok(!p.includes("string"),
+        `label leaked the TypeScript type: ${p}`);
+    }
+  } finally { await rmRoot(root); }
+});
+
 test("regeneration clears stale plists", async () => {
   const root = await makeAgent("frank");
   try {