@adaptabletools/adaptable 23.0.4 → 23.0.5-canary.0

package/src/agGrid/AgGridColumnAdapter.js

@@ -29,11 +29,6 @@ import { AgGridFloatingFilterAdapterFactory } from './AgGridFloatingFilterAdapte
 import { errorOnce } from './AdaptableLogger';
 import { isUnsupportedColumnDataTypeForIconStyle } from '../Utilities/Helpers/StyledColumns/IconStyleHelper';
 import { isWeightedAverageAggFuncName, } from '../AdaptableState/Common/AggregationColumns';
-/**
- * CSS property keys produced by `convertAdaptableStyleToCSS` from a
- * `CellFontStyle` slice. Used to strip Format-Column-derived font CSS
- * when a Styled Column claims the Font slot.
- */
 const FONT_CSS_KEYS = [
     'color',
     'fontWeight',
@@ -42,11 +37,6 @@ const FONT_CSS_KEYS = [
     'textDecoration',
     'textAlign',
 ];
-/**
- * CSS property keys produced by `convertAdaptableStyleToCSS` from a
- * `CellBoxStyle` slice. Used to strip Format-Column-derived cell-box CSS
- * when a Styled Column claims the Cell slot.
- */
 const CELL_BOX_CSS_KEYS = [
     'backgroundColor',
     'borderColor',
@@ -123,7 +113,6 @@ export class AgGridColumnAdapter {
             }
         }
         if (theValue === undefined && colDef[propertyName] === undefined) {
-            // already undefined, so don't set an own property to the same undefined value
             return;
         }
         colDef[propertyName] = theValue;
@@ -133,14 +122,6 @@ export class AgGridColumnAdapter {
         return this.colDefPropertyCache.get(userKey);
     }
     shouldSkipColumn(colId) {
-        /**
-         * This skips special columns that ag grid will likely implement in the future
-         *
-         * BUT DOES NOT SKIP GROUP COLUMNS or SELECTION COLUMNS!!!
-         *
-         * It's probably here for historical reasons - previously it used to skip the selection column
-         * but now it's not skipping it anymore
-         */
         return (colId.startsWith('ag-Grid-') &&
             !this.adaptableApi.columnApi.isAutoRowGroupColumn(colId) &&
             !this.adaptableApi.columnApi.isSelectionColumn(colId));
@@ -148,10 +129,9 @@ export class AgGridColumnAdapter {
     getAllAgGridColumns() {
         const pivotMode = this.adaptableInstance.isInPivotMode();
         let cols = pivotMode
-            ? // for pivot mode, we take only the initial columns
+            ?
                 this.agGridApi.getColumns()
-            : // but for non-pivot mode, we ask for all columns
-                // which also includes those that are generated for row grouping
+            :
                 this.agGridApi.getAllGridColumns();
         if (pivotMode) {
             const pivotResultColumns = this.agGridApi.getPivotResultColumns() || [];
@@ -162,17 +142,11 @@ export class AgGridColumnAdapter {
         }
         return cols;
     }
-    /**
-     * Setup all columns, or only those with the given Ids
-     * @param specificColumnIds - optional list of column Ids to setup. If not provided, all columns are setup
-     */
     setupColumns(specificColumnIds) {
         let cols = this.getAllAgGridColumns();
         if (specificColumnIds?.length) {
             cols = cols.filter((col) => specificColumnIds.includes(col.getColId()));
         }
-        // this needs to be here, before the other setup below
-        // so the setup methods below reference the correct columns in adaptable store
         cols.forEach((col) => {
             const colDef = col.getColDef();
             const colId = col.getColId();
@@ -195,9 +169,6 @@ export class AgGridColumnAdapter {
             this.setupColumnValueGetter(colSetupInfo);
             this.setupColumnTooltipValueGetter(colSetupInfo);
             if (!isAutoRowGroupColumn) {
-                // we do NOT setup filtering for  auto row group columns
-                // this is done via gridOptions.autoGroupColumnDef
-                // see #autoGroupColumnDef
                 this.setupColumnFilter(colSetupInfo);
                 this.setupColumnFloatingFilter(colSetupInfo);
             }
@@ -215,7 +186,6 @@ export class AgGridColumnAdapter {
         });
     }
     setupColumnValueGetter({ col }) {
-        // need this here if we want plugins to intercept
         this.setColDefProperty(col, 'valueGetter', (userValue) => {
             return userValue;
         });
@@ -266,7 +236,6 @@ export class AgGridColumnAdapter {
                     !hasStyledColumn && formatColumns.length
                         ? this.getFormatColumnCellClass(formatColumns, abColumn, params)
                         : null,
-                    //  isQuickSearchActive && hasQuickSearchStyleClassName ? quickSearchStyleClassName : null,
                     isQuickSearchActive && !isServerSideRowModel ? 'ab-QuickSearchFind' : null,
                     editableClassName,
                     readonlyClassName,
@@ -276,7 +245,6 @@ export class AgGridColumnAdapter {
                     noteClassName,
                     commentsClassName,
                 ]
-                    // we flatten the array because some rules ('userCellClass' etc)  might return a string[]
                     .flat()
                     .filter((x) => !!x);
                 const result = returnValue.length ? returnValue : undefined;
@@ -289,7 +257,6 @@ export class AgGridColumnAdapter {
         this.setColDefProperty(col, 'headerClass', (userHeaderClass) => {
             const headerClass = (params) => {
                 let baseHeaderClass = [];
-                // inherit styles from user provided colDef property
                 const userDefinedHeaderClass = typeof userHeaderClass === 'function' ? userHeaderClass(params) : userHeaderClass;
                 if (userDefinedHeaderClass) {
                     baseHeaderClass =
@@ -300,12 +267,9 @@ export class AgGridColumnAdapter {
                                 : [userDefinedHeaderClass];
                 }
                 if (params.floatingFilter) {
-                    // we NEVER style floating filters
                     return baseHeaderClass;
                 }
                 if (params.columnGroup) {
-                    // we TEMPORARILY do NOT style column groups
-                    // see https://github.com/AdaptableTools/adaptable/issues/2947#issuecomment-3062304655
                     return baseHeaderClass;
                 }
                 const isExcelExport = this.adaptableApi.exportApi.internalApi.isExcelExportInProgress();
@@ -335,11 +299,7 @@ export class AgGridColumnAdapter {
                     return baseHeaderClass;
                 }
                 const target = 'columnHeader';
-                // handle special case of headers with text alignment
-                // in this case, we add a specific class to the header
-                // see #header_text_align
                 const formatColumnWithTextAlignment = this.getRelevantFormatColumnHeaderStyles(abColumn)
-                    // we take the first one only, even if multiple are defined
                     .find((fc) => fc.Style?.Alignment != undefined);
                 if (formatColumnWithTextAlignment) {
                     const alignment = formatColumnWithTextAlignment.Style.Alignment.toLowerCase();
@@ -369,8 +329,6 @@ export class AgGridColumnAdapter {
             return undefined;
         }
         return Object.entries(style).reduce((acc, [key, value]) => {
-            // needed as AG-Grid vanilla turns all CSS props to kebab, while AG Grid React does not
-            // @ts-ignore
             acc[`--ab-dynamic-${kebabCase(key)}`] = value;
             return acc;
         }, {});
@@ -401,8 +359,6 @@ export class AgGridColumnAdapter {
                     ? { ...textMatchStyle, ...currentTextMatchStyle }
                     : textMatchStyle;
                 let baseStyles = {};
-                // this is required because otherwise, when AG Grid filters, it refreshed the pivotResultColDef and the base styles get lost
-                // if pivot result col: inherit styles from base column
                 if (this.adaptableApi.columnApi.isPivotResultColumn(columnId)) {
                     const baseColumn = params.column.getColDef()?.pivotValueColumn;
                     if (baseColumn) {
@@ -410,8 +366,6 @@ export class AgGridColumnAdapter {
                         const baseColParams = {
                             ...params,
                             column: baseColumn,
-                            // @ts-ignore
-                            // #derived_pivot_cell_style
                             __pivotResultColumn: params.column,
                         };
                         baseStyles =
@@ -421,7 +375,6 @@ export class AgGridColumnAdapter {
                     }
                 }
                 else {
-                    // inherit styles from user provided colDef property
                     baseStyles = typeof userCellStyle === 'function' ? userCellStyle(params) : userCellStyle;
                 }
                 const result = {
@@ -446,11 +399,9 @@ export class AgGridColumnAdapter {
         this.setColDefProperty(col, 'headerStyle', (userHeaderStyle) => {
             const headerStyleFunc = (params) => {
                 let baseStyles = {};
-                // inherit styles from user provided colDef property
                 baseStyles =
                     typeof userHeaderStyle === 'function' ? userHeaderStyle(params) : userHeaderStyle;
                 if (params.floatingFilter) {
-                    // we NEVER style floating filters
                     return baseStyles;
                 }
                 const columnId = params.column.getColId();
@@ -463,8 +414,6 @@ export class AgGridColumnAdapter {
                     ...this.getFormatColumnHeaderStyle(adaptableColumn, params),
                 };
                 if (result['borderColor']) {
-                    // by default, header cells don't have a border
-                    // if the user defines a border-color, we assume he wants to show a border
                     result['borderWidth'] = `1px`;
                     result['borderStyle'] = 'solid';
                 }
@@ -514,7 +463,6 @@ export class AgGridColumnAdapter {
                         return values;
                     };
                     return {
-                        // we need to pass a function which returns a Promise, that's what AG Grid expects
                         values: fetchSelectItems,
                         formatValue: (value) => valueToLabelMap.get(value) ?? value,
                     };
@@ -570,9 +518,6 @@ export class AgGridColumnAdapter {
             if (!styledColumn || styledColumn.IsSuspended) {
                 return undefined;
             }
-            // Icon Style has its own tooltip vocabulary (`'CellValue'` /
-            // `'IconDescription'`) so we handle it before falling through to the
-            // numeric tooltip branch.
             if (styledColumn.IconStyle && !isUnsupportedColumnDataTypeForIconStyle(abColumn.dataType)) {
                 const iconTokens = styledColumn.IconStyle.ToolTipText ?? [];
                 if (iconTokens.length === 0) {
@@ -594,8 +539,6 @@ export class AgGridColumnAdapter {
                     return trimmed ? trimmed : String(params.value ?? '');
                 };
             }
-            // Rating: `PercentageValue` is `clamp(value, 0, Max) / Max` (not the
-            // column min/max span used by Gradient / Percent Bar).
             if (styledColumn.RatingStyle) {
                 const ratingToolTip = styledColumn.RatingStyle.ToolTipText ?? [];
                 if (ratingToolTip.length === 0) {
@@ -621,10 +564,6 @@ export class AgGridColumnAdapter {
                     return trimmed ? trimmed : String(params.value ?? '');
                 };
             }
-            // Percent Bar, Bullet Chart, Gradient and Range Bar may all expose
-            // `ToolTipText: CellTextOptions`. Range Bar resolves min/max per row
-            // (from `RangeBarStyle.Min` / `RangeBarStyle.Max`) so we treat it
-            // separately rather than re-using the column-wide numeric helpers.
             const tooltipStyle = styledColumn.PercentBarStyle ??
                 styledColumn.BulletChartStyle ??
                 styledColumn.GradientStyle ??
@@ -669,13 +608,6 @@ export class AgGridColumnAdapter {
             };
         });
     }
-    /**
-     * Resolves a Range Bar bound (number / column id / Col-Min / Col-Max /
-     * Col-Avg / Col-Median) into a concrete numeric value for the supplied row.
-     * Mirrors the resolution logic in `RangeBarRenderer.resolveBoundValue` and
-     * is used by the tooltip path. Returns `undefined` when the bound cannot
-     * be resolved (e.g. unknown column id or non-numeric source value).
-     */
     resolveRangeBarBound(bound, abColumn, rowNode) {
         if (bound == undefined) {
             return undefined;
@@ -731,8 +663,6 @@ export class AgGridColumnAdapter {
     }
     setupColumnType(columnSetupInfo) {
         const { col, colId } = columnSetupInfo;
-        // AG Grid introduced since v30.x an inferred cellDataType
-        // the problem is that it breaks the default value formatter and/or editor (especially for Date columns)
         this.setColDefProperty(col, 'type', (original_columnType) => {
             const originalTypes = original_columnType == undefined
                 ? []
@@ -758,7 +688,6 @@ export class AgGridColumnAdapter {
     setupColumnCellDataType(columnSetupInfo) {
         const { col, colId } = columnSetupInfo;
         this.setColDefProperty(col, 'cellDataType', (original_cellDataType) => {
-            // #map_dateString_to_date
             if (original_cellDataType === 'dateString') {
                 errorOnce(`AG Grid: Column '${colId}' specifies cellDataType='dateString' which is no longer supported. It has been automatically replaced with cellDataType='date'. Please update your column definition.`);
                 return 'date';
@@ -768,7 +697,6 @@ export class AgGridColumnAdapter {
     }
     setupColumnHeader({ col }) {
         this.setColDefProperty(col, 'headerValueGetter', (original_headerValueGetter) => {
-            // see #customize_header
             if (!isProvidedByAdaptable(original_headerValueGetter)) {
                 this.adaptableApi.logWarn(`colDef.headerValueGetter is defined for column '${col.getColId()}', and overrides the Adaptable custom header mechanism! We recommend using a ColumnOptions.columnHeader instead!`);
             }
@@ -781,24 +709,19 @@ export class AgGridColumnAdapter {
         if (!useAdaptableFilter) {
             return;
         }
-        // setup Auto Group Column Filter
         if (this.adaptableApi.columnApi.isAutoRowGroupColumn(col.getColId())) {
             if (this.adaptableApi.gridApi.isTreeDataGrid()) {
                 this.setColDefProperty(col, 'filter', (original_filter) => {
                     const autoGroupColumnDef = this.agGridApi.getGridOption('autoGroupColumnDef');
                     if (autoGroupColumnDef?.filter != undefined) {
-                        // we plan to provide a TreeListColumnFilter
-                        // until then, it's the user's responsibility to explicitly set the filter in the provided `autoGroupColumnDef`
                         return original_filter;
                     }
                     else {
-                        // if no filter is explicitly set, we do NOT provide a filter
                         return false;
                     }
                 });
             }
             else {
-                // TODO only set auto group column as filterable if at least one group columns is filterable
                 this.setColDefProperty(col, 'filter', () => {
                     return 'agGroupColumnFilter';
                 });
@@ -807,7 +730,6 @@ export class AgGridColumnAdapter {
                 return;
             }
         }
-        // setup "normal" column filter
         this.setColDefProperty(col, 'filter', (original_filter) => {
             const pivotMode = this.adaptableInstance.isInPivotMode();
             if (!useAdaptableFilter) {
@@ -834,7 +756,6 @@ export class AgGridColumnAdapter {
             typeof userProvidedFilterProp?.handler !== 'function' &&
             !this.adaptableInstance.isInPivotMode();
         if (hasInvalidFilterProp) {
-            // warning is logged in the 'setupColumnFilter' method
             return false;
         }
         const isFloatingFilterDisabled = !colDef.filter ||
@@ -843,15 +764,9 @@ export class AgGridColumnAdapter {
             !this.adaptableApi.filterApi.columnFilterApi.isQuickFilterVisible();
         if (this.adaptableApi.columnApi.isAutoRowGroupColumnForMulti(col.getColId())) {
             this.setColDefProperty(col, 'floatingFilter', (original_floatingFilter) => {
-                // the floating filter for the group column is "inherited" from the base column
-                // via the colDef.filter =  'agGroupColumnFilter'
-                // see #group_inherit_column_filter
-                // https://www.ag-grid.com/javascript-data-grid/grouping-single-group-column/#inherit-row-grouped-columns-filters
-                // https://www.ag-grid.com/javascript-data-grid/grouping-multiple-group-columns/#filtering
                 return original_floatingFilter;
             });
             this.setColDefProperty(col, 'suppressFloatingFilterButton', () => {
-                // hide button for multi column groups
                 return true;
             });
             return;
@@ -882,60 +797,49 @@ export class AgGridColumnAdapter {
                 const { node, value } = params;
                 const mostRelevantFormatColumn = this.adaptableApi.formatColumnApi.internalApi.getMostRelevantFormatColumnForColumn(activeFormatColumnsWithDisplayFormat, abColumn, { node, value });
                 if (!mostRelevantFormatColumn) {
-                    // ALL FormatColumns are conditional and NONE of them are relevant for this row
                     return value;
                 }
-                // Resolve once: a preset name (e.g. 'Dollar') is materialised
-                // into the concrete AdaptableFormat for this render call.
                 const resolvedDisplayFormat = resolveDisplayFormat(mostRelevantFormatColumn.DisplayFormat);
                 if (!resolvedDisplayFormat) {
                     return value;
                 }
                 const formatterOptions = resolvedDisplayFormat.Options;
                 if (resolvedDisplayFormat.Formatter === 'NumberFormatter') {
-                    // change the Number format - if the scope allows it
                     if (this.adaptableApi.columnScopeApi.isColumnInNumericScope(abColumn, mostRelevantFormatColumn.Scope)) {
                         let cellValue = params.value;
                         if (typeof params.value?.toNumber === 'function' &&
                             typeof params.value?.toString === 'function') {
-                            // aggregation values are wrapped in an AG Grid specific object
                             cellValue = params.value.toNumber();
                         }
                         return this.adaptableApi.formatColumnApi.internalApi.getNumberFormattedValue(cellValue, params.node, abColumn, formatterOptions);
                     }
                 }
                 if (resolvedDisplayFormat.Formatter === 'DateFormatter') {
-                    // change the Date format - if the scope allows it
                     if (this.adaptableApi.columnScopeApi.isColumnInDateScope(abColumn, mostRelevantFormatColumn.Scope)) {
                         let cellValue = params.value;
                         if (typeof params.value?.toNumber === 'function' &&
                             typeof params.value?.toString === 'function') {
-                            // aggregation values are wrapped in an AG Grid specific object
                             cellValue = params.value.toString();
                         }
                         return this.adaptableApi.formatColumnApi.internalApi.getDateFormattedValue(cellValue, params.node, abColumn, formatterOptions);
                     }
                 }
                 if (resolvedDisplayFormat.Formatter === 'StringFormatter') {
-                    // change the String format - if the scope allows it
                     if (this.adaptableApi.columnScopeApi.isColumnInTextScope(abColumn, mostRelevantFormatColumn.Scope)) {
                         let cellValue = params.value;
                         if (typeof params.value?.toNumber === 'function' &&
                             typeof params.value?.toString === 'function') {
-                            // aggregation values are wrapped in an AG Grid specific object
                             cellValue = params.value.toString();
                         }
                         return this.adaptableApi.formatColumnApi.internalApi.getStringFormattedValue(cellValue, params.node, abColumn, formatterOptions);
                     }
                 }
-                // should NEVER arrive at this line, but just to be sure
                 return value;
             };
         });
     }
     setupColumnEditable({ col }) {
         this.setColDefProperty(col, 'editable', (original_editable) => {
-            // cell is NOT editable by default
             const editableCallback = (params) => {
                 const getOriginalColDefEditable = () => {
                     if (typeof original_editable === 'function') {
@@ -945,12 +849,10 @@ export class AgGridColumnAdapter {
                         return original_editable;
                     }
                 };
-                // 1. evaluate EditOptions.isCellEditable if provided
                 if (this.adaptableApi.gridApi.internalApi.hasCellEditableAccordingToEditOptions()) {
                     const gridCell = this.adaptableApi.gridApi.getGridCellFromRowNode(params.node, params.column.getColId());
                     return this.adaptableApi.gridApi.internalApi.isCellEditableAccordingToEditOptions(gridCell, getOriginalColDefEditable());
                 }
-                // 2. otherwise, fallback to colDef.editable
                 return getOriginalColDefEditable();
             };
             return editableCallback;
@@ -970,14 +872,9 @@ export class AgGridColumnAdapter {
             const valueSetter = (params) => {
                 const field = params.column.getColDef().field;
                 if (noValidations) {
-                    //TODO also consider the case when userValueSetter is a string
                     if (typeof userValueSetter === 'function') {
                         return userValueSetter(params);
                     }
-                    // we allowed it go reach this point
-                    // just to run isCellEditable
-                    // and since this has already run and we have no other validations
-                    // just assign the new value and exit
                     if (field) {
                         params.data[field] = params.newValue;
                     }
@@ -994,10 +891,6 @@ export class AgGridColumnAdapter {
                 if (cellDataChangedInfo.oldValue === cellDataChangedInfo.newValue) {
                     return true;
                 }
-                /**
-                 * Validate on the future row, with the new value.
-                 * structuredClone fails, it contains functions.
-                 */
                 const newRow = { ...params.node, data: { ...params.node.data } };
                 newRow.data[field] = params.newValue;
                 const cellDataChangeInfoForSyncValidation = {
@@ -1017,7 +910,6 @@ export class AgGridColumnAdapter {
                         onServerValidationCompleted,
                     })();
                 }
-                //TODO also consider the case when userValueSetter is a string
                 if (typeof userValueSetter === 'function') {
                     return userValueSetter(params);
                 }
@@ -1046,7 +938,6 @@ export class AgGridColumnAdapter {
         };
         const comparatorGetter = (propName) => {
             return (userPropertyValue) => {
-                // CustomSort Comparer function takes precedence over CustomSort SortedValues
                 if (customSortComparer) {
                     return customSortComparer.comparer;
                 }
@@ -1056,7 +947,6 @@ export class AgGridColumnAdapter {
                 if (userPropertyValue) {
                     return userPropertyValue;
                 }
-                // for DATE columns we have to use the normalised values (Date objects) to compare
                 if (abColumn.dataType === 'date') {
                     return (valueA, valueB) => {
                         const dateA = getDateValue(valueA);
@@ -1065,13 +955,13 @@ export class AgGridColumnAdapter {
                             return dateA.getTime() - dateB.getTime();
                         }
                         else if (dateA) {
-                            return 1; // consider non-null dates as greater than null/undefined
+                            return 1;
                         }
                         else if (dateB) {
-                            return -1; // consider non-null dates as greater than null/undefined
+                            return -1;
                         }
                         else {
-                            return 0; // both are null/undefined, considered equal
+                            return 0;
                         }
                     };
                 }
@@ -1311,27 +1201,16 @@ export class AgGridColumnAdapter {
         }
         return undefined;
     }
-    /**
-     * The combination of styled column and format cells
-     * This function decides when the two can be merged.
-     */
     getFormatColumnAndStyledColumnCellStyle(column, params) {
         const styledColumn = this.adaptableApi.styledColumnApi.getStyledColumnForColumnId(column.columnId);
         const styledColumnIsActive = !!styledColumn && !styledColumn?.IsSuspended;
-        // Styled-column-derived cell style (e.g. Gradient backgroundColor, plus
-        // any Font/Cell slot the renderer chose to expose).
         const styledColumnStyle = styledColumnIsActive
             ? this.getStyledColumnStyle(styledColumn, column, params)
             : {};
-        // Format Column styles for this cell (may be empty).
         const activeFormatColumnsWithStyle = this.adaptableApi.formatColumnApi.internalApi.getFormatColumnsWithStyleForColumn(column, {
             target: 'cell',
         });
         let formatColumnStyle = this.getFormatColumnCellStyle(column, activeFormatColumnsWithStyle, params);
-        // Per-slice precedence rule: when the Styled Column claims a slice
-        // (via its `Font` or `Cell` slot), Format Column properties belonging
-        // to that slice are stripped and never applied. When the slice is not
-        // claimed, Format Column inherits naturally.
         if (styledColumnIsActive) {
             if (this.styledColumnClaimsFontStyle(styledColumn, column)) {
                 formatColumnStyle = stripFontCssKeys(formatColumnStyle);
@@ -1340,23 +1219,11 @@ export class AgGridColumnAdapter {
                 formatColumnStyle = stripCellBoxCssKeys(formatColumnStyle);
             }
         }
-        // Styled Column wins over Format Column for any overlapping property.
         return {
             ...formatColumnStyle,
             ...styledColumnStyle,
         };
     }
-    /**
-     * Returns true when the active Styled Column declares a `Font` slot
-     * (and therefore claims all Font-slice properties on this column).
-     *
-     * Note: Badge claims **only** `Alignment` from the Font slice — pill
-     * typography is owned per-pill via `PillStyle`, never inherited from a
-     * Format Column. Stripping the whole Font slice when Badge declares
-     * `Alignment` keeps the precedence rule simple and is fine in practice
-     * because Format-Column-derived font styles don't apply to flex rows of
-     * pills anyway.
-     */
     styledColumnClaimsFontStyle(styledColumn, abColumn) {
         const iconFontClaims = !!styledColumn?.IconStyle &&
             !isUnsupportedColumnDataTypeForIconStyle(abColumn.dataType) &&
@@ -1367,10 +1234,6 @@ export class AgGridColumnAdapter {
             hasCellFontStyle(styledColumn?.BadgeStyle?.Font) ||
             iconFontClaims);
     }
-    /**
-     * Returns true when the active Styled Column declares a `Cell` slot
-     * (and therefore claims all Cell-slice properties on this column).
-     */
     styledColumnClaimsCellBoxStyle(styledColumn, abColumn) {
         const iconCellClaims = !!styledColumn?.IconStyle &&
             !isUnsupportedColumnDataTypeForIconStyle(abColumn.dataType) &&
@@ -1382,8 +1245,6 @@ export class AgGridColumnAdapter {
     }
     getFormatColumnHeaderStyle(column, params) {
         if (params.columnGroup) {
-            // FormatColumns are not supported in column groups
-            // YET, see https://github.com/AdaptableTools/adaptable/issues/2947#issuecomment-3062304655
             return {};
         }
         const relevantFormatColumnsWithStyle = this.getRelevantFormatColumnHeaderStyles(column);
@@ -1398,9 +1259,6 @@ export class AgGridColumnAdapter {
         if (params.value == undefined || params.value === '') {
             return style;
         }
-        // Row-kind filtering: defer to the shared row-scope helper so the
-        // cellStyle path (Gradient background, Font/Cell slots) follows the
-        // same `StyledColumn.RowScope` rules as every cellRenderer.
         if (!shouldRenderStyledColumnOnRow(styledColumn, params.node, this.adaptableApi)) {
             return style;
         }
@@ -1417,9 +1275,6 @@ export class AgGridColumnAdapter {
                 const matchingRange = this.adaptableApi.styledColumnApi.internalApi.findRangeForColumn(expandGradientCellRanges(gradientStyle), abColumn, gradientStyleRangeLookupValueType(gradientStyle), colValue);
                 if (matchingRange) {
                     cellBackColor = matchingRange.Color;
-                    // Flip the alpha ramp when (a) it's the negative band of a
-                    // ZeroCentred diverging gradient, OR (b) the user has explicitly
-                    // marked this band as `ReverseGradient` (lower-is-darker).
                     reverseGradient =
                         (!!gradientStyle.ZeroCentred && isNegativeZeroCentredBand(matchingRange)) ||
                             !!matchingRange.ReverseGradient;
@@ -1451,25 +1306,12 @@ export class AgGridColumnAdapter {
             style.paddingTop = 0;
             style.paddingBottom = 0;
         }
-        // Per-slice styling: each Styled Column type can opt into a Font/Cell
-        // slot (declared on the *Style interface) that flows through to cell
-        // CSS. The slots also act as a "claim" against Format Columns — see
-        // `getFormatColumnAndStyledColumnCellStyle`.
-        //
-        // Order is important: we apply the Font slot BEFORE the auto-contrast
-        // override (recomputed below) so that auto-contrast wins on a per-cell
-        // basis when a Gradient cell has a tinted background, even if the user
-        // also set `Font.ForeColor` as a baseline.
         const autoContrastColor = gradientStyle?.AutoContrastText && style.color ? style.color : undefined;
         const iconStyleFontApplies = styledColumn.IconStyle && !isUnsupportedColumnDataTypeForIconStyle(abColumn.dataType);
         const fontSlot = styledColumn.GradientStyle?.Font ??
             styledColumn.PercentBarStyle?.Font ??
             styledColumn.BulletChartStyle?.Font ??
             (iconStyleFontApplies ? styledColumn.IconStyle?.Font : undefined);
-        // Badge's Font slot intentionally skipped here: only `Alignment` is
-        // meaningful on Badge cells and the renderer applies it as flex
-        // `justify-content` on the wrapper (cell `text-align` has no effect on
-        // flex rows of pills). Still claimed for the precedence rule above.
         if (fontSlot) {
             style = { ...style, ...convertAdaptableStyleToCSS(fontSlot) };
         }
@@ -1491,14 +1333,11 @@ export class AgGridColumnAdapter {
             return {};
         }
         const relevantFormatColumnsWithStyle = activeFormatColumnsWithStyle.filter((formatColumn) => {
-            return this.adaptableApi.formatColumnApi.internalApi.formatColumnShouldRenderInCell(formatColumn, abColumn, params.node, params.value, 
-            // @ts-ignore see #derived_pivot_cell_style
-            params.__pivotResultColumn);
+            return this.adaptableApi.formatColumnApi.internalApi.formatColumnShouldRenderInCell(formatColumn, abColumn, params.node, params.value, params.__pivotResultColumn);
         });
         return this.getFormatColumnAdaptableStyle(relevantFormatColumnsWithStyle);
     }
     getFormatColumnAdaptableStyle(formatColumns) {
-        // first has more precedence, then they need to be applied in reverse order
         return formatColumns.reduceRight((style, formatColumn) => {
             const formatColumnStyle = formatColumn.Style
                 ? convertAdaptableStyleToCSS(formatColumn.Style)
@@ -1552,7 +1391,6 @@ export class AgGridColumnAdapter {
         }
     }
     isColGroupDef(columnDefinition) {
-        // @ts-ignore
         return columnDefinition['children'] != null;
     }
     getRelevantFormatColumnHeaderStyles(column) {